Github user wangjiaochun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23225#discussion_r239990587
  
    --- Diff: 
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java ---
    @@ -161,6 +161,10 @@ private void writeSortedFile(boolean isLastFile) {
         final ShuffleInMemorySorter.ShuffleSorterIterator sortedRecords =
           inMemSorter.getSortedIterator();
     
    +    // If there are no sorted records, so we don't need to create an empty 
spill file.
    +    if (!sortedRecords.hasNext()) {
    +      return;
    +    }
    --- End diff --
    
    Okay, I will make the changes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to