dongjoon-hyun commented on a change in pull request #25535: [SPARK-28835][SQL] Introduce TPCDSSchema URL: https://github.com/apache/spark/pull/25535#discussion_r316495246
########## File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSSchema.scala ########## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql + +trait TPCDSSchema { + + private val tableColumns = Map( + "call_center" -> Review comment: @dbaliafroozeh . I'm just wondering the reason you changed the order of tables from the original code. For me, 1. This is not consistent with the original code (It starts with `catalog_page` table.) - This is the best for review. 2. This is not consistent with TPCDS spec document. (Usually, it starts with `Fact Table Definition`: `store_sales` table) - This is the best to compare with TPCDS spec doc. 3. This is not alphabetic. - This is the best for human readability and to lookup on GitHub. While you are here, could you choose one of the above and update this PR? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
