Sure! But the fact was that reviewers objected to a commit in PR A that was approved in PR B, so their objection was simply ignored! Please don't understand me wrong. I'm not saying that it was your responsibility. It is still the responsibility of the reviewers to make sure that this does not happen. Probably this has become a bit harder since we moved to GitHub.
Volker Braun schrieb am Freitag, 26. April 2024 um 00:42:46 UTC+2: > On Tuesday, April 23, 2024 at 6:24:51 PM UTC+2 seb....@gmail.com wrote: > > The problem with this is: if there are commits on a branch that are > reviewed in more than one PR, the question is: does *positive review* > mean *all* or *some* PR's? > > > The review is for a single PR, not for individual commits. > > The positively reviewed PR gets merged, and then you may or may not want > to rebase other PRs on the new develop branch. If you do, then the changes > that were merged disappear from the "files changed" tab of that other PR on > github. Either way, the commits from the positively reviewed PR are added > to the sage codebase. > > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/51ae610f-7527-4581-93bb-dc092f8bfc4bn%40googlegroups.com.
