It can be a problem for later maintainers when the code contains unused vars/functions/etc. I would prune the backend down to the bare minimum, and rename everything so it is consistent.
Clearly the license of magicolor applies to you now, though i wonder if the magicolor license is legitimate, based on its origin? allan On Thu, Jun 21, 2012 at 5:07 PM, Paul Newall <p.newalls at ntlworld.com> wrote: > kodakaio was based on magicolor. I have made the minimum changes to get it > to work. That's why so many references to magicolor remain. I'm not sure > what the right approach is? If I have a function that is identical to the > function in magicolor, it might be good for it to have the same name? > I guess if I have changed a function, it ought to have a new name. > The kodakaio scanners have nothing significant in common with the magicolor > scanners. > > I chose not to use SNMP for auto detecting scanners because that would mean > installing a version of the SNMP library that was not readily available in > ubuntu repositories. I used cups instead. Since the kodak AiO devices have > printers built in and can only print from linux using cups it's a good > assumption that users will generally have cups installed. > But I left the SNMP functions in the backend just in case the cups method > did not work out OK. > I think it would be better if I removed them now. > > It seems I forgot to add kodakaio to ALL_BACKENDS in configure, so I should > fix that. > > I have a couple of questions: > Regarding the SANE exception to the GPL. Is it generally desirable to have > that exception for backends? it seems to be more likely to be relevant for > the sanei libraries? In the case of kodakaio, it has lots of code from > magicolor, and magicolor does not have the exception, does that mean that > kodakaio should not have the exception? > > Is it the right thing to do to keep attaching versions of my patch to emails > to this mailing list? or would it be better to point people to a website > where they can download it? > > Thank you for all the comments, > Paul Newall > > ----- Original Message ----- From: "m. allan noah" <kitno455 at gmail.com> > To: "Paul Newall" <p.newalls at ntlworld.com> > Cc: <sane-devel at lists.alioth.debian.org> > Sent: Thursday, June 21, 2012 12:56 AM > > Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices - > adding tosane-backends > > > Does kodak use SNMP? If not, it would be cleaner to remove that code. > Also, this contains lots of references to magicolor in macro and > variable names. Does it depend on magicolor? Are these machines > derivatives of magicolor scanners? > > allan > > On Wed, Jun 20, 2012 at 6:41 PM, Paul Newall <p.newalls at ntlworld.com> > wrote: >> >> A new patch is attached. >> This patch should modify the current git to add kodakaio for the kodak ESP >> nnnn, ESP Cnnn, and Hero series of AiOs >> >> >> Regards, >> Paul Newall >> >> ----- Original Message ----- From: "Paul Newall" <p.newalls at ntlworld.com> >> To: <sane-devel at lists.alioth.debian.org> >> Sent: Sunday, June 17, 2012 9:21 PM >> Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices - >> adding tosane-backends >> >> >> >>> I had a few suggestions for improvements. In a few days I will made a new >>> version of the patch. >>> Any other suggestions would be gratefully received. >>> >>> Regards, >>> Paul Newall >>> >>> ----- Original Message ----- From: "Paul Newall" <p.newalls at ntlworld.com> >>> To: <sane-devel at lists.alioth.debian.org> >>> Sent: Sunday, June 17, 2012 12:10 AM >>> Subject: [sane-devel] New backend kodakaio for kodak AiO devices - adding >>> tosane-backends >>> >>> >>>> I have this backend (kodakaio) working. >>>> And tested by a few users, using a cut down version of sane-backends. >>>> Now I have made a patch for the git version cloned today from >>>> git://git.debian.org/sane/sane-backends.git >>>> The patch is attached >>>> Does anyone with write access to git want to add this backend? >>>> >>>> Summary of the changes I made: >>>> Added the backend: kodakaio.c .h .conf .man .desc >>>> Modified: configure.in (added detection of a cups installation since >>>> this >>>> is >>>> used for autodetection on the network) >>>> Modified: makefile.am in backends and in docs. Modified: authors, >>>> dll.conf >>>> >>>> I think that's all the changes. >>>> >>>> Regards, >>>> Paul Newall >>>> >>>> >>>> >>> >>> >>> >>> >>> -------------------------------------------------------------------------------- >>> >>> >>>> -- >>>> sane-devel mailing list: sane-devel at lists.alioth.debian.org >>>> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel >>>> Unsubscribe: Send mail with subject "unsubscribe your_password" >>>> to sane-devel-request at lists.alioth.debian.org >>> >>> >>> >> >> -- >> sane-devel mailing list: sane-devel at lists.alioth.debian.org >> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel >> Unsubscribe: Send mail with subject "unsubscribe your_password" >> to sane-devel-request at lists.alioth.debian.org > > > > > -- > "The truth is an offense, but not a sin" > > -- > sane-devel mailing list: sane-devel at lists.alioth.debian.org > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel > Unsubscribe: Send mail with subject "unsubscribe your_password" > ? ? ? ? ? ?to sane-devel-request at lists.alioth.debian.org -- "The truth is an offense, but not a sin"