core.git: svx/source
svx/source/sdr/overlay/overlayselection.cxx | 98 +---
1 file changed, 48 insertions(+), 50 deletions(-)
New commits:
commit 7b1405689d4246e0e37e8759f03e1962af964cec
Author: Noel Grandin
AuthorDate: Fri Apr 19 22:56:04 2024 +0200
Commit: Noel Grandin
CommitDate: Sat Apr 20 07:42:08 2024 +0200
reduce the number of drawing primitives we create in OverlaySelection
and flatten it a little
Change-Id: I3377f832658c504a2541c6994f7386adad06b0e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166321
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/svx/source/sdr/overlay/overlayselection.cxx
b/svx/source/sdr/overlay/overlayselection.cxx
index 89ef1202e125..9644650263c9 100644
--- a/svx/source/sdr/overlay/overlayselection.cxx
+++ b/svx/source/sdr/overlay/overlayselection.cxx
@@ -92,63 +92,61 @@ namespace sdr::overlay
drawinglayer::primitive2d::Primitive2DContainer
OverlaySelection::createOverlayObjectPrimitive2DSequence()
{
drawinglayer::primitive2d::Primitive2DContainer aRetval;
-const sal_uInt32 nCount(getRanges().size());
+const sal_uInt32 nCount(maRanges.size());
-if(nCount)
-{
-// create range primitives
-const bool bInvert(OverlayType::Invert == maLastOverlayType);
-basegfx::BColor aRGBColor(getBaseColor().getBColor());
-aRetval.resize(nCount);
+if(!nCount)
+return aRetval;
-if(bInvert)
-{
-// force color to white for invert to get a full invert
-aRGBColor = basegfx::BColor(1.0, 1.0, 1.0);
-}
+// create range primitives
+const bool bInvert(OverlayType::Invert == maLastOverlayType);
+basegfx::BColor aRGBColor(getBaseColor().getBColor());
+if(bInvert)
+{
+// force color to white for invert to get a full invert
+aRGBColor = basegfx::BColor(1.0, 1.0, 1.0);
+}
-for(sal_uInt32 a(0);a < nCount; a++)
-{
-const basegfx::B2DPolygon
aPolygon(basegfx::utils::createPolygonFromRect(maRanges[a]));
-aRetval[a] =
-new
drawinglayer::primitive2d::PolyPolygonColorPrimitive2D(
-basegfx::B2DPolyPolygon(aPolygon),
-aRGBColor);
-}
+basegfx::B2DPolyPolygon aPolyPolygon;
+aPolyPolygon.reserve(nCount);
+for(sal_uInt32 a(0);a < nCount; a++)
+
aPolyPolygon.append(basegfx::utils::createPolygonFromRect(maRanges[a]));
+aRetval.append(
+new drawinglayer::primitive2d::PolyPolygonColorPrimitive2D(
+std::move(aPolyPolygon),
+aRGBColor));
-if(bInvert)
+if(bInvert)
+{
+// embed all in invert primitive
+aRetval = drawinglayer::primitive2d::Primitive2DContainer {
+new drawinglayer::primitive2d::InvertPrimitive2D(
+std::move(aRetval))
+};
+}
+else if(OverlayType::Transparent == maLastOverlayType)
+{
+// embed all rectangles in transparent paint
+const double fTransparence(mnLastTransparence / 100.0);
+drawinglayer::primitive2d::Primitive2DReference
aUnifiedTransparence(
+new
drawinglayer::primitive2d::UnifiedTransparencePrimitive2D(
+std::move(aRetval),
+fTransparence));
+
+if(mbBorder)
{
-// embed all in invert primitive
-aRetval = drawinglayer::primitive2d::Primitive2DContainer {
-new drawinglayer::primitive2d::InvertPrimitive2D(
-std::move(aRetval))
-};
+basegfx::B2DPolyPolygon
aBorderPolyPolygon(impCombineRangesToPolyPolygon(maRanges));
+drawinglayer::primitive2d::Primitive2DReference
aSelectionOutline(
+new
drawinglayer::primitive2d::PolyPolygonHairlinePrimitive2D(
+std::move(aBorderPolyPolygon),
+aRGBColor));
+
+// add both to result
+aRetval = drawinglayer::primitive2d::Primitive2DContainer
{ aUnifiedTransparence, aSelectionOutline };
}
-else if(OverlayType::Transparent == maLastOverlayType)
+else
{
-// embed all rectangles in transparent paint
-const double fTransparence(mnLastTransparence / 100.0);
-
[Bug 160741] remember Sort Options
https://bugs.documentfoundation.org/show_bug.cgi?id=160741 --- Comment #1 from Sam --- Correction: the default Sort Options may be different, but the fact remains that the ones you select will not be remembered. Note that the Sort Criteria are remembered. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160741] New: remember Sort Options
https://bugs.documentfoundation.org/show_bug.cgi?id=160741 Bug ID: 160741 Summary: remember Sort Options Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: arnet...@bluewin.ch Description: There are two Sort Options that are ticked by default: - Include formats - Include boundary row(s) containing only images If you change any of these options, they may not be remembered next time you open Sort Options. Steps to Reproduce: 1. go to Data > Sort > Options 2. select any other options and click OK 3. apply a sort 4. go to Data > Sort > Options again Actual Results: The previously entered sort options are not remembered; the selection reverts to the two default options: - Include formats - Include boundary row(s) containing only images Expected Results: The previously entered sort options are remembered. Reproducible: Always User Profile Reset: No Additional Info: Version: 24.2.2.2 (X86_64) / LibreOffice Community Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01 CPU threads: 4; OS: macOS 12.7.4; UI render: Skia/Raster; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160740] New: cell styles in protected sheets lose background colours
https://bugs.documentfoundation.org/show_bug.cgi?id=160740 Bug ID: 160740 Summary: cell styles in protected sheets lose background colours Product: LibreOffice Version: 24.2.2.2 release Hardware: x86-64 (AMD64) OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: arnet...@bluewin.ch Created attachment 193764 --> https://bugs.documentfoundation.org/attachment.cgi?id=193764=edit protected sheet with background colours in cell styles Background colours built into cell styles should not be lost when protecting a sheet. In the attached sample file, Sheet1 is protected. Go to Tools, then uncheck Protect Sheet … Background colours built into the cell styles will reoccur. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160551] Lossless export to .webm causes Hang
https://bugs.documentfoundation.org/show_bug.cgi?id=160551 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160553] FILEOPEN RTF Section break between tables is not imported
https://bugs.documentfoundation.org/show_bug.cgi?id=160553 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160541] Quickfind sidebar: present results with some indication of location in document
https://bugs.documentfoundation.org/show_bug.cgi?id=160541 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160539] Quickfind sidebar: Words are cut-off at beginning and end
https://bugs.documentfoundation.org/show_bug.cgi?id=160539 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160540] Quickfind sidebar: find results all show as equal sized
https://bugs.documentfoundation.org/show_bug.cgi?id=160540 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160538] Quickfind sidebar: ordering of results, Text in fields and frames comes first
https://bugs.documentfoundation.org/show_bug.cgi?id=160538 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160531] improved way of moving cells
https://bugs.documentfoundation.org/show_bug.cgi?id=160531 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157069] Calc formatting border options won't display correctly with Colibre icons on the side bar.
https://bugs.documentfoundation.org/show_bug.cgi?id=157069 --- Comment #3 from QA Administrators --- Dear darkmetal262, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160739] Raise a matrix to an exponential with Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=160739 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160739] Raise a matrix to an exponential with Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=160739 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157069] Calc formatting border options won't display correctly with Colibre icons on the side bar.
https://bugs.documentfoundation.org/show_bug.cgi?id=157069 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 51256] FILEOPEN: hang on DOC with hidden table that opens differently in MS Office 2003 and 2010/2013
https://bugs.documentfoundation.org/show_bug.cgi?id=51256 --- Comment #26 from QA Administrators --- Dear Rusbearing, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 34050] Particular ODT saved in web layout causes hang when switched to normal view
https://bugs.documentfoundation.org/show_bug.cgi?id=34050 --- Comment #27 from QA Administrators --- Dear pmvd, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 132111] Initial cell's number format in Writer table is reported wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=132111 --- Comment #4 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 121407] nested table layout error
https://bugs.documentfoundation.org/show_bug.cgi?id=121407 --- Comment #20 from QA Administrators --- Dear 564398053, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 120464] Creating a new Heading style from one assigned to Chapter Numbering does not inherit outline level
https://bugs.documentfoundation.org/show_bug.cgi?id=120464 --- Comment #6 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 119697] FILEOPEN DOCX Text box Shape (with absolute position to column in Word?) is positioned incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=119697 --- Comment #20 from QA Administrators --- Dear Timur, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 113811] FILESAVE: dialogs are not preserved in flat ODS file
https://bugs.documentfoundation.org/show_bug.cgi?id=113811 --- Comment #12 from QA Administrators --- Dear Mátyás Jani, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160739] Raise a matrix to an exponential with Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=160739 --- Comment #3 from xhertan --- Created attachment 193763 --> https://bugs.documentfoundation.org/attachment.cgi?id=193763=edit this is the excel file that runs good on WPS and MS excel but ails on LO Calc -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160739] Raise a matrix to an exponential with Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=160739 --- Comment #2 from xhertan --- Created attachment 193762 --> https://bugs.documentfoundation.org/attachment.cgi?id=193762=edit file that works in MS Excel and fails in LO Calc -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160739] Raise a matrix to an exponential with Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=160739 ady changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from ady --- In the bug report page, there is a link that says "Add an attachment". Please use it to attach a file that works for you in other spreadsheet tools. Please be aware that it will be publicly available, so, using one of those other spreadsheet tools, you might want to eliminate any private or sensitive information and save that as a copy of your original file; then attach such minimal copy. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160714] Exporting ODP file to PDF in Impress does not export PDF figures correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=160714 --- Comment #6 from Patrick Luby (volunteer) --- (In reply to LeonH from comment #5) > I have noticed this does not happen with all PDF figures. It depends on the > source of the PDF. > > For example, I have always seen this happen as I used the same source to > produce my PDF figures, I used ROOT framework for C++ to produce them (as > the one I uploaded here as an example). > > I have tested now with some PDF figures I downloaded from the internet and > some seem to work as expected, but for some the background color of the > figure turns from white to black. > > I do not know what is the difference in all these PDF exports, and if this > is an issue of LO not supporting different PDF formats, or the sources (such > as ROOT) not exporting correctly. I admit I haven't figured out how to fix this bug yet, but I have done some debugging in my local LibreOffice build and I think your bug is just a miscalculation of the X and Y coordinates of where the embedded PDF is placed with the exported PDF. I think the "white to black" bug you found is a different bug. Can you file a bug for one of those and add me to the cc list? I unzipped your attached .odp file and I could open the embedded .pdf without a problem in the macOS Preview application. It is usually fussier than Adobe Acrobat so I think the source .pdf that you put the document is OK. After that, I found that I can run LibreOffice from the command line with the following environment variable, and that will export the PDF without compression so I could edit the exported .pdf file directly: export VCL_DEBUG_DISABLE_PDFCOMPRESSION=1 With an uncompressed, exported PDF file, I have been manually changing embedded PDF to see if I can get the image to move to the left. I have had some success with that and narrowed down the cause to the following lines in the exported PDF: 8 0 obj << /Type /XObject /Subtype /Form /Matrix [ 0 -1 1 0 0 387 ] /Resources <>/ExtGState 10 0 R/Font<>/Pattern<>>> /BBox [ 0 0 387 567 ] /Filter/FlateDecode /Length 25435>> I was able to edit the /Matrix and /BBox attributes in the above line to get the image to move left. Hence why I think LibreOffice is just miscalculating the position. Note: LibreOffice uses the /Matrix and /BBox attributes to write the embedded PDF "inline" in the exported PDF. The harder problem is where in the LibreOffice code does the positioning coordinates get calculated? I'll start seeing if I can trace the code back to where Impress tells the export to PDF code to "place this embedded PDF at X, Y". -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160739] New: Raise a matrix to an exponential with Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=160739 Bug ID: 160739 Summary: Raise a matrix to an exponential with Calc Product: LibreOffice Version: 7.6.6.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jjad...@yahoo.com Description: I am trying to raise a matrix to a high power using Calc but that's throwing the "Err:523". the same file worked perfectly fine in MS Excel and WSP. I checked the recursive formula option and it is active. I installed the version 24 and the error persists. LibreOffice Version: 7.6.6.3 OS: Linux Steps to Reproduce: 1. Fill the cells A2:C4 with a square (3x3) matrix (Mo) values 2. Fill Cell E2 with the power value. Let's say E2=7 3. Fille Cell G2 with the power counter recursive formula counter: =IF(ISNUMBER(G2),IF(G2=E2,TEXT(G2,"0"),G2+1),IF(VALUE(G2)=E2,G2,1)) 4. Select Fill the Output Matrix cells H2:J4 with the array formula: =IF(ISNUMBER(G2),IF(G2=1,A2:C4,MMULT(A2:C4,H2:J4)),H2:J4) 5. This is an array formula, need to finish with CTRL+SHIFT+ENTER Actual Results: Err:523 Expected Results: Mew Matrix M = exp(Mo,7) Reproducible: Always User Profile Reset: Yes Additional Info: I tried the same example on version LO 24 with the same error results. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159625] Can NOT un-check [allow to split paragraph]
https://bugs.documentfoundation.org/show_bug.cgi?id=159625 --- Comment #8 from Paolo Benvenuto --- Confirmed in Version: 24.2.2.2 (X86_64) / LibreOffice Community Build ID: 420(Build:2) CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-US (C.UTF-8); UI: en-US Ubuntu package version: 4:24.2.2~rc2-0ubuntu0.22.04.1~lo1 Calc: threaded on ubuntu 22.04 Both checkin and unchecking the "Allow to split paragraph" check box aren't retained, in both paragraph properties and paragraph style Attacching a one-paragraph document: you can test yourself: - change the paragraph property and close the dialog -> next time you open the dialog you see that nothing has changed - same thing with the paragraph style -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159625] Can NOT un-check [allow to split paragraph]
https://bugs.documentfoundation.org/show_bug.cgi?id=159625 --- Comment #7 from Paolo Benvenuto --- Created attachment 193761 --> https://bugs.documentfoundation.org/attachment.cgi?id=193761=edit document where "Allow to split paragraph" paragraph property cannot be changed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160738] New: search and replace widget reset the current selection only option after saving
https://bugs.documentfoundation.org/show_bug.cgi?id=160738 Bug ID: 160738 Summary: search and replace widget reset the current selection only option after saving Product: LibreOffice Version: 24.2.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: myway...@gmail.com Description: Search and Replace widget reset the current selection only option after saving (even if the dialogue widget is open) caused data loss in my case In libreoffice calc I didn't try the other Apps. Steps to Reproduce: 1.doing search and replace with current selection only enabled(selected) 2. save the document while the dialogue still open 3. the current selection option status change to disable (deselected) 4. loss of date if I don't keep track of it and do a replace without noticing (it happend with me) Actual Results: current selection only disabled on save (deselected) Expected Results: current selection only remain enabled (selected) at least as long as the dialogue is widget is open Reproducible: Always User Profile Reset: No Additional Info: Version: 24.2.2.2 (x86) / LibreOffice Community Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01 CPU threads: 16; OS: Windows 10.0 Build 19044; UI render: default; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160734] Support exporting to Markdown
https://bugs.documentfoundation.org/show_bug.cgi?id=160734 --- Comment #4 from NamelessGO --- > Markdown support. But as you said, the challenge is picking a flavour Would propose Markdown-it due to being 100% compliant with CommonMark, secure by Google, and extensible with plugins https://github.com/markdown-it/markdown-it Python port: https://markdown-it-py.readthedocs.io/en/latest/# Experimental Rust port: https://github.com/chrisjsewell/markdown-it-pyrs Table and strikethrough from GFM flavour are implemented natively, and more features can be added via extensions https://markdown-it-py.readthedocs.io/en/latest/plugins.html -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160734] Support exporting to Markdown
https://bugs.documentfoundation.org/show_bug.cgi?id=160734 --- Comment #4 from NamelessGO --- > Markdown support. But as you said, the challenge is picking a flavour Would propose Markdown-it due to being 100% compliant with CommonMark, secure by Google, and extensible with plugins https://github.com/markdown-it/markdown-it Python port: https://markdown-it-py.readthedocs.io/en/latest/# Experimental Rust port: https://github.com/chrisjsewell/markdown-it-pyrs Table and strikethrough from GFM flavour are implemented natively, and more features can be added via extensions https://markdown-it-py.readthedocs.io/en/latest/plugins.html -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 81956] FILEOPEN: Z-ordering of GroupShape not preserved properly for docx file.
https://bugs.documentfoundation.org/show_bug.cgi?id=81956 Justin L changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | Status|NEW |ASSIGNED --- Comment #14 from Justin L --- This "hack a fix" patchset 1 works for this document, but I'm sure it will have bad side effects. I need to have it apply to a groupset only if not in header/footer (since in that case everything should be backgrounded). -- You are receiving this mail because: You are the assignee for the bug.
[Bug 140616] FILEOPEN DOCX: paragraph style ignores rPr nested inside pPr (hand-crafted document) and fails to override with para marker highlight
https://bugs.documentfoundation.org/show_bug.cgi?id=140616 Justin L changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #13 from Justin L --- (In reply to Commit Notification from comment #12) > tdf#140616 ApplyParagraphMarkFormatToNumbering: including highlight This patch fixes "and fails to override with para marker highlight" It worked earlier if there was no highlight in the style, but only in the marker (because then highlight == COL_TRANSPARENT). Now the marker will override any inherited-from-styles highlighting. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107830] [META] DOCX (OOXML) paragraph-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107830 Bug 107830 depends on bug 140616, which changed state. Bug 140616 Summary: FILEOPEN DOCX: paragraph style ignores rPr nested inside pPr (hand-crafted document) and fails to override with para marker highlight https://bugs.documentfoundation.org/show_bug.cgi?id=140616 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160601] [UI] Slide sorter starts with hard coded number of slides per row (5 on Linux, 4 on Windows it seems) - no mean to set a preferred number
https://bugs.documentfoundation.org/show_bug.cgi?id=160601 --- Comment #12 from Commit Notification --- Cor Nouws committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7c2ed9919d6d9d286d9062b91577d6bb2b7de8aa tdf#160601 add expert option for default slides per row in slide sorter It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160601] [UI] Slide sorter starts with hard coded number of slides per row (5 on Linux, 4 on Windows it seems) - no mean to set a preferred number
https://bugs.documentfoundation.org/show_bug.cgi?id=160601 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
core.git: officecfg/registry sd/source
officecfg/registry/schema/org/openoffice/Office/Impress.xcs |7 +++
sd/source/ui/view/frmview.cxx |3 ++-
2 files changed, 9 insertions(+), 1 deletion(-)
New commits:
commit 7c2ed9919d6d9d286d9062b91577d6bb2b7de8aa
Author: Cor Nouws
AuthorDate: Thu Apr 11 21:01:18 2024 +0200
Commit: Justin Luth
CommitDate: Sat Apr 20 00:34:46 2024 +0200
tdf#160601 add expert option for default slides per row in slide sorter
Change-Id: Ib122ad0fce8159c1ceb092bcc65a59ba1ad23bc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166174
Reviewed-by: Justin Luth
Tested-by: Jenkins
diff --git a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs
b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs
index e6bda773491f..699cdc752a2f 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs
@@ -423,6 +423,13 @@
true
+
+
+ Default number of slides per row in slide sorter.
+ Sorter slides per row
+
+4
+
diff --git a/sd/source/ui/view/frmview.cxx b/sd/source/ui/view/frmview.cxx
index 61b7bfdf2ecf..50cf9d636396 100644
--- a/sd/source/ui/view/frmview.cxx
+++ b/sd/source/ui/view/frmview.cxx
@@ -41,6 +41,7 @@
#include
#include
#include
+#include
using namespace ::com::sun::star;
using namespace ::com::sun::star::uno;
@@ -222,7 +223,7 @@ FrameView::FrameView(SdDrawDocument* pDrawDoc, FrameView*
pFrameView /* = NULL *
SetEliminatePolyPoints(false);
mbDoubleClickTextEdit = false;
mbClickChangeRotation = false;
-mnSlidesPerRow = 4;
+mnSlidesPerRow =
officecfg::Office::Impress::Misc::SorterSlidesPerRow::get();
{
bool bUseContrast =
Application::GetSettings().GetStyleSettings().GetHighContrastMode();
[Bug 140616] FILEOPEN DOCX: paragraph style ignores rPr nested inside pPr (hand-crafted document) and fails to override with para marker highlight
https://bugs.documentfoundation.org/show_bug.cgi?id=140616 --- Comment #12 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3b7ffa204c6d04640b5e2f4d4c6b6b4a03fd26c8 tdf#140616 ApplyParagraphMarkFormatToNumbering: including highlight It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/qa sw/source
sw/qa/extras/ooxmlexport/ooxmlexport14.cxx |1 +
sw/source/core/text/txtfld.cxx |2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 3b7ffa204c6d04640b5e2f4d4c6b6b4a03fd26c8
Author: Justin Luth
AuthorDate: Thu Apr 18 04:00:05 2024 -0400
Commit: Justin Luth
CommitDate: Sat Apr 20 00:18:17 2024 +0200
tdf#140616 ApplyParagraphMarkFormatToNumbering: including highlight
I was concerned that I might override highlights
set in numbering.xml but in that case
pFormat && pFormat->hasItem(RES_CHRATR_HIGHLIGHT)
so pCleanSet no longer hasItem.
(see num3n.docx and TestDoc_highlight2.docx)
Note: must use Word 2010+ to see numbering.xml highlights!!
This is strictly a visual thing. Unit testing has traditionally
used magic tile rendering x,y positions to check the color,
which seems completely untrustworthy.
Change-Id: I026252f127107e4782d08f72bfd5e2a412142111
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166303
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
index 6528b093fd57..ba70a335ca09 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
@@ -965,6 +965,7 @@ CPPUNIT_TEST_FIXTURE(Test, testHighlightEdit_numbering)
xmlDocUniquePtr pXmlStyles = parseExport("word/styles.xml");
assertXPath(pXmlStyles,
"//w:style[@w:styleId='CustomParaStyleHighlightGreen']/w:rPr/w:highlight"_ostr,
"val"_ostr, "green");
+// Visually, the last bullet point's text should be green-highlighted (but
the bullet point itself shouldn't)
if (bWasExportToShade)
{
diff --git a/sw/source/core/text/txtfld.cxx b/sw/source/core/text/txtfld.cxx
index 84f32e30971f..55e439096f3d 100644
--- a/sw/source/core/text/txtfld.cxx
+++ b/sw/source/core/text/txtfld.cxx
@@ -409,7 +409,7 @@ static void
checkApplyParagraphMarkFormatToNumbering(SwFont* pNumFnt, SwTextForm
if (oFontBackColor)
pNumFnt->SetBackColor(oFontBackColor);
-if (aHighlight != COL_TRANSPARENT)
+if (aHighlight != COL_TRANSPARENT &&
!pCleanedSet->HasItem(RES_CHRATR_HIGHLIGHT))
pNumFnt->SetHighlightColor(aHighlight);
}
[Bug 160736] FILESAVE, Options not saved when closing the solver window
https://bugs.documentfoundation.org/show_bug.cgi?id=160736 m_a_riosv changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m_a_riosv --- *** This bug has been marked as a duplicate of bug 158735 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160737] LibreOffice Calc Opens New Worksheet with the number 4 Character being Repeatedly Entered
https://bugs.documentfoundation.org/show_bug.cgi?id=160737 ady changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|UNCONFIRMED |RESOLVED --- Comment #2 from ady --- (In reply to rmschaller from comment #0) > appeared to clear up the problem for now. FWIW, this sounds as if some "dirty" key in your keyboard got accidentally stuck. If that is not the case, I guess it would not be easy for anyway to reproduce. For now, I am setting this report as INSUFFICIENT DATA. If this happens again, please re-set the report to UNCONFIRMED and add any relevant info. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160726] SVG: feComposite: nothing displayed when not using 'use'
https://bugs.documentfoundation.org/show_bug.cgi?id=160726 m_a_riosv changed: What|Removed |Added Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEW --- Comment #2 from m_a_riosv --- Reproducible, and more, the second one is visualized in black no in color like in Firefox. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 0957ee9f5d379c80fca4027c187b471118d0490d CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160737] LibreOffice Calc Opens New Worksheet with the number 4 Character being Repeatedly Entered
https://bugs.documentfoundation.org/show_bug.cgi?id=160737 --- Comment #1 from rmschal...@gmail.com --- Created attachment 193760 --> https://bugs.documentfoundation.org/attachment.cgi?id=193760=edit mov file showing the screen behavior -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160737] New: LibreOffice Calc Opens New Worksheet with the number 4 Character being Repeatedly Entered
https://bugs.documentfoundation.org/show_bug.cgi?id=160737
Bug ID: 160737
Summary: LibreOffice Calc Opens New Worksheet with the number 4
Character being Repeatedly Entered
Product: LibreOffice
Version: 7.4.7.2 release
Hardware: ARM
OS: other
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Calc
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: rmschal...@gmail.com
Description:
Upon opening a new worksheet, the numeric character ("4") is auto-repeated
without any interaction with the keyboard. tried closing down Calc and
restarting but the problem persisted. Had to reboot device and that appeared
to clear up the problem for now.
Steps to Reproduce:
1.launch a new worksheet in LibreOffice Calc
2.
3.
Actual Results:
A new worksheet appears as expected but the number "4" is auto-repeated in cell
A1 with out any keyboard interaction, not expected!
Expected Results:
A blank sheet should appear without any characters being entered into any of
the cells
Reproducible: Always
User Profile Reset: No
Additional Info:
I've added screen capture video showing the behavior
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 136339] Standard (aka "Reset to Parent") button in paragraph styles doesn't function for the highlighting tab
https://bugs.documentfoundation.org/show_bug.cgi?id=136339 --- Comment #5 from Glen Campbell --- I started to work on this several days ago and I could reproduce it at that time. I have since updated to the latest in the code base and I can not reproduce this now. That is, pressing the "reset to parent" button causes the yellow highlighting to reset to white and the character color remains black. I hate to say something is "magically fixed", but perhaps someone did some unrelated work that accomplished the fix here. stephane.guil...@libreoffice.org - could you please retest to confirm and close if so? Of course, the "standard" button is now the "reset to parent" button. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160686] "Left Page" and "Right Page" are nonsensical and should be removed
https://bugs.documentfoundation.org/show_bug.cgi?id=160686 --- Comment #12 from David --- (In reply to Eyal Rozenberg from comment #11) > (In reply to David from comment #10) > The use case you described in that comment has nothing to do with a > distinction between "Left" and "Right" pages, nor between "Odd" and "Even" > pages; nor would you use the "Left Page" and "Right Page" styles for that > case - you would use a page style appropriate for the first page of a > chapter. I am not against this being possible! I am against the definition > of the two "Left Page" and "Right Page" styles. My use case has everything to do with "Left Page" and "Right Page" styles. I want the new chapter or section to start specifically on the right side. > I would call them styles you would not use for your use case. I mean, I can > take the "HTML" page style and use that for the first page of my chapter, > too; it's an arbitrary choice. Yes you can, but since the "Right Page" style already has the Page layout option set to "Right only," why would I want to go ahead and configure another style for the same option when that one's already set to correctly start the new section or chapter on only the right page by default? > > Maybe because no viable, better alternative to my real-life use case has yet > > been provided. > > Like I said above - create a new custom page style, say "Chapter Title"; set > its Next Style to Default Page Style (or whatever page style you want to use > for that chapter), and you're all set. Yes, after I set the page layout to "Right only." So why should I have to set the options for another style to be what I want when the styles there already have the option set? What you just suggested will not put my new page on the right side by default, with a blank page on the left side if necessary, and that is exactly what I want. And I don't have a problem with the page numbers being correct either. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 143123] Port Java SDK examples to Python
https://bugs.documentfoundation.org/show_bug.cgi?id=143123 --- Comment #11 from Commit Notification --- zeph committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/55b0ddf119714ce1221ceb098a8329de2716c448 tdf#143123 Port ChartInDraw / ChartInWriter examples to Python It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: odk/examples odk/Package_examples.mk
odk/Package_examples.mk |3
odk/examples/DevelopersGuide/Charts/python/CalcHelper.py| 15 -
odk/examples/DevelopersGuide/Charts/python/ChartHelper.py | 114 +++
odk/examples/DevelopersGuide/Charts/python/ChartInDraw.py | 177
odk/examples/DevelopersGuide/Charts/python/ChartInWriter.py | 77 +
odk/examples/DevelopersGuide/Charts/python/Helper.py| 13
6 files changed, 396 insertions(+), 3 deletions(-)
New commits:
commit 55b0ddf119714ce1221ceb098a8329de2716c448
Author: zeph
AuthorDate: Sun Mar 17 16:17:14 2024 -0700
Commit: Hossein
CommitDate: Fri Apr 19 22:18:25 2024 +0200
tdf#143123 Port ChartInDraw / ChartInWriter examples to Python
Ported two more SDK examples ChartInDraw and ChartInWriter from Java to
Python.
ChartInCalc and helper classes which contain additional helper methods
were ported in a previous patch.
Change-Id: Idffa0c07282dfc2c0f09ec5a9959f1db34a1d9a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165088
Tested-by: Jenkins
Tested-by: Hossein
Reviewed-by: Hossein
diff --git a/odk/Package_examples.mk b/odk/Package_examples.mk
index 87bad187b91b..f575e70aae1e 100644
--- a/odk/Package_examples.mk
+++ b/odk/Package_examples.mk
@@ -49,7 +49,10 @@ $(eval $(call
gb_Package_add_files_with_dir,odk_examples,$(SDKDIRNAME)/examples,
DevelopersGuide/Charts/java/SelectionChangeListener.java \
DevelopersGuide/Charts/java/bullet.gif \
DevelopersGuide/Charts/python/CalcHelper.py \
+DevelopersGuide/Charts/python/ChartHelper.py \
DevelopersGuide/Charts/python/ChartInCalc.py \
+DevelopersGuide/Charts/python/ChartInDraw.py \
+DevelopersGuide/Charts/python/ChartInWriter.py \
DevelopersGuide/Charts/python/Helper.py \
DevelopersGuide/Charts/python/bullet.gif \
DevelopersGuide/Components/Addons/JobsAddon/Addons.xcu \
diff --git a/odk/examples/DevelopersGuide/Charts/python/CalcHelper.py
b/odk/examples/DevelopersGuide/Charts/python/CalcHelper.py
index dcbb0b8e8740..8bc427daa3fb 100644
--- a/odk/examples/DevelopersGuide/Charts/python/CalcHelper.py
+++ b/odk/examples/DevelopersGuide/Charts/python/CalcHelper.py
@@ -1,3 +1,12 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
import math
import random
import sys
@@ -140,10 +149,10 @@ class CalcHelper:
try:
# get the sheet to insert the chart
sheet = self.get_data_sheet()
-cell_range = sheet[0 : row_count - 1, 0 : column_count - 1]
+cell_range = sheet[0 : row_count, 0 : column_count]
factor = 2.0 * math.pi / (row_count - 1)
-factor_col = column_count = 2
+factor_col = column_count + 2
sheet[0, factor_col - 1].Value = 0.2
sheet[1, factor_col - 1].String = "Change the factor above and
watch the changes in the chart"
@@ -187,3 +196,5 @@ class CalcHelper:
except Exception as e:
print(f"Couldn't initialize Spreadsheet Document: {e}",
file=sys.stderr)
traceback.print_exc()
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/odk/examples/DevelopersGuide/Charts/python/ChartHelper.py
b/odk/examples/DevelopersGuide/Charts/python/ChartHelper.py
new file mode 100644
index ..837be22365cd
--- /dev/null
+++ b/odk/examples/DevelopersGuide/Charts/python/ChartHelper.py
@@ -0,0 +1,114 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+# Helper for creating an OLE chart
+
+from com.sun.star.text import VertOrientation
+from com.sun.star.text import HoriOrientation
+
+
+class ChartHelper(object):
+
+def __init__(self, container_doc):
+self._CHART_CLASS_ID = "12dcae26-281f-416f-a234-c3086127382e"
+self._container_document = container_doc
+
+def insert_ole_chart_in_writer(self, upper_left, extent,
chart_service_name: str):
+"""Inserts an OLE chart into a Writer document.
+
+Args:
+upper_left (Point): The upper-left corner of the chart.
+extent (Size): The size of the chart.
+chart_service_name (str): The name of the chart service to use.
+
+Returns:
+The ChartDocument inserted
+"""
+result = None
+
+try:
+text_content = self._container_document.createInstance(
+
core.git: sc/inc sc/source
sc/inc/patattr.hxx | 25 ++--
sc/source/core/data/patattr.cxx | 121
2 files changed, 119 insertions(+), 27 deletions(-)
New commits:
commit 9b1bba2f9633b27cd822270d79f01be19db9c640
Author: Noel Grandin
AuthorDate: Thu Apr 18 16:21:44 2024 +0200
Commit: Noel Grandin
CommitDate: Fri Apr 19 22:10:11 2024 +0200
tdf#160706 speed up loading conditional formatting rule in XLS (4)
speed up the matching of duplicates in CellAttributeHelper by using
std::set and partial sorting by name
Takes my time from 33s to 6s
Change-Id: I06376c1e253981cb5a3020142d24fa5776513d4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166262
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/inc/patattr.hxx b/sc/inc/patattr.hxx
index 1dabeaa07102..9ca1ff0250d8 100644
--- a/sc/inc/patattr.hxx
+++ b/sc/inc/patattr.hxx
@@ -29,7 +29,7 @@
#include "fonthelper.hxx"
#include "scitems.hxx"
#include "attrib.hxx"
-#include
+#include
namespace vcl { class Font; }
namespace model { class ComplexColor; }
@@ -59,9 +59,23 @@ class SC_DLLPUBLIC CellAttributeHelper final
{
friend class CellAttributeHolder;
+// Data structure chosen so that
+// (a) we can find by name
+// (b) we can erase quickly, by using name and pointer.
+// so we sort the set first by name, and then by pointer.
+struct RegisteredAttrSetLess
+{
+bool operator()(const ScPatternAttr* lhs, const ScPatternAttr* rhs)
const;
+// so we can search in std::set without a ScPatternAttr
+using is_transparent = void;
+bool operator()(const ScPatternAttr* lhs, const OUString* rhs) const;
+bool operator()(const OUString* lhs, const ScPatternAttr* rhs) const;
+};
+typedef std::set
RegisteredAttrSet;
+
SfxItemPool&mrSfxItemPool;
mutable ScPatternAttr* mpDefaultCellAttribute;
-mutable std::unordered_set
maRegisteredCellAttributes;
+mutable RegisteredAttrSet
maRegisteredCellAttributes;
mutable const ScPatternAttr*mpLastHit;
mutable sal_uInt64 mnCurrentMaxKey;
@@ -77,9 +91,10 @@ public:
SfxItemPool& GetPool() const { return mrSfxItemPool; }
void CellStyleDeleted(const ScStyleSheet& rStyle);
-void CellStyleCreated(ScDocument& rDoc, std::u16string_view rName);
+void CellStyleCreated(ScDocument& rDoc, const OUString& rName);
void UpdateAllStyleSheets(ScDocument& rDoc);
void AllStylesToNames();
+void ReIndexRegistered();
};
class SC_DLLPUBLIC CellAttributeHolder final
@@ -111,7 +126,7 @@ class SC_DLLPUBLIC ScPatternAttr final
friend class CellAttributeHelper;
SfxItemSet maLocalSfxItemSet;
-std::optional pName;
+std::optional moName;
mutable std::optional mxVisible;
ScStyleSheet* pStyle;
CellAttributeHelper*pCellAttributeHelper;
@@ -228,7 +243,7 @@ public:
voidSetStyleSheet(ScStyleSheet* pNewStyle, bool
bClearDirectFormat = true);
const ScStyleSheet* GetStyleSheet() const { return pStyle; }
const OUString* GetStyleName() const;
-voidUpdateStyleSheet(const ScDocument& rDoc);
+boolUpdateStyleSheet(const ScDocument& rDoc);
voidStyleToName();
boolIsVisible() const;
diff --git a/sc/source/core/data/patattr.cxx b/sc/source/core/data/patattr.cxx
index 486806e7ccc9..08b120339aa7 100644
--- a/sc/source/core/data/patattr.cxx
+++ b/sc/source/core/data/patattr.cxx
@@ -81,6 +81,17 @@ CellAttributeHelper::~CellAttributeHelper()
delete mpDefaultCellAttribute;
}
+static int CompareStringPtr(const OUString* lhs, const OUString* rhs)
+{
+if (lhs == rhs)
+return 0;
+if (lhs && rhs)
+return (*lhs).compareTo(*rhs);
+if (!lhs && rhs)
+return -1;
+return 1;
+}
+
const ScPatternAttr* CellAttributeHelper::registerAndCheck(const
ScPatternAttr& rCandidate, bool bPassingOwnership) const
{
if ( == ())
@@ -103,13 +114,13 @@ const ScPatternAttr*
CellAttributeHelper::registerAndCheck(const ScPatternAttr&
delete
return mpLastHit;
}
-
-for (const ScPatternAttr* pCheck : maRegisteredCellAttributes)
+const OUString* pCandidateStyleName = rCandidate.GetStyleName();
+auto it = maRegisteredCellAttributes.lower_bound(pCandidateStyleName);
+for (; it != maRegisteredCellAttributes.end(); ++it)
{
-if (mpLastHit == pCheck)
-// ptr compare: already checked above, skip this one
-continue;
-
+const ScPatternAttr* pCheck = *it;
+if (CompareStringPtr(pCheck->GetStyleName(), pCandidateStyleName) != 0)
+break;
if
[Bug 160686] "Left Page" and "Right Page" are nonsensical and should be removed
https://bugs.documentfoundation.org/show_bug.cgi?id=160686 --- Comment #11 from Eyal Rozenberg --- (In reply to David from comment #10) > I hereby explicitly refute your claim as per my use case described in > comment #8. I was answering Heiko... The use case you described in that comment has nothing to do with a distinction between "Left" and "Right" pages, nor between "Odd" and "Even" pages; nor would you use the "Left Page" and "Right Page" styles for that case - you would use a page style appropriate for the first page of a chapter. I am not against this being possible! I am against the definition of the two "Left Page" and "Right Page" styles. > > These are not, and can't be, the styles of "Right Page"'s or "Left Page"'s, > > whatever that means; so they must be removed. > Then what would you call them given my use case? I would call them styles you would not use for your use case. I mean, I can take the "HTML" page style and use that for the first page of my chapter, too; it's an arbitrary choice. > Maybe because no viable, better alternative to my real-life use case has yet > been provided. Like I said above - create a new custom page style, say "Chapter Title"; set its Next Style to Default Page Style (or whatever page style you want to use for that chapter), and you're all set. -- You are receiving this mail because: You are the assignee for the bug.
core.git: static/source
static/source/embindmaker/embindmaker.cxx |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
New commits:
commit 038c1983122ada4cfe0c85b527940a410643ace1
Author: Stephan Bergmann
AuthorDate: Fri Apr 19 15:06:03 2024 +0200
Commit: Stephan Bergmann
CommitDate: Fri Apr 19 21:38:50 2024 +0200
Embind: Clarify need for emscripten::internal::raw_destructor
specializations
...which are needed at compile time (the emscripten::class_ ctor always
records the address of emscripten::internal::raw_destructor, even in
cases
where it never calls it; and raw_destructor internally calls delete, but the
dtor of the UNO interface types is protected) but not at runtime (as those
UNO
interface types are only accessed through css::uno::Reference smart
pointers)
Change-Id: I09e4f258f8dfc0fc53c0fe7210c7f709d86be176
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166304
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/static/source/embindmaker/embindmaker.cxx
b/static/source/embindmaker/embindmaker.cxx
index abce7e574f67..f9540c1f006b 100644
--- a/static/source/embindmaker/embindmaker.cxx
+++ b/static/source/embindmaker/embindmaker.cxx
@@ -951,6 +951,7 @@ SAL_IMPLEMENT_MAIN()
cppOut << "#include
"
"#include
"
"#include
"
+ "#include
"
"#include
";
for (auto const& enm : enums)
{
@@ -977,14 +978,11 @@ SAL_IMPLEMENT_MAIN()
cppOut << "#include <" << sng.replace('.', '/') << ".hpp>
";
}
cppOut << "
"
- "// TODO: This is a temporary workaround that likely causes
the Embind UNO
"
- "// bindings to leak memory. Reference counting and cloning
mechanisms of
"
- "// Embind should be investigated to figure out what exactly
we need here:
"
"namespace emscripten::internal {
";
for (auto const& ifc : interfaces)
{
cppOut << "template<> void raw_destructor<" << cppName(ifc) <<
">(" << cppName(ifc)
- << " *) {}
";
+ << " *) { O3TL_UNREACHABLE; }
";
}
cppOut << "}
";
unsigned long long n = 0;
[Bug 160362] Syntax Highlighting Support
https://bugs.documentfoundation.org/show_bug.cgi?id=160362
`{third: "Beedell", first: "Roke"}`{.JSON5}
<1c4cm...@rokejulianlockhart.addy.io> changed:
What|Removed |Added
See Also|https://bugs.documentfounda |
|tion.org/show_bug.cgi?id=43 |
|089 |
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 43089] Syntax highlighting for Math
https://bugs.documentfoundation.org/show_bug.cgi?id=43089
`{third: "Beedell", first: "Roke"}`{.JSON5}
<1c4cm...@rokejulianlockhart.addy.io> changed:
What|Removed |Added
See Also|https://bugs.documentfounda |
|tion.org/show_bug.cgi?id=16 |
|0362|
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 160362] Syntax Highlighting Support
https://bugs.documentfoundation.org/show_bug.cgi?id=160362
`{third: "Beedell", first: "Roke"}`{.JSON5}
<1c4cm...@rokejulianlockhart.addy.io> changed:
What|Removed |Added
Blocks||43089
Referenced Bugs:
https://bugs.documentfoundation.org/show_bug.cgi?id=43089
[Bug 43089] Syntax highlighting for Math
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 43089] Syntax highlighting for Math
https://bugs.documentfoundation.org/show_bug.cgi?id=43089
`{third: "Beedell", first: "Roke"}`{.JSON5}
<1c4cm...@rokejulianlockhart.addy.io> changed:
What|Removed |Added
Depends on||160362
Referenced Bugs:
https://bugs.documentfoundation.org/show_bug.cgi?id=160362
[Bug 160362] Syntax Highlighting Support
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 43089] Syntax highlighting for Math
https://bugs.documentfoundation.org/show_bug.cgi?id=43089
`{third: "Beedell", first: "Roke"}`{.JSON5}
<1c4cm...@rokejulianlockhart.addy.io> changed:
What|Removed |Added
See Also|https://bugs.documentfounda |
|tion.org/show_bug.cgi?id=16 |
|0360|
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 160360] Syntax Highlighting for Markdown
https://bugs.documentfoundation.org/show_bug.cgi?id=160360
`{third: "Beedell", first: "Roke"}`{.JSON5}
<1c4cm...@rokejulianlockhart.addy.io> changed:
What|Removed |Added
See Also|https://bugs.documentfounda |
|tion.org/show_bug.cgi?id=43 |
|089 |
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 160362] Syntax Highlighting Support
https://bugs.documentfoundation.org/show_bug.cgi?id=160362
`{third: "Beedell", first: "Roke"}`{.JSON5}
<1c4cm...@rokejulianlockhart.addy.io> changed:
What|Removed |Added
See Also|https://bugs.documentfounda |
|tion.org/show_bug.cgi?id=16 |
|0360|
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 160360] Syntax Highlighting for Markdown
https://bugs.documentfoundation.org/show_bug.cgi?id=160360
`{third: "Beedell", first: "Roke"}`{.JSON5}
<1c4cm...@rokejulianlockhart.addy.io> changed:
What|Removed |Added
See Also|https://bugs.documentfounda |
|tion.org/show_bug.cgi?id=16 |
|0362|
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 160360] Syntax Highlighting for Markdown
https://bugs.documentfoundation.org/show_bug.cgi?id=160360
`{third: "Beedell", first: "Roke"}`{.JSON5}
<1c4cm...@rokejulianlockhart.addy.io> changed:
What|Removed |Added
Depends on||160362
Referenced Bugs:
https://bugs.documentfoundation.org/show_bug.cgi?id=160362
[Bug 160362] Syntax Highlighting Support
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 160362] Syntax Highlighting Support
https://bugs.documentfoundation.org/show_bug.cgi?id=160362
`{third: "Beedell", first: "Roke"}`{.JSON5}
<1c4cm...@rokejulianlockhart.addy.io> changed:
What|Removed |Added
Blocks||160360
Referenced Bugs:
https://bugs.documentfoundation.org/show_bug.cgi?id=160360
[Bug 160360] Syntax Highlighting for Markdown
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 160360] Syntax Highlighting for Markdown
https://bugs.documentfoundation.org/show_bug.cgi?id=160360
--- Comment #6 from `{third: "Beedell", first: "Roke"}`{.JSON5}
<1c4cm...@rokejulianlockhart.addy.io> ---
(In reply to Eyal Rozenberg from comment #5)
> I don't remember that LO offers syntax highlighting for files it edits as
> text. Why should Markdown be any different?
>
> If you want to edit Markdown as text, use a source code editor or a
> specialized MD editor with a preview. I don't know that LibreOffice is used
> that way.
>
> Suggest marking as either WONTFIX or INVALID.
Indeed, it shouldn't be, hence
https://bugs.documentfoundation.org/show_bug.cgi?id=160362#c1.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 160360] Syntax Highlighting for Markdown
https://bugs.documentfoundation.org/show_bug.cgi?id=160360 --- Comment #5 from Eyal Rozenberg --- I don't remember that LO offers syntax highlighting for files it edits as text. Why should Markdown be any different? If you want to edit Markdown as text, use a source code editor or a specialized MD editor with a preview. I don't know that LibreOffice is used that way. Suggest marking as either WONTFIX or INVALID. -- You are receiving this mail because: You are the assignee for the bug.
core.git: 2 commits - vcl/inc vcl/source vcl/unx
vcl/inc/fontsubset.hxx |4 ++-- vcl/inc/ppdparser.hxx |2 +- vcl/inc/strhelper.hxx |2 +- vcl/inc/unx/fontmanager.hxx |2 +- vcl/source/fontsubset/cff.cxx |2 +- vcl/source/fontsubset/fontsubset.cxx|9 ++--- vcl/source/fontsubset/sft.cxx |2 +- vcl/source/helper/strhelper.cxx |8 vcl/unx/generic/fontmanager/fontmanager.cxx | 23 +++ vcl/unx/generic/printer/ppdparser.cxx | 12 +++- vcl/unx/gtk3/gtkinst.cxx|4 +--- 11 files changed, 24 insertions(+), 46 deletions(-) New commits: commit b209d17236778b5bd2ca8f519166e75447ed9117 Author: Noel Grandin AuthorDate: Fri Apr 19 12:37:28 2024 +0200 Commit: Noel Grandin CommitDate: Fri Apr 19 21:27:11 2024 +0200 mpReqFontName is potentially pointing to freed memory since we assign it from a temporary OString. No idea why this hasn't caused a problem already. Change-Id: I5480fb2ab5d1e07212ad804f99223946abf5a6c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166297 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/vcl/inc/fontsubset.hxx b/vcl/inc/fontsubset.hxx index 01bd67f4bff8..490d4839f711 100644 --- a/vcl/inc/fontsubset.hxx +++ b/vcl/inc/fontsubset.hxx @@ -77,7 +77,7 @@ private: // subset-request details FontTypemnReqFontTypeMask; ///< allowed subset-target font types SvStream* mpOutFile; -const char* mpReqFontName; +OString maReqFontName; const sal_GlyphId* mpReqGlyphIds; const sal_uInt8*mpReqEncodedIds; int mnReqGlyphCount; diff --git a/vcl/source/fontsubset/cff.cxx b/vcl/source/fontsubset/cff.cxx index 2021a6a44d71..384556458b4d 100644 --- a/vcl/source/fontsubset/cff.cxx +++ b/vcl/source/fontsubset/cff.cxx @@ -2615,7 +2615,7 @@ bool FontSubsetInfo::CreateFontSubsetFromCff() // TODO: also support CFF->CFF subsetting (when PDF-export and PS-printing need it) const bool bPfbSubset(mnReqFontTypeMask & FontType::TYPE1_PFB); Type1Emitter aType1Emitter( mpOutFile, bPfbSubset); -aType1Emitter.setSubsetName( mpReqFontName); +aType1Emitter.setSubsetName( maReqFontName.getStr() ); aCff.emitAsType1( aType1Emitter, mpReqGlyphIds, mpReqEncodedIds, mnReqGlyphCount, *this); diff --git a/vcl/source/fontsubset/fontsubset.cxx b/vcl/source/fontsubset/fontsubset.cxx index d0e05058f967..0fab8bfbf087 100644 --- a/vcl/source/fontsubset/fontsubset.cxx +++ b/vcl/source/fontsubset/fontsubset.cxx @@ -35,7 +35,6 @@ FontSubsetInfo::FontSubsetInfo() , meInFontType( FontType::NO_FONT) , mnReqFontTypeMask( FontType::NO_FONT ) , mpOutFile(nullptr) -, mpReqFontName(nullptr) , mpReqGlyphIds(nullptr) , mpReqEncodedIds(nullptr) , mnReqGlyphCount(0) @@ -67,9 +66,7 @@ bool FontSubsetInfo::CreateFontSubset( mpReqGlyphIds = pReqGlyphIds; mpReqEncodedIds = pReqEncodedIds; mnReqGlyphCount = nReqGlyphCount; - -OString aPSName = m_aPSName.toUtf8(); -mpReqFontName = aPSName.getStr(); +maReqFontName = m_aPSName.toUtf8(); // TODO: move the glyphid/encid/notdef reshuffling from the callers to here commit 598ff4e2433a419a432fd54ed5dac560663ec107 Author: Noel Grandin AuthorDate: Fri Apr 19 12:35:06 2024 +0200 Commit: Noel Grandin CommitDate: Fri Apr 19 21:27:01 2024 +0200 loplugin:constantparam in vcl Change-Id: Ifab93e642773bcbf3801cee36bf3db66446febec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166295 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/vcl/inc/fontsubset.hxx b/vcl/inc/fontsubset.hxx index fbe648940d0c..01bd67f4bff8 100644 --- a/vcl/inc/fontsubset.hxx +++ b/vcl/inc/fontsubset.hxx @@ -54,7 +54,7 @@ public: const unsigned char* pFontBytes, int nByteLength ); SAL_DLLPRIVATE bool CreateFontSubset( FontType nOutFontTypeMask, -SvStream* pOutFile, const char* pOutFontName, +SvStream* pOutFile, const sal_GlyphId* pGlyphIds, const sal_uInt8* pEncodedIds, int nReqGlyphCount); diff --git a/vcl/inc/ppdparser.hxx b/vcl/inc/ppdparser.hxx index cbc1b94b4ea8..732e9e550166 100644 --- a/vcl/inc/ppdparser.hxx +++ b/vcl/inc/ppdparser.hxx @@ -172,7 +172,7 @@ private: static void initPPDFiles(PPDCache ); static OUString getPPDFile( const OUString& rFile ); -OUStringmatchPaperImpl(int nWidth, int nHeight, bool bDontSwap = false, psp::orientation* pOrientation = nullptr) const; +OUStringmatchPaperImpl(int nWidth, int nHeight, psp::orientation* pOrientation) const; public: ~PPDParser(); diff --git a/vcl/inc/strhelper.hxx b/vcl/inc/strhelper.hxx index
core.git: 2 commits - basegfx/source chart2/source compilerplugins/clang cui/source include/svl include/svx include/tools svl/source svx/source tools/source
basegfx/source/polygon/b2dlinegeometry.cxx| 27
chart2/source/controller/chartapiwrapper/TitleWrapper.cxx |3
chart2/source/view/charttypes/PieChart.hxx|1
chart2/source/view/inc/VDataSeries.hxx|4
chart2/source/view/main/SeriesPlotterContainer.cxx|1
chart2/source/view/main/VDataSeries.cxx |7
compilerplugins/clang/constantparam.bitmask.results | 30
compilerplugins/clang/constantparam.booleans.results | 3102 --
compilerplugins/clang/constantparam.constructors.results | 822 +--
compilerplugins/clang/constantparam.numbers.results | 2342 +-
compilerplugins/clang/constantparam.py|2
cui/source/inc/paragrph.hxx |1
cui/source/tabpages/paragrph.cxx |2
include/svl/itemset.hxx |2
include/svx/svdpage.hxx |6
include/tools/stream.hxx |3
svl/source/items/itemset.cxx |4
svx/source/sdr/properties/e3dsceneproperties.cxx |2
svx/source/sdr/properties/groupproperties.cxx |2
svx/source/svdraw/svdedtv1.cxx|4
svx/source/svdraw/svdpage.cxx | 24
svx/source/table/tablecontroller.cxx |4
tools/source/stream/stream.cxx|2
23 files changed, 3444 insertions(+), 2953 deletions(-)
New commits:
commit c04c38f4841aff5eac78c92a7145b661a3a99c2a
Author: Noel Grandin
AuthorDate: Fri Apr 19 10:27:27 2024 +0200
Commit: Noel Grandin
CommitDate: Fri Apr 19 21:26:52 2024 +0200
loplugin:constantparam
Change-Id: I58e31ffdfc87a15e82bce54afd47ff3906159707
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166293
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/basegfx/source/polygon/b2dlinegeometry.cxx
b/basegfx/source/polygon/b2dlinegeometry.cxx
index 4f5de36a8295..a6a88c557ee8 100644
--- a/basegfx/source/polygon/b2dlinegeometry.cxx
+++ b/basegfx/source/polygon/b2dlinegeometry.cxx
@@ -335,8 +335,7 @@ namespace basegfx
bool bStartRound,
bool bEndRound,
bool bStartSquare,
-bool bEndSquare,
-basegfx::triangulator::B2DTriangleVector* pTriangles)
+bool bEndSquare)
{
// create polygon for edge
// Unfortunately, while it would be geometrically correct to not
add
@@ -565,15 +564,6 @@ namespace basegfx
}
}
-if(nullptr != pTriangles)
-{
-const basegfx::triangulator::B2DTriangleVector aResult(
-basegfx::triangulator::triangulate(
-aBezierPolygon));
-pTriangles->insert(pTriangles->end(), aResult.begin(),
aResult.end());
-aBezierPolygon.clear();
-}
-
// return
return aBezierPolygon;
}
@@ -672,15 +662,6 @@ namespace basegfx
// close and return
aEdgePolygon.setClosed(true);
-if(nullptr != pTriangles)
-{
-const basegfx::triangulator::B2DTriangleVector aResult(
-basegfx::triangulator::triangulate(
-aEdgePolygon));
-pTriangles->insert(pTriangles->end(), aResult.begin(),
aResult.end());
-aEdgePolygon.clear();
-}
-
return aEdgePolygon;
}
}
@@ -946,8 +927,7 @@ namespace basegfx
bFirst && eCap ==
css::drawing::LineCap_ROUND,
bLast && eCap ==
css::drawing::LineCap_ROUND,
bFirst && eCap ==
css::drawing::LineCap_SQUARE,
-bLast && eCap ==
css::drawing::LineCap_SQUARE,
-nullptr));
+bLast && eCap ==
css::drawing::LineCap_SQUARE));
}
else
{
@@ -958,8 +938,7 @@ namespace basegfx
false,
false,
false,
-false,
-nullptr));
+false));
}
// prepare next step
diff --git a/compilerplugins/clang/constantparam.bitmask.results
b/compilerplugins/clang/constantparam.bitmask.results
index 5a78a996d7b5..3038062d9a92 100644
---
core.git: solenv/gbuild
solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 78c613d7df5138f7da9132a6e4aabb1e78321e90 Author: Stephan Bergmann AuthorDate: Fri Apr 19 12:31:42 2024 +0200 Commit: Stephan Bergmann CommitDate: Fri Apr 19 21:21:24 2024 +0200 Emscripten: Drop unused, deprecated EXPORTED_RUNTIME_METHODS Linking Executable/soffice.html kept warning about > warning: JS library symbol '$allocateUTF8' is deprecated. Please open a bug if you have a continuing need for this symbol [-Wdeprecated] > warning: deprecated item in EXPORTED_RUNTIME_METHODS: printErr use err instead. > em++: warning: warnings in JS library compilation [-Wjs-compiler] printErr had been introduced in f090004c5f236275ca5142fc578f0375872c0336 "WASM adapt link and debug flags" and allocateUTF8 had been introduced in ce60a3dd4dbff0dcb5b82c9053ae5d90f8ac929d "Add LOKit functions and whitelist export for it to WASM", but in both cases no code seems to ever have made use of either of those two methods, before or after. Change-Id: I1e81ca6ddad748d91653f709c272328cc8f2b679 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166296 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk b/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk index 5d960db61087..64713ec66fd1 100644 --- a/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk +++ b/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk @@ -25,7 +25,7 @@ gb_EMSCRIPTEN_LDFLAGS += -s TOTAL_MEMORY=1GB -s PTHREAD_POOL_SIZE=4 # To keep the link time (and memory) down, prevent all rewriting options from wasm-emscripten-finalize # See emscripten.py, finalize_wasm, modify_wasm = True # So we need WASM_BIGINT=1 and ASSERTIONS=1 (2 implies STACK_OVERFLOW_CHECK) -gb_EMSCRIPTEN_LDFLAGS += --bind -s FORCE_FILESYSTEM=1 -s WASM_BIGINT=1 -s ERROR_ON_UNDEFINED_SYMBOLS=1 -s FETCH=1 -s ASSERTIONS=1 -s EXIT_RUNTIME=0 -s EXPORTED_RUNTIME_METHODS=["UTF16ToString","stringToUTF16","UTF8ToString","allocateUTF8","printErr","ccall","cwrap","addOnPreMain"$(if $(ENABLE_DBGUTIL),$(COMMA)"addOnPostRun"),"registerType","throwBindingError"$(if $(ENABLE_QT6),$(COMMA)"callMain"$(COMMA)"specialHTMLTargets")] +gb_EMSCRIPTEN_LDFLAGS += --bind -s FORCE_FILESYSTEM=1 -s WASM_BIGINT=1 -s ERROR_ON_UNDEFINED_SYMBOLS=1 -s FETCH=1 -s ASSERTIONS=1 -s EXIT_RUNTIME=0 -s EXPORTED_RUNTIME_METHODS=["UTF16ToString","stringToUTF16","UTF8ToString","ccall","cwrap","addOnPreMain"$(if $(ENABLE_DBGUTIL),$(COMMA)"addOnPostRun"),"registerType","throwBindingError"$(if $(ENABLE_QT6),$(COMMA)"callMain"$(COMMA)"specialHTMLTargets")] gb_EMSCRIPTEN_QTDEFS := -DQT_NO_LINKED_LIST -DQT_NO_JAVA_STYLE_ITERATORS -DQT_NO_EXCEPTIONS -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CORE_LIB gb_Executable_EXT := .html
core.git: offapi/org static/README.wasm.md static/source unotest/source
offapi/org/libreoffice/embindtest/XTest.idl |2 ++
static/README.wasm.md | 14 +++---
static/source/embindmaker/embindmaker.cxx | 13 +
unotest/source/embindtest/embindtest.cxx| 11 +++
unotest/source/embindtest/embindtest.js | 11 +++
5 files changed, 36 insertions(+), 15 deletions(-)
New commits:
commit 1c81f63e91d39187748ea070d064e996481dbd3d
Author: Stephan Bergmann
AuthorDate: Thu Apr 18 16:05:48 2024 +0200
Commit: Stephan Bergmann
CommitDate: Fri Apr 19 21:20:59 2024 +0200
Embind: Consistently represent empty interface references as JS null
The existing code had two issues: For one, e.g. calling a function that
returned a null interface reference mapped that to JS null, while querying
an
object for a non-supported interface via `new css.uno.X...(y)` mapped that
to
an "empty" JS object instead. (So checking for a non-null reference needed
to
be done as either `x !=== null` or as `x.is()`, depending on context.) And
for
another, while calling $is() on a non-"empty" object worked fine, it failed
on
such an "empty" object (as the Embind internals of that object lacked the $$
property).
So change the querying mechanism from the `new css.uno.X...(y)` constructor
to a
`css.uno.Xquery(y)` function call syntax, which now returns JS null when
querying for a non-supported interface. (And drop the broken $is method.)
Change-Id: I8fa488ab2892423f2a461d9b72db47e1d4df3b8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166255
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/offapi/org/libreoffice/embindtest/XTest.idl
b/offapi/org/libreoffice/embindtest/XTest.idl
index 8817e94669fc..3dc1773c120a 100644
--- a/offapi/org/libreoffice/embindtest/XTest.idl
+++ b/offapi/org/libreoffice/embindtest/XTest.idl
@@ -112,6 +112,8 @@ interface XTest {
boolean isSequenceEnum([in] sequence value);
sequence getSequenceStruct();
boolean isSequenceStruct([in] sequence value);
+XTest getNull();
+boolean isNull([in] XTest value);
void throwRuntimeException();
void passJob([in] com::sun::star::task::XJob object);
void passJobExecutor([in] com::sun::star::task::XJobExecutor object);
diff --git a/static/README.wasm.md b/static/README.wasm.md
index 19da4518030c..5397e2124d16 100644
--- a/static/README.wasm.md
+++ b/static/README.wasm.md
@@ -228,11 +228,11 @@ Some usage examples through javascript of the current
implementation:
let uno = init_unoembind_uno(Module);
let css = uno.com.sun.star;
xModel = Module.getCurrentModelFromViewSh();
-xTextDocument = new css.text.XTextDocument(xModel);
+xTextDocument = css.text.XTextDocument.query(xModel);
xText = xTextDocument.getText();
-xSimpleText = new css.text.XSimpleText(xText);
+xSimpleText = css.text.XSimpleText.query(xText);
xTextCursor = xSimpleText.createTextCursor();
-xTextRange = new css.text.XTextRange(xTextCursor);
+xTextRange = css.text.XTextRange.query(xTextCursor);
xTextRange.setString("string here!");
xModel.delete(); xTextDocument.delete(); xText.delete(); xSimpleText.delete();
xTextCursor.delete(); xTextRange.delete();
```
@@ -242,13 +242,13 @@ xModel.delete(); xTextDocument.delete(); xText.delete();
xSimpleText.delete(); x
let uno = init_unoembind_uno(Module);
let css = uno.com.sun.star;
xModel = Module.getCurrentModelFromViewSh();
-xEnumAccess = new css.container.XEnumerationAccess(xText);
+xEnumAccess = css.container.XEnumerationAccess.query(xText);
xParaEnumeration = xEnumAccess.createEnumeration();
while (xParaEnumeration.hasMoreElements()) {
-xParagraph = new css.text.XTextRange(xParaEnumeration.nextElement().get());
-if (xParagraph.$is()) {
-xParaProps = new css.beans.XPropertySet(xParagraph);
+xParagraph =
css.text.XTextRange.query(xParaEnumeration.nextElement().get());
+if (xParagraph !== null) {
+xParaProps = css.beans.XPropertySet.query(xParagraph);
let color = new Module.uno_Any(
Module.uno_Type.Long(), Math.floor(Math.random() * 0xFF));
xParaProps.setPropertyValue("CharColor", color);
diff --git a/static/source/embindmaker/embindmaker.cxx
b/static/source/embindmaker/embindmaker.cxx
index 252d7b25451c..abce7e574f67 100644
--- a/static/source/embindmaker/embindmaker.cxx
+++ b/static/source/embindmaker/embindmaker.cxx
@@ -1082,18 +1082,15 @@ SAL_IMPLEMENT_MAIN()
".smart_ptr<::com::sun::star::uno::Reference<"
<< cppName(ifc) << ">>(\"uno_Reference_" << jsName(ifc)
<< "\")
"
+ ".class_function(\"query\", "
+
"+[](::com::sun::star::uno::Reference<::com::sun::star::uno::XInterface> "
+ "const & the_object) { return
::com::sun::star::uno::Reference<"
+ << cppName(ifc)
+ <<
core.git: static/source
static/source/embindmaker/embindmaker.cxx | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
New commits:
commit 41706fcd962a38627d20f62488c6110967396ee7
Author: Stephan Bergmann
AuthorDate: Fri Apr 19 11:00:05 2024 +0200
Commit: Stephan Bergmann
CommitDate: Fri Apr 19 21:20:41 2024 +0200
Embind: Don't expose special XInterface methods to JS client code
Change-Id: I8592466b96406a1658d0a5a1b961142f862a9e4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166290
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/static/source/embindmaker/embindmaker.cxx
b/static/source/embindmaker/embindmaker.cxx
index ea7879ecceb0..252d7b25451c 100644
--- a/static/source/embindmaker/embindmaker.cxx
+++ b/static/source/embindmaker/embindmaker.cxx
@@ -667,16 +667,19 @@ void dumpMethods(std::ostream& out,
rtl::Reference const& manager,
OUString const& name,
rtl::Reference const& entity,
std::list const& baseTrail)
{
-for (auto const& meth : entity->getDirectMethods())
+if (name != "com.sun.star.uno.XInterface")
{
-if (!baseTrail.empty() || hasInOutParameters(meth))
+for (auto const& meth : entity->getDirectMethods())
{
-dumpWrapper(out, manager, name, meth, baseTrail);
-}
-else
-{
-out << ".function(\"" << meth.name << "\", &" <<
cppName(name)
-<< "::" << meth.name << ", ::emscripten::pure_virtual())
";
+if (!baseTrail.empty() || hasInOutParameters(meth))
+{
+dumpWrapper(out, manager, name, meth, baseTrail);
+}
+else
+{
+out << ".function(\"" << meth.name << "\", &" <<
cppName(name)
+<< "::" << meth.name << ", ::emscripten::pure_virtual())
";
+}
}
}
}
core.git: config_host.mk.in configure.ac distro-configs/CPLinux-LOKit.conf solenv/gbuild
config_host.mk.in |3 + configure.ac | 62 - distro-configs/CPLinux-LOKit.conf |1 solenv/gbuild/platform/com_GCC_defs.mk |6 ++- 4 files changed, 70 insertions(+), 2 deletions(-) New commits: commit 2e50b3850ba2074dba41e6ea07c9e7d236af0d6c Author: Caolán McNamara AuthorDate: Tue Feb 13 15:17:48 2024 + Commit: Caolán McNamara CommitDate: Fri Apr 19 21:01:53 2024 +0200 add --enable-hardening-flags to enable compiler hardening flags distros typically have their own set via C[XX]FLAGS, so make this an optional argument some notes on the options: -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=2 https://www.redhat.com/en/blog/enhance-application-security-fortifysource (I see Fedora has recently bumped to to 3 since Jan 2024 https://fedoraproject.org/wiki/Changes/Add_FORTIFY_SOURCE%3D3_to_distribution_build_flags but here use 2 for now instead) -Wp,-D_GLIBCXX_ASSERTIONS https://fedoraproject.org/wiki/Changes/HardeningFlags28 -fstack-protector-strong (We already apply this by default) -fstack-clash-protection https://fedoraproject.org/wiki/Changes/HardeningFlags28 -fcf-protection https://fedoraproject.org/wiki/Changes/HardeningFlags28 https://cgit.freedesktop.org/libreoffice/core/commit/?id=af55dc3891f7950d392175004b2090cb0e54828e and record the compiler flags in debuginfo -grecord-gcc-switches Change-Id: Ib05387bad8324b188bd4ed0ee327d6a7cf83973b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163312 Tested-by: Jenkins CollaboraOffice Reviewed-by: Andras Timar (cherry picked from commit 33483058f6e27f39633114721f7329c90571101d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166289 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/config_host.mk.in b/config_host.mk.in index 00dc7aa1f898..1d5a83add0c0 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -179,6 +179,9 @@ export ENABLE_GTK3=@ENABLE_GTK3@ export ENABLE_GTK4=@ENABLE_GTK4@ export ENABLE_GTKTILEDVIEWER=@ENABLE_GTKTILEDVIEWER@ export DISABLE_GUI=@DISABLE_GUI@ +export ENABLE_HARDENING_FLAGS=@ENABLE_HARDENING_FLAGS@ +export HARDENING_CFLAGS=@HARDENING_CFLAGS@ +export HARDENING_OPT_CFLAGS=@HARDENING_OPT_CFLAGS@ export ENABLE_HEADLESS=@ENABLE_HEADLESS@ export ENABLE_HTMLHELP=@ENABLE_HTMLHELP@ export ENABLE_JAVA=@ENABLE_JAVA@ diff --git a/configure.ac b/configure.ac index 4bb5ad4d97da..4d96c1e90cf5 100644 --- a/configure.ac +++ b/configure.ac @@ -1916,6 +1916,13 @@ libo_FUZZ_ARG_ENABLE(release-build, See https://wiki.documentfoundation.org/Development/DevBuild]), ,) +libo_FUZZ_ARG_ENABLE(hardening-flags, +AS_HELP_STRING([--enable-hardening-flags], +[Enable automatically using hardening compiler flags. Distros typically + instead use their default configuration via CXXFLAGS, etc. But this provides a + convenient set of default hardening flags for non-distros]), +,) + AC_ARG_ENABLE(windows-build-signing, AS_HELP_STRING([--enable-windows-build-signing], [Enable signing of windows binaries (*.exe, *.dll)]), @@ -2929,6 +2936,19 @@ fi AC_SUBST(ENABLE_RELEASE_BUILD) AC_SUBST(GET_TASK_ALLOW_ENTITLEMENT) +dnl === +dnl Test whether build should auto use hardening compiler flags +dnl === +AC_MSG_CHECKING([whether build should auto use hardening compiler flags]) +if test "$enable_hardening_flags" = "" -o "$enable_hardening_flags" = "no"; then +AC_MSG_RESULT([no]) +ENABLE_HARDENING_FLAGS= +else +AC_MSG_RESULT([yes]) +ENABLE_HARDENING_FLAGS=TRUE +fi +AC_SUBST(ENABLE_HARDENING_FLAGS) + AC_MSG_CHECKING([whether to build a Community flavor]) if test -z "$enable_community_flavor" -o "$enable_community_flavor" = "yes"; then AC_DEFINE(HAVE_FEATURE_COMMUNITY_FLAVOR) @@ -7381,13 +7401,51 @@ dnl === dnl GCC features dnl === HAVE_GCC_STACK_CLASH_PROTECTION= +HARDENING_CFLAGS= +HARDENING_OPT_CFLAGS= if test "$GCC" = "yes" -o "$COM_IS_CLANG" = TRUE; then +AC_MSG_CHECKING([whether $CC_BASE supports -grecord-gcc-switches]) +save_CFLAGS=$CFLAGS +CFLAGS="$CFLAGS -Werror -grecord-gcc-switches" +AC_LINK_IFELSE( +[AC_LANG_PROGRAM(, [[return 0;]])], +[AC_MSG_RESULT([yes]); HARDENING_CFLAGS="$HARDENING_CFLAGS -grecord-gcc-switches"], +[AC_MSG_RESULT([no])]) +CFLAGS=$save_CFLAGS + +AC_MSG_CHECKING([whether $CC_BASE supports -D_FORTIFY_SOURCE=2]) +save_CFLAGS=$CFLAGS +CFLAGS="$CFLAGS -Werror -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=2" +AC_LINK_IFELSE( +[AC_LANG_PROGRAM(, [[#include return
[Bug 160524] wishbug: make *switching* column quantity as easy as left- or right-justify
https://bugs.documentfoundation.org/show_bug.cgi?id=160524 --- Comment #1 from m.hatz...@web.de --- needsComment from whom? Me? To what effect? What exactly isn't comprehensible? Please let me know. -- You are receiving this mail because: You are the assignee for the bug.
core.git: compilerplugins/clang
compilerplugins/clang/unusedfields.cxx | 19 +++
1 file changed, 19 insertions(+)
New commits:
commit 5c6cdc5d5a1bf14155523b2817a96609068ae6ac
Author: Noel Grandin
AuthorDate: Thu Apr 18 14:50:17 2024 +0200
Commit: Noel Grandin
CommitDate: Fri Apr 19 20:32:18 2024 +0200
loplugin:unusedfields update for new clang AST nodes
Change-Id: Icc47093ab13123e9cb2866434796c7d6e8eb38d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166291
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/compilerplugins/clang/unusedfields.cxx
b/compilerplugins/clang/unusedfields.cxx
index d089d11d4956..35381632755a 100644
--- a/compilerplugins/clang/unusedfields.cxx
+++ b/compilerplugins/clang/unusedfields.cxx
@@ -724,6 +724,16 @@ void UnusedFields::checkIfReadFrom(const FieldDecl*
fieldDecl, const Expr* membe
{
break;
}
+else if (isa(parent)) // things like
o3tl::convertNarrowing pass members as template params
+{
+bPotentiallyReadFrom = true;
+break;
+}
+else if (isa(parent))
+{
+bPotentiallyReadFrom = true;
+break;
+}
else
{
bPotentiallyReadFrom = true;
@@ -949,6 +959,15 @@ void UnusedFields::checkIfWrittenTo(const FieldDecl*
fieldDecl, const Expr* memb
{
break;
}
+else if (isa(parent)) // things like
o3tl::convertNarrowing pass members as template params
+{
+break;
+}
+else if (isa(parent))
+{
+bPotentiallyWrittenTo = true;
+break;
+}
else
{
bPotentiallyWrittenTo = true;
[Bug 160431] Inverts webp file image when inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=160431 --- Comment #9 from KJP --- Further research with WEBP images shows that it is the transparency which is inverted. Any part of the image which is fully transparent will be shown as black, and anything which is fully opaque will be shown as fully transparent. Partially opaque/transparent areas will appear with their correct colours but as the inverse of their opacity - ie a 75% opaque area will be shown as 25% opaque. A 1% opaque area will look 99% opaque, etc. So we know which property is being incorrectly calculated. Now it's just a question of finding the calculation and correcting it! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160732] Rename "Navigation" toolbar to clarify its role, avoid confusion, and relate to "Recency"
https://bugs.documentfoundation.org/show_bug.cgi?id=160732 --- Comment #1 from V Stuart Foote --- The 'Navigation' TB was implemented exclusively for the recency navigation as found in web browsers. It tracks edit cursor positions within a current documment. Its major annoyance was its pop-up mode, since tamed by a default fixed docking appended to the Standard TB. Recency had been missing from the SB Navigator, which had focused on movement between document objects. Inclusion of a Recency mode in the Navigator brought it edit cursor stack movement, with enhanced expansion of the types of cursor events being tracked and available to move between. With suppression of the pop-up, its appearance in the View -> Toolbars menu list with labeling as the "Navigation" is benign. The TB is obviously not the SB Navigator, even for the Benjamin user. I don't see advantage to renaming, and of course no reason for removal. Recency subtly describes behavior of the stack, a distinction needed in the SB Navigator deck, but in function it remains Navigation and the name of the TB works. -1 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160731] Navigate By Recency (aka Navigation toolbar) does not work under gtk3 + Wayland
https://bugs.documentfoundation.org/show_bug.cgi?id=160731
--- Comment #1 from Jim Raykowski ---
Quickly commenting out these two lines of code seems to make the recency work
as expected using gtk3 under wayland.
bool SwCursorShell::CallCursorShellFN( FNCursorShell fnCursor )
{
//if (SwWrtShell* pWrtSh = dynamic_cast(this))
//pWrtSh->addCurrentPosition();
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 160726] SVG: feComposite: nothing displayed when not using 'use'
https://bugs.documentfoundation.org/show_bug.cgi?id=160726 Xisco Faulí changed: What|Removed |Added Summary|SVG: feComposite: nothing |SVG: feComposite: nothing |displayed when circle is|displayed when not using |used|'use' -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160726] SVG: feComposite: nothing displayed when circle is used
https://bugs.documentfoundation.org/show_bug.cgi?id=160726 --- Comment #1 from Xisco Faulí --- Created attachment 193759 --> https://bugs.documentfoundation.org/attachment.cgi?id=193759=edit sample 2 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 131430] The format in (all) cells of a spreadsheet is deleted when undoing the Replace All command in combination with Cell Styles.
https://bugs.documentfoundation.org/show_bug.cgi?id=131430 --- Comment #6 from Jürgen Kirsten --- The bug still occurs in version: Version: 24.2.1.2 (X86_64) / LibreOffice Community Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160714] Exporting ODP file to PDF in Impress does not export PDF figures correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=160714 --- Comment #5 from LeonH --- I have noticed this does not happen with all PDF figures. It depends on the source of the PDF. For example, I have always seen this happen as I used the same source to produce my PDF figures, I used ROOT framework for C++ to produce them (as the one I uploaded here as an example). I have tested now with some PDF figures I downloaded from the internet and some seem to work as expected, but for some the background color of the figure turns from white to black. I do not know what is the difference in all these PDF exports, and if this is an issue of LO not supporting different PDF formats, or the sources (such as ROOT) not exporting correctly. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107831] [META] Paragraph-level bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107831 Bug 107831 depends on bug 159903, which changed state. Bug 159903 Summary: Paragraph style indent settings not working correctly https://bugs.documentfoundation.org/show_bug.cgi?id=159903 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159903] Paragraph style indent settings not working correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=159903 Michael Stahl (allotropia) changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de |desktop.org | Resolution|--- |FIXED Status|NEW |RESOLVED Whiteboard|target:24.8.0 |odf target:24.8.0 --- Comment #10 from Michael Stahl (allotropia) --- fixed now -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158166] image contour isn't updated when an image is replaced with another
https://bugs.documentfoundation.org/show_bug.cgi?id=158166 Paolo Benvenuto changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #2 from Paolo Benvenuto --- confirmed Version: 24.2.2.2 (X86_64) / LibreOffice Community Build ID: 420(Build:2) CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-US (C.UTF-8); UI: en-US Ubuntu package version: 4:24.2.2~rc2-0ubuntu0.22.04.1~lo1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160699] Performance: Libreoffice hangs on first launch after boot for 30-60 seconds on intel mac maybe due to custom font(s)
https://bugs.documentfoundation.org/show_bug.cgi?id=160699 steve changed: What|Removed |Added Blocks|158839 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158839 [Bug 158839] [META] OpenPGP bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158839] [META] OpenPGP bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=158839 steve changed: What|Removed |Added Depends on|160699 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160699 [Bug 160699] Performance: Libreoffice hangs on first launch after boot for 30-60 seconds on intel mac maybe due to custom font(s) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160286] Slow Calc FILEOPEN, EDITING, FILESAVE version 24.2.
https://bugs.documentfoundation.org/show_bug.cgi?id=160286 Franco changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #3 from Franco --- Hello! Excuse me for late answer. Tested in safe mode, with release 24.2.2: still very slow and unusable. The files I am working with contain personal financial information: cannot share them. I have tried with very simple file, containing monthly bank records (just 143 lines) and it is fast even in normal mode. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157671] Combo box in a Table control grid throws "When losing focus" event when receive focus
https://bugs.documentfoundation.org/show_bug.cgi?id=157671 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #3 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I gave a new try, I could reproduce this. I retrieved some bts with gen rendering: first OnFocusGained is called with: #0 FmXGridCell::onFocusGained(com::sun::star::awt::FocusEvent const&) (this=0x559179c9c6a0, _rEvent=...) at svx/source/fmcomp/gridcell.cxx:3449 #1 0x7f6642c831d0 in FmXGridCell::OnFocusGained(LinkParamNone*) (this=0x559179c9c6a0) at svx/source/fmcomp/gridcell.cxx:3467 #2 0x7f6642c81c0d in FmXGridCell::LinkStubOnFocusGained(void*, LinkParamNone*) (instance=0x559179c9c6a0, data=0x0) at svx/source/fmcomp/gridcell.cxx:3458 #3 0x7f6641e86b78 in Link::Call(LinkParamNone*) const (this=0x559179c2ccd8, data=0x0) at include/tools/link.hxx:111 #4 0x7f6641e81068 in svt::ControlBase::FocusInHdl(weld::Widget&) (this=0x559179c2cb90) at svtools/source/brwbox/ebbcontrols.cxx:396 #5 0x7f6641e7cf0d in svt::ControlBase::LinkStubFocusInHdl(void*, weld::Widget&) (instance=0x559179c2cb90, data=...) at svtools/source/brwbox/ebbcontrols.cxx:394 #6 0x7f6640130b28 in Link::Call(weld::Widget&) const (this=0x559179bab738, data=...) at include/tools/link.hxx:111 #7 0x7f66400f1f95 in SalInstanceWidget::HandleEventListener(VclWindowEvent&) (this=0x559179bab690, rEvent=...) at vcl/source/app/salvtables.cxx:735 #8 0x7f664013af05 in SalInstanceComboBox::CallHandleEventListener(VclWindowEvent&) (this=0x559179bab690, rEvent=...) at vcl/inc/salvtables.hxx:934 #9 0x7f6640125254 in SalInstanceComboBoxWithEdit::HandleEventListener(VclWindowEvent&) (this=0x559179bab690, rEvent=...) at vcl/source/app/salvtables.cxx:6765 #10 0x7f66400f269d in SalInstanceWidget::EventListener(VclWindowEvent&) (this=0x559179bab690, rEvent=...) at vcl/source/app/salvtables.cxx:822 #11 0x7f66400eeefd in SalInstanceWidget::LinkStubEventListener(void*, VclWindowEvent&) (instance=0x559179bab690, data=...) at vcl/source/app/salvtables.cxx:820 #12 0x7f663f7cedd8 in Link::Call(VclWindowEvent&) const (this=0x559179d406b0, data=...) at include/tools/link.hxx:111 #13 0x7f663f7cbb4e in vcl::Window::CallEventListeners(VclEventId, void*) (this=0x559179c92980, nEvent=VclEventId::WindowGetFocus, pData=0x0) at vcl/source/window/event.cxx:262 #14 0x7f663f7cb64c in vcl::Window::PreNotify(NotifyEvent&) (this=0x559179c92980, rNEvt=...) at vcl/source/window/event.cxx:70 #15 0x7f663f9b6689 in Edit::PreNotify(NotifyEvent&) (this=0x559179c92980, rNEvt=...) at vcl/source/control/edit.cxx:1925 #16 0x7f663f93834d in vcl::Window::CompatPreNotify(NotifyEvent&) (this=0x559179c92980, rNEvt=...) at vcl/source/window/window.cxx:3940 #17 0x7f663f948501 in ImplCallPreNotify(NotifyEvent&) (rEvt=...) at vcl/source/window/winproc.cxx:69 FIRST GAP #18 0x7f663f85b92e in vcl::Window::ImplGrabFocus(GetFocusFlags) (this=0x559179c92980, nFlags=GetFocusFlags::NONE) at vcl/source/window/mouse.cxx:383 SECOND GAP #19 0x7f663f925537 in vcl::Window::GrabFocus() (this=0x559179c92980) at vcl/source/window/window.cxx:2988 #20 0x7f66400ef681 in SalInstanceWidget::grab_focus() (this=0x559179bab690) at vcl/source/app/salvtables.cxx:389 #21 0x7f663f9fcde0 in InterimItemWindow::GetFocus() (this=0x559179c2cb90) at vcl/source/control/InterimItemWindow.cxx:135 #22 0x7f663f93823c in vcl::Window::CompatGetFocus() (this=0x559179c2cb90) at vcl/source/window/window.cxx:3908 #23 0x7f663f85b9a1 in vcl::Window::ImplGrabFocus(GetFocusFlags) (this=0x559179c2cb90, nFlags=GetFocusFlags::NONE) at vcl/source/window/mouse.cxx:384 #24 0x7f663f925537 in vcl::Window::GrabFocus() (this=0x559179c2cb90) at vcl/source/window/window.cxx:2988 #25 0x7f6641e8d298 in svt::EditBrowseBox::StartEditHdl(void*) (this=0x559179c52260) at svtools/source/brwbox/editbrowsebox.cxx:208 #26 0x7f6641e8d1ed in svt::EditBrowseBox::LinkStubStartEditHdl(void*, void*) (instance=0x559179c52260, data=0x0) at svtools/source/brwbox/editbrowsebox.cxx:201 and when OnFocusLost is called: #0 FmXGridCell::onFocusLost(com::sun::star::awt::FocusEvent const&) (this=0x559179c9c6a0, _rEvent=...) at svx/source/fmcomp/gridcell.cxx:3455 #1 0x7f6642c832d0 in FmXGridCell::OnFocusLost(LinkParamNone*) (this=0x559179c9c6a0) at svx/source/fmcomp/gridcell.cxx:3479 #2 0x7f6642c81c3d in FmXGridCell::LinkStubOnFocusLost(void*, LinkParamNone*) (instance=0x559179c9c6a0, data=0x0) at svx/source/fmcomp/gridcell.cxx:3470 #3 0x7f6641e86b78 in Link::Call(LinkParamNone*) const (this=0x559179c2cd00, data=0x0) at include/tools/link.hxx:111 #4 0x7f6641e810b8 in svt::ControlBase::FocusOutHdl(weld::Widget&) (this=0x559179c2cb90) at svtools/source/brwbox/ebbcontrols.cxx:402 #5
[Bug 159903] Paragraph style indent settings not working correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=159903 --- Comment #9 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0c7ae3bd96130eaa400d55a3ba9bf1e2fe6600de tdf#156146 tdf#159903 sw: add unit tests It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/qa sw/source
sw/qa/core/text/data/Broken indent demo.odt |binary sw/qa/core/text/data/tdf156146.fodt | 281 sw/qa/core/text/text.cxx| 62 ++ sw/source/core/text/inftxt.hxx |6 sw/source/core/text/itratr.hxx |6 sw/source/core/text/itrtxt.hxx |2 6 files changed, 350 insertions(+), 7 deletions(-) New commits: commit 0c7ae3bd96130eaa400d55a3ba9bf1e2fe6600de Author: Michael Stahl AuthorDate: Thu Apr 18 18:23:29 2024 +0200 Commit: Michael Stahl CommitDate: Fri Apr 19 18:12:33 2024 +0200 tdf#156146 tdf#159903 sw: add unit tests Unfortunately the actual computed margins are not stored in text formatting data structures so are only available directly from SwTextMargin. Change-Id: Ia7ce5e148194a55b5d9874ed112aaa977ed16c7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166258 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/sw/qa/core/text/data/Broken indent demo.odt b/sw/qa/core/text/data/Broken indent demo.odt new file mode 100644 index ..af5928bfa556 Binary files /dev/null and b/sw/qa/core/text/data/Broken indent demo.odt differ diff --git a/sw/qa/core/text/data/tdf156146.fodt b/sw/qa/core/text/data/tdf156146.fodt new file mode 100644 index ..1587cd945e49 --- /dev/null +++ b/sw/qa/core/text/data/tdf156146.fodt @@ -0,0 +1,281 @@ + +http://www.w3.org/TR/css3-text/; xmlns:grddl="http://www.w3.org/2003/g/data-view#; xmlns:xhtml="http://www.w3.org/1999/xhtml; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:xforms="http://www.w3.org/2002/xforms; xmlns:dom="http://www.w3.org/2001/xml-events; xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" xmlns:ooo="http://openoffice.org/2004/office; xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" xmlns:ooow="http://openoffice.org/2004/writer; xmlns:xlink="http://www.w3.org/1999/xlink; xmlns:drawooo="http://openoffice.org/2010/draw; xmlns:oooc="http://openoffice.org/2004/calc; xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:c alcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" xmlns:tableooo="http://openoffice.org/2009/table; xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:rpt="http://openoffice.org/2005/report; xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:officeooo="http://openoffice.org/2009/office; xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0" xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:meta="urn:oasis:names:tc:opendocument:xmlns: meta:1.0" xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0" office:version="1.3" office:mimetype="application/vnd.oasis.opendocument.text"> + 2023-06-14T01:10:01.4975110772024-04-18T18:00:26.359273842PT14M47S2ZetaOffice/7.4.8.0.0$Linux_X86_64 LibreOffice_project/b82f1163cc2fc696cf86209d94d838d04998350f + + + false + false + false + true + true + true + true + true + false + 0 + false + false + false + true + false + false + true + false + false + false + false + true + true + true + false + false + false + false + false + false + false + false + true + false + false + true + false + false + false + true + 0 + 1 + true + false + + high-resolution + true + + + false + false + true + false + true + true + true + false + true + + true + 910346 + + true + false + true + true + 0 + + false + false + false + true + false + true + 0 + false + false + false + false + true + false + false + false + + false + false + true + false + false + false + false + false + false + false + false + false + 811422 + false + false + false + false + false + true + false + true + true + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
[Bug 136905] NB Layout tab 'Page Size' drop list UX is poor
https://bugs.documentfoundation.org/show_bug.cgi?id=136905 --- Comment #13 from Justin L --- bug 159865 showed that for different people, the size ends up being different. So all the work done here was reverted. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160734] Support exporting to Markdown
https://bugs.documentfoundation.org/show_bug.cgi?id=160734 --- Comment #3 from Eyal Rozenberg --- (In reply to Stéphane Guillou (stragu) from comment #1) > Import and Export filters are good, less controversial first steps in > Markdown support. But as you said, the challenge is picking a flavour. Right. And I know I said CommonMark, but then - Tables are important :-) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160734] Support exporting to Markdown
https://bugs.documentfoundation.org/show_bug.cgi?id=160734 --- Comment #3 from Eyal Rozenberg --- (In reply to Stéphane Guillou (stragu) from comment #1) > Import and Export filters are good, less controversial first steps in > Markdown support. But as you said, the challenge is picking a flavour. Right. And I know I said CommonMark, but then - Tables are important :-) -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160734] Support exporting to Markdown
https://bugs.documentfoundation.org/show_bug.cgi?id=160734 --- Comment #2 from Eyal Rozenberg --- (In reply to Stéphane Guillou (stragu) from comment #1) > (I consider "Save As" to be very different, and a lot more difficult to > implement, as it would imply that LO supports _editing_ markdown files. The opening comment of the other bug says "One way I could imagine such a support is by export tables created in Calc to Markdown syntax." Also, I'm not sure how exactly you're making that distinction. If you can import a file format and export to it, then your app is an editor of that format. Perhaps not a great editor, nor an editor with "idempotence" over import-then-export, but an editor nonetheless. ... but maybe I'm misunderstanding? Also note I am not asking for Markdown _import_ support, at least not with this bug. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160734] Support exporting to Markdown
https://bugs.documentfoundation.org/show_bug.cgi?id=160734 --- Comment #2 from Eyal Rozenberg --- (In reply to Stéphane Guillou (stragu) from comment #1) > (I consider "Save As" to be very different, and a lot more difficult to > implement, as it would imply that LO supports _editing_ markdown files. The opening comment of the other bug says "One way I could imagine such a support is by export tables created in Calc to Markdown syntax." Also, I'm not sure how exactly you're making that distinction. If you can import a file format and export to it, then your app is an editor of that format. Perhaps not a great editor, nor an editor with "idempotence" over import-then-export, but an editor nonetheless. ... but maybe I'm misunderstanding? Also note I am not asking for Markdown _import_ support, at least not with this bug. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 153761] FILESAVE ODT->DOCX hatch fill in shape is lost
https://bugs.documentfoundation.org/show_bug.cgi?id=153761 Justin L changed: What|Removed |Added Whiteboard|target:24.8.0 target:24.2.2 | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160736] New: FILESAVE, Options not saved when closing the solver window
https://bugs.documentfoundation.org/show_bug.cgi?id=160736 Bug ID: 160736 Summary: FILESAVE, Options not saved when closing the solver window Product: LibreOffice Version: 24.2.1.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nico...@degand.net Description: Solver options are not saved when you close the solver dialog box (contrary to the solver parameters) and a fortiori when saving the file Steps to Reproduce: 1. Edit an option in the solver options dialog box 2. Leave the solver options dialog box 3. Leave the solver dialog box 4. Open the solver dialog box 5. Open the solver options dialog box Actual Results: The option edited in step 1 is back to default Expected Results: The option edited in step 1 should remain as edited Reproducible: Always User Profile Reset: No Additional Info: Version: 24.2.1.2 (X86_64) / LibreOffice Community Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: fr-FR (fr_FR); UI: fr-FR Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: sc/qa sc/source
sc/qa/unit/tiledrendering2/data/multi-selection.ods |binary
sc/qa/unit/tiledrendering2/tiledrendering2.cxx | 45
sc/source/ui/view/viewfun3.cxx |8 +++
3 files changed, 53 insertions(+)
New commits:
commit 4ffe06a81866a2c9f8598d194e04c114cc083119
Author: Miklos Vajna
AuthorDate: Fri Apr 19 08:51:34 2024 +0200
Commit: Miklos Vajna
CommitDate: Fri Apr 19 17:14:37 2024 +0200
cool#8789 sc lok: fix copy for multi-selections
Select A1+A3 in Calc, copy, try to paste in B1, nothing happens.
This is because lok::Document::getSelectionTypeAndText() for a Calc
document ends up in ScViewFunc::CopyToTransferable(), which only handles
the SC_MARK_SIMPLE* cases.
Fix the problem by implementing support for SC_MARK_MULTI, similar to
what ScCellShell::ExecuteEdit() does in the SID_COPY case, which also
calls CopyToClip().
Keep the test highlevel as the Calc shell doesn't seem to have an easy
function to do the same as the Ctrl-click on a cell without duplicating
lots of code in the testcase.
Change-Id: I641d9db95ca391a4f39d96aeeb33422129262288
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166279
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sc/qa/unit/tiledrendering2/data/multi-selection.ods
b/sc/qa/unit/tiledrendering2/data/multi-selection.ods
new file mode 100644
index ..9436aaf93c26
Binary files /dev/null and
b/sc/qa/unit/tiledrendering2/data/multi-selection.ods differ
diff --git a/sc/qa/unit/tiledrendering2/tiledrendering2.cxx
b/sc/qa/unit/tiledrendering2/tiledrendering2.cxx
index 058e7deb0883..65a85c685b33 100644
--- a/sc/qa/unit/tiledrendering2/tiledrendering2.cxx
+++ b/sc/qa/unit/tiledrendering2/tiledrendering2.cxx
@@ -17,6 +17,8 @@
#include
#include
#include
+#include
+#include
#include
@@ -79,6 +81,7 @@ class ViewCallback final
public:
std::map m_aStateChanges;
+tools::Rectangle m_aCellCursorBounds;
TestLokCallbackWrapper m_callbackWrapper;
ViewCallback()
@@ -108,6 +111,20 @@ public:
{
switch (nType)
{
+case LOK_CALLBACK_CELL_CURSOR:
+{
+uno::Sequence aSeq =
comphelper::string::convertCommaSeparated(
+OUString::createFromAscii(pPayload));
+m_aCellCursorBounds = tools::Rectangle();
+if (aSeq.getLength() >= 4)
+{
+m_aCellCursorBounds.SetLeft(aSeq[0].toInt32());
+m_aCellCursorBounds.SetTop(aSeq[1].toInt32());
+m_aCellCursorBounds.setWidth(aSeq[2].toInt32());
+m_aCellCursorBounds.setHeight(aSeq[3].toInt32());
+}
+}
+break;
case LOK_CALLBACK_STATE_CHANGED:
{
std::stringstream aStream(pPayload);
@@ -159,6 +176,34 @@ CPPUNIT_TEST_FIXTURE(Test, testSidebarLocale)
std::string aLocale = it->second.get("locale");
CPPUNIT_ASSERT_EQUAL(std::string("de-DE"), aLocale);
}
+
+CPPUNIT_TEST_FIXTURE(Test, testCopyMultiSelection)
+{
+// Given a document with A1 and A3 as selected cells:
+ScModelObj* pModelObj = createDoc("multi-selection.ods");
+ViewCallback aView1;
+// Get the center of A3:
+uno::Sequence aPropertyValues = {
+comphelper::makePropertyValue("ToPoint", OUString("$A$3")),
+};
+dispatchCommand(mxComponent, ".uno:GoToCell", aPropertyValues);
+Point aPoint = aView1.m_aCellCursorBounds.Center();
+// Go to A1:
+aPropertyValues = {
+comphelper::makePropertyValue("ToPoint", OUString("$A$1")),
+};
+dispatchCommand(mxComponent, ".uno:GoToCell", aPropertyValues);
+// Ctrl-click on A3:
+int nCtrl = KEY_MOD1;
+pModelObj->postMouseEvent(LOK_MOUSEEVENT_MOUSEBUTTONDOWN, aPoint.getX(),
aPoint.getY(), 1,
+ MOUSE_LEFT, nCtrl);
+
+// When getting the selection:
+uno::Reference xTransferable =
pModelObj->getSelection();
+
+// Make sure we get A1+A3 instead of an error:
+CPPUNIT_ASSERT(xTransferable.is());
+}
}
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/ui/view/viewfun3.cxx b/sc/source/ui/view/viewfun3.cxx
index ee2cccf72f35..1c918ff1c04d 100644
--- a/sc/source/ui/view/viewfun3.cxx
+++ b/sc/source/ui/view/viewfun3.cxx
@@ -458,6 +458,14 @@ rtl::Reference
ScViewFunc::CopyToTransferable()
return new ScTransferObj( std::move(pClipDoc), std::move(aObjDesc)
);
}
}
+else if (eMarkType == SC_MARK_MULTI)
+{
+ScDocumentUniquePtr pClipDoc(new ScDocument(SCDOCMODE_CLIP));
+// This takes care of the input line and calls CopyToClipMultiRange()
for us.
+CopyToClip(pClipDoc.get(), /*bCut=*/false, /*bApi=*/true);
+TransferableObjectDescriptor aObjDesc;
+return new ScTransferObj(std::move(pClipDoc), std::move(aObjDesc));
+}
[Bug 160725] XLOOKUP has different result for approximate search than Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=160725 Balázs Varga (allotropia) changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |balazs.varga...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 131531] FILESAVE ODT->DOCX: Header height of first page is not reserved
https://bugs.documentfoundation.org/show_bug.cgi?id=131531 Justin L changed: What|Removed |Added Severity|normal |minor Priority|medium |low -- You are receiving this mail because: You are the assignee for the bug.
[Bug 113335] [META] XLSX (OOXML) hyperlink bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=113335 Bug 113335 depends on bug 65136, which changed state. Bug 65136 Summary: FILESAVE, FILEOPEN: XLS, XLSX partial-cell hyperlink is reloaded as full-cell hyperlink https://bugs.documentfoundation.org/show_bug.cgi?id=65136 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107733] [META] Hyperlink bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107733 Bug 107733 depends on bug 65136, which changed state. Bug 65136 Summary: FILESAVE, FILEOPEN: XLS, XLSX partial-cell hyperlink is reloaded as full-cell hyperlink https://bugs.documentfoundation.org/show_bug.cgi?id=65136 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.
