Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22379
@HyukjinKwon Thank you for your work on the PR. @cloud-fan @felixcheung
@dongjoon-hyun @gatorsmile Thanks for your reviews.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22379
Thanks all!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22379
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97455/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97455 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97455/testReport)**
for PR 22379 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97455 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97455/testReport)**
for PR 22379 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97440/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97440 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97440/testReport)**
for PR 22379 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97440 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97440/testReport)**
for PR 22379 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22379
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97429/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97429 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97429/testReport)**
for PR 22379 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22379
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97429 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97429/testReport)**
for PR 22379 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97383/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97383 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97383/testReport)**
for PR 22379 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97385/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97385 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97385/testReport)**
for PR 22379 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22379
Sorry, I missed that comment. I replied in that comment.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22379
have you addressed
https://github.com/apache/spark/pull/22379/files#r225033808 ?
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97385 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97385/testReport)**
for PR 22379 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97383 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97383/testReport)**
for PR 22379 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22379
While addressing the review comments, I also reviewed at the same time. The
change looks pretty good to go.
For https://github.com/apache/spark/pull/22379#issuecomment-429738031, I
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22379
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22379
I wouldn't too, but there's no way for using `schema_of_csv` otherwise ..
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22379
I wouldn't make schema a `Columm`. `Column` means it's dynamic, while I
think it should be a static value, to simplify the implementation.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22379
Like ..
```
val csvData = "a,1,2"
from_csv(column, schema = schema_of_csv(lit(csvData)))
```
---
-
To
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22379
BTW how would the `schema_of_csv` function help with `from_csv`?
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22379
Looks pretty good! just one minor commet
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97341/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97341 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97341/testReport)**
for PR 22379 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97341 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97341/testReport)**
for PR 22379 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22379
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97336/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97336 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97336/testReport)**
for PR 22379 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97336 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97336/testReport)**
for PR 22379 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22379
jenkins, retest this, please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97330 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97330/testReport)**
for PR 22379 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97330/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97330 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97330/testReport)**
for PR 22379 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97319/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97319 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97319/testReport)**
for PR 22379 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97319 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97319/testReport)**
for PR 22379 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97313/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97313 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97313/testReport)**
for PR 22379 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97313 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97313/testReport)**
for PR 22379 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22379
From 15th this month, I will address comments at @MaxGekk's PRs when I have
some time and I will directly push to his branches. Please I would appreciate
if those PRs are kept being reviewed.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22379
Looks pretty much getting close to go.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22379
Looks pretty mush getting close to go.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97274/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97274 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97274/testReport)**
for PR 22379 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97274 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97274/testReport)**
for PR 22379 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97263 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97263/testReport)**
for PR 22379 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22379
jenkins, retest this, please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97263/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97245/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97245 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97245/testReport)**
for PR 22379 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97263 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97263/testReport)**
for PR 22379 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97245 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97245/testReport)**
for PR 22379 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97017/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97017 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97017/testReport)**
for PR 22379 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97017 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97017/testReport)**
for PR 22379 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96990/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #96990 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96990/testReport)**
for PR 22379 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #96990 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96990/testReport)**
for PR 22379 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96952/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #96952 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96952/testReport)**
for PR 22379 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #96952 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96952/testReport)**
for PR 22379 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96904/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #96904 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96904/testReport)**
for PR 22379 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #96904 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96904/testReport)**
for PR 22379 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22379
I am going to re-target to the PR back to Spark 3.0 since I was told we
skip Spark 2.5.
---
-
To unsubscribe, e-mail:
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22379
Could you take a look at the PR one more time, please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96802/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #96802 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96802/testReport)**
for PR 22379 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #96802 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96802/testReport)**
for PR 22379 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #96801 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96801/testReport)**
for PR 22379 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96801/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #96801 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96801/testReport)**
for PR 22379 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22379
Something wrong with build, it takes old version of a class.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
1 - 100 of 213 matches
Mail list logo