Re: xf86EnableIO & ExtendedEnabled vs. the input thread
On 01/31/19 07:23 AM, Adam Jackson wrote:
On Wed, 2019-01-23 at 14:22 -0800, Alan Coopersmith wrote:
Is there any reason we just don't drop ExtendedEnabled altogether and
just always pass the calls through to the kernel? That'd leave us
still needing to call xf86EnableIO() in the input thread on Solaris,
unlike Linux, but that's more sensible than forcing a DisableIO()
first just to reset the ExtendedEnabled state.
I can't think of a good reason to track ExtendedEnabled, no. All of the
implementations look like they're idempotent (though I had to read the
weird Linux ppc thing twice to be sure). The ExtendedEnabled logic
itself seems to predate XFree86 4.0, which is back far enough in the
dark ages that I don't think we'd ever find a useful changelog for its
motivation. I say nuke it.
Okay, I'll do that - but that then leaves the problem of how to enable it in
the input thread, since the input thread is in the core/shared X server code,
but needs to call a routine in the XFree86 DDX.
My current unclean solution is:
index 97e59d21f..8c8bf090a 100644
--- a/os/inputthread.c
+++ b/os/inputthread.c
@@ -39,6 +39,10 @@
#include "opaque.h"
#include "osdep.h"
+#ifdef __sun
+#include
+#endif
+
#if INPUTTHREAD
Bool InputThreadEnable = TRUE;
@@ -326,6 +330,16 @@ InputThreadDoWork(void *arg)
pthread_setname_np ("InputThread");
#endif
+#ifdef __sun
+{
+Bool (*enableIO)(void) = (Bool (*)(void))
+dlsym(RTLD_PROBE, "xf86EnableIO");
+
+if (enableIO != NULL)
+(*enableIO)();
+}
+#endif
+
ospoll_add(inputThreadInfo->fds, hotplugPipeRead,
ospoll_trigger_level,
InputThreadPipeNotify,
but I'm guessing instead we should have some sort of callback or ddx-specific
initialization called from inputthread, that happens to be an empty stub
everywhere but the xf86 ddx for Solaris.
Thoughts on that?
Thanks,
-alan-
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
[ANNOUNCE] xcursor-themes 1.0.6
This is a default set of cursor themes for use with libXcursor, originally created for the XFree86 Project, and now shipped as part of the X.Org software distribution. This release adds some symlinks to the whiteglass cursor theme to provide additional cursor names that gnome-shell expects, so that gnome-shell doesn't crash when using trying to use those cursors. Alan Coopersmith (3): Update README for gitlab migration Update configure.ac bug URL for gitlab migration xcursor-themes 1.0.6 Paul Hebble (1): Add missing symlinks for whiteglass git tag: xcursor-themes-1.0.6 https://xorg.freedesktop.org/archive/individual/data/xcursor-themes-1.0.6.tar.bz2 MD5: aea14eabf40528ec4db18f1cfcf5c458 xcursor-themes-1.0.6.tar.bz2 SHA1: b56fd5bf5b1ada0532a85c27db0d296e392168c5 xcursor-themes-1.0.6.tar.bz2 SHA256: ee1ec574741293abcf66ac14ce7e74add7ac6be7deb8b38179ef010d22354999 xcursor-themes-1.0.6.tar.bz2 SHA512: 2ad3586a5571a5ddc0001187362b54b839644916164834213af98e58698044aec4392dd6e1e42f1794fda85c8fedf259b09214a9636bd0e71a1629c710f198d3 xcursor-themes-1.0.6.tar.bz2 PGP: https://xorg.freedesktop.org/archive/individual/data/xcursor-themes-1.0.6.tar.bz2.sig https://xorg.freedesktop.org/archive/individual/data/xcursor-themes-1.0.6.tar.gz MD5: 76f7f7706118e8faa53ba2901762391d xcursor-themes-1.0.6.tar.gz SHA1: 916ef26cd1b41f12f80d0ad5ec7f176277b60267 xcursor-themes-1.0.6.tar.gz SHA256: 22638f7bd6257adf889d25af9c8a7b2cfdcf5a5e18339d25fbb092dbf6c663c1 xcursor-themes-1.0.6.tar.gz SHA512: 6afe6a3126f9104f3cbf2001c2a972dfdf615660ec57ad455ea24f79b12c493b8eeec542edf7293b34083d1669baeb6b9ad9cb303f646c6704a67675aa3cfb9c xcursor-themes-1.0.6.tar.gz PGP: https://xorg.freedesktop.org/archive/individual/data/xcursor-themes-1.0.6.tar.gz.sig -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - https://blogs.oracle.com/alanc signature.asc Description: PGP signature ___ xorg-announce mailing list xorg-announce@lists.x.org https://lists.x.org/mailman/listinfo/xorg-announce
[ANNOUNCE] xcursor-themes 1.0.6
This is a default set of cursor themes for use with libXcursor, originally created for the XFree86 Project, and now shipped as part of the X.Org software distribution. This release adds some symlinks to the whiteglass cursor theme to provide additional cursor names that gnome-shell expects, so that gnome-shell doesn't crash when using trying to use those cursors. Alan Coopersmith (3): Update README for gitlab migration Update configure.ac bug URL for gitlab migration xcursor-themes 1.0.6 Paul Hebble (1): Add missing symlinks for whiteglass git tag: xcursor-themes-1.0.6 https://xorg.freedesktop.org/archive/individual/data/xcursor-themes-1.0.6.tar.bz2 MD5: aea14eabf40528ec4db18f1cfcf5c458 xcursor-themes-1.0.6.tar.bz2 SHA1: b56fd5bf5b1ada0532a85c27db0d296e392168c5 xcursor-themes-1.0.6.tar.bz2 SHA256: ee1ec574741293abcf66ac14ce7e74add7ac6be7deb8b38179ef010d22354999 xcursor-themes-1.0.6.tar.bz2 SHA512: 2ad3586a5571a5ddc0001187362b54b839644916164834213af98e58698044aec4392dd6e1e42f1794fda85c8fedf259b09214a9636bd0e71a1629c710f198d3 xcursor-themes-1.0.6.tar.bz2 PGP: https://xorg.freedesktop.org/archive/individual/data/xcursor-themes-1.0.6.tar.bz2.sig https://xorg.freedesktop.org/archive/individual/data/xcursor-themes-1.0.6.tar.gz MD5: 76f7f7706118e8faa53ba2901762391d xcursor-themes-1.0.6.tar.gz SHA1: 916ef26cd1b41f12f80d0ad5ec7f176277b60267 xcursor-themes-1.0.6.tar.gz SHA256: 22638f7bd6257adf889d25af9c8a7b2cfdcf5a5e18339d25fbb092dbf6c663c1 xcursor-themes-1.0.6.tar.gz SHA512: 6afe6a3126f9104f3cbf2001c2a972dfdf615660ec57ad455ea24f79b12c493b8eeec542edf7293b34083d1669baeb6b9ad9cb303f646c6704a67675aa3cfb9c xcursor-themes-1.0.6.tar.gz PGP: https://xorg.freedesktop.org/archive/individual/data/xcursor-themes-1.0.6.tar.gz.sig -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - https://blogs.oracle.com/alanc signature.asc Description: PGP signature ___ xorg@lists.x.org: X.Org support Archives: http://lists.freedesktop.org/archives/xorg Info: https://lists.x.org/mailman/listinfo/xorg Your subscription address: %(user_address)s
