[GitHub] flink pull request #6411: [FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputForm...
GitHub user Lemonjing reopened a pull request: https://github.com/apache/flink/pull/6411 [FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputFormat before closing, to ensure CI stability ## What is the purpose of the change This pull request update scala api `ScalaCsvOutputFormat` to increase CI stability. ## Brief change log Add flush method before close function in ScalaCsvOutputFormat for scala API. ## Verifying this change Add `ScalaCsvOutputFormatTest` and test passed. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation Does this pull request introduce a new feature? (yes / **no**) If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**) You can merge this pull request into a Git repository by running: $ git pull https://github.com/Lemonjing/flink csv-close-hotfix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6411.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6411 commit 95a9b60b1ece7d248755d92868e682c4ee0fd334 Author: lemonjing <932191671@...> Date: 2018-07-25T07:06:10Z [FLINK-9941][ScalaAPI] flush in ScalaCsvOutputFormat before closing, to ensure CI stability ---
[GitHub] flink pull request #6411: [FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputForm...
Github user Lemonjing closed the pull request at: https://github.com/apache/flink/pull/6411 ---
[GitHub] flink pull request #6411: [FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputForm...
GitHub user Lemonjing opened a pull request: https://github.com/apache/flink/pull/6411 [FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputFormat before closing, to ensure CI stability ## What is the purpose of the change This pull request update scala api `ScalaCsvOutputFormat` to increase CI stability. ## Brief change log Add flush method before close function in ScalaCsvOutputFormat for scala API. ## Verifying this change This change is already covered by existing tests, such as ScalarFunctionsTest ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation Does this pull request introduce a new feature? (yes / **no**) If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**) You can merge this pull request into a Git repository by running: $ git pull https://github.com/Lemonjing/flink csv-close-hotfix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6411.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6411 commit 6c6120722eef81c2c275b92a13a5687fef35e7bb Author: lemonjing <932191671@...> Date: 2018-07-25T05:46:55Z [hotfix] Flush in ScalaCsvOutputFormat before closing, to ensure CI stability ---
[GitHub] spark pull request #20897: [MINOR][DOC] Fix a few markdown typos
Github user Lemonjing commented on a diff in the pull request:
https://github.com/apache/spark/pull/20897#discussion_r178481268
--- Diff: docs/mllib-pmml-model-export.md ---
@@ -7,15 +7,15 @@ displayTitle: PMML model export - RDD-based API
* Table of contents
{:toc}
-## `spark.mllib` supported models
--- End diff --
backquotes in mds cause display problems (see
http://spark.apache.org/docs/latest/mllib-pmml-model-export.html)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20897: [MINOR][DOC] Fix a few markdown typos
Github user Lemonjing commented on the issue: https://github.com/apache/spark/pull/20897 see http://spark.apache.org/docs/latest/ml-features.html#elementwiseproduct --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20897: [MINOR][DOC] Fix a few markdown typos
Github user Lemonjing commented on a diff in the pull request: https://github.com/apache/spark/pull/20897#discussion_r177113075 --- Diff: docs/mllib-feature-extraction.md --- @@ -278,8 +278,8 @@ for details on the API. multiplication. In other words, it scales each column of the dataset by a scalar multiplier. This represents the [Hadamard product](https://en.wikipedia.org/wiki/Hadamard_product_%28matrices%29) between the input vector, `v` and transforming vector, `scalingVec`, to yield a result vector. -Qu8T948*1# --- End diff -- @HyukjinKwon If the original author did not reply, you can look at my latest reply and confirm this confused character sequence. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20897: [MINOR][DOC] Fix a few markdown typos
Github user Lemonjing commented on the issue: https://github.com/apache/spark/pull/20897 @HyukjinKwon The description of ElementwiseProduct is obvious, and i think "`Qu8T948*1#`" is a mistake, if not, "`Qu8T948*1#`" is a input vector and 1 is scaling vector, and this is not a good example to express vector, even so, there is markdown syntax error. By the way, there is no example context here, such as "e.g."ï¼"for example" or something else. And i have queried the history and found another evidence. Before spark v1.6.0, this file do not have "`Qu8T948*1#`". So this maybe a mistake in one commit at v1.6.0 and this mistake not be found or fixed across v1.6.0 to now. ... https://github.com/apache/spark/blob/v1.4.1/docs/mllib-feature-extraction.md no https://github.com/apache/spark/blob/v1.5.0/docs/mllib-feature-extraction.md no https://github.com/apache/spark/blob/v1.5.2/docs/mllib-feature-extraction.md no https://github.com/apache/spark/blob/v1.6.0/docs/mllib-feature-extraction.md yes 1.6.0 ~ 2.3.0 yes Thanks, and hope to confirm it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20889: [MINOR][DOC] Fix ml-guide markdown typos
Github user Lemonjing closed the pull request at: https://github.com/apache/spark/pull/20889 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos
Github user Lemonjing commented on the issue: https://github.com/apache/spark/pull/20889 @felixcheung thanks a lot. and i closed it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos
Github user Lemonjing commented on the issue: https://github.com/apache/spark/pull/20889 can someone help me to close this pr? i have merged these commits to a new pr. https://github.com/apache/spark/pull/20897 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20897: [MINOR][DOC] Fix a few markdown typos
GitHub user Lemonjing opened a pull request: https://github.com/apache/spark/pull/20897 [MINOR][DOC] Fix a few markdown typos ## What changes were proposed in this pull request? Easy fix in the markdown. ## How was this patch tested? jekyII build test manually. Please review http://spark.apache.org/contributing.html before opening a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Lemonjing/spark master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/20897.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20897 commit 937bbef522eedddbcb502f7f9692564040a63cd7 Author: lemonjing <932191671@...> Date: 2018-03-24T04:45:43Z [MINOR][DOC] Fix a few markdown typos --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos
Github user Lemonjing commented on the issue: https://github.com/apache/spark/pull/20889 @HyukjinKwon Thanks a lot, could u help me to review these commits if u have timeã --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos
Github user Lemonjing commented on the issue: https://github.com/apache/spark/pull/20889 @felixcheung hiï¼In my reading processï¼I found another md file typos and fix it. Do I need to close this pr and merge it into one commit and give a new pr? Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos
Github user Lemonjing commented on the issue: https://github.com/apache/spark/pull/20889 @felixcheung Yes, I read the entire docs of Spark Mlib. There is no problem with other mds (I may not have seen it or other contributors solved it). This error is obvious, and it affects the link of the later issue, so i found it. [http://spark.apache.org/docs/latest/ml-guide.html#breaking-changes](url) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20889: [MINOR][DOC] Fix ml-guide markdown typos
GitHub user Lemonjing opened a pull request: https://github.com/apache/spark/pull/20889 [MINOR][DOC] Fix ml-guide markdown typos ## What changes were proposed in this pull request? Easy fix in the markdown. ## How was this patch tested? Tested manually Please review http://spark.apache.org/contributing.html before opening a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Lemonjing/spark master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/20889.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20889 commit be9cadb83fadae8099afe050ef8f99c7589e942a Author: lemonjing <932191671@...> Date: 2018-03-23T05:48:42Z [MINOR][DOC] Fix ml-guide markdown typos --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
