[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
ftynse wrote: > 10 separate commits/PRs for the same exact sed costs more in commit noise > (and effort on the part of @e-kwsm) than one solid, patient, review here Not unless you subscribe only to a subproject. FWIW, I'm not comfortable blanket approving changes, however trivial, to subprojects I'm not actively working on, and I suspect most folks here are not. Subprojects may have some ongoing work that will be disrupted or reasons why they chose the suboptimal implementation. https://github.com/llvm/llvm-project/pull/91857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
https://github.com/ftynse approved this pull request. LGTM for the MLIR part. Please seek approval from relevant reviewers for all other subprojects. https://github.com/llvm/llvm-project/pull/91857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
ftynse wrote: This should be included in the actual commit, not GitHub comments. https://github.com/llvm/llvm-project/pull/91857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
ftynse wrote: Please provide a proper patch description, i.e., why the change is being made. https://github.com/llvm/llvm-project/pull/91857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[mlir] [lld] [openmp] [llvm] [compiler-rt] [libcxx] [clang] [flang] [libc] [lldb] [libcxxabi] [clang-tools-extra] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)
https://github.com/ftynse closed https://github.com/llvm/llvm-project/pull/79626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[flang] [libc] [clang] [libcxxabi] [lld] [mlir] [lldb] [compiler-rt] [openmp] [clang-tools-extra] [llvm] [libcxx] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)
ftynse wrote: Looks like whatever Windows container it runs on is missing a numpy installation. Not correlated with this patch in any way. https://github.com/llvm/llvm-project/pull/79626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[lld] [clang-tools-extra] [clang] [flang] [openmp] [compiler-rt] [mlir] [llvm] [libc] [lldb] [libcxx] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)
https://github.com/ftynse approved this pull request. https://github.com/llvm/llvm-project/pull/79626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [mlir][llvm] Fix elem type passing into `getelementptr` (PR #68136)
https://github.com/ftynse approved this pull request. https://github.com/llvm/llvm-project/pull/68136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [mlir][llvm] Fix elem type passing into `getelementptr` (PR #68136)
ftynse wrote: What I meant in the comment was that MLIR doesn't need to make a hard switch to using opaque pointers and immediately turn off typed pointers. I didn't really imply that an operations in the IR should freely mix the two. Typed pointers should and will be removed from the LLVM dialect as well. I consider any significant investment into typed pointer support, let alone a "mixed mode", a waste of time. Since this PR fixes a crash, I'm fine with it landing as is instead of spending cycles on an arguably better fix that will get removed within months as I hope opaque pointers to be gone from the dialect by the next release. Improving verifiers otherwise is greatly appreciated! https://github.com/llvm/llvm-project/pull/68136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] Added erase() to fix memory leak of mlir/unittests/IR/InterfaceTest.cpp (PR #65583)
https://github.com/ftynse approved this pull request. https://github.com/llvm/llvm-project/pull/65583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
