Bug#730528: [php-maint] Bug#730528: Enable dtrace/systemtap support
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 06/12/2013 10:05, Ondřej Surý a écrit : Hi Vincent, could you please elaborate more? What benefits would that have to general users and is there any performance (or any other) drawbacks in enabling this? Remi, do you enable this on Fedora builds (or do you have any plans to do so?). Yes dtrace is enabled in Fedora for PHP 5.5 build. Notice, this cause 1 test failing because of stack size limit, not a big issue, but this means stack consumption is greater, so have to be increase in some (very rare) cases. Remi. -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlKhoO0ACgkQYUppBSnxahh+NgCdEXnVGt88pbJ1N7KyyW9CY0Zs WtcAoLIMYNAvg9PJvXPmfuOZCP+TsUNW =5PdW -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: Fedora 20 Final blocker - Please add symfony packages.
Le 28/11/2013 03:25, Adam Williamson a écrit : Hi, folks. We have just over one week to the Fedora 20 Go/No-Go meeting, and a big happy pile of blocker bugs - everyone's having fun! In order to be able to complete testing in time for the go/no-go meeting Please consider for F20Final: https://bugzilla.redhat.com/show_bug.cgi?id=1021749 https://admin.fedoraproject.org/updates/FEDORA-2013-22356 Having a broken PHPUnit in F20 will make most of the PHP packages FTBFS. Note: retiring a package before the new one is pushed is just a VERY bad idea (despite comment#34 on bz) Remi. -- test mailing list test@lists.fedoraproject.org To unsubscribe: https://admin.fedoraproject.org/mailman/listinfo/test
Re: [Glpi-dev] [Glpi-user] Plugin Réforme
Le 19/11/2013 21:08, Viduc a écrit : Bonjour Je viens de réaliser un plugin pour GLPI. Ce plugin a comme objectif de gérer la réforme d'une machine: 1/ retire le nom de la fiche glpi et le met en comentaire 2/ passe le statut de la machine à réformé (ou autre) 3/ retire la machine du domaine (si la machine appartient à un domaine) 4/ créé un bon de réforme avec les informations financières 5/ envoie le bon de réforme par mail à une adresse 6/ supprime la fiche glpi de la machine Est-ce qu'un partie de ces besoins ne sont pas déjà couvert par le plugin uninstall ? Et l'impression par le plugin PDF ? Le plugin est fonctionnel à 95%. Je dois encore réaliser quelques tests à plus grande échelle. J'utilise plusieurs librairies libres: -Smarty (moteur de template pour gérer les vues) J'ai rien compte, mais c'est pas dans les standard de GLPI. -adldap (pour la partie gestion Active Directory) -fpdf (pour le création du bon de réforme au format pdf) Je pense qu'il serait préférable d'utiliser tcpdf, qui est la bibliothèque utilisée dans GLPI 0.85. Mes 0,02€ Remi. ___ Glpi-dev mailing list Glpi-dev@gna.org https://mail.gna.org/listinfo/glpi-dev
Re: [Dotclear Dev] Nouveau commentaire
Le 15/11/2013 10:26, Nicolas a écrit : Bonjour Rémi, Le 15 novembre 2013 06:57, Remi Collet r...@famillecollet.com a écrit : Salut, Dans la version 2.6, l'ajout des commentaires sous la liste est très pratique (pour les réponses, on a la question sous les yeux). Par contre, pas d'éditeur enrichi ? Ça oblige a créer le commentaire, puis à le modifier.. Bon, il manquait déjà la possibilité de le publier directement, mais c'est moins gênant, ça oblige à se relire ;) Ça vous semble possible à ajouter ? Oui. Tu nous crées un ticket : dev.dotclear.org/2.0/newticket ? Désolé, mais je pige pas comment je me connecte sur le track. NIcolas -- Dev mailing list - Dev@list.dotclear.org - http://ml.dotclear.org/listinfo/dev
Re: [Dotclear Dev] Nouveau commentaire
Le 15/11/2013 12:46, Nicolas a écrit : Oui. Tu nous crées un ticket : dev.dotclear.org/2.0/newticket ? http://dev.dotclear.org/2.0/ticket/1868 Merci -- Dev mailing list - Dev@list.dotclear.org - http://ml.dotclear.org/listinfo/dev
[Dotclear Dev] Nouveau commentaire
Salut, Dans la version 2.6, l'ajout des commentaires sous la liste est très pratique (pour les réponses, on a la question sous les yeux). Par contre, pas d'éditeur enrichi ? Ça oblige a créer le commentaire, puis à le modifier.. Bon, il manquait déjà la possibilité de le publier directement, mais c'est moins gênant, ça oblige à se relire ;) Ça vous semble possible à ajouter ? Remi. P.S. http://blog.famillecollet.com/fr -- Dev mailing list - Dev@list.dotclear.org - http://ml.dotclear.org/listinfo/dev
Re: [Dotclear Dev] 2.6 et free.fr
Le 14/11/2013 13:50, Laurence Furic a écrit : Il y a beaucoup plus de personnes qui n'accèdent pas au tout dernier cri et qui lorsqu'elles y accèdent, continuent d'utiliser un modèle qui est ancien pendant beaucoup plus longtemps parce que ce n'est pas encore dans leur culture qu'il faille monter d'un cran tous les trois ou six mois. Il ne faut pas oublier les aspects sécurité. Certains projets on les ressources nécessaires pour maintenir plusieurs versions en parallèle (ex php 5.4 + 5.5, MySQL 5.1 + 5.5 + 5.6, ...), mais je ne pense pas que dotclear maintienne en parallèle les versions 2.4, 2.5 et 2.6 ? (tant mieux si je me trompe). Utiliser des anciennes versions, non maintenues, me semble un risque inconsidéré. Surtout pour un blog qui est par définition accessible en public. Bon... tu me diras, avec un hébergeur qui propose une version tellement obsolète de PHP, on peut pas en demander beaucoup. Donc, la politique de l'autruche (ça marche, ne changeons rien) n'est plus possible de nos jours. Mes 0,02€ Remi. -- Dev mailing list - Dev@list.dotclear.org - http://ml.dotclear.org/listinfo/dev
[PHP-CVS] com php-src: missing 'config.h' in 5dc37b3: ext/zip/lib/config.h
Commit:6997b8793d0fa6e41976dd692c378f0a450de2a5 Author:Remi Collet r...@php.net Sun, 10 Nov 2013 07:10:36 +0100 Parents: 6713f9c4b24b5be0d543f0f87cab0f401b0c41ed Branches: PHP-5.6 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=6997b8793d0fa6e41976dd692c378f0a450de2a5 Log: missing 'config.h' in 5dc37b3 Changed paths: A ext/zip/lib/config.h Diff: diff --git a/ext/zip/lib/config.h b/ext/zip/lib/config.h new file mode 100644 index 000..f9132ba --- /dev/null +++ b/ext/zip/lib/config.h @@ -0,0 +1,25 @@ +/* + +--+ + | PHP Version 5| + +--+ + | Copyright (c) 1997-2013 The PHP Group| + +--+ + | This source file is subject to version 3.01 of the PHP license, | + | that is bundled with this package in the file LICENSE, and is| + | available through the world-wide-web at the following url: | + | http://www.php.net/license/3_01.txt. | + | If you did not receive a copy of the PHP license and are unable to | + | obtain it through the world-wide-web, please send a note to | + | lice...@php.net so we can mail you a copy immediately. | + +--+ + | Author: Pierre-Alain Joye paj...@php.net | + +--+ +*/ +#ifdef HAVE_CONFIG_H +/* Building in PECL */ +#include ../config.h + +#else +/* Building in PHP tree */ +#include php_config.h +#endif -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: Copr
Le 07/11/2013 13:54, Miroslav Suchý a écrit : Dear developers and Fedora contributors, let me introduce Copr: http://copr-fe.cloud.fedoraproject.org/ Very nice tool (from a Copr tester) Thanks a lot. Remi. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: [PECL-DEV] PHP Solr 2.x
Le 20/10/2013 23:49, Omar Abdallah a écrit : I'd like to have the initiative to continue development on the php Solr extension starting from version 2.0.0. Have you check: https://github.com/ecaron/php-pecl-solr http://marc.info/?l=pecl-devm=135066423910915w=2 I think it will be great to have this extension maintained. Regards, Remi. -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PECL-DEV] [ANNOUNCEMENT] lua-1.1.0 (beta) Released.
Le 23/10/2013 06:22, PECL Announce a écrit : The new PECL package lua-1.1.0 (beta) has been released at http://pecl.php.net/. Can you please fix link to sources http://pecl.php.net/package/lua = http://svn.php.net/viewvc/pecl/lua/ Which seems outdated (no version 1.1.0 there) Thanks -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PECL-DEV] Missing License in official archive, so cannot be redistribute extension.
Le 22/10/2013 11:00, Derick Rethans a écrit : On Mon, 21 Oct 2013, Remi Collet wrote: Here is the list of some (in the ~80 I have checked) extensions where the LICENSE file is missing from the official archive of the last released version. So those extensions cannot be redistribute. That's a bit of a useless blanket statement. The package.xml ought to link to the license file, so why not just extract it when it's linked there instead? the packaging system can easily take care of that. I should probably have wrote ...cannot be redistribute easily without hacking. The link in the package.xml is often http://www.php.net/license Which is not enough (which version ?). Some are still v2 or v3 Yes, I often extract the URL from the headers: | This source file is subject to version 3.01 of the PHP license, | that is bundled with this package in the file LICENSE, and is | available through the world-wide-web at the following url: | http://www.php.net/license/3_01.txt. And in all case, when preparing a package, full review of all sources, and bundled library are required. Yes the packager can do the work instead of upstream. Once again, what is the cost of adding this file ? Is this not just respect for downstream distribution ? Remi. -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PECL-DEV] Missing License in official archive, so cannot be redistribute extension.
Here is the list of some (in the ~80 I have checked) extensions where the LICENSE file is missing from the official archive of the last released version. So those extensions cannot be redistribute. Please fix them. 1/ missing but fixed, so will be in next version https://bugs.php.net/65869 dio https://bugs.php.net/65856 hidef https://bugs.php.net/65874 htscanner https://bugs.php.net/65841 inclued https://bugs.php.net/65540 leveldb .../memory-profiler/pull/6 memprof https://bugs.php.net/65864 sphinx fixed in svnuploadprogress https://bugs.php.net/63446 uuid 2/ missing, bug reported, not fixed yet https://bugs.php.net/65859 geoip https://bugs.php.net/65860 lzf https://bugs.php.net/65861 mailparse https://bugs.php.net/65862 ncurses https://bugs.php.net/65937 parsekit https://bugs.php.net/60396 pdflib == closed as wontfix https://bugs.php.net/65156 radius https://bugs.php.net/65850 SPL_Types https://bugs.php.net/65866 sqlite https://bugs.php.net/65884 stats https://bugs.php.net/57944 vld https://bugs.php.net/65842 xattr https://bugs.php.net/65846 xrange https://bugs.php.net/65851 xslcache https://bugs.php.net/65863 yar Cheers, Remi -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PECL-DEV] PECL site improvements
Le 18/10/2013 08:13, Hannes Magnusson a écrit : Am I understanding this correctly... If I don't care for Windows, and don't include a LICENSE file, then the peclweb package upload will still tell me to bug off and reject the package? Worst Idea Ever. This problem affects all downstream distribution. It's really up to a project to provide this file to allow downstream users to respect the License term of the project. Else, it will means: ok, the sources are free, but you can't distribute binaries of this. Remi. -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PECL-DEV] PECL site improvements
Le 18/10/2013 02:23, Christopher Jones a écrit : On 10/14/2013 04:34 AM, Anatol Belski wrote: Hi, there are two improvements just implemented to the PECL website. I Every package is required to have LICENSE or COPYING to be present in the root of the package. The goal is to enforce the conformance with at least PHP and BSD licenses. Where by no explicit check for exact license type is done, it's considered as a good practice to include the license. Also, the licenses will be included into the windows binary packages. To add that file to the tarball, just add a line like this to the root dir in the package.xml file name=LICENSE role=doc / This change just blocked me from releasing OCI8 on PECL. OCI8 has traditionally had the license information (http://www.php.net/license/3_01.txt) mentioned appropriately in the source code and package.xml files. What is the cost for adding this file ? I only recall limited discussion [1] around this topic and no discussion of hard enforcement. The upload form site shouldn't block valid uploads. It should do one of: 1. Only warn about a missing file Once again, this is enough for source distribution, not for binary distribution. 2. Recognize the package.xml license, perhaps just a special case recognizing the PHP license: license uri=http://www.php.net/license;PHP/license (This would be my preference.) I don't think this is possible. Which version of the License ? 3. They can decide not to make distributions if they can't determine the license in a usable form for their use. Yes, this is the solution. Remi. -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PECL-DEV] [ANNOUNCEMENT] newt-1.2.7 (stable) Released.
Le 14/10/2013 14:49, PECL Announce a écrit : The new PECL package newt-1.2.7 (stable) has been released at http://pecl.php.net/. $ tar tf newt-1.2.7.tgz package.xml Can you please update your Archive_Tar version and reupload the archive ? Thanks, Remi. Release notes - Fixed bug #64990 - Segmentation Fault @ newt_checkbox_tree_add_item Fixed bug #65889 - Provide LICENSE file Package Info - PHP-NEWT - PHP language extension for Red Hat Newt library, a terminal-based window and widget library for writing applications with user friendly interface. Once this extension is enabled in PHP it will provide the use of Newt widgets, such as windows, buttons, checkboxes, radiobuttons, labels, editboxes, scrolls, textareas, scales, etc. Use of this extension if very similar to the original Newt API of C programming language. Related Links - Package home: http://pecl.php.net/package/newt Changelog: http://pecl.php.net/package-changelog.php?package=newt Download: http://pecl.php.net/get/newt-1.2.7.tgz Authors - Michael Spector mich...@php.net (lead) -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Segfault on bitset function / 64bits only
Hi. Testing Judy library (for Judy PHP extension), I encounter a reproducable segfault on x86_64 only (Judy 1.0.5 official release, no patch applied). See the reproducer attached (segfault with value ~300) $ gdb foo (gdb) run 500 ... OK - bit successfully set at 269 OK - bit successfully set at 270 Program received signal SIGSEGV, Segmentation fault. 0x77db4590 in j__udyInsWalk (Pjp=Pjp@entry=0x603198, Index=Index@entry=271, Pjpm=Pjpm@entry=0x603060) at Judy1Set.c:1506 1506JU_BITMAPSETL(Pjlb, Pjp-jp_1Index[offset]); (gdb) bt #0 0x77db4590 in j__udyInsWalk (Pjp=Pjp@entry=0x603198, Index=Index@entry=271, Pjpm=Pjpm@entry=0x603060) at Judy1Set.c:1506 #1 0x77db4fb6 in j__udyInsWalk (Pjp=0x603198, Pjp@entry=0x603108, Index=Index@entry=271, Pjpm=Pjpm@entry=0x603060) at Judy1Set.c:1650 #2 0x77db4fb6 in j__udyInsWalk (Pjp=0x603108, Pjp@entry=0x603068, Index=Index@entry=271, Pjpm=Pjpm@entry=0x603060) at Judy1Set.c:1650 #3 0x77db7388 in Judy1Set (PPArray=0x7fffdea8, Index=271, PJError=0x7fffde80) at Judy1Set.c:1847 #4 0x0040097e in main () Have you already encounter this issue ? Any idea ? Thanks, Remi. CC to Paul (Fedora package owner) and Nicolas (PECL extension owner). P.S. https://bugzilla.redhat.com/1017338 - fedora bug report #include stdio.h #include Judy.h int main(int argc, char *argv[]) // Example program of Judy1 macro APIs { Word_t Index; // index (or key) Word_t Rcount;// count of indexes (or bits set) Word_t Rc_word; // full word return value intRc_int, max; // boolean values returned (0 or 1) Pvoid_t J1Array = (Pvoid_t) NULL; // initialize Judy1 array max = (argc1 ? atoi(argv[1]) : 10); for (Index=1 ; Indexmax ; Index++) { J1S(Rc_int, J1Array, Index); if (Rc_int == JERR) printf(ERRMEM\n); if (Rc_int == 1) printf(OK - bit successfully set at %lu\n, Index); if (Rc_int == 0) printf(BUG - bit already set at %lu\n, Index); } J1C(Rcount, J1Array, 0, -1); // count all bits set in array printf(%lu bits set in Judy1 array\n, Rcount); J1MU(Rc_word, J1Array); // how much memory was used? printf(%lu Indexes used %lu bytes of memory\n, Rcount, Rc_word); Index = 0; J1F(Rc_int, J1Array, Index); // find first bit set in array if (Rc_int == 1) printf(OK - first bit set is at %lu\n, Index); if (Rc_int == 0) printf(BUG - no bits set in array\n); return(0); } -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk___ Judy-devel mailing list Judy-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/judy-devel
Re: Segfault on bitset function / 64bits only
Le 10/10/2013 13:56, Remi Collet a écrit : Testing Judy library (for Judy PHP extension), I encounter a reproducable segfault on x86_64 only (Judy 1.0.5 official release, no patch applied). I forget to give you some information. Build options: + CFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic' + LDFLAGS='-Wl,-z,relro ' So gcc options are: -DJU_64BIT -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic And, from build, perhaps a revelant warning Judy1Set.c: In function 'j__udyInsWalk': Judy1Set.c:1506:63: warning: iteration 8u invokes undefined behavior [-Waggressive-loop-optimizations] JU_BITMAPSETL(Pjlb, Pjp-jp_1Index[offset]); ^ Judy1Set.c:1505:13: note: containing loop for (offset = 0; offset 15; ++offset) ^ Full build log http://kojipkgs.fedoraproject.org//packages/Judy/1.0.5/7.fc20/data/logs/x86_64/build.log Remi. -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ Judy-devel mailing list Judy-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/judy-devel
Re: [PECL-DEV] Windows builds PECL site integration
Le 04/10/2013 20:59, Anatol Belski a écrit : Hi, as one could already have seen, the links to the extension DLLs has been integrated into the PECL website. Nice. But, it seems this violate most of extension License ;) From BSD or PHP License: 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. This means the .zip archive MUST include the LICENSE file. Problem: lot of extensions still not have this file. Ex: https://bugs.php.net/65842 The header of the source files is (perhaps) enough for sources redistribution, but obviously not for binary. Sorry to bother you (again) with awfull legal stuff, but I think this is important, especially for a PHP official site to respect the PHP License. Regards, Remi. -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PECL-DEV] Windows builds PECL site integration
Le 06/10/2013 10:51, Pierre Joye a écrit : Yes and no, this license term is outside php.net, I agree, distribution != redistribution. (notice: php.net distribute extension, but also redistribute various bundled libraries) But it seems strange that someone copying a zip for redistribution violate the License term. I just want to point out to upstream that by not including a proper full license text, they are making it difficult or impossible for anyone to comply with their desired license terms. So, we should really provides clean archive. but yes we should bundle the licenses (extension license(s) and the libraries license used by a given extension). The first action is for extension owners to add those files in their repository (and package.xml). This is something I don't think we can do for them. I'm hoping, reading this discussion, they will be aware of this issue, and will fix their reporotory, when needed, without having to ask each of them explicitly... Code is in git, contributions welcome :) I will continue to ask extension owner to fix their sources., filling bug... and hope I don't bother them to much and I help to achieve this goal. I don't think I could help more with the windows build tools ;) Cheers Remi. P.S. Common licenses that require including their texts with all derivative works include ASL 2.0, EPL, BSD, PHP and MIT. Cheers, -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PECL-DEV] Re: Windows builds PECL site integration
Le 06/10/2013 20:30, Jan Ehrhardt a écrit : In my own builds I do not use nmake test either. But what I do for most extensions is to run a php.exe phpinfo.php and a php-cgi.exe phpinfo.php with the extension_dir set to 'ext' and the extension loaded. Doing it that way occasionally revealed a bug, but also showed that php_wincache.dll will not load in a TS PHP. I also run a minimal load test for all extension / RPM I build. $ php --no-php-ini \ --define extension=modules/extname.so \ --modules | grep extname This allow to detect some bugs which are not detect at buildtime [1] Very recent ex: https://bugs.php.net/65847 Remi. [1] this only raises a implicit function declaration warning, and we don't use -Werror for now ;) -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] com php-src: Fix Bug #60633 build warning in bcmath: ext/bcmath/libbcmath/src/recmul.c
Commit:60d9175280cbab5967966e38f42fced854d10408 Author:Remi Collet r...@php.net Thu, 3 Oct 2013 08:45:31 +0200 Parents: 2ba39268151549f03140ec3d260cf9489336ec93 Branches: PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=60d9175280cbab5967966e38f42fced854d10408 Log: Fix Bug #60633 build warning in bcmath Bugs: https://bugs.php.net/60633 Changed paths: M ext/bcmath/libbcmath/src/recmul.c Diff: diff --git a/ext/bcmath/libbcmath/src/recmul.c b/ext/bcmath/libbcmath/src/recmul.c index c31d09d..64014f3 100644 --- a/ext/bcmath/libbcmath/src/recmul.c +++ b/ext/bcmath/libbcmath/src/recmul.c @@ -183,7 +183,6 @@ _bc_rec_mul (bc_num u, int ulen, bc_num v, int vlen, bc_num *prod, int full_scale TSRMLS_DC) { bc_num u0, u1, v0, v1; - int u0len, v0len; bc_num m1, m2, m3, d1, d2; int n, prodlen, m1zero; int d1len, d2len; @@ -216,10 +215,8 @@ _bc_rec_mul (bc_num u, int ulen, bc_num v, int vlen, bc_num *prod, } _bc_rm_leading_zeros (u1); _bc_rm_leading_zeros (u0); - u0len = u0-n_len; _bc_rm_leading_zeros (v1); _bc_rm_leading_zeros (v0); - v0len = v0-n_len; m1zero = bc_is_zero(u1 TSRMLS_CC) || bc_is_zero(v1 TSRMLS_CC); -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Streams constify API change in master leads to compilation warning for extensions
Le 02/10/2013 20:41, Jakub Zelenka a écrit : Hi, I was wondering why stream API has been changed in this commit: https://github.com/php/php-src/commit/92d27ccb0574f901a107409a7fec92888fa2b82f Basically all char pointers have been constified. The thing is that this commit leads to compilation warning for many extensions. In my case I use php_stream_locate_url_wrapper and want to compile my extension (fann) without any warnings. Sorry to have not read enough carefully your mail. -PHPAPI php_stream_wrapper *php_stream_locate_url_wrapper (const char *path, char **path_for_open, int options TSRMLS_DC); +PHPAPI php_stream_wrapper *php_stream_locate_url_wrapper (const char *path, const char **path_for_open, int options TSRMLS_DC); While is absolutly safe (and often useful) to switch from (char *) to (const char *), it is not with (char **) No compatibility in ever way. ... expected ‘const char **’ but argument is of type ‘char **’ ... ... expected ‘char **’ but argument is of type ‘const char **’ ... So I agree, this one could probably be reverted. As I found awful having to see more code like this (ex from twig) #if PHP_API_VERSION = 20100412 zend_get_object_classname(object, (const char **) class_name, class_name_len TSRMLS_CC); #else zend_get_object_classname(object, class_name, class_name_len TSRMLS_CC); #endif return class_name; } Remi. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Streams constify API change in master leads to compilation warning for extensions
Le 02/10/2013 20:41, Jakub Zelenka a écrit : Hi, I was wondering why stream API has been changed in this commit: https://github.com/php/php-src/commit/92d27ccb0574f901a107409a7fec92888fa2b82f Basically all char pointers have been constified. The thing is that this commit leads to compilation warning for many extensions. In my case I use php_stream_locate_url_wrapper and want to compile my extension (fann) without any warnings. Because this change is in master and not in 5.5-, I will have to add some ifdefs and cast it for 5.6+. The thing is that php_stream_locate_url_wrapper and other stream fuctions are often used for function parameters from zend_parse_parameters which are just char *. Then the values have to be casted. I understand that APIs should be improved and sometimes changes are necessary but in this case I have to ask a question. Was this change worthy to compilation warnings for many extensions? I don't see any problem with this change. When a (char *) is expected (which means, give me a pointer to something I can change), you can only give a (char *). So a (const char *) raises a warning. When a (const char *) is expected (which means, give me a pointer to something I won't change), you can give a (char *) or a (const char *), both are accepted without any warning. In fann you had a (char *), I propose you to remove the cast to (const char *) which raise a warning with 5.5 and is not useful in master. In the opposite way a cast from const to not-const have of course no sense. So, yes we need to add more const in php API, as this is the correct way to properly fix various build warnings. About the linked commit, I think it would be useful in 5.5 (as this don't break ABI). Note, a string (such as some name) is consider by gcc as a (char *) but as a (const char *) by g++ (except if -fno-const-strings is used). Ex : http://git.php.net/?p=php-src.git;a=commitdiff;h=f7eff9cd41e0b996af9a0a01d3c5f8fdd8b7fa60 This constify option of exception functions fixes warning (at least) in xmldiff extension (written in C++) which use const strings. Remi. PS. is a warning free build a dream ? I don't think. If not would it be possible to revert it? Thanks Jakub -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[Glpi-dev] Plugins tarball and tools
Comme pour GLPI, de nombreux plugins ont un dossier tools qui contient des outils pour le développeur qu'il n'est pas nécessaire de distribuer. Donc soyez sympa de le supprimer avant de créer l'archive :) Ce dossier étant (souvent) accessible par l'interface, en fonction de son contenu, cela peut créer des problèmes de sécurité. --- As for GLPI, a lot of plugins now have a tool directory which contains tools for developers. which have not to be distributed. So, be nice, and delete it before creating the archive :) As this directory is usally not available through the web, some content could create security issues. Remi. /me trying to update GLPI RPM with clean stuff... ___ Glpi-dev mailing list Glpi-dev@gna.org https://mail.gna.org/listinfo/glpi-dev
Re: thunderbird-24.0.2 reverted - why? (Use the commit log..., Luke)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 24/09/2013 12:29, Heiko Adams a écrit : The bodhi comments say that thunderbird-lightning dep was broken. But it just needs to be updated to version 2.6 and everything should work fine again. /me really likes the just needs ! As simple as pressing the green button. Remi. -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlJBcu8ACgkQYUppBSnxahhDBwCg1fBgCtoeqqPSNz0poOuTmXYL 3eUAnizVPY/WlDQPxLYCVCr65fuBbbXR =pTzg -END PGP SIGNATURE- -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: thunderbird-24.0.2 reverted - why? (Use the commit log..., Luke)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 24/09/2013 12:35, Reindl Harald a écrit : and that is why ist *is wrong* to give negative karma because some extension is not updated - who says that the extension RPM is relevant for all users? I don't agree. Broken dep are not acceptable in stable release. Remi. -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlJBloAACgkQYUppBSnxahibGACgjOOGCxLIxZn3KL5tBJjD3enc /3QAni3QwCMVQgXoN1kcDuxgxZJy/qAU =DXCc -END PGP SIGNATURE- -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: thunderbird-24.0.2 reverted - why? (Use the commit log..., Luke)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 24/09/2013 15:50, Reindl Harald a écrit : Am 24.09.2013 15:41, schrieb Remi Collet: Le 24/09/2013 12:35, Reindl Harald a écrit : and that is why ist *is wrong* to give negative karma because some extension is not updated - who says that the extension RPM is relevant for all users? I don't agree. Broken dep are not acceptable in stable release if one person maintains thunderbird and the other one lightning how do you imagine that both packages are built at the same moment and get the same karma? this is a organisation problem and again: I agree on the organisation problem, but only on that. a broken depdendency for lightning is *never* a reason to give thunderbird bad karma - you do not need the lightning RPM at all, install the extension as most others are not in the repos from mozilla.org Yes. You can also use Thunderbird from mozilla.org, libreoffice from ... And switch from Fedora to LFS. First a reminder: we have an update policy which explicitly explain why we should not update, to not break things like that in a stable release. http://fedoraproject.org/wiki/Updates_Policy So (as far as security bug are fixed) it is absolutely fine to keep Thunderbird 17.0.x in Fedora 18/19. Ok. Mozilla stuff have an exception and update to each major version (which make sense for Firefox, but probably not for Thunderbird, as we only provide the ESR version) and even if both packages are built at the same time there are more using TB and giving positive karma because they simply do not have a dep-problem and so you can't make the push synchron in most cases In such case this is the responsibility of the xulrunner or thunderbird owner to rebuild all the packages which need to be and to publish all the packages in a single update. that's why --skip-broken exists Definitively not acceptable. Remi. -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlJBn1cACgkQYUppBSnxahi+RACgnka4Ag24WVqYrF2250pvyjgA 3OkAoN1fmTMXbWofA4qW7rcg0VUV4JyC =PTpm -END PGP SIGNATURE- -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: thunderbird-24.0.2 reverted - why? (Use the commit log..., Luke)
Le 24/09/2013 16:00, Jan Horak a écrit : ... I'm a bit unsure if keeping max version (ie. Requires: thunderbird %{thunderbird_next_version}) for dependent packages is fruitful here ... FYI: Already droped from Enigmail spec file. But this is a bit specific, as Enigmail doesn't use anymore anything from Thunderbird API and is now mostly a pure xul app (except a small .so to wrapp some system call). From install.rdf: em:minVersion17.0/em:minVersion em:maxVersion99.0/em:maxVersion Remi. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
[PHP-CVS] com php-src: Make message and format arguments const char * to avoid build warning about invalid cast.: Zend/zend_exceptions.c Zend/zend_exceptions.h
Commit:f7eff9cd41e0b996af9a0a01d3c5f8fdd8b7fa60 Author:Remi Collet r...@php.net Mon, 23 Sep 2013 13:21:57 +0200 Parents: a92a350ccef7b295a5d7d8404771ae9bb8f602d3 Branches: PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=f7eff9cd41e0b996af9a0a01d3c5f8fdd8b7fa60 Log: Make message and format arguments const char * to avoid build warning about invalid cast. Changed paths: M Zend/zend_exceptions.c M Zend/zend_exceptions.h Diff: diff --git a/Zend/zend_exceptions.c b/Zend/zend_exceptions.c index 14ae75e..c7f157c 100644 --- a/Zend/zend_exceptions.c +++ b/Zend/zend_exceptions.c @@ -560,7 +560,7 @@ ZEND_METHOD(exception, getPrevious) RETURN_ZVAL(previous, 1, 0); } -int zend_spprintf(char **message, int max_len, char *format, ...) /* {{{ */ +int zend_spprintf(char **message, int max_len, const char *format, ...) /* {{{ */ { va_list arg; int len; @@ -732,7 +732,7 @@ ZEND_API zend_class_entry *zend_get_error_exception(TSRMLS_D) /* {{{ */ } /* }}} */ -ZEND_API zval * zend_throw_exception(zend_class_entry *exception_ce, char *message, long code TSRMLS_DC) /* {{{ */ +ZEND_API zval * zend_throw_exception(zend_class_entry *exception_ce, const char *message, long code TSRMLS_DC) /* {{{ */ { zval *ex; @@ -760,7 +760,7 @@ ZEND_API zval * zend_throw_exception(zend_class_entry *exception_ce, char *messa } /* }}} */ -ZEND_API zval * zend_throw_exception_ex(zend_class_entry *exception_ce, long code TSRMLS_DC, char *format, ...) /* {{{ */ +ZEND_API zval * zend_throw_exception_ex(zend_class_entry *exception_ce, long code TSRMLS_DC, const char *format, ...) /* {{{ */ { va_list arg; char *message; @@ -775,7 +775,7 @@ ZEND_API zval * zend_throw_exception_ex(zend_class_entry *exception_ce, long cod } /* }}} */ -ZEND_API zval * zend_throw_error_exception(zend_class_entry *exception_ce, char *message, long code, int severity TSRMLS_DC) /* {{{ */ +ZEND_API zval * zend_throw_error_exception(zend_class_entry *exception_ce, const char *message, long code, int severity TSRMLS_DC) /* {{{ */ { zval *ex = zend_throw_exception(exception_ce, message, code TSRMLS_CC); zend_update_property_long(default_exception_ce, ex, severity, sizeof(severity)-1, severity TSRMLS_CC); diff --git a/Zend/zend_exceptions.h b/Zend/zend_exceptions.h index 8263353..81c8a1f 100644 --- a/Zend/zend_exceptions.h +++ b/Zend/zend_exceptions.h @@ -40,12 +40,12 @@ ZEND_API void zend_register_default_classes(TSRMLS_D); /* exception_ce NULL or zend_exception_get_default() or a derived class * messageNULL or the message of the exception */ -ZEND_API zval * zend_throw_exception(zend_class_entry *exception_ce, char *message, long code TSRMLS_DC); -ZEND_API zval * zend_throw_exception_ex(zend_class_entry *exception_ce, long code TSRMLS_DC, char *format, ...); +ZEND_API zval * zend_throw_exception(zend_class_entry *exception_ce, const char *message, long code TSRMLS_DC); +ZEND_API zval * zend_throw_exception_ex(zend_class_entry *exception_ce, long code TSRMLS_DC, const char *format, ...); ZEND_API void zend_throw_exception_object(zval *exception TSRMLS_DC); ZEND_API void zend_clear_exception(TSRMLS_D); -ZEND_API zval * zend_throw_error_exception(zend_class_entry *exception_ce, char *message, long code, int severity TSRMLS_DC); +ZEND_API zval * zend_throw_error_exception(zend_class_entry *exception_ce, const char *message, long code, int severity TSRMLS_DC); extern ZEND_API void (*zend_throw_exception_hook)(zval *ex TSRMLS_DC); @@ -53,7 +53,7 @@ extern ZEND_API void (*zend_throw_exception_hook)(zval *ex TSRMLS_DC); ZEND_API void zend_exception_error(zval *exception, int severity TSRMLS_DC); /* do not export, in php it's available thru spprintf directly */ -int zend_spprintf(char **message, int max_len, char *format, ...); +int zend_spprintf(char **message, int max_len, const char *format, ...); END_EXTERN_C() -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: AppData validation tool
Le 18/09/2013 17:23, Richard Hughes a écrit : I'd appreciate it if a few people could try it out According to the commit you point me previously, it seems summary could be translated https://github.com/hughsie/fedora-appstream/commit/6683d10503a592ac02ec9cf9671c817b2077e82e = xml.write(summary xml:lang=\%s\%s/summary\n % (sanitise_xml(lang), sanitise_xml(comments[lang]))) But trying $ appdata-validate misc/qelectrotech.appdata.xml misc/qelectrotech.appdata.xml 1 problems detected: • tag duplicated: summary is duplicated Remi. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: AppData validation tool
Le 18/09/2013 18:03, Richard Hughes a écrit : Good catch, fixed upstream, thanks: Welcome ! I forget to say that I think this is a very useful tool ! Thanks to provide this. Remi. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: [PHP-DEV] PHP CLI setting cooked terminal mode
Le 18/09/2013 16:04, Alain Williams a écrit : What is needed is for this to NOT be called if the standard output is not connected to a tty. From your previous message: ioctl(0, SNDCTL_TMR_TIMEBASE or TCGETS, {B38400 opost isig icanon echo ...}) = 0 ioctl(0, SNDCTL_TMR_STOP or TCSETSW, {B38400 opost isig icanon echo ...}) = 0 Which is standard input, not standard output I can get it to not do this by connecting stdin to /dev/null: ./myScript /dev/null | less qed Should I raise this as a bug ? So, I don't think there is any bug there. Remi. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] PHP CLI setting cooked terminal mode
Le 17/09/2013 02:27, Alain Williams a écrit : I have done a bit of digging and suspect that this happens as part of readline initialisation. +1 phpinfo() reports: --without-readline but then: Please... don't rely, for distro packaged PHP on configure option listed in phpinfo report [1]. Additional Modules Module Name readline readline extension doesn't use readline library (under incompatible license: GPLv3) but libedit (License: BSD). Remi. [1] http://blog.famillecollet.com/post/2010/09/29/phpinfo-BUG-or-PEBKAC -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: Proposal: AppData files in all application packages?
Which package own /usr/share/appdata ? At the moment it's gnome-software, which isn't exactly ideal. I'm erring towards adding it to filesystem, but other ideas welcome. Yes filesystem seems definively the good choice (as other dir as /usr/share/applications, icons, ...). Remi. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: Proposal: AppData files in all application packages?
Le 09/09/2013 22:08, Elad Alfassa a écrit : If you have any specific questions (after reading both commit messages), we'll be happy to answer them. Yes, I have found how to add this file, thanks. I you really want this to succeeds and to be adopted by application upstream, we need to provides really simple documentation. (I'm tired to heard about some new fedora specific and complex request... even if this is not true, this is a common upstream feeling) And sorry, but this is not yet the case. (especially for ex. for a QT app which doesn't use gettext or autotool) Just to confirm: this new file is only useful on fedora = 20 ? (so we need to not ship it in fedora 20, perhaps some Guildelines about this could be useful) Which package own /usr/share/appdata ? Remi. P.S. new version 0.3RC of qelectrotech in rawhide have this file, added by upstream on my proposal. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: Proposal: AppData files in all application packages?
Le 09/09/2013 17:51, Florian Müllner a écrit : On Mon, Sep 9, 2013 at 5:36 PM, Remi Collet fed...@famillecollet.com wrote: Le 06/09/2013 11:33, Richard Hughes a écrit : [1] http://people.freedesktop.org/~hughsient/appdata/ I don't see any localization information in those specifications... From the above link: Questions: [...] How do I translate this data? Sorry, but this need more explanation / sample / howto. As I understand, localization is not planned for 3.10. Sorry, but without translation, I just think this is a NO-GO for me. Remi. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: Proposal: AppData files in all application packages?
Le 06/09/2013 11:33, Richard Hughes a écrit : [1] http://people.freedesktop.org/~hughsient/appdata/ [2] https://github.com/hughsie/fedora-appstream/tree/master/appdata-extra I don't see any localization information in those specifications... Isn't this supposed to be a user-friendly feature ? Remi. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
[PHP-CVS] com php-src: Fixed Bug #65564 stack-buffer-overflow in DateTimeZone stuff caught by AddressSanitizer: NEWS ext/date/php_date.c
Commit:d69513afecf3d82c6bfba35ef1634b3b7c377d87 Author:Remi Collet r...@php.net Fri, 30 Aug 2013 10:42:08 +0200 Parents: 7da6498342d76c34892bfa247bc1779d8f5ee1e6 Branches: PHP-5.4 PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=d69513afecf3d82c6bfba35ef1634b3b7c377d87 Log: Fixed Bug #65564 stack-buffer-overflow in DateTimeZone stuff caught by AddressSanitizer Bugs: https://bugs.php.net/65564 Changed paths: M NEWS M ext/date/php_date.c Diff: diff --git a/NEWS b/NEWS index 42b69f5..76eb1fa 100644 --- a/NEWS +++ b/NEWS @@ -36,6 +36,8 @@ PHP NEWS - Datetime: . Fixed bug #65554 (createFromFormat broken when weekday name is followed by some delimiters). (Valentin Logvinskiy, Stas). + . Fixed bug #65564 (stack-buffer-overflow in DateTimeZone stuff caught +by AddressSanitizer). (Remi). - Openssl: . Fixed bug #64802 (openssl_x509_parse fails to parse subject properly in diff --git a/ext/date/php_date.c b/ext/date/php_date.c index 1c97781..70960b1 100644 --- a/ext/date/php_date.c +++ b/ext/date/php_date.c @@ -2113,13 +2113,13 @@ static HashTable *date_object_get_properties(zval *object TSRMLS_DC) /* first we add the date and time in ISO format */ MAKE_STD_ZVAL(zv); ZVAL_STRING(zv, date_format(Y-m-d H:i:s, 12, dateobj-time, 1), 0); - zend_hash_update(props, date, 5, zv, sizeof(zval), NULL); + zend_hash_update(props, date, 5, zv, sizeof(zv), NULL); /* then we add the timezone name (or similar) */ if (dateobj-time-is_localtime) { MAKE_STD_ZVAL(zv); ZVAL_LONG(zv, dateobj-time-zone_type); - zend_hash_update(props, timezone_type, 14, zv, sizeof(zval), NULL); + zend_hash_update(props, timezone_type, 14, zv, sizeof(zv), NULL); MAKE_STD_ZVAL(zv); switch (dateobj-time-zone_type) { @@ -2142,7 +2142,7 @@ static HashTable *date_object_get_properties(zval *object TSRMLS_DC) ZVAL_STRING(zv, dateobj-time-tz_abbr, 1); break; } - zend_hash_update(props, timezone, 9, zv, sizeof(zval), NULL); + zend_hash_update(props, timezone, 9, zv, sizeof(zv), NULL); } return props; @@ -2265,7 +2265,7 @@ static HashTable *date_object_get_properties_interval(zval *object TSRMLS_DC) #define PHP_DATE_INTERVAL_ADD_PROPERTY(n,f) \ MAKE_STD_ZVAL(zv); \ ZVAL_LONG(zv, (long)intervalobj-diff-f); \ - zend_hash_update(props, n, strlen(n) + 1, zv, sizeof(zval), NULL); + zend_hash_update(props, n, strlen(n) + 1, zv, sizeof(zv), NULL); PHP_DATE_INTERVAL_ADD_PROPERTY(y, y); PHP_DATE_INTERVAL_ADD_PROPERTY(m, m); @@ -2282,7 +2282,7 @@ static HashTable *date_object_get_properties_interval(zval *object TSRMLS_DC) } else { MAKE_STD_ZVAL(zv); ZVAL_FALSE(zv); - zend_hash_update(props, days, 5, zv, sizeof(zval), NULL); + zend_hash_update(props, days, 5, zv, sizeof(zv), NULL); } PHP_DATE_INTERVAL_ADD_PROPERTY(special_type, special.type); PHP_DATE_INTERVAL_ADD_PROPERTY(special_amount, special.amount); -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] com php-src: Merge branch 'PHP-5.4' into PHP-5.5: ext/date/php_date.c
Commit:a5749eb0cbe6edb91ba0d5d79bbeedaeabf3788a Author:Remi Collet r...@php.net Fri, 30 Aug 2013 10:43:12 +0200 Parents: 4e3de606b54425029cc4617215a3360bb8550b2f d69513afecf3d82c6bfba35ef1634b3b7c377d87 Branches: PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=a5749eb0cbe6edb91ba0d5d79bbeedaeabf3788a Log: Merge branch 'PHP-5.4' into PHP-5.5 * PHP-5.4: Fixed Bug #65564 stack-buffer-overflow in DateTimeZone stuff caught by AddressSanitizer Bugs: https://bugs.php.net/65564 Changed paths: MM ext/date/php_date.c Diff: -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] com php-src: Fixed bug #65564 stack-buffer-overflow in DateTimeZone stuff caught by AddressSanitizer: NEWS ext/date/php_date.c
Commit:6fab1caa4100cf05fcf485ef0917830ae9f57563 Author:Remi Collet r...@php.net Fri, 30 Aug 2013 10:45:33 +0200 Parents: a5749eb0cbe6edb91ba0d5d79bbeedaeabf3788a Branches: PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=6fab1caa4100cf05fcf485ef0917830ae9f57563 Log: Fixed bug #65564 stack-buffer-overflow in DateTimeZone stuff caught by AddressSanitizer Bugs: https://bugs.php.net/65564 Changed paths: M NEWS M ext/date/php_date.c Diff: diff --git a/NEWS b/NEWS index d637d0a..ab1b5ca 100644 --- a/NEWS +++ b/NEWS @@ -25,6 +25,8 @@ PHP NEWS - Datetime: . Fixed bug #65554 (createFromFormat broken when weekday name is followed by some delimiters). (Valentin Logvinskiy, Stas). + . Fixed bug #65564 (stack-buffer-overflow in DateTimeZone stuff caught +by AddressSanitizer). (Remi). - OPCache: . Fixed bug #65561 (Zend Opcache on Solaris 11 x86 needs ZEND_MM_ALIGNMENT=4). diff --git a/ext/date/php_date.c b/ext/date/php_date.c index 997038a..95c68f1 100644 --- a/ext/date/php_date.c +++ b/ext/date/php_date.c @@ -2305,7 +2305,7 @@ static HashTable *date_object_get_properties_timezone(zval *object TSRMLS_DC) MAKE_STD_ZVAL(zv); ZVAL_LONG(zv, tzobj-type); - zend_hash_update(props, timezone_type, 14, zv, sizeof(zval), NULL); + zend_hash_update(props, timezone_type, 14, zv, sizeof(zv), NULL); MAKE_STD_ZVAL(zv); switch (tzobj-type) { @@ -2327,7 +2327,7 @@ static HashTable *date_object_get_properties_timezone(zval *object TSRMLS_DC) ZVAL_STRING(zv, tzobj-tzi.z.abbr, 1); break; } - zend_hash_update(props, timezone, 9, zv, sizeof(zval), NULL); + zend_hash_update(props, timezone, 9, zv, sizeof(zv), NULL); return props; } -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Re: [PHP-CVS] com php-src: Fixed bug #65564 stack-buffer-overflow in DateTimeZone stuff caught by AddressSanitizer: NEWS ext/date/php_date.c
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=6fab1caa4100cf05fcf485ef0917830ae9f57563 What do you think to add the -fsanitize=address option (if available) for the debug build ? Note, this will make build / test slower. Remi. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [RFC] Switch from json extension to jsonc [Discussion]
Le 30/08/2013 10:56, Jordi Boggiano a écrit : I think it'd be best to resolve this in PHP because otherwise it means Debian ( Fedora?) users will have the bad surprise of a quirky Debian, Fedora, Mageia, Mandriva, Ubuntu, etc. implementation when deploying to prod, and I can imagine the impossible-to-reproduce issues that will follow. This is clearly a important part of the proposal. Having the same json implementation in all PHP. Remi. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Attitude against distributions... (Was: JSON non-free license)
Le 29/08/2013 07:54, Pierre Joye a écrit : hi Remi! On Thu, Aug 29, 2013 at 7:33 AM, Remi Collet r...@fedoraproject.org wrote: But we are PHP project members. And we ship an OpenSource software which is Licensed under the PHP License, a really free License (per FSF definition). Ah? I always read that the PHP License is not actually Free as per FSF definition, and not compatible with their true free license (GPL). Did that change recently? :) This is not a problem of GPL definition. From FSF web site: The following licenses [...which included the PHP one ...] are free software licenses, but are not compatible with the GNU GPL. And of course, only the first part is important here. So most linux distribution recognize PHP License as a free License. Remi. Cheers, -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [RFC] Switch from json extension to jsonc [Discussion]
Le 29/08/2013 08:25, Stas Malyshev a écrit : Hi! Subject: Switch from json extension which have a problematic (non-free) license to jsonc dropin free alternative. RFC: https://wiki.php.net/rfc/free-json-parser From what I see in the benchmarks, while encoding is on par with current implementation, decoding is more than 2x slower. This may be a problem, especially for something like REST API that may have to decode decent amount of JSON data. Can it be fixed? From my analysis (profiling), most of the time is spent in memory allocation calls. As we used a parser from a library, we do 1- parse in library space 2- object tree allocation of the result 3- copy result from library space to php space 4- PHP object tree allocation I don't see any good solution to optimize this except copying the code from the library into PHP, and thus remove stop 2+3. Also, I see the sizes of the encode results is different from ext/json. Why is that? Also, Partial implementation of big integers parsing is a bit worrying. If we want to have drop-in replacement, partial implementations would lead to trouble. Can it be fixed? As the parsing is done in the library, we receive a int64. So to late. As previously copying the code will allow such change. Of course I have tried to avoid this (copying the code) and prefer to keep the library unchanged... but... Remi. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [RFC] Switch from json extension to jsonc [Discussion]
Le 29/08/2013 08:25, Stas Malyshev a écrit : Also, I see the sizes of the encode results is different from ext/json. Why is that? Stupid bench... data include some values from microtime()... Fixed. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [RFC] Switch from json extension to jsonc [Discussion]
Le 29/08/2013 09:04, Stas Malyshev a écrit : Hi! From my analysis (profiling), most of the time is spent in memory allocation calls. As we used a parser from a library, we do 1- parse in library space 2- object tree allocation of the result 3- copy result from library space to php space 4- PHP object tree allocation Can't we just patch the lib to do the right thing? Is it just malloc vs. emalloc or deeper problems? Probably deeper problem. Moving to statically allocated stack (just a stupid test, of course) of json_object only reduce time by ~15%... I don't see any good solution to optimize this except copying the code from the library into PHP, and thus remove stop 2+3. Of course I have tried to avoid this (copying the code) and prefer to keep the library unchanged... but... Well, 2x slowdown is pretty serious. I didn't have a good look at the code so I can't advise how to fix it, but I think it needs to be fixed one way or another. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: Running a command in spec file?
Le 28/08/2013 18:09, Dave Johansen a écrit : I'm trying to make a spec file that uses the devtoolset in RHEL 5/6 ( rhn.redhat.com/errata/RHEA-2013-0175.html ) but I haven't been able to figure out how to enable devtoolset in the spec file. If I run 'scl enable devtoolset-1.1 bash' before doing rpmbuild it works, but how do I run a command like that in the spec file? In %build: . /opt/rh/devtoolset-or-sclname/enable Remi. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: [PHP-DEV] Attitude against distributions... (Was: JSON non-free license)
Le 28/08/2013 23:40, Stas Malyshev a écrit : Hi! And while the issue was first reported by Debian, the other distributions share the same concerns. This is why PHP should consider this - because the other parts of the eco-system are already going forward with this. Yes. This is not a Debian only problem. Most of linux distribution are affected (Fedora, Mandriva, Mageia, OpenSuse, Ubuntu...) AFAIK no one have altered PHP. We only build with --disable-json which is available in the standard build process, and build/ship jsonc separately. There is also a consensus to move on this only for new PHP 5.5 and keep json in PHP 5.3 / 5.4 as this problem was not discovered before. What we need to consider this extension as a replacement for core JSON is: - explanation of advantages and disadvantages (noting that for most PHP users weird license is not a significant disadvantage of the extension) of the change Yes, most PHP users don't care of License. especially those who want to do evil ;) But we are PHP project members. And we ship an OpenSource software which is Licensed under the PHP License, a really free License (per FSF definition). So, of course, we expect users to respect this License. And probably, we'd like them to respect OpenSource, so we need to have an exemplary conduct about those License issues. - RFC - API description - potential BC problems - performance impact Already drafted : https://wiki.php.net/rfc/free-json-parser I was thinking to submit this for discussion later (mostly because I will be AFK first week of september), but as the discussion raised now... Remi. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Attitude against distributions... (Was: JSON non-free license)
Le 29/08/2013 00:36, Jan Ehrhardt a écrit : Stas Malyshev in php.internals (Wed, 28 Aug 2013 14:40:06 -0700): What we need to consider this extension as a replacement for core JSON is: - explanation of advantages and disadvantages (noting that for most PHP users weird license is not a significant disadvantage of the extension) of the change - RFC - API description - potential BC problems - performance impact Some PECL extensions rely on (static?) json: couchdb, couchbase and solr. The maintainers of these extensions will have some work to do, unless the replacement is completely BC. Fedora used to build json extension as shared (like most extension). We never encounter any issue with other extension (except load order, but this is a well known and managed thing) jsonc is really a dropin replacement. - for other extension, same API/ABI - for userland Remi. Jan -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] [RFC] Switch from json extension to jsonc [Discussion]
Subject: Switch from json extension which have a problematic (non-free) license to jsonc dropin free alternative. RFC: https://wiki.php.net/rfc/free-json-parser Remi. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [Dotclear Dev] [dev]JSON dans CB
Le 21/08/2013 16:37, Pascal Chevrel a écrit : http://philsturgeon.co.uk/blog/2013/08/fud-cracker-php-55-never-lost-json-support C'est bon, on peut arrêter le drame. Merci pour cette rectification. Clairement l'extension json est (restera) disponible quelque soit le mode d'installation de PHP. Depuis les sources : ext/json 1.2.1 Depuis les .deb : php5-json installé par défaut (Recommends) Depuis les .rpm : php-pecl-jsonc installé par défaut. Il me reste juste à écrire la RFC pour intégrer l'extension jsonc 1.3.1 dans la prochaine version de PHP (5.6 ?) Remi. -- Dev mailing list - Dev@list.dotclear.org - http://ml.dotclear.org/listinfo/dev
Re: Changes to make MySQL vs. MariaDB less confusing
Le 22/08/2013 02:01, Chris Adams a écrit : it still works Really ? See https://bugzilla.redhat.com/buglist.cgi?bug_status=NEWbug_status=ASSIGNEDbug_status=ON_QAcomponent=mysql-workbenchlist_id=1639090 Remi. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
headup : libzip 0.11 in rawhide (and PHP change)
Hi. I have updated libzip to 0.11.1 in rawhide. Despite there is no soname change, see: http://upstream-tracker.org/versions/libzip.html So I think it is preferable to rebuild dependent packages to ensure all is ok. As PHP only work with libzip 0.10 (use lot of private stuff), the zip extension is become unmaintainable, so have been dropped from php. So we are going to receive tons of broken deps for pakages requiring php-zip. I just submit php-pecl-zip to review [1] This extension (from the same sources, but updated for libzip 0.11) is of course absolutely compatible. It will be really simpler to sync the life cyle of this extension with the library. Remi [1] https://bugzilla.redhat.com/show_bug.cgi?id=999313 -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: headup : libzip 0.11 in rawhide + F20 (and PHP change)
Le 21/08/2013 09:38, Remi Collet a écrit : Hi. I have updated libzip to 0.11.1 in rawhide. And in F20 branched too. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: headup : libzip 0.11 in rawhide (and PHP change)
Le 21/08/2013 09:38, Remi Collet a écrit : Hi. I have updated libzip to 0.11.1 in rawhide. Despite there is no soname change, see: http://upstream-tracker.org/versions/libzip.html So I think it is preferable to rebuild dependent packages to ensure all is ok. Build done, f20 and rawhide: libzip-0.11.1-1 php-5.5.3-1 (drop zip extension, so no more libzip dep) amftools-0.0-4.20121220svn32 ebook-tools-0.2.1-5 focuswriter-1.3.5.1-6 fuse-zip-0.2.12-9 libsigrok-0.2.1-2 nodejs-zipfile-0.4.0-2 openlierox-0.59-0.17.beta10 repsnapper-0:2.2.0-0.5.a4 Still TODO (but seems already FTBFS) subsurface-0:3.1 Remi. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
Re: headup : libzip 0.11 in rawhide (and PHP change)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 21/08/2013 14:44, Reindl Harald a écrit : drop zip extension? why? - From my initial message: As PHP only work with libzip 0.10 (use lot of private stuff), the zip extension is become unmaintainable, so have been dropped from php. So we are going to receive tons of broken deps for pakages requiring php-zip. I just submit php-pecl-zip to review [1] This extension (from the same sources, but updated for libzip 0.11) is of course absolutely compatible. It will be really simpler to sync the life cyle of this extension with the library. Remi [1] https://bugzilla.redhat.com/show_bug.cgi?id=999313 -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlIU4zsACgkQYUppBSnxahiNpwCeJ/jcbBlEMXBbz8BnGPtApBlp 21gAnjByhcwkRFl9TEVwVK0Zexv5ItfZ =LG4K -END PGP SIGNATURE- -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
[PHP-DEV] Re: [PHP-CVS] com php-src: Strict session: ext/session/mod_files.c ext/session/mod_files.h ext/session/mod_mm.c ext/session/php_session.h ext/session/session.c ext/session/tests/003.phpt ext
Le 05/08/2013 01:36, Stanislav Malyshev a écrit : + STD_PHP_INI_BOOLEAN(session.use_strict_mode, 0, PHP_INI_ALL, OnUpdateBool, use_strict_mode,php_ps_globals, ps_globals) I don't see this new option referenced in the provided php.ini-{production,development} Remi. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[perl-Net-SSLGlue/f19] update to 1.04
commit 0f4e0a8be49a9e3341301800370c86c47cde2370 Author: Remi Collet r...@fedoraproject.org Date: Tue Aug 6 13:32:55 2013 +0200 update to 1.04 .gitignore|1 + perl-Net-SSLGlue.spec |5 - sources |2 +- 3 files changed, 6 insertions(+), 2 deletions(-) --- diff --git a/.gitignore b/.gitignore index 1740c7f..5ba8336 100644 --- a/.gitignore +++ b/.gitignore @@ -4,3 +4,4 @@ /Net-SSLGlue-0.8.tar.gz /Net-SSLGlue-1.01.tar.gz /Net-SSLGlue-1.03.tar.gz +/Net-SSLGlue-1.04.tar.gz diff --git a/perl-Net-SSLGlue.spec b/perl-Net-SSLGlue.spec index aaee7e0..af92657 100644 --- a/perl-Net-SSLGlue.spec +++ b/perl-Net-SSLGlue.spec @@ -1,5 +1,5 @@ Name: perl-Net-SSLGlue -Version:1.03 +Version:1.04 Release:1%{?dist} Summary:Add/extend SSL support for common perl modules License:GPL+ or Artistic @@ -76,6 +76,9 @@ rm -rf $RPM_BUILD_ROOT %changelog +* Mon Aug 5 2013 Remi Collet r...@fedoraproject.org - 1.04-1 +- update to 1.04 + * Sat Jun 15 2013 Remi Collet r...@fedoraproject.org - 1.03-1 - update to 1.03 diff --git a/sources b/sources index a4c0c47..81ef2a2 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -16c73d1419881904483377232a75fc93 Net-SSLGlue-1.03.tar.gz +8a6116f625eb5cb58791359f89800234 Net-SSLGlue-1.04.tar.gz -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
File Net-SSLGlue-1.04.tar.gz uploaded to lookaside cache by remi
A file has been added to the lookaside cache for perl-Net-SSLGlue: 8a6116f625eb5cb58791359f89800234 Net-SSLGlue-1.04.tar.gz -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[perl-Net-SSLGlue] update to 1.04
commit 05a779771277dc7cd8d416d3304836f34f81b4c6 Author: Remi Collet r...@fedoraproject.org Date: Mon Aug 5 16:39:17 2013 +0200 update to 1.04 .gitignore|1 + perl-Net-SSLGlue.spec |7 +-- sources |2 +- 3 files changed, 7 insertions(+), 3 deletions(-) --- diff --git a/.gitignore b/.gitignore index 1740c7f..5ba8336 100644 --- a/.gitignore +++ b/.gitignore @@ -4,3 +4,4 @@ /Net-SSLGlue-0.8.tar.gz /Net-SSLGlue-1.01.tar.gz /Net-SSLGlue-1.03.tar.gz +/Net-SSLGlue-1.04.tar.gz diff --git a/perl-Net-SSLGlue.spec b/perl-Net-SSLGlue.spec index 6b1fe36..ccfa6f1 100644 --- a/perl-Net-SSLGlue.spec +++ b/perl-Net-SSLGlue.spec @@ -1,6 +1,6 @@ Name: perl-Net-SSLGlue -Version:1.03 -Release:3%{?dist} +Version:1.04 +Release:1%{?dist} Summary:Add/extend SSL support for common perl modules License:GPL+ or Artistic Group: Development/Libraries @@ -76,6 +76,9 @@ rm -rf $RPM_BUILD_ROOT %changelog +* Mon Aug 5 2013 Remi Collet r...@fedoraproject.org - 1.04-1 +- update to 1.04 + * Sat Aug 03 2013 Fedora Release Engineering rel-...@lists.fedoraproject.org - 1.03-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild diff --git a/sources b/sources index a4c0c47..81ef2a2 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -16c73d1419881904483377232a75fc93 Net-SSLGlue-1.03.tar.gz +8a6116f625eb5cb58791359f89800234 Net-SSLGlue-1.04.tar.gz -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
rpmfusion.org defaced.
If you haven't notice, rpmfusion.org have been defaced. Please, do what is needed. Remi.
Re: RFC: Proposal for a more agile Fedora.next (draft of my Flock talk)
Le 22/07/2013 15:38, Matthew Miller a écrit : Wait, did you just say Fedora _Core_? Yes I did. But, this is not a return to the old Core + Extras, because the line is drawn based on _what_ and _how_ rather than on who works for what company. Whatever explanation which can be given, Core is just the worst name to be used. For me, The merge Core + Extras = Fedora is just the most significant step for fedora project as a real community distro. Getting back to Core (even with a different definition) is just something I'd like to avoid because will be considered like a huge regression. Ex : I'm so disgusted that I don't ever have desire to read the rest of the doc. Remi. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: [PECL-DEV] [ANNOUNCEMENT] yar-1.2.0 (stable) Released.
Le 15/07/2013 12:04, PECL Announce a écrit : The new PECL package yar-1.2.0 (stable) has been released at http://pecl.php.net/. Package home: http://pecl.php.net/package/yar From dependencies: PHP Version: PHP 5.2.0 or newer PHP Version: PHP version 5.4.5 or older It seems a bit strange ? (I tried a build against 5.5.0, seems ok). Remi. -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [Dotclear Dev] Communauté, international, incrémental
Le 11/07/2013 08:27, Franck Paul a écrit : Dotclear tourne très bien sur des plateformes PHP 5.4 (je n'ai pas encore testé 5.5), J'utilise Dotclear avec php 5.5 depuis plusieurs mois sans le moindre problème. Remi ___ Dev mailing list - Dev@list.dotclear.org - http://ml.dotclear.org/listinfo/dev
[PHP-DEV] bug #65082 - extension to json_ecnode for not-utf8 char input.
See: https://bugs.php.net/65082 Proposal: https://github.com/remicollet/pecl-json-c/commit/5a499a4550d1f29f1f8eeb1b4ca0b01a33c64779 I think this request make sense and think to apply this enhancement in php 5.5. Do you agree ? Other ideas ? Remi. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: Negative karma for missing update descriptions?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 04/07/2013 17:09, Ankur Sinha a écrit : On Thu, 2013-07-04 at 14:51 +, Jóhann B. Guðmundsson wrote: How does a reporter supposed to know which bugs are fixed if there is no update description? One can specify what bugs an update fixes in Bodhi. These bugs are closed when the update goes stable, and these bugs are listed both in bodhi and in fedora-easy-karma. All the updates I've seen today that received negative karma for their descriptions had these bugs specified. I think an update with some bug link(s) really have a description. And I also think that an update without description (really no description, or only a short silly message) could receive negative karma. But probably because I always try to give as much as possible information in my updates. Remi. -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlHVlOUACgkQYUppBSnxahgYWgCdGgrzupwG/pVI2rPHNLKrzLmw iRAAnRzEbQfKGfjOauV3f37vL/IOhqm6 =jxqw -END PGP SIGNATURE- -- test mailing list test@lists.fedoraproject.org To unsubscribe: https://admin.fedoraproject.org/mailman/listinfo/test
Re: Who uses abi-compliance-checker?
Le 03/07/2013 22:03, Richard Shaw a écrit : I initially got abi-compliance-checker into Fedora because one of my packages does not maintain any sort of API/ABI compatibility or even versioning for that matter. That way I could always check a new release to see if any of its dependencies needed to be rebuilt. Since then, I've started using it for all of my libraries in the spirit of Trust but verify, and I've occasionally found issues even though upstream didn't bump the soversion. So out of curiosity, anyone else using this great tool? I used it for some libraries I maintain. http://rpms.famillecollet.com/compat_reports/ But I also use http://upstream-tracker.org/ Very usefull, except for not yet released version. Remi If anyone is curious about it, I don't mind typing up the process I go through to make the checks. I think I've found a pretty good path of least resistance method :) Thanks, Richard -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
[PHP-DEV] Re: [PHP-CVS] com php-src: Fix PDO_DBLIB bugs - FreeTDS dependency
Le 04/06/2013 05:02, Stanley Sufficool a écrit : Commit:5a04ab9a54f529f4197bed6f17599604266cdb35 Author:Stanley Sufficool ssuffic...@php.net Mon, 3 Jun 2013 20:02:08 -0700 Parents: 7360f0f1e6c4b49e89bd3c2cf1f524e9cf7f9dcc Branches: PHP-5.4 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=5a04ab9a54f529f4197bed6f17599604266cdb35 Log: Fix PDO_DBLIB bugs: #64338, #64808, #63638 Note: this change raises dependency on freetds 0.91 (don't build with previous and old 0.82) Probably not a big issue. Need to be known. Remi P.S sorry to have not detect this earlier (but I don't build RC for all possible targets...) /builddir/build/BUILD/php-5.4.17/ext/pdo_dblib/dblib_driver.c: In function 'dblib_handle_quoter': /builddir/build/BUILD/php-5.4.17/ext/pdo_dblib/dblib_driver.c:146: warning: unused variable 'H' /builddir/build/BUILD/php-5.4.17/ext/pdo_dblib/dblib_driver.c: In function 'pdo_dblib_transaction_cmd': /builddir/build/BUILD/php-5.4.17/ext/pdo_dblib/dblib_driver.c:175: warning: unused variable 'ret' /builddir/build/BUILD/php-5.4.17/ext/pdo_dblib/dblib_driver.c: In function 'pdo_dblib_handle_factory': /builddir/build/BUILD/php-5.4.17/ext/pdo_dblib/dblib_driver.c:277: error: 'DBVERSION_71' undeclared (first use in this function) /builddir/build/BUILD/php-5.4.17/ext/pdo_dblib/dblib_driver.c:277: error: (Each undeclared identifier is reported only once /builddir/build/BUILD/php-5.4.17/ext/pdo_dblib/dblib_driver.c:277: error: for each function it appears in.) /builddir/build/BUILD/php-5.4.17/ext/pdo_dblib/dblib_driver.c:278: error: 'DBVERSION_72' undeclared (first use in this function) /builddir/build/BUILD/php-5.4.17/ext/pdo_dblib/dblib_driver.c:365: warning: implicit declaration of function 'DBSETLDBNAME' /builddir/build/BUILD/php-5.4.17/ext/pdo_dblib/dblib_driver.c:269: warning: unused variable 'val' -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Fix PDO_DBLIB bugs - FreeTDS dependency
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 03/07/2013 19:17, Ralf Lang a écrit : Remi P.S sorry to have not detect this earlier (but I don't build RC for all possible targets...) /builddir/build/BUILD/php-5.4.17/ext/pdo_dblib/dblib_driver.c: In I could set up an obs project for rhel, fedora and a service to build on each master commit etc... I just don't have enough insight to see what it means when it doesn't build ;) It's not a problem for Fedora, as all maintained version have freetds-0.91. It's not a problem for RHEL as php-mssql not provided (and EPEL also have freetds-0.91). Remi. -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlHUXlkACgkQYUppBSnxahhWuwCgkH+mFuqpzFnrm97IGLmzsKP2 R3sAoLTZFzUfpEYIHoCnh+MfSmSFBWuJ =iyUp -END PGP SIGNATURE- -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] com php-src: NEWS: NEWS
Commit:4bc11af193cef12d7469143b7969b929a7dbf926 Author:Remi Collet r...@php.net Tue, 2 Jul 2013 10:46:21 +0200 Parents: c940aab7895fa4cb109e7790ae14080090b04959 Branches: PHP-5.4 PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=4bc11af193cef12d7469143b7969b929a7dbf926 Log: NEWS Changed paths: M NEWS Diff: diff --git a/NEWS b/NEWS index 094ce8a..a6e4e22 100644 --- a/NEWS +++ b/NEWS @@ -14,6 +14,9 @@ PHP NEWS argument). (Felipe) . Fixed bug #60732 (php_error_docref links to invalid pages). (Jakub Vrana) +- CGI: + . Fixed Bug #65143 (Missing php-cgi man page). (Remi) + - CLI server: . Fixed bug #65066 (Cli server not responsive when responding with 422 http status code). (Adam) -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] com php-src: Fixed Bug #65142 Missing phar man page: NEWS ext/phar/Makefile.frag ext/phar/config.m4 ext/phar/phar.1.in ext/phar/phar.phar.1.in
Commit:f4ce5e7fb65ce215ea5fd182a90aaa4d634f6023 Author:Remi Collet r...@php.net Tue, 2 Jul 2013 10:46:50 +0200 Parents: 4bc11af193cef12d7469143b7969b929a7dbf926 Branches: PHP-5.4 PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=f4ce5e7fb65ce215ea5fd182a90aaa4d634f6023 Log: Fixed Bug #65142 Missing phar man page Simple man page from phar help output. Bugs: https://bugs.php.net/65142 Changed paths: M NEWS M ext/phar/Makefile.frag M ext/phar/config.m4 A ext/phar/phar.1.in A ext/phar/phar.phar.1.in diff --git a/NEWS b/NEWS index a6e4e22..1d3385a 100644 --- a/NEWS +++ b/NEWS @@ -42,6 +42,9 @@ PHP NEWS . Allowed PDO_OCI to compile with Oracle Database 12c client libraries. (Chris Jones) +- Phar: + . Fixed Bug #65142 (Missing phar man page). (Remi) + - Session . Fixed bug #62535 ($_SESSION[$key][cancel_upload] doesn't work as documented). (Arpad) diff --git a/ext/phar/Makefile.frag b/ext/phar/Makefile.frag index b1c820f..ed6de9f 100644 --- a/ext/phar/Makefile.frag +++ b/ext/phar/Makefile.frag @@ -40,3 +40,7 @@ install-pharcmd: pharcmd $(INSTALL) $(builddir)/phar.phar $(INSTALL_ROOT)$(bindir) -@rm -f $(INSTALL_ROOT)$(bindir)/phar $(LN_S) -f $(bindir)/phar.phar $(INSTALL_ROOT)$(bindir)/phar + @$(mkinstalldirs) $(INSTALL_ROOT)$(mandir)/man1 + @$(INSTALL_DATA) $(builddir)/phar.1 $(INSTALL_ROOT)$(mandir)/man1/phar.1 + @$(INSTALL_DATA) $(builddir)/phar.phar.1 $(INSTALL_ROOT)$(mandir)/man1/phar.phar.1 + diff --git a/ext/phar/config.m4 b/ext/phar/config.m4 index 2ac7f3d..d424060 100644 --- a/ext/phar/config.m4 +++ b/ext/phar/config.m4 @@ -27,4 +27,6 @@ if test $PHP_PHAR != no; then PHP_ADD_EXTENSION_DEP(phar, hash, true) PHP_ADD_EXTENSION_DEP(phar, spl, true) PHP_ADD_MAKEFILE_FRAGMENT + + PHP_OUTPUT(ext/phar/phar.1 ext/phar/phar.phar.1) fi diff --git a/ext/phar/phar.1.in b/ext/phar/phar.1.in new file mode 100644 index 000..259a2ba --- /dev/null +++ b/ext/phar/phar.1.in @@ -0,0 +1,523 @@ +.TH PHAR 1 2013 The PHP Group User Commands +.SH NAME +phar, phar.phar \- PHAR (PHP archive) command line tool +.SH SYNOPSIS +.B phar +command [options] ... +.LP +.SH DESCRIPTION +The \fBPHAR\fP file format provides a way to put entire PHP applications into a single +file called a phar (PHP Archive) for easy distribution and installation. +.P +With the \fBphar\fP command you can create, update or extract PHP archives. +.P +Commands: +add compress delete extract help help-list info list meta-del +meta-get meta-set pack sign stub-get stub-set tree version + +.SH add command +Add entries to a PHAR package. +.P +Required arguments: +.TP 15 +.PD +.B -f \fIfile\fP +Specifies the phar \fIfile\fP to work on. +.TP +.PD +.B ... +Any number of input files and directories. If -i is in +use then ONLY files and matching the given regular +expression are being packed. If -x is given then files +matching that regular expression are NOT being packed. +.P +Optional arguments: +.TP 15 +.PD +.B \-a \fIalias\fP +Provide an \fIalias\fP name for the phar file. +.TP +.PD +.B \-c \fIalgo\fP +Compression algorithm (see +.SM +.B COMPRESSION +) +.TP +.PD +.B \-i \fIregex\fP +Specifies a regular expression for input files. +.TP +.PD +.B \-l \fIlevel\fP +Number of preceding subdirectories to strip from file entries +.TP +.PD +.B \-x \fIregex\fP +Regular expression for input files to exclude. + +.SH compress command +Compress or uncompress all files or a selected entry. +.P +Required arguments: +.TP 15 +.PD +.B \-c \fIalgo\fP +Compression algorithm (see +.SM +.B COMPRESSION +) +.TP +.PD +.B -f \fIfile\fP +Specifies the phar \fIfile\fP to work on. +.P +Optional arguments: +.TP 15 +.PD +.B -e \fIentry\fP +Name of \fIentry\fP to work on (must include PHAR internal +directory name if any). + +.SH delete command +Delete entry from a PHAR archive +.P +Required arguments: +.TP 15 +.PD +.B \-e \fIentry\fP +Name of \fIentry\fP to work on (must include PHAR internal +directory name if any). +.TP +.PD +.B -f \fIfile\fP +Specifies the phar \fIfile\fP to work on. + +.SH extract command +Extract a PHAR package to a directory. +.P +Required arguments: +.TP 15 +.PD +.B -f \fIfile\fP +Specifies the phar \fIfile\fP to work on. +.P +Optional arguments: +.TP 15 +.PD +.B -i \fIregex\fP +Specifies a regular expression for input files. +.TP +.PD +.B -x \fIregex\fP +Regular expression for input files to exclude. +.TP +.PD +.B ... +Directory to extract to (defaults to '.'). + + +.SH help command +This help or help for a selected command. +.P +Optional arguments: +.TP 15 +.PD +.B ... +Optional command to retrieve help for. + +.SH help-list command +Lists available commands. + +.SH info command +Get information about a PHAR package. +.P +By using -k it is possible to return a single value. +.P +Required arguments: +.TP 15 +.PD +.B -f \fIfile\fP +Specifies the phar \fIfile\fP
[PHP-CVS] com php-src: NEWS: NEWS
Commit:4d5a2fba16dac42a29145d2dbc074c4ddb87589d Author:Remi Collet r...@php.net Tue, 2 Jul 2013 10:48:19 +0200 Parents: 8f0567581e942a56c8e73d4672387a38bcb43eb8 Branches: PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=4d5a2fba16dac42a29145d2dbc074c4ddb87589d Log: NEWS Changed paths: M NEWS Diff: diff --git a/NEWS b/NEWS index 4cbd4e8..860b3c3 100644 --- a/NEWS +++ b/NEWS @@ -14,6 +14,9 @@ PHP NEWS . Fixed bug #64827 (Segfault in zval_mark_grey (zend_gc.c)). (Laruence) . OPcache must be compatible with LiteSpeed SAPI (Dmitry) +- CGI: + . Fixed Bug #65143 (Missing php-cgi man page). (Remi) + - CLI server: . Fixed bug #65066 (Cli server not responsive when responding with 422 http status code). (Adam) @@ -35,6 +38,9 @@ PHP NEWS . Allowed PDO_OCI to compile with Oracle Database 12c client libraries. (Chris Jones) +- Phar: + . Fixed Bug #65142 (Missing phar man page). (Remi) + - Session: . Added optional create_sid() argument to session_set_save_handler(), SessionHandler and new SessionIdInterface. (Leigh, Arpad) -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] com php-src: Fixed Bug #65143 Missing php-cgi man page: sapi/cgi/Makefile.frag sapi/cgi/config9.m4 sapi/cgi/php-cgi.1.in sapi/cli/php.1.in
Commit:c940aab7895fa4cb109e7790ae14080090b04959 Author:Remi Collet r...@php.net Tue, 2 Jul 2013 10:42:47 +0200 Parents: 743c4864eb5c868a96d66180a562a00133861385 Branches: PHP-5.4 PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=c940aab7895fa4cb109e7790ae14080090b04959 Log: Fixed Bug #65143 Missing php-cgi man page Currently php-cgi man page is a simple redirect to php (CLI) man page. Could be splited / improved in the future. Bugs: https://bugs.php.net/65143 Changed paths: M sapi/cgi/Makefile.frag M sapi/cgi/config9.m4 A sapi/cgi/php-cgi.1.in M sapi/cli/php.1.in Diff: diff --git a/sapi/cgi/Makefile.frag b/sapi/cgi/Makefile.frag index 505119e..d54dd40 100644 --- a/sapi/cgi/Makefile.frag +++ b/sapi/cgi/Makefile.frag @@ -6,4 +6,7 @@ $(SAPI_CGI_PATH): $(PHP_GLOBAL_OBJS) $(PHP_BINARY_OBJS) $(PHP_CGI_OBJS) install-cgi: $(SAPI_CGI_PATH) @echo Installing PHP CGI binary:$(INSTALL_ROOT)$(bindir)/ @$(INSTALL) -m 0755 $(SAPI_CGI_PATH) $(INSTALL_ROOT)$(bindir)/$(program_prefix)php-cgi$(program_suffix)$(EXEEXT) + @echo Installing PHP CGI man page: $(INSTALL_ROOT)$(mandir)/man1/ + @$(mkinstalldirs) $(INSTALL_ROOT)$(mandir)/man1 + @$(INSTALL_DATA) sapi/cgi/php-cgi.1 $(INSTALL_ROOT)$(mandir)/man1/$(program_prefix)php-cgi$(program_suffix).1 diff --git a/sapi/cgi/config9.m4 b/sapi/cgi/config9.m4 index 67251ae..49e61c8 100644 --- a/sapi/cgi/config9.m4 +++ b/sapi/cgi/config9.m4 @@ -71,6 +71,8 @@ if test $PHP_CGI != no; then dnl Expose to Makefile PHP_SUBST(SAPI_CGI_PATH) PHP_SUBST(BUILD_CGI) + +PHP_OUTPUT(sapi/cgi/php-cgi.1) else AC_MSG_RESULT(yes) fi diff --git a/sapi/cgi/php-cgi.1.in b/sapi/cgi/php-cgi.1.in new file mode 100644 index 000..340e6c5 --- /dev/null +++ b/sapi/cgi/php-cgi.1.in @@ -0,0 +1 @@ +.so man1/php.1 diff --git a/sapi/cli/php.1.in b/sapi/cli/php.1.in index 0e9d07a..6f0266d 100644 --- a/sapi/cli/php.1.in +++ b/sapi/cli/php.1.in @@ -1,6 +1,8 @@ .TH PHP 1 2013 The PHP Group Scripting Language .SH NAME php \- PHP Command Line Interface 'CLI' +.P +php-cgi \- PHP Command Gateway Interface 'CGI' .SH SYNOPSIS .B php [options] [ -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] com php-src: Merge branch 'PHP-5.4' into PHP-5.5: ext/phar/Makefile.frag
Commit:8f0567581e942a56c8e73d4672387a38bcb43eb8 Author:Remi Collet r...@php.net Tue, 2 Jul 2013 10:47:38 +0200 Parents: 1968fac697946e813074c68bb9c8d2f916f9bab4 f4ce5e7fb65ce215ea5fd182a90aaa4d634f6023 Branches: PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=8f0567581e942a56c8e73d4672387a38bcb43eb8 Log: Merge branch 'PHP-5.4' into PHP-5.5 * PHP-5.4: Fixed Bug #65142 Missing phar man page NEWS Fixed Bug #65143 Missing php-cgi man page Bugs: https://bugs.php.net/65142 https://bugs.php.net/65143 Changed paths: MM ext/phar/Makefile.frag Diff: -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] com php-src: fix typo in php man page: sapi/cli/php.1.in
Commit:67817a199ca4c8bcff163cb005287c0087db6bf3 Author:Remi Collet r...@php.net Tue, 2 Jul 2013 12:19:09 +0200 Parents: f4ce5e7fb65ce215ea5fd182a90aaa4d634f6023 Branches: PHP-5.4 PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=67817a199ca4c8bcff163cb005287c0087db6bf3 Log: fix typo in php man page Changed paths: M sapi/cli/php.1.in Diff: diff --git a/sapi/cli/php.1.in b/sapi/cli/php.1.in index 6f0266d..749baa8 100644 --- a/sapi/cli/php.1.in +++ b/sapi/cli/php.1.in @@ -2,7 +2,7 @@ .SH NAME php \- PHP Command Line Interface 'CLI' .P -php-cgi \- PHP Command Gateway Interface 'CGI' +php-cgi \- PHP Common Gateway Interface 'CGI' command .SH SYNOPSIS .B php [options] [ -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
APC is dead - Welcome APCU
Hi, php-pecl-apc have been retired from rawhide repository. php-pecl-apcu is a dropin alternative for user cache and is also available in F18, F19 and EPEL6 (testing). It's time to switch and test. Remi. P.S. opcode cache is now provided by zend-opcache (php 5.5) or php-pecl-zendopcache (php 5.3 / 5.4), the official PHP project opcode cache. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
[PHP-DEV] phar command man page
Hi, See https://bugs.php.net/bug.php?id=65142 I've created a man page for phar. Please have a quick look. If no disagreement, I plan to commit this file in 5.4 Remi. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] phar command man page
Also https://bugs.php.net/bug.php?id=65143 for php-cgi. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: libgd breakage
Le 26/06/2013 14:36, Paulo César Pereira de Andrade a écrit : Hi, It is taking a bit too long for some dependencies to be rebuilt in rawhide. Could a compat-libgd be provided please? I am receiving daily mails about broken deps, already posted to $pkg-owner@ asking what I could help, but still no response neither problems corrected. Remi Collet told me it appears there are some FTBFS packages in the cycle. As none of the FBTFS are related to libgd, I don't see any value to have a compat-libgd package. Remi. I would like to also start working on packaging sagemath 5.10, but am not providing as much time to work on fedora as I would want, so also not providing a compat-libgd sample package, sorry... Thanks, Paulo -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: [Glpi-dev] [Glpi-news] GLPI 0.83.91 available / disponible [RPM]
Le 25/06/2013 08:29, This a low traffic a écrit : The official GLPI 0.83.91 version is now available from download on the project web-site : http://glpi-project.org/?article41lang=en This version correct several a security bug. You are stongly encouraged to update your actual version. RPM are already available For Fedora = 17 users in updates-testing repository For RHEL / CentOS... in epel-testing repository Backport also available in remi repository. Notice : due to incompatible version scheme, the RPM version is 0.83.9.1 Remi. ___ Glpi-dev mailing list Glpi-dev@gna.org https://mail.gna.org/listinfo/glpi-dev
[PHP-CVS] com php-src: Upstream fix from https://bitbucket.org/libgd/gd-libgd/issue/75: ext/gd/libgd/gd_webp.c
Commit:b4632d0c1249bf0042324eb83cd11339c977a441 Author:Remi Collet r...@php.net Mon, 24 Jun 2013 11:03:12 +0200 Parents: f49b27e166739946c255924d6609d0a40a70783b Branches: PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=b4632d0c1249bf0042324eb83cd11339c977a441 Log: Upstream fix from https://bitbucket.org/libgd/gd-libgd/issue/75 Changed paths: M ext/gd/libgd/gd_webp.c Diff: diff --git a/ext/gd/libgd/gd_webp.c b/ext/gd/libgd/gd_webp.c index 889f5f1..bf9ac9d 100644 --- a/ext/gd/libgd/gd_webp.c +++ b/ext/gd/libgd/gd_webp.c @@ -58,11 +58,13 @@ gdImagePtr gdImageCreateFromWebpPtr (int size, void *data) return im; } +#define GD_WEBP_ALLOC_STEP (4*1024) + gdImagePtr gdImageCreateFromWebpCtx (gdIOCtx * infile) { intwidth, height, ret; - unsigned char *filedata; - unsigned char dummy[1024]; + unsigned char *filedata = NULL; + unsigned char *read, *temp; unsigned char *Y = NULL; unsigned char *U = NULL; unsigned char *V = NULL; @@ -70,16 +72,25 @@ gdImagePtr gdImageCreateFromWebpCtx (gdIOCtx * infile) gdImagePtr im; do { - n = gdGetBuf(dummy, 1024, infile); - size += n; - } while (n != EOF); + temp = gdRealloc(filedata, size+GD_WEBP_ALLOC_STEP); + if (temp) { + filedata = temp; + read = temp + size; + } else { + if (filedata) { + gdFree(filedata); + } + php_gd_error(WebP decode: realloc failed); + return NULL; + } + + n = gdGetBuf(read, GD_WEBP_ALLOC_STEP, infile); + /* differs from upstream where gdGetBuf return 0 instead of EOF */ + if (n0 n!=EOF) { + size += n; + } + } while (n0 n!=EOF); - filedata = gdMalloc(size); - if (!filedata) { - php_gd_error(WebP decode: alloc failed); - return NULL; - } - gdGetBuf(filedata, size, infile); ret = WebPDecode(filedata, size, Y, U, V, width, height); gdFree(filedata); if (ret != webp_success) { -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] com php-src: Use same logic to load WebP image that other formats: NEWS ext/gd/gd.c
Commit:8075f1f4a37804d00b35556826d378de513f7a8c Author:Remi Collet r...@php.net Mon, 24 Jun 2013 11:10:52 +0200 Parents: b4632d0c1249bf0042324eb83cd11339c977a441 Branches: PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=8075f1f4a37804d00b35556826d378de513f7a8c Log: Use same logic to load WebP image that other formats Changed paths: M NEWS M ext/gd/gd.c Diff: diff --git a/NEWS b/NEWS index 2d35499..2df33bc 100644 --- a/NEWS +++ b/NEWS @@ -18,6 +18,8 @@ OPcache imagerotate). (Pierre) . Fixed Bug #65060 (imagecreatefrom... crashes with user streams). (Remi) . Fixed Bug #65084 (imagecreatefromjpeg fails with URL). (Remi) + . Fix gdImageCreateFromWebpCtx and use same logic to load WebP image +that other formats. (Remi) - Intl: . Fixed bug #62759: Buggy grapheme_substr() on edge case. (Stas) diff --git a/ext/gd/gd.c b/ext/gd/gd.c index 49370a7..9bdedee 100644 --- a/ext/gd/gd.c +++ b/ext/gd/gd.c @@ -2367,23 +2367,6 @@ static void _php_image_create_from(INTERNAL_FUNCTION_PARAMETERS, int image_type, RETURN_FALSE; } - if (image_type == PHP_GDIMG_TYPE_WEBP) { - size_t buff_size; - char *buff; - - /* needs to be malloc (persistent) - GD will free() it later */ - buff_size = php_stream_copy_to_mem(stream, buff, PHP_STREAM_COPY_ALL, 1); - if (!buff_size) { - php_error_docref(NULL TSRMLS_CC, E_WARNING,Cannot read image data); - goto out_err; - } - im = (*ioctx_func_p)(buff_size, buff); - if (!im) { - goto out_err; - } - goto register_im; - } - /* try and avoid allocating a FILE* if the stream is not naturally a FILE* */ if (php_stream_is(stream, PHP_STREAM_IS_STDIO)) { if (FAILURE == php_stream_cast(stream, PHP_STREAM_AS_STDIO, (void**)fp, REPORT_ERRORS)) { @@ -2499,7 +2482,7 @@ PHP_FUNCTION(imagecreatefrompng) Create a new image from PNG file or URL */ PHP_FUNCTION(imagecreatefromwebp) { - _php_image_create_from(INTERNAL_FUNCTION_PARAM_PASSTHRU, PHP_GDIMG_TYPE_WEBP, WEBP, gdImageCreateFromWebpPtr, gdImageCreateFromWebpPtr); + _php_image_create_from(INTERNAL_FUNCTION_PARAM_PASSTHRU, PHP_GDIMG_TYPE_WEBP, WEBP, gdImageCreateFromWebp, gdImageCreateFromWebpCtx); } /* }}} */ #endif /* HAVE_GD_VPX */ -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] com php-src: Merge branch 'PHP-5.5': ext/gd/gd.c
Commit:8c694401bb817ce645abe87c094615a3d5ed87ce Author:Remi Collet r...@php.net Mon, 24 Jun 2013 11:11:02 +0200 Parents: 6c56d785aea5a14cd8a6164f2a4e4e71bc55b9d6 8075f1f4a37804d00b35556826d378de513f7a8c Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=8c694401bb817ce645abe87c094615a3d5ed87ce Log: Merge branch 'PHP-5.5' * PHP-5.5: Use same logic to load WebP image that other formats Changed paths: MM ext/gd/gd.c Diff: -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] com php-src: fix imagecreatefromwebp and imagewebp protos: ext/gd/gd.c
Commit:9da4985bf2d532ed72fbd3a7d3390464692cce7a Author:Remi Collet r...@php.net Mon, 24 Jun 2013 11:15:50 +0200 Parents: 8075f1f4a37804d00b35556826d378de513f7a8c Branches: PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=9da4985bf2d532ed72fbd3a7d3390464692cce7a Log: fix imagecreatefromwebp and imagewebp protos Changed paths: M ext/gd/gd.c Diff: diff --git a/ext/gd/gd.c b/ext/gd/gd.c index 9bdedee..7fef56e 100644 --- a/ext/gd/gd.c +++ b/ext/gd/gd.c @@ -2478,8 +2478,8 @@ PHP_FUNCTION(imagecreatefrompng) #endif /* HAVE_GD_PNG */ #ifdef HAVE_GD_WEBP -/* {{{ proto resource imagecreatefrompng(string filename) - Create a new image from PNG file or URL */ +/* {{{ proto resource imagecreatefromwebp(string filename) + Create a new image from WEBP file or URL */ PHP_FUNCTION(imagecreatefromwebp) { _php_image_create_from(INTERNAL_FUNCTION_PARAM_PASSTHRU, PHP_GDIMG_TYPE_WEBP, WEBP, gdImageCreateFromWebp, gdImageCreateFromWebpCtx); @@ -2718,7 +2718,7 @@ PHP_FUNCTION(imagepng) #ifdef HAVE_GD_WEBP /* {{{ proto bool imagewebp(resource im [, string filename[, quality]] ) - Output PNG image to browser or file */ + Output WEBP image to browser or file */ PHP_FUNCTION(imagewebp) { _php_image_output_ctx(INTERNAL_FUNCTION_PARAM_PASSTHRU, PHP_GDIMG_TYPE_WEBP, WEBP, gdImageWebpCtx); -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] com php-src: Merge branch 'PHP-5.5': ext/gd/gd.c
Commit:8e4e38aaeea0944a976fd2629c210c87483dcb3f Author:Remi Collet r...@php.net Mon, 24 Jun 2013 11:15:56 +0200 Parents: 8c694401bb817ce645abe87c094615a3d5ed87ce 9da4985bf2d532ed72fbd3a7d3390464692cce7a Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=8e4e38aaeea0944a976fd2629c210c87483dcb3f Log: Merge branch 'PHP-5.5' * PHP-5.5: fix imagecreatefromwebp and imagewebp protos Changed paths: MM ext/gd/gd.c Diff: -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] com php-src: Fixed Bug #65060 imagecreatefrom... crashes with user streams Fixed Bug #65084 imagecreatefromjpeg fails with URL: NEWS ext/gd/gd.c
Commit:fc898ee0f94ee3686aa1f359d4a973d5e8e1754b Author:Remi Collet r...@php.net Fri, 21 Jun 2013 14:11:04 +0200 Parents: 162726241ccfa567b3867a10f1f7ec6fa365533c Branches: PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=fc898ee0f94ee3686aa1f359d4a973d5e8e1754b Log: Fixed Bug #65060 imagecreatefrom... crashes with user streams Fixed Bug #65084 imagecreatefromjpeg fails with URL Regression introduced in 8a90aad (drop of USE_GD_IOCTX) Secure with php_stream_can_cast to avoid segfault in php_stream_cast. (encountered when imagecreatefromxpm with URL) Bugs: https://bugs.php.net/65060 https://bugs.php.net/65084 Changed paths: M NEWS M ext/gd/gd.c Diff: diff --git a/NEWS b/NEWS index d8b74c2..577d2e4 100644 --- a/NEWS +++ b/NEWS @@ -8,6 +8,8 @@ PHP NEWS - GD . Fixed #65070 (bgcolor does not use the same format as the input image with imagerotate). (Pierre) + . Fixed Bug #65060 (imagecreatefrom... crashes with user streams). (Remi) + . Fixed Bug #65084 (imagecreatefromjpeg fails with URL). (Remi) 20 Jun 2013, PHP 5.5.0 diff --git a/ext/gd/gd.c b/ext/gd/gd.c index 4ebac94..21aa9e2 100644 --- a/ext/gd/gd.c +++ b/ext/gd/gd.c @@ -2361,13 +2361,12 @@ static void _php_image_create_from(INTERNAL_FUNCTION_PARAMETERS, int image_type, } } + stream = php_stream_open_wrapper(file, rb, REPORT_ERRORS|IGNORE_PATH|IGNORE_URL_WIN, NULL); if (stream == NULL) { RETURN_FALSE; } - ioctx_func_p = NULL; /* don't allow sockets without IOCtx */ - if (image_type == PHP_GDIMG_TYPE_WEBP) { size_t buff_size; char *buff; @@ -2419,7 +2418,7 @@ static void _php_image_create_from(INTERNAL_FUNCTION_PARAMETERS, int image_type, io_ctx-gd_free(io_ctx); pefree(buff, 1); } - else { + else if (php_stream_can_cast(stream, PHP_STREAM_AS_STDIO)) { /* try and force the stream to be FILE* */ if (FAILURE == php_stream_cast(stream, PHP_STREAM_AS_STDIO | PHP_STREAM_CAST_TRY_HARD, (void **) fp, REPORT_ERRORS)) { goto out_err; -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] com php-src: Merge branch 'PHP-5.5': ext/gd/gd.c
Commit:20dbd2710835bf03a0f8e344e9bd1bbad38e845d Author:Remi Collet r...@php.net Fri, 21 Jun 2013 14:11:33 +0200 Parents: 9b22faa5b8ea2579f6247e024b0c59fd032a7eed fc898ee0f94ee3686aa1f359d4a973d5e8e1754b Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=20dbd2710835bf03a0f8e344e9bd1bbad38e845d Log: Merge branch 'PHP-5.5' * PHP-5.5: Fixed Bug #65060 imagecreatefrom... crashes with user streams Fixed Bug #65084 imagecreatefromjpeg fails with URL Bugs: https://bugs.php.net/65060 https://bugs.php.net/65084 Changed paths: MM ext/gd/gd.c Diff: -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] com php-src: skip test for bug #64936 when tokenizer not built: ext/reflection/tests/bug64936.phpt
Commit:9be591bdb503740ef5d3261422a180e68b9eb3fc Author:Remi Collet r...@php.net Thu, 20 Jun 2013 08:42:07 +0200 Parents: 0e55d3a12a668c08378326e4aa4e8556b5a384b0 Branches: PHP-5.4 PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=9be591bdb503740ef5d3261422a180e68b9eb3fc Log: skip test for bug #64936 when tokenizer not built Bugs: https://bugs.php.net/64936 Changed paths: M ext/reflection/tests/bug64936.phpt Diff: diff --git a/ext/reflection/tests/bug64936.phpt b/ext/reflection/tests/bug64936.phpt index 578dc7e..363a17f 100644 --- a/ext/reflection/tests/bug64936.phpt +++ b/ext/reflection/tests/bug64936.phpt @@ -3,6 +3,10 @@ ReflectionMethod::getDocComment() uses left over doc comment from previous scann --INI-- opcache.save_comments=1 opcache.load_comments=1 +--SKIPIF-- +?php +if (!extension_loaded('reflection') || !extension_loaded('tokenizer')) print 'skip missing reflection of tokernizer extension'; +? --FILE-- ?php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Fedora 19 - Feature PHP 5.5 done !
https://fedoraproject.org/wiki/Features/Php55 I just create the update to PHP 5.5.0 final. https://admin.fedoraproject.org/updates/php-5.5.0-1.fc19 Very very short before F19 release ! Remi. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Minimal install diff from F16 to F19 (TC6)
Le 20/06/2013 11:52, Harald Hoyer a écrit : $ rpm -q --whatrequires json-c no package requires json-c Probably should try $ rpm -q --whatrequires \ libjson.so.0()(64bit) \ libjson-c.so.2()(64bit) = pulseaudio, abrt, libreport, ... Remi. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Minimal install diff from F16 to F19 (TC6)
Le 20/06/2013 12:18, Harald Hoyer a écrit : On 06/20/2013 11:59 AM, Remi Collet wrote: Le 20/06/2013 11:52, Harald Hoyer a écrit : $ rpm -q --whatrequires json-c no package requires json-c Probably should try $ rpm -q --whatrequires \ libjson.so.0()(64bit) \ libjson-c.so.2()(64bit) = pulseaudio, abrt, libreport, ... Remi. This cries for the compile option -Wl,--as-needed I think I have explain that when updated to 0.11. libjson.so is just a artefact to allow applications build with it to continue to work. libjson-c.so is the correct library (renamed by upstream because of name conflicts with other projects). So, if an application is link with -ljson it will fail and need a fix. As usually, correct way is to use pkg-config output $ pkg-config --cflags json-c -I/usr/include/json-c $ pkg-config --libs json-c -ljson-c And, for compatibility, to avoid to much problem $ pkg-config --libs json -ljson-c Notice : this layer will be dropped in the future. Remi. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Fedora 19 - Feature PHP 5.5 done !
Freeze exception required for this update. https://bugzilla.redhat.com/976306 Remi. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
[PHP-CVS] com php-src: Related to bug #65047 (Test skip on client / server version): ext/pdo_pgsql/tests/bug46274.phpt ext/pdo_pgsql/tests/bug46274_2.phpt ext/pdo_pgsql/tests/bug_49985.phpt
Commit:67bde2f8ac4a6c5a8d36f7aebfd2a4a1621142d0 Author:Remi Collet r...@php.net Wed, 19 Jun 2013 12:26:21 +0200 Parents: c666239265048abd3cc0b2c48493a5db1eacc28e Branches: PHP-5.4 PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=67bde2f8ac4a6c5a8d36f7aebfd2a4a1621142d0 Log: Related to bug #65047 (Test skip on client / server version) bug46274.phpt and bug46274_2.phpt Make query silent (when server don't know bytea_output option) bug_49985.phpt Make result locale independent Bugs: https://bugs.php.net/65047 https://bugs.php.net/46274 Changed paths: M ext/pdo_pgsql/tests/bug46274.phpt M ext/pdo_pgsql/tests/bug46274_2.phpt M ext/pdo_pgsql/tests/bug_49985.phpt Diff: diff --git a/ext/pdo_pgsql/tests/bug46274.phpt b/ext/pdo_pgsql/tests/bug46274.phpt index 8a85c9f..40706ec 100644 --- a/ext/pdo_pgsql/tests/bug46274.phpt +++ b/ext/pdo_pgsql/tests/bug46274.phpt @@ -15,7 +15,7 @@ $db = PDOTest::test_factory(dirname(__FILE__) . '/common.phpt'); $db-setAttribute(PDO::ATTR_STRINGIFY_FETCHES, true); try { - $db-query(SET bytea_output = 'escape'); + @$db-query(SET bytea_output = 'escape'); } catch (Exception $e) { } diff --git a/ext/pdo_pgsql/tests/bug46274_2.phpt b/ext/pdo_pgsql/tests/bug46274_2.phpt index 317160c..df60f34 100644 --- a/ext/pdo_pgsql/tests/bug46274_2.phpt +++ b/ext/pdo_pgsql/tests/bug46274_2.phpt @@ -15,7 +15,7 @@ $db = PDOTest::test_factory(dirname(__FILE__) . '/common.phpt'); $db-setAttribute(PDO::ATTR_STRINGIFY_FETCHES, false); try { -$db-query(SET bytea_output = 'escape'); +@$db-query(SET bytea_output = 'escape'); } catch (Exception $e) { } diff --git a/ext/pdo_pgsql/tests/bug_49985.phpt b/ext/pdo_pgsql/tests/bug_49985.phpt index 26dcfc6..e1d7df8 100644 --- a/ext/pdo_pgsql/tests/bug_49985.phpt +++ b/ext/pdo_pgsql/tests/bug_49985.phpt @@ -30,6 +30,6 @@ for ($i = 0; $i 3; $i++) { ? --EXPECTF-- bool(true) -SQLSTATE[23505]: %stest_pkey -SQLSTATE[23505]: %stest_pkey +SQLSTATE[23505]: %stest_pkey%s +SQLSTATE[23505]: %stest_pkey%s -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PECL-DEV] [ANNOUNCEMENT] mysqlnd_ms-1.5.1 (stable) Released.
Le 19/06/2013 12:50, PECL Announce a écrit : The new PECL package mysqlnd_ms-1.5.1 (stable) has been released at http://pecl.php.net/. Minor issue, this exension reports as 1.5.0-alpha $ grep MS_VERSION mysqlnd_ms-1.5.1/mysqlnd_ms.h #define MYSQLND_MS_VERSION 1.5.1 #define MYSQLND_MS_VERSION_ID 10500 Remi. -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
File Net-SSLGlue-1.03.tar.gz uploaded to lookaside cache by remi
A file has been added to the lookaside cache for perl-Net-SSLGlue: 16c73d1419881904483377232a75fc93 Net-SSLGlue-1.03.tar.gz -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[perl-Net-SSLGlue] update to 1.03
commit 82650069105528ea794b48056538ef051e652d13 Author: Remi Collet r...@fedoraproject.org Date: Sat Jun 15 11:36:54 2013 +0200 update to 1.03 .gitignore|1 + perl-Net-SSLGlue.spec |7 +-- sources |2 +- 3 files changed, 7 insertions(+), 3 deletions(-) --- diff --git a/.gitignore b/.gitignore index 9ecb307..1740c7f 100644 --- a/.gitignore +++ b/.gitignore @@ -3,3 +3,4 @@ /Net-SSLGlue-0.7.tar.gz /Net-SSLGlue-0.8.tar.gz /Net-SSLGlue-1.01.tar.gz +/Net-SSLGlue-1.03.tar.gz diff --git a/perl-Net-SSLGlue.spec b/perl-Net-SSLGlue.spec index 3ba31f9..aaee7e0 100644 --- a/perl-Net-SSLGlue.spec +++ b/perl-Net-SSLGlue.spec @@ -1,6 +1,6 @@ Name: perl-Net-SSLGlue -Version:1.01 -Release:4%{?dist} +Version:1.03 +Release:1%{?dist} Summary:Add/extend SSL support for common perl modules License:GPL+ or Artistic Group: Development/Libraries @@ -76,6 +76,9 @@ rm -rf $RPM_BUILD_ROOT %changelog +* Sat Jun 15 2013 Remi Collet r...@fedoraproject.org - 1.03-1 +- update to 1.03 + * Thu Feb 14 2013 Fedora Release Engineering rel-...@lists.fedoraproject.org - 1.01-4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_19_Mass_Rebuild diff --git a/sources b/sources index 77c2958..a4c0c47 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -23c42165c3a3f962185c562945b007a0 Net-SSLGlue-1.01.tar.gz +16c73d1419881904483377232a75fc93 Net-SSLGlue-1.03.tar.gz -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
File Apache-DBI-1.12.tar.gz uploaded to lookaside cache by remi
A file has been added to the lookaside cache for perl-Apache-DBI: 1bf6ca12b87de05bd53045325064636e Apache-DBI-1.12.tar.gz -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[perl-Apache-DBI] update to 1.12
commit c2732e1fb13bb3531784efc8935b5918aae8986e Author: Remi Collet r...@fedoraproject.org Date: Sat Jun 15 11:44:09 2013 +0200 update to 1.12 .gitignore |1 + perl-Apache-DBI.spec |7 +-- sources |2 +- 3 files changed, 7 insertions(+), 3 deletions(-) --- diff --git a/.gitignore b/.gitignore index 1045358..cd6e81d 100644 --- a/.gitignore +++ b/.gitignore @@ -1,2 +1,3 @@ *spec~ /Apache-DBI-1.11.tar.gz +/Apache-DBI-1.12.tar.gz diff --git a/perl-Apache-DBI.spec b/perl-Apache-DBI.spec index 10ecf7d..6f77530 100644 --- a/perl-Apache-DBI.spec +++ b/perl-Apache-DBI.spec @@ -1,8 +1,8 @@ %global perlname Apache-DBI Name: perl-Apache-DBI -Version: 1.11 -Release: 5%{?dist} +Version: 1.12 +Release: 1%{?dist} Summary: Persistent database connections with Apache/mod_perl Group: Development/Libraries @@ -72,6 +72,9 @@ make test %{perl_vendorlib}/Apache %changelog +* Sat Jun 15 2013 Remi Collet fed...@famillecollet.com 1.12-1 +- update to 1.12 + * Thu Feb 14 2013 Fedora Release Engineering rel-...@lists.fedoraproject.org - 1.11-5 - Rebuilt for https://fedoraproject.org/wiki/Fedora_19_Mass_Rebuild diff --git a/sources b/sources index 6fa8b18..267ad83 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -b973fdf5292bbe6caa38a664d0a83f0b Apache-DBI-1.11.tar.gz +1bf6ca12b87de05bd53045325064636e Apache-DBI-1.12.tar.gz -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[perl-Net-SSLGlue/f19] update to 1.03
Summary of changes: 8265006... update to 1.03 (*) (*) This commit already existed in another branch; no separate mail sent -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel