[PATCH 0/3] multipath-tools: docs housekeeping

[Xose Vazquez Perez]

Xose Vazquez Perez (3):
  multipath-tools: simplify comment in hwtable
  multipath-tools: unify text in multipath.conf.5
  multipath-tools: update man pages dates

 libmpathpersist/mpath_persistent_reserve_in.3  |  2 +-
 libmpathpersist/mpath_persistent_reserve_out.3 |  2 +-
 libmultipath/hwtable.c |  4 ++--
 multipath/multipath.8.in   |  2 +-
 multipath/multipath.conf.5.in  | 14 +++---
 multipathd/multipathd.8.in |  2 +-
 6 files changed, 13 insertions(+), 13 deletions(-)

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
-- 
2.44.0

[PATCH 3/3] multipath-tools: update man pages dates

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmpathpersist/mpath_persistent_reserve_in.3  | 2 +-
 libmpathpersist/mpath_persistent_reserve_out.3 | 2 +-
 multipath/multipath.8.in   | 2 +-
 multipath/multipath.conf.5.in  | 2 +-
 multipathd/multipathd.8.in | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/libmpathpersist/mpath_persistent_reserve_in.3 
b/libmpathpersist/mpath_persistent_reserve_in.3
index 6cc35349..4ac43fa3 100644
--- a/libmpathpersist/mpath_persistent_reserve_in.3
+++ b/libmpathpersist/mpath_persistent_reserve_in.3
@@ -6,7 +6,7 @@
 .\" Update the date below if you make any significant change.
 .\" 

 .
-.TH MPATH_PERSISTENT_RESERVE_IN 3 2018-06-15 Linux
+.TH MPATH_PERSISTENT_RESERVE_IN 3 2024-02-09 Linux
 .
 .
 .\" 

diff --git a/libmpathpersist/mpath_persistent_reserve_out.3 
b/libmpathpersist/mpath_persistent_reserve_out.3
index 70e26028..3dbeae1f 100644
--- a/libmpathpersist/mpath_persistent_reserve_out.3
+++ b/libmpathpersist/mpath_persistent_reserve_out.3
@@ -6,7 +6,7 @@
 .\" Update the date below if you make any significant change.
 .\" 

 .
-.TH MPATH_PERSISTENT_RESERVE_OUT 3 2018-06-15 Linux
+.TH MPATH_PERSISTENT_RESERVE_OUT 3 2024-02-09 Linux
 .
 .
 .\" 

diff --git a/multipath/multipath.8.in b/multipath/multipath.8.in
index 348eb220..b88e9a4c 100644
--- a/multipath/multipath.8.in
+++ b/multipath/multipath.8.in
@@ -6,7 +6,7 @@
 .\" Update the date below if you make any significant change.
 .\" 

 .
-.TH MULTIPATH 8 2021-11-12 Linux
+.TH MULTIPATH 8 2023-09-08 Linux
 .
 .
 .\" 

diff --git a/multipath/multipath.conf.5.in b/multipath/multipath.conf.5.in
index c1a19ebb..46d3685a 100644
--- a/multipath/multipath.conf.5.in
+++ b/multipath/multipath.conf.5.in
@@ -6,7 +6,7 @@
 .\" Update the date below if you make any significant change.
 .\" 

 .
-.TH MULTIPATH.CONF 5 2023-06-15 Linux
+.TH MULTIPATH.CONF 5 2024-04-17 Linux
 .
 .
 .\" 

diff --git a/multipathd/multipathd.8.in b/multipathd/multipathd.8.in
index f1cab3ff..12b77156 100644
--- a/multipathd/multipathd.8.in
+++ b/multipathd/multipathd.8.in
@@ -6,7 +6,7 @@
 .\" Update the date below if you make any significant change.
 .\" 

 .
-.TH MULTIPATHD 8 2022-09-03 Linux
+.TH MULTIPATHD 8 2023-12-19 Linux
 .
 .
 .\" 

-- 
2.44.0

[PATCH 2/3] multipath-tools: unify text in multipath.conf.5

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 multipath/multipath.conf.5.in | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/multipath/multipath.conf.5.in b/multipath/multipath.conf.5.in
index b29a75fe..c1a19ebb 100644
--- a/multipath/multipath.conf.5.in
+++ b/multipath/multipath.conf.5.in
@@ -187,7 +187,7 @@ The default is: \fBno\fR
 .
 .TP
 .B multipath_dir
-(Deprecated) This option is not supported anymore, and the value is ignored.
+(Deprecated) This option is not supported anymore, and will be ignored.
 .
 .
 .TP
@@ -277,7 +277,7 @@ The default is: \fBno\fR
 .
 .TP
 .B pg_timeout
-(Deprecated) This option is not supported anymore, and the value is ignored.
+(Deprecated) This option is not supported anymore, and will be ignored.
 .
 .
 .TP
@@ -322,7 +322,7 @@ The default is: \fBID_WWN\fR, for NVMe devices
 .
 .TP
 .B getuid_callout
-(Deprecated) This option is not supported anymore, and the value is ignored.
+(Deprecated) This option is not supported anymore, and will be ignored.
 .
 .
 .TP
@@ -995,7 +995,7 @@ The default is: \fB\fR
 .
 .TP
 .B config_dir
-(Deprecated) This option is not supported anymore, and the value is ignored.
+(Deprecated) This option is not supported anymore, and will be ignored.
 .RS
 .TP
 The compiled-in value is: \fB@CONFIGDIR@\fR
@@ -1295,7 +1295,7 @@ The default is: \fBno\fR
 .
 .TP
 .B disable_changed_wwids
-(Deprecated) This option is not supported anymore, and the value is ignored.
+(Deprecated) This option is not supported anymore, and will be ignored.
 .RE
 .
 .
@@ -1340,7 +1340,7 @@ value in \fI@CONFIGFILE@\fR, run \fBmultipathd 
reconfigure\fR, and use
 \fBmultipathd del path \fR and \fBmultipathd add path \fR to
 delete and re-add the same path device.
 .LP
-The default is: \fBundefined\fR.
+The default is: \fB\fR
 .RE
 .
 .
-- 
2.44.0

[PATCH 1/3] multipath-tools: simplify comment in hwtable

[Xose Vazquez Perez]

Instead of adding the new 5300 model, replace them with wildcards.

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 640bf347..7aac3f37 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -683,8 +683,8 @@ static struct hwentry default_hw[] = {
.pgfailback= -FAILBACK_IMMEDIATE,
},
{
-   // Storwize V5000/V7000 lines / SAN Volume Controller (SVC) / 
Flex System V7000
-   // FlashSystem 
V840/V9000/5000/5100/5200/7200/7300/9100/9200/9200R/9500
+   // Storwize V5000/V7000 lines / SAN Volume Controller (SVC)
+   // Flex System V7000 / FlashSystem V840/V9000 and 5x00/7x00/9x00
.vendor= "IBM",
.product   = "^2145",
.no_path_retry = NO_PATH_RETRY_QUEUE,
-- 
2.44.0

Re: Fedora 40 apache now giving errors

[Xose Vazquez Perez]

Steven A. Falco wrote:


I upgraded to F40, and suddenly an apache cgi script that was working perfectly 
in \
F39 (and earlier) is giving me a "Read-only file system" error when trying to 
write \
data into a file.

The directory where the cgi is trying to write is owned by apache:apache, and 
it is \
mode 777.  The file the cgi is trying to write to is also owned by 
apache:apache and \
is mode 666.

If I manually run the cgi (a trivial perl script), it works perfectly, but 
apache \
gives the "Read-only file system" error.  Apache can read the file fine, it 
just \
cannot write to it.

I also tried having the cgi simply touch a file in /tmp, and that fails too.

Any suggestions gratefully accepted.


# mkdir /etc/systemd/system/httpd.service.d/

# vi /etc/systemd/system/httpd.service.d/override.conf
[Service]
ProtectHome=false

# systemctl daemon-reload
# systemctl restart httpd.service
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Re: [PATCH] multipath-tools: update no_path_retry value for IBM/2145

[Xose Vazquez Perez]

On 8/26/21 8:47 AM, Martin Wilck wrote:
   ^^^
It is never too late!


On Thu, 2021-08-26 at 00:24 +0200, Xose Vazquez Perez wrote:

Based on current configs:
https://www.ibm.com/docs/en/flashsystem-9x00/8.4.x?topic=system-settings-linux-hosts

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
  libmultipath/hwtable.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 2a896440..58554cbb 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -662,7 +662,7 @@ static struct hwentry default_hw[] = {
 /* Storwize family / SAN Volume Controller / Flex
System V7000 / FlashSystem V840/V9000/9100 */
 .vendor    = "IBM",
 .product   = "^2145",
-   .no_path_retry = NO_PATH_RETRY_QUEUE,
+   .no_path_retry = 5,
 .pgpolicy  = GROUP_BY_PRIO,
 .pgfailback    = -FAILBACK_IMMEDIATE,
 .prio_name = PRIO_ALUA,


Ref: https://github.com/opensvc/multipath-tools/issues/6

The question is on which basis IBM came up with this recommendation.
5 (aka 25s) is a rather low value. Some users may encounter unpleasant
surprises if we change the default this way, as it used to be infinite
before.

Using 5, the IBS 2145 would have the 2nd-lowest default in hwtable.c
after Dell PowerStore (3). Symmetrix has 6; all other arrays default to
10 or higher, many default to "queue".

Observing that the above is the documentation for the *Flashsystem*
9200,  I consider it likely that the value ".no_path_retry = 5" would
apply to flash-based IBM storage products, but not to the older
products such as the V7000, which unfortunately use the same device ID.

It'd be helpful if someone from IBM could jump in here...

Pondering the pros and cons, I vote for keeping the current defaults
for now.

Martin


Some history:

first commit 3eb8c380a :
   {
   /* IBM SAN Volume Controller */
   .vendor= "IBM",
   .product   = "2145",
   .getuid= DEFAULT_GETUID,
   .getprio   = "mpath_prio_alua /dev/%n",
   .features  = "1 queue_if_no_path",
   .hwhandler = DEFAULT_HWHANDLER,
   .selector  = DEFAULT_SELECTOR,
   .pgpolicy  = GROUP_BY_PRIO,
   .pgfailback= -FAILBACK_IMMEDIATE,
   .rr_weight = RR_WEIGHT_NONE,
   .no_path_retry = NO_PATH_RETRY_UNDEF,
   .minio = DEFAULT_MINIO,
   .checker_name  = TUR,
   },

NO_PATH_RETRY_UNDEF was removed in b7c3cf014 because it was the default value,
and later "1 queue_if_no_path" was replaced by NO_PATH_RETRY_QUEUE in 87ea76f99

IBM docs recommends:
no_path_retry 5 # or no_path_retry "fail" for some current linux distros

IBM Storage FlashSystem 5200, 5000, 5100, Storwize V5100 and V5000E:
https://www.ibm.com/docs/en/flashsystem-5x00/8.6.x?topic=system-settings-linux-hosts

IBM Storage FlashSystem 7300, 7200 and Storwize V7000:
https://www.ibm.com/docs/en/flashsystem-7x00/8.6.x?topic=system-settings-linux-hosts

IBM FlashSystem V9000:
https://www.ibm.com/docs/en/flashsystem-v9000/8.3.x?topic=system-settings-linux-hosts

IBM Storage FlashSystem 9500, 9200 and 9100:
https://www.ibm.com/docs/en/flashsystem-9x00/8.6.x?topic=system-settings-linux-hosts

Therefore, we should change this value.

[PATCH] multipath-tools: remove extra hyphen from CFLAGS std option

[Xose Vazquez Perez]

https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html#index-std-1

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.inc b/Makefile.inc
index 06bdd5ee..e59425d3 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -104,7 +104,7 @@ CPPFLAGS:= $(FORTIFY_OPT) $(CPPFLAGS) $(D_URCU_VERSION) 
\
   -DRUNTIME_DIR=\"$(runtimedir)\" 
-DCONFIG_DIR=\"$(configdir)\" \
   -DDEFAULT_CONFIGFILE=\"$(configfile)\" 
-DSTATE_DIR=\"$(statedir)\" \
   -DEXTRAVERSION=\"$(EXTRAVERSION)\" -MMD -MP
-CFLAGS := --std=gnu99 $(CFLAGS) $(OPTFLAGS) $(WARNFLAGS) -pipe
+CFLAGS := -std=gnu99 $(CFLAGS) $(OPTFLAGS) $(WARNFLAGS) -pipe
 BIN_CFLAGS := -fPIE -DPIE
 LIB_CFLAGS := -fPIC
 SHARED_FLAGS   := -shared
-- 
2.43.0

[PATCH] multipath-tools: fix an assignment ambiguity

[Xose Vazquez Perez]

spotted by indent:
./kpartx/gpt.c:623: Warning:old style assignment ambiguity in "=-". Assuming "= 
-"

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 kpartx/gpt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kpartx/gpt.c b/kpartx/gpt.c
index 47d8743e..fbf6ae22 100644
--- a/kpartx/gpt.c
+++ b/kpartx/gpt.c
@@ -606,7 +606,7 @@ read_gpt_pt (int fd, __attribute__((unused)) struct slice 
all,
gpt_entry *ptes = NULL;
unsigned int i;
int n = 0;
-   int last_used_index=-1;
+   int last_used_index = -1;
int sector_size_mul = get_sector_size(fd)/512;
 
if (!find_valid_gpt (fd, , ) || !gpt || !ptes) {
-- 
2.43.0

[PATCH] multipath-tools: update ml

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libdmmp/docs/man/libdmmp.h.3 | 2 +-
 libmultipath/hwtable.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libdmmp/docs/man/libdmmp.h.3 b/libdmmp/docs/man/libdmmp.h.3
index 45d5be3e..7c57041d 100644
--- a/libdmmp/docs/man/libdmmp.h.3
+++ b/libdmmp/docs/man/libdmmp.h.3
@@ -110,4 +110,4 @@ below in case you want to create your own log handler.
 GPLv2+
 
 .SH "BUG"
-Please report bug to 
+Please report bug to 
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index ae6aac79..808af544 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -11,7 +11,7 @@
 
 /*
  * Tuning suggestions on these parameters should go to
- * dm-de...@redhat.com (subscribers-only, see README)
+ *  (see README.md)
  *
  * You are welcome to claim maintainership over a controller
  * family. Please mail the currently enlisted maintainer and
-- 
2.43.0

[dm-devel] [PATCH] multipath-tools: fix spelling

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 README.md | 4 ++--
 multipath/multipath.conf.5.in | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 679e55bf..524c9fb1 100644
--- a/README.md
+++ b/README.md
@@ -92,7 +92,7 @@ The following variables can be passed to the `make` command 
line:
The default is `$(prefix)/$(LIB)/multipath`, where `$(LIB)` is `lib64` on
systems that have `/lib64`, and `lib` otherwise.
  * `configfile="/some/path`": The path to the main configuration file.
-The defalt is `$(etc_prefix)/etc/multipath.conf`.
+The default is `$(etc_prefix)/etc/multipath.conf`.
  * `configdir="/some/path"` : directory to search for additional configuration 
files.
 This used to be the run-time option `config_dir` in earlier versions.
The default is `$(etc_prefix)/etc/multipath/conf.d`.
@@ -141,7 +141,7 @@ The following variables can be passed to the `make` command 
line:
found on the build system, and `/lib` otherwise.

 The options `configdir`, `plugindir`, `configfile`, and `statedir` above can
-be used for setting indvidual paths where the `prefix` variables don't provide
+be used for setting individual paths where the `prefix` variables don't provide
 sufficient control. See `Makefile.inc` for even more fine-grained control.
 
 [^systemd]: Some systemd installations use separate `prefix` and `rootprefix`. 
diff --git a/multipath/multipath.conf.5.in b/multipath/multipath.conf.5.in
index d320a88f..226d0019 100644
--- a/multipath/multipath.conf.5.in
+++ b/multipath/multipath.conf.5.in
@@ -36,7 +36,7 @@ Files ending in \fI.conf\fR in this directory are read
 in alphabetical order, after reading \fI@CONFIGFILE@\fR.
 They use the same syntax as \fI@CONFIGFILE@\fR itself,
 and support all sections and keywords. If a keyword occurs in the same section
-in multiple files, the last occurence will take precedence over all others.
+in multiple files, the last occurrence will take precedence over all others.
 .
 .
 .\" 

-- 
2.41.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH RFC] multipath-tools: treat disable_changed_wwids like other deprecated keywords

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/dict.c | 27 ++-
 1 file changed, 6 insertions(+), 21 deletions(-)

diff --git a/libmultipath/dict.c b/libmultipath/dict.c
index 6b3e04a3..f81c84aa 100644
--- a/libmultipath/dict.c
+++ b/libmultipath/dict.c
@@ -278,11 +278,6 @@ static int print_str(struct strbuf *buff, const char *ptr)
return ret == -EINVAL ? 0 : ret;
 }
 
-static int print_ignored(struct strbuf *buff)
-{
-   return append_strbuf_quoted(buff, "ignored");
-}
-
 static int print_yes_no(struct strbuf *buff, long v)
 {
return append_strbuf_quoted(buff, v == YN_NO ? "no" : "yes");
@@ -548,7 +543,6 @@ declare_def_snprint(verbosity, print_int)
 declare_def_handler(reassign_maps, set_yes_no)
 declare_def_snprint(reassign_maps, print_yes_no)
 
-declare_deprecated_handler(multipath_dir)
 
 static int def_partition_delim_handler(struct config *conf, vector strvec,
   const char *file, int line_nr)
@@ -918,17 +912,6 @@ declare_hw_handler(skip_kpartx, set_yes_no_undef)
 declare_hw_snprint(skip_kpartx, print_yes_no_undef)
 declare_mp_handler(skip_kpartx, set_yes_no_undef)
 declare_mp_snprint(skip_kpartx, print_yes_no_undef)
-static int def_disable_changed_wwids_handler(struct config *conf, vector 
strvec,
-const char *file, int line_nr)
-{
-   return 0;
-}
-static int snprint_def_disable_changed_wwids(struct config *conf,
-struct strbuf *buff,
-const void *data)
-{
-   return print_ignored(buff);
-}
 
 declare_def_range_handler(remove_retries, 0, INT_MAX)
 declare_def_snprint(remove_retries, print_int)
@@ -950,9 +933,6 @@ declare_def_handler(enable_foreign, set_str)
 declare_def_snprint_defstr(enable_foreign, print_str,
   DEFAULT_ENABLE_FOREIGN)
 
-declare_deprecated_handler(config_dir)
-declare_deprecated_handler(pg_timeout)
-
 #define declare_def_attr_handler(option, function) \
 static int \
 def_ ## option ## _handler (struct config *conf, vector strvec,
\
@@ -2076,7 +2056,12 @@ snprint_deprecated (struct config *conf, struct strbuf 
*buff, const void * data)
return 0;
 }
 
+// Deprecated keywords
+declare_deprecated_handler(config_dir)
+declare_deprecated_handler(disable_changed_wwids)
 declare_deprecated_handler(getuid_callout)
+declare_deprecated_handler(multipath_dir)
+declare_deprecated_handler(pg_timeout)
 
 /*
  * If you add or remove a keyword also update multipath/multipath.conf.5
@@ -2151,7 +2136,7 @@ init_keywords(vector keywords)
install_keyword("retrigger_delay", _retrigger_delay_handler, 
_def_retrigger_delay);
install_keyword("missing_uev_wait_timeout", 
_uev_wait_timeout_handler, _def_uev_wait_timeout);
install_keyword("skip_kpartx", _skip_kpartx_handler, 
_def_skip_kpartx);
-   install_keyword("disable_changed_wwids", 
_disable_changed_wwids_handler, _def_disable_changed_wwids);
+   install_keyword("disable_changed_wwids", 
_disable_changed_wwids_handler, _deprecated);
install_keyword("remove_retries", _remove_retries_handler, 
_def_remove_retries);
install_keyword("max_sectors_kb", _max_sectors_kb_handler, 
_def_max_sectors_kb);
install_keyword("ghost_delay", _ghost_delay_handler, 
_def_ghost_delay);
-- 
2.41.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: fix docs

[Xose Vazquez Perez]

Mainly; add multipathc info, and info to check man pages  

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 README.md  | 1 +
 kpartx/kpartx.8| 5 +++--
 libmpathpersist/mpath_persistent_reserve_in.3  | 5 +++--
 libmpathpersist/mpath_persistent_reserve_out.3 | 5 +++--
 mpathpersist/mpathpersist.8| 5 +++--
 multipath/multipath.8  | 5 +++--
 multipath/multipath.conf.5 | 5 +++--
 multipathd/multipathc.8| 5 +++--
 multipathd/multipathd.8| 3 ++-
 9 files changed, 24 insertions(+), 15 deletions(-)

diff --git a/README.md b/README.md
index 5e04f5c3..a7f994ae 100644
--- a/README.md
+++ b/README.md
@@ -8,6 +8,7 @@ https://github.com/opensvc/multipath-tools
 This package provides the following binaries to drive the Device Mapper 
multipathing driver:
 
 * multipath - Device mapper target autoconfig.
+* multipathc - Interactive client for multipathd.
 * multipathd - Multipath daemon.
 * mpathpersist - Manages SCSI persistent reservations on dm multipath devices.
 * kpartx - Create device maps from partition tables.
diff --git a/kpartx/kpartx.8 b/kpartx/kpartx.8
index 2b144a7f..ef8051a5 100644
--- a/kpartx/kpartx.8
+++ b/kpartx/kpartx.8
@@ -1,11 +1,12 @@
 .\" 

-.\" Update the date below if you make any significant change.
 .\" Make sure there are no errors with:
 .\" groff -z -wall -b -e -t kpartx/kpartx.8
+.\" man --warnings -E UTF-8 -l -Tutf8 -Z  kpartx/kpartx.8 > /dev/null
 .\"
+.\" Update the date below if you make any significant change.
 .\" 

 .
-.TH KPARTX 8 2019-04-27 "Linux"
+.TH KPARTX 8 2019-04-27 Linux
 .
 .
 .\" 

diff --git a/libmpathpersist/mpath_persistent_reserve_in.3 
b/libmpathpersist/mpath_persistent_reserve_in.3
index c168cae8..2f9b8f79 100644
--- a/libmpathpersist/mpath_persistent_reserve_in.3
+++ b/libmpathpersist/mpath_persistent_reserve_in.3
@@ -1,11 +1,12 @@
 .\" 

-.\" Update the date below if you make any significant change.
 .\" Make sure there are no errors with:
 .\" groff -z -wall -b -e -t libmpathpersist/mpath_persistent_reserve_in.3
+.\" man --warnings -E UTF-8 -l -Tutf8 -Z 
libmpathpersist/mpath_persistent_reserve_in.3 > /dev/null
 .\"
+.\" Update the date below if you make any significant change.
 .\" 

 .
-.TH MPATH_PERSISTENT_RESERVE_IN 3 2018-06-15 "Linux"
+.TH MPATH_PERSISTENT_RESERVE_IN 3 2018-06-15 Linux
 .
 .
 .\" 

diff --git a/libmpathpersist/mpath_persistent_reserve_out.3 
b/libmpathpersist/mpath_persistent_reserve_out.3
index f20be313..d3204c56 100644
--- a/libmpathpersist/mpath_persistent_reserve_out.3
+++ b/libmpathpersist/mpath_persistent_reserve_out.3
@@ -1,11 +1,12 @@
 .\" 

-.\" Update the date below if you make any significant change.
 .\" Make sure there are no errors with:
 .\" groff -z -wall -b -e -t libmpathpersist/mpath_persistent_reserve_out.3
+.\" man --warnings -E UTF-8 -l -Tutf8 -Z 
libmpathpersist/mpath_persistent_reserve_out.3 > /dev/null
 .\"
+.\" Update the date below if you make any significant change.
 .\" 

 .
-.TH MPATH_PERSISTENT_RESERVE_OUT 3 2018-06-15 "Linux"
+.TH MPATH_PERSISTENT_RESERVE_OUT 3 2018-06-15 Linux
 .
 .
 .\" 

diff --git a/mpathpersist/mpathpersist.8 b/mpathpersist/mpathpersist.8
index d594422e..8d26b37c 100644
--- a/mpathpersist/mpathpersist.8
+++ b/mpathpersist/mpathpersist.8
@@ -1,11 +1,12 @@
 .\" 

-.\" Update the date below if you make any significant change.
 .\" Make sure there are no errors with:
 .\" groff -z -wall -b -e -t mpathpersist/mpathpersist.8
+.\" man --warnings -E UTF-8 -l -Tutf8 -Z mpathpersist/mpathpersist.8 > 
/dev/null
 .\"
+.\" Update the date below if you make any significant change.
 .\" 

 .
-.TH MPATHPERSIST 8 2021-11-12 "Linux"
+.TH MPATHPERSIST 8 2021-11-12 Linux
 .
 .
 .\" 
--

[dm-devel] [PATCH] multipath-tools: fix syntax and spelling errors

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 multipath/multipath.conf.5 | 8 
 multipathd/main.c  | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index 8a0ff0d8..c3a5f02f 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -243,26 +243,26 @@ The default is: \fBfailover\fR
 .
 .TP
 .B detect_pgpolicy
-If set to \fIyes\fR and all path devcices are configured with either the
+If set to \fIyes\fR and all path devices are configured with either the
 \fIalua\fR or \fIsysfs\fR prioritizer, the multipath device will automatically
 use the \fIgroup_by_prio\fR path_grouping_policy. If set to \fIno\fR, the
 path_grouping_policy will be selected as usual.
 .RS
 .TP
-The default is: \fIyes\fR
+The default is: \fByes\fR
 .RE
 .
 .
 .TP
 .B detect_pgpolicy_use_tpg
 If both this and \fIdetect_pgpolicy\fR are set to \fIyes\fR and all path
-devcices are configured with either the \fIalua\fR or \fIsysfs\fR prioritizer,
+devices are configured with either the \fIalua\fR or \fIsysfs\fR prioritizer,
 the multipath device will automatically use the \fIgroup_by_tpg\fR
 path_grouping_policy. If set to \fIno\fR, the path_grouping_policy will be
 selected by the method described for \fIdetect_pgpolicy\fR above.
 .RS
 .TP
-The default is: \fIno\fR
+The default is: \fBno\fR
 .RE
 .
 .
diff --git a/multipathd/main.c b/multipathd/main.c
index 6463d2b7..2e02a548 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -396,7 +396,7 @@ void put_multipath_config(__attribute__((unused)) void *arg)
 }
 
 /*
- * The path group orderings that this function finds acceptible are different
+ * The path group orderings that this function finds acceptable are different
  * from now select_path_group determines the best pathgroup. The idea here is
  * to only trigger a kernel reload when it is obvious that the pathgroups would
  * be out of order, even if all the paths were usable. Thus pathgroups with
-- 
2.41.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: fix spelling

[Xose Vazquez Perez]

libmultipath/structs_vec.c:270: mulitpath ==> multipath
libmultipath/libmultipath.version:36: overriden ==> overridden
libmpathutil/libmpathutil.version:36: overriden ==> overridden

SUMMARY:
mulitpath 1
overriden 2

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmpathutil/libmpathutil.version | 2 +-
 libmultipath/libmultipath.version | 2 +-
 libmultipath/structs_vec.c| 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/libmpathutil/libmpathutil.version 
b/libmpathutil/libmpathutil.version
index dd007be4..68f5ab91 100644
--- a/libmpathutil/libmpathutil.version
+++ b/libmpathutil/libmpathutil.version
@@ -33,7 +33,7 @@
 
 /*
  * Symbols exported by both libmpathutil and libmultipath
- * libmpathutil exports just dummy symbols, intended to be overriden
+ * libmpathutil exports just dummy symbols, intended to be overridden
  * by those in libmultipath.
  * CAUTION - the version in libmpathutil.version and libmultipath.version
  * must be THE SAME, otherwise the overriding will fail!
diff --git a/libmultipath/libmultipath.version 
b/libmultipath/libmultipath.version
index aba1a30e..8fcfd20f 100644
--- a/libmultipath/libmultipath.version
+++ b/libmultipath/libmultipath.version
@@ -33,7 +33,7 @@
 
 /*
  * Symbols exported by both libmpathutil and libmultipath
- * libmpathutil exports just dummy symbols, intended to be overriden
+ * libmpathutil exports just dummy symbols, intended to be overridden
  * by those in libmultipath.
  * CAUTION - the version in libmpathutil.version and libmultipath.version
  * must be THE SAME, otherwise the overriding will fail!
diff --git a/libmultipath/structs_vec.c b/libmultipath/structs_vec.c
index f3fdc5a6..0e8a46e7 100644
--- a/libmultipath/structs_vec.c
+++ b/libmultipath/structs_vec.c
@@ -267,7 +267,7 @@ int adopt_paths(vector pathvec, struct multipath *mpp)
if (mpp->queue_mode == QUEUE_MODE_RQ &&
pp->bus == SYSFS_BUS_NVME &&
pp->sg_id.proto_id == NVME_PROTOCOL_TCP) {
-   condlog(2, "%s: mulitpath device %s created 
with request queue_mode. Unable to add nvme:tcp paths",
+   condlog(2, "%s: multipath device %s created 
with request queue_mode. Unable to add nvme:tcp paths",
pp->dev, mpp->alias);
continue;
}
-- 
2.41.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] multipath-tools: adapt HITACHI/OPEN- config to work with alua and multibus

[Xose Vazquez Perez]

On 5/31/23 17:49, Martin Wilck wrote:


On Wed, 2023-05-31 at 15:57 +0200, Xose Vazquez Perez wrote:

ALUA is needed by Hitachi Global-Active Device (GAD):
https://knowledge.hitachivantara.com/Documents/Management_Software/SVOS/8.1/Global-Active_Device/Overview_of_global-active_device



Thanks, but where exactly did you find this information in the linked
document? I don't see ALUA mentioned. Unfortunately Hitachi chose to
use non-standard terminology... 


No public info, personal e-mail from Matthias:

"We have also a config for ALUA. It is used for hardware copy between two
arrays and the server should only use the local paths:

SLES 12 SP2 ALUA:

device {
   vendor   "HITACHI"
   product  "OPEN-.*"
   features "0"
   path_grouping_policy group_by_prio
   prio alua
   path_selector"round-robin 0"
   rr_weightuniform
   no_path_retry1
   rr_min_io100
   path_checker directio
   failback immediate
 }
"

> Is ALUA always active / supported in these arrays?

Disable by default. And it is only needed with GAD setup:

Array settings:
"ALUA Mode" Enabled
"Path Mode" ALUA
"ALUA Permitted" YES
"ALUA Settable" YES
"Target Port Asymmetric Access State" Active/Optimized

Same case as HUAWEI 
https://github.com/opensvc/multipath-tools/commit/9283fa6663ad908fd0419edcef4795fbbbe9f09d

"no_path_retry 10" comes from: 
https://knowledge.hitachivantara.com/Documents/Management_Software/SVOS/9.8.6/Volume_Management_-_VSP_5000_Series/Host_Attachment/05_Red_Hat_Linux_configuration_and_attachment#Device_Mapper_(DM)_Multipath_configuration.0D.0Afor_Red_Hat_Linux


--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: adapt HITACHI/OPEN- config to work with alua and multibus

[Xose Vazquez Perez]

ALUA is needed by Hitachi Global-Active Device (GAD):
https://knowledge.hitachivantara.com/Documents/Management_Software/SVOS/8.1/Global-Active_Device/Overview_of_global-active_device

Cc: Matthias Rudolph 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 65bca744..a858ffa9 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -485,7 +485,9 @@ static struct hwentry default_hw[] = {
/* USP-V, HUS VM, VSP, VSP G1X00 and VSP GX00 families / HPE XP 
*/
.vendor= "(HITACHI|HP|HPE)",
.product   = "^OPEN-",
-   .pgpolicy  = MULTIBUS,
+   .pgpolicy  = GROUP_BY_PRIO,
+   .pgfailback= -FAILBACK_IMMEDIATE,
+   .no_path_retry = 10,
},
{
/* AMS other than AMS 2000 */
-- 
2.40.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] multipath-tools Makefiles: handle dependency files correctly

[Xose Vazquez Perez]

On 3/23/23 12:53, Martin Wilck wrote:


Xose, Ben,

when this gets a Reviewed-by, I'd prepare a new submission to
Christophe (unless someone objects).


There is a pending Gentoo patch from Sam James:
https://listman.redhat.com/archives/dm-devel/2023-March/053587.html

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] multipath-tools Makefiles: handle dependency files correctly

[Xose Vazquez Perez]

On 3/20/23 16:55, mwi...@suse.com wrote:

From: Martin Wilck 

Some generated .d files were not correctly included, and not
removed with "make dep_clean". Fix it.

Reported-by: Xose Vazquez Perez 
Signed-off-by: Martin Wilck 


Tested-by: Xose Vazquez Perez 


---
  libmultipath/Makefile | 4 ++--
  multipathd/Makefile   | 4 ++--
  2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/libmultipath/Makefile b/libmultipath/Makefile
index 61aa611..85767ab 100644
--- a/libmultipath/Makefile
+++ b/libmultipath/Makefile
@@ -71,7 +71,7 @@ uninstall:
  clean: dep_clean
$(Q)$(RM) core *.a *.o *.so *.so.* *.abi nvme-ioctl.c nvme-ioctl.h 
autoconfig.h $(NV_VERSION_SCRIPT)
  
-include $(wildcard $(OBJS:.o=.d))

+include $(wildcard $(OBJS:.o=.d) $(OBJS-T:.o=.d))
  
  dep_clean:

-   $(Q)$(RM) $(OBJS:.o=.d)
+   $(Q)$(RM) $(OBJS:.o=.d) $(OBJS-T:.o=.d)
diff --git a/multipathd/Makefile b/multipathd/Makefile
index 9d53132..dca8e10 100644
--- a/multipathd/Makefile
+++ b/multipathd/Makefile
@@ -81,7 +81,7 @@ uninstall:
  clean: dep_clean
$(Q)$(RM) core *.o $(EXEC) $(CLI)
  
-include $(wildcard $(OBJS:.o=.d))

+include $(wildcard $(OBJS:.o=.d) $(CLI_OBJS:.o=.d))
  
  dep_clean:

-   $(Q)$(RM) $(OBJS:.o=.d)
+   $(Q)$(RM) $(OBJS:.o=.d) $(CLI_OBJS:.o=.d)


--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: delete multipathd/multipathc.d file when "make clean"

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 multipathd/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/multipathd/Makefile b/multipathd/Makefile
index 9d531329..ba879102 100644
--- a/multipathd/Makefile
+++ b/multipathd/Makefile
@@ -79,7 +79,7 @@ uninstall:
$(Q)$(RM) $(DESTDIR)$(unitdir)/$(EXEC).socket
 
 clean: dep_clean
-   $(Q)$(RM) core *.o $(EXEC) $(CLI)
+   $(Q)$(RM) core *.o $(EXEC) $(CLI) multipathc.d
 
 include $(wildcard $(OBJS:.o=.d))
 
-- 
2.40.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 1/2] multipath.conf(5): remove io-affinity information

[Xose Vazquez Perez]

On 11/30/22 05:56, bmarzins at redhat.com (Benjamin Marzinski) wrote:


The multpath-tools do not support the io-affinity path selector.  We
always add a repeat count as the path argument. The io-affinity selector
doesn't take one. Instead it takes a bitmap of CPUs that a path can run
on. This isn't something that lends itself to the kind of
auto-assembling that multipathd does. But even if we did want to try to
support this path-selector, until we do, we shouldn't be listing it in
the multipath.conf documentation.

Signed-off-by: Benjamin Marzinski 



---
  multipath/multipath.conf.5 | 4 
  1 file changed, 4 deletions(-)

diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index 1fea9d5a..3a45ac89 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -205,10 +205,6 @@ of outstanding I/O to the path and its relative throughput.
  estimation of future service time based on the history of previous I/O 
submitted
  to each path.
  .TP
-.I "io-affinity 0"
-(Since 5.11 kernel) Choose the path for the next bunch of I/O based on a CPU to
-path mapping the user passes in and what CPU we are executing on.
-.TP
  The default is: \fBservice-time 0\fR
  .RE
  .


I think the main, and only?, consumer for this path selector is Exadata.

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: mailing list url was changed

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 README.md  | 2 +-
 libmultipath/propsel.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index fb118822..5e04f5c3 100644
--- a/README.md
+++ b/README.md
@@ -172,7 +172,7 @@ Mailing list
 
 
 (subscribers-only)
-To subscribe and archives: https://www.redhat.com/mailman/listinfo/dm-devel
+To subscribe and archives: https://listman.redhat.com/mailman/listinfo/dm-devel
 Searchable: https://marc.info/?l=dm-devel
 
 
diff --git a/libmultipath/propsel.c b/libmultipath/propsel.c
index cd3d74e1..a25cc921 100644
--- a/libmultipath/propsel.c
+++ b/libmultipath/propsel.c
@@ -574,7 +574,7 @@ out:
  * Using the sysfs priority checker defeats this purpose.
  *
  * Moreover, NetApp would also prefer the RDAC checker over ALUA.
- * (https://www.redhat.com/archives/dm-devel/2017-September/msg00326.html)
+ * (https://listman.redhat.com/archives/dm-devel/2017-September/msg00326.html)
  */
 static int
 check_rdac(struct path * pp)
-- 
2.38.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 2/2] multipath.conf(5): improve documentation of dev_loss_tmo

[Xose Vazquez Perez]

On 12/3/22 01:02, Martin Wilck wrote:


Funny, Ben never told me there was a conflicting option name in RHEL.
I guess it's too late now, as I said, the upstream option has existed
for 4 years.


Because it was remove in RHEL-8, since multipath-tools were updated to 0.8.4
RHEL-7 uses a very old code base(0.4.9) with a lot of patches(273)

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 2/2] multipath.conf(5): improve documentation of dev_loss_tmo

[Xose Vazquez Perez]

On 12/3/22 00:50, Martin Wilck wrote:


On Fri, 2022-12-02 at 17:44 -0600, Roger Heflin wrote:

Thanks.

The older distribution I checked has this for -T
      -T tm:valid
               check if tm matches the multipathd configuration
timestamp value from /run/multipathd/timestamp If so, return success
if valid is 1. Otherwise, return failure. If the timestamp doesn't
match continue with multipath execution.  This option is designed to
be used with -c by the udev rules.


Strange, I can't find this anywhere in the sources I know.
What distro is this? "multipath -T" in the sense I described has
existed since 0.7.7, so for more than 4 years.


RH: 
https://src.fedoraproject.org/rpms/device-mapper-multipath/blob/6738b34a0b0aabf1bc8c15d540bafa29ca99c58f/f/0158-RHBZ-1318581-timestamp-doc-fix.patch

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH v2] multipath.conf(5): improve documentation of dev_loss_tmo

[Xose Vazquez Perez]

From: Martin Wilck 

The statement that the default is 600 is wrong in most cases.
Improve the description of the default and the dependency of this
parameter on other parameters.

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Martin Wilck 
Reviewed-by: Xose Vazquez Perez 
---
v2: unchanged text, just move "default value" to bottom

---
 multipath/multipath.conf.5 | 39 ++
 1 file changed, 27 insertions(+), 12 deletions(-)

diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index bd7d7788..76a6fb35 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -707,18 +707,33 @@ The default is: \fB5\fR
 .
 .TP
 .B dev_loss_tmo
-Specify the number of seconds the SCSI layer will wait after a problem has
-been detected on a FC remote port before removing it from the system. This
-can be set to "infinity" which sets it to the max value of 2147483647
-seconds, or 68 years. It will be automatically adjusted to the overall
-retry interval \fIno_path_retry\fR * \fIpolling_interval\fR
-if a number of retries is given with \fIno_path_retry\fR and the
-overall retry interval is longer than the specified \fIdev_loss_tmo\fR value.
-The Linux kernel will cap this value to \fI600\fR if \fIfast_io_fail_tmo\fR
-is not set. See KNOWN ISSUES.
-.RS
-.TP
-The default is: \fB600\fR
+Specify the number of seconds the SCSI layer will wait after a connection loss 
has
+been detected on a remote port before removing it from the system. This
+can be set to "infinity", which effectively means 136 years (2^32-1 seconds).
+This parameter is only applied to Fibre Channel and SAS devices.
+.RS
+.LP
+The value of \fIdev_loss_tmo\fR is restricted by other settings.
+If \fIfast_io_fail_tmo\fR is set to a positive value, \fBmultipathd\fR
+will make sure that the value of \fIdev_loss_tmo\fR is larger than
+\fIno_path_retry\fR * \fIpolling_interval\fR.
+If \fIfast_io_fail_tmo\fR is not set, the kernel limits the \fIdev_loss_tmo\fR
+value to 600 seconds.
+In this case, the user has to make sure that \fIno_path_retry\fR is smaller
+than \fIdev_loss_tmo / polling_interval\fR. In particular,
+\fIno_path_retry\fR must not be set to \(dq\fIqueue\fR\(dq. See KNOWN ISSUES.
+.LP
+When path devices reappear after a connection loss, it is much easier for
+the kernel to simply reactivate an inactive device than to re-add
+a previously deleted one. It is therefore recommended to set
+\fIdev_loss_tmo\fR to a large value within the restrictions mentioned above.
+.LP
+Fibre Channel and SAS devices have hardware-dependent defaults, which are left
+unchanged if \fIdev_loss_tmo\fR is not specified. For a few storage arrays,
+the multipath-tools built-in settings override the default. Run \fImultipath 
-T\fR
+to see the settings for your device.
+.TP
+The default is: \fB\fR
 .RE
 .
 .
-- 
2.38.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 2/2] multipath.conf(5): improve documentation of dev_loss_tmo

[Xose Vazquez Perez]

On 12/1/22 11:32, mwi...@suse.com wrote:


From: Martin Wilck 

The statement that the default is 600 is wrong in most cases.
Improve the description of the default and the dependency of this
parameter on other parameters.


I did change this patch to move "default value" to bottom.

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH v2] multipath-tools: multipath.conf man page housekeeping

[Xose Vazquez Perez]

Mark deprecated options as (Deprecated), and standardize the description
Document pg_timeout
Default value of "features" is "0"
directio is also an alternative to readsector0

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
v2: revert wrong FPIN info

---
 multipath/multipath.conf.5 | 32 ++--
 1 file changed, 18 insertions(+), 14 deletions(-)

diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index 3967db9b..bd7d7788 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -178,7 +178,7 @@ The default is: \fBno\fR
 .
 .TP
 .B multipath_dir
-This option is not supported any more. The value is ignored.
+(Deprecated) This option is not supported any more, and the value is ignored.
 .
 .
 .TP
@@ -238,6 +238,11 @@ The default is: \fBfailover\fR
 .
 .
 .TP
+.B pg_timeout
+(Deprecated) This option is not supported any more, and the value is ignored.
+.
+.
+.TP
 .B uid_attrs
 .
 Setting this option activates \fBmerging uevents\fR by WWID, which may improve
@@ -279,7 +284,7 @@ The default is: \fBID_WWN\fR, for NVMe devices
 .
 .TP
 .B getuid_callout
-This option is not supported any more. The value is ignored.
+(Deprecated) This option is not supported any more, and the value is ignored.
 .
 .
 .TP
@@ -463,7 +468,7 @@ cannot be changed. \fInvme:tcp\fR paths are only supported 
in multipath
 devices with queue_mode set to \fIbio\fR. multipath will automatically
 set this when creating a device with \fInvme:tcp\fR paths.
 .TP
-The default is: \fB\fR
+The default is: \fB0\fR
 .RE
 .
 .
@@ -479,7 +484,7 @@ second, until \fIchecker_timeout\fR seconds have elapsed. 
Possible values are:
 .TP 12
 .I readsector0
 (Deprecated) Read the first sector of the device. This checker is being
-deprecated, please use \fItur\fR instead.
+deprecated, please use \fItur\fR or \fIdirectio\fR instead.
 .TP
 .I tur
 Issue a \fITEST UNIT READY\fR command to the device.
@@ -551,7 +556,7 @@ The default is: \fBmanual\fR
 .
 .
 .TP
-.B  rr_min_io
+.B rr_min_io
 Number of I/O requests to route to a path before switching to the next in the
 same path group. This is only for \fIBlock I/O\fR(BIO) based multipath and
 only apply to \fIround-robin\fR path_selector.
@@ -735,7 +740,7 @@ The default is: \fB\fR
 .
 .TP
 .B bindings_file
-This option is deprecated, and will be removed in a future release.
+(Deprecated) This option is deprecated, and will be removed in a future 
release.
 The full pathname of the binding file to be used when the user_friendly_names
 option is set.
 .RS
@@ -746,7 +751,7 @@ The default is: \fB/etc/multipath/bindings\fR
 .
 .TP
 .B wwids_file
-This option is deprecated, and will be removed in a future release.
+(Deprecated) This option is deprecated, and will be removed in a future 
release.
 The full pathname of the WWIDs file, which is used by multipath to keep track
 of the WWIDs for LUNs it has created multipath devices on in the past.
 .RS
@@ -757,7 +762,7 @@ The default is: \fB/etc/multipath/wwids\fR
 .
 .TP
 .B prkeys_file
-This option is deprecated, and will be removed in a future release.
+(Deprecated) This option is deprecated, and will be removed in a future 
release.
 The full pathname of the prkeys file, which is used by multipathd to keep
 track of the persistent reservation key used for a specific WWID, when
 \fIreservation_key\fR is set to \fBfile\fR.
@@ -929,7 +934,7 @@ The default is: \fB\fR
 .
 .TP
 .B config_dir
-This option is not supported any more. The value is ignored.
+(Deprecated) This option is not supported any more, and the value is ignored.
 .
 .
 .TP
@@ -1042,7 +1047,7 @@ The default is: \fBno\fR
 .
 .TP
 .B delay_watch_checks
-This option is \fBdeprecated\fR, and mapped to \fIsan_path_err_forget_rate\fR.
+(Deprecated) This option is \fBdeprecated\fR, and mapped to 
\fIsan_path_err_forget_rate\fR.
 If this is set to a value greater than 0 and no \fIsan_path_err\fR options
 are set, \fIsan_path_err_forget_rate\fR will be set to the value of
 \fIdelay_watch_checks\fR and \fIsan_path_err_threshold\fR will be set to 1.
@@ -1056,7 +1061,7 @@ The default is: \fBno\fR
 .
 .TP
 .B delay_wait_checks
-This option is \fBdeprecated\fR, and mapped to 
\fIsan_path_err_recovery_time\fR.
+(Deprecated) This option is \fBdeprecated\fR, and mapped to 
\fIsan_path_err_recovery_time\fR.
 If this is set to a value greater than 0 and no \fIsan_path_err\fR options
 are set, \fIsan_path_err_recovery_time\fR will be set to the value of
 \fIdelay_wait_checks\fR times \fImax_polling_interval\fR. This will give
@@ -1223,8 +1228,7 @@ The default is: \fBno\fR
 .
 .TP
 .B disable_changed_wwids
-This option is deprecated and ignored. If the WWID of a path suddenly changes,
-multipathd handles it as if it was removed and then added again.
+(Deprecated) This option is not supported any more, and the value is ignored.
 .RE
 .
 .
@@ -1845,7 +1849,7 @@ normal pathgroup. The 

[dm-devel] [PATCH] multipath-tools: add EF to rdac info

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/propsel.c | 2 +-
 multipath/multipath.conf.5 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libmultipath/propsel.c b/libmultipath/propsel.c
index d1d5cc25..cd3d74e1 100644
--- a/libmultipath/propsel.c
+++ b/libmultipath/propsel.c
@@ -568,7 +568,7 @@ out:
 }
 
 /*
- * Current RDAC (NetApp E-Series) firmware relies
+ * Current RDAC (NetApp E/EF Series) firmware relies
  * on periodic REPORT TARGET PORT GROUPS for
  * internal load balancing.
  * Using the sysfs priority checker defeats this purpose.
diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index 063b05a7..a7796c65 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -364,7 +364,7 @@ prio_args keyword.
 .PP
 The default depends on the \fBdetect_prio\fR setting: If \fBdetect_prio\fR is
 \fByes\fR (default), the default priority algorithm is \fBsysfs\fR (except for
-NetAPP E-Series, where it is \fBalua\fR). If \fBdetect_prio\fR is
+NetAPP E/EF Series, where it is \fBalua\fR). If \fBdetect_prio\fR is
 \fBno\fR, the default priority algorithm is \fBconst\fR.
 .RE
 .
-- 
2.38.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: multipath.conf man page housekeeping

[Xose Vazquez Perez]

Mark deprecated options as (Deprecated), and standardize the description
Document pg_timeout
Default value of "features" is "0"
directio is also an alternative to readsector0

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 multipath/multipath.conf.5 | 41 --
 1 file changed, 22 insertions(+), 19 deletions(-)

diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index 8e28ba12..063b05a7 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -178,7 +178,7 @@ The default is: \fBno\fR
 .
 .TP
 .B multipath_dir
-This option is not supported any more. The value is ignored.
+(Deprecated) This option is not supported any more, and the value is ignored.
 .
 .
 .TP
@@ -242,6 +242,11 @@ The default is: \fBfailover\fR
 .
 .
 .TP
+.B pg_timeout
+(Deprecated) This option is not supported any more, and the value is ignored.
+.
+.
+.TP
 .B uid_attrs
 .
 Setting this option activates \fBmerging uevents\fR by WWID, which may improve
@@ -283,7 +288,7 @@ The default is: \fBID_WWN\fR, for NVMe devices
 .
 .TP
 .B getuid_callout
-This option is not supported any more. The value is ignored.
+(Deprecated) This option is not supported any more, and the value is ignored.
 .
 .
 .TP
@@ -468,7 +473,7 @@ cannot be changed. \fInvme:tcp\fR paths are only supported 
in multipath
 devices with queue_mode set to \fIbio\fR. multipath will automatically
 set this when creating a device with \fInvme:tcp\fR paths.
 .TP
-The default is: \fB\fR
+The default is: \fB0\fR
 .RE
 .
 .
@@ -484,7 +489,7 @@ second, until \fIchecker_timeout\fR seconds have elapsed. 
Possible values are:
 .TP 12
 .I readsector0
 (Deprecated) Read the first sector of the device. This checker is being
-deprecated, please use \fItur\fR instead.
+deprecated, please use \fItur\fR or \fIdirectio\fR instead.
 .TP
 .I tur
 Issue a \fITEST UNIT READY\fR command to the device.
@@ -556,7 +561,7 @@ The default is: \fBmanual\fR
 .
 .
 .TP
-.B  rr_min_io
+.B rr_min_io
 Number of I/O requests to route to a path before switching to the next in the
 same path group. This is only for \fIBlock I/O\fR(BIO) based multipath and
 only apply to \fIround-robin\fR path_selector.
@@ -740,7 +745,7 @@ The default is: \fB\fR
 .
 .TP
 .B bindings_file
-This option is deprecated, and will be removed in a future release.
+(Deprecated) This option is deprecated, and will be removed in a future 
release.
 The full pathname of the binding file to be used when the user_friendly_names
 option is set.
 .RS
@@ -751,7 +756,7 @@ The default is: \fB/etc/multipath/bindings\fR
 .
 .TP
 .B wwids_file
-This option is deprecated, and will be removed in a future release.
+(Deprecated) This option is deprecated, and will be removed in a future 
release.
 The full pathname of the WWIDs file, which is used by multipath to keep track
 of the WWIDs for LUNs it has created multipath devices on in the past.
 .RS
@@ -762,7 +767,7 @@ The default is: \fB/etc/multipath/wwids\fR
 .
 .TP
 .B prkeys_file
-This option is deprecated, and will be removed in a future release.
+(Deprecated) This option is deprecated, and will be removed in a future 
release.
 The full pathname of the prkeys file, which is used by multipathd to keep
 track of the persistent reservation key used for a specific WWID, when
 \fIreservation_key\fR is set to \fBfile\fR.
@@ -934,7 +939,7 @@ The default is: \fB\fR
 .
 .TP
 .B config_dir
-This option is not supported any more. The value is ignored.
+(Deprecated) This option is not supported any more, and the value is ignored.
 .
 .
 .TP
@@ -1047,7 +1052,7 @@ The default is: \fBno\fR
 .
 .TP
 .B delay_watch_checks
-This option is \fBdeprecated\fR, and mapped to \fIsan_path_err_forget_rate\fR.
+(Deprecated) This option is \fBdeprecated\fR, and mapped to 
\fIsan_path_err_forget_rate\fR.
 If this is set to a value greater than 0 and no \fIsan_path_err\fR options
 are set, \fIsan_path_err_forget_rate\fR will be set to the value of
 \fIdelay_watch_checks\fR and \fIsan_path_err_threshold\fR will be set to 1.
@@ -1061,7 +1066,7 @@ The default is: \fBno\fR
 .
 .TP
 .B delay_wait_checks
-This option is \fBdeprecated\fR, and mapped to 
\fIsan_path_err_recovery_time\fR.
+(Deprecated) This option is \fBdeprecated\fR, and mapped to 
\fIsan_path_err_recovery_time\fR.
 If this is set to a value greater than 0 and no \fIsan_path_err\fR options
 are set, \fIsan_path_err_recovery_time\fR will be set to the value of
 \fIdelay_wait_checks\fR times \fImax_polling_interval\fR. This will give
@@ -1228,8 +1233,7 @@ The default is: \fBno\fR
 .
 .TP
 .B disable_changed_wwids
-This option is deprecated and ignored. If the WWID of a path suddenly changes,
-multipathd handles it as if it was removed and then added again.
+(Deprecated) This option is not supported any more, and the value is ignored.
 .RE
 .
 .
@@ -1848,7 +1852,7 @@ normal pathgroup. The logic of determining \(dq

[dm-devel] [PATCH] multipath-tools: fix c error in install_keyword for deprecated pg_timeout

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/dict.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libmultipath/dict.c b/libmultipath/dict.c
index 6fc77315..97f43387 100644
--- a/libmultipath/dict.c
+++ b/libmultipath/dict.c
@@ -2103,7 +2103,7 @@ init_keywords(vector keywords)
install_keyword("no_path_retry", _no_path_retry_handler, 
_hw_no_path_retry);
install_keyword("rr_min_io", _minio_handler, _hw_minio);
install_keyword("rr_min_io_rq", _minio_rq_handler, 
_hw_minio_rq);
-   install_keyword("pg_timeout", _handler, _deprecated);
+   install_keyword("pg_timeout", _pg_timeout_handler, 
_deprecated);
install_keyword("flush_on_last_del", _flush_on_last_del_handler, 
_hw_flush_on_last_del);
install_keyword("fast_io_fail_tmo", _fast_io_fail_handler, 
_hw_fast_io_fail);
install_keyword("dev_loss_tmo", _dev_loss_handler, 
_hw_dev_loss);
@@ -2192,7 +2192,7 @@ init_keywords(vector keywords)
install_keyword("no_path_retry", _no_path_retry_handler, 
_mp_no_path_retry);
install_keyword("rr_min_io", _minio_handler, _mp_minio);
install_keyword("rr_min_io_rq", _minio_rq_handler, 
_mp_minio_rq);
-   install_keyword("pg_timeout", _handler, _deprecated);
+   install_keyword("pg_timeout", _pg_timeout_handler, 
_deprecated);
install_keyword("flush_on_last_del", _flush_on_last_del_handler, 
_mp_flush_on_last_del);
install_keyword("features", _features_handler, _mp_features);
install_keyword("mode", _mode_handler, _mp_mode);
-- 
2.38.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 2/3] multipath-tools: add PowerMax NVMe to hwtable

[Xose Vazquez Perez]

No official config, just a "multipath -ll" output:
https://bugzilla.redhat.com/1686708#c0

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 7ae7dbf8..3c4f866a 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -339,6 +339,12 @@ static struct hwentry default_hw[] = {
.pgpolicy  = MULTIBUS,
.no_path_retry = 6,
},
+   {
+   /* PowerMax NVMe */
+   .vendor= "NVME",
+   .product   = "EMC PowerMax",
+   .no_path_retry = NO_PATH_RETRY_QUEUE,
+   },
{
/* DGC CLARiiON CX/AX / VNX and Unity */
.vendor= "^DGC",
-- 
2.38.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 1/3 v3] multipath-tools: update hwtable text/info/comments

[Xose Vazquez Perez]

Add Alletra 5000, FAS/AFF and E/EF Series info.
Compact some info.
Delete trivial/redundant comments.
Reformat LIO.

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 21 ++---
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 2085aba5..7ae7dbf8 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -232,7 +232,7 @@ static struct hwentry default_hw[] = {
.prio_name = PRIO_ALUA,
},
{
-   /* Nimble Storage / HPE Alletra 6000 */
+   /* Nimble Storage / HPE Alletra 5000/6000 */
.vendor= "Nimble",
.product   = "Server",
.hwhandler = "1 alua",
@@ -367,7 +367,7 @@ static struct hwentry default_hw[] = {
.pgpolicy  = MULTIBUS,
},
{
-   /* SC Series, formerly Compellent */
+   /* SC Series (formerly Compellent) */
.vendor= "COMPELNT",
.product   = "Compellent Vol",
.pgpolicy  = GROUP_BY_PRIO,
@@ -456,6 +456,7 @@ static struct hwentry default_hw[] = {
{
/*
 * ETERNUS AB/HB
+*
 * Maintainer: NetApp RDAC team 

 */
.vendor= "FUJITSU",
@@ -672,7 +673,7 @@ static struct hwentry default_hw[] = {
.pgfailback= -FAILBACK_IMMEDIATE,
},
{
-   // Storwize V5000 and V7000 lines / SAN Volume Controller (SVC) 
/ Flex System V7000 /
+   // Storwize V5000/V7000 lines / SAN Volume Controller (SVC) / 
Flex System V7000
// FlashSystem 
V840/V9000/5000/5100/5200/7200/7300/9100/9200/9200R/9500
.vendor= "IBM",
.product   = "^2145",
@@ -808,7 +809,7 @@ static struct hwentry default_hw[] = {
 */
{
/*
-* ONTAP family
+* ONTAP FAS/AFF Series
 *
 * Maintainer: Martin George 
 */
@@ -825,7 +826,7 @@ static struct hwentry default_hw[] = {
},
{
/*
-* SANtricity(RDAC) family
+* SANtricity(RDAC) E/EF Series
 *
 * Maintainer: NetApp RDAC team 

 */
@@ -1049,12 +1050,12 @@ static struct hwentry default_hw[] = {
.prio_name = PRIO_ALUA,
},
/*
-* Linux-IO Target
+* Linux
 */
{
-   /* Linux-IO Target */
+   /* Linux-IO (LIO) Target */
.vendor= "(LIO-ORG|SUSE)",
-   .product   = ".",
+   .product   = ".*",
.hwhandler = "1 alua",
.pgpolicy  = GROUP_BY_PRIO,
.pgfailback= -FAILBACK_IMMEDIATE,
@@ -1107,8 +1108,6 @@ static struct hwentry default_hw[] = {
 */
{
/* OceanStor V3-V6 */
-   // This config works with multibus and ALUA
-   // ALUA is required by HyperMetro
.vendor= "HUAWEI",
.product   = "XSG1",
.pgpolicy  = GROUP_BY_PRIO,
@@ -1202,7 +1201,7 @@ static struct hwentry default_hw[] = {
.no_path_retry = 30,
},
{
-   /* 3000 / 6000 Series - ALUA mode */
+   /* 3000 / 6000 Series (ALUA mode) */
.vendor= "VIOLIN",
.product   = "SAN ARRAY ALUA",
.hwhandler = "1 alua",
-- 
2.38.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 3/3] multipath-tools: add more info for NetApp ontap prio

[Xose Vazquez Perez]

and format fixes.

Cc: George Martin 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 README.md  |  2 +-
 multipath/multipath.conf.5 | 10 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/README.md b/README.md
index bbeb44fe..31ddbaba 100644
--- a/README.md
+++ b/README.md
@@ -209,7 +209,7 @@ To enable ALUA, the following options should be changed:
 - LSI/Engenio/NetApp RDAC class, as NetApp SANtricity E/EF Series and 
rebranded arrays:
"Select operating system:" should be changed to "Linux DM-MP (Kernel 3.10 
or later)".
 
-- NetApp ONTAP:
+- NetApp ONTAP FAS/AFF Series:
To check ALUA state: "igroup show -v ", and to enable ALUA:
"igroup set  alua yes".
 
diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index 1fea9d5a..8e28ba12 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -6,7 +6,7 @@
 .\" Update the date below if you make any significant change.
 .\" 

 .
-.TH MULTIPATH.CONF 5 2022-09-09 Linux
+.TH MULTIPATH.CONF 5 2022-10-01 Linux
 .
 .
 .\" 

@@ -315,7 +315,8 @@ accepts the optional prio_arg \fIexclusive_pref_bit\fR.
 .TP
 .I ontap
 (Hardware-dependent)
-Generate the path priority for NetApp ONTAP class, and rebranded arrays.
+Generate the path priority for NetApp ONTAP FAS/AFF Series and rebranded 
arrays,
+with ONTAP native mode(not ALUA).
 .TP
 .I rdac
 (Hardware-dependent)
@@ -1292,8 +1293,6 @@ wwid.
 The default is: \fBno\fR
 .RE
 .
-.
-
 .
 .\" 

 .SH "blacklist and blacklist_exceptions sections"
@@ -1852,7 +1851,7 @@ the logic when to reinstate, differs between the three 
methods.
 This method is \fBdeprecated\fR and mapped to the \(dqsan_path_err\(dq method.
 See the \fIdelay_watch_checks\fR and \fIdelay_wait_checks\fR options above
 for more information.
-
+.
 .TP
 .B \(dqmarginal_path\(dq failure tracking
 If a second failure event (good->bad transition) occurs within
@@ -1924,6 +1923,7 @@ size=167772160 features='n/a' hwhandler='ANA' wp=rw
 The \(dqnvme\(dq foreign library provides support for NVMe native multipathing
 in the kernel. It is part of the standard multipath package.
 .
+.
 .\" 

 .SH "KNOWN ISSUES"
 .\" 

-- 
2.38.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 0/3] update hwtable and multipath.conf man page

[Xose Vazquez Perez]

Xose Vazquez Perez (3):
  multipath-tools: update hwtable text/info/comments
  multipath-tools: add PowerMax NVMe to hwtable
  multipath-tools: add more info for NetApp ontap prio

 README.md  |  2 +-
 libmultipath/hwtable.c | 27 ---
 multipath/multipath.conf.5 | 10 +-
 3 files changed, 22 insertions(+), 17 deletions(-)

Cc: George Martin 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
-- 
2.38.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH v2] multipath-tools: update hwtable text/info/comments

[Xose Vazquez Perez]

add HPE Alletra 5000 info.
compact some info.
delete trivial/redundant comments.

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 14 ++
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 2085aba5..7daf29d8 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -232,7 +232,7 @@ static struct hwentry default_hw[] = {
.prio_name = PRIO_ALUA,
},
{
-   /* Nimble Storage / HPE Alletra 6000 */
+   /* Nimble Storage / HPE Alletra 5000/6000 */
.vendor= "Nimble",
.product   = "Server",
.hwhandler = "1 alua",
@@ -367,7 +367,7 @@ static struct hwentry default_hw[] = {
.pgpolicy  = MULTIBUS,
},
{
-   /* SC Series, formerly Compellent */
+   /* SC Series (formerly Compellent) */
.vendor= "COMPELNT",
.product   = "Compellent Vol",
.pgpolicy  = GROUP_BY_PRIO,
@@ -672,7 +672,7 @@ static struct hwentry default_hw[] = {
.pgfailback= -FAILBACK_IMMEDIATE,
},
{
-   // Storwize V5000 and V7000 lines / SAN Volume Controller (SVC) 
/ Flex System V7000 /
+   // Storwize V5000/V7000 lines / SAN Volume Controller (SVC) / 
Flex System V7000
// FlashSystem 
V840/V9000/5000/5100/5200/7200/7300/9100/9200/9200R/9500
.vendor= "IBM",
.product   = "^2145",
@@ -1049,10 +1049,10 @@ static struct hwentry default_hw[] = {
.prio_name = PRIO_ALUA,
},
/*
-* Linux-IO Target
+* Linux
 */
{
-   /* Linux-IO Target */
+   /* Linux-IO (LIO) Target */
.vendor= "(LIO-ORG|SUSE)",
.product   = ".",
.hwhandler = "1 alua",
@@ -1107,8 +1107,6 @@ static struct hwentry default_hw[] = {
 */
{
/* OceanStor V3-V6 */
-   // This config works with multibus and ALUA
-   // ALUA is required by HyperMetro
.vendor= "HUAWEI",
.product   = "XSG1",
.pgpolicy  = GROUP_BY_PRIO,
@@ -1202,7 +1200,7 @@ static struct hwentry default_hw[] = {
.no_path_retry = 30,
},
{
-   /* 3000 / 6000 Series - ALUA mode */
+   /* 3000 / 6000 Series (ALUA mode) */
.vendor= "VIOLIN",
.product   = "SAN ARRAY ALUA",
.hwhandler = "1 alua",
-- 
2.37.3

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: update hwtable text/info/comments

[Xose Vazquez Perez]

delete attributes from template, outdated and incompleted.
delete trivial/redundant comments.
add HPE Alletra 5000 info.
remove empty lines in comments.
compact some info.

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 66 +++---
 1 file changed, 10 insertions(+), 56 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 2085aba5..d2c92d43 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -33,59 +33,26 @@
 * Copy this TEMPLATE to add new hardware.
 *
 * Keep only mandatory(.vendor and .product) and modified attributes.
-* Attributes with default values must be removed.
+* Attributes with default values must be omitted.
 * .vendor, .product, .revision and .bl_product are POSIX Extended 
regex.
 *
 * COMPANY_NAME
-*
 * Maintainer: NAME 
 */
{
/* Product Name */
.vendor= "VENDOR",
.product   = "PRODUCT",
-   .revision  = "REVISION",
-   .bl_product= "BL_PRODUCT",
-   .pgpolicy  = FAILOVER,
-   .uid_attribute = "ID_SERIAL",
-   .selector  = "service-time 0",
-   .checker_name  = TUR,
-   .alias_prefix  = "mpath",
-   .features  = "0",
-   .hwhandler = "0",
-   .prio_name = PRIO_CONST,
-   .prio_args = "",
-   .pgfailback= -FAILBACK_MANUAL,
-   .rr_weight = RR_WEIGHT_NONE,
-   .no_path_retry = NO_PATH_RETRY_UNDEF,
-   .minio = 1000,
-   .minio_rq  = 1,
-   .flush_on_last_del = FLUSH_DISABLED,
-   .user_friendly_names = USER_FRIENDLY_NAMES_OFF,
-   .fast_io_fail  = 5,
-   .dev_loss  = 600,
-   .retain_hwhandler = RETAIN_HWHANDLER_ON,
-   .detect_prio   = DETECT_PRIO_ON,
-   .detect_checker = DETECT_CHECKER_ON,
-   .deferred_remove = DEFERRED_REMOVE_OFF,
-   .delay_watch_checks = DELAY_CHECKS_OFF,
-   .delay_wait_checks = DELAY_CHECKS_OFF,
-   .skip_kpartx   = SKIP_KPARTX_OFF,
-   .max_sectors_kb = MAX_SECTORS_KB_UNDEF,
-   .ghost_delay   = GHOST_DELAY_OFF,
+   ...
},
 #endif
 
 static struct hwentry default_hw[] = {
/*
 * Generic NVMe devices
-*
-* Due to the parsing logic in find_hwe(), generic entries
-* have to be put on top of this list, and more specific ones
-* below.
 */
{
-   /* Generic NVMe */
+   /* NVMe */
.vendor= "NVM[eE]",
.product   = ".*",
.uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE,
@@ -95,7 +62,6 @@ static struct hwentry default_hw[] = {
},
/*
 * Apple
-*
 * Maintainer: Shyam Sundar 
 */
{
@@ -232,7 +198,7 @@ static struct hwentry default_hw[] = {
.prio_name = PRIO_ALUA,
},
{
-   /* Nimble Storage / HPE Alletra 6000 */
+   /* Nimble Storage / HPE Alletra 5000/6000 */
.vendor= "Nimble",
.product   = "Server",
.hwhandler = "1 alua",
@@ -311,7 +277,6 @@ static struct hwentry default_hw[] = {
{
/*
 * Nexenta COMSTAR
-*
 * Maintainer: Yacine Kheddache 
 */
.vendor= "NEXENTA",
@@ -367,7 +332,7 @@ static struct hwentry default_hw[] = {
.pgpolicy  = MULTIBUS,
},
{
-   /* SC Series, formerly Compellent */
+   /* SC Series (formerly Compellent) */
.vendor= "COMPELNT",
.product   = "Compellent Vol",
.pgpolicy  = GROUP_BY_PRIO,
@@ -471,7 +436,6 @@ static struct hwentry default_hw[] = {
},
/*
 * Hitachi Vantara
-*
 * Maintainer: Matthias Rudolph 
 */
{
@@ -672,7 +636,7 @@ static struct hwentry default_hw[] = {
.pgfailback= -FAILBACK_IMMEDIATE,
},
{
-   // Storwize V5000 and V7000 lines / SAN Volume Controller (SVC) 
/ Flex System V7000 /
+   // Storwize V5000/V7000 lines / SAN Volume Controller (SVC) / 
Flex System V7000
// FlashSystem 
V840/V9000/

[dm-devel] [PATCH] multipath-tools: update man pages with last modification date

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 kpartx/kpartx.8| 2 +-
 libmpathpersist/mpath_persistent_reserve_in.3  | 2 +-
 libmpathpersist/mpath_persistent_reserve_out.3 | 2 +-
 mpathpersist/mpathpersist.8| 2 +-
 multipath/multipath.8  | 2 +-
 multipath/multipath.conf.5 | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/kpartx/kpartx.8 b/kpartx/kpartx.8
index 08bb349b..2b144a7f 100644
--- a/kpartx/kpartx.8
+++ b/kpartx/kpartx.8
@@ -5,7 +5,7 @@
 .\"
 .\" 

 .
-.TH KPARTX 8 2016-10-28 "Linux"
+.TH KPARTX 8 2019-04-27 "Linux"
 .
 .
 .\" 

diff --git a/libmpathpersist/mpath_persistent_reserve_in.3 
b/libmpathpersist/mpath_persistent_reserve_in.3
index 4691bdea..c168cae8 100644
--- a/libmpathpersist/mpath_persistent_reserve_in.3
+++ b/libmpathpersist/mpath_persistent_reserve_in.3
@@ -5,7 +5,7 @@
 .\"
 .\" 

 .
-.TH MPATH_PERSISTENT_RESERVE_IN 3 2016-11-01 "Linux"
+.TH MPATH_PERSISTENT_RESERVE_IN 3 2018-06-15 "Linux"
 .
 .
 .\" 

diff --git a/libmpathpersist/mpath_persistent_reserve_out.3 
b/libmpathpersist/mpath_persistent_reserve_out.3
index 55b00b00..f20be313 100644
--- a/libmpathpersist/mpath_persistent_reserve_out.3
+++ b/libmpathpersist/mpath_persistent_reserve_out.3
@@ -5,7 +5,7 @@
 .\"
 .\" 

 .
-.TH MPATH_PERSISTENT_RESERVE_OUT 3 2016-11-01 "Linux"
+.TH MPATH_PERSISTENT_RESERVE_OUT 3 2018-06-15 "Linux"
 .
 .
 .\" 

diff --git a/mpathpersist/mpathpersist.8 b/mpathpersist/mpathpersist.8
index 7b574592..d594422e 100644
--- a/mpathpersist/mpathpersist.8
+++ b/mpathpersist/mpathpersist.8
@@ -5,7 +5,7 @@
 .\"
 .\" 

 .
-.TH MPATHPERSIST 8 2019-05-27 "Linux"
+.TH MPATHPERSIST 8 2021-11-12 "Linux"
 .
 .
 .\" 

diff --git a/multipath/multipath.8 b/multipath/multipath.8
index 4c7e9885..88149d53 100644
--- a/multipath/multipath.8
+++ b/multipath/multipath.8
@@ -5,7 +5,7 @@
 .\"
 .\" 

 .
-.TH MULTIPATH 8 2018-10-10 "Linux"
+.TH MULTIPATH 8 2021-11-12 "Linux"
 .
 .
 .\" 

diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index 6018fa54..e098d555 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -6,7 +6,7 @@
 .\" Update the date below if you make any significant change.
 .\" 

 .
-.TH MULTIPATH.CONF 5 2021-09-08 Linux
+.TH MULTIPATH.CONF 5 2022-09-09 Linux
 .
 .
 .\" 

-- 
2.37.3

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH v3] multipath-tools: add more info for NetApp RDAC arrays

[Xose Vazquez Perez]

To use ALUA mode:
"Select operating system:" should be changed to "Linux DM-MP (Kernel 3.10 or 
later)".

To use RDAC mode:
"Select operating system:" should be changed to "Linux DM-MP (Kernel 3.9 or 
earlier)".

Info from:
 
https://library.netapp.com/ecmdocs/ECMLP2439710/html/GUID-49E94674-947F-4921-A1D1-CE9B42DCBA39.html
 
https://library.netapp.com/ecmdocs/ECMLP2439710/html/GUID-CA17AE34-F5B2-4FF4-8FD4-4A7AA4238976.html
 
https://library.netapp.com/ecmdocs/ECMLP2439710/html/GUID-3DA657A9-FF4A-4237-90EC-BA8863B7431E.html

Add it to prio and hardware_handler.

Cc: NetApp RDAC team 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
v2: delete "Automatic Load Balancing option" obsolete info
v3: a part of the body wa trimmed by git
---
 README.md  | 2 +-
 multipath/multipath.conf.5 | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index b05b1332..45234dc6 100644
--- a/README.md
+++ b/README.md
@@ -165,7 +165,7 @@ To enable ALUA, the following options should be changed:
"LUN Affinity" and "ALUA" should be changed to "Enable", "Redundancy Type"
must be "Active-Active".
 
-- LSI/Engenio/NetApp RDAC class, as NetApp SANtricity E/EF Series and OEM 
arrays:
+- LSI/Engenio/NetApp RDAC class, as NetApp SANtricity E/EF Series and 
rebranded arrays:
"Select operating system:" should be changed to "Linux DM-MP (Kernel 3.10 
or later)".
 
 - NetApp ONTAP:
diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index acdd1ae6..6018fa54 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -320,7 +320,7 @@ Generate the path priority for NetApp ONTAP class, and 
rebranded arrays.
 .I rdac
 (Hardware-dependent)
 Generate the path priority for LSI/Engenio/NetApp RDAC class as NetApp 
SANtricity
-E/EF Series, and rebranded arrays.
+E/EF Series and rebranded arrays, with "Linux DM-MP (Kernel 3.9 or earlier)" 
option.
 .TP
 .I hp_sw
 (Hardware-dependent)
@@ -1568,7 +1568,7 @@ with Failover Mode 1 (Passive Not Ready(PNR)).
 .I 1 rdac
 (Hardware-dependent)
 Hardware handler for LSI/Engenio/NetApp RDAC class as NetApp SANtricity E/EF
-Series, and rebranded arrays.
+Series and rebranded arrays, with "Linux DM-MP (Kernel 3.9 or earlier)" option.
 .TP
 .I 1 hp_sw
 (Hardware-dependent)
-- 
2.37.3

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH v2] multipath-tools: add more info for NetApp RDAC arrays

[Xose Vazquez Perez]

To use ALUA mode:
"Select operating system:" should be changed to "Linux DM-MP (Kernel 3.10 or 
later)".

To use RDAC mode:
"Select operating system:" should be changed to "Linux DM-MP (Kernel 3.9 or 
earlier)".

Add it to prio and hardware_handler.

Cc: NetApp RDAC team 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
v2: delete "Automatic Load Balancing option" obsolete info
---
 README.md  | 2 +-
 multipath/multipath.conf.5 | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index b05b1332..45234dc6 100644
--- a/README.md
+++ b/README.md
@@ -165,7 +165,7 @@ To enable ALUA, the following options should be changed:
"LUN Affinity" and "ALUA" should be changed to "Enable", "Redundancy Type"
must be "Active-Active".
 
-- LSI/Engenio/NetApp RDAC class, as NetApp SANtricity E/EF Series and OEM 
arrays:
+- LSI/Engenio/NetApp RDAC class, as NetApp SANtricity E/EF Series and 
rebranded arrays:
"Select operating system:" should be changed to "Linux DM-MP (Kernel 3.10 
or later)".
 
 - NetApp ONTAP:
diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index acdd1ae6..6018fa54 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -320,7 +320,7 @@ Generate the path priority for NetApp ONTAP class, and 
rebranded arrays.
 .I rdac
 (Hardware-dependent)
 Generate the path priority for LSI/Engenio/NetApp RDAC class as NetApp 
SANtricity
-E/EF Series, and rebranded arrays.
+E/EF Series and rebranded arrays, with "Linux DM-MP (Kernel 3.9 or earlier)" 
option.
 .TP
 .I hp_sw
 (Hardware-dependent)
@@ -1568,7 +1568,7 @@ with Failover Mode 1 (Passive Not Ready(PNR)).
 .I 1 rdac
 (Hardware-dependent)
 Hardware handler for LSI/Engenio/NetApp RDAC class as NetApp SANtricity E/EF
-Series, and rebranded arrays.
+Series and rebranded arrays, with "Linux DM-MP (Kernel 3.9 or earlier)" option.
 .TP
 .I 1 hp_sw
 (Hardware-dependent)
-- 
2.37.3

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: add more info for NetApp RDAC arrays

[Xose Vazquez Perez]

From:
https://library.netapp.com/ecmdocs/ECMLP2439710/html/GUID-49E94674-947F-4921-A1D1-CE9B42DCBA39.html
https://library.netapp.com/ecmdocs/ECMLP2439710/html/GUID-CA17AE34-F5B2-4FF4-8FD4-4A7AA4238976.html
https://library.netapp.com/ecmdocs/ECMLP2439710/html/GUID-3DA657A9-FF4A-4237-90EC-BA8863B7431E.html

To use ALUA mode, "Automatic Load Balancing" should be enabled and
"Select operating system:" should be changed to "Linux DM-MP (Kernel 3.10 or 
later)".

To use RDAC mode, "Automatic Load Balancing" should be disabled and
"Select operating system:" should be changed to "Linux DM-MP (Kernel 3.9 or 
earlier)".


Add it to prio and hardware_handler, and to alua info.


Cc: NetApp RDAC team 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 README.md  | 5 +++--
 multipath/multipath.conf.5 | 8 +---
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/README.md b/README.md
index b05b1332..4e34c591 100644
--- a/README.md
+++ b/README.md
@@ -165,8 +165,9 @@ To enable ALUA, the following options should be changed:
"LUN Affinity" and "ALUA" should be changed to "Enable", "Redundancy Type"
must be "Active-Active".
 
-- LSI/Engenio/NetApp RDAC class, as NetApp SANtricity E/EF Series and OEM 
arrays:
-   "Select operating system:" should be changed to "Linux DM-MP (Kernel 3.10 
or later)".
+- LSI/Engenio/NetApp RDAC class, as NetApp SANtricity E/EF Series and 
rebranded arrays:
+  "Automatic Load Balancing" should be enabled and "Select operating system:"
+  should be changed to "Linux DM-MP (Kernel 3.10 or later)".
 
 - NetApp ONTAP:
To check ALUA state: "igroup show -v ", and to enable ALUA:
diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index acdd1ae6..58080990 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -6,7 +6,7 @@
 .\" Update the date below if you make any significant change.
 .\" 

 .
-.TH MULTIPATH.CONF 5 2021-09-08 Linux
+.TH MULTIPATH.CONF 5 2022-08-14 Linux
 .
 .
 .\" 

@@ -320,7 +320,8 @@ Generate the path priority for NetApp ONTAP class, and 
rebranded arrays.
 .I rdac
 (Hardware-dependent)
 Generate the path priority for LSI/Engenio/NetApp RDAC class as NetApp 
SANtricity
-E/EF Series, and rebranded arrays.
+E/EF Series and rebranded arrays, with Automatic Load Balancing disabled and
+Select operating system: Linux DM-MP (Kernel 3.9 or earlier).
 .TP
 .I hp_sw
 (Hardware-dependent)
@@ -1568,7 +1569,8 @@ with Failover Mode 1 (Passive Not Ready(PNR)).
 .I 1 rdac
 (Hardware-dependent)
 Hardware handler for LSI/Engenio/NetApp RDAC class as NetApp SANtricity E/EF
-Series, and rebranded arrays.
+Series and rebranded arrays, with Automatic Load Balancing disabled and
+Select operating system: Linux DM-MP (Kernel 3.9 or earlier).
 .TP
 .I 1 hp_sw
 (Hardware-dependent)
-- 
2.37.2

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] spelling: cplusplus

[Xose Vazquez Perez]

From: Josh Soref <2119212+jso...@users.noreply.github.com>

From: Josh Soref <2119212+jso...@users.noreply.github.com>

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Reviewed-by: Xose Vazquez Perez 
Signed-off-by: Josh Soref <2119212+jso...@users.noreply.github.com>
---
It was 12/44
---
 libmpathvalid/mpath_valid.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libmpathvalid/mpath_valid.h b/libmpathvalid/mpath_valid.h
index ed06196e..ec2f9392 100644
--- a/libmpathvalid/mpath_valid.h
+++ b/libmpathvalid/mpath_valid.h
@@ -20,7 +20,7 @@
 #ifndef LIB_MPATH_VALID_H
 #define LIB_MPATH_VALID_H
 
-#ifdef __cpluscplus
+#ifdef __cplusplus
 extern "C" {
 #endif
 
-- 
2.37.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH v2] multipath-tools: add basic info on how to use multipath-tools with NVMe devices

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 README.md | 16 
 1 file changed, 16 insertions(+)

diff --git a/README.md b/README.md
index 2322082c..b05b1332 100644
--- a/README.md
+++ b/README.md
@@ -174,3 +174,19 @@ To enable ALUA, the following options should be changed:
 
 - Huawei OceanStor:
"Host Access Mode" should be changed to "Asymmetric".
+
+
+NVMe
+
+To use Device Mapper/multipath-tools with NVMe devices,
+if the Native NVMe Multipath subsystem is enabled
+( "Y" in `/sys/module/nvme_core/parameters/multipath` ),
+it has to be disabled:
+
+`echo "options nvme_core multipath=N" > /etc/modprobe.d/01-nvme_core-mp.conf`,
+regenerate the initramfs (`dracut -f` or `update-initramfs`) and reboot.
+
+Check that it is disabled(N) with:
+`cat /sys/module/nvme_core/parameters/multipath`
+or
+`systool -m nvme_core -A multipath`
-- 
2.37.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: correct CLARiiON info from multipath.conf man page

[Xose Vazquez Perez]

Remove "Unity" from emc prio and hardware_handler, because
Unity does not support PNR mode, just ALUA (page 113 and 153):
https://www.delltechnologies.com/asset/en-us/products/storage/technical-support/docu5128.pdf
And add PNR info.

Cc: Yanfei Chen 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 multipath/multipath.conf.5 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index d5506d99..8cc1be13 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -306,7 +306,7 @@ generate the path priority. This prioritizer accepts the 
optional prio_arg
 .I emc
 (Hardware-dependent)
 Generate the path priority for DGC class arrays as CLARiiON CX/AX and
-EMC VNX and Unity families.
+EMC VNX families with Failover Mode 1 (Passive Not Ready(PNR)).
 .TP
 .I alua
 (Hardware-dependent)
@@ -1562,8 +1562,8 @@ The following hardware handler are implemented:
 .TP 12
 .I 1 emc
 (Hardware-dependent)
-Hardware handler for DGC class arrays as CLARiiON CX/AX and EMC VNX and Unity
-families.
+Hardware handler for DGC class arrays as CLARiiON CX/AX and EMC VNX families
+with Failover Mode 1 (Passive Not Ready(PNR)).
 .TP
 .I 1 rdac
 (Hardware-dependent)
-- 
2.37.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: remove list of rebranded arrays vendors from man page

[Xose Vazquez Perez]

It does not provide useful info, and it is incomplete.

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 multipath/multipath.conf.5 | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index c2d34f18..d5506d99 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -315,12 +315,12 @@ accepts the optional prio_arg \fIexclusive_pref_bit\fR.
 .TP
 .I ontap
 (Hardware-dependent)
-Generate the path priority for NetApp ONTAP class and OEM arrays as IBM 
NSeries.
+Generate the path priority for NetApp ONTAP class, and rebranded arrays.
 .TP
 .I rdac
 (Hardware-dependent)
 Generate the path priority for LSI/Engenio/NetApp RDAC class as NetApp 
SANtricity
-E/EF Series, and OEM arrays from IBM DELL SGI STK and SUN.
+E/EF Series, and rebranded arrays.
 .TP
 .I hp_sw
 (Hardware-dependent)
@@ -496,7 +496,7 @@ Active/Standby mode exclusively.
 .I rdac
 (Hardware-dependent)
 Check the path state for LSI/Engenio/NetApp RDAC class as NetApp SANtricity 
E/EF
-Series, and OEM arrays from IBM DELL SGI STK and SUN.
+Series, and rebranded arrays.
 .TP
 .I directio
 Read the first sector with direct I/O. This checker could cause spurious path
@@ -1568,7 +1568,7 @@ families.
 .I 1 rdac
 (Hardware-dependent)
 Hardware handler for LSI/Engenio/NetApp RDAC class as NetApp SANtricity E/EF
-Series, and OEM arrays from IBM DELL SGI STK and SUN.
+Series, and rebranded arrays.
 .TP
 .I 1 hp_sw
 (Hardware-dependent)
-- 
2.37.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] libmultipath: unset detect_checker for clariion / Unity arrays

[Xose Vazquez Perez]

This patch is still pending.

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 0/2] multipath-tools: update docs

[Xose Vazquez Perez]

On 7/15/22 09:33, Martin Wilck wrote:

>> ALUA is supported in some devices, but usually it's disabled by default.
>> To enable ALUA, the following options should be changed:


Perhaps we should just delete the sentence "usually it's disabled by
default"?


I do find the sentence to be accurate. "usually" does the trick.

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 0/2] multipath-tools: update docs

[Xose Vazquez Perez]

On 7/14/22 21:38, Martin Wilck wrote:


On Thu, 2022-07-14 at 21:05 +0200, Xose Vazquez Perez wrote:

Xose Vazquez Perez (2):
   multipath-tools: update devel repo info in README.md
   multipath-tools: delete README.alua


Why complete delete it?


It was written five years ago, and now maybe it is outdated/irrelevant.
Three options were provided; let it be, delete it, or move the info to README.md
Treat it like rfc.

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: add ALUA info to README.md

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 README.md | 28 
 1 file changed, 28 insertions(+)

diff --git a/README.md b/README.md
index dcf51f20..2322082c 100644
--- a/README.md
+++ b/README.md
@@ -146,3 +146,31 @@ The multipath-tools source code is covered by several 
different licences.
 Refer to the individual source files for details.
 Source files which do not specify a licence are shipped under LGPL-2.0
 (see `LICENSES/LGPL-2.0`).
+
+
+ALUA
+
+This is a rough guide, consult your storage device manufacturer documentation.
+
+ALUA is supported in some devices, but usually it's disabled by default.
+To enable ALUA, the following options should be changed:
+
+- EMC CLARiiON/VNX:
+   "Failover Mode" should be changed to "4" or "Active-Active 
mode(ALUA)-failover mode 4"
+
+- HPE 3PAR, Primera, and Alletra 9000:
+   "Host:" should be changed to "Generic-ALUA Persona 2 (UARepLun, SESLun, 
ALUA)".
+
+- Promise VTrak/Vess:
+   "LUN Affinity" and "ALUA" should be changed to "Enable", "Redundancy Type"
+   must be "Active-Active".
+
+- LSI/Engenio/NetApp RDAC class, as NetApp SANtricity E/EF Series and OEM 
arrays:
+   "Select operating system:" should be changed to "Linux DM-MP (Kernel 3.10 
or later)".
+
+- NetApp ONTAP:
+   To check ALUA state: "igroup show -v ", and to enable ALUA:
+   "igroup set  alua yes".
+
+- Huawei OceanStor:
+   "Host Access Mode" should be changed to "Asymmetric".
-- 
2.37.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 1/2] multipath-tools: update devel repo info in README.md

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 README.md | 10 +++---
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/README.md b/README.md
index f06f8cea..dcf51f20 100644
--- a/README.md
+++ b/README.md
@@ -3,7 +3,6 @@
 multipath-tools for Linux
 =
 
-
 https://github.com/opensvc/multipath-tools
 
 This package provides the following binaries to drive the Device Mapper 
multipathing driver:
@@ -42,14 +41,12 @@ Go to: https://github.com/opensvc/multipath-tools/tags
 Select a release-tag and then click on "zip" or "tar.gz".
 
 
-Source code
-===
+Devel code
+==
 
 To get latest devel code:
 
-git clone https://github.com/opensvc/multipath-tools.git
-
-Github page: https://github.com/opensvc/multipath-tools
+git clone -b queue https://github.com/openSUSE/multipath-tools
 
 
 Building multipath-tools
@@ -149,4 +146,3 @@ The multipath-tools source code is covered by several 
different licences.
 Refer to the individual source files for details.
 Source files which do not specify a licence are shipped under LGPL-2.0
 (see `LICENSES/LGPL-2.0`).
-
-- 
2.37.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 2/2] multipath-tools: delete README.alua

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 README.alua | 24 
 1 file changed, 24 deletions(-)
 delete mode 100644 README.alua

diff --git a/README.alua b/README.alua
deleted file mode 100644
index 5d2b1c64..
--- a/README.alua
+++ /dev/null
@@ -1,24 +0,0 @@
-This is a rough guide, consult your storage device manufacturer documentation.
-
-ALUA is supported in some devices, but usually it's disabled by default.
-To enable ALUA, the following options should be changed:
-
-- EMC CLARiiON/VNX:
-   "Failover Mode" should be changed to "4" or "Active-Active 
mode(ALUA)-failover mode 4"
-
-- HPE 3PAR, Primera, and Alletra 9000:
-   "Host:" should be changed to "Generic-ALUA Persona 2 (UARepLun, SESLun, 
ALUA)".
-
-- Promise VTrak/Vess:
-   "LUN Affinity" and "ALUA" should be changed to "Enable", "Redundancy Type"
-   must be "Active-Active".
-
-- LSI/Engenio/NetApp RDAC class, as NetApp SANtricity E/EF Series and OEM 
arrays:
-   "Select operating system:" should be changed to "Linux DM-MP (Kernel 3.10 
or later)".
-
-- NetApp ONTAP:
-   To check ALUA state: "igroup show -v ", and to enable ALUA:
-   "igroup set  alua yes".
-
-- Huawei OceanStor:
-   "Host Access Mode" should be changed to "Asymmetric".
-- 
2.37.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 0/2] multipath-tools: update docs

[Xose Vazquez Perez]

Xose Vazquez Perez (2):
  multipath-tools: update devel repo info in README.md
  multipath-tools: delete README.alua

 README.alua | 24 
 README.md   | 10 +++---
 2 files changed, 3 insertions(+), 31 deletions(-)
 delete mode 100644 README.alua

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
-- 
2.37.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 1/2] multipath-tools: update Huawei OceanStor NVMe vendor id

[Xose Vazquez Perez]

"NVME" in the doc, but "NVMe" is the real output:
(page 61-62): https://drive.google.com/file/d/1c5RK4GXX7ofZBFxTtZ_IN1qHyIjw5eR1
https://marc.info/?l=dm-devel=163393151312418
Use both, just in case.

Cc: 
Cc: 
Cc: 
Cc: Zhouweigang (Jack) 
Cc: Zou Ming 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 513fa679..fc0252ba 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -1116,7 +1116,7 @@ static struct hwentry default_hw[] = {
},
{
/* OceanStor NVMe */
-   .vendor= "NVME",
+   .vendor= "NVM[eE]",
.product   = "Huawei-XSG1",
.checker_name  = DIRECTIO,
.no_path_retry = 12,
-- 
2.36.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 0/2] update hwtable

[Xose Vazquez Perez]

Xose Vazquez Perez (2):
  multipath-tools: update Huawei OceanStor NVMe vendor id
  multipath-tools: update "Generic NVMe" vendor regex in hwtable

 libmultipath/hwtable.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Cc: 
Cc: 
Cc: 
Cc: Zhouweigang (Jack) 
Cc: Zou Ming 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
-- 
2.36.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 2/2] multipath-tools: update "Generic NVMe" vendor regex in hwtable

[Xose Vazquez Perez]

to accept NVME and NVMe

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index fc0252ba..c88fa09a 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -86,7 +86,7 @@ static struct hwentry default_hw[] = {
 */
{
/* Generic NVMe */
-   .vendor= "NVME",
+   .vendor= "NVM[eE]",
.product   = ".*",
.uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE,
.checker_name  = NONE,
-- 
2.36.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] multipath-tools: add basic info on how to use multipath-tools with NVMe devices

[Xose Vazquez Perez]

On 4/1/22 12:20, Martin Wilck wrote:


On Mon, 2022-03-28 at 19:57 +0200, Xose Vazquez Perez wrote:

On 3/28/22 19:48, Martin Wilck wrote:

On Mon, 2022-03-28 at 19:04 +0200, Xose Vazquez Perez wrote:

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
   README.nvme | 12 
   1 file changed, 12 insertions(+)
   create mode 100644 README.nvme


Why another separate README with just 12 lines?

Martin


README.md is intended multipath-tools developers.
And README.alua and README.nvme are for sysadmins.



I see no fundamental reason not to merge all READMEs into one,
and create "sysadmin" and "developer" sections.


README.md is in markdown syntax.
README.alua and README.nvme are plain text, and its content is easier to 
identify.
Are you running out of inodes? :-)

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 4/9] multipath-tools: add NetApp E-Series NVMe to hardware table

[Xose Vazquez Perez]

On 6/9/22 18:49, Martin Wilck wrote:


IIUC NetApp's concern is not the generic entry, but the entries
mentioning E-Series or it's OEM products in NVMe configuration
explicitly. I also have some trouble understanding the concern, but
NetApp is in charge of these entries, so I believe we should respect
what they're saying.

With the late patches I submitted, the generic NVMe defaults would work
for the NetApp devices without those being explicitly mentioned. I hope
this is ok for everyone. Only the no_path_retry setting would get lost,
which is acceptable IMO because this is rather an admin setting than
product-specific.


And now (IMO) it is worse, because NetApp NVMe arrays are under a generic 
config.

What do they hate?  just ".product = "NetApp E-Series"" ???

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 4/9] multipath-tools: add NetApp E-Series NVMe to hardware table

[Xose Vazquez Perez]

On 5/26/22 22:10, Schremmer, Steven wrote:


Sorry for being slow to respond to this. NetApp publishes settings for
multipath-tools for NVMe-attach E-Series for specific distribution versions
that we have qualified. Anyone using these settings outside of these
versions would NOT be in a valid system configuration for NetApp support. Are
reasonable defaults in the hardware table really useful if they cause a user
to follow a path that leads them to an unsupported system configuration?


Do you(@NetApp crew) realize that the "NVME/.*" prod/vendor was added more than 
five years ago:
https://github.com/opensvc/multipath-tools/commit/4dd25783e13909cba0c38ed8bfedf76dc5a38c7b#diff-eeab98c4bb0459858e2ad17c9aa77ea30ee7a900e16cddb5325b9984b1694021

Your argument doesn't make any sense.

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: fix Huawei OceanStor NVMe vendor tag

[Xose Vazquez Perez]

"NVME" in the doc, but "NVMe" is the real output:
(page 61-62): https://drive.google.com/file/d/1c5RK4GXX7ofZBFxTtZ_IN1qHyIjw5eR1
https://marc.info/?l=dm-devel=163393151312418
Use both, just in case.

Cc: 
Cc: 
Cc: 
Cc: Zhouweigang (Jack) 
Cc: Zou Ming 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 39daadc2..c2b3642c 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -1147,7 +1147,7 @@ static struct hwentry default_hw[] = {
},
{
/* OceanStor NVMe */
-   .vendor= "NVME",
+   .vendor= "NVM[eE]",
.product   = "Huawei-XSG1",
.pgpolicy  = MULTIBUS,
.checker_name  = DIRECTIO,
-- 
2.36.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: update "Generic NVMe" options in hwtable

[Xose Vazquez Perez]

Suggested-by: Martin Wilck 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 39daadc2..555f4e0c 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -86,11 +86,10 @@ static struct hwentry default_hw[] = {
 */
{
/* Generic NVMe */
-   .vendor= "NVME",
+   .vendor= "NVM[eE]",
.product   = ".*",
.uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE,
.checker_name  = NONE,
-   .retain_hwhandler = RETAIN_HWHANDLER_OFF,
},
/*
 * Apple
-- 
2.36.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH RFC] multipath-tools: update "Generic NVMe" options in hwtable

[Xose Vazquez Perez]

On 3/31/22 13:02, Martin Wilck wrote:

On Wed, 2022-03-30 at 21:49 +0200, Xose Vazquez Perez wrote:

Removed values were default.


This is wrong for uid_attribute. You can see it when you run "make
test", which fails with your patch. It's also wrong for
retain_hwhandler, but that entry should indeed be removed, because
keeping it there is misleading at best. hwhandlers have no meaning for
NVMe, and retain_hwhandler is enforced to be true an all kernels since
4.3.

Regards,
Martin


Check ANA, else fall back to CONST(multibus).

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
  libmultipath/hwtable.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 0e1c0a41..81dca0d5 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -88,9 +88,9 @@ static struct hwentry default_hw[] = {
 /* Generic NVMe */
 .vendor    = "NVME",
 .product   = ".*",
-   .uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE,
-   .checker_name  = NONE,
-   .retain_hwhandler = RETAIN_HWHANDLER_OFF,
+   .pgpolicy  = GROUP_BY_PRIO,
+   .pgfailback    = -FAILBACK_IMMEDIATE,
+   .no_path_retry = NO_PATH_RETRY_QUEUE,
 },
 /*
  * Apple




as of this patch, what else do you want to add/remove ?

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 47ea5d3d..2f750adb 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -86,11 +86,10 @@ static struct hwentry default_hw[] = {
 */
{
/* Generic NVMe */
-   .vendor= "NVME",
+   .vendor= "NVM[eE]",
.product   = ".*",
.uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE,
.checker_name  = NONE,
-   .retain_hwhandler = RETAIN_HWHANDLER_OFF,
},
/*
 * Apple

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: add ETERNUS AB/HB (relabeled NetApp E-Series) NVMe to hardware table

[Xose Vazquez Perez]

Info from (page 88):
https://sp.ts.fujitsu.com/dmsp/Publications/public/a3ca08733-a105-EN.pdf

Cc: NetApp RDAC team 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 9 +
 1 file changed, 9 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 47ea5d3d..39daadc2 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -477,6 +477,15 @@ static struct hwentry default_hw[] = {
.pgfailback= -FAILBACK_IMMEDIATE,
.no_path_retry = 30,
},
+   {
+   /* ETERNUS AB/HB NVMe */
+   .vendor= "NVME",
+   .product   = "Fujitsu ETERNUS AB/HB Series",
+   .pgpolicy  = GROUP_BY_PRIO,
+   .prio_name = PRIO_ANA,
+   .pgfailback= -FAILBACK_IMMEDIATE,
+   .no_path_retry = 30,
+   },
/*
 * Hitachi Vantara
 *
-- 
2.36.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 0/9] add new devices to hw table

[Xose Vazquez Perez]

Xose Vazquez Perez (9):
  multipath-tools: fix misspellings
  multipath-tools: add HPE Alletra 9000 NVMe to hardware table
  multipath-tools: delete redundant ONTAP NVMe comment
  multipath-tools: add NetApp E-Series NVMe to hardware table
  multipath-tools: add Huawei OceanStor NVMe to hardware table
  multipath-tools: add IBM FlashSystem(TMS RamSan) NVMe to hardware table
  multipath-tools: add IBM FlashSystem(Storwize/SVC) NVMe to hardware table
  multipath-tools: add Pure FlashArray NVMe to hardware table
  multipath-tools: add Dell EMC PowerStore NVMe to hardware table

 README.md   |  2 +-
 libmultipath/checkers/rdac.c|  2 +-
 libmultipath/hwtable.c  | 60 ++---
 libmultipath/prioritizers/iet.c |  2 +-
 multipath/multipath.conf.5  |  2 +-
 tests/directio.c|  2 +-
 6 files changed, 60 insertions(+), 10 deletions(-)

Cc: NetApp RDAC team 
Cc: Uday Shankar 
Cc: Brian Bunker 
Cc: Zhouweigang (Jack) 
Cc: Zou Ming 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
-- 
2.36.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 6/9] multipath-tools: add IBM FlashSystem(TMS RamSan) NVMe to hardware table

[Xose Vazquez Perez]

Info from:
https://www.ibm.com/docs/en/flashsystem-900/1.6.1?topic=configurations-multipathing-information-linux

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index e5adc2a3..f825f6d3 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -733,6 +733,13 @@ static struct hwentry default_hw[] = {
.product   = "(RamSan|FlashSystem)",
.pgpolicy  = MULTIBUS,
},
+   {
+   /* FlashSystem(RamSan) NVMe */
+   .vendor= "NVMe",
+   .product   = "FlashSystem",
+   .pgpolicy  = MULTIBUS,
+   .no_path_retry = NO_PATH_RETRY_FAIL,
+   },
{
/* (DDN) DCS9900, SONAS 2851-DR1 */
.vendor= "IBM",
-- 
2.36.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 7/9] multipath-tools: add IBM FlashSystem(Storwize/SVC) NVMe to hardware table

[Xose Vazquez Perez]

Info from:
https://www.ibm.com/docs/en/flashsystem-7x00/8.5.x?topic=system-multipath-configuration-fc-nvme-hosts

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index f825f6d3..f99e2537 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -680,6 +680,13 @@ static struct hwentry default_hw[] = {
.pgfailback= -FAILBACK_IMMEDIATE,
.prio_name = PRIO_ALUA,
},
+   {
+   /* FlashSystem(Storwize/SVC) NVMe */
+   .vendor= "NVME",
+   .product   = "IBM[ ]+2145",
+   .pgpolicy  = MULTIBUS,
+   .no_path_retry = NO_PATH_RETRY_QUEUE,
+   },
{
/* PAV DASD ECKD */
.vendor= "IBM",
-- 
2.36.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 4/9] multipath-tools: add NetApp E-Series NVMe to hardware table

[Xose Vazquez Perez]

Info from (page 12):
https://docs.netapp.com/us-en/e-series/pdfs/sidebar/NVMe_over_Fibre_Channel_setup.pdf

Cc: NetApp RDAC team 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 9 +
 1 file changed, 9 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 814e727a..61a5aa16 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -845,6 +845,15 @@ static struct hwentry default_hw[] = {
.pgpolicy  = MULTIBUS,
.no_path_retry = NO_PATH_RETRY_QUEUE,
},
+   {
+   /* E-Series NVMe */
+   .vendor= "NVME",
+   .product   = "NetApp E-Series",
+   .pgpolicy  = GROUP_BY_PRIO,
+   .prio_name = PRIO_ANA,
+   .pgfailback= -FAILBACK_IMMEDIATE,
+   .no_path_retry = 30,
+   },
/*
 * NEC
 */
-- 
2.36.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 8/9] multipath-tools: add Pure FlashArray NVMe to hardware table

[Xose Vazquez Perez]

Cc: Uday Shankar 
Cc: Brian Bunker 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index f99e2537..bef1c8e5 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -1107,6 +1107,13 @@ static struct hwentry default_hw[] = {
.fast_io_fail  = 10,
.max_sectors_kb = 4096,
},
+   {
+   /* FlashArray NVMe */
+   .vendor= "NVME",
+   .product   = "Pure Storage FlashArray",
+   .pgpolicy  = MULTIBUS,
+   .no_path_retry = 10,
+   },
/*
 * Huawei
 */
-- 
2.36.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 9/9] multipath-tools: add Dell EMC PowerStore NVMe to hardware table

[Xose Vazquez Perez]

Info from (page 46):
https://dl.dell.com/content/manual37523884-dell-emc-powerstore-host-configuration-guide.pdf

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 9 +
 1 file changed, 9 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index bef1c8e5..47ea5d3d 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -403,6 +403,15 @@ static struct hwentry default_hw[] = {
.no_path_retry = 3,
.fast_io_fail  = 15,
},
+   {
+   /* PowerStore NVMe */
+   .vendor= ".*",
+   .product   = "dellemc-powerstore",
+   .pgpolicy  = GROUP_BY_PRIO,
+   .prio_name = PRIO_ANA,
+   .pgfailback= -FAILBACK_IMMEDIATE,
+   .no_path_retry = 3,
+   },
{
/* PowerVault ME 4/5 families */
.vendor= "DellEMC",
-- 
2.36.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 3/9] multipath-tools: delete redundant ONTAP NVMe comment

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index b6ff1107..814e727a 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -839,11 +839,7 @@ static struct hwentry default_hw[] = {
.no_path_retry = 24,
},
{
-   /*
-* NVMe-FC namespace devices: MULTIBUS, queueing preferred
-*
-* The hwtable is searched backwards, so place this after 
"Generic NVMe"
-*/
+   /* ONTAP NVMe */
.vendor= "NVME",
.product   = "^NetApp ONTAP Controller",
.pgpolicy  = MULTIBUS,
-- 
2.36.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 2/9] multipath-tools: add HPE Alletra 9000 NVMe to hardware table

[Xose Vazquez Perez]

Info from (page 53, website sometimes is broken):
https://support.hpe.com/hpesc/public/docDisplay?docLocale=en_US=a00115289en_us
 or
https://support.hpe.com/hpesc/public/docDisplay?docId=sd1334en_us=GUID-551FCC2F-D8EA-405B-B9DC-2E66C2AE8608.html

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 0f0795c3..b6ff1107 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -119,6 +119,13 @@ static struct hwentry default_hw[] = {
.dev_loss  = MAX_DEV_LOSS_TMO,
.vpd_vendor_id = VPD_VP_HP3PAR,
},
+   {
+   /* Alletra 9000 NVMe */
+   .vendor= "NVME",
+   .product   = "HPE Alletra",
+   .pgpolicy  = MULTIBUS,
+   .no_path_retry = NO_PATH_RETRY_QUEUE,
+   },
{
/* RA8000 / ESA12000 */
.vendor= "DEC",
-- 
2.36.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 5/9] multipath-tools: add Huawei OceanStor NVMe to hardware table

[Xose Vazquez Perez]

Info from (config removed in latest edition):
https://download.huawei.com/edownload/e/download.do?actionFlag=download=EDOC1100154490=6001=SUPE_DOC&_t=1612885603000
Old version (page 61-62): 
https://drive.google.com/file/d/1c5RK4GXX7ofZBFxTtZ_IN1qHyIjw5eR1

Cc: Zhouweigang (Jack) 
Cc: Zou Ming 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 8 
 1 file changed, 8 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 61a5aa16..e5adc2a3 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -1106,6 +1106,14 @@ static struct hwentry default_hw[] = {
.pgfailback= -FAILBACK_IMMEDIATE,
.no_path_retry = 15,
},
+   {
+   /* OceanStor NVMe */
+   .vendor= "NVME",
+   .product   = "Huawei-XSG1",
+   .pgpolicy  = MULTIBUS,
+   .checker_name  = DIRECTIO,
+   .no_path_retry = 12,
+   },
/*
 * Kove
 */
-- 
2.36.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 1/9] multipath-tools: fix misspellings

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 README.md   | 2 +-
 libmultipath/checkers/rdac.c| 2 +-
 libmultipath/prioritizers/iet.c | 2 +-
 multipath/multipath.conf.5  | 2 +-
 tests/directio.c| 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/README.md b/README.md
index d67888d9..f06f8cea 100644
--- a/README.md
+++ b/README.md
@@ -80,7 +80,7 @@ The following variables can be passed to the `make` command 
line:
The default is `/etc/multipath/conf.d`.
  * `ENABLE_LIBDMMP=0`: disable building libdmmp
  * `ENABLE_DMEVENTS_POLL=0`: disable support for the device-mapper event
-   polling API. For use with pre-5.0 kernels that don't supprt dmevent polling
+   polling API. For use with pre-5.0 kernels that don't support dmevent polling
(but even if you don't use this option, multipath-tools will work with
these kernels).
  * `SCSI_DH_MODULES_PRELOAD="(list)"`: specify a space-separated list of SCSI
diff --git a/libmultipath/checkers/rdac.c b/libmultipath/checkers/rdac.c
index d924a9f7..f7aaa30a 100644
--- a/libmultipath/checkers/rdac.c
+++ b/libmultipath/checkers/rdac.c
@@ -96,7 +96,7 @@ int libcheck_init (struct checker * c)
goto out;
}
 
-   /* get the changeble values */
+   /* get the changeable values */
cmd[2] = 0xA + (CHANGEABLE_PAGE_CODE_VALUES << 6);
io_hdr.dxferp = 
memset(, 0, sizeof(struct control_mode_page));
diff --git a/libmultipath/prioritizers/iet.c b/libmultipath/prioritizers/iet.c
index e98773cf..167a46b0 100644
--- a/libmultipath/prioritizers/iet.c
+++ b/libmultipath/prioritizers/iet.c
@@ -31,7 +31,7 @@
 // name: find_regex
 // @param string: string you want to search into
 // @param regex: the pattern used
-// @return result: string finded in string with regex, "none" if none
+// @return result: string found in string with regex, "none" if none
 char *find_regex(char * string, char * regex)
 {
int err;
diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index fe838e38..d57c810b 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -1759,7 +1759,7 @@ The protocol string of the path device. The possible 
values are \fIscsi:fcp\fR,
 \fIscsi:spi\fR, \fIscsi:ssa\fR, \fIscsi:sbp\fR, \fIscsi:srp\fR,
 \fIscsi:iscsi\fR, \fIscsi:sas\fR, \fIscsi:adt\fR, \fIscsi:ata\fR,
 \fIscsi:unspec\fR, \fIccw\fR, \fIcciss\fR, \fInvme\fR, and \fIundef\fR. This is
-\fBnot\fR a regular expression. the path device protcol string must match
+\fBnot\fR a regular expression. the path device protocol string must match
 exactly. The protocol that a path is using can be viewed by running
 \fBmultipathd show paths format "%d %P"\fR
 .LP
diff --git a/tests/directio.c b/tests/directio.c
index 9f7d3883..20ccc47a 100644
--- a/tests/directio.c
+++ b/tests/directio.c
@@ -693,7 +693,7 @@ static void test_check_state_blksize(void **state)
do_libcheck_reset(1);
 }
 
-/* test async checkers pending and getting resovled by another checker
+/* test async checkers pending and getting resolved by another checker
  * as well as the loops for getting multiple events */
 static void test_check_state_async(void **state)
 {
-- 
2.36.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: remove duplicate headers

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/foreign/nvme.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libmultipath/foreign/nvme.c b/libmultipath/foreign/nvme.c
index 838e1164..52ca56d8 100644
--- a/libmultipath/foreign/nvme.c
+++ b/libmultipath/foreign/nvme.c
@@ -23,7 +23,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
-- 
2.35.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH RFC] multipath-tools: update "Generic NVMe" options in hwtable

[Xose Vazquez Perez]

Removed values were default.
Check ANA, else fall back to CONST(multibus).

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 0e1c0a41..81dca0d5 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -88,9 +88,9 @@ static struct hwentry default_hw[] = {
/* Generic NVMe */
.vendor= "NVME",
.product   = ".*",
-   .uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE,
-   .checker_name  = NONE,
-   .retain_hwhandler = RETAIN_HWHANDLER_OFF,
+   .pgpolicy  = GROUP_BY_PRIO,
+   .pgfailback= -FAILBACK_IMMEDIATE,
+   .no_path_retry = NO_PATH_RETRY_QUEUE,
},
/*
 * Apple
-- 
2.35.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] multipath-tools: add basic info on how to use multipath-tools with NVMe devices

[Xose Vazquez Perez]

On 3/28/22 19:48, Martin Wilck wrote:

On Mon, 2022-03-28 at 19:04 +0200, Xose Vazquez Perez wrote:

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
  README.nvme | 12 
  1 file changed, 12 insertions(+)
  create mode 100644 README.nvme


Why another separate README with just 12 lines?

Martin


README.md is intended multipath-tools developers.
And README.alua and README.nvme are for sysadmins.

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: add basic info on how to use multipath-tools with NVMe devices

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 README.nvme | 12 
 1 file changed, 12 insertions(+)
 create mode 100644 README.nvme

diff --git a/README.nvme b/README.nvme
new file mode 100644
index ..70bf6b0d
--- /dev/null
+++ b/README.nvme
@@ -0,0 +1,12 @@
+To use Device Mapper/multipath-tools with NVMe devices,
+if the Native NVMe Multipath subsystem is enabled
+( "Y" in /sys/module/nvme_core/parameters/multipath ),
+it has to be disabled:
+
+echo "options nvme_core multipath=N" > /etc/modprobe.d/01-nvme_core-mp.conf
+regenerate the initramfs (dracut -f or update-initramfs) and reboot.
+
+Check that it is disabled(N) with:
+cat /sys/module/nvme_core/parameters/multipath
+or
+systool -m nvme_core -A multipath
-- 
2.35.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: add Martin and Benjamin as maintainers

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 README.md | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 15478625..10ddf463 100644
--- a/README.md
+++ b/README.md
@@ -129,10 +129,12 @@ pre-0.4.5: 
https://web.archive.org/web/20070309224034/http://christophe.varoqui.
 post-0.4.5: https://github.com/opensvc/multipath-tools/commits/master
 
 
-Maintainer
-==
+Maintainers
+===
 
 Christophe Varoqui 
+Benjamin Marzinski 
+Martin Wilck 
 Device-mapper development mailing list 
 
 
-- 
2.35.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 3/3] multipath-tools: add HP/HSVX740 to hwtable

[Xose Vazquez Perez]

Info from: 
https://community.hpe.com/hpeb/attachments/hpeb/itrc-248/61618/1/HP_DM_MP_Guide.pdf

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 7a4b78f1..0e1c0a41 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -192,7 +192,7 @@ static struct hwentry default_hw[] = {
{
/* SAN Virtualization Services Platform */
.vendor= "HP",
-   .product   = "HSVX700",
+   .product   = "(HSVX700|HSVX740)",
.hwhandler = "1 alua",
.pgpolicy  = GROUP_BY_PRIO,
.pgfailback= -FAILBACK_IMMEDIATE,
-- 
2.35.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 2/3] multipath-tools: add HPE as vendor for OPEN- (XP8 arrays)

[Xose Vazquez Perez]

Cc: Matthias Rudolph 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index cace23b7..7a4b78f1 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -467,8 +467,8 @@ static struct hwentry default_hw[] = {
 * Maintainer: Matthias Rudolph 
 */
{
-   /* USP-V, HUS VM, VSP, VSP G1X00 and VSP GX00 families / HP XP 
*/
-   .vendor= "(HITACHI|HP)",
+   /* USP-V, HUS VM, VSP, VSP G1X00 and VSP GX00 families / HPE XP 
*/
+   .vendor= "(HITACHI|HP|HPE)",
.product   = "^OPEN-",
.pgpolicy  = MULTIBUS,
},
-- 
2.35.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 1/3] multipath-tools: identify more arrays under IBM/2145 ID

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 7f89dd2c..cace23b7 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -665,7 +665,7 @@ static struct hwentry default_hw[] = {
},
{
// Storwize V5000 and V7000 lines / SAN Volume Controller (SVC) 
/ Flex System V7000 /
-   // FlashSystem V840/V9000/5000/5100/5200/7200/9100/9200/9200R
+   // FlashSystem 
V840/V9000/5000/5100/5200/7200/7300/9100/9200/9200R/9500
.vendor= "IBM",
.product   = "^2145",
.no_path_retry = NO_PATH_RETRY_QUEUE,
-- 
2.35.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: add DellEMC/ME5 (PowerVault ME5) to hardware table

[Xose Vazquez Perez]

Convert PowerVault ME4 template for all ME series.

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index bd157103..7f89dd2c 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -397,9 +397,9 @@ static struct hwentry default_hw[] = {
.fast_io_fail  = 15,
},
{
-   /* PowerVault ME4 */
+   /* PowerVault ME 4/5 families */
.vendor= "DellEMC",
-   .product   = "ME4",
+   .product   = "^ME",
.pgpolicy  = GROUP_BY_PRIO,
.prio_name = PRIO_ALUA,
.hwhandler = "1 alua",
-- 
2.35.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [opensvc/multipath-tools] Bump version (PR #27)

[Xose Vazquez Perez]

On 2/21/22 22:34, Martin Wilck wrote:

here is another multipath-tools update. I've taken the liberty to bump the version to 0.8.9 already. It's mostly a bug fix release. The most important new feature is the support for FC Fibre 
Performance Impact Notifications (FPIN) contributed by Muneendra Kumar.



It was not tagged yet!



@bmarzins  (12):
libmultipath: embed dm_info in multipath structure
multipathd: update dm_info on multipath change events
multipathd: avoid unnecessary path read-only reloads
libmultipath: fix DI_NOIO pathinfo PATH_PENDING handling
libmultipath: simplify out __set_no_path_retry()
libmultipath: don't enter recovery mode with pending paths
libmultipath: fix disassemble status for historical-service-time PS
libmultipath: make helper function to trigger path uevents
multipathd: trigger udev change on path addition
libmultipath: use asprintf() to allocate prefixed_uuid
multipathd: disallow changing to/from fpin marginal paths on reconfig
libmultipath: fix printing native nvme multipath topology.

@mwilck  (23):
multipathd.service: remove LimitCORE=infinity directive
multipathd.service: don't load SCSI device handler modules
multipathd.service: add dependency on initrd-cleanup.service
multipathd.service: drop dependencies on iscsi and iscsid
libmpathpersist: split public and internal API
multipathd: remove duplicate definitions from main.h
libmpathpersist/multipathd: remove duplicate definition
libmpathpersist: remove __STDC_FORMAT_MACROS
libmpathpersist: cleanup mpathpr.h
libmultipath.version: bump major version
multipath/Makefile: use $(udevrulesdir)
multipath-tools: Makefile.inc: delete obsolete comment
multipath-tools: install modules-load.d/multipath.conf
multipathd.service: drop ExecStartPre for loading dm-multipath
multipath: Makefile: modules-load.d file for SCSI device handlers
README.md: add basic information about building multipath-tools
libmultipath: hwtable: use ALUA for all LIO targets
kpartx.rules: skip MD devices
libmultipath: enable linear ordering of bus/proto tuple
libmultipath: use bus_protocol_id() in snprint_path_protocol()
libmultipath: enable defining a static bitfield
libmultipath: only warn once about unsupported dev_loss_tmo
Bump version to 0.8.9

@muneendramandala  (1):
multipathd: handle fpin events

@thesamesam  (1):
build: don't compress man pages (fixes #24 
)

@trofi  (6):
kpartx/devmapper.c: fix unused-but-set variable error
kpartx/devmapper.c: fix unused variable error
multipath-tools: autodiscover libdevmapper.h headers
multipath-tools: autodiscover libudev.h headers
multipath-tools: allow passing non-standard linux-headers location
multipath-tools: avoid using GZIP Makefile variable
(fixes #23 )

@steffen-maier  (2):
libmultipath: support host adapter name lookup for s390x ccw bus
libmultipath: add %L path wildcard for 64-bit hex LUN

@Uglymotha  (1):
Add missing include  (fixes #25 
)

@xosevp  (2):
multipath-tools: fix misspellings
multipath-tools: remove duplicate headers




You can view, comment on, or merge this pull request online at:

https://github.com/opensvc/multipath-tools/pull/27 



Commit Summary

  * 6afb78f 

 multipathd.service: remove LimitCORE=infinity directive
  * e90c387 

 multipathd.service: don't load SCSI device handler modules
  * 11f0440 

 multipathd.service: add dependency on initrd-cleanup.service
  * 7b251a0 

 multipathd.service: drop dependencies on iscsi and iscsid
  * cc18bab 

 libmultipath: embed dm_info in multipath structure
  * 67c86ad 

 multipathd: update dm_info on multipath change events
  * 6e40bf9 

 multipathd: avoid unnecessary path read-only reloads
  

Re: F36 Change proposal: No ifcfg by default (Self-Contained Change)

[Xose Vazquez Perez]

Neal Gompa wrote:


On Wed, Jan 5, 2022 at 9:43 AM Sérgio Basto 


It's deprecated and expected to be retired eventually. I doubt a
"port" would ever happen.


initscripts is needed by audit: https://bugzilla.redhat.com/2029105
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[dm-devel] [PATCH] multipath-tools: remove duplicate headers

[Xose Vazquez Perez]

Minimal clean up done with scripts/checkincludes.pl

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
./libdmmp/libdmmp.c: stdbool.h is included more than once.
./libmpathpersist/mpath_pr_ioctl.c: unistd.h is included more than once.
./libmultipath/alias.c: errno.h is included more than once.
./libmultipath/alias.c: stdlib.h is included more than once.
./libmultipath/alias.c: util.h is included more than once.
./libmultipath/checkers/directio.c: unistd.h is included more than once.
./libmultipath/checkers/tur.c: ../libmultipath/util.h is included more than 
once.
./libmultipath/print.c: string.h is included more than once.
./libmultipath/uevent.c: errno.h is included more than once.
./multipath/main.c: alias.h is included more than once.
./multipathd/main.c: uevent.h is included more than once.
./multipathd/main.c: wwids.h is included more than once.
./tests/strbuf.c: stdbool.h is included more than once.
---
 libdmmp/libdmmp.c| 1 -
 libmpathpersist/mpath_pr_ioctl.c | 1 -
 libmultipath/alias.c | 3 ---
 libmultipath/checkers/directio.c | 1 -
 libmultipath/checkers/tur.c  | 1 -
 libmultipath/print.c | 1 -
 libmultipath/uevent.c| 1 -
 multipath/main.c | 1 -
 multipathd/main.c| 2 --
 tests/strbuf.c   | 1 -
 10 files changed, 13 deletions(-)

diff --git a/libdmmp/libdmmp.c b/libdmmp/libdmmp.c
index 51f1d8fc..0025e66d 100644
--- a/libdmmp/libdmmp.c
+++ b/libdmmp/libdmmp.c
@@ -26,7 +26,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/libmpathpersist/mpath_pr_ioctl.c b/libmpathpersist/mpath_pr_ioctl.c
index 17c52848..093ec71b 100644
--- a/libmpathpersist/mpath_pr_ioctl.c
+++ b/libmpathpersist/mpath_pr_ioctl.c
@@ -10,7 +10,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include "mpath_pr_ioctl.h"
 #include "mpath_persist.h"
diff --git a/libmultipath/alias.c b/libmultipath/alias.c
index 87c33afc..548a1184 100644
--- a/libmultipath/alias.c
+++ b/libmultipath/alias.c
@@ -4,7 +4,6 @@
  */
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -19,8 +18,6 @@
 #include "checkers.h"
 #include "structs.h"
 #include "config.h"
-#include "util.h"
-#include "errno.h"
 #include "devmapper.h"
 #include "strbuf.h"
 
diff --git a/libmultipath/checkers/directio.c b/libmultipath/checkers/directio.c
index 28b0cf51..bc7b7be5 100644
--- a/libmultipath/checkers/directio.c
+++ b/libmultipath/checkers/directio.c
@@ -12,7 +12,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 #include "checkers.h"
diff --git a/libmultipath/checkers/tur.c b/libmultipath/checkers/tur.c
index a4b4a213..c93e4625 100644
--- a/libmultipath/checkers/tur.c
+++ b/libmultipath/checkers/tur.c
@@ -23,7 +23,6 @@
 #include "../libmultipath/sg_include.h"
 #include "../libmultipath/util.h"
 #include "../libmultipath/time-util.h"
-#include "../libmultipath/util.h"
 
 #define TUR_CMD_LEN 6
 #define HEAVY_CHECK_COUNT   10
diff --git a/libmultipath/print.c b/libmultipath/print.c
index c93fffd4..ef4e05d2 100644
--- a/libmultipath/print.c
+++ b/libmultipath/print.c
@@ -8,7 +8,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/libmultipath/uevent.c b/libmultipath/uevent.c
index b1f00b3e..29e25572 100644
--- a/libmultipath/uevent.c
+++ b/libmultipath/uevent.c
@@ -41,7 +41,6 @@
 #include 
 #include 
 #include 
-#include 
 
 #include "debug.h"
 #include "list.h"
diff --git a/multipath/main.c b/multipath/main.c
index 0a9377e5..d09f62db 100644
--- a/multipath/main.c
+++ b/multipath/main.c
@@ -63,7 +63,6 @@
 #include "time-util.h"
 #include "file.h"
 #include "valid.h"
-#include "alias.h"
 
 /*
  * Return values of configure(), check_path_valid(), and main().
diff --git a/multipathd/main.c b/multipathd/main.c
index 4d611647..c241dad5 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -59,7 +59,6 @@
 #include "prio.h"
 #include "wwids.h"
 #include "pgpolicies.h"
-#include "uevent.h"
 #include "log.h"
 #include "uxsock.h"
 #include "alias.h"
@@ -80,7 +79,6 @@
 #include "waiter.h"
 #include "dmevents.h"
 #include "io_err_stat.h"
-#include "wwids.h"
 #include "foreign.h"
 #include "../third-party/valgrind/drd.h"
 #include "init_unwinder.h"
diff --git a/tests/strbuf.c b/tests/strbuf.c
index 43a477db..f8554da5 100644
--- a/tests/strbuf.c
+++ b/tests/strbuf.c
@@ -9,7 +9,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include "strbuf.h"
-- 
2.34.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: fix misspellings

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
Unsure about: ./libmpathpersist/mpath_persist.h:80: FORMATE ==> FORMAT ???
---
CHANGES:
./kpartx/crc32.c:345: multile ==> multiple
./kpartx/gpt.c:97: MSDOS ==> MS-DOS
./libdmmp/libdmmp.c:192: retuned ==> returned
./libmpathcmd/mpath_cmd.h:83: successs ==> success
./libmpathpersist/mpath_persist_int.c:549: avialable ==> available
./libmpathvalid/mpath_valid.h:86: reinitalize ==> reinitialize
./libmpathvalid/mpath_valid.h:98: resoures ==> resources
./libmpathvalid/mpath_valid.h:99: futher ==> further
./libmultipath/checkers/directio.c:26: multple ==> multiple
./libmultipath/checkers.h:159: asyncronous ==> asynchronous
./libmultipath/dmparser.c:105: unkown ==> unknown
./libmultipath/foreign.h:45: strucure ==> structure
./libmultipath/Makefile:64: nees ==> needs
./libmultipath/prioritizers/alua_spc3.h:289: asymetric ==> asymmetric
./libmultipath/prioritizers/path_latency.c:287: thresold ==> threshold
./libmultipath/uevent.c:295: exsit ==> exist
./multipathd/dmevents.c:388: intialized ==> initialized
./multipathd/main.c:1602: initalized ==> initialized
./multipathd/main.c:1794: hadling ==> handling
./multipathd/main.c:2110: occured ==> occurred
./multipathd/main.c:2280: abnormaly ==> abnormally
./multipathd/main.h:20: occassion ==> occasion
./multipathd/multipathd.8:85: seperate ==> separate
./multipathd/uxlsnr.c:78: mumber ==> number
./multipath/multipath.conf.5:1100: seperate ==> separate
./multipath/multipath.conf.5:1101: occuring ==> occurring
./multipath/multipath.conf.5:1143: encounted ==> encountered
./multipath/multipath.conf.5:1423: agains ==> against
./multipath/multipath.conf.5:1550: wilcard ==> wildcard
./multipath/multipath.conf.5:1798: occurence ==> occurrence
./multipath/multipath.conf.5:254: effiency ==> efficiency
./multipath/multipath.conf.5:590: greated ==> greater
./multipath/multipath.conf.5:833: mutipath ==> multipath
./tests/hwtable.c:1006: trival ==> trivial
./tests/hwtable.c:1046: trival ==> trivial
./tests/hwtable.c:1089: trival ==> trivial
./tests/hwtable.c:424: expresssions ==> expressions
./tests/hwtable.c:606: qith ==> with
./tests/hwtable.c:970: trival ==> trivial
./tests/README.md:41: containting ==> containing

SUMMARY:
abnormaly 1
asymetric 1
asyncronous   1
avialable 1
containting   1
effiency  1
expresssions  1
futher1
hadling   1
initalized1
intialized1
msdos 1
multile   1
multple   1
mumber1
mutipath  1
nees  1
occassion 1
occured   1
occurence 1
occuring  1
qith  1
reinitalize   1
resoures  1
retuned   1
seperate  2
strucure  1
successs  1
thresold  1
trival4
unkown1
wilcard   1
---
 kpartx/crc32.c   |  2 +-
 kpartx/gpt.c |  2 +-
 libdmmp/libdmmp.c|  2 +-
 libmpathcmd/mpath_cmd.h  |  2 +-
 libmpathpersist/mpath_persist_int.c  |  2 +-
 libmpathvalid/mpath_valid.h  |  6 +++---
 libmultipath/Makefile|  2 +-
 libmultipath/checkers.h  |  2 +-
 libmultipath/checkers/directio.c |  2 +-
 libmultipath/dmparser.c  |  2 +-
 libmultipath/foreign.h   |  2 +-
 libmultipath/prioritizers/alua_spc3.h|  2 +-
 libmultipath/prioritizers/path_latency.c |  2 +-
 libmultipath/uevent.c|  2 +-
 multipath/multipath.conf.5   | 18 +-
 multipathd/dmevents.c|  2 +-
 multipathd/main.c|  8 
 multipathd/main.h|  2 +-
 multipathd/multipathd.8  |  2 +-
 multipathd/uxlsnr.c  |  2 +-
 tests/README.md  |  2 +-
 tests/hwtable.c  | 12 ++--
 22 files changed, 40 insertions(+), 40 deletions(-)

diff --git a/kpartx/crc32.c b/kpartx/crc32.c
index b23a0835..e688f8e9 100644
--- a/kpartx/crc32.c
+++ b/kpartx/crc32.c
@@ -342,7 +342,7 @@ uint32_t attribute((pure)) crc32_be(uint32_t crc, unsigned 
char const *p, size_t
  * but again the multiple of the polynomial to subtract depends only on
  * the high bits, the high 8 bits in this case.
  *
- * The multile we need in that case is the low 32 bits of a 40-bit
+ * The multiple we need in that case is the low 32 bits of a 40-bit
  * value whose high 8 bits are given, and which is a multiple of the
  * generator polynomial.  This is simply the CRC-32 of the given
  * one-byte message.
diff --git a/kpartx/gpt.c b/kpartx/gpt.c
index f7fefb70..34a910cf 100644
--- a/kpartx/gpt.c
+++ b/kpartx/gpt.c
@@ -94,7 +94,7 @@ efi_crc32(const void *buf, unsigned long len)
  *
  * Description: Returns 1 if PMBR is

Re: [dm-devel] [PATCH resend] multipath-tools: dm-devel is a closed ml

[Xose Vazquez Perez]

On 12/2/21 08:45, Martin Wilck wrote:


On Wed, 2021-12-01 at 23:35 +0100, Xose Vazquez Perez wrote:

Just for subscribers

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
  README.md | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)



According to Alasdair's statement,
(https://listman.redhat.com/archives/dm-devel/2021-October/msg00037.html),
the list is "moderated for non-subscribers", not strictly subscribers-
only.

Moreover, the same README has "(subscribers-only)" just a few lines
above, in the "Mailing List" section.


"moderated for non-subscribers" should only be for very sporadic posters.
Contributors must be in the list.
Sometimes some messages get lost because it's human-operated. And it
also overloads ml admins with unnecessary extra work.

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH resend] multipath-tools: delete duplicate RDAC maintainer entries

[Xose Vazquez Perez]

On 12/2/21 08:56, Martin Wilck wrote:



I'd like to have this acked by Netapp before merging it. Actually, I'd
prefer to have it acked by Fujitsu and Lenovo, too, but we don't have
contact addresses for them, so be it.

My €0.02: I'd rather not have this, because it's not obvious to
everybody that these arrays are actually Netapp systems and are thus
maintained not by their vendors but Netapp.


There are 25 RDAC arrays in hwtable, only two of them(those included in
the patch) and the NetApp one have a "Maintainer" entry.
And they can easily identified, .checker_name and .prio_name are RDAC.

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: add .mailmap file

[Xose Vazquez Perez]

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 .mailmap | 24 
 1 file changed, 24 insertions(+)
 create mode 100644 .mailmap

diff --git a/.mailmap b/.mailmap
new file mode 100644
index ..2c04cb0a
--- /dev/null
+++ b/.mailmap
@@ -0,0 +1,24 @@
+#
+# This list is used by git-shortlog to fix a few botched name translations
+# in the git archive, either because the author's full name was messed up
+# and/or not always written the same way, making contributions from the
+# same person appearing not to be so or badly displayed. Also allows for
+# old email addresses to map to new email addresses.
+#
+# For format details, see "MAPPING AUTHORS" in "man git-shortlog".
+#
+# Please keep this list dictionary sorted.
+#
+Benjamin Marzinski  
+Benjamin Marzinski  
+Benjamin Marzinski  bmarz...@sourceware.org 

+Christophe Varoqui  

+Christophe Varoqui  
+Christophe Varoqui  
+Christophe Varoqui  

+Christophe Varoqui  root 
+Christophe Varoqui  root 
+Christophe Varoqui  root 

+Christophe Varoqui  
+Martin Wilck  
+Martin Wilck  
-- 
2.33.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH resend] multipath-tools: dm-devel is a closed ml

[Xose Vazquez Perez]

Just for subscribers

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index b15c265f..2d3d1023 100644
--- a/README.md
+++ b/README.md
@@ -77,7 +77,7 @@ Maintainer
 ==
 
 Christophe Varoqui 
-Device-mapper development mailing list 
+Device-mapper development mailing list (subscribers-only) 
 
 
 Licence
-- 
2.33.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH resend] multipath-tools: delete duplicate RDAC maintainer entries

[Xose Vazquez Perez]

Already at NetApp.

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 11 ++-
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 763982cd..1cae0ca5 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -439,10 +439,7 @@ static struct hwentry default_hw[] = {
.no_path_retry = 10,
},
{
-   /*
-* ETERNUS AB/HB
-* Maintainer: NetApp RDAC team 

-*/
+   /* ETERNUS AB/HB */
.vendor= "FUJITSU",
.product   = "ETERNUS_AHB",
.bl_product= "Universal Xport",
@@ -762,11 +759,7 @@ static struct hwentry default_hw[] = {
 * Lenovo
 */
{
-   /*
-* DE Series
-*
-* Maintainer: NetApp RDAC team 

-*/
+   /* DE Series */
.vendor= "LENOVO",
.product   = "DE_Series",
.bl_product= "Universal Xport",
-- 
2.32.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH resend] multipath-tools: add DellEMC/ME4 (PowerVault ME4) to hardware table

[Xose Vazquez Perez]

Info from: 
https://www.delltechnologies.com/asset/fr-fr/products/storage/industry-market/PowerVault_ME4_Series_and_Linux.pdf

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 9 +
 1 file changed, 9 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 763982cd..fc85283b 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -398,6 +398,15 @@ static struct hwentry default_hw[] = {
.no_path_retry = 3,
.fast_io_fail  = 15,
},
+   {
+   /* PowerVault ME4 */
+   .vendor= "DellEMC",
+   .product   = "ME4",
+   .pgpolicy  = GROUP_BY_PRIO,
+   .prio_name = PRIO_ALUA,
+   .hwhandler = "1 alua",
+   .pgfailback= -FAILBACK_IMMEDIATE,
+   },
/*
 * Fujitsu
 */
-- 
2.32.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH resend] multipath-tools: remove Hannes as IBM arrays maintainer

[Xose Vazquez Perez]

Reviewed-by: Hannes Reinecke 
Cc: Hannes Reinecke 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 763982cd..11282699 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -482,8 +482,6 @@ static struct hwentry default_hw[] = {
},
/*
 * IBM
-*
-* Maintainer: Hannes Reinecke 
 */
{
/* ProFibre 4000R */
-- 
2.32.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] multipath-tools: dm-devel is a closed ml

[Xose Vazquez Perez]

On 10/9/21 02:41, Alasdair G Kergon wrote:


On Fri, Oct 08, 2021 at 05:06:26PM +0200, Xose Vazquez Perez wrote:

Just for subscribers


Although we manually moderate non-subscribers so their messages
do get through, often a bit delayed.

Alasdair



BTW, this should be added to: 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/MAINTAINERS#n5433

To get:
Alasdair Kergon  (maintainer:DEVICE-MAPPER  (LVM))
Mike Snitzer  (maintainer:DEVICE-MAPPER  (LVM))
dm-devel@redhat.com (moderated list:DEVICE-MAPPER  (LVM))
linux-ker...@vger.kernel.org (open list)

---

diff --git a/MAINTAINERS b/MAINTAINERS
index a4a0c2baaf27..3b9d679c6239 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5433,8 +5433,7 @@ F:include/linux/devm-helpers.h
 DEVICE-MAPPER  (LVM)
 M: Alasdair Kergon 
 M: Mike Snitzer 
-M: dm-devel@redhat.com
-L: dm-devel@redhat.com
+L: dm-devel@redhat.com (moderated for non-subscribers)
 S: Maintained
 W: http://sources.redhat.com/dm
 Q: http://patchwork.kernel.org/project/dm-devel/list/

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: dm-devel is a closed ml

[Xose Vazquez Perez]

Just for subscribers

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index b15c265f..2d3d1023 100644
--- a/README.md
+++ b/README.md
@@ -77,7 +77,7 @@ Maintainer
 ==
 
 Christophe Varoqui 
-Device-mapper development mailing list 
+Device-mapper development mailing list (subscribers-only) 
 
 
 Licence
-- 
2.33.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH RFC] multipath-tools: remove Hannes as IBM arrays maintainer

[Xose Vazquez Perez]

On 10/2/21 15:43, Hannes Reinecke wrote:


diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 763982cd..11282699 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -482,8 +482,6 @@ static struct hwentry default_hw[] = {
  },
  /*
   * IBM
- *
- * Maintainer: Hannes Reinecke 
   */
  {
  /* ProFibre 4000R */



Hmm. You could've asked me ...


It was sent as RFC.

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH RFC] multipath-tools: remove Hannes as IBM arrays maintainer

[Xose Vazquez Perez]

Cc: Hannes Reinecke 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 763982cd..11282699 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -482,8 +482,6 @@ static struct hwentry default_hw[] = {
},
/*
 * IBM
-*
-* Maintainer: Hannes Reinecke 
 */
{
/* ProFibre 4000R */
-- 
2.32.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: delete duplicate RDAC maintainer entries

[Xose Vazquez Perez]

Already at NetApp.

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 11 ++-
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 763982cd..1cae0ca5 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -439,10 +439,7 @@ static struct hwentry default_hw[] = {
.no_path_retry = 10,
},
{
-   /*
-* ETERNUS AB/HB
-* Maintainer: NetApp RDAC team 

-*/
+   /* ETERNUS AB/HB */
.vendor= "FUJITSU",
.product   = "ETERNUS_AHB",
.bl_product= "Universal Xport",
@@ -762,11 +759,7 @@ static struct hwentry default_hw[] = {
 * Lenovo
 */
{
-   /*
-* DE Series
-*
-* Maintainer: NetApp RDAC team 

-*/
+   /* DE Series */
.vendor= "LENOVO",
.product   = "DE_Series",
.bl_product= "Universal Xport",
-- 
2.32.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] multipath-tools: remove Compellent maintainer

[Xose Vazquez Perez]

On 9/29/21 09:43, Martin Wilck wrote:


On Tue, 2021-09-28 at 22:39 +0200, Xose Vazquez Perez wrote:

e-mail was bounced: 550 5.1.1 User Unknown

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 


Reviewed-by: Martin Wilck 

(Do we want to maintain this information in our hwtable in the long
run?)


Why not? They are just comments.

It's useful to check settings with arrays vendors.

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: add DellEMC/ME4 (PowerVault ME4) to hardware table

[Xose Vazquez Perez]

Info from: 
https://www.delltechnologies.com/asset/fr-fr/products/storage/industry-market/PowerVault_ME4_Series_and_Linux.pdf

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 9 +
 1 file changed, 9 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 763982cd..fc85283b 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -398,6 +398,15 @@ static struct hwentry default_hw[] = {
.no_path_retry = 3,
.fast_io_fail  = 15,
},
+   {
+   /* PowerVault ME4 */
+   .vendor= "DellEMC",
+   .product   = "ME4",
+   .pgpolicy  = GROUP_BY_PRIO,
+   .prio_name = PRIO_ALUA,
+   .hwhandler = "1 alua",
+   .pgfailback= -FAILBACK_IMMEDIATE,
+   },
/*
 * Fujitsu
 */
-- 
2.32.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: remove Compellent maintainer

[Xose Vazquez Perez]

e-mail was bounced: 550 5.1.1 User Unknown

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 7fc5bc04..763982cd 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -361,11 +361,7 @@ static struct hwentry default_hw[] = {
.pgpolicy  = MULTIBUS,
},
{
-   /*
-* SC Series, formerly Compellent
-*
-* Maintainer: Sean McGinnis 
-*/
+   /* SC Series, formerly Compellent */
.vendor= "COMPELNT",
.product   = "Compellent Vol",
.pgpolicy  = GROUP_BY_PRIO,
-- 
2.32.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: make "COMPELNT/Compellent Vol" config work with alua and multibus

[Xose Vazquez Perez]

ALUA is needed by SAS arrays, pag#124:
https://downloads.dell.com/manuals/all-products/esuprt_solutions_int/esuprt_solutions_int_solutions_resources/general-solution-resources_white-papers2_en-us.pdf

Cc: Sean McGinnis 
Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 4e8b52ff..7fc5bc04 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -368,7 +368,8 @@ static struct hwentry default_hw[] = {
 */
.vendor= "COMPELNT",
.product   = "Compellent Vol",
-   .pgpolicy  = MULTIBUS,
+   .pgpolicy  = GROUP_BY_PRIO,
+   .pgfailback= -FAILBACK_IMMEDIATE,
.no_path_retry = NO_PATH_RETRY_QUEUE,
},
{
-- 
2.32.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] multipath-tools: make EMC/Invista config work with alua and multibus

[Xose Vazquez Perez]

Optimal Path Management (OPM) was introduced with VPLEX 5.5 to improve VPLEX
performance. OPM uses the ALUA mechanism to spread the I/O load across VPLEX 
directors
while gaining cache locality, pag #187:
https://www.delltechnologies.com/en-us/collaterals/unauth/technical-guides-support-information/products/storage-2/docu5128.pdf

Cc: Martin Wilck 
Cc: Benjamin Marzinski 
Cc: Christophe Varoqui 
Cc: DM-DEVEL ML 
Signed-off-by: Xose Vazquez Perez 
---
 libmultipath/hwtable.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 7095aaf1..4e8b52ff 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -350,8 +350,9 @@ static struct hwentry default_hw[] = {
.vendor= "EMC",
.product   = "Invista",
.bl_product= "LUNZ",
-   .pgpolicy  = MULTIBUS,
+   .pgpolicy  = GROUP_BY_PRIO,
.no_path_retry = 5,
+   .pgfailback= -FAILBACK_IMMEDIATE,
},
{
/* XtremIO */
-- 
2.32.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel