[Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is < 10000 and fails in various places

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365

--- Comment #37 from David Cook  ---
(In reply to Thomas Klausner from comment #36)
> (In reply to Martin Renvoize from comment #35)
> > I suppose it's not as clear cut as we're making out here is it? 
> > MARC::Record allows dealing with ISO 2709 MARC and MARCXML, and those differ
> > in their ability to handle large records.
> 
> Yes, so I think that MARC::File::USMARC should properly handle too large
> data (which MARC::File::XML can handle) via providing an option to truncate
> too large data or die when trying to encode it.

+1

> Koha itself should switch to use MARCXML to store the whole record in the ES
> index (unless we don't need the whole record in the index at all)

Personally, I don't think we need the whole record in the index at all, but
that's arguably a separate issue. 

If we use MARCXML instead of MARC, unless we base64 encode it, I realized there
will be a side-effect there of making the whole record queryable on a keyword
search. (I recently noted that we don't have a "Any" index in ES like we do
with Zebra.)

(In reply to Martin Renvoize from comment #35)
> I suppose it's not as clear cut as we're making out here is it? 
> MARC::Record allows dealing with ISO 2709 MARC and MARCXML, and those differ
> in their ability to handle large records.  If we fix the ISO representation
> to truncate it throw exceptions won't that also affect the MARCXML round
> tripping?   Can we definitely have it work one way for one and another for
> the other?   I suppose we would basically need to ensure the core store is
> in MARCXML and the ISO output is the but that truncated or errors..  but is
> that inside MARC::Record or should that be handled at the Koha layer.. 
> certainly the iso parts should do better at highlighting the issues however,
> and certainly the encoding fun you identified needs fixing.

So MARCXML->MARC->MARCXML record roundtripping for large records is already a
problem, because the process generates invalid MARC records, which can't be
read back into MARCXML. That's the issue we're trying to address. 

If MARC::Record threw an exception for MARCXML->MARC where a valid record can't
be generated, we would've never wound up in the mess we're currently in haha. 

Of course, MARC::Record isn't the only one guilty of this. I'm trying to get
MarcEdit fixed, because I have a different scenario where it produces invalid
MARC records too. 

So in terms of MARC::Record vs Koha... I think MARC::Record should throw an
exception, and Koha should handle that exception. Personally, the only time we
should ever be using ISO MARC is as an export. And in that situation we can say
"Sorry! Unable to export this record as an ISO MARC file due to field size
limitations! Please try another format!" or something like that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25339] Validate biblionumber on opac-basket.pl and opac-review.pl

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25339

David Cook  changed:

   What|Removed |Added

   Assignee|dc...@prosentient.com.au|oleon...@myacpl.org
 Status|Failed QA   |In Discussion

--- Comment #10 from David Cook  ---
Sorry, Owen. I reset the Assignee a little while ago, as it seemed we'd hit a
dead-end here and I didn't want folk thinking I was still working on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36217] Jobs page include last hour filter does not work

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36217

--- Comment #4 from David Cook  ---
Actually, it's a bit funny how "Current jobs only" and "Only include jobs
enqueued in the last hour" are handled completely differently. We don't really
need to send a timestamp even, since we know it's always going to be just the
last hour. 

It would be better to have a "only_last_hour" parameter sent by
"koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt" and picked
up in "Koha/REST/V1/BackgroundJobs.pm"

There we can generate a timestamp that is (now - 1 hour) with a timezone that
matches our database connection (see "sub dbh" in Koha/Database.pm for more
details about the db connection).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36217] Jobs page include last hour filter does not work

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36217

David Cook  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from David Cook  ---
This issue is a pet peeve of mine but I haven't had time to address it. 

Marking this as Failed QA based on Phil's comments.

We'll want to send UTC time and process as UTC time on the backend.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37040] ErrorDocument accidentally setting off CSRF

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37040

David Nind  changed:

   What|Removed |Added

 Attachment #167521|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 167560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167560=edit
Bug 37040: Prevent ErrorDocument subrequests from activating CSRF

This change improves the mechanism for preventing the CSRF middleware
being activated by ErrorDocument subrequests.

This change was necessary due to a subtle issue identified by
Bug 37041.

Test plan:
0. Apply the patch
1. Restart Koha
koha-plack --restart kohadev
2. Go to
http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=9908
3. Log in
4. Note that you get a pretty 403 and not an ugly plain text error
5. Go to http://localhost:8081
6. Fill in the login details, but use the HTML inspector to delete
the csrf_token from the hidden inputs
7. Submit the login
8. Note a pretty 403 page

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37040] ErrorDocument accidentally setting off CSRF

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37040

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36217] Jobs page include last hour filter does not work

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36217

Phil Ringnalda  changed:

   What|Removed |Added

 CC||p...@chetcolibrary.org

--- Comment #2 from Phil Ringnalda  ---
What timezone are the values for Queued, Started, and Ended in?

The (sad) answer is that Queued is in server-time, and Started and Ended are in
db-server-time, and your patch only works if server-time is UTC and the browser
is at-or-after UTC.

I see this bug on my production server, where both server-time and
db-server-time are my own timezone, and your patch would work fine.

But in ktd by default, both times are UTC and I'm UTC+7 or UTC+8, and so I
don't see the bug, because "an hour ago or more recently" nicely covers the
fact that jobs are enqueued 7 or 8 hours after the local time I actually
enqueue them.

If I put TZ=America/Los_Angeles in ktd's .env, then server time matches my
time, and I can see the bug without the patch, and the patch fixes the bug,
though it's a little odd that jobs are started and finished 7 or 8 hours after
they were enqueued, and in the future while I'm looking at the job page
(apparently getting db-server-time set in Docker is a bit harder than just
setting TZ in ENV).

If I put TZ=Pacific/Honolulu in ktd's .env, then jobs are enqueued three hours
before I actually created them, and the patch does not work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37048] Use template wrapper for self checkout page

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37048

David Nind  changed:

   What|Removed |Added

 Attachment #167554|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 167559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167559=edit
Bug 37048: Use template wrapper for self checkout page

This patch updates the OPAC's self checkout page template to use
WRAPPERs for the Bootstrap tabs markup.

To test, apply the patch and enable the "WebBasedSelfCheck" system
preference if necessary.

- Navigate to the self checkout page
  (http://127.0.0.1:8080/cgi-bin/koha/sco/sco-main.pl)
  - Start checking out to a patron
- You should see three tabs, "Checkouts", "Holds", and "Charges."
  The tabs should look correct and work correctly.

Sponsored-By: Athens County Public Libraries
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37048] Use template wrapper for self checkout page

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37048

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36868] Add ability to automatically empty cart after placing holds ( staff interface and OPAC )

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868

Lucas Gass  changed:

   What|Removed |Added

 Attachment #166835|0   |1
is obsolete||

--- Comment #3 from Lucas Gass  ---
Created attachment 167558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167558=edit
Bug 36868: Logic for staff interface

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37046] Use template wrapper for OPAC curbside pickups

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37046

David Nind  changed:

   What|Removed |Added

 Attachment #167553|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 167557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167557=edit
Bug 37046: Use template wrapper for OPAC curbside pickups

This patch updates the OPAC curbside pickups template to use WRAPPERs
for the Bootstrap tabs markup.

To test, apply the patch and enable the "CurbsidePickup" system
preference if necessary.

- Log in to the OPAC and click the "Curbside pickups" tab in the sidebar
  of the user summary page.
  - With no curbside pickup policy defined, you shoul see a single tab,
"Your pickups" and the message "No curbside pickups."
- In the staff interface go to Administration -> Curbside pickup.
  - Configure curbside pickups for at least one branch.
- Return to the OPAC and refresh the curbside pickups page.
  - You should now see a "Schedule a pickup" tab along with the "Your
pickups" tab, and it should be active by default.
  - Schedule a pickup.
- When the page refreshes, the "Your pickups" tab should now be
  active by default.

Sponsored-By: Athens County Public Libraries
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37046] Use template wrapper for OPAC curbside pickups

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37046

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35294] Typo in comment in C4 circulation barocode

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35294

David Nind  changed:

   What|Removed |Added

 Attachment #167547|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 167556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167556=edit
Bug 35294: Fix typos in catalogue code comments

Test plan:
1. git grep -n -E 'barocode|preproccess' to find the files and line # of typos
2. Apply the patch
3. git grep -E 'barocode|proccess'
4. See no results

Signed-off-by: David Nind 
Signed-off-by: Matt Blenkinsop 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35294] Typo in comment in C4 circulation barocode

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35294

David Nind  changed:

   What|Removed |Added

 Attachment #167541|0   |1
is obsolete||

--- Comment #7 from David Nind  ---
Comment on attachment 167541
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167541
Bug 35294: Fix typo in catalogue/search.pl

I think adding a follow-up would have been sufficient.

I've obsoleted the original patch, and will add the sign-off lines to the new
patch shortly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36986] (Bug 26176 follow-up) Fix rename StaffLoginBranchBasedOnIP in DBRev

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36986

--- Comment #21 from Victor Grousset/tuxayo  ---
Nice, thanks Frido and Martin :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35294] Typo in comment in C4 circulation barocode

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35294

Brendan Lawlor  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |blaw...@clamsnet.org
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37050] Add select2 to SQL report multi select

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37050] Add select2 to SQL report multi select

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050

--- Comment #1 from Brendan Lawlor  ---
Created attachment 167555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167555=edit
Bug 37050: Add select2 to SQL reports multi select

This patch adds select 2 to modifies multi-select parameter fields in SQL
reports to use the select2 framework. If no selections are made for a multi
select parameter all values will be used by default.

To test:
1. Apply patch
2. Go to Reports and create a report from SQL
   select *
   from items
   where
   homebranch in <>
   and
   itype in <>
3. Run the report making multiple selections for each parameter
4. Run the report making multiple selections for one parameter and no
selections in another parameter
5. Check that the results are as you would expect
6. On the results page click 'Show SQL code'
7. Confirm that the codes are included according to your selections
8. Note that when no selections are made for a parameter all codes are used by
defaut. This allows the query to run when no selections are made instead of
causing an error. It allows reports to be written where a multi select
parameter is optional.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37050] Add select2 to SQL report multi select

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050

Brendan Lawlor  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37050] Add select2 to SQL report multi select

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050

Brendan Lawlor  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |blaw...@clamsnet.org
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37050] New: Add select2 to SQL report multi select

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050

Bug ID: 37050
   Summary: Add select2 to SQL report multi select
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: blaw...@clamsnet.org
QA Contact: testo...@bugs.koha-community.org

Bug 36545 adds select2 to improve the user experience when making multiple
selections in item search.

Bug 35746 adds the ability to reports to make multiple selections for SQL
parameters.

It would be nice for consistency and ux for the report multiselect to use
select2.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37049] New: Advanced Search first field empty returns unexpected results

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37049

Bug ID: 37049
   Summary: Advanced Search first field empty returns unexpected
results
 Change sponsored?: ---
   Product: Koha
   Version: 23.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jyo...@equinoxinitiative.org
QA Contact: testo...@bugs.koha-community.org

I could not find this documented, but I have replicated this on 22.11, 23.05
and 23.11, both on our own systems and a sampling from the Koha demo sites
page.

If you leave the first field blank on the advanced search screen, and complete
the 2nd and 3rd fields, when you perform the search, Koha shifts up the search
terms, so the operators no longer are associated with the desired term.

If you click "Return to the last advanced search", that is exactly how Koha now
displays it. 

For example:

KW: 
AND KW: water
NOT Title: waterloo

Perform the search and then click "Return to the last advanced search".

Koha displays:

KW: water
AND Title: waterloo
NOT KW: 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33177] Use include file for subfield constraints in both authority and bibliographic frameworks

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33177

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33177] Use include file for subfield constraints in both authority and bibliographic frameworks

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33177

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33177] Use include file for subfield constraints in both authority and bibliographic frameworks

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33177

Owen Leonard  changed:

   What|Removed |Added

 Attachment #147994|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37048] Use template wrapper for self checkout page

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37048

--- Comment #1 from Owen Leonard  ---
Created attachment 167554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167554=edit
Bug 37048: Use template wrapper for self checkout page

This patch updates the OPAC's self checkout page template to use
WRAPPERs for the Bootstrap tabs markup.

To test, apply the patch and enable the "WebBasedSelfCheck" system
preference if necessary.

- Navigate to the self checkout page
  (http://127.0.0.1:8080/cgi-bin/koha/sco/sco-main.pl)
  - Start checking out to a patron
- You should see three tabs, "Checkouts", "Holds", and "Charges."
  The tabs should look correct and work correctly.

Sponsored-By: Athens County Public Libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37048] Use template wrapper for self checkout page

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37048

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571

Owen Leonard  changed:

   What|Removed |Added

 Blocks||37048


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37048
[Bug 37048] Use template wrapper for self checkout page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37048] New: Use template wrapper for self checkout page

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37048

Bug ID: 37048
   Summary: Use template wrapper for self checkout page
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 32571

Continuing the work of Bug 32571, self checkout page should be updated to use
the new WRAPPER for tabs.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571
[Bug 32571] Use template wrapper to build tabbed components
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37046] Use template wrapper for OPAC curbside pickups

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37046

--- Comment #1 from Owen Leonard  ---
Created attachment 167553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167553=edit
Bug 37046: Use template wrapper for OPAC curbside pickups

This patch updates the OPAC curbside pickups template to use WRAPPERs
for the Bootstrap tabs markup.

To test, apply the patch and enable the "CurbsidePickup" system
preference if necessary.

- Log in to the OPAC and click the "Curbside pickups" tab in the sidebar
  of the user summary page.
  - With no curbside pickup policy defined, you shoul see a single tab,
"Your pickups" and the message "No curbside pickups."
- In the staff interface go to Administration -> Curbside pickup.
  - Configure curbside pickups for at least one branch.
- Return to the OPAC and refresh the curbside pickups page.
  - You should now see a "Schedule a pickup" tab along with the "Your
pickups" tab, and it should be active by default.
  - Schedule a pickup.
- When the page refreshes, the "Your pickups" tab should now be
  active by default.

Sponsored-By: Athens County Public Libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37046] Use template wrapper for OPAC curbside pickups

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37046

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37047] Patron Bookings

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37047

--- Comment #1 from Kelly McElligott  ---
The bookings does appear from the moremember detail page, but not from the
circulation.pl page

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28575] Add ability to choose if lost fee is refunded based on when lost fee was paid off

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575

Matt Blenkinsop  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |matt.blenkinsop@ptfs-europe
   |ity.org |.com
 CC||matt.blenkinsop@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33737] Add bookings to patron details

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33737

Kelly McElligott  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=37047

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37047] New: Patron Bookings

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37047

Bug ID: 37047
   Summary: Patron Bookings
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Testing on Main, the Patron Bookings tab appears on the Patron page, and will
indicate if there is a number of bookings, but nothing appears if the tab is
clicked. 

To test:
1. Create an item bookable.
2. Book an item for a patron.
3. Either click the patron's name from the booking or go to the patron's detail
page.
4. See they have a Booking (1) in their tab. 
5. Click this tab, but nothing appears. 

Bug 33737 shows that should appear here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571

Owen Leonard  changed:

   What|Removed |Added

 Blocks||37046


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37046
[Bug 37046] Use template wrapper for OPAC curbside pickups
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37046] New: Use template wrapper for OPAC curbside pickups

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37046

Bug ID: 37046
   Summary: Use template wrapper for OPAC curbside pickups
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 32571

Continuing the work of Bug 32571, OPAC's curbside pickups page should be
updated to use the new WRAPPER for tabs.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571
[Bug 32571] Use template wrapper to build tabbed components
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37045] Redirect to login page or modal when adding a title to a list

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37045

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37045] New: Redirect to login page or modal when adding a title to a list

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37045

Bug ID: 37045
   Summary: Redirect to login page or modal when adding a title to
a list
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

In the OPAC, if you're not logged in and try to create a list from the search
results, there is only a browser alert saying you need to be logged in. It
would be helpful to the patron if they were redirected to the login page, or if
a login modal popped up so they can log in and create their list.

To recreate:
1. Make sure you are not logged into the OPAC
2. Search for a term broad enough to get you some results (e.g. shakespeare)
3. Select one or more results and choose the "[New list]" option from the "With
selected titles:" dropdown 
--> You get a browser alert saying you must be logged in

To compare:
4. Click Lists > Log in to create your own lists
--> You are redirected to the login page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33178] Use template wrapper for authority and bibliographic subfield entry form tabs

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178

--- Comment #1 from Owen Leonard  ---
Created attachment 167552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167552=edit
Bug 33178: Use template wrapper for authority and bibliographic subfield entry
form tabs

This patch updates the authority and bibliographic subfield entry
forms to replace tab markup with the use of WRAPPERs. Some JS has been
modified in order to adapt to the changed Bootstrap tab markup.

The patch also updates the WRAPPER code so that a unique ID can be
added to individual tabs. This is necessary as a hook for the Sortable
JavaScript.

To test, apply the patch and go to Administration.

- Go to MARC bibliographic frameworks -> Actions -> MARC structure.
  - Click Actions -> View subfields for a tag with more than one
subfield.
- Click the "Edit" button for one of the subfields, not the first
  one in the list.
  - The tab for the subfield you chose should be active.
  - Confirm that all the tabs look correct and work correctly.
  - Try dragging one of the tabs into a new position. Save your
changes and confirm that the subfield was saved in that new
position.
- Go to Administration -> Authority types -> Actions -> MARC structure
  and repeat the same steps above with the authority record subfields.

Sponsored-By: Athens County Public Libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33178] Use template wrapper for authority and bibliographic subfield entry form tabs

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36749] Link field to authorities removes subfield $e in advanced editor

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36749

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36749] Link field to authorities removes subfield $e in advanced editor

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36749

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35179] Limit MARC Modification Templates by User

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35179

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36847] Add "Multiple matches" as a match type when staging records

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36847

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36847] Add "Multiple matches" as a match type when staging records

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36847

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36960] Apply Multiple MARC Modification Templates when staging MARC records

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36960

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21860] MARC modification templates cannot check or change indicators

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36960] Apply Multiple MARC Modification Templates when staging MARC records

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36960

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36960] Apply Multiple MARC Modification Templates when staging MARC records

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36960

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21860] MARC modification templates cannot check or change indicators

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860

Jason Robb  changed:

   What|Removed |Added

 CC||jr...@sekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21860] MARC modification templates cannot check or change indicators

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860

jvi...@austinseminary.edu changed:

   What|Removed |Added

 CC||jvi...@austinseminary.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21860] MARC modification templates cannot check or change indicators

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860

Lauren Denny  changed:

   What|Removed |Added

 CC||lauren_de...@sil.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28915] MARC Modification Templates should allow specification of a position or range within a control field

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915

Lauren Denny  changed:

   What|Removed |Added

 CC||lauren_de...@sil.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21860] MARC modification templates cannot check or change indicators

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28915] MARC Modification Templates should allow specification of a position or range within a control field

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915

Miranda Nero  changed:

   What|Removed |Added

 CC||mn...@oslri.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21860] MARC modification templates cannot check or change indicators

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860

Miranda Nero  changed:

   What|Removed |Added

 CC||mn...@oslri.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33177] Use include file for subfield constraints in both authority and bibliographic frameworks

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33177

Owen Leonard  changed:

   What|Removed |Added

 Blocks|33178   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178
[Bug 33178] Use template wrapper for authority and bibliographic subfield entry
form tabs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33178] Use template wrapper for authority and bibliographic subfield entry form tabs

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33178

Owen Leonard  changed:

   What|Removed |Added

 Depends on|33177   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33177
[Bug 33177] Use include file for subfield constraints in both authority and
bibliographic frameworks
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37036] Cannot access template toolkit branch variable in auto renewal notices

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov
 QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc
   |y.org   |ountymd.gov
 Status|Signed Off  |Passed QA

--- Comment #4 from Emily Lamancusa  ---
Looks good, and QA tests pass. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36168] remove_unused_authorities.pl timeout error that's not a timeout error

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36168

Koha collecto  changed:

   What|Removed |Added

 CC||k...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37036] Cannot access template toolkit branch variable in auto renewal notices

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #167503|0   |1
is obsolete||

--- Comment #3 from Emily Lamancusa  ---
Created attachment 167551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167551=edit
Bug 37036: Pass along the branches table for auto renewals

To test:
1. Set up autorenewals bu adjusting circulation rules:
'Automatic renewal' -> 'Yes'
'No automatic renewal before' -> 5

2. Set 'AutoRenewalNotices' to 'according to patron messaging preferences'.
3. Set an  AUTO_RENEWALS and  AUTO_RENEWALS_DGST notice to include branch info.
I am using this to test:

Branchcode: [% branch.branchcode %]
Branch name: [% branch.branchname %]
Branch address: [% branch.branchaddress1 %]
Branch address2: [% IF branch.branchaddress2 %][% branch.branchaddress2 %][%
END %]
Branch city: [% branch.branchcity %], [% branch.branchstate %] [%
branch.branchzip %]

4. Make sure your branch has the proper infro. filled out in Libraries
administration.
5. Find a patron and adjust the messaging preferences so they receive automatic
renewal notices. Also make sure the patron has an email.
5. Check out some items and make them due with the next 5 days.
6. Run the automatic_renewal cron job:

perl /kohadevbox/koha/misc/cronjobs/automatic_renewals.pl -c -v

7. Notice no branch information displays.
8. APPLY PATCH
9. Checkout items from multiple issuing branches to a single patron.
10. Make sure the patron's messaging prefs are set to revieve NON-digestable
notices.
11. Run the automatic renewal job, each notice should include the branch
information from the issuing library.
12. Change the patron's messageing preferences to receieve digestable notices.
13. Run the job without the --digest-per-branch flag. You should get a single
notice with the branch info. coming from the patron's home branch.
14. Run the job with the --digest-per-branch flag. You should get seperate
digested notices with the branch info. coming from the issueing library branch.

Signed-off-by: David Nind 
Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36055] Simplify MARC21 Fast Add framework

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36055

Koha collecto  changed:

   What|Removed |Added

 CC||k...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35635] Expand Patron attribute type mandatory field

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37044] OPAC message from SCO missing library branch

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37044

--- Comment #1 from Sam Lau  ---
Created attachment 167550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167550=edit
Bug 37044: Added library branch to SCO OPAC message

This patch simply adds the correct branch at the end of an OPAC message on the
SCO page.

To Test:
1) From the staff interface, click on a patron and add an OPAC message to their
   account.
2) Log into the SCO with this patron.
   (http://localhost:8080/cgi-bin/koha/sco/sco-main.pl)
3) Notice how in the "Messages for you" at the top, you will see the message,
   however, at the timestamp, it says something like "Written on 06/06/2024 by
"
   w/o listing the library that sent it.
4) Apply patch
5) Log back into SCO module
6) Note that now in the message timestamp, it correctly lists the library that
   sent the message.
7) Sign-off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37044] OPAC message from SCO missing library branch

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37044

Sam Lau  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37044] OPAC message from SCO missing library branch

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37044

Sam Lau  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |sama...@gmail.com
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37044] New: OPAC message from SCO missing library branch

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37044

Bug ID: 37044
   Summary: OPAC message from SCO missing library branch
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Self checkout
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: sama...@gmail.com
QA Contact: testo...@bugs.koha-community.org

To recreate:

1) From the staff interface, click on a patron and add an OPAC message to their 
   account. 
2) Log into the SCO with this patron. 
   (http://localhost:8080/cgi-bin/koha/sco/sco-main.pl)
3) Notice how in the "Messages for you" at the top, you will see the message, 
   however, at the timestamp, it says something like "Written on 06/06/2024 by
" 
   w/o listing the library that sent it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36995] Can't delete Library EAN

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36995

--- Comment #5 from Martin Renvoize  ---
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36995] Can't delete Library EAN

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36995

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main
 Version(s)||24.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35989] Searching Geographic authorities generates error

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35989

--- Comment #15 from Martin Renvoize  ---
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35989] Searching Geographic authorities generates error

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35989

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||24.11.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34444] Statistic 1/2 not saving when updating fund after receipt

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3

--- Comment #12 from Martin Renvoize  ---
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34444] Statistic 1/2 not saving when updating fund after receipt

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||24.11.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474

Matt Blenkinsop  changed:

   What|Removed |Added

 CC||matt.blenkinsop@ptfs-europe
   ||.com

--- Comment #94 from Matt Blenkinsop  ---
*** Bug 34762 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34762] Add a search based select component to ERM

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34762

Matt Blenkinsop  changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #10 from Matt Blenkinsop  ---


*** This bug has been marked as a duplicate of bug 32474 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32493] Vendor store loads unpaginated vendor list on ERM module main page

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32493
Bug 32493 depends on bug 34762, which changed state.

Bug 34762 Summary: Add a search based select component to ERM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34762

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36424] Database update 22.06.00.078 breaks update process (II)

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
Version|Main|23.05

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37042] Schema Upgrade fail at 23.06.00.049 > Bug 31503 - Change patron_consent.type

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37042

--- Comment #3 from Martin Renvoize  ---
Downgrading from 'critical' to 'normal' as I think this might be a local issue
rather than a wider problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37042] Schema Upgrade fail at 23.06.00.049 > Bug 31503 - Change patron_consent.type

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37042

Martin Renvoize  changed:

   What|Removed |Added

   Severity|critical|normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37042] Schema Upgrade fail at 23.06.00.049 > Bug 31503 - Change patron_consent.type

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37042

--- Comment #2 from Martin Renvoize  ---
It was added all the way back in 18.11.. I'm thinking you've somehow had it
removed.. could you elaborate as to how you've got into this position?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30198] Add privacy elements to reports

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30198

Caroline Cyr La Rose  changed:

   What|Removed |Added

Version|21.05   |unspecified

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33793] Add method to define limited access to run reports

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33793

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37042] Schema Upgrade fail at 23.06.00.049 > Bug 31503 - Change patron_consent.type

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37042

--- Comment #1 from Martin Renvoize  ---
Hmm, I'm not sure how you've got into the position on not having the
patron_consent table at all..

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||37042


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37042
[Bug 37042] Schema Upgrade  fail at 23.06.00.049 >  Bug 31503 - Change
patron_consent.type
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37042] Schema Upgrade fail at 23.06.00.049 > Bug 31503 - Change patron_consent.type

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37042

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||31503


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503
[Bug 31503] Allow several consent types on the consents tab of OPAC account
page
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||31503


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503
[Bug 31503] Allow several consent types on the consents tab of OPAC account
page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31503] Allow several consent types on the consents tab of OPAC account page

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||20819


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819
[Bug 20819] GDPR: Add a consent field for processing personal data in account
menu and self-registration
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33292] Claim Return doesn't refund lost item charge when MarkLostItemsAsReturned includes "When marking an item as a return claim" and "Refund lost item fee" is on

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27919] Split claims return from LOST

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36926] Move syspref PlaceHoldsOnOrdersFromSuggestions

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36926

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc
   |y.org   |ountymd.gov
 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

--- Comment #5 from Emily Lamancusa  ---
Looks good - thanks, Sam! Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36926] Move syspref PlaceHoldsOnOrdersFromSuggestions

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36926

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #167506|0   |1
is obsolete||

--- Comment #4 from Emily Lamancusa  ---
Created attachment 167549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167549=edit
Bug 36926: Move syspref PlaceHoldsOnOrdersFromSuggestions

This patch moves the 'PlaceHoldsOnOrdersFromSuggestions' system preferences
from the Acquisitions->Printing section to the Circulation->Holds Policy
section.

To test:
1) Go to Admin->System Preferences and search for
'PlaceHoldsOnOrdersFromSuggestions'
2) Note that it is located in the Acquisitions prefs, under the Printing
subheading
3) Apply patch
4) search for the preferences again
5) Note that it is now located in the Circulation preferences under the Holds
Policy subheading

Signed-off-by: David Nind 
Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35635] Expand Patron attribute type mandatory field

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635

Lucas Gass  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34157] Exporting labels as a barcode range can cause 500 error

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34157

J. Reuter  changed:

   What|Removed |Added

 CC||reu...@die-bonn.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35635] Expand Patron attribute type mandatory field

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635

Lucas Gass  changed:

   What|Removed |Added

 Attachment #167546|0   |1
is obsolete||

--- Comment #5 from Lucas Gass  ---
Created attachment 167548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167548=edit
Bug 35635: Add opac_mandatory to patron attribute table

To test:
1. Before applying the patch go to Adminstration > Patron attribute types
2. Create or modify some attributes to be mandatory and some to not be
mandatory.
3. APPLY PATCH, updatedatabase, restart_all
4. Go back to Adminstration > Patron attribute types. The patron attributes
that were made mandatory should now also have the opac_mandatory field checked.
5. Make sure that you can change the correctly save the new "OPAC mandatory:"
field.
6. If the 'Display in OPAC:' field is unchecked the 'OPAC mandatory:' checkbox
should be disabled.
7. Mark some patron attributes as 'OPAC mandatory:'.
8. Go to the OPAC self reg page, the field should be required.
9. BAck on Adminstration > Patron attribute types check some attributes as
'OPAC mandatory:' and 'Editable in OPAC:'.
10. As a logged in OPAC user go to "Personal details" and make sure the
attribute is required.
11. For the same attriubute as step 9-10 , mark as NOT 'Editable in OPAC:'.
Make sure you can still save the form on the OPAC "Personal details" page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35294] Typo in comment in C4 circulation barocode

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35294

--- Comment #6 from Brendan Lawlor  ---
When I looked at this again I noticed another typo in the comment that appears
in both catalogue/search.pl and catalogue/itemsearch.pl

This new patch fixes both typos barocode and preproccess. 

Should I obsolete the first patch and set this back to needs sign off?

Thanks David and Matt.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35294] Typo in comment in C4 circulation barocode

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35294

--- Comment #5 from Brendan Lawlor  ---
Created attachment 167547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167547=edit
Bug 35294: Fix typos in catalogue code comments

Test plan:
1. git grep -n -E 'barocode|preproccess' to find the files and line # of typos
2. Apply the patch
3. git grep -E 'barocode|proccess'
4. See no results

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36925] ERM eUsage reports : data table filter does not work

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925

--- Comment #3 from Matt Blenkinsop  ---
The query behind the reports table is too complex for the datatable filtering
so in the short term we need to switch the filtering off. Reports can be
exported to excel for filtering / analysis

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35635] Expand Patron attribute type mandatory field

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635

--- Comment #4 from Lucas Gass  ---
Created attachment 167546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167546=edit
Bug 35635: Add opac_mandatory to patron attribute table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36925] ERM eUsage reports : data table filter does not work

2024-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925

--- Comment #2 from Matt Blenkinsop  ---
Created attachment 167545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167545=edit
Bug 36925: Remove filtering from usage reports

The query behind a usage report is too complex for the datatables filtering
options and so should be removed until we can add some datatables utility
methods to assist with the filtering

Test plan:
1) Navigate to E-resource management > eUsage > Data providers
2) Create a provider
3) Click into the provider and navigate to the Manual upload tab
4) Upload the file attached
5) Navigate to the Reports section in the left hand menu
6) Run a report that returns some data from the harvested file (report type is
TR_J1)
7) Try to filter the table using the filter inputs, it will fail
8) Apply patch
9) Run yarn js:build to rebuild the Javascript
10) Hard refresh the browser
11) The filter options should not not be in the table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   5   6   7   8   9   10   >