[clang-tools-extra] Clang doc async (PR #93276)
@@ -1049,31 +1047,33 @@ static llvm::Error CopyFile(StringRef FilePath,
StringRef OutDirectory) {
std::error_code FileErr = llvm::sys::fs::copy_file(PathRead, PathWrite);
if (FileErr != OK) {
return llvm::createStringError(llvm::inconvertibleErrorCode(),
- "error creating file " +
- llvm::sys::path::filename(FilePath) +
- ": " + FileErr.message() + "\n");
+ "error creating file " + FilePath + ": " +
+ FileErr.message() + "\n");
}
return llvm::Error::success();
}
llvm::Error HTMLGenerator::createResources(ClangDocContext ) {
- auto Err = SerializeIndex(CDCtx);
- if (Err)
+ if (auto Err = SerializeIndex(CDCtx)) {
return Err;
- Err = GenIndex(CDCtx);
- if (Err)
+ }
+
+ if (auto Err = GenIndex(CDCtx)) {
return Err;
+ }
for (const auto : CDCtx.UserStylesheets) {
-Err = CopyFile(FilePath, CDCtx.OutDirectory);
-if (Err)
+if (auto Err = CopyFile(FilePath, CDCtx.OutDirectory)) {
return Err;
+}
}
+
for (const auto : CDCtx.FilesToCopy) {
-Err = CopyFile(FilePath, CDCtx.OutDirectory);
-if (Err)
+if (auto Err = CopyFile(FilePath, CDCtx.OutDirectory)) {
return Err;
+}
}
+
ilovepi wrote:
nit: Try to avoid unrelated white space chagnes. If your editor inserts these
automatically, you may need to update your config. Also `git clang-format
HEAD~` is your friend, but do be sure to use an up-to-date `clang-format`.
https://github.com/llvm/llvm-project/pull/93276
_______
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] Clang doc async (PR #93276)
@@ -82,6 +82,7 @@ function createIndex(Index) {
document.addEventListener("DOMContentLoaded", function() {
// JsonIndex is a variable from another file that contains the index
// in JSON format
- var Index = JSON.parse(JsonIndex);
- createIndex(Index);
+ fetch("/index.json")
+ .then((response) => response.json())
+ .then((Index) => { createIndex(Index); });
ilovepi wrote:
Can you update this comment to reflect how this works?
https://github.com/llvm/llvm-project/pull/93276
_______
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] Clang doc async (PR #93276)
@@ -179,7 +183,7 @@ Example usage for a project using a compile commands
database:
SourceRoot,
RepositoryUrl,
{UserStylesheets.begin(), UserStylesheets.end()},
- {"index.js", "index_json.js"}};
+ {"index.js"}};
ilovepi wrote:
I assume `index_json.js` is no longer needed from the changes above w/
`fetch(...`. If that's accurate, can you include those details in the commit
message?
https://github.com/llvm/llvm-project/pull/93276
_______
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] Clang doc async (PR #93276)
@@ -491,6 +491,7 @@ struct ClangDocContext {
std::string SourceRoot; // Directory where processed files are stored.
Links
// to definition locations will only be generated
if
// the file is in this dir.
+
ilovepi wrote:
nit: unrelated change in whitespace
https://github.com/llvm/llvm-project/pull/93276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] Clang doc async (PR #93276)
@@ -155,6 +155,10 @@ Example usage for a project using a compile commands database: return 1; } + // add option to customize url fragment + // such as + // https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-doc/ClangDocMain.cpp#L1 + ilovepi wrote: Is this intended as a `TODO:`? https://github.com/llvm/llvm-project/pull/93276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] Clang doc async (PR #93276)
@@ -1049,31 +1047,33 @@ static llvm::Error CopyFile(StringRef FilePath,
StringRef OutDirectory) {
std::error_code FileErr = llvm::sys::fs::copy_file(PathRead, PathWrite);
if (FileErr != OK) {
return llvm::createStringError(llvm::inconvertibleErrorCode(),
- "error creating file " +
- llvm::sys::path::filename(FilePath) +
- ": " + FileErr.message() + "\n");
+ "error creating file " + FilePath + ": " +
+ FileErr.message() + "\n");
ilovepi wrote:
I'm a little unclear on why we're not using the `llvm::sys::path` here anymore?
Is `FilePath` actually a `URL` or something equivalent that isn't platform
dependent? For example, if it's a real file system path, I'd worry that things
like the `/` would be wrong if this was Windows vs. Linux.
https://github.com/llvm/llvm-project/pull/93276
_______
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] Clang doc async (PR #93276)
@@ -1049,31 +1047,33 @@ static llvm::Error CopyFile(StringRef FilePath,
StringRef OutDirectory) {
std::error_code FileErr = llvm::sys::fs::copy_file(PathRead, PathWrite);
if (FileErr != OK) {
return llvm::createStringError(llvm::inconvertibleErrorCode(),
- "error creating file " +
- llvm::sys::path::filename(FilePath) +
- ": " + FileErr.message() + "\n");
+ "error creating file " + FilePath + ": " +
+ FileErr.message() + "\n");
}
return llvm::Error::success();
}
llvm::Error HTMLGenerator::createResources(ClangDocContext ) {
- auto Err = SerializeIndex(CDCtx);
- if (Err)
+ if (auto Err = SerializeIndex(CDCtx)) {
return Err;
- Err = GenIndex(CDCtx);
- if (Err)
+ }
ilovepi wrote:
I'm not sure updating the error handling here and below is a functional
improvement. However, even if it is, it belongs in a separate PR, as its
unrelated to the work done in this patch. While we normally don't use `auto`
that much in llvm (see
https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable),
an error code is probably an OK time to use one. Unfortunately, these APIs
don't seem to obviously return an error based on their signatures, so you may
want to consider using an explicit type (but its not required). Lastly, our
style guide only uses braces for conditionals w/ multiple lines (see
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements).
https://github.com/llvm/llvm-project/pull/93276
_______
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] Clang doc async (PR #93276)
https://github.com/ilovepi requested changes to this pull request. I've noted several items that need to be addressed in line before this lands. Both the commit title and description need to be updated. Please add a tag `[clang-doc]` to the commit title, and include the full details of the problem you're addressing and how this patch addresses them in the description. If this fixes the issue you've referenced, add `Fixes #93273` after the body of the descripton. You can find more info on GitHub interactions w/ commits here https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue Lastly, this patch badly needs tests. Please create a PR with that demonstrates the existing behavior in a test (or tests) that we can land first. You can rebase this patch on top of it, and we can easily understand the delta between the new and old behaviors based on how the test changed. https://github.com/llvm/llvm-project/pull/93276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] Clang doc async (PR #93276)
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/93276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Macro for constant rounding mode (PR #92699)
@@ -965,6 +965,16 @@ void Preprocessor::Lex(Token ) {
LastTokenWasAt = Result.is(tok::at);
--LexLevel;
+ if (Result.is(tok::l_brace)) {
+CurlyBraceLevel++;
+ } else if (Result.is(tok::r_brace)) {
+if (!RoundingPragmas.empty() &&
efriedma-quic wrote:
Maybe we can move the `!RoundingPragmas.empty()` outside the if statement, so
we can skip a little more of the code if the user isn't using any pragmas? I
mean, it probably doesn't make a big difference, but Lex() is
performance-sensitive.
https://github.com/llvm/llvm-project/pull/92699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Macro for constant rounding mode (PR #92699)
https://github.com/efriedma-quic commented: This approach seems much better. https://github.com/llvm/llvm-project/pull/92699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Macro for constant rounding mode (PR #92699)
https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/92699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [clang] Add tanf16 builtin and support for tan constrained intrinsic (PR #93314)
farzonl wrote: > IMO it'd be good to have a bit more context in the commit description about > why this is being done. If you follow the breadcrumbs from the issue to the > thread in the PR I think you can put it together, but a more local summary > might be helpful. done https://github.com/llvm/llvm-project/pull/93314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [clang] Add tanf16 builtin and support for tan constrained intrinsic (PR #93314)
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/93314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)
rgets=$(check-targets
${linux_projects_to_test} | sort | uniq)
linux_projects=$(add-dependencies ${linux_projects_to_test} | sort | uniq)
linux_runtimes_to_test=$(compute-runtimes-to-test ${linux_projects_to_test})
+echo "debug linux_runtimes_to_test: ${linux_runtimes_to_test}"
linux_runtime_check_targets=$(check-targets ${linux_runtimes_to_test} | sort |
uniq)
+echo "debug linux_runtime_check_targets: ${linux_runtime_check_targets}"
linux_runtimes=$(echo ${linux_runtimes_to_test} | sort | uniq)
+echo "debug linux_runtimes: ${linux_runtimes}"
windows_projects_to_test=$(exclude-windows $(compute-projects-to-test
${modified_projects}))
windows_check_targets=$(check-targets ${windows_projects_to_test} | sort |
uniq)
>From 5d56a7e54d7e22be3337d571ac640f353ebc5ac7 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:37:50 +0300
Subject: [PATCH 07/10] Re-enable `set -x`
---
.ci/generate-buildkite-pipeline-premerge | 1 +
1 file changed, 1 insertion(+)
diff --git a/.ci/generate-buildkite-pipeline-premerge
b/.ci/generate-buildkite-pipeline-premerge
index e286d1e2664c8..c4885103ecbd4 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -19,6 +19,7 @@
set -eu
set -o pipefail
+set -x
# Environment variables script works with:
>From 67ed5ce731f7a359c6cccb85b111e6fe71118c72 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:46:23 +0300
Subject: [PATCH 08/10] Removed unncessary echo
---
.ci/generate-buildkite-pipeline-premerge | 1 -
1 file changed, 1 deletion(-)
diff --git a/.ci/generate-buildkite-pipeline-premerge
b/.ci/generate-buildkite-pipeline-premerge
index c4885103ecbd4..e628630257cb3 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -89,7 +89,6 @@ function compute-projects-to-test() {
function compute-runtimes-to-test() {
projects=${@}
for project in ${projects}; do
-echo "${project}"
case ${project} in
clang)
for p in libcxx libcxxabi libunwind; do
>From 6cd1e08f26e8d229b9505daca594abed3500fe20 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:49:35 +0300
Subject: [PATCH 09/10] Remove debug echoes
---
.ci/generate-buildkite-pipeline-premerge | 3 ---
1 file changed, 3 deletions(-)
diff --git a/.ci/generate-buildkite-pipeline-premerge
b/.ci/generate-buildkite-pipeline-premerge
index e628630257cb3..06474323c5b12 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -258,11 +258,8 @@ linux_check_targets=$(check-targets
${linux_projects_to_test} | sort | uniq)
linux_projects=$(add-dependencies ${linux_projects_to_test} | sort | uniq)
linux_runtimes_to_test=$(compute-runtimes-to-test ${linux_projects_to_test})
-echo "debug linux_runtimes_to_test: ${linux_runtimes_to_test}"
linux_runtime_check_targets=$(check-targets ${linux_runtimes_to_test} | sort |
uniq)
-echo "debug linux_runtime_check_targets: ${linux_runtime_check_targets}"
linux_runtimes=$(echo ${linux_runtimes_to_test} | sort | uniq)
-echo "debug linux_runtimes: ${linux_runtimes}"
windows_projects_to_test=$(exclude-windows $(compute-projects-to-test
${modified_projects}))
windows_check_targets=$(check-targets ${windows_projects_to_test} | sort |
uniq)
>From cac43abbbc829e8bafa06cca4de68718ea4f3360 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:50:34 +0300
Subject: [PATCH 10/10] Remove `set -x`
---
.ci/generate-buildkite-pipeline-premerge | 1 -
1 file changed, 1 deletion(-)
diff --git a/.ci/generate-buildkite-pipeline-premerge
b/.ci/generate-buildkite-pipeline-premerge
index 06474323c5b12..aaccdf0d4287d 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -19,7 +19,6 @@
set -eu
set -o pipefail
-set -x
# Environment variables script works with:
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)
nux_projects_to_test} | sort | uniq)
linux_projects=$(add-dependencies ${linux_projects_to_test} | sort | uniq)
linux_runtimes_to_test=$(compute-runtimes-to-test ${linux_projects_to_test})
+echo "debug linux_runtimes_to_test: ${linux_runtimes_to_test}"
linux_runtime_check_targets=$(check-targets ${linux_runtimes_to_test} | sort |
uniq)
+echo "debug linux_runtime_check_targets: ${linux_runtime_check_targets}"
linux_runtimes=$(echo ${linux_runtimes_to_test} | sort | uniq)
+echo "debug linux_runtimes: ${linux_runtimes}"
windows_projects_to_test=$(exclude-windows $(compute-projects-to-test
${modified_projects}))
windows_check_targets=$(check-targets ${windows_projects_to_test} | sort |
uniq)
>From 5d56a7e54d7e22be3337d571ac640f353ebc5ac7 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:37:50 +0300
Subject: [PATCH 7/9] Re-enable `set -x`
---
.ci/generate-buildkite-pipeline-premerge | 1 +
1 file changed, 1 insertion(+)
diff --git a/.ci/generate-buildkite-pipeline-premerge
b/.ci/generate-buildkite-pipeline-premerge
index e286d1e2664c8..c4885103ecbd4 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -19,6 +19,7 @@
set -eu
set -o pipefail
+set -x
# Environment variables script works with:
>From 67ed5ce731f7a359c6cccb85b111e6fe71118c72 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:46:23 +0300
Subject: [PATCH 8/9] Removed unncessary echo
---
.ci/generate-buildkite-pipeline-premerge | 1 -
1 file changed, 1 deletion(-)
diff --git a/.ci/generate-buildkite-pipeline-premerge
b/.ci/generate-buildkite-pipeline-premerge
index c4885103ecbd4..e628630257cb3 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -89,7 +89,6 @@ function compute-projects-to-test() {
function compute-runtimes-to-test() {
projects=${@}
for project in ${projects}; do
-echo "${project}"
case ${project} in
clang)
for p in libcxx libcxxabi libunwind; do
>From 6cd1e08f26e8d229b9505daca594abed3500fe20 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:49:35 +0300
Subject: [PATCH 9/9] Remove debug echoes
---
.ci/generate-buildkite-pipeline-premerge | 3 ---
1 file changed, 3 deletions(-)
diff --git a/.ci/generate-buildkite-pipeline-premerge
b/.ci/generate-buildkite-pipeline-premerge
index e628630257cb3..06474323c5b12 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -258,11 +258,8 @@ linux_check_targets=$(check-targets
${linux_projects_to_test} | sort | uniq)
linux_projects=$(add-dependencies ${linux_projects_to_test} | sort | uniq)
linux_runtimes_to_test=$(compute-runtimes-to-test ${linux_projects_to_test})
-echo "debug linux_runtimes_to_test: ${linux_runtimes_to_test}"
linux_runtime_check_targets=$(check-targets ${linux_runtimes_to_test} | sort |
uniq)
-echo "debug linux_runtime_check_targets: ${linux_runtime_check_targets}"
linux_runtimes=$(echo ${linux_runtimes_to_test} | sort | uniq)
-echo "debug linux_runtimes: ${linux_runtimes}"
windows_projects_to_test=$(exclude-windows $(compute-projects-to-test
${modified_projects}))
windows_check_targets=$(check-targets ${windows_projects_to_test} | sort |
uniq)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)
nux_projects_to_test} | sort | uniq)
linux_projects=$(add-dependencies ${linux_projects_to_test} | sort | uniq)
linux_runtimes_to_test=$(compute-runtimes-to-test ${linux_projects_to_test})
+echo "debug linux_runtimes_to_test: ${linux_runtimes_to_test}"
linux_runtime_check_targets=$(check-targets ${linux_runtimes_to_test} | sort |
uniq)
+echo "debug linux_runtime_check_targets: ${linux_runtime_check_targets}"
linux_runtimes=$(echo ${linux_runtimes_to_test} | sort | uniq)
+echo "debug linux_runtimes: ${linux_runtimes}"
windows_projects_to_test=$(exclude-windows $(compute-projects-to-test
${modified_projects}))
windows_check_targets=$(check-targets ${windows_projects_to_test} | sort |
uniq)
>From 5d56a7e54d7e22be3337d571ac640f353ebc5ac7 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:37:50 +0300
Subject: [PATCH 7/8] Re-enable `set -x`
---
.ci/generate-buildkite-pipeline-premerge | 1 +
1 file changed, 1 insertion(+)
diff --git a/.ci/generate-buildkite-pipeline-premerge
b/.ci/generate-buildkite-pipeline-premerge
index e286d1e2664c8..c4885103ecbd4 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -19,6 +19,7 @@
set -eu
set -o pipefail
+set -x
# Environment variables script works with:
>From 67ed5ce731f7a359c6cccb85b111e6fe71118c72 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:46:23 +0300
Subject: [PATCH 8/8] Removed unncessary echo
---
.ci/generate-buildkite-pipeline-premerge | 1 -
1 file changed, 1 deletion(-)
diff --git a/.ci/generate-buildkite-pipeline-premerge
b/.ci/generate-buildkite-pipeline-premerge
index c4885103ecbd4..e628630257cb3 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -89,7 +89,6 @@ function compute-projects-to-test() {
function compute-runtimes-to-test() {
projects=${@}
for project in ${projects}; do
-echo "${project}"
case ${project} in
clang)
for p in libcxx libcxxabi libunwind; do
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[jenkinsci/credentials-plugin]
Branch: refs/heads/dependabot/maven/io.jenkins.tools.bom-bom-2.426.x-3056.v53343b_a_b_a_850 Home: https://github.com/jenkinsci/credentials-plugin To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/credentials-plugin/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/credentials-plugin/push/refs/heads/dependabot/maven/io.jenkins.tools.bom-bom-2.426.x-3056.v53343b_a_b_a_850/7bdd35-00%40github.com.
[jenkinsci/credentials-plugin] ceecb9: Bump io.jenkins.tools.bom:bom-2.426.x
Branch: refs/heads/dependabot/maven/io.jenkins.tools.bom-bom-2.426.x-3080.vfa_b_e4a_a_39b_44 Home: https://github.com/jenkinsci/credentials-plugin Commit: ceecb988afea1082d4514e24dbdc01221caa6882 https://github.com/jenkinsci/credentials-plugin/commit/ceecb988afea1082d4514e24dbdc01221caa6882 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: 2024-05-24 (Fri, 24 May 2024) Changed paths: M pom.xml Log Message: --- Bump io.jenkins.tools.bom:bom-2.426.x Bumps [io.jenkins.tools.bom:bom-2.426.x](https://github.com/jenkinsci/bom) from 2961.v1f472390972e to 3080.vfa_b_e4a_a_39b_44. - [Release notes](https://github.com/jenkinsci/bom/releases) - [Commits](https://github.com/jenkinsci/bom/commits) --- updated-dependencies: - dependency-name: io.jenkins.tools.bom:bom-2.426.x dependency-type: direct:production ... Signed-off-by: dependabot[bot] To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/credentials-plugin/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/credentials-plugin/push/refs/heads/dependabot/maven/io.jenkins.tools.bom-bom-2.426.x-3080.vfa_b_e4a_a_39b_44/00-ceecb9%40github.com.
[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)
nux_projects_to_test} | sort | uniq)
linux_projects=$(add-dependencies ${linux_projects_to_test} | sort | uniq)
linux_runtimes_to_test=$(compute-runtimes-to-test ${linux_projects_to_test})
+echo "debug linux_runtimes_to_test: ${linux_runtimes_to_test}"
linux_runtime_check_targets=$(check-targets ${linux_runtimes_to_test} | sort |
uniq)
+echo "debug linux_runtime_check_targets: ${linux_runtime_check_targets}"
linux_runtimes=$(echo ${linux_runtimes_to_test} | sort | uniq)
+echo "debug linux_runtimes: ${linux_runtimes}"
windows_projects_to_test=$(exclude-windows $(compute-projects-to-test
${modified_projects}))
windows_check_targets=$(check-targets ${windows_projects_to_test} | sort |
uniq)
>From 5d56a7e54d7e22be3337d571ac640f353ebc5ac7 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:37:50 +0300
Subject: [PATCH 7/7] Re-enable `set -x`
---
.ci/generate-buildkite-pipeline-premerge | 1 +
1 file changed, 1 insertion(+)
diff --git a/.ci/generate-buildkite-pipeline-premerge
b/.ci/generate-buildkite-pipeline-premerge
index e286d1e2664c8..c4885103ecbd4 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -19,6 +19,7 @@
set -eu
set -o pipefail
+set -x
# Environment variables script works with:
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [flang] [libcxx] [lld] [lldb] [llvm] [mlir] [openmp] [BOLT] Fix unused variable warning (PR #93253)
Timm =?utf-8?q?Bäder?= ,Sven van Haastregt ,Kiran Chandramohan ,Vyacheslav Levytskyy ,Alexey Bataev ,Simon Pilgrim ,Simon Pilgrim ,Shilei Tian ,Matheus Izvekov ,Teresa Johnson ,Matheus Izvekov ,Timm =?utf-8?q?Bäder?= ,Simon Pilgrim , Timm =?utf-8?q?Bäder?= ,Daniel Paoliello ,Shih-Po Hung ,Jacques Pienaar ,Simon Pilgrim ,Brendan Dahl ,tyb0807 ,Daniel Grumberg ,Christopher Bate ,Kazu Hirata ,Craig Topper ,Hui ,Ramkumar Ramachandra ,Peter Klausler <35819229+klaus...@users.noreply.github.com> Message-ID: In-Reply-To: https://github.com/sayhaan closed https://github.com/llvm/llvm-project/pull/93253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[Lldb-commits] [clang] [flang] [libcxx] [lld] [lldb] [llvm] [mlir] [openmp] [BOLT] Fix unused variable warning (PR #93253)
Timm =?utf-8?q?Bäder?= ,Sven van Haastregt ,Kiran Chandramohan ,Vyacheslav Levytskyy ,Alexey Bataev ,Simon Pilgrim ,Simon Pilgrim ,Shilei Tian ,Matheus Izvekov ,Teresa Johnson ,Matheus Izvekov ,Timm =?utf-8?q?Bäder?= ,Simon Pilgrim , Timm =?utf-8?q?Bäder?= ,Daniel Paoliello ,Shih-Po Hung ,Jacques Pienaar ,Simon Pilgrim ,Brendan Dahl ,tyb0807 ,Daniel Grumberg ,Christopher Bate ,Kazu Hirata ,Craig Topper ,Hui ,Ramkumar Ramachandra ,Peter Klausler <35819229+klaus...@users.noreply.github.com> Message-ID: In-Reply-To: https://github.com/sayhaan closed https://github.com/llvm/llvm-project/pull/93253 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)
nux_projects_to_test} | sort | uniq)
linux_projects=$(add-dependencies ${linux_projects_to_test} | sort | uniq)
linux_runtimes_to_test=$(compute-runtimes-to-test ${linux_projects_to_test})
+echo "debug linux_runtimes_to_test: ${linux_runtimes_to_test}"
linux_runtime_check_targets=$(check-targets ${linux_runtimes_to_test} | sort |
uniq)
+echo "debug linux_runtime_check_targets: ${linux_runtime_check_targets}"
linux_runtimes=$(echo ${linux_runtimes_to_test} | sort | uniq)
+echo "debug linux_runtimes: ${linux_runtimes}"
windows_projects_to_test=$(exclude-windows $(compute-projects-to-test
${modified_projects}))
windows_check_targets=$(check-targets ${windows_projects_to_test} | sort |
uniq)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)
S="std=c++26" \
+ -DLIBCXXABI_TEST_PARAMS="std=c++26"
+
+ echo "--- ninja runtimes C++26"
+
+ ninja -vC "${RUNTIMES_BUILD_DIR}" ${runtime_targets}
+
+ echo "--- cmake runtimes clang modules"
+
+ rm -rf "${RUNTIMES_BUILD_DIR}"
+ cmake -S "${MONOREPO_ROOT}/runtimes" -B "${RUNTIMES_BUILD_DIR}" -GNinja \
+ -DCMAKE_C_COMPILER="${BUILD_DIR}/bin/clang" \
+ -DCMAKE_CXX_COMPILER="${BUILD_DIR}/bin/clang++" \
+ -DLLVM_ENABLE_RUNTIMES="${runtimes}" \
+ -DLIBCXX_CXX_ABI=libcxxabi \
+ -DCMAKE_BUILD_TYPE=RelWithDebInfo \
+ -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}" \
+ -DLIBCXX_TEST_PARAMS="enable_modules=clang" \
+ -DLIBCXXABI_TEST_PARAMS="enable_modules=clang"
+
+ echo "--- ninja runtimes clang modules"
+
+ ninja -vC "${RUNTIMES_BUILD_DIR}" ${runtime_targets}
+fi
>From 5be9db11843c12f9a7e8064e68bd3218c7ad3855 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:17:14 +0300
Subject: [PATCH 2/5] Add missing semicolons
---
.ci/generate-buildkite-pipeline-premerge | 1 +
1 file changed, 1 insertion(+)
diff --git a/.ci/generate-buildkite-pipeline-premerge
b/.ci/generate-buildkite-pipeline-premerge
index d563fa6a01120..8d55239254cea 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -94,6 +94,7 @@ function compute-runtimes-to-test() {
for p in libcxx libcxxabi libunwind; do
echo $p
done
+;;
*)
# Nothing to do
;;
>From d2ce8f24442e25117499499ac6b3f7c4b586f0aa Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:21:49 +0300
Subject: [PATCH 3/5] Make a test change in clang
---
clang/examples/PrintFunctionNames/PrintFunctionNames.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang/examples/PrintFunctionNames/PrintFunctionNames.cpp
b/clang/examples/PrintFunctionNames/PrintFunctionNames.cpp
index 6509a6440e12d..b2b785b87c25c 100644
--- a/clang/examples/PrintFunctionNames/PrintFunctionNames.cpp
+++ b/clang/examples/PrintFunctionNames/PrintFunctionNames.cpp
@@ -72,7 +72,7 @@ class PrintFunctionsConsumer : public ASTConsumer {
*sema.LateParsedTemplateMap.find(FD)->second;
sema.LateTemplateParser(sema.OpaqueParser, LPT);
llvm::errs() << "late-parsed-decl: \"" << FD->getNameAsString() <<
"\"\n";
-}
+}
}
};
>From a585ece606204a9623cca70ba73f68d5796de8e5 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:27:14 +0300
Subject: [PATCH 4/5] Add `set -x` to pipeline generating script
---
.ci/generate-buildkite-pipeline-premerge | 1 +
1 file changed, 1 insertion(+)
diff --git a/.ci/generate-buildkite-pipeline-premerge
b/.ci/generate-buildkite-pipeline-premerge
index 8d55239254cea..16bcd34422ce1 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -19,6 +19,7 @@
set -eu
set -o pipefail
+set -x
# Environment variables script works with:
>From 9160288e92d0556a3ca5f45d82c97348ed24f248 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:29:26 +0300
Subject: [PATCH 5/5] Add missing echo
---
.ci/generate-buildkite-pipeline-premerge | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.ci/generate-buildkite-pipeline-premerge
b/.ci/generate-buildkite-pipeline-premerge
index 16bcd34422ce1..fac6d6bdc9d41 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -260,7 +260,7 @@ linux_projects=$(add-dependencies ${linux_projects_to_test}
| sort | uniq)
linux_runtimes_to_test=$(compute-runtimes-to-test ${linux_projects_to_test})
linux_runtime_check_targets=$(check-targets ${linux_runtimes_to_test} | sort |
uniq)
-linux_runtimes=$(${linux_runtimes_to_test} | sort | uniq)
+linux_runtimes=$(echo ${linux_runtimes_to_test} | sort | uniq)
windows_projects_to_test=$(exclude-windows $(compute-projects-to-test
${modified_projects}))
windows_check_targets=$(check-targets ${windows_projects_to_test} | sort |
uniq)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)
S="std=c++26" \
+ -DLIBCXXABI_TEST_PARAMS="std=c++26"
+
+ echo "--- ninja runtimes C++26"
+
+ ninja -vC "${RUNTIMES_BUILD_DIR}" ${runtime_targets}
+
+ echo "--- cmake runtimes clang modules"
+
+ rm -rf "${RUNTIMES_BUILD_DIR}"
+ cmake -S "${MONOREPO_ROOT}/runtimes" -B "${RUNTIMES_BUILD_DIR}" -GNinja \
+ -DCMAKE_C_COMPILER="${BUILD_DIR}/bin/clang" \
+ -DCMAKE_CXX_COMPILER="${BUILD_DIR}/bin/clang++" \
+ -DLLVM_ENABLE_RUNTIMES="${runtimes}" \
+ -DLIBCXX_CXX_ABI=libcxxabi \
+ -DCMAKE_BUILD_TYPE=RelWithDebInfo \
+ -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}" \
+ -DLIBCXX_TEST_PARAMS="enable_modules=clang" \
+ -DLIBCXXABI_TEST_PARAMS="enable_modules=clang"
+
+ echo "--- ninja runtimes clang modules"
+
+ ninja -vC "${RUNTIMES_BUILD_DIR}" ${runtime_targets}
+fi
>From 5be9db11843c12f9a7e8064e68bd3218c7ad3855 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:17:14 +0300
Subject: [PATCH 2/4] Add missing semicolons
---
.ci/generate-buildkite-pipeline-premerge | 1 +
1 file changed, 1 insertion(+)
diff --git a/.ci/generate-buildkite-pipeline-premerge
b/.ci/generate-buildkite-pipeline-premerge
index d563fa6a01120..8d55239254cea 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -94,6 +94,7 @@ function compute-runtimes-to-test() {
for p in libcxx libcxxabi libunwind; do
echo $p
done
+;;
*)
# Nothing to do
;;
>From d2ce8f24442e25117499499ac6b3f7c4b586f0aa Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:21:49 +0300
Subject: [PATCH 3/4] Make a test change in clang
---
clang/examples/PrintFunctionNames/PrintFunctionNames.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang/examples/PrintFunctionNames/PrintFunctionNames.cpp
b/clang/examples/PrintFunctionNames/PrintFunctionNames.cpp
index 6509a6440e12d..b2b785b87c25c 100644
--- a/clang/examples/PrintFunctionNames/PrintFunctionNames.cpp
+++ b/clang/examples/PrintFunctionNames/PrintFunctionNames.cpp
@@ -72,7 +72,7 @@ class PrintFunctionsConsumer : public ASTConsumer {
*sema.LateParsedTemplateMap.find(FD)->second;
sema.LateTemplateParser(sema.OpaqueParser, LPT);
llvm::errs() << "late-parsed-decl: \"" << FD->getNameAsString() <<
"\"\n";
-}
+}
}
};
>From a585ece606204a9623cca70ba73f68d5796de8e5 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:27:14 +0300
Subject: [PATCH 4/4] Add `set -x` to pipeline generating script
---
.ci/generate-buildkite-pipeline-premerge | 1 +
1 file changed, 1 insertion(+)
diff --git a/.ci/generate-buildkite-pipeline-premerge
b/.ci/generate-buildkite-pipeline-premerge
index 8d55239254cea..16bcd34422ce1 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -19,6 +19,7 @@
set -eu
set -o pipefail
+set -x
# Environment variables script works with:
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[jenkinsci/saml-plugin] e8e36d: chore(deps): bump the pac4j group with 2 updates
Branch: refs/heads/dependabot/maven/pac4j-94c581520f Home: https://github.com/jenkinsci/saml-plugin Commit: e8e36dae6e0ff47f0f7ac0f7e8755ef377c9b280 https://github.com/jenkinsci/saml-plugin/commit/e8e36dae6e0ff47f0f7ac0f7e8755ef377c9b280 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: 2024-05-24 (Fri, 24 May 2024) Changed paths: M pom.xml Log Message: --- chore(deps): bump the pac4j group with 2 updates Bumps the pac4j group with 2 updates: [org.pac4j:pac4j-saml](https://github.com/pac4j/pac4j) and [org.pac4j:pac4j-javaee](https://github.com/pac4j/pac4j). Updates `org.pac4j:pac4j-saml` from 5.7.2 to 6.0.3 - [Commits](https://github.com/pac4j/pac4j/compare/pac4j-parent-5.7.2...pac4j-parent-6.0.3) Updates `org.pac4j:pac4j-javaee` from 5.7.2 to 6.0.3 - [Commits](https://github.com/pac4j/pac4j/compare/pac4j-parent-5.7.2...pac4j-parent-6.0.3) --- updated-dependencies: - dependency-name: org.pac4j:pac4j-saml dependency-type: direct:production update-type: version-update:semver-major dependency-group: pac4j - dependency-name: org.pac4j:pac4j-javaee dependency-type: direct:production update-type: version-update:semver-major dependency-group: pac4j ... Signed-off-by: dependabot[bot] To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/saml-plugin/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/saml-plugin/push/refs/heads/dependabot/maven/pac4j-94c581520f/00-e8e36d%40github.com.
[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)
S="std=c++26" \
+ -DLIBCXXABI_TEST_PARAMS="std=c++26"
+
+ echo "--- ninja runtimes C++26"
+
+ ninja -vC "${RUNTIMES_BUILD_DIR}" ${runtime_targets}
+
+ echo "--- cmake runtimes clang modules"
+
+ rm -rf "${RUNTIMES_BUILD_DIR}"
+ cmake -S "${MONOREPO_ROOT}/runtimes" -B "${RUNTIMES_BUILD_DIR}" -GNinja \
+ -DCMAKE_C_COMPILER="${BUILD_DIR}/bin/clang" \
+ -DCMAKE_CXX_COMPILER="${BUILD_DIR}/bin/clang++" \
+ -DLLVM_ENABLE_RUNTIMES="${runtimes}" \
+ -DLIBCXX_CXX_ABI=libcxxabi \
+ -DCMAKE_BUILD_TYPE=RelWithDebInfo \
+ -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}" \
+ -DLIBCXX_TEST_PARAMS="enable_modules=clang" \
+ -DLIBCXXABI_TEST_PARAMS="enable_modules=clang"
+
+ echo "--- ninja runtimes clang modules"
+
+ ninja -vC "${RUNTIMES_BUILD_DIR}" ${runtime_targets}
+fi
>From 5be9db11843c12f9a7e8064e68bd3218c7ad3855 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:17:14 +0300
Subject: [PATCH 2/3] Add missing semicolons
---
.ci/generate-buildkite-pipeline-premerge | 1 +
1 file changed, 1 insertion(+)
diff --git a/.ci/generate-buildkite-pipeline-premerge
b/.ci/generate-buildkite-pipeline-premerge
index d563fa6a01120..8d55239254cea 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -94,6 +94,7 @@ function compute-runtimes-to-test() {
for p in libcxx libcxxabi libunwind; do
echo $p
done
+;;
*)
# Nothing to do
;;
>From d2ce8f24442e25117499499ac6b3f7c4b586f0aa Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:21:49 +0300
Subject: [PATCH 3/3] Make a test change in clang
---
clang/examples/PrintFunctionNames/PrintFunctionNames.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang/examples/PrintFunctionNames/PrintFunctionNames.cpp
b/clang/examples/PrintFunctionNames/PrintFunctionNames.cpp
index 6509a6440e12d..b2b785b87c25c 100644
--- a/clang/examples/PrintFunctionNames/PrintFunctionNames.cpp
+++ b/clang/examples/PrintFunctionNames/PrintFunctionNames.cpp
@@ -72,7 +72,7 @@ class PrintFunctionsConsumer : public ASTConsumer {
*sema.LateParsedTemplateMap.find(FD)->second;
sema.LateTemplateParser(sema.OpaqueParser, LPT);
llvm::errs() << "late-parsed-decl: \"" << FD->getNameAsString() <<
"\"\n";
-}
+}
}
};
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [clang] Add tanf16 builtin and support for tan constrained intrinsic (PR #93314)
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/93314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92492)
"GNU" == note.info.n_name && + note.data.ValidOffsetForDataOfSize(0, note.info.n_descsz)) +return UUID(note.data.GetData().take_front(note.info.n_descsz)); } } return invalid_uuid; ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[clang] [llvm] [clang] Add tanf16 builtin and support for tan constrained intrinsic (PR #93314)
@@ -183,6 +183,14 @@ void foo(double *d, float f, float *fp, long double *l,
int *i, const char *c, _
// CHECK: call x86_fp80 @llvm.experimental.constrained.sqrt.f80(x86_fp80
%{{.*}}, metadata !"round.tonearest", metadata !"fpexcept.strict")
// CHECK: call fp128 @llvm.experimental.constrained.sqrt.f128(fp128 %{{.*}},
metadata !"round.tonearest", metadata !"fpexcept.strict")
+__builtin_tan(f);__builtin_tanf(f); __builtin_tanl(f);
__builtin_tanf128(f);
damyanp wrote:
super nit: it looks like the other `f` prefixed ones all line up to the same
column, apart from this new one.
https://github.com/llvm/llvm-project/pull/93314
___________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [clang] Add tanf16 builtin and support for tan constrained intrinsic (PR #93314)
https://github.com/damyanp approved this pull request. IMO it'd be good to have a bit more context in the commit description about why this is being done. If you follow the breadcrumbs from the issue to the thread in the PR I think you can put it together, but a more local summary might be helpful. https://github.com/llvm/llvm-project/pull/93314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [clang] Add tanf16 builtin and support for tan constrained intrinsic (PR #93314)
https://github.com/damyanp edited https://github.com/llvm/llvm-project/pull/93314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[jenkinsci/parameterized-trigger-plugin]
Branch: refs/heads/dependabot/maven/io.jenkins.tools.bom-bom-2.426.x-3080.vfa_b_e4a_a_39b_44 Home: https://github.com/jenkinsci/parameterized-trigger-plugin To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/parameterized-trigger-plugin/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/parameterized-trigger-plugin/push/refs/heads/dependabot/maven/io.jenkins.tools.bom-bom-2.426.x-3080.vfa_b_e4a_a_39b_44/d120c2-00%40github.com.
[jenkinsci/parameterized-trigger-plugin] 17eda6: Bump io.jenkins.tools.bom:bom-2.426.x (#385)
Branch: refs/heads/master Home: https://github.com/jenkinsci/parameterized-trigger-plugin Commit: 17eda62c0375bc26233d67b2210b81fb6a1acfae https://github.com/jenkinsci/parameterized-trigger-plugin/commit/17eda62c0375bc26233d67b2210b81fb6a1acfae Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: 2024-05-24 (Fri, 24 May 2024) Changed paths: M pom.xml Log Message: --- Bump io.jenkins.tools.bom:bom-2.426.x (#385) To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/parameterized-trigger-plugin/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/parameterized-trigger-plugin/push/refs/heads/master/635e7b-17eda6%40github.com.
[jenkinsci/ivy-plugin] c150cb: Bump io.jenkins.tools.bom:bom-2.426.x (#101)
Branch: refs/heads/master Home: https://github.com/jenkinsci/ivy-plugin Commit: c150cb1a53cd1ba2b521b76ca434e386a8b34573 https://github.com/jenkinsci/ivy-plugin/commit/c150cb1a53cd1ba2b521b76ca434e386a8b34573 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: 2024-05-24 (Fri, 24 May 2024) Changed paths: M pom.xml Log Message: --- Bump io.jenkins.tools.bom:bom-2.426.x (#101) To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/ivy-plugin/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/ivy-plugin/push/refs/heads/master/180fec-c150cb%40github.com.
[jenkinsci/ivy-plugin]
Branch: refs/heads/dependabot/maven/io.jenkins.tools.bom-bom-2.426.x-3080.vfa_b_e4a_a_39b_44 Home: https://github.com/jenkinsci/ivy-plugin To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/ivy-plugin/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/ivy-plugin/push/refs/heads/dependabot/maven/io.jenkins.tools.bom-bom-2.426.x-3080.vfa_b_e4a_a_39b_44/10ccd2-00%40github.com.
[jenkinsci/configurationslicing-plugin]
Branch: refs/heads/dependabot/maven/io.jenkins.tools.bom-bom-2.426.x-3080.vfa_b_e4a_a_39b_44 Home: https://github.com/jenkinsci/configurationslicing-plugin To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/configurationslicing-plugin/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/configurationslicing-plugin/push/refs/heads/dependabot/maven/io.jenkins.tools.bom-bom-2.426.x-3080.vfa_b_e4a_a_39b_44/0dbfea-00%40github.com.
[jenkinsci/configurationslicing-plugin] c3e963: chore(deps): bump io.jenkins.tools.bom:bom-2.426.x...
Branch: refs/heads/master Home: https://github.com/jenkinsci/configurationslicing-plugin Commit: c3e963d3724fcacdc6d6ce870ca818fac7ee9f3f https://github.com/jenkinsci/configurationslicing-plugin/commit/c3e963d3724fcacdc6d6ce870ca818fac7ee9f3f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: 2024-05-24 (Fri, 24 May 2024) Changed paths: M pom.xml Log Message: --- chore(deps): bump io.jenkins.tools.bom:bom-2.426.x (#259) To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/configurationslicing-plugin/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/configurationslicing-plugin/push/refs/heads/master/aa74a9-c3e963%40github.com.
[jenkinsci/docker-plugin] 057a51: Bump io.jenkins.tools.bom:bom-2.440.x (#1078)
Branch: refs/heads/master Home: https://github.com/jenkinsci/docker-plugin Commit: 057a518471d8f4277b6e492047c72fa8d8d4741d https://github.com/jenkinsci/docker-plugin/commit/057a518471d8f4277b6e492047c72fa8d8d4741d Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: 2024-05-24 (Fri, 24 May 2024) Changed paths: M pom.xml Log Message: --- Bump io.jenkins.tools.bom:bom-2.440.x (#1078) To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/docker-plugin/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/docker-plugin/push/refs/heads/master/8aa4c2-057a51%40github.com.
[clang] [clang-format]: Annotate colons found in inline assembly (PR #92617)
@@ -1426,12 +1428,9 @@ class AnnotatingParser {
// the colon are passed as macro arguments.
Tok->setType(TT_ObjCMethodExpr);
} else if (Contexts.back().ContextKind == tok::l_paren &&
- !Line.InPragmaDirective) {
-if (Style.isTableGen() && Contexts.back().IsTableGenDAGArg) {
- Tok->setType(TT_TableGenDAGArgListColon);
- break;
-}
-Tok->setType(TT_InlineASMColon);
+ !Line.InPragmaDirective && Style.isTableGen() &&
+ Contexts.back().IsTableGenDAGArg) {
+Tok->setType(TT_TableGenDAGArgListColon);
gedare wrote:
done, tests pass. @hnakamura5 any objections?
https://github.com/llvm/llvm-project/pull/92617/files#diff-f7c46dd11ab8379e248666096236ccfb4966e050f6494588cb9484c0e29d4e3dL1428
https://github.com/llvm/llvm-project/pull/92617
___________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-format]: Annotate colons found in inline assembly (PR #92617)
; Tokens;
@@ -1500,7 +1500,7 @@ TEST_F(TokenAnnotatorTest, UnderstandsAsm) {
EXPECT_TOKEN(Tokens[7], tok::r_brace, TT_InlineASMBrace);
Tokens = annotate("__asm__ volatile (\n"
-"a:\n"
+"\"a\":\n"
": x\n"
":);");
ASSERT_EQ(Tokens.size(), 11u) << Tokens;
@@ -1508,6 +1508,71 @@ TEST_F(TokenAnnotatorTest, UnderstandsAsm) {
EXPECT_TOKEN(Tokens[4], tok::colon, TT_InlineASMColon);
EXPECT_TOKEN(Tokens[5], tok::colon, TT_InlineASMColon);
EXPECT_TOKEN(Tokens[7], tok::colon, TT_InlineASMColon);
+
+ Tokens = annotate("asm volatile (\n"
+"\"a\":\n"
+": x\n"
+":);");
+ ASSERT_EQ(Tokens.size(), 11u) << Tokens;
+ EXPECT_TOKEN(Tokens[0], tok::kw_asm, TT_Unknown);
+ EXPECT_TOKEN(Tokens[4], tok::colon, TT_InlineASMColon);
+ EXPECT_TOKEN(Tokens[5], tok::colon, TT_InlineASMColon);
+ EXPECT_TOKEN(Tokens[7], tok::colon, TT_InlineASMColon);
+
+ Tokens = annotate("__asm__ volatile (\n"
+"\"a_label:\"\n"
+":\n"
+": x\n"
+":);");
+ ASSERT_EQ(Tokens.size(), 11u) << Tokens;
+ EXPECT_TOKEN(Tokens[0], tok::kw_asm, TT_Unknown);
+ EXPECT_TOKEN(Tokens[4], tok::colon, TT_InlineASMColon);
+ EXPECT_TOKEN(Tokens[5], tok::colon, TT_InlineASMColon);
+ EXPECT_TOKEN(Tokens[7], tok::colon, TT_InlineASMColon);
+
+ Tokens = annotate("asm volatile (\n"
+"\"a_label:\"\n"
+":\n"
+": x\n"
+":);");
+ ASSERT_EQ(Tokens.size(), 11u) << Tokens;
+ EXPECT_TOKEN(Tokens[0], tok::kw_asm, TT_Unknown);
+ EXPECT_TOKEN(Tokens[4], tok::colon, TT_InlineASMColon);
+ EXPECT_TOKEN(Tokens[5], tok::colon, TT_InlineASMColon);
+ EXPECT_TOKEN(Tokens[7], tok::colon, TT_InlineASMColon);
+
+ Tokens = annotate("__asm__ volatile (\n"
+"\"a_label:\"\n"
+"\"a b c(%%x)\"\n"
+":\n"
+": x\n"
+":);");
+ ASSERT_EQ(Tokens.size(), 12u) << Tokens;
+ EXPECT_TOKEN(Tokens[0], tok::kw_asm, TT_Unknown);
+ EXPECT_TOKEN(Tokens[5], tok::colon, TT_InlineASMColon);
+ EXPECT_TOKEN(Tokens[6], tok::colon, TT_InlineASMColon);
+ EXPECT_TOKEN(Tokens[8], tok::colon, TT_InlineASMColon);
+
+ Tokens = annotate("__asm__ volatile (\n"
+"\"insn\"\n"
+": \"=r\" (var1), \"=\" (value)\n"
+":\n"
+": \"memory\");");
+ ASSERT_EQ(Tokens.size(), 20u) << Tokens;
+ EXPECT_TOKEN(Tokens[0], tok::kw_asm, TT_Unknown);
+ EXPECT_TOKEN(Tokens[4], tok::colon, TT_InlineASMColon);
+ EXPECT_TOKEN(Tokens[14], tok::colon, TT_InlineASMColon);
+ EXPECT_TOKEN(Tokens[15], tok::colon, TT_InlineASMColon);
+
+ Tokens = annotate("__asm__ volatile (\n"
+"\"ldr r1, [r0, %%[sym]]\"\n"
+":\n"
+": [sym] \"J\" (a(, ))\n"
+");");
+ ASSERT_EQ(Tokens.size(), 21u) << Tokens;
+ EXPECT_TOKEN(Tokens[0], tok::kw_asm, TT_Unknown);
+ EXPECT_TOKEN(Tokens[4], tok::colon, TT_InlineASMColon);
+ EXPECT_TOKEN(Tokens[5], tok::colon, TT_InlineASMColon);
}
TEST_F(TokenAnnotatorTest, UnderstandsObjCBlock) {
>From 84882016f666fe736fec55815e88ac297b59452f Mon Sep 17 00:00:00 2001
From: Gedare Bloom
Date: Fri, 24 May 2024 09:46:41 -0600
Subject: [PATCH 3/3] TokenAnnotator: remove last block in consumeToken colon
---
clang/lib/Format/TokenAnnotator.cpp | 4
1 file changed, 4 deletions(-)
diff --git a/clang/lib/Format/TokenAnnotator.cpp
b/clang/lib/Format/TokenAnnotator.cpp
index bbf791c44d775..6378c224d847c 100644
--- a/clang/lib/Format/TokenAnnotator.cpp
+++ b/clang/lib/Format/TokenAnnotator.cpp
@@ -1427,10 +1427,6 @@ class AnnotatingParser {
// This handles a special macro in ObjC code where selectors including
// the colon are passed as macro arguments.
Tok->setType(TT_ObjCMethodExpr);
- } else if (Contexts.back().ContextKind == tok::l_paren &&
- !Line.InPragmaDirective && Style.isTableGen() &&
- Contexts.back().IsTableGenDAGArg) {
-Tok->setType(TT_TableGenDAGArgListColon);
}
break;
case tok::pipe:
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)
https://github.com/yronglin deleted https://github.com/llvm/llvm-project/pull/90574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [clang] Add tanf16 builtin and support for tan constrained intrinsic (PR #93314)
: Fri, 24 May 2024 11:42:58 -0400 Subject: [PATCH 2/2] update clang format --- clang/lib/CodeGen/CGBuiltin.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/clang/lib/CodeGen/CGBuiltin.cpp b/clang/lib/CodeGen/CGBuiltin.cpp index 7650a006fffb1..443ed4c025e93 100644 --- a/clang/lib/CodeGen/CGBuiltin.cpp +++ b/clang/lib/CodeGen/CGBuiltin.cpp @@ -2931,9 +2931,8 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, case Builtin::BI__builtin_tanf16: case Builtin::BI__builtin_tanl: case Builtin::BI__builtin_tanf128: - return RValue::get(emitUnaryMaybeConstrainedFPBuiltin(*this, E, - Intrinsic::tan, - Intrinsic::experimental_constrained_tan)); + return RValue::get(emitUnaryMaybeConstrainedFPBuiltin( + *this, E, Intrinsic::tan, Intrinsic::experimental_constrained_tan)); case Builtin::BItrunc: case Builtin::BItruncf: ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)
rogram=program, port=int(port), sourceInitFile=True,
expectFailure=True
)
if not (response and response["success"]):
self.assertFalse(
diff --git a/lldb/tools/lldb-dap/lldb-dap.cpp b/lldb/tools/lldb-dap/lldb-dap.cpp
index a403e7ae26bfd..c9cd6ffe1db43 100644
--- a/lldb/tools/lldb-dap/lldb-dap.cpp
+++ b/lldb/tools/lldb-dap/lldb-dap.cpp
@@ -758,7 +758,7 @@ void request_attach(const llvm::json::Object ) {
(port != LLDB_INVALID_PORT_NUMBER)) {
// If both pid and port numbers are specified.
error.SetErrorString("The user can't specify both pid and port");
- } else if ((port != LLDB_INVALID_PORT_NUMBER) && (port < UINT16_MAX)) {
+ } else if (port != LLDB_INVALID_PORT_NUMBER) {
// If port is specified and pid is not.
lldb::SBListener listener = g_dap.debugger.GetListener();
>From 5590afc46aff9765f314139bbf4a446ca0f21b0c Mon Sep 17 00:00:00 2001
From: Santhosh Kumar Ellendula
Date: Wed, 15 May 2024 15:32:29 -0700
Subject: [PATCH 8/8] [lldb-dap] Added "port" property to vscode "attach"
command - fix code format resolved code format issues.
---
.../test/tools/lldb-dap/lldbdap_testcase.py| 1 -
.../lldb-dap/attach/TestDAP_attachByPortNum.py | 18 ++
2 files changed, 10 insertions(+), 9 deletions(-)
diff --git
a/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py
b/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py
index d95a80482a60b..a2bef31ceb0ce 100644
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py
@@ -299,7 +299,6 @@ def attach(
expectFailure=False,
port=None,
hostname=None,
-
):
"""Build the default Makefile target, create the DAP debug adaptor,
and attach to the process.
diff --git a/lldb/test/API/tools/lldb-dap/attach/TestDAP_attachByPortNum.py
b/lldb/test/API/tools/lldb-dap/attach/TestDAP_attachByPortNum.py
index cfa20260fed39..e5cdc256a7abc 100644
--- a/lldb/test/API/tools/lldb-dap/attach/TestDAP_attachByPortNum.py
+++ b/lldb/test/API/tools/lldb-dap/attach/TestDAP_attachByPortNum.py
@@ -22,18 +22,18 @@
class TestDAP_attachByPortNum(lldbdap_testcase.DAPTestCaseBase):
def runTargetProgramOnPort(self, port=None, program=None):
server_tool = None
-if (lldbplatformutil.getPlatform() == "linux"):
+if lldbplatformutil.getPlatform() == "linux":
server_tool = lldbgdbserverutils.get_lldb_server_exe()
if server_tool is None:
self.dap_server.request_disconnect(terminateDebuggee=True)
self.assertIsNotNone(server_tool, "lldb-server not found.")
-server_tool += " g localhost:" + port + " "
-elif (lldbplatformutil.getPlatform() == "macosx"):
+server_tool += " g localhost:" + port + " "
+elif lldbplatformutil.getPlatform() == "macosx":
server_tool = lldbgdbserverutils.get_debugserver_exe()
if server_tool is None:
self.dap_server.request_disconnect(terminateDebuggee=True)
self.assertIsNotNone(server_tool, "debugserver not found.")
-server_tool += " --listen localhost:" + port + " "
+server_tool += " --listen localhost:" + port + " "
self.process = subprocess.Popen(
[server_tool + program],
@@ -72,9 +72,7 @@ def test_by_port(self):
port = "2345"
self.process = self.runTargetProgramOnPort(port=port, program=program)
pid = self.process.pid
-response = self.attach(
-program=program, port=int(port), sourceInitFile=True
-)
+response = self.attach(program=program, port=int(port),
sourceInitFile=True)
self.set_and_hit_breakpoint(continueToExit=True)
self.process.kill()
@@ -91,7 +89,11 @@ def test_by_port_and_pid(self):
port = "2345"
self.process = self.runTargetProgramOnPort(port=port, program=program)
response = self.attach(
-program=program, pid=1234, port=int(port), sourceInitFile=True,
expectFailure=True
+program=program,
+pid=1234,
+port=int(port),
+sourceInitFile=True,
+expectFailure=True,
)
if not (response and response["success"]):
self.assertFalse(
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[clang] [llvm] [clang] Add tanf16 builtin and support for tan constrained intrinsic (PR #93314)
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7eeec8e6d10a796974c3439529f3de690251b004 683dfa875e024acba12b229dbecd6d10573c891f -- clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/X86/math-builtins.c clang/test/CodeGen/constrained-math-builtins.c clang/test/CodeGen/math-libcalls.c llvm/include/llvm/CodeGen/ISDOpcodes.h `` View the diff from clang-format here. ``diff diff --git a/clang/lib/CodeGen/CGBuiltin.cpp b/clang/lib/CodeGen/CGBuiltin.cpp index 7650a006ff..443ed4c025 100644 --- a/clang/lib/CodeGen/CGBuiltin.cpp +++ b/clang/lib/CodeGen/CGBuiltin.cpp @@ -2931,9 +2931,8 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, case Builtin::BI__builtin_tanf16: case Builtin::BI__builtin_tanl: case Builtin::BI__builtin_tanf128: - return RValue::get(emitUnaryMaybeConstrainedFPBuiltin(*this, E, - Intrinsic::tan, - Intrinsic::experimental_constrained_tan)); + return RValue::get(emitUnaryMaybeConstrainedFPBuiltin( + *this, E, Intrinsic::tan, Intrinsic::experimental_constrained_tan)); case Builtin::BItrunc: case Builtin::BItruncf: `` https://github.com/llvm/llvm-project/pull/93314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/92014
>From 74ddb1e1cf40a388c1d57145fed3953ee4a5eab7 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 10 May 2024 12:42:03 -0700
Subject: [PATCH] Add AddressRange to SB API
Summary:
This adds new SB API calls and classes to allow a user of the SB API to
obtain an address range from SBFunction and SBBlock.
Test Plan:
llvm-lit -sv
llvm-project/lldb/test/API/python_api/address_range/TestAddressRange.py
Reviewers: clayborg
Subscribers: lldb-commits
Tasks:
Tags:
---
lldb/bindings/headers.swig| 2 +
.../interface/SBAddressRangeDocstrings.i | 3 +
.../interface/SBAddressRangeExtensions.i | 11 +
.../interface/SBAddressRangeListDocstrings.i | 3 +
.../interface/SBAddressRangeListExtensions.i | 27 ++
lldb/bindings/interfaces.swig | 6 +
lldb/include/lldb/API/LLDB.h | 2 +
lldb/include/lldb/API/SBAddress.h | 1 +
lldb/include/lldb/API/SBAddressRange.h| 66 +
lldb/include/lldb/API/SBAddressRangeList.h| 54
lldb/include/lldb/API/SBBlock.h | 4 +
lldb/include/lldb/API/SBDefines.h | 2 +
lldb/include/lldb/API/SBFunction.h| 3 +
lldb/include/lldb/API/SBStream.h | 2 +
lldb/include/lldb/API/SBTarget.h | 1 +
lldb/include/lldb/Core/AddressRange.h | 14 +
lldb/include/lldb/Core/AddressRangeListImpl.h | 51
lldb/include/lldb/Symbol/Block.h | 2 +
lldb/include/lldb/lldb-forward.h | 3 +
lldb/source/API/CMakeLists.txt| 2 +
lldb/source/API/SBAddressRange.cpp| 103 +++
lldb/source/API/SBAddressRangeList.cpp| 94 +++
lldb/source/API/SBBlock.cpp | 10 +
lldb/source/API/SBFunction.cpp| 14 +
lldb/source/Core/AddressRange.cpp | 43 +++
lldb/source/Core/AddressRangeListImpl.cpp | 50
lldb/source/Core/CMakeLists.txt | 1 +
lldb/source/Symbol/Block.cpp | 16 ++
.../API/python_api/address_range/Makefile | 3 +
.../address_range/TestAddressRange.py | 251 ++
.../API/python_api/address_range/main.cpp | 8 +
31 files changed, 852 insertions(+)
create mode 100644 lldb/bindings/interface/SBAddressRangeDocstrings.i
create mode 100644 lldb/bindings/interface/SBAddressRangeExtensions.i
create mode 100644 lldb/bindings/interface/SBAddressRangeListDocstrings.i
create mode 100644 lldb/bindings/interface/SBAddressRangeListExtensions.i
create mode 100644 lldb/include/lldb/API/SBAddressRange.h
create mode 100644 lldb/include/lldb/API/SBAddressRangeList.h
create mode 100644 lldb/include/lldb/Core/AddressRangeListImpl.h
create mode 100644 lldb/source/API/SBAddressRange.cpp
create mode 100644 lldb/source/API/SBAddressRangeList.cpp
create mode 100644 lldb/source/Core/AddressRangeListImpl.cpp
create mode 100644 lldb/test/API/python_api/address_range/Makefile
create mode 100644 lldb/test/API/python_api/address_range/TestAddressRange.py
create mode 100644 lldb/test/API/python_api/address_range/main.cpp
diff --git a/lldb/bindings/headers.swig b/lldb/bindings/headers.swig
index ffdc3c31ec883..c91504604b6ac 100644
--- a/lldb/bindings/headers.swig
+++ b/lldb/bindings/headers.swig
@@ -8,6 +8,8 @@
%{
#include "lldb/lldb-public.h"
#include "lldb/API/SBAddress.h"
+#include "lldb/API/SBAddressRange.h"
+#include "lldb/API/SBAddressRangeList.h"
#include "lldb/API/SBAttachInfo.h"
#include "lldb/API/SBBlock.h"
#include "lldb/API/SBBreakpoint.h"
diff --git a/lldb/bindings/interface/SBAddressRangeDocstrings.i
b/lldb/bindings/interface/SBAddressRangeDocstrings.i
new file mode 100644
index 0..650195704d73e
--- /dev/null
+++ b/lldb/bindings/interface/SBAddressRangeDocstrings.i
@@ -0,0 +1,3 @@
+%feature("docstring",
+"API clients can get address range information."
+) lldb::SBAddressRange;
diff --git a/lldb/bindings/interface/SBAddressRangeExtensions.i
b/lldb/bindings/interface/SBAddressRangeExtensions.i
new file mode 100644
index 0..31bcfcb64590b
--- /dev/null
+++ b/lldb/bindings/interface/SBAddressRangeExtensions.i
@@ -0,0 +1,11 @@
+%extend lldb::SBAddressRange {
+#ifdef SWIGPYTHON
+%pythoncode%{
+ def __repr__(self):
+import lldb
+stream = lldb.SBStream()
+self.GetDescription(stream, lldb.target if lldb.target else
lldb.SBTarget())
+return stream.GetData()
+%}
+#endif
+}
diff --git a/lldb/bindings/interface/SBAddressRangeListDocstrings.i
b/lldb/bindings/interface/SBAddressRangeListDocstrings.i
new file mode 100644
index 0..e4b96b9ca5931
--- /dev/null
+++ b/lldb/bindings/interface/SBAddressRangeListDocstrings.i
@@ -0,0 +1,3 @@
+%feature("docstring",
+"Represe
[clang] [llvm] [clang] Add tanf16 builtin and support for tan constrained intrinsic (PR #93314)
`llvm.experimental.constrained.exp``' Intrinsic
^
diff --git a/llvm/include/llvm/CodeGen/ISDOpcodes.h
b/llvm/include/llvm/CodeGen/ISDOpcodes.h
index d8af97957e48e..22062f0efbbda 100644
--- a/llvm/include/llvm/CodeGen/ISDOpcodes.h
+++ b/llvm/include/llvm/CodeGen/ISDOpcodes.h
@@ -415,6 +415,7 @@ enum NodeType {
STRICT_FLDEXP,
STRICT_FSIN,
STRICT_FCOS,
+ STRICT_FTAN,
STRICT_FEXP,
STRICT_FEXP2,
STRICT_FLOG,
@@ -934,6 +935,7 @@ enum NodeType {
FCBRT,
FSIN,
FCOS,
+ FTAN,
FPOW,
FPOWI,
/// FLDEXP - ldexp, inspired by libm (op0 * 2**op1).
diff --git a/llvm/include/llvm/IR/ConstrainedOps.def
b/llvm/include/llvm/IR/ConstrainedOps.def
index 41aa44de957f9..a7b37c5cb204d 100644
--- a/llvm/include/llvm/IR/ConstrainedOps.def
+++ b/llvm/include/llvm/IR/ConstrainedOps.def
@@ -95,6 +95,7 @@ DAG_FUNCTION(round, 1, 0,
experimental_constrained_round, FROUND)
DAG_FUNCTION(roundeven, 1, 0, experimental_constrained_roundeven,
FROUNDEVEN)
DAG_FUNCTION(sin, 1, 1, experimental_constrained_sin,FSIN)
DAG_FUNCTION(sqrt,1, 1, experimental_constrained_sqrt, FSQRT)
+DAG_FUNCTION(tan, 1, 1, experimental_constrained_tan,FTAN)
DAG_FUNCTION(trunc, 1, 0, experimental_constrained_trunc,
FTRUNC)
// This is definition for fmuladd intrinsic function, that is converted into
diff --git a/llvm/include/llvm/IR/Intrinsics.td
b/llvm/include/llvm/IR/Intrinsics.td
index 3019f68083d42..e1c33c7da33a5 100644
--- a/llvm/include/llvm/IR/Intrinsics.td
+++ b/llvm/include/llvm/IR/Intrinsics.td
@@ -1217,6 +1217,10 @@ let IntrProperties = [IntrInaccessibleMemOnly,
IntrWillReturn, IntrStrictFP] in
[ LLVMMatchType<0>,
llvm_metadata_ty,
llvm_metadata_ty ]>;
+ def int_experimental_constrained_tan : DefaultAttrsIntrinsic<[
llvm_anyfloat_ty ],
+[ LLVMMatchType<0>,
+ llvm_metadata_ty,
+ llvm_metadata_ty ]>;
def int_experimental_constrained_pow : DefaultAttrsIntrinsic<[
llvm_anyfloat_ty ],
[ LLVMMatchType<0>,
LLVMMatchType<0>,
diff --git a/llvm/test/Assembler/fp-intrinsics-attr.ll
b/llvm/test/Assembler/fp-intrinsics-attr.ll
index 6546d1a275c99..613630e1a2b4d 100644
--- a/llvm/test/Assembler/fp-intrinsics-attr.ll
+++ b/llvm/test/Assembler/fp-intrinsics-attr.ll
@@ -85,6 +85,11 @@ define void @func(double %a, double %b, double %c, i32 %i)
strictfp {
metadata !"round.dynamic",
metadata !"fpexcept.strict")
+ %tan = call double @llvm.experimental.constrained.tan.f64(
+ double %a,
+ metadata !"round.dynamic",
+ metadata !"fpexcept.strict")
+
%pow = call double @llvm.experimental.constrained.pow.f64(
double %a, double %b,
metadata !"round.dynamic",
@@ -244,6 +249,9 @@ declare double
@llvm.experimental.constrained.sin.f64(double, metadata, metadata
declare double @llvm.experimental.constrained.cos.f64(double, metadata,
metadata)
; CHECK: @llvm.experimental.constrained.cos.f64({{.*}}) #[[ATTR1]]
+declare double @llvm.experimental.constrained.tan.f64(double, metadata,
metadata)
+; CHECK: @llvm.experimental.constrained.tan.f64({{.*}}) #[[ATTR1]]
+
declare double @llvm.experimental.constrained.pow.f64(double, double,
metadata, metadata)
; CHECK: @llvm.experimental.constrained.pow.f64({{.*}}) #[[ATTR1]]
diff --git a/llvm/test/Feature/fp-intrinsics.ll
b/llvm/test/Feature/fp-intrinsics.ll
index b92408a1bf1cd..7759813dc2e11 100644
--- a/llvm/test/Feature/fp-intrinsics.ll
+++ b/llvm/test/Feature/fp-intrinsics.ll
@@ -151,6 +151,17 @@ entry:
ret double %result
}
+; Verify that tan(42.0) isn't simplified when the rounding mode is unknown.
+; CHECK-LABEL: ftan
+; CHECK: call double @llvm.experimental.constrained.tan
+define double @ftan() #0 {
+entry:
+ %result = call double @llvm.experimental.constrained.tan.f64(double 42.0,
+ metadata !"round.dynamic",
+ metadata !"fpexcept.strict") #0
+ ret double %result
+}
+
; Verify that exp(42.0) isn't simplified when the rounding mode is unknown.
; CHECK-LABEL: f10
; CHECK: call double @llvm.experimental.constrained.exp
``
https://github.com/llvm/llvm-project/pull/93314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [clang] Add tanf16 builtin and support for tan constrained intrinsic (PR #93314)
eturns the tangent of the specified operand, returning the
+same values as the libm ``tan`` functions would, and handles error
+conditions in the same way.
+
+
'``llvm.experimental.constrained.exp``' Intrinsic
^
diff --git a/llvm/include/llvm/CodeGen/ISDOpcodes.h
b/llvm/include/llvm/CodeGen/ISDOpcodes.h
index d8af97957e48e..22062f0efbbda 100644
--- a/llvm/include/llvm/CodeGen/ISDOpcodes.h
+++ b/llvm/include/llvm/CodeGen/ISDOpcodes.h
@@ -415,6 +415,7 @@ enum NodeType {
STRICT_FLDEXP,
STRICT_FSIN,
STRICT_FCOS,
+ STRICT_FTAN,
STRICT_FEXP,
STRICT_FEXP2,
STRICT_FLOG,
@@ -934,6 +935,7 @@ enum NodeType {
FCBRT,
FSIN,
FCOS,
+ FTAN,
FPOW,
FPOWI,
/// FLDEXP - ldexp, inspired by libm (op0 * 2**op1).
diff --git a/llvm/include/llvm/IR/ConstrainedOps.def
b/llvm/include/llvm/IR/ConstrainedOps.def
index 41aa44de957f9..a7b37c5cb204d 100644
--- a/llvm/include/llvm/IR/ConstrainedOps.def
+++ b/llvm/include/llvm/IR/ConstrainedOps.def
@@ -95,6 +95,7 @@ DAG_FUNCTION(round, 1, 0,
experimental_constrained_round, FROUND)
DAG_FUNCTION(roundeven, 1, 0, experimental_constrained_roundeven,
FROUNDEVEN)
DAG_FUNCTION(sin, 1, 1, experimental_constrained_sin,FSIN)
DAG_FUNCTION(sqrt,1, 1, experimental_constrained_sqrt, FSQRT)
+DAG_FUNCTION(tan, 1, 1, experimental_constrained_tan,FTAN)
DAG_FUNCTION(trunc, 1, 0, experimental_constrained_trunc,
FTRUNC)
// This is definition for fmuladd intrinsic function, that is converted into
diff --git a/llvm/include/llvm/IR/Intrinsics.td
b/llvm/include/llvm/IR/Intrinsics.td
index 3019f68083d42..e1c33c7da33a5 100644
--- a/llvm/include/llvm/IR/Intrinsics.td
+++ b/llvm/include/llvm/IR/Intrinsics.td
@@ -1217,6 +1217,10 @@ let IntrProperties = [IntrInaccessibleMemOnly,
IntrWillReturn, IntrStrictFP] in
[ LLVMMatchType<0>,
llvm_metadata_ty,
llvm_metadata_ty ]>;
+ def int_experimental_constrained_tan : DefaultAttrsIntrinsic<[
llvm_anyfloat_ty ],
+[ LLVMMatchType<0>,
+ llvm_metadata_ty,
+ llvm_metadata_ty ]>;
def int_experimental_constrained_pow : DefaultAttrsIntrinsic<[
llvm_anyfloat_ty ],
[ LLVMMatchType<0>,
LLVMMatchType<0>,
diff --git a/llvm/test/Assembler/fp-intrinsics-attr.ll
b/llvm/test/Assembler/fp-intrinsics-attr.ll
index 6546d1a275c99..613630e1a2b4d 100644
--- a/llvm/test/Assembler/fp-intrinsics-attr.ll
+++ b/llvm/test/Assembler/fp-intrinsics-attr.ll
@@ -85,6 +85,11 @@ define void @func(double %a, double %b, double %c, i32 %i)
strictfp {
metadata !"round.dynamic",
metadata !"fpexcept.strict")
+ %tan = call double @llvm.experimental.constrained.tan.f64(
+ double %a,
+ metadata !"round.dynamic",
+ metadata !"fpexcept.strict")
+
%pow = call double @llvm.experimental.constrained.pow.f64(
double %a, double %b,
metadata !"round.dynamic",
@@ -244,6 +249,9 @@ declare double
@llvm.experimental.constrained.sin.f64(double, metadata, metadata
declare double @llvm.experimental.constrained.cos.f64(double, metadata,
metadata)
; CHECK: @llvm.experimental.constrained.cos.f64({{.*}}) #[[ATTR1]]
+declare double @llvm.experimental.constrained.tan.f64(double, metadata,
metadata)
+; CHECK: @llvm.experimental.constrained.tan.f64({{.*}}) #[[ATTR1]]
+
declare double @llvm.experimental.constrained.pow.f64(double, double,
metadata, metadata)
; CHECK: @llvm.experimental.constrained.pow.f64({{.*}}) #[[ATTR1]]
diff --git a/llvm/test/Feature/fp-intrinsics.ll
b/llvm/test/Feature/fp-intrinsics.ll
index b92408a1bf1cd..7759813dc2e11 100644
--- a/llvm/test/Feature/fp-intrinsics.ll
+++ b/llvm/test/Feature/fp-intrinsics.ll
@@ -151,6 +151,17 @@ entry:
ret double %result
}
+; Verify that tan(42.0) isn't simplified when the rounding mode is unknown.
+; CHECK-LABEL: ftan
+; CHECK: call double @llvm.experimental.constrained.tan
+define double @ftan() #0 {
+entry:
+ %result = call double @llvm.experimental.constrained.tan.f64(double 42.0,
+ metadata !"round.dynamic",
+ metadata !"fpexcept.strict") #0
+ ret double %result
+}
+
; Verify that exp(42.0) isn't simplified when the rounding mode is unknown.
; CHECK-LABEL: f10
; CHECK: call double @llvm.experimental.constrained.exp
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] [SemaCXX] Implement CWG2627 Bit-fields and narrowing conversions (PR #78112)
https://github.com/MitalAshok edited https://github.com/llvm/llvm-project/pull/78112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[Lldb-commits] [flang] [lldb] [llvm] [flang] [lldb] [llvm] Fix 'destory' comment typos [NFC] (PR #93260)
https://github.com/JDevlieghere approved this pull request. Normally I'd ask splitting upcross-project PRs, but this one is trivial and very unlikely to be cause churn :-) LGMT. https://github.com/llvm/llvm-project/pull/93260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[clang] [clang][ExtractAPI] Ensure TemplateArgumentLocations are only accessed if available (PR #93205)
https://github.com/daniel-grumberg closed https://github.com/llvm/llvm-project/pull/93205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] ab7e6b6 - [clang][ExtractAPI] Ensure TemplateArgumentLocations are only accessed if available (#93205)
uot;spelling": "<"
+// TYPE-NEXT: },
+// TYPE-NEXT: {
+// TYPE-NEXT: "kind": "typeIdentifier",
+// TYPE-NEXT: "preciseIdentifier": "c:t0.0",
+// TYPE-NEXT: "spelling": "T"
+// TYPE-NEXT: },
+// TYPE-NEXT: {
+// TYPE-NEXT: "kind": "text",
+// TYPE-NEXT: "spelling": "> "
+// TYPE-NEXT: },
+// TYPE-NEXT: {
+// TYPE-NEXT: "kind": "identifier",
+// TYPE-NEXT: "spelling": "Type"
+// TYPE-NEXT: },
+// TYPE-NEXT: {
+// TYPE-NEXT: "kind": "text",
+// TYPE-NEXT: "spelling": ";"
+// TYPE-NEXT: }
+// TYPE-NEXT: ]
+};
+
// expected-no-diagnostics
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [WebAssembly] Implement prototype f16x8.extract_lane instruction. (PR #93272)
https://github.com/dschuff closed https://github.com/llvm/llvm-project/pull/93272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 4ebe9bb - [WebAssembly] Implement prototype f16x8.extract_lane instruction. (#93272)
ENT_v4i32_S:
case WebAssembly::ARGUMENT_v2i64:
case WebAssembly::ARGUMENT_v2i64_S:
+ case WebAssembly::ARGUMENT_v8f16:
+ case WebAssembly::ARGUMENT_v8f16_S:
case WebAssembly::ARGUMENT_v4f32:
case WebAssembly::ARGUMENT_v4f32_S:
case WebAssembly::ARGUMENT_v2f64:
diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
b/llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
index 3524abba8990a..443558537da24 100644
--- a/llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
+++ b/llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
@@ -62,7 +62,7 @@ MVT WebAssemblyAsmPrinter::getRegType(unsigned RegNo) const {
const TargetRegisterInfo *TRI = Subtarget->getRegisterInfo();
const TargetRegisterClass *TRC = MRI->getRegClass(RegNo);
for (MVT T : {MVT::i32, MVT::i64, MVT::f32, MVT::f64, MVT::v16i8, MVT::v8i16,
-MVT::v4i32, MVT::v2i64, MVT::v4f32, MVT::v2f64})
+MVT::v4i32, MVT::v2i64, MVT::v4f32, MVT::v2f64, MVT::v8f16})
if (TRI->isTypeLegalForClass(*TRC, T))
return T;
LLVM_DEBUG(errs() << "Unknown type for register number: " << RegNo);
@@ -662,6 +662,8 @@ void WebAssemblyAsmPrinter::emitInstruction(const
MachineInstr *MI) {
case WebAssembly::ARGUMENT_v4f32_S:
case WebAssembly::ARGUMENT_v2f64:
case WebAssembly::ARGUMENT_v2f64_S:
+ case WebAssembly::ARGUMENT_v8f16:
+ case WebAssembly::ARGUMENT_v8f16_S:
// These represent values which are live into the function entry, so
there's
// no instruction to emit.
break;
diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
b/llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
index bb898e7bebd3a..558e3d859dcd8 100644
--- a/llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
+++ b/llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
@@ -52,6 +52,7 @@ defm "" : ARGUMENT;
defm "" : ARGUMENT;
defm "" : ARGUMENT;
defm "" : ARGUMENT;
+defm "" : ARGUMENT;
// Constrained immediate argument types. Allow any value from the minimum
signed
// value to the maximum unsigned value for the lane size.
@@ -659,6 +660,14 @@ def : Pat<
(and (vector_extract (v8i16 V128:$vec), (i32 LaneIdx8:$idx)), (i32 0x)),
(EXTRACT_LANE_I16x8_u $vec, imm:$idx)>;
+defm EXTRACT_LANE_F16x8 :
+ HALF_PRECISION_I<(outs F32:$dst), (ins V128:$vec, vec_i8imm_op:$idx),
+ (outs), (ins vec_i8imm_op:$idx),
+ [(set (f32 F32:$dst), (int_wasm_extract_lane_f16x8
+(v8f16 V128:$vec), (i32 LaneIdx16:$idx)))],
+ "f16x8.extract_lane\t$dst, $vec, $idx",
+ "f16x8.extract_lane\t$idx", 0x121>;
+
// Replace lane value: replace_lane
multiclass ReplaceLane simdop> {
defm REPLACE_LANE_#vec :
diff --git a/llvm/test/CodeGen/WebAssembly/half-precision.ll
b/llvm/test/CodeGen/WebAssembly/half-precision.ll
index eee5bf8b8c48a..d9d3f6be800fd 100644
--- a/llvm/test/CodeGen/WebAssembly/half-precision.ll
+++ b/llvm/test/CodeGen/WebAssembly/half-precision.ll
@@ -27,3 +27,11 @@ define <8 x half> @splat_v8f16(float %x) {
%v = call <8 x half> @llvm.wasm.splat.f16x8(float %x)
ret <8 x half> %v
}
+
+; CHECK-LABEL: extract_lane_v8f16:
+; CHECK: f16x8.extract_lane $push0=, $0, 1
+; CHECK-NEXT: return $pop0
+define float @extract_lane_v8f16(<8 x half> %v) {
+ %r = call float @llvm.wasm.extract.lane.f16x8(<8 x half> %v, i32 1)
+ ret float %r
+}
diff --git a/llvm/test/MC/WebAssembly/simd-encodings.s
b/llvm/test/MC/WebAssembly/simd-encodings.s
index c23a9d1958099..d397188a9882e 100644
--- a/llvm/test/MC/WebAssembly/simd-encodings.s
+++ b/llvm/test/MC/WebAssembly/simd-encodings.s
@@ -848,4 +848,7 @@ main:
# CHECK: f16x8.splat # encoding: [0xfd,0xa0,0x02]
f16x8.splat
+# CHECK: f16x8.extract_lane 1 # encoding: [0xfd,0xa1,0x02,0x01]
+f16x8.extract_lane 1
+
end_function
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[jenkinsci/jenkins-test-harness] e98569: EE 8 to EE 9
Branch: refs/heads/jakarta Home: https://github.com/jenkinsci/jenkins-test-harness Commit: e98569b13e34bdc4f50eb3e3db75bbe5158d7de5 https://github.com/jenkinsci/jenkins-test-harness/commit/e98569b13e34bdc4f50eb3e3db75bbe5158d7de5 Author: Basil Crow Date: 2024-05-24 (Fri, 24 May 2024) Changed paths: M Jenkinsfile M pom.xml M src/main/java/jenkins/benchmark/jmh/JmhBenchmarkState.java M src/main/java/org/jvnet/hudson/test/CaptureEnvironmentBuilder.java M src/main/java/org/jvnet/hudson/test/ClosureExecuterAction.java M src/main/java/org/jvnet/hudson/test/ComputerConnectorTester.java M src/main/java/org/jvnet/hudson/test/CreateFileBuilder.java M src/main/java/org/jvnet/hudson/test/FailureBuilder.java M src/main/java/org/jvnet/hudson/test/GroovyHudsonTestCase.java M src/main/java/org/jvnet/hudson/test/GroovyJenkinsRule.java M src/main/java/org/jvnet/hudson/test/HudsonTestCase.java M src/main/java/org/jvnet/hudson/test/JavaNetReverseProxy.java M src/main/java/org/jvnet/hudson/test/JenkinsComputerConnectorTester.java M src/main/java/org/jvnet/hudson/test/JenkinsRecipe.java M src/main/java/org/jvnet/hudson/test/JenkinsRule.java M src/main/java/org/jvnet/hudson/test/MockBuilder.java M src/main/java/org/jvnet/hudson/test/MockFolder.java M src/main/java/org/jvnet/hudson/test/MockQueueItemAuthenticator.java M src/main/java/org/jvnet/hudson/test/NoListenerConfiguration.java M src/main/java/org/jvnet/hudson/test/RealJenkinsRule.java M src/main/java/org/jvnet/hudson/test/TestCrumbIssuer.java M src/main/java/org/jvnet/hudson/test/UnitTestSupportingPluginManager.java M src/main/java/org/jvnet/hudson/test/UnstableBuilder.java M src/main/java/org/jvnet/hudson/test/WorkspaceCopyFileBuilder.java M src/main/java/org/jvnet/hudson/test/recipes/Recipe.java M src/test/java/org/jvnet/hudson/main/UseRecipesWithJenkinsRuleTest.java M src/test/java/org/jvnet/hudson/test/RealJenkinsRuleTest.java Log Message: --- EE 8 to EE 9 To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/jenkins-test-harness/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/jenkins-test-harness/push/refs/heads/jakarta/281bac-e98569%40github.com.
[clang] [llvm] [WebAssembly] Implement prototype f16x8.extract_lane instruction. (PR #93272)
https://github.com/dschuff approved this pull request. https://github.com/llvm/llvm-project/pull/93272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang][ExtractAPI] Ensure TemplateArgumentLocations are only accessed if available (PR #93205)
https://github.com/QuietMisdreavus approved this pull request. https://github.com/llvm/llvm-project/pull/93205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[Lldb-commits] [lldb] [lldb][lldb-dap] Cleanup breakpoint filters. (PR #87550)
@@ -331,6 +333,7 @@ struct DAP {
// "Content-Length:" field followed by the length, followed by the raw
// JSON bytes.
void SendJSON(const std::string _str);
+ bool bp_initted;
JDevlieghere wrote:
This should be next to `exception_breakpoints`, but I wouldn't bother with the
boolean and instead make `exception_breakpoints` a `std::optional<...>` and
initialize it in `PopulateExceptionBreakpoints` so that the two are inherently
tied together.
https://github.com/llvm/llvm-project/pull/87550
_______
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[jenkinsci/jenkins-test-harness] 51030c: Forward compatibility with EE 9 cores
Branch: refs/heads/forward Home: https://github.com/jenkinsci/jenkins-test-harness Commit: 51030cd12ee480cddf85993ee381caeb3a513107 https://github.com/jenkinsci/jenkins-test-harness/commit/51030cd12ee480cddf85993ee381caeb3a513107 Author: Basil Crow Date: 2024-05-24 (Fri, 24 May 2024) Changed paths: M pom.xml M src/main/java/jenkins/benchmark/jmh/JmhBenchmarkState.java M src/main/java/org/jvnet/hudson/test/ComputerConnectorTester.java M src/main/java/org/jvnet/hudson/test/HudsonTestCase.java M src/main/java/org/jvnet/hudson/test/JavaNetReverseProxy.java A src/main/java/org/jvnet/hudson/test/JavaNetReverseProxy2.java M src/main/java/org/jvnet/hudson/test/JenkinsComputerConnectorTester.java M src/main/java/org/jvnet/hudson/test/JenkinsRule.java M src/main/java/org/jvnet/hudson/test/MockFolder.java M src/main/java/org/jvnet/hudson/test/NoListenerConfiguration.java A src/main/java/org/jvnet/hudson/test/NoListenerConfiguration2.java M src/main/java/org/jvnet/hudson/test/RealJenkinsRule.java M src/main/java/org/jvnet/hudson/test/UnitTestSupportingPluginManager.java M src/spotbugs/excludesFilter.xml Log Message: --- Forward compatibility with EE 9 cores To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/jenkins-test-harness/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/jenkins-test-harness/push/refs/heads/forward/4f58e0-51030c%40github.com.
[Lldb-commits] [lldb] [lldb][lldb-dap] Cleanup breakpoint filters. (PR #87550)
@@ -335,3 +335,14 @@ TypeSystemMap::GetTypeSystemForLanguage(lldb::LanguageType
language,
}
return GetTypeSystemForLanguage(language);
}
+
+bool TypeSystem::SupportsLanguageStatic(lldb::LanguageType language) {
+ if (language == eLanguageTypeUnknown)
+return false;
+
+ LanguageSet plugins =
+ PluginManager::GetAllTypeSystemSupportedLanguagesForTypes();
JDevlieghere wrote:
`s/plugins/languages/`
https://github.com/llvm/llvm-project/pull/87550
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[jenkinsci/gradle-plugin] 812206: Bump references to Develocity Maven extension from...
Branch: refs/heads/master Home: https://github.com/jenkinsci/gradle-plugin Commit: 812206783e5d7c746930545d735b526454e556a0 https://github.com/jenkinsci/gradle-plugin/commit/812206783e5d7c746930545d735b526454e556a0 Author: Bot Githubaction <98587996+bot-githubact...@users.noreply.github.com> Date: 2024-05-24 (Fri, 24 May 2024) Changed paths: M README.adoc M settings.gradle.kts Log Message: --- Bump references to Develocity Maven extension from 1.21.3 to 1.21.4 (#447) To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/gradle-plugin/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/gradle-plugin/push/refs/heads/master/23d49f-812206%40github.com.
[jenkinsci/gradle-plugin]
Branch: refs/heads/upgradebot/bump-dv-maven-extension-1.21.4 Home: https://github.com/jenkinsci/gradle-plugin To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/gradle-plugin/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/gradle-plugin/push/refs/heads/upgradebot/bump-dv-maven-extension-1.21.4/190b11-00%40github.com.
[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #93302)
setDSOLocal(Entry); } @@ -4857,7 +4857,7 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef MangledName, llvm::Type *Ty, (Entry->getDLLStorageClass() == llvm::GlobalVariable::DLLImportStorageClass) && !D->hasAttr() && -!shouldMapVisibilityToDLLExport(cast_or_null(D))) +!shouldMapVisibilityToDLLExport(D)) Entry->setDLLStorageClass(llvm::GlobalValue::DefaultStorageClass); if (LangOpts.OpenMP && !LangOpts.OpenMPSimd && D) >From 501b2d783e0486479a026cd0b3682acba64215dc Mon Sep 17 00:00:00 2001 From: Andrew Ng Date: Fri, 24 May 2024 16:21:37 +0100 Subject: [PATCH 3/3] clang-format the result of the last change --- clang/lib/CodeGen/CodeGenModule.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index 6c3e7a6ffbb0b..4327eeb92bfbf 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -4856,8 +4856,7 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef MangledName, llvm::Type *Ty, if (D && (Entry->getDLLStorageClass() == llvm::GlobalVariable::DLLImportStorageClass) && -!D->hasAttr() && - !shouldMapVisibilityToDLLExport(D)) +!D->hasAttr() && !shouldMapVisibilityToDLLExport(D)) Entry->setDLLStorageClass(llvm::GlobalValue::DefaultStorageClass); if (LangOpts.OpenMP && !LangOpts.OpenMPSimd && D) ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [WebAssembly] Re-enable reference types by default (PR #93261)
https://github.com/dschuff approved this pull request. https://github.com/llvm/llvm-project/pull/93261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #93302)
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 70a54bca6f7f9f45b4b17974ddaa01cd7a5d64be 5425cfb18b53f767fd9dc18e5ac7e196b5349f23 -- clang/test/CodeGenCXX/windows-instantiate-dllexport-template-specialization.cpp clang/lib/CodeGen/CodeGenModule.cpp `` View the diff from clang-format here. ``diff diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index 6c3e7a6ffb..4327eeb92b 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -4856,8 +4856,7 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef MangledName, llvm::Type *Ty, if (D && (Entry->getDLLStorageClass() == llvm::GlobalVariable::DLLImportStorageClass) && -!D->hasAttr() && -!shouldMapVisibilityToDLLExport(D)) +!D->hasAttr() && !shouldMapVisibilityToDLLExport(D)) Entry->setDLLStorageClass(llvm::GlobalValue::DefaultStorageClass); if (LangOpts.OpenMP && !LangOpts.OpenMPSimd && D) `` https://github.com/llvm/llvm-project/pull/93302 _______ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #93302)
@@ -4849,9 +4852,12 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef MangledName, llvm::Type *Ty, Entry->setLinkage(llvm::Function::ExternalLinkage); } -// Handle dropped DLL attributes. -if (D && !D->hasAttr() && !D->hasAttr() && -!shouldMapVisibilityToDLLExport(D)) +// Handle dropped dllimport. +if (D && +(Entry->getDLLStorageClass() == + llvm::GlobalVariable::DLLImportStorageClass) && +!D->hasAttr() && +!shouldMapVisibilityToDLLExport(cast_or_null(D))) nga888 wrote: I've fixed up both instances of the call to `shouldMapVisibilityToDLLExport()`. https://github.com/llvm/llvm-project/pull/93302 _______ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[llvm-branch-commits] [llvm] release/18.x: [DAGCombiner] In mergeTruncStore, make sure we aren't storing shifted in bits. (#90939) (PR #91038)
https://github.com/AtariDreams closed https://github.com/llvm/llvm-project/pull/91038 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[clang] [clang][ASTImporter] Fix possible crash "given incorrect InsertPos for specialization". (PR #89887)
balazske wrote:
> Could you please show your commands which reproduced this crash? I tested
> locally with the following commands and it runs OK.
>
> ```c++
> clang++ -cc1 -std=c++17 -emit-pch -o test.cpp.ast test.cpp
> clang++ -cc1 -x c++ -ast-merge test.cpp.ast /dev/null -ast-dump
> ```
That code is only an example, it differs not much of the real code that caused
the crash. But it is not enough to use this code for the problem reproduction.
This code can be used to get the case when the specialization list is changed
before the insertion, but even then no crash happens:
```c++
namespace N {
template
int B = B + B;
template <>
int B<0> = 0;
template <>
int B<1> = 1;
}
int A = N::B<5>;
```
With clang version 18.1.6 the original crash does not occur any more.
The "original crash" was reproduced on specific source files of project
"contour". Probably I can attach the files and command, but some changes can be
required to make it work.
https://github.com/llvm/llvm-project/pull/89887
_______
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[llvm-branch-commits] [lld] [llvm] release/18.x: [lld] Fix -ObjC load behavior with LTO (#92162) (PR #92478)
https://github.com/AtariDreams closed https://github.com/llvm/llvm-project/pull/92478 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #93302)
setDSOLocal(Entry); } @@ -4857,7 +4857,7 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef MangledName, llvm::Type *Ty, (Entry->getDLLStorageClass() == llvm::GlobalVariable::DLLImportStorageClass) && !D->hasAttr() && -!shouldMapVisibilityToDLLExport(cast_or_null(D))) +!shouldMapVisibilityToDLLExport(D)) Entry->setDLLStorageClass(llvm::GlobalValue::DefaultStorageClass); if (LangOpts.OpenMP && !LangOpts.OpenMPSimd && D) ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[jenkinsci/jenkins-test-harness] 4c67e5: Upgrade Jetty from 10.0.20 to 12.0.9 (EE 8)
Branch: refs/heads/prototype Home: https://github.com/jenkinsci/jenkins-test-harness Commit: 4c67e571b4a6796ff71e75ee9db1033201eb2929 https://github.com/jenkinsci/jenkins-test-harness/commit/4c67e571b4a6796ff71e75ee9db1033201eb2929 Author: Basil Crow Date: 2024-05-24 (Fri, 24 May 2024) Changed paths: M Jenkinsfile M pom.xml M src/main/java/jenkins/benchmark/jmh/JmhBenchmarkState.java M src/main/java/org/jvnet/hudson/test/HudsonTestCase.java M src/main/java/org/jvnet/hudson/test/JavaNetReverseProxy.java M src/main/java/org/jvnet/hudson/test/JenkinsRule.java M src/main/java/org/jvnet/hudson/test/NoListenerConfiguration.java Log Message: --- Upgrade Jetty from 10.0.20 to 12.0.9 (EE 8) To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/jenkins-test-harness/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/jenkins-test-harness/push/refs/heads/prototype/1959ab-4c67e5%40github.com.
[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)
@@ -2306,6 +2345,11 @@ bool DWARFASTParserClang::CompleteTypeFromDWARF(const DWARFDIE , if (!die) return false; + ParsedDWARFTypeAttributes attrs(die); labath wrote: SG https://github.com/llvm/llvm-project/pull/92328 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/92328 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/92328 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[clang] [MSVC, ARM64] Fix signature for __prefetch (PR #93235)
https://github.com/dpaoliello closed https://github.com/llvm/llvm-project/pull/93235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 53b9048 - [MSVC, ARM64] Fix signature for __prefetch (#93235)
Author: Daniel Paoliello Date: 2024-05-24T07:56:17-07:00 New Revision: 53b904823cba4e93d58793b0804407f812477724 URL: https://github.com/llvm/llvm-project/commit/53b904823cba4e93d58793b0804407f812477724 DIFF: https://github.com/llvm/llvm-project/commit/53b904823cba4e93d58793b0804407f812477724.diff LOG: [MSVC, ARM64] Fix signature for __prefetch (#93235) #67174 added the `__prefetch` intrinsic, however it used the wrong signature: the argument should be `const void*`, not `void*`. Docs: https://learn.microsoft.com/en-us/cpp/intrinsics/arm64-intrinsics?view=msvc-170#:~:text=__prefetch Unfortunately, this can't be backported (there are no more 18.x releases, and this change is a breaking change), so I'll see if I can get a workaround added on MSVC's side for Clang 18. Added: Modified: clang/include/clang/Basic/BuiltinsAArch64.def clang/lib/Headers/intrin.h Removed: diff --git a/clang/include/clang/Basic/BuiltinsAArch64.def b/clang/include/clang/Basic/BuiltinsAArch64.def index cf8711c6eaee3..5f53c98167dfb 100644 --- a/clang/include/clang/Basic/BuiltinsAArch64.def +++ b/clang/include/clang/Basic/BuiltinsAArch64.def @@ -290,7 +290,7 @@ TARGET_HEADER_BUILTIN(_CountLeadingZeros64, "UiULLi", "nh", INTRIN_H, ALL_MS_LAN TARGET_HEADER_BUILTIN(_CountOneBits, "UiUNi", "nh", INTRIN_H, ALL_MS_LANGUAGES, "") TARGET_HEADER_BUILTIN(_CountOneBits64, "UiULLi", "nh", INTRIN_H, ALL_MS_LANGUAGES, "") -TARGET_HEADER_BUILTIN(__prefetch, "vv*", "nh", INTRIN_H, ALL_MS_LANGUAGES, "") +TARGET_HEADER_BUILTIN(__prefetch, "vvC*", "nh", INTRIN_H, ALL_MS_LANGUAGES, "") #undef BUILTIN #undef LANGBUILTIN diff --git a/clang/lib/Headers/intrin.h b/clang/lib/Headers/intrin.h index 7eb6dceaabfae..5ceb986a1f652 100644 --- a/clang/lib/Headers/intrin.h +++ b/clang/lib/Headers/intrin.h @@ -378,7 +378,7 @@ unsigned int _CountLeadingSigns64(__int64); unsigned int _CountOneBits(unsigned long); unsigned int _CountOneBits64(unsigned __int64); -void __cdecl __prefetch(void *); +void __cdecl __prefetch(const void *); #endif /*------------*\ ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #93302)
@@ -4849,9 +4852,12 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef MangledName, llvm::Type *Ty, Entry->setLinkage(llvm::Function::ExternalLinkage); } -// Handle dropped DLL attributes. -if (D && !D->hasAttr() && !D->hasAttr() && -!shouldMapVisibilityToDLLExport(D)) +// Handle dropped dllimport. +if (D && +(Entry->getDLLStorageClass() == + llvm::GlobalVariable::DLLImportStorageClass) && +!D->hasAttr() && +!shouldMapVisibilityToDLLExport(cast_or_null(D))) nga888 wrote: Sorry, the above comment should have been in reply to the instance above. This cast shouldn't be needed at all. I suspect a copy & paste error on my behalf! https://github.com/llvm/llvm-project/pull/93302 _______ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #93302)
nga888 wrote: > Does the test exercise both modified paths? I'm guessing it only exercises > GetOrCreateLLVMFunction, but I'm not a codegen expert. Only 1 path is "exercised" but I believe neither path of the removed code was exercised previously and no other tests are affected by the code removal. https://github.com/llvm/llvm-project/pull/93302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 82a5d0d - [clang][Interp][NFC] Make eval-order test more useful
Author: Timm Bäder
Date: 2024-05-24T16:47:46+02:00
New Revision: 82a5d0da6007609ddcb3190530e0a269ae0452db
URL:
https://github.com/llvm/llvm-project/commit/82a5d0da6007609ddcb3190530e0a269ae0452db
DIFF:
https://github.com/llvm/llvm-project/commit/82a5d0da6007609ddcb3190530e0a269ae0452db.diff
LOG: [clang][Interp][NFC] Make eval-order test more useful
Use different -verify prefixes and make sure the tests really break
when fixing the eval order.
Added:
Modified:
clang/test/AST/Interp/eval-order.cpp
Removed:
diff --git a/clang/test/AST/Interp/eval-order.cpp
b/clang/test/AST/Interp/eval-order.cpp
index 695a43c9d235b..aaf2b74510bbf 100644
--- a/clang/test/AST/Interp/eval-order.cpp
+++ b/clang/test/AST/Interp/eval-order.cpp
@@ -1,8 +1,7 @@
-// RUN: %clang_cc1 -std=c++1z -verify %s -fcxx-exceptions
-triple=x86_64-linux-gnu
-// RUN: %clang_cc1 -std=c++1z -verify %s -fcxx-exceptions
-triple=x86_64-linux-gnu -fexperimental-new-constant-interpreter
+// RUN: %clang_cc1 -std=c++1z -verify=ref,both %s -fcxx-exceptions
-triple=x86_64-linux-gnu
+// RUN: %clang_cc1 -std=c++1z -verify=expected,both %s -fcxx-exceptions
-triple=x86_64-linux-gnu -fexperimental-new-constant-interpreter
// ref-no-diagnostics
-// expected-no-diagnostics
/// Check that assignment operators evaluate their operands right-to-left.
/// Copied from test/SemaCXX/constant-expression-cxx1z.cpp
@@ -46,7 +45,7 @@ namespace EvalOrder {
}
template constexpr T &(T &) {
if (!done_a)
-throw "wrong";
+throw "wrong"; // expected-note 7{{not valid}}
done_b = true;
return (T &&)v;
}
@@ -76,21 +75,30 @@ namespace EvalOrder {
// SEQ(A()->*B(::n)); FIXME
// Rule 4: a(b1, b2, b3)
- // SEQ(A(f)(B(1), B(2), B(3))); FIXME
+ SEQ(A(f)(B(1), B(2), B(3))); // expected-error {{not an integral constant
expression}} FIXME \
+ // expected-note 2{{in call to}}
// Rule 5: b = a, b @= a
- // SEQ(B(lvalue().get()) = A(0)); FIXME
- // SEQ(B(lvalue().get()) = A(ud)); FIXME
+ SEQ(B(lvalue().get()) = A(0)); // expected-error {{not an integral
constant expression}} FIXME \
+ // expected-note 2{{in call to}}
+ SEQ(B(lvalue().get()) = A(ud)); // expected-error {{not an
integral constant expression}} FIXME \
+ // expected-note 2{{in call to}}
SEQ(B(lvalue().get()) += A(0));
- // SEQ(B(lvalue().get()) += A(ud)); FIXME
- // SEQ(B(lvalue().get()) += A(nm)); FIXME
+ SEQ(B(lvalue().get()) += A(ud)); // expected-error {{not an
integral constant expression}} FIXME \
+// expected-note 2{{in call
to}}
+
+ SEQ(B(lvalue().get()) += A(nm)); // expected-error {{not an
integral constant expression}} FIXME \
+ // expected-note 2{{in call to}}
+
// Rule 6: a[b]
constexpr int arr[3] = {};
SEQ(A(arr)[B(0)]);
SEQ(A(+arr)[B(0)]);
- // SEQ(A(0)[B(arr)]); FIXME
- // SEQ(A(0)[B(+arr)]); FIXME
+ SEQ(A(0)[B(arr)]); // expected-error {{not an integral constant expression}}
FIXME \
+ // expected-note 2{{in call to}}
+ SEQ(A(0)[B(+arr)]); // expected-error {{not an integral constant
expression}} FIXME \
+ // expected-note 2{{in call to}}
SEQ(A(ud)[B(0)]);
// Rule 7: a << b
___________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[llvm-branch-commits] [mlir] 50cb216 - Revert "[mlir] Optimize ThreadLocalCache by removing atomic bottleneck (#93270)"
Author: Jacques Pienaar
Date: 2024-05-24T07:45:37-07:00
New Revision: 50cb2160464ef916146c199ab8c9fe3ea9f054d6
URL:
https://github.com/llvm/llvm-project/commit/50cb2160464ef916146c199ab8c9fe3ea9f054d6
DIFF:
https://github.com/llvm/llvm-project/commit/50cb2160464ef916146c199ab8c9fe3ea9f054d6.diff
LOG: Revert "[mlir] Optimize ThreadLocalCache by removing atomic bottleneck
(#93270)"
This reverts commit 1b803fe53dda11ca63f008f5ab8e206f3954ce48.
Added:
Modified:
mlir/include/mlir/Support/ThreadLocalCache.h
Removed:
diff --git a/mlir/include/mlir/Support/ThreadLocalCache.h
b/mlir/include/mlir/Support/ThreadLocalCache.h
index d19257bf6e25e..1be94ca14bcfa 100644
--- a/mlir/include/mlir/Support/ThreadLocalCache.h
+++ b/mlir/include/mlir/Support/ThreadLocalCache.h
@@ -58,12 +58,11 @@ class ThreadLocalCache {
/// ValueT. We use a weak reference here so that the object can be destroyed
/// without needing to lock access to the cache itself.
struct CacheType
- : public llvm::SmallDenseMap, ValueT *>>
{
+ : public llvm::SmallDenseMap> {
~CacheType() {
// Remove the values of this cache that haven't already expired.
for (auto : *this)
-if (std::shared_ptr value = it.second.first.lock())
+if (std::shared_ptr value = it.second.lock())
it.first->remove(value.get());
}
@@ -72,7 +71,7 @@ class ThreadLocalCache {
void clearExpiredEntries() {
for (auto it = this->begin(), e = this->end(); it != e;) {
auto curIt = it++;
-if (curIt->second.first.expired())
+if (curIt->second.expired())
this->erase(curIt);
}
}
@@ -89,27 +88,22 @@ class ThreadLocalCache {
ValueT () {
// Check for an already existing instance for this thread.
CacheType = getStaticCache();
-std::pair, ValueT *> =
-staticCache[perInstanceState.get()];
-if (ValueT *value = threadInstance.second)
+std::weak_ptr =
staticCache[perInstanceState.get()];
+if (std::shared_ptr value = threadInstance.lock())
return *value;
// Otherwise, create a new instance for this thread.
-{
- llvm::sys::SmartScopedLock threadInstanceLock(
- perInstanceState->instanceMutex);
- threadInstance.second =
- perInstanceState->instances.emplace_back(std::make_unique())
- .get();
-}
-threadInstance.first =
-std::shared_ptr(perInstanceState, threadInstance.second);
+llvm::sys::SmartScopedLock threadInstanceLock(
+perInstanceState->instanceMutex);
+perInstanceState->instances.push_back(std::make_unique());
+ValueT *instance = perInstanceState->instances.back().get();
+threadInstance = std::shared_ptr(perInstanceState, instance);
// Before returning the new instance, take the chance to clear out any used
// entries in the static map. The cache is only cleared within the same
// thread to remove the need to lock the cache itself.
staticCache.clearExpiredEntries();
-return *threadInstance.second;
+return *instance;
}
ValueT *() { return get(); }
ValueT *operator->() { return (); }
___________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)
@@ -4640,6 +4647,306 @@ class FunctionNoProtoType : public FunctionType, public
llvm::FoldingSetNode {
}
};
+//
--
+
+/// Represents an abstract function effect, using just an enumeration
describing
+/// its kind.
+class FunctionEffect {
+public:
+ /// Identifies the particular effect.
+ enum class Kind : uint8_t {
+None = 0,
+NonBlocking = 1,
+NonAllocating = 2,
+Blocking = 3,
+Allocating = 4
+ };
+
+ /// Flags describing some behaviors of the effect.
+ using Flags = unsigned;
+ enum FlagBit : Flags {
+// Can verification inspect callees' implementations? (e.g. nonblocking:
+// yes, tcb+types: no). This also implies the need for 2nd-pass
+// verification.
+FE_InferrableOnCallees = 0x1,
+
+// Language constructs which effects can diagnose as disallowed.
+FE_ExcludeThrow = 0x2,
+FE_ExcludeCatch = 0x4,
+FE_ExcludeObjCMessageSend = 0x8,
+FE_ExcludeStaticLocalVars = 0x10,
+FE_ExcludeThreadLocalVars = 0x20
+ };
+
+private:
+ LLVM_PREFERRED_TYPE(Kind)
+ unsigned FKind : 3;
+
+ // Expansion: for hypothetical TCB+types, there could be one Kind for TCB,
+ // then ~16(?) bits "SubKind" to map to a specific named TCB. SubKind would
+ // be considered for uniqueness.
+
+public:
+ FunctionEffect() : FKind(unsigned(Kind::None)) {}
+
+ explicit FunctionEffect(Kind K) : FKind(unsigned(K)) {}
+
+ /// The kind of the effect.
+ Kind kind() const { return Kind(FKind); }
+
+ /// Return the opposite kind, for effects which have opposites.
+ Kind oppositeKind() const;
+
+ /// For serialization.
+ uint32_t toOpaqueInt32() const { return FKind; }
+ static FunctionEffect fromOpaqueInt32(uint32_t Value) {
+return FunctionEffect(Kind(Value));
+ }
+
+ /// Flags describing some behaviors of the effect.
+ Flags flags() const {
+switch (kind()) {
+case Kind::NonBlocking:
+ return FE_InferrableOnCallees | FE_ExcludeThrow | FE_ExcludeCatch |
+ FE_ExcludeObjCMessageSend | FE_ExcludeStaticLocalVars |
+ FE_ExcludeThreadLocalVars;
+case Kind::NonAllocating:
+ // Same as NonBlocking, except without FE_ExcludeStaticLocalVars.
+ return FE_InferrableOnCallees | FE_ExcludeThrow | FE_ExcludeCatch |
+ FE_ExcludeObjCMessageSend | FE_ExcludeThreadLocalVars;
+case Kind::Blocking:
+case Kind::Allocating:
+ return 0;
+case Kind::None:
+ break;
+}
+llvm_unreachable("unknown effect kind");
+ }
+
+ /// The description printed in diagnostics, e.g. 'nonblocking'.
+ StringRef name() const;
+
+ /// Return true if the effect is allowed to be inferred on the callee,
+ /// which is either a FunctionDecl or BlockDecl.
+ /// This is only used if the effect has FE_InferrableOnCallees flag set.
+ /// Example: This allows nonblocking(false) to prevent inference for the
+ /// function.
+ bool canInferOnFunction(const Decl ) const;
+
+ // Return false for success. When true is returned for a direct call, then
the
+ // FE_InferrableOnCallees flag may trigger inference rather than an immediate
+ // diagnostic. Caller should be assumed to have the effect (it may not have
it
+ // explicitly when inferring).
+ bool shouldDiagnoseFunctionCall(bool Direct,
+ ArrayRef CalleeFX) const;
+
+ friend bool operator==(const FunctionEffect , const FunctionEffect )
{
+return LHS.FKind == RHS.FKind;
+ }
+ friend bool operator!=(const FunctionEffect , const FunctionEffect )
{
+return !(LHS == RHS);
+ }
+ friend bool operator<(const FunctionEffect , const FunctionEffect ) {
+return LHS.FKind < RHS.FKind;
+ }
+};
+
+/// Wrap a function effect's condition expression in another struct so
+/// that FunctionProtoType's TrailingObjects can treat it separately.
+class FunctionEffectCondition {
Sirraide wrote:
Makes sense to me. That’s a lot less confusing imo.
https://github.com/llvm/llvm-project/pull/84983
_______
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #93302)
@@ -4849,9 +4852,12 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef MangledName, llvm::Type *Ty, Entry->setLinkage(llvm::Function::ExternalLinkage); } -// Handle dropped DLL attributes. -if (D && !D->hasAttr() && !D->hasAttr() && -!shouldMapVisibilityToDLLExport(D)) +// Handle dropped dllimport. +if (D && +(Entry->getDLLStorageClass() == + llvm::GlobalVariable::DLLImportStorageClass) && +!D->hasAttr() && +!shouldMapVisibilityToDLLExport(cast_or_null(D))) nga888 wrote: This part of the code isn't directly related to the change but I assume I can go ahead and change it? https://github.com/llvm/llvm-project/pull/93302 _______ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)
https://github.com/dougsonos edited https://github.com/llvm/llvm-project/pull/84983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)
https://github.com/dougsonos edited https://github.com/llvm/llvm-project/pull/84983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] d8c8c8c - [clang][Interp] Diagnose dummy assignments differently
ray());
diff --git a/clang/test/AST/Interp/cxx03.cpp b/clang/test/AST/Interp/cxx03.cpp
index b6aaf0840cfb3..70ae4134842b5 100644
--- a/clang/test/AST/Interp/cxx03.cpp
+++ b/clang/test/AST/Interp/cxx03.cpp
@@ -24,3 +24,8 @@ namespace NonLValueMemberExpr {
const int ::subobj_init = PODType().value;
}
+
+void LambdaAccessingADummy() {
+ int d;
+ int a9[1] = {[d = 0] = 1}; // both-error {{is not an integral constant
expression}}
+}
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] add fallback to expr in the template differ when comparing ValueDecl (PR #93266)
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/93266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] ad190fc - [clang] add fallback to expr in the template differ when comparing ValueDecl (#93266)
Author: Matheus Izvekov
Date: 2024-05-24T11:38:22-03:00
New Revision: ad190fcf15c1d0beea1ba93b4d250e15d2e944f4
URL:
https://github.com/llvm/llvm-project/commit/ad190fcf15c1d0beea1ba93b4d250e15d2e944f4
DIFF:
https://github.com/llvm/llvm-project/commit/ad190fcf15c1d0beea1ba93b4d250e15d2e944f4.diff
LOG: [clang] add fallback to expr in the template differ when comparing
ValueDecl (#93266)
Added:
Modified:
clang/docs/ReleaseNotes.rst
clang/lib/AST/ASTDiagnostic.cpp
clang/test/Misc/diag-template-diffing-cxx26.cpp
Removed:
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index f612a1fd36859..fd7f3ee13d9ac 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -803,6 +803,7 @@ Miscellaneous Bug Fixes
- Fixed an infinite recursion in ASTImporter, on return type declared inside
body of C++11 lambda without trailing return (#GH68775).
- Fixed declaration name source location of instantiated function definitions
(GH71161).
+- Improve diagnostic output to print an expression instead of 'no argument`
when comparing Values as template arguments.
Miscellaneous Clang Crashes Fixed
^
diff --git a/clang/lib/AST/ASTDiagnostic.cpp b/clang/lib/AST/ASTDiagnostic.cpp
index 5c7afaaf2ca8f..0680ff5e3a385 100644
--- a/clang/lib/AST/ASTDiagnostic.cpp
+++ b/clang/lib/AST/ASTDiagnostic.cpp
@@ -1936,6 +1936,11 @@ class TemplateDiff {
return;
}
+if (E) {
+ PrintExpr(E);
+ return;
+}
+
OS << "(no argument)";
}
diff --git a/clang/test/Misc/diag-template-
diff ing-cxx26.cpp b/clang/test/Misc/diag-template-
diff ing-cxx26.cpp
index cc174d6c334fb..2b6dd86a9885d 100644
--- a/clang/test/Misc/diag-template-
diff ing-cxx26.cpp
+++ b/clang/test/Misc/diag-template-
diff ing-cxx26.cpp
@@ -19,10 +19,10 @@ namespace GH93068 {
// expected-note@#A {{no known conversion from 'A<0>' to 'const A<[1]>
&' for 1st argument}}
// expected-note@#A {{no known conversion from 'A<0>' to 'A<[1]> &&' for
1st argument}}
-// notree-error@#2 {{no viable conversion from 'A' to 'A<(no
argument)>'}}
+// notree-error@#2 {{no viable conversion from 'A' to 'A'}}
/* tree-error@#2 {{no viable conversion
A<
-[n != (no argument)]>}}*/
+[n != n + 1]>}}*/
A v2 = A(); // #2
// expected-note@#A {{no known conversion from 'A' to 'const A<[1]>
&' for 1st argument}}
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] add fallback to expr in the template differ when comparing ValueDecl (PR #93266)
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/93266
>From 5b592204ddef177d612f8455f4e14ab9cf9c06bd Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Thu, 23 May 2024 23:57:01 -0300
Subject: [PATCH] [clang] add fallback to expr in the template differ when
comparing ValueDecl
---
clang/docs/ReleaseNotes.rst | 1 +
clang/lib/AST/ASTDiagnostic.cpp | 5 +
clang/test/Misc/diag-template-diffing-cxx26.cpp | 4 ++--
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index f612a1fd36859..fd7f3ee13d9ac 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -803,6 +803,7 @@ Miscellaneous Bug Fixes
- Fixed an infinite recursion in ASTImporter, on return type declared inside
body of C++11 lambda without trailing return (#GH68775).
- Fixed declaration name source location of instantiated function definitions
(GH71161).
+- Improve diagnostic output to print an expression instead of 'no argument`
when comparing Values as template arguments.
Miscellaneous Clang Crashes Fixed
^
diff --git a/clang/lib/AST/ASTDiagnostic.cpp b/clang/lib/AST/ASTDiagnostic.cpp
index 5c7afaaf2ca8f..0680ff5e3a385 100644
--- a/clang/lib/AST/ASTDiagnostic.cpp
+++ b/clang/lib/AST/ASTDiagnostic.cpp
@@ -1936,6 +1936,11 @@ class TemplateDiff {
return;
}
+if (E) {
+ PrintExpr(E);
+ return;
+}
+
OS << "(no argument)";
}
diff --git a/clang/test/Misc/diag-template-diffing-cxx26.cpp
b/clang/test/Misc/diag-template-diffing-cxx26.cpp
index cc174d6c334fb..2b6dd86a9885d 100644
--- a/clang/test/Misc/diag-template-diffing-cxx26.cpp
+++ b/clang/test/Misc/diag-template-diffing-cxx26.cpp
@@ -19,10 +19,10 @@ namespace GH93068 {
// expected-note@#A {{no known conversion from 'A<0>' to 'const A<[1]>
&' for 1st argument}}
// expected-note@#A {{no known conversion from 'A<0>' to 'A<[1]> &&' for
1st argument}}
-// notree-error@#2 {{no viable conversion from 'A' to 'A<(no
argument)>'}}
+// notree-error@#2 {{no viable conversion from 'A' to 'A'}}
/* tree-error@#2 {{no viable conversion
A<
-[n != (no argument)]>}}*/
+[n != n + 1]>}}*/
A v2 = A(); // #2
// expected-note@#A {{no known conversion from 'A' to 'const A<[1]>
&' for 1st argument}}
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[jenkinsci/badge-plugin] 376e52: chore(deps): bump io.jenkins.tools.bom:bom-2.426.x...
Branch: refs/heads/refactoring_for_new_major_version Home: https://github.com/jenkinsci/badge-plugin Commit: 376e52cc9fc372a44744ab922d8fdafea2cd2460 https://github.com/jenkinsci/badge-plugin/commit/376e52cc9fc372a44744ab922d8fdafea2cd2460 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: 2024-05-24 (Fri, 24 May 2024) Changed paths: M pom.xml Log Message: --- chore(deps): bump io.jenkins.tools.bom:bom-2.426.x (#157) Bumps [io.jenkins.tools.bom:bom-2.426.x](https://github.com/jenkinsci/bom) from 3056.v53343b_a_b_a_850 to 3080.vfa_b_e4a_a_39b_44. - [Release notes](https://github.com/jenkinsci/bom/releases) - [Commits](https://github.com/jenkinsci/bom/commits) --- updated-dependencies: - dependency-name: io.jenkins.tools.bom:bom-2.426.x dependency-type: direct:production ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Commit: 28ce6ecef783e1051329be91cddc16bf56e88e30 https://github.com/jenkinsci/badge-plugin/commit/28ce6ecef783e1051329be91cddc16bf56e88e30 Author: strangelookingnerd <49242855+strangelookingn...@users.noreply.github.com> Date: 2024-05-24 (Fri, 24 May 2024) Changed paths: M pom.xml Log Message: --- Merge branch 'master' into refactoring_for_new_major_version Compare: https://github.com/jenkinsci/badge-plugin/compare/010aaf024145...28ce6ecef783 To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/badge-plugin/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/badge-plugin/push/refs/heads/refactoring_for_new_major_version/010aaf-28ce6e%40github.com.
[jenkinsci/badge-plugin]
Branch: refs/heads/dependabot/maven/io.jenkins.tools.bom-bom-2.426.x-3080.vfa_b_e4a_a_39b_44 Home: https://github.com/jenkinsci/badge-plugin To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/badge-plugin/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/badge-plugin/push/refs/heads/dependabot/maven/io.jenkins.tools.bom-bom-2.426.x-3080.vfa_b_e4a_a_39b_44/6482c8-00%40github.com.
[jenkinsci/badge-plugin] 376e52: chore(deps): bump io.jenkins.tools.bom:bom-2.426.x...
Branch: refs/heads/master Home: https://github.com/jenkinsci/badge-plugin Commit: 376e52cc9fc372a44744ab922d8fdafea2cd2460 https://github.com/jenkinsci/badge-plugin/commit/376e52cc9fc372a44744ab922d8fdafea2cd2460 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: 2024-05-24 (Fri, 24 May 2024) Changed paths: M pom.xml Log Message: --- chore(deps): bump io.jenkins.tools.bom:bom-2.426.x (#157) Bumps [io.jenkins.tools.bom:bom-2.426.x](https://github.com/jenkinsci/bom) from 3056.v53343b_a_b_a_850 to 3080.vfa_b_e4a_a_39b_44. - [Release notes](https://github.com/jenkinsci/bom/releases) - [Commits](https://github.com/jenkinsci/bom/commits) --- updated-dependencies: - dependency-name: io.jenkins.tools.bom:bom-2.426.x dependency-type: direct:production ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/badge-plugin/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/badge-plugin/push/refs/heads/master/45d76d-376e52%40github.com.
[clang] [clang] add fallback to expr in the template differ when comparing ValueDecl (PR #93266)
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/93266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Avoid crash due to unimplemented StructuralValue support in the template differ (PR #93265)
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/93265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] bd851ee - [clang] Avoid crash due to unimplemented StructuralValue support in the template differ (#93265)
t->getDefaultArgument().getArgument().getAsExpr();
}
+
+if (!Iter.hasDesugaredTA())
+ return;
+
+const TemplateArgument = Iter.getDesugaredTA();
+switch (TA.getKind()) {
+case TemplateArgument::StructuralValue:
+ // FIXME: Diffing of structural values is not implemented.
+ //Just fall back to the expression.
+ return;
+case TemplateArgument::Integral:
+ Value = TA.getAsIntegral();
+ HasInt = true;
+ IntType = TA.getIntegralType();
+ return;
+case TemplateArgument::Declaration: {
+ VD = TA.getAsDecl();
+ QualType ArgType = TA.getParamTypeForDecl();
+ QualType VDType = VD->getType();
+ if (ArgType->isPointerType() &&
+ Context.hasSameType(ArgType->getPointeeType(), VDType))
+NeedAddressOf = true;
+ return;
+}
+case TemplateArgument::NullPtr:
+ IsNullPtr = true;
+ return;
+case TemplateArgument::Expression:
+ // TODO: Sometimes, the desugared template argument Expr
diff ers from
+ // the sugared template argument Expr. It may be useful in the future
+ // but for now, it is just discarded.
+ if (!E)
+E = TA.getAsExpr();
+ return;
+case TemplateArgument::Null:
+case TemplateArgument::Type:
+case TemplateArgument::Template:
+case TemplateArgument::TemplateExpansion:
+ llvm_unreachable("TemplateArgument kind is not expected for NTTP");
+case TemplateArgument::Pack:
+ llvm_unreachable("TemplateArgument kind should be handled elsewhere");
+}
+llvm_unreachable("Unexpected TemplateArgument kind");
}
/// DiffNonTypes - Handles any template parameters not handled by DiffTypes
diff --git a/clang/test/Misc/diag-template-
diff ing.cpp b/clang/test/Misc/diag-template-
diff ing-cxx11.cpp
similarity index 100%
rename from clang/test/Misc/diag-template-
diff ing.cpp
rename to clang/test/Misc/diag-template-
diff ing-cxx11.cpp
diff --git a/clang/test/Misc/diag-template-
diff ing-cxx26.cpp b/clang/test/Misc/diag-template-
diff ing-cxx26.cpp
new file mode 100644
index 0..cc174d6c334fb
--- /dev/null
+++ b/clang/test/Misc/diag-template-
diff ing-cxx26.cpp
@@ -0,0 +1,49 @@
+// RUN: %clang_cc1 -fsyntax-only %s -std=c++26
-verify=expected,notree
+// RUN: %clang_cc1 -fsyntax-only %s -std=c++26 -fno-elide-type
-verify=expected,notree
+// RUN: %clang_cc1 -fsyntax-only %s -std=c++26
-fdiagnostics-show-template-tree -verify=expected,tree
+// RUN: %clang_cc1 -fsyntax-only %s -std=c++26 -fno-elide-type
-fdiagnostics-show-template-tree -verify=expected,tree
+
+namespace GH93068 {
+ int n[2];
+
+ template struct A {}; // #A
+
+ namespace t1 {
+// notree-error@#1 {{no viable conversion from 'A<0>' to 'A'}}
+
+/* tree-error@#1 {{no viable conversion
+ A<
+[0 != n + 1]>}}*/
+
+A v1 = A<0>(); // #1
+// expected-note@#A {{no known conversion from 'A<0>' to 'const A<[1]>
&' for 1st argument}}
+// expected-note@#A {{no known conversion from 'A<0>' to 'A<[1]> &&' for
1st argument}}
+
+// notree-error@#2 {{no viable conversion from 'A' to 'A<(no
argument)>'}}
+/* tree-error@#2 {{no viable conversion
+ A<
+[n != (no argument)]>}}*/
+
+A v2 = A(); // #2
+// expected-note@#A {{no known conversion from 'A' to 'const A<[1]>
&' for 1st argument}}
+// expected-note@#A {{no known conversion from 'A' to 'A<[1]> &&' for
1st argument}}
+ } // namespace t1
+
+ namespace t2 {
+A v1;
+A v2;
+
+// notree-note@#A {{no known conversion from 'A' to 'const A<(no
argument)>' for 1st argument}}
+// notree-note@#A {{no known conversion from 'A' to 'A<(no argument)>'
for 1st argument}}
+
+/* tree-note@#A {{no known conversion from argument type to parameter type
for 1st argument
+ [(no qualifiers) != const] A<
+[n != (no argument)]>}}*/
+
+/* tree-note@#A {{no known conversion from argument type to parameter type
for 1st argument
+ A<
+[n != (no argument)]>}}*/
+
+void f() { v2 = v1; } // expected-error {{no viable overloaded '='}}
+ } // namespace t2
+} // namespace GH93068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Avoid crash due to unimplemented StructuralValue support in the template differ (PR #93265)
tDefaultArgument().getArgument().getAsExpr();
}
+
+if (!Iter.hasDesugaredTA())
+ return;
+
+const TemplateArgument = Iter.getDesugaredTA();
+switch (TA.getKind()) {
+case TemplateArgument::StructuralValue:
+ // FIXME: Diffing of structural values is not implemented.
+ //Just fall back to the expression.
+ return;
+case TemplateArgument::Integral:
+ Value = TA.getAsIntegral();
+ HasInt = true;
+ IntType = TA.getIntegralType();
+ return;
+case TemplateArgument::Declaration: {
+ VD = TA.getAsDecl();
+ QualType ArgType = TA.getParamTypeForDecl();
+ QualType VDType = VD->getType();
+ if (ArgType->isPointerType() &&
+ Context.hasSameType(ArgType->getPointeeType(), VDType))
+NeedAddressOf = true;
+ return;
+}
+case TemplateArgument::NullPtr:
+ IsNullPtr = true;
+ return;
+case TemplateArgument::Expression:
+ // TODO: Sometimes, the desugared template argument Expr differs from
+ // the sugared template argument Expr. It may be useful in the future
+ // but for now, it is just discarded.
+ if (!E)
+E = TA.getAsExpr();
+ return;
+case TemplateArgument::Null:
+case TemplateArgument::Type:
+case TemplateArgument::Template:
+case TemplateArgument::TemplateExpansion:
+ llvm_unreachable("TemplateArgument kind is not expected for NTTP");
+case TemplateArgument::Pack:
+ llvm_unreachable("TemplateArgument kind should be handled elsewhere");
+}
+llvm_unreachable("Unexpected TemplateArgument kind");
}
/// DiffNonTypes - Handles any template parameters not handled by DiffTypes
diff --git a/clang/test/Misc/diag-template-diffing.cpp
b/clang/test/Misc/diag-template-diffing-cxx11.cpp
similarity index 100%
rename from clang/test/Misc/diag-template-diffing.cpp
rename to clang/test/Misc/diag-template-diffing-cxx11.cpp
diff --git a/clang/test/Misc/diag-template-diffing-cxx26.cpp
b/clang/test/Misc/diag-template-diffing-cxx26.cpp
new file mode 100644
index 0..cc174d6c334fb
--- /dev/null
+++ b/clang/test/Misc/diag-template-diffing-cxx26.cpp
@@ -0,0 +1,49 @@
+// RUN: %clang_cc1 -fsyntax-only %s -std=c++26
-verify=expected,notree
+// RUN: %clang_cc1 -fsyntax-only %s -std=c++26 -fno-elide-type
-verify=expected,notree
+// RUN: %clang_cc1 -fsyntax-only %s -std=c++26
-fdiagnostics-show-template-tree -verify=expected,tree
+// RUN: %clang_cc1 -fsyntax-only %s -std=c++26 -fno-elide-type
-fdiagnostics-show-template-tree -verify=expected,tree
+
+namespace GH93068 {
+ int n[2];
+
+ template struct A {}; // #A
+
+ namespace t1 {
+// notree-error@#1 {{no viable conversion from 'A<0>' to 'A'}}
+
+/* tree-error@#1 {{no viable conversion
+ A<
+[0 != n + 1]>}}*/
+
+A v1 = A<0>(); // #1
+// expected-note@#A {{no known conversion from 'A<0>' to 'const A<[1]>
&' for 1st argument}}
+// expected-note@#A {{no known conversion from 'A<0>' to 'A<[1]> &&' for
1st argument}}
+
+// notree-error@#2 {{no viable conversion from 'A' to 'A<(no
argument)>'}}
+/* tree-error@#2 {{no viable conversion
+ A<
+[n != (no argument)]>}}*/
+
+A v2 = A(); // #2
+// expected-note@#A {{no known conversion from 'A' to 'const A<[1]>
&' for 1st argument}}
+// expected-note@#A {{no known conversion from 'A' to 'A<[1]> &&' for
1st argument}}
+ } // namespace t1
+
+ namespace t2 {
+A v1;
+A v2;
+
+// notree-note@#A {{no known conversion from 'A' to 'const A<(no
argument)>' for 1st argument}}
+// notree-note@#A {{no known conversion from 'A' to 'A<(no argument)>'
for 1st argument}}
+
+/* tree-note@#A {{no known conversion from argument type to parameter type
for 1st argument
+ [(no qualifiers) != const] A<
+[n != (no argument)]>}}*/
+
+/* tree-note@#A {{no known conversion from argument type to parameter type
for 1st argument
+ A<
+[n != (no argument)]>}}*/
+
+void f() { v2 = v1; } // expected-error {{no viable overloaded '='}}
+ } // namespace t2
+} // namespace GH93068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #93302)
@@ -4849,9 +4852,12 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef MangledName, llvm::Type *Ty, Entry->setLinkage(llvm::Function::ExternalLinkage); } -// Handle dropped DLL attributes. -if (D && !D->hasAttr() && !D->hasAttr() && -!shouldMapVisibilityToDLLExport(D)) +// Handle dropped dllimport. +if (D && +(Entry->getDLLStorageClass() == + llvm::GlobalVariable::DLLImportStorageClass) && +!D->hasAttr() && +!shouldMapVisibilityToDLLExport(cast_or_null(D))) pogo59 wrote: ```suggestion !shouldMapVisibilityToDLLExport(cast(D))) ``` D is non-null here. https://github.com/llvm/llvm-project/pull/93302 _______ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[jenkinsci/nodelabelparameter-plugin] 7fc1c1: Bump io.jenkins.tools.bom:bom-2.426.x (#312)
Branch: refs/heads/master Home: https://github.com/jenkinsci/nodelabelparameter-plugin Commit: 7fc1c11f12faeb1ae01c8935333eb0c31fb50812 https://github.com/jenkinsci/nodelabelparameter-plugin/commit/7fc1c11f12faeb1ae01c8935333eb0c31fb50812 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: 2024-05-24 (Fri, 24 May 2024) Changed paths: M pom.xml Log Message: --- Bump io.jenkins.tools.bom:bom-2.426.x (#312) To unsubscribe from these emails, change your notification settings at https://github.com/jenkinsci/nodelabelparameter-plugin/settings/notifications -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/nodelabelparameter-plugin/push/refs/heads/master/c6976d-7fc1c1%40github.com.
[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #93302)
@@ -4554,8 +4554,11 @@ llvm::Constant *CodeGenModule::GetOrCreateLLVMFunction(
Entry->setLinkage(llvm::Function::ExternalLinkage);
}
-// Handle dropped DLL attributes.
-if (D && !D->hasAttr() && !D->hasAttr() &&
+// Handle dropped dllimport.
+if (D &&
+(Entry->getDLLStorageClass() ==
+ llvm::GlobalVariable::DLLImportStorageClass) &&
+!D->hasAttr() &&
!shouldMapVisibilityToDLLExport(cast_or_null(D))) {
pogo59 wrote:
```suggestion
!shouldMapVisibilityToDLLExport(cast(D))) {
```
D is non-null here.
https://github.com/llvm/llvm-project/pull/93302
_______
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #93302)
https://github.com/pogo59 edited https://github.com/llvm/llvm-project/pull/93302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #93302)
https://github.com/pogo59 commented: Does the test exercise both modified paths? I'm guessing it only exercises GetOrCreateLLVMFunction, but I'm not a codegen expert. https://github.com/llvm/llvm-project/pull/93302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
