[GitHub] zeppelin issue #2911: ZEPPELIN-3332 Zeppelin login fails with NPE if ldapRea...
Github user felixalbani commented on the issue: https://github.com/apache/zeppelin/pull/2911 @Leemoonsoo ---
[GitHub] zeppelin issue #2911: ZEPPELIN-3332 Zeppelin login fails with NPE if ldapRea...
Github user felixalbani commented on the issue: https://github.com/apache/zeppelin/pull/2911 I created this new PR since previous PR https://github.com/apache/zeppelin/pull/2867 was not created from master. Sorry for any inconveniences. ---
[GitHub] zeppelin pull request #2911: Zeppelin 3332
GitHub user felixalbani opened a pull request: https://github.com/apache/zeppelin/pull/2911 Zeppelin 3332 ### What is this PR for? Simply fixes NPE by checking for null ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3332 ### Questions: Does the licenses files need update? No Is there breaking changes for older versions? No Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/felixalbani/zeppelin ZEPPELIN-3332 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2911.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2911 commit dd7d37dac991fc04ec6287fe05235e027e20e1f2 Author: bag_of_tricks <falbani@...> Date: 2018-04-05T16:21:23Z ZEPPELIN-3332 Simply fixes NPE by checking for null commit 622333eb925870b5b4a2ce22da063b9857dd3da1 Author: bag_of_tricks <falbani@...> Date: 2018-04-05T16:24:01Z Revert "ZEPPELIN-3332" This reverts commit dd7d37dac991fc04ec6287fe05235e027e20e1f2. commit c6ccf4189ad50c09749b2a06d5fb61830075ab84 Author: bag_of_tricks <falbani@...> Date: 2018-04-05T16:27:18Z ZEPPELIN-3332 Simply fixes NPE by checking for null ---
[GitHub] zeppelin pull request #2867: ZEPPELIN-3332 Zeppelin login fails with NPE if ...
Github user felixalbani closed the pull request at: https://github.com/apache/zeppelin/pull/2867 ---
[GitHub] spark issue #20883: [SPARK-23759][UI] Unable to bind Spark UI to specific ho...
Github user felixalbani commented on the issue: https://github.com/apache/spark/pull/20883 @mgaido91 Thanks, I updated description with your suggestions --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20883: [SPARK-23759][UI] Unable to bind Spark UI to specific ho...
Github user felixalbani commented on the issue: https://github.com/apache/spark/pull/20883 @gerashegalov Updated the PR title --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20883: [SPARK-23759][UI] Unable to bind Spark2 history server t...
Github user felixalbani commented on the issue: https://github.com/apache/spark/pull/20883 Removed "Please review ..." remnants from template --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20883: [SPARK-23759][UI] Unable to bind Spark2 history server t...
Github user felixalbani commented on the issue: https://github.com/apache/spark/pull/20883 @vanzin I closed https://github.com/apache/spark/pull/20867 and open this one against master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20883: [SPARK-23759][UI] Unable to bind Spark2 history s...
GitHub user felixalbani opened a pull request: https://github.com/apache/spark/pull/20883 [SPARK-23759][UI] Unable to bind Spark2 history server to specific ho⦠â¦st name / IP Fixes SPARK-23759 by moving connector.start() after connector.setHost() ## What changes were proposed in this pull request? This pull is to fix SPARK-23759 issue Problem was created due connector.setHost(hostName) call was after connector.start() ## How was this patch tested? Patch was tested after build and deployment. This patch requires SPARK_LOCAL_IP environment variable to be set on spark-env.sh Please review http://spark.apache.org/contributing.html before opening a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/felixalbani/spark SPARK-23759 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/20883.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20883 commit 4bed6be070883c8a845a6cc651b0e056fe976538 Author: bag_of_tricks <falbani@...> Date: 2018-03-22T19:24:53Z [SPARK-23759][UI] Unable to bind Spark2 history server to specific host name / IP Fixes SPARK-23759 by moving connector.start() after connector.setHost() --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20867: [SPARK-23759][UI] Unable to bind Spark2 history s...
Github user felixalbani closed the pull request at: https://github.com/apache/spark/pull/20867 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20867: [SPARK-23759][UI] Unable to bind Spark2 history server t...
Github user felixalbani commented on the issue: https://github.com/apache/spark/pull/20867 @vanzin I changed the base branch from master to branch-2.2 - 2 days ago - do I still need to close this and create it again? (its my first PR - my apologies for any inconvenience) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20867: [SPARK-23759][UI] Unable to bind Spark2 history server t...
Github user felixalbani commented on the issue: https://github.com/apache/spark/pull/20867 @mgaido91 I pushed the start() after setAcceptQueueSize in new commit --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20867: Spark 23759
GitHub user felixalbani reopened a pull request: https://github.com/apache/spark/pull/20867 Spark 23759 ## What changes were proposed in this pull request? This pull is to fix SPARK-23759 issue Problem was created due connector.setHost(hostName) call was after connector.start() ## How was this patch tested? Patch was tested after build and deployment. This patch requires SPARK_LOCAL_IP environment variable to be set on spark-env.sh Please review http://spark.apache.org/contributing.html before opening a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/felixalbani/spark SPARK-23759 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/20867.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20867 commit f9d1293991b34a80b4fa11a846812e3a79e1493f Author: bag_of_tricks <falbani@...> Date: 2018-03-20T22:46:55Z Solution to SPARK-23759 is to setHost before starting the connector Solution to SPARK-23759 is to setHost before starting the connector. I run few tests and was able to confirm the binding happens as expected. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20867: Spark 23759
Github user felixalbani closed the pull request at: https://github.com/apache/spark/pull/20867 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20867: Spark 23759
GitHub user felixalbani opened a pull request: https://github.com/apache/spark/pull/20867 Spark 23759 ## What changes were proposed in this pull request? This pull is to fix SPARK-23759 issue Problem was created due connector.setHost(hostName) call was after connector.start() ## How was this patch tested? Patch was tested after build and deployment. This patch requires SPARK_LOCAL_IP environment variable to be set on spark-env.sh Please review http://spark.apache.org/contributing.html before opening a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/felixalbani/spark SPARK-23759 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/20867.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20867 commit edcd9fbc92683753d55ed0c69f391bf3bed59da4 Author: Shixiong Zhu <shixiong@...> Date: 2017-07-11T03:26:17Z [SPARK-21369][CORE] Don't use Scala Tuple2 in common/network-* ## What changes were proposed in this pull request? Remove all usages of Scala Tuple2 from common/network-* projects. Otherwise, Yarn users cannot use `spark.reducer.maxReqSizeShuffleToMem`. ## How was this patch tested? Jenkins. Author: Shixiong Zhu <shixi...@databricks.com> Closes #18593 from zsxwing/SPARK-21369. (cherry picked from commit 833eab2c9bd273ee9577fbf9e480d3e3a4b7d203) Signed-off-by: Wenchen Fan <wenc...@databricks.com> commit 399aa016e8f44fea4e5ef4b71a9a80484dd755f8 Author: Xingbo Jiang <xingbo.jiang@...> Date: 2017-07-11T13:52:54Z [SPARK-21366][SQL][TEST] Add sql test for window functions ## What changes were proposed in this pull request? Add sql test for window functions, also remove uncecessary test cases in `WindowQuerySuite`. ## How was this patch tested? Added `window.sql` and the corresponding output file. Author: Xingbo Jiang <xingbo.ji...@databricks.com> Closes #18591 from jiangxb1987/window. (cherry picked from commit 66d21686556681457aab6e44e19f5614c5635f0c) Signed-off-by: Wenchen Fan <wenc...@databricks.com> commit cb6fc89ba20a427fa7d66fa5036b17c1a5d5d87f Author: Eric Vandenberg <ericvandenberg@...> Date: 2017-07-12T06:49:15Z [SPARK-21219][CORE] Task retry occurs on same executor due to race co⦠â¦ndition with blacklisting There's a race condition in the current TaskSetManager where a failed task is added for retry (addPendingTask), and can asynchronously be assigned to an executor *prior* to the blacklist state (updateBlacklistForFailedTask), the result is the task might re-execute on the same executor. This is particularly problematic if the executor is shutting down since the retry task immediately becomes a lost task (ExecutorLostFailure). Another side effect is that the actual failure reason gets obscured by the retry task which never actually executed. There are sample logs showing the issue in the https://issues.apache.org/jira/browse/SPARK-21219 The fix is to change the ordering of the addPendingTask and updatingBlackListForFailedTask calls in TaskSetManager.handleFailedTask Implemented a unit test that verifies the task is black listed before it is added to the pending task. Ran the unit test without the fix and it fails. Ran the unit test with the fix and it passes. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Eric Vandenberg Closes #18427 from ericvandenbergfb/blacklistFix. ## What changes were proposed in this pull request? This is a backport of the fix to SPARK-21219, already checked in as 96d58f2. ## How was this patch tested? Ran TaskSetManagerSuite tests locally. Author: Eric Vandenberg <ericvandenb...@fb.com> Closes #18604 from jsoltren/branch-2.2. commit 39eba3053ac99f03d9df56471bae5fc5cc9f4462 Author: Kohki Nishio <taroplus@...> Date: 2017-07-13T00:22:40Z [SPARK-18646][REPL] Set parent classloader as null for ExecutorClassLoader ## What changes were proposed in this pull request? `ClassLoader` will preferentially load class from `parent`. Only when `parent` is null or the load failed, that it will call the overridden `findClass` function. To avoid the potential issue caused by loading class using inappropriate class loader, we should set the `parent` of `ClassLoader` to null, so that we can fully control which class loader is used. This is take over of #17074, the primary author of this PR is taroplus . Should close #17074 after this PR get merged.
[GitHub] zeppelin pull request #2867: ZEPPELIN-3332
GitHub user felixalbani opened a pull request: https://github.com/apache/zeppelin/pull/2867 ZEPPELIN-3332 Zeppelin login fails with NPE if ldapRealm.authorizationEnabled is not set true Issue was introduced by pull https://github.com/apache/zeppelin/pull/2498 ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html ### What type of PR is it? Bug Fix ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3332 ### How should this be tested? * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/felixalbani/zeppelin ZEPPELIN-3332 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2867.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2867 commit ceb7b6f837cfe196fd1a9b51abbffe0c31ee7e71 Author: bag_of_tricks <falbani@...> Date: 2018-03-14T14:44:25Z ZEPPELIN-3332 Zeppelin login fails with NPE if ldapRealm.authorizationEnabled is not set true Issue was introduced by pull https://github.com/apache/zeppelin/pull/2498 ---
[GitHub] nifi pull request #2089: Nifi-ldap-iaa support for PasswordComparisonAuthent...
GitHub user felixalbani opened a pull request: https://github.com/apache/nifi/pull/2089 Nifi-ldap-iaa support for PasswordComparisonAuthenticator Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/felixalbani/nifi-1 NIFI-4293 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2089.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2089 commit 3c8749d5d72d742f65c1890f6f60cd6f58dbe906 Author: Felix Albani <falb...@hortonworks.com> Date: 2017-08-15T18:47:23Z Nifi-ldap-iaa support for PasswordComparisonAuthenticator --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
