[jira] [Commented] (CASSANDRA-15407) Hint-dispatcher file-channel not closed, if "open()" fails with OOM
[ https://issues.apache.org/jira/browse/CASSANDRA-15407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979175#comment-16979175 ] Alex Petrov commented on CASSANDRA-15407: - Closing since it is committed. > Hint-dispatcher file-channel not closed, if "open()" fails with OOM > --- > > Key: CASSANDRA-15407 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15407 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Hints >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-alpha > > > Some places in the code base do not to close the file (some channel-proxy) in > case of errors. We should close the channel-proxy in those cases - at least > to not make the situation (due to that OOM) even worse. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15407) Hint-dispatcher file-channel not closed, if "open()" fails with OOM
[ https://issues.apache.org/jira/browse/CASSANDRA-15407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978493#comment-16978493 ] Robert Stupp commented on CASSANDRA-15407: -- +1 Committed as [c2e11bd4224b2110abe6aa84c8882e85980e3491|https://github.com/apache/cassandra/commit/c2e11bd4224b2110abe6aa84c8882e85980e3491] to [trunk|https://github.com/apache/cassandra/tree/trunk] > Hint-dispatcher file-channel not closed, if "open()" fails with OOM > --- > > Key: CASSANDRA-15407 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15407 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Hints >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > Some places in the code base do not to close the file (some channel-proxy) in > case of errors. We should close the channel-proxy in those cases - at least > to not make the situation (due to that OOM) even worse. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15407) Hint-dispatcher file-channel not closed, if "open()" fails with OOM
[ https://issues.apache.org/jira/browse/CASSANDRA-15407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974542#comment-16974542 ] Ekaterina Dimitrova commented on CASSANDRA-15407: - Tests completed successfully. Patch ready for review/commit > Hint-dispatcher file-channel not closed, if "open()" fails with OOM > --- > > Key: CASSANDRA-15407 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15407 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Hints >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > Some places in the code base do not to close the file (some channel-proxy) in > case of errors. We should close the channel-proxy in those cases - at least > to not make the situation (due to that OOM) even worse. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15407) Hint-dispatcher file-channel not closed, if "open()" fails with OOM
[ https://issues.apache.org/jira/browse/CASSANDRA-15407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971688#comment-16971688 ] Ekaterina Dimitrova commented on CASSANDRA-15407: - Patch implemented: [https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-15407-trunk] The build was tested locally. Currently running the Jenkins tests before submission for review. > Hint-dispatcher file-channel not closed, if "open()" fails with OOM > --- > > Key: CASSANDRA-15407 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15407 > Project: Cassandra > Issue Type: Bug >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > > Some places in the code base do not to close the file (some channel-proxy) in > case of errors. We should close the channel-proxy in those cases - at least > to not make the situation (due to that OOM) even worse. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
