[jira] [Commented] (CASSANDRA-15460) Fix missing call to enable RPC after native transport is started in in-jvm dtests

2020-01-29 Thread Alex Petrov (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026094#comment-17026094
 ] 

Alex Petrov commented on CASSANDRA-15460:
-

Thank you for the patch.

+1 from my side, too.

Committed to 2.2 with 
[f7ee96c74f783b42e520d26d278eafaca2a59678|https://github.com/apache/cassandra/commit/f7ee96c74f783b42e520d26d278eafaca2a59678]
 and merged up to 
[3.0|https://github.com/apache/cassandra/commit/f1d07ac198b61b6b989a4744263d98b73007c340],
 
[3.11|https://github.com/apache/cassandra/commit/02e551aa6a062cf72e712a092166792e0e9442e9],
 and 
[trunk|https://github.com/apache/cassandra/commit/609bac6bbd424d0fe5fe149ab367eaf54110c185].

> Fix missing call to enable RPC after native transport is started in in-jvm 
> dtests
> -
>
> Key: CASSANDRA-15460
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15460
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/dtest
>Reporter: Doug Rohrer
>Assignee: Doug Rohrer
>Priority: Normal
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When starting the native transport, the original patch missed the step of 
> calling {{StorageService.instance.setRpcReady(true);}}. This appears to only 
> be required for counter columns, but without it you can't update a counter 
> value.
> We should add this call after starting up the native transport, and set it to 
> {{false}} during the shutdown sequence to mimic the production code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-15460) Fix missing call to enable RPC after native transport is started in in-jvm dtests

2019-12-19 Thread Yifan Cai (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000572#comment-17000572
 ] 

Yifan Cai commented on CASSANDRA-15460:
---

Thanks [~drohrer]. The patch LGTM. +1

> Fix missing call to enable RPC after native transport is started in in-jvm 
> dtests
> -
>
> Key: CASSANDRA-15460
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15460
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/dtest
>Reporter: Doug Rohrer
>Assignee: Doug Rohrer
>Priority: Normal
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When starting the native transport, the original patch missed the step of 
> calling {{StorageService.instance.setRpcReady(true);}}. This appears to only 
> be required for counter columns, but without it you can't update a counter 
> value.
> We should add this call after starting up the native transport, and set it to 
> {{false}} during the shutdown sequence to mimic the production code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org