[jira] [Updated] (CASSANDRA-15460) Fix missing call to enable RPC after native transport is started in in-jvm dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-15460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-15460:
Component/s: (was: Test/dtest/python)
Test/dtest/java
> Fix missing call to enable RPC after native transport is started in in-jvm
> dtests
> -
>
> Key: CASSANDRA-15460
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15460
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Doug Rohrer
>Assignee: Doug Rohrer
>Priority: Normal
> Labels: pull-request-available
> Fix For: 2.2.16, 3.0.20, 3.11.6, 4.0, 4.0-alpha3
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When starting the native transport, the original patch missed the step of
> calling {{StorageService.instance.setRpcReady(true);}}. This appears to only
> be required for counter columns, but without it you can't update a counter
> value.
> We should add this call after starting up the native transport, and set it to
> {{false}} during the shutdown sequence to mimic the production code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15460) Fix missing call to enable RPC after native transport is started in in-jvm dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-15460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-15460:
Fix Version/s: 4.0
3.11.6
3.0.20
2.2.16
Since Version: 2.2.15
Source Control Link:
https://github.com/apache/cassandra/commit/f7ee96c74f783b42e520d26d278eafaca2a59678
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Fix missing call to enable RPC after native transport is started in in-jvm
> dtests
> -
>
> Key: CASSANDRA-15460
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15460
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Doug Rohrer
>Assignee: Doug Rohrer
>Priority: Normal
> Labels: pull-request-available
> Fix For: 2.2.16, 3.0.20, 3.11.6, 4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When starting the native transport, the original patch missed the step of
> calling {{StorageService.instance.setRpcReady(true);}}. This appears to only
> be required for counter columns, but without it you can't update a counter
> value.
> We should add this call after starting up the native transport, and set it to
> {{false}} during the shutdown sequence to mimic the production code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15460) Fix missing call to enable RPC after native transport is started in in-jvm dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-15460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-15460:
Status: Ready to Commit (was: Review In Progress)
> Fix missing call to enable RPC after native transport is started in in-jvm
> dtests
> -
>
> Key: CASSANDRA-15460
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15460
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Doug Rohrer
>Assignee: Doug Rohrer
>Priority: Normal
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When starting the native transport, the original patch missed the step of
> calling {{StorageService.instance.setRpcReady(true);}}. This appears to only
> be required for counter columns, but without it you can't update a counter
> value.
> We should add this call after starting up the native transport, and set it to
> {{false}} during the shutdown sequence to mimic the production code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15460) Fix missing call to enable RPC after native transport is started in in-jvm dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-15460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15460:
--
Reviewers: Alex Petrov, David Capwell, Yifan Cai, David Capwell (was: Alex
Petrov, David Capwell, Yifan Cai)
Alex Petrov, David Capwell, Yifan Cai, David Capwell (was: Alex
Petrov, Yifan Cai)
Status: Review In Progress (was: Patch Available)
LGTM, +1
Minor nit (aka feel free to ignore). If you modify startNativeTransport and
destroyNativeTransport to set this flag, then no change is needed in dtest.
> Fix missing call to enable RPC after native transport is started in in-jvm
> dtests
> -
>
> Key: CASSANDRA-15460
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15460
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Doug Rohrer
>Assignee: Doug Rohrer
>Priority: Normal
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When starting the native transport, the original patch missed the step of
> calling {{StorageService.instance.setRpcReady(true);}}. This appears to only
> be required for counter columns, but without it you can't update a counter
> value.
> We should add this call after starting up the native transport, and set it to
> {{false}} during the shutdown sequence to mimic the production code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15460) Fix missing call to enable RPC after native transport is started in in-jvm dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-15460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yifan Cai updated CASSANDRA-15460:
--
Reviewers: Alex Petrov, Yifan Cai (was: Alex Petrov)
> Fix missing call to enable RPC after native transport is started in in-jvm
> dtests
> -
>
> Key: CASSANDRA-15460
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15460
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Doug Rohrer
>Assignee: Doug Rohrer
>Priority: Normal
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When starting the native transport, the original patch missed the step of
> calling {{StorageService.instance.setRpcReady(true);}}. This appears to only
> be required for counter columns, but without it you can't update a counter
> value.
> We should add this call after starting up the native transport, and set it to
> {{false}} during the shutdown sequence to mimic the production code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15460) Fix missing call to enable RPC after native transport is started in in-jvm dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-15460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Doug Rohrer updated CASSANDRA-15460:
Test and Documentation Plan: Patch in Github PR #399 includes new unit test
for counter updates.
Status: Patch Available (was: Open)
> Fix missing call to enable RPC after native transport is started in in-jvm
> dtests
> -
>
> Key: CASSANDRA-15460
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15460
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Doug Rohrer
>Assignee: Doug Rohrer
>Priority: Normal
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When starting the native transport, the original patch missed the step of
> calling {{StorageService.instance.setRpcReady(true);}}. This appears to only
> be required for counter columns, but without it you can't update a counter
> value.
> We should add this call after starting up the native transport, and set it to
> {{false}} during the shutdown sequence to mimic the production code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15460) Fix missing call to enable RPC after native transport is started in in-jvm dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-15460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CASSANDRA-15460:
---
Labels: pull-request-available (was: )
> Fix missing call to enable RPC after native transport is started in in-jvm
> dtests
> -
>
> Key: CASSANDRA-15460
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15460
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Doug Rohrer
>Assignee: Doug Rohrer
>Priority: Normal
> Labels: pull-request-available
>
> When starting the native transport, the original patch missed the step of
> calling {{StorageService.instance.setRpcReady(true);}}. This appears to only
> be required for counter columns, but without it you can't update a counter
> value.
> We should add this call after starting up the native transport, and set it to
> {{false}} during the shutdown sequence to mimic the production code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15460) Fix missing call to enable RPC after native transport is started in in-jvm dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-15460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Doug Rohrer updated CASSANDRA-15460:
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Low Hanging Fruit
Discovered By: Unit Test
Reviewers: Alex Petrov
Severity: Normal
Assignee: Doug Rohrer
Status: Open (was: Triage Needed)
> Fix missing call to enable RPC after native transport is started in in-jvm
> dtests
> -
>
> Key: CASSANDRA-15460
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15460
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Doug Rohrer
>Assignee: Doug Rohrer
>Priority: Normal
>
> When starting the native transport, the original patch missed the step of
> calling {{StorageService.instance.setRpcReady(true);}}. This appears to only
> be required for counter columns, but without it you can't update a counter
> value.
> We should add this call after starting up the native transport, and set it to
> {{false}} during the shutdown sequence to mimic the production code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
