Repository: spark Updated Branches: refs/heads/master 8319432af -> 2f962422a
[MINOR][ML] Remove unnecessary default value setting for evaluators. ## What changes were proposed in this pull request? Remove unnecessary default value setting for all evaluators, as we have set them in corresponding _HasXXX_ base classes. ## How was this patch tested? Existing tests. Author: Yanbo Liang <yblia...@gmail.com> Closes #19262 from yanboliang/evaluation. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/2f962422 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/2f962422 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/2f962422 Branch: refs/heads/master Commit: 2f962422a25020582c915e15819f91f43c0b9d68 Parents: 8319432 Author: Yanbo Liang <yblia...@gmail.com> Authored: Tue Sep 19 22:22:35 2017 +0800 Committer: Yanbo Liang <yblia...@gmail.com> Committed: Tue Sep 19 22:22:35 2017 +0800 ---------------------------------------------------------------------- python/pyspark/ml/evaluation.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/2f962422/python/pyspark/ml/evaluation.py ---------------------------------------------------------------------- diff --git a/python/pyspark/ml/evaluation.py b/python/pyspark/ml/evaluation.py index 7cb8d62..09cdf9b 100644 --- a/python/pyspark/ml/evaluation.py +++ b/python/pyspark/ml/evaluation.py @@ -146,8 +146,7 @@ class BinaryClassificationEvaluator(JavaEvaluator, HasLabelCol, HasRawPrediction super(BinaryClassificationEvaluator, self).__init__() self._java_obj = self._new_java_obj( "org.apache.spark.ml.evaluation.BinaryClassificationEvaluator", self.uid) - self._setDefault(rawPredictionCol="rawPrediction", labelCol="label", - metricName="areaUnderROC") + self._setDefault(metricName="areaUnderROC") kwargs = self._input_kwargs self._set(**kwargs) @@ -224,8 +223,7 @@ class RegressionEvaluator(JavaEvaluator, HasLabelCol, HasPredictionCol, super(RegressionEvaluator, self).__init__() self._java_obj = self._new_java_obj( "org.apache.spark.ml.evaluation.RegressionEvaluator", self.uid) - self._setDefault(predictionCol="prediction", labelCol="label", - metricName="rmse") + self._setDefault(metricName="rmse") kwargs = self._input_kwargs self._set(**kwargs) @@ -297,8 +295,7 @@ class MulticlassClassificationEvaluator(JavaEvaluator, HasLabelCol, HasPredictio super(MulticlassClassificationEvaluator, self).__init__() self._java_obj = self._new_java_obj( "org.apache.spark.ml.evaluation.MulticlassClassificationEvaluator", self.uid) - self._setDefault(predictionCol="prediction", labelCol="label", - metricName="f1") + self._setDefault(metricName="f1") kwargs = self._input_kwargs self._set(**kwargs) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
