[jira] [Commented] (HADOOP-14676) Wrong default value for "fs.df.interval"
[ https://issues.apache.org/jira/browse/HADOOP-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108403#comment-16108403 ] Konstantin Shvachko commented on HADOOP-14676: -- +1 Looks good. > Wrong default value for "fs.df.interval" > > > Key: HADOOP-14676 > URL: https://issues.apache.org/jira/browse/HADOOP-14676 > Project: Hadoop Common > Issue Type: Bug > Components: common, conf, fs >Affects Versions: 2.6.1 >Reporter: Konstantin Shvachko >Assignee: xiangguang zheng > Attachments: HADOOP-14676.001.patch > > > According to {{core-default.xml}} the default value of {{fs.df.interval = 60 > sec}}. But the implementation of {{DF}} substitutes 3 sec instead. The > problem is that {{DF}} uses outdated constant {{DF.DF_INTERVAL_DEFAULT}} > instead of the correct one > {{CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14676) Wrong default value for "fs.df.interval"
[ https://issues.apache.org/jira/browse/HADOOP-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108092#comment-16108092 ] xiangguang zheng commented on HADOOP-14676: --- [~shv] Could you take a look when you have a chance? > Wrong default value for "fs.df.interval" > > > Key: HADOOP-14676 > URL: https://issues.apache.org/jira/browse/HADOOP-14676 > Project: Hadoop Common > Issue Type: Bug > Components: common, conf, fs >Affects Versions: 2.6.1 >Reporter: Konstantin Shvachko >Assignee: xiangguang zheng > Attachments: HADOOP-14676.001.patch > > > According to {{core-default.xml}} the default value of {{fs.df.interval = 60 > sec}}. But the implementation of {{DF}} substitutes 3 sec instead. The > problem is that {{DF}} uses outdated constant {{DF.DF_INTERVAL_DEFAULT}} > instead of the correct one > {{CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14676) Wrong default value for "fs.df.interval"
[ https://issues.apache.org/jira/browse/HADOOP-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105846#comment-16105846 ] xiangguang zheng commented on HADOOP-14676: --- The manual steps I did to verify is to compile and run the unit test towards hadoop common module. When I run the test, there were 9 test failure and 1 test error. But I have verified that those failure and errors existed in hadoop trunk before I made any changes, and none of test failure/error was related to this patch > Wrong default value for "fs.df.interval" > > > Key: HADOOP-14676 > URL: https://issues.apache.org/jira/browse/HADOOP-14676 > Project: Hadoop Common > Issue Type: Bug > Components: common, conf, fs >Affects Versions: 2.6.1 >Reporter: Konstantin Shvachko >Assignee: xiangguang zheng > Attachments: HADOOP-14676.001.patch > > > According to {{core-default.xml}} the default value of {{fs.df.interval = 60 > sec}}. But the implementation of {{DF}} substitutes 3 sec instead. The > problem is that {{DF}} uses outdated constant {{DF.DF_INTERVAL_DEFAULT}} > instead of the correct one > {{CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14676) Wrong default value for "fs.df.interval"
[ https://issues.apache.org/jira/browse/HADOOP-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105812#comment-16105812 ] Hadoop QA commented on HADOOP-14676: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m 16s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 19m 9s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 44s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 50s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 53s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 13m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 13m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s{color} | {color:green} hadoop-common-project/hadoop-common: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m 25s{color} | {color:green} hadoop-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 33s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 75m 12s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:14b5c93 | | JIRA Issue | HADOOP-14676 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12879434/HADOOP-14676.001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 0323f0016078 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 713349a | | Default Java | 1.8.0_131 | | findbugs | v3.1.0-RC1 | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/12889/testReport/ | | modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/12889/console | | Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Wrong default value for "fs.df.interval" > > > Key: HADOOP-14676 > URL: https://issues.apache.org/jira/browse/HADOOP-14676 > Project: Hadoop Common > Issue Type: Bug > Components: common, conf, fs >Affects Versions: 2.6.1 >Reporter: Konstantin Shvachko >Assignee: xiangguang zheng > Attachments: HADOOP-14676.001.patch
[jira] [Commented] (HADOOP-14676) Wrong default value for "fs.df.interval"
[ https://issues.apache.org/jira/browse/HADOOP-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105579#comment-16105579 ] Hadoop QA commented on HADOOP-14676: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 23s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m 1s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 14m 55s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 37s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 27s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 24s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 50s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 11m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 36s{color} | {color:green} hadoop-common-project/hadoop-common: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 27s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 36s{color} | {color:green} hadoop-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 32s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 59m 53s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:14b5c93 | | JIRA Issue | HADOOP-14676 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12879404/HADOOP-14676.000.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux f081ca315932 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 746189a | | Default Java | 1.8.0_131 | | findbugs | v3.1.0-RC1 | | whitespace | https://builds.apache.org/job/PreCommit-HADOOP-Build/12886/artifact/patchprocess/whitespace-eol.txt | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/12886/testReport/ | | modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/12886/console | | Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Wrong default value for "fs.df.interval" > > > Key: HADOOP-14676 > URL: https://issues.apache.org/jira/browse/HADOOP-14676 > Project: Hadoop Common > Issue Type:
[jira] [Commented] (HADOOP-14676) Wrong default value for "fs.df.interval"
[ https://issues.apache.org/jira/browse/HADOOP-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105433#comment-16105433 ] Hadoop QA commented on HADOOP-14676: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 40s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m 50s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 36s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 27s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 24s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 50s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 10m 13s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 35s{color} | {color:orange} hadoop-common-project/hadoop-common: The patch generated 1 new + 4 unchanged - 1 fixed = 5 total (was 5) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 58s{color} | {color:red} hadoop-common in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 30s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 61m 32s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.security.TestRaceWhenRelogin | | | hadoop.security.TestKDiag | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:14b5c93 | | JIRA Issue | HADOOP-14676 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12879382/HADOOP-14676.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 27c090312e4b 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 9ea01fd | | Default Java | 1.8.0_131 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-HADOOP-Build/12884/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt | | unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/12884/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/12884/testReport/ | | modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/12884/console | | Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Wrong default value for "fs.df.interval" >
[jira] [Commented] (HADOOP-14676) Wrong default value for "fs.df.interval"
[ https://issues.apache.org/jira/browse/HADOOP-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105363#comment-16105363 ] Erik Krogen commented on HADOOP-14676: -- Hey [~zhengxg3], thanks for working on this. A few things: * When you upload the patch you should put a version name in it, e.g. HADOOP-14676.000.patch. This helps us to track the revisions of the patch as we go through the review-update cycle. Also, I think it might be required for Jenkins to run the precommit build against your patch. * I don't think {{DF.DF_INTERVAL_DEFAULT}} is used anywhere anymore, can you confirm this and if so then delete it altogether? * Please don't use wildcard ({{*}}) imports. > Wrong default value for "fs.df.interval" > > > Key: HADOOP-14676 > URL: https://issues.apache.org/jira/browse/HADOOP-14676 > Project: Hadoop Common > Issue Type: Bug > Components: common, conf, fs >Affects Versions: 2.6.1 >Reporter: Konstantin Shvachko >Assignee: xiangguang zheng > Attachments: HADOOP-14676.patch > > > According to {{core-default.xml}} the default value of {{fs.df.interval = 60 > sec}}. But the implementation of {{DF}} substitutes 3 sec instead. The > problem is that {{DF}} uses outdated constant {{DF.DF_INTERVAL_DEFAULT}} > instead of the correct one > {{CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14676) Wrong default value for "fs.df.interval"
[ https://issues.apache.org/jira/browse/HADOOP-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105321#comment-16105321 ] xiangguang zheng commented on HADOOP-14676: --- Please review the code, I modified the DF.java to use the CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT instead of outdated DF.DF_INTERVAL_DEFAULT > Wrong default value for "fs.df.interval" > > > Key: HADOOP-14676 > URL: https://issues.apache.org/jira/browse/HADOOP-14676 > Project: Hadoop Common > Issue Type: Bug > Components: common, conf, fs >Affects Versions: 2.6.1 >Reporter: Konstantin Shvachko >Assignee: xiangguang zheng > Attachments: HADOOP-14676.patch > > > According to {{core-default.xml}} the default value of {{fs.df.interval = 60 > sec}}. But the implementation of {{DF}} substitutes 3 sec instead. The > problem is that {{DF}} uses outdated constant {{DF.DF_INTERVAL_DEFAULT}} > instead of the correct one > {{CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14676) Wrong default value for "fs.df.interval"
[ https://issues.apache.org/jira/browse/HADOOP-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105307#comment-16105307 ] xiangguang zheng commented on HADOOP-14676: --- [^HADOOP-14676.patch] > Wrong default value for "fs.df.interval" > > > Key: HADOOP-14676 > URL: https://issues.apache.org/jira/browse/HADOOP-14676 > Project: Hadoop Common > Issue Type: Bug > Components: common, conf, fs >Affects Versions: 2.6.1 >Reporter: Konstantin Shvachko >Assignee: xiangguang zheng > > According to {{core-default.xml}} the default value of {{fs.df.interval = 60 > sec}}. But the implementation of {{DF}} substitutes 3 sec instead. The > problem is that {{DF}} uses outdated constant {{DF.DF_INTERVAL_DEFAULT}} > instead of the correct one > {{CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org