Re: RFR: 8330205: Initial troff manpage generation for JDK 24
On Mon, 10 Jun 2024 02:31:00 GMT, David Holmes wrote: > Sets the version to 24/24-ea and the copyright year to 2025. > > Content changes related to the start of release (e.g. for removed options in > java.1) are handled separately. > > This initial generation also picks up the unpublished changes from: > > - JDK-8330807: Update Manpage for obsoletion of ScavengeBeforeFullGC > - JDK-8284500: Typo in Supported Named Extensions - BasicContraints > - JDK-8324342: Doclet should default `@since` for a nested class to that of > its enclosing class > > Thanks Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19617#pullrequestreview-2108383696
Re: RFR: 8330182: Start of release updates for JDK 24 [v12]
On Wed, 5 Jun 2024 15:35:18 GMT, Joe Darcy wrote: >> Get JDK 24 underway. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 23 commits: > > - Update copyright. > - Updated problem list after bug fix. > - Merge branch 'master' into JDK-8330188 > - Merge branch 'master' into JDK-8330188 > - Temporarily problem list java.lang.instrument tests until jar generation > is fixed. > - Merge branch 'master' into JDK-8330188 > - Update symbol files for JDK 23 build 25. > - Correct release year. > - Merge branch 'master' into JDK-8330188 > - Add symbol files current with JDK 23 build 24. > - ... and 13 more: https://git.openjdk.org/jdk/compare/4369856c...f4a5026b Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2099585754
Re: RFR: 8332750: Broken link in CatalogFeatures.html
On Tue, 4 Jun 2024 21:17:43 GMT, Joe Wang wrote: > Fix a broken link. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19551#pullrequestreview-2097432388
Re: RFR: 8333398: Uncomment the commented test in test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java
On Mon, 3 Jun 2024 04:25:38 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which uncomments an > additional test that was commented out in > `test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java`? > > As noted in https://bugs.openjdk.org/browse/JDK-898, the original issue > due to which this line was commented out in the test, has been fixed several > releases back and thus this line can now be uncommented. > > I've verified that this test continues to pass with these changes. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19514#pullrequestreview-2092824056
Re: RFR: 8331879: Clean up non-standard use of /// comments in `java.base` [v2]
On Tue, 28 May 2024 22:31:15 GMT, Jonathan Gibbons wrote: >> With the advent of JEP 467, `///` comments may be treated as documentation >> comments, and may be subject to the recently new `javac` warning about >> "dangling doc comments" in unexpected places. >> >> In keeping with the policy to keep the `java.base` module free of all >> `javac` warnings, this patch proposes edits to existing uses of `///`. >> >> There are two dominant policies in the proposed changes. >> 1. A long horizontal line of `/` is replaced by `//-` >> 2. A long vertical series of lines beginning `///` is replaced by lines >> beginning `//|`. >> >> As with all style changes, I have also tried to honor local usage, for >> consistency. >> >> In one place, a pair of comments appeared to contain directives >> (`CLOVER:ON`, `CLOVER:OFF`). I investigated the use of such comments to >> determine that the exact form of the comment prefix was not significant. >> (Phew!) >> >> >> (This PR is informally blocked by JEP 467). > > Jonathan Gibbons has updated the pull request incrementally with one > additional commit since the last revision: > > incorporate review comments Thanks for making these updates. To my eye, replacement of "///" with "//---" is preferable over "//|", but I think either choice is acceptable. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19130#pullrequestreview-2091379761
Re: RFR: 8330182: Start of release updates for JDK 24 [v10]
On Thu, 30 May 2024 17:11:31 GMT, Joe Darcy wrote: >> Get JDK 24 underway. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 18 commits: > > - Merge branch 'master' into JDK-8330188 > - Update symbol files for JDK 23 build 25. > - Correct release year. > - Merge branch 'master' into JDK-8330188 > - Add symbol files current with JDK 23 build 24. > - Merge branch 'master' into JDK-8330188 > - Merge branch 'master' into JDK-8330188 > - Fix-up test. > - Merge branch 'master' into JDK-8330188 > - Adjust test for deprecated options. > - ... and 8 more: https://git.openjdk.org/jdk/compare/32636dcc...39a028c3 Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2089018766
Re: RFR: 8332749: Broken link in MemorySegment.Scope.html
On Thu, 23 May 2024 11:39:11 GMT, Per Minborg wrote: > This PR proposes to fix a broken link in the `MemorySegment.Scope` class. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19366#pullrequestreview-2074232921
Re: RFR: 8330182: Start of release updates for JDK 24 [v5]
On Mon, 20 May 2024 22:42:20 GMT, Joe Darcy wrote: >> Get JDK 24 underway. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 11 commits: > > - Fix-up test. > - Merge branch 'master' into JDK-8330188 > - Adjust test for deprecated options. > - Merge branch 'master' into JDK-8330188 > - Update deprecated options test. > - Merge branch 'master' into JDK-8330188 > - Merge branch 'master' into JDK-8330188 > - Merge branch 'master' into JDK-8330188 > - Correct release date as observed in review feedback. > - Improve javadoc of class file update. > - ... and 1 more: https://git.openjdk.org/jdk/compare/d6b7f9b1...128f53a3 Still looks good. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2067401131
Re: RFR: 8332424: Update IANA Language Subtag Registry to Version 2024-05-16
On Fri, 17 May 2024 18:04:02 GMT, Justin Lu wrote: > Please review this PR which is a trivial update to the IANA sub tag registry > to version 2024-05-16. Locale tests pass as expected after update. > > Associated announcement -> > https://mm.icann.org/pipermail/ietf-languages-announcements/2024-May/91.html Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19286#pullrequestreview-2064365331
Re: RFR: 8331957: Release Note: System Property for Java SE Specification Maintenance Version
On Thu, 9 May 2024 00:49:43 GMT, xiaotaonan wrote: > …ersion > > Release Note: System Property for Java SE Specification Maintenance Version This system property should not be set for a feature release. It should only be set if there has been a JCP Maintenance Release. Perhaps this PR should be against a different repo? - Changes requested by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19149#pullrequestreview-2047019025
Re: RFR: 8330182: Start of release updates for JDK 24 [v3]
On Mon, 29 Apr 2024 22:50:26 GMT, Joe Darcy wrote: >> Get JDK 24 underway. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains seven additional commits since > the last revision: > > - Update deprecated options test. > - Merge branch 'master' into JDK-8330188 > - Merge branch 'master' into JDK-8330188 > - Merge branch 'master' into JDK-8330188 > - Correct release date as observed in review feedback. > - Improve javadoc of class file update. > - JDK-8330182: Start of release updates for JDK 24 >JDK-8330183: Add SourceVersion.RELEASE_24 >JDK-8330184: Add source 24 and target 24 to javac Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2030298396
Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc [v3]
On Wed, 24 Apr 2024 08:54:53 GMT, Jin Kwon wrote: >> Fix typos within the `DatabaseMetaData.java`. > > Jin Kwon has updated the pull request incrementally with one additional > commit since the last revision: > > 8330686: Fix typos in the DatabaseMetaData javadoc > > Reviewed-by: jpai Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18860#pullrequestreview-2020930726
Re: RFR: 8330178: Clean up non-standard use of /** comments in `java.base` [v2]
On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote: >> Please review a set of updates to clean up use of `/**` comments in the >> vicinity of declarations. >> >> There are various categories of update: >> >> * "Box comments" beginning with `/**` >> * Misplaced doc comments before package or import statements >> * Misplaced doc comments after the annotations for a declaration >> * Dangling `/**` comments relating to a group of declarations, separate from >> the doc comments for each of those declarations >> * Use of `/**` for the legal header at or near the top of the file >> >> In one case, two doc comments before a declaration were merged, which fixes >> a bug/omission in the documented serialized form. > > Jonathan Gibbons has updated the pull request incrementally with one > additional commit since the last revision: > > Update > src/java.base/share/classes/sun/net/www/protocol/file/FileURLConnection.java > > Fix grammatical typo > > Co-authored-by: Alexey Ivanov Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18846#pullrequestreview-2016126206
Re: RFR: 8330178: Clean up non-standard use of /** comments in `java.base`
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote: > Please review a set of updates to clean up use of `/**` comments in the > vicinity of declarations. > > There are various categories of update: > > * "Box comments" beginning with `/**` > * Misplaced doc comments before package or import statements > * Misplaced doc comments after the annotations for a declaration > * Dangling `/**` comments relating to a group of declarations, separate from > the doc comments for each of those declarations > * Use of `/**` for the legal header at or near the top of the file > > In one case, two doc comments before a declaration were merged, which fixes a > bug/omission in the documented serialized form. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18846#pullrequestreview-2010068091
Re: RFR: 8330458: Add missing @since tag to ClassFile.JAVA_23_VERSION
On Wed, 17 Apr 2024 20:46:26 GMT, Joe Darcy wrote: > 8330458: Add missing @since tag to ClassFile.JAVA_23_VERSION Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18828#pullrequestreview-2007547483
Re: RFR: 8330182: Start of release updates for JDK 24 [v2]
On Wed, 17 Apr 2024 05:43:12 GMT, Joe Darcy wrote: >> Get JDK 24 underway. > > Joe Darcy has updated the pull request incrementally with two additional > commits since the last revision: > > - Correct release date as observed in review feedback. > - Improve javadoc of class file update. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2006604933
Re: RFR: 8329805: Deprecate for removal ObjectOutputStream.PutField.write
On Tue, 16 Apr 2024 19:44:36 GMT, Roger Riggs wrote: > The method `java.io.ObjectOutputStream.PutField.write` has been deprecated > since 1.4 and should be deprecated for removal. The Deprecation annotation is > updated to indicate the intention to remov the method. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18802#pullrequestreview-2004749149
Re: RFR: 8330279: Typo in `java.text.Bidi` class description
On Mon, 15 Apr 2024 19:39:41 GMT, Naoto Sato wrote: > Fixing a typo in the javadoc Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18788#pullrequestreview-2002041316
Re: RFR: 8330182: Start of release updates for JDK 24
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote: > Get JDK 24 underway. The copyright year was not updated in all files *14.java. I assume that's intentional. I've also Reviewed the associated CSRs. make/conf/version-numbers.conf line 36: > 34: DEFAULT_VERSION_EXTRA2=0 > 35: DEFAULT_VERSION_EXTRA3=0 > 36: DEFAULT_VERSION_DATE=2024-03-17 "2024-03-17"? I thought that the expected date was "2025-03-18"? - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2002002355 PR Review Comment: https://git.openjdk.org/jdk/pull/18787#discussion_r1566336599
Re: RFR: 8329787: Fix typo in CLDRConverter
On Fri, 5 Apr 2024 17:22:36 GMT, Naoto Sato wrote: > Fix a file/class name in the `CLDRConverter` build tool, with some clean-up > for a switch statement. I like the new switch! - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18662#pullrequestreview-1983822529
Re: RFR: 8328183: Minor mistakes in docs of PrintStream.append()
On Wed, 3 Apr 2024 19:01:14 GMT, Brian Burkhalter wrote: > Clarify the behavior of `append` for a `null` `CharSequence` parameter and > clean up a couple of other typos. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18607#pullrequestreview-1977785394
Re: RFR: JDK-8329557: Fix statement around MathContext.DECIMAL128 rounding
On Tue, 2 Apr 2024 23:43:24 GMT, Joe Darcy wrote: > Happened to notice a semantic typo in the description of > MathContext.DECIMAL128, use of "decimal64" where "decimal128" was intended, > and added some additional information to make the related descriptions more > informative. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18587#pullrequestreview-1975387023
Re: RFR: 8326627: Document Double/Float.valueOf(String) behaviour for numeric strings with non-ASCII digits
On Wed, 27 Mar 2024 19:58:17 GMT, Naoto Sato wrote: > Clarifying the behavior for non-ASCII digits in Double/Float.valueOf(String) > method descriptions. A draft CSR has also been created. Associated CSR also Reviewed. I like the relocation of existing text to the more appropriate `@apiNote`. The example provides additional clarity. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18526#pullrequestreview-1964850180
Re: RFR: 8328700: Unused import and variable should be deleted in regex package
On Fri, 22 Mar 2024 17:58:25 GMT, Raffaello Giulietti wrote: > Make use of an unused local variable probably intended to replace later casts. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18460#pullrequestreview-1955535154
Re: RFR: 8327180: Failed: java/io/ObjectStreamClass/ObjectStreamClassCaching.java#G1 [v3]
On Wed, 13 Mar 2024 20:10:25 GMT, Roger Riggs wrote: >> The intermittent failure of ObjectStreamClassCaching is due to an incorrect >> assumption about GC behavior and a race condition. >> >> Removed test based on incorrect assumptions about simultaneous clearing of >> WeakReferences. >> Added a run of the test using ZGC, (previously omitted) > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Use the correct ZGenerational collector Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18284#pullrequestreview-1935176824
Re: RFR: 8327180: Failed: java/io/ObjectStreamClass/ObjectStreamClassCaching.java#G1
On Wed, 13 Mar 2024 18:01:21 GMT, Roger Riggs wrote: > The intermittent failure of ObjectStreamClassCaching is due to an incorrect > assumption about GC behavior and a race condition. > > Removed test based on incorrect assumptions about simultaneous clearing of > WeakReferences. > Added a run of the test using ZGC, (previously omitted) Marked as reviewed by iris (Reviewer). test/jdk/java/io/ObjectStreamClass/ObjectStreamClassCaching.java line 53: > 51: /* > 52: * Disabled for ZGC Generational. > 53: * TODO: Find correct appropriate solution to the flakiness of this test. Shouldn't you also remove the comment at line 52 since this test is no longer disabled? - PR Review: https://git.openjdk.org/jdk/pull/18284#pullrequestreview-1934946970 PR Review Comment: https://git.openjdk.org/jdk/pull/18284#discussion_r1523749769
Re: RFR: 8327242: Document supported CLDR versions in the javadoc [v4]
On Wed, 13 Mar 2024 16:06:26 GMT, Naoto Sato wrote: >> Adding a table that maps JDK versions and corresponding CLDR releases as an >> implNote. A draft CSR has also been created. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Further refinement Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18243#pullrequestreview-1934843256
Re: RFR: 8327242: Document supported CLDR versions in the javadoc [v2]
On Tue, 12 Mar 2024 18:50:38 GMT, Naoto Sato wrote: >> Adding a table that maps JDK versions and corresponding CLDR releases as an >> implNote. A draft CSR has also been created. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflects review comments Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18243#pullrequestreview-1932235667
Re: RFR: 8327705: Remove mention of "applet" from java.text package description [v2]
On Mon, 11 Mar 2024 16:32:31 GMT, Naoto Sato wrote: >> Removing left over "applet" mention in the package-info doc. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Addressing review comments Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1928697079
Re: RFR: JDK-8327631: Update IANA Language Subtag Registry to Version 2024-03-07
On Thu, 7 Mar 2024 23:31:46 GMT, Justin Lu wrote: > Please review this PR which is a trivial update to the IANA sub tag registry > to version 2024-03-07. Tests pass as expected after update. > > Associated announcement -> > https://mm.icann.org/pipermail/ietf-languages-announcements/2024-March/90.html Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18159#pullrequestreview-1925817696
Re: RFR: 8327705: Remove mention of "applet" from java.text package description
On Fri, 8 Mar 2024 19:54:31 GMT, Naoto Sato wrote: > Removing left over "applet" mention in the package-info doc. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1925813600
Re: RFR: 8327167: Clarify the handling of Leap year by Calendar
On Thu, 7 Mar 2024 19:28:13 GMT, Naoto Sato wrote: > A simple doc update to include a leap day example in the `Calendar` class. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18158#pullrequestreview-1923843891
Re: RFR: 8327434: Test java/util/PluggableLocale/TimeZoneNameProviderTest.java timed out
On Wed, 6 Mar 2024 21:32:11 GMT, Naoto Sato wrote: > Fixing timeout failures in the test case. Time zone names that are missing > (chiefly for minor locales) are now calculated at runtime after the fix to > JDK-8174269. This extra calculation time was multiplied in the test case as > it iterated over all locales x timezones, which caused timeouts in some > configurations. Changed the test case to not iterate all locales, but iterate > over relevant ones. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18143#pullrequestreview-1921039503
Re: RFR: 8327208: Remove unused method java.util.jar.Manifest.make72Safe
On Mon, 4 Mar 2024 09:55:09 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which suggests we remove the package-private, > unused and deprecated method `java.util.jar.Manifest.make72Safe`. > > This method was marked deprecated after a cleanup/refactoring in > [JDK-8066619](https://bugs.openjdk.org/browse/JDK-8066619) caused it to fall > out of use. It should rather be removed. > > Some tests reference the `make72Safe` methods in comment, or implement the > legacy versions of the same logic to simulate pre JDK 11 line break behavior > of `Manifest.write`. These comments and method names are adjusted to not > reference the now removed method. > > This change was initially discussed here: > https://mail.openjdk.org/pipermail/core-libs-dev/2024-February/119819.html Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18104#pullrequestreview-1915271908
Re: RFR: 8326351: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3.1
On Tue, 20 Feb 2024 19:56:53 GMT, Lance Andersen wrote: > Please review the updates to open/src/java.base/share/legal/zlib.md to update > the file from zlib 1.2.13 to zlib 1.3.1 which was missed as part of the PR > for [JDK-8324632](https://bugs.openjdk.org/browse/JDK-8324632) Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17935#pullrequestreview-1891486155
Re: RFR: 8326158: Javadoc for java.time.DayOfWeek#minus(long)
On Tue, 20 Feb 2024 18:34:59 GMT, Naoto Sato wrote: > Fixing a typo in the said method. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17933#pullrequestreview-1891250872
Re: CFV: New Core Libraries Group Member: Raffaello Giulietti
Vote: yes Iris
Re: RFR: 8325150: (tz) Update Timezone Data to 2024a
On Wed, 7 Feb 2024 08:45:40 GMT, Johny Jose wrote: > Timezone data 2024a changes Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17743#pullrequestreview-1868554271
Re: [jdk22] RFR: 8322066: Update troff manpages in JDK 22 before RC
On Sun, 4 Feb 2024 22:43:28 GMT, David Holmes wrote: > This update drops the "ea" from the version string. > > We also propagate the following fixes from the markdown sources to the troff > manpage file: > > JDK-8322478: Update java manpage for multi-file source-code launcher > JDK-8302233: HSS/LMS: keytool and jarsigner changes > JDK-8318971: Better Error Handling for Jar Tool When Processing Non-existent > Files > > > Thanks. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/104#pullrequestreview-1864200734
Re: RFR: 8324998: Add test cases for String.regionMatches comparing Turkic dotted/dotless I with uppercase latin I
On Tue, 30 Jan 2024 19:57:01 GMT, Eirik Bjørsnøs wrote: > Please review this test-only PR which improves test coverage of > `String.regionMatches` when comparing the Turkic "dotted I" and "dotless i" > characters with their latin cousins. > > The test `CompactStrings/RegionMatches.java` currently includes cases > comparing these characters against the lowercase latin "i" character, but not > against the corresponding uppercase latin "I" character. It would be good to > add test cases for the uppercase I as well. > > This was originally found in #12637, which was closed without being > integrated. I think this test coverage enhancement is worth rescuing from > that PR, where it did prove to catch a regression. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17639#pullrequestreview-1852564646
Re: Integrated: 8271147: java/nio/file/Path.java javadoc typo
On Fri, 23 Jul 2021 03:37:44 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which fixes the typo noted in > https://bugs.openjdk.java.net/browse/JDK-8271147? `make docs-image` worked > fine and the generated javadoc looks fine. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/4884#pullrequestreview-713382247
Re: RFR: 8324632: Update Zlib Data Compression Library to Version 1.3.1
On Mon, 29 Jan 2024 16:57:00 GMT, Lance Andersen wrote: > Hi all, > > Please review this PR which updates zlib from 1.3 to 1.3.1 in OpenJDK > > The [Zlib Data Compression Library](https://github.com/madler/zlib) has > released Zlib 1.3.1 on January 24, 2024. > > There are a [small number of > updates](https://github.com/madler/zlib/compare/v1.3.1..v1.3) between 1.3 and > 1.3.1 > > Mach5 tiers1-3 have run clean I've spot-checked these files against the referenced diffs between v1.3.1 and v1.3 and confirm that they are as expected. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17619#pullrequestreview-1849300812
Re: RFR: 8324657: Intermittent OOME on exception message create
On Mon, 22 Jan 2024 20:52:32 GMT, Roger Riggs wrote: > When an exception handler for an OutOfMemoryError uses string concatenation > to compose an exception message, the invoke dynamic string format > implementation may itself exhaust memory, preventing the exception from being > handled. > Explicit use of String.concat() call can improve exception handling. > > Writing a test of the exact failure condition has proved challenging due to > the unpredictable state of memory when OOME occurs. The replacement of "+" > with String.concat() is simple and direct. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17522#pullrequestreview-1842436256
Re: RFR: JDK-6503196: API doc for DecimalFormat::getMaximumIntegerDigits is unclear
On Tue, 23 Jan 2024 18:40:42 GMT, Justin Lu wrote: > Please review this PR which clarifies some confusion for the digit getter and > setter methods of DecimalFormat. > > When formatting non `BigInteger` and `BigDecimal` values, DecimalFormat uses > 309/340 as hard limits for integer and fraction digit limits, regardless of > the value set by the user. There was some confusion, that those numbers might > be returned by the getters, when in reality, they are only used internally. > > Moving the 309/340 wording to the class description and linking to it reduces > the repetitive wording, but also eliminates the confusion that the getters > may return those values. This should be OK, as setting limits higher than > those values are likely rare, so the warning does not need to be in every > method description. > > Additionally, `getMaximumIntegerDigits()` is updated to point to the patterns > section to warn about the non-obvious rules for max integer digits. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17541#pullrequestreview-1840051983
Re: RFR: 8324065: Daylight saving information for `Africa/Casablanca` are incorrect [v2]
On Thu, 18 Jan 2024 21:02:26 GMT, Naoto Sato wrote: >> Fixing incorrect std/dst transitions for time zones that have rules beyond >> 2037. The year 2037 restriction seems to come from the old `zic` command >> implementation and thus can be expanded in the JDK. Arbitrary I chose 2100 >> which is greater than the year 2087 which is the farthest rule at the moment. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Added comment to clarify the possible need for the last year expansion Still looks good! - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17492#pullrequestreview-1830637536
Re: RFR: 8324065: Daylight saving information for `Africa/Casablanca` are incorrect
On Thu, 18 Jan 2024 19:37:33 GMT, Naoto Sato wrote: > Fixing incorrect std/dst transitions for time zones that have rules beyond > 2037. The year 2037 restriction seems to come from the old `zic` command > implementation and thus can be expanded in the JDK. Arbitrary I chose 2100 > which is greater than the year 2087 which is the farthest rule at the moment. Hopefully "2100" is unique enough that you'll be able to easily search/replace the next time you need to extend. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17492#pullrequestreview-1830530349
Re: [jdk22] RFR: 8322235: Split up and improve LocaleProvidersRun
On Fri, 12 Jan 2024 18:25:25 GMT, Justin Lu wrote: > Please review this PR which is a backport of commit > [4ea7b364](https://github.com/openjdk/jdk/commit/4ea7b36447ea96d62b1ca164c34e2b2b74a16579) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The original commit was a test-only change which optimized and split up the > LocaleProvidersRun.java test. Confirmed identical to changes in main-line. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk22/pull/68#pullrequestreview-1818908921
Re: [jdk22] RFR: 8323571: Regression in source resolution process
On Thu, 11 Jan 2024 22:56:38 GMT, Joe Wang wrote: > Backport to fix the regression introduced in JDK 22. Verified changes same as those in main-line. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk22/pull/63#pullrequestreview-1817021441
Re: [jdk22] RFR: 8320788: The system properties page is missing some properties
On Wed, 10 Jan 2024 20:56:14 GMT, Naoto Sato wrote: > Backporting the document only fix to jdk22 Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/59#pullrequestreview-1814223539
Re: [jdk22] RFR: 8320919: Clarify Locale related system properties
On Tue, 9 Jan 2024 23:55:30 GMT, Naoto Sato wrote: > Backporting the document clarification to JDK22 Confirmed that this change corresponds to the changes in main-line and the previously approved CSR. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk22/pull/47#pullrequestreview-1812224747
Re: RFR: 8320788: The system properties page is missing some properties [v2]
On Tue, 9 Jan 2024 19:23:53 GMT, Naoto Sato wrote: >> Adding an explanation of the locale-related system properties in the >> `System.getProperties()` method. Corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflects review comments Looks good. Associated CSR also Reviewed. Thanks for the clarification regarding the pending new section in Locale. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17317#pullrequestreview-1811895882
Re: [jdk22] RFR: 8321480: ISO 4217 Amendment 176 Update
On Tue, 9 Jan 2024 19:27:12 GMT, Justin Lu wrote: > Please review this PR which is the backport of the ISO 4217 Amendment 176 > Update. Commit > [8b24851b](https://github.com/openjdk/jdk/commit/8b24851b9d3619c41c7a6cdb9193ed26a9b732dc) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Confirmed changes identical to those in main-line. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk22/pull/45#pullrequestreview-1811892304
Re: RFR: 8320788: The system properties page is missing some properties
On Tue, 9 Jan 2024 00:51:28 GMT, Naoto Sato wrote:
> Adding an explanation of the locale-related system properties in the
> `System.getProperties()` method. Corresponding CSR has also been drafted.
src/java.base/share/classes/java/lang/System.java line 818:
> 816: * {@link #getProperty(String)} operation.
> 817: *
> 818: * In addition to the above set of system properties, locale related
I think I'd consider a slight reduction in the first/last phrases leaving this
equivalent statement:
Additional locale-related system properties defined by the {@link
Locale##default_locale Default Locale} section in the {@code Locale} class
description may also be obtained with this method.
(Note that I couldn't find the referenced Locale section, but perhaps I was
looking at an older version of the spec.)
-
PR Review Comment: https://git.openjdk.org/jdk/pull/17317#discussion_r1446489646
Re: [jdk22] RFR: 8322725: (tz) Update Timezone Data to 2023d
On Fri, 5 Jan 2024 17:05:04 GMT, Dan Lutker wrote: > Clean backport tzdata 2023d. > `make test TEST="test/jdk/java/util/TimeZone test/jdk/java/time/test > test/jdk/sun/util/resources test/jdk/sun/text/resources > test/jdk/sun/util/calendar"` is all passing Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/35#pullrequestreview-1811674978
Re: RFR: 8310995: missing @since tags in 36 jdk.dynalink classes
On Mon, 8 Jan 2024 13:24:55 GMT, Athijegannathan Sundararajan wrote: > Adding missing "@ since 9" in javadoc comment of the public classes, > interfaces and packages of the jdk.dynalink module. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17305#pullrequestreview-1809643551
Re: [jdk22] RFR: 8322214: Return value of XMLInputFactory.getProperty() changed from boolean to String in JDK 22 early access builds
On Thu, 4 Jan 2024 19:09:34 GMT, Joe Wang wrote: > backport of PR: https://github.com/openjdk/jdk/pull/17252 Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/32#pullrequestreview-1804849821
Re: RFR: 8322647: Short name for the `Europe/Lisbon` time zone is incorrect
On Fri, 22 Dec 2023 18:59:20 GMT, Naoto Sato wrote:
> This is a regression caused by the fix to
> [JDK-8317979](https://bugs.openjdk.org/browse/JDK-8317979), where the parsing
> of TZDB files was incorrect. With this fix, `TimeZoneNames_en.java` which is
> generated during the build time has the following diffs from the previous
> (incorrect) one:
>
> ---
> master/build/macosx-aarch64/support/gensrc/java.base/sun/util/resources/cldr/TimeZoneNames_en.java
> 2023-12-18 10:28:57
> +++
> tz/build/macosx-aarch64/support/gensrc/java.base/sun/util/resources/cldr/TimeZoneNames_en.java
> 2023-12-22 10:09:13
> @@ -304,11 +304,11 @@
> };
> final String[] Azores = new String[] {
> "Azores Standard Time",
> - "HMT",
> + "",
> "Azores Summer Time",
> - "HMT",
> + "",
> "Azores Time",
> - "HMT",
> + "",
> };
> final String[] Bhutan = new String[] {
> "Bhutan Time",
> @@ -968,11 +968,11 @@
> };
> final String[] Africa_Central = new String[] {
> "Central Africa Time",
> - "SAST",
> - "",
> - "SAST",
> + "CAT",
> "",
> - "SAST",
> + "CAT",
> + "",
> + "CAT",
> };
> final String[] Africa_Eastern = new String[] {
> "East Africa Time",
> @@ -1016,11 +1016,11 @@
> };
> final String[] Europe_Western = new String[] {
> "Western European Standard Time",
> - "FMT",
> - "Western European Summer Time",
> - "FMT",
> + "WET",
> + "Western European Summer Time",
> + "WEST",
> "Western European Time",
> - "FMT",
> + "WET",
> };
> final String[] Mexico_Pacific = new String[] {
> "Mexican Pacific Standard Time",
> @@ -1152,11 +1152,11 @@
> };
> final String[] Australia_Western = new String[] {
> "Australian Western Standard Time",
> - "",
> + "AWST",
> "Australian Western Daylight Time",
> - "",
> + "AWDT",
> "Western Australia Time",
> - "",
> + "AWT",
> };
> final String[] Greenland_Eastern = new String[] {
> "East Greenland Standard Time",
>
> Previously, they all had wrong short names due to incorrect parsi...
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17187#pullrequestreview-1795097842
Re: [jdk22] RFR: 8321514: UTF16 string gets constructed incorrectly from codepoints if CompactStrings is not enabled
On Mon, 18 Dec 2023 11:56:50 GMT, Aleksei Voitylov wrote: > Hi all, > > This pull request contains a backport of commit > [fde5b168](https://github.com/openjdk/jdk/commit/fde5b16817c3263236993f2e8c2d2469610d99bd) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Aleksei Voitylov on 14 Dec 2023 > and was reviewed by Roger Riggs. > > Thanks! Verified PR identical to openjdk/jdk PR. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk22/pull/18#pullrequestreview-1789287452
Re: RFR: 8320279: Link issues in java.xml module-info.java
On Wed, 13 Dec 2023 20:54:16 GMT, Joe Wang wrote: > Doc-only change: fix incorrect links in module-info.java and StAX factories. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17093#pullrequestreview-1780486241
Re: RFR: 8321406: Null IDs should be resolved as before catalogs are added
On Tue, 5 Dec 2023 19:34:58 GMT, Joe Wang wrote: > Improve null handling. When both the public and system IDs are null, this > change lets the resolution process continue as usual, before the catalogs > were added. This is consistent with the process on the other part of the > program where a CatalogResolver is used only when the IDs are not null. > > Test: existing XML tests passed. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16983#pullrequestreview-1766224226
Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v5]
On Tue, 5 Dec 2023 01:48:14 GMT, Joe Darcy wrote: >> Time to start making preparations for JDK 23. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 15 commits: > > - Merge branch 'master' into JDK-8319413 > - Add symbol files. > - Merge branch 'master' into JDK-8319413 > - Merge branch 'master' into JDK-8319413 > - Merge branch 'master' into JDK-8319413 > - Merge branch 'master' into JDK-8319413 > - Update symbol files to JDK 22 b26. > - Merge branch 'master' into JDK-8319413 > - Merge branch 'master' into JDK-8319413 > - Add symbol files for JDK 22 build 25. > - ... and 5 more: https://git.openjdk.org/jdk/compare/30b5d427...2ee6cb96 Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16505#pullrequestreview-1764000855
Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v4]
On Sat, 2 Dec 2023 20:40:57 GMT, Andrey Turbanov wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update symbol files to JDK 22 b26. > > test/langtools/tools/javac/versions/Versions.java line 97: > >> 95: TWENTY_ONE(false,"65.0", "21"), >> 96: TWENTY_TWO(false,"66.0", "22"), >> 97: TWENTY_THREE(false,"67.0", "23"), > > As alignment is broken anyway, let's add space > Suggestion: > > TWENTY_THREE(false, "67.0", "23"), If you're going to add the space, I'd consider establishing new alignment at TWENTY to accommodate the eventual space needed for "THREE", "SEVEN", and "EIGHT". You wouldn't need to reset alignment for quite some time after that. - PR Review Comment: https://git.openjdk.org/jdk/pull/16505#discussion_r1414904341
Re: RFR: 8321131: Console read line with zero out should zero out underlying buffer in JLine [v2]
On Fri, 1 Dec 2023 21:24:47 GMT, Naoto Sato wrote: >> This is the fix to JLine, which makes it on par with the built-in Console >> fix ([JDK-8320798](https://bugs.openjdk.org/browse/JDK-8320798)). > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > moved instance fields at the top of the class Marked as reviewed by iris (Reviewer). src/jdk.internal.le/share/classes/jdk/internal/org/jline/JdkConsoleProviderImpl.java line 72: > 70: private final Terminal terminal; > 71: private volatile LineReader jline; > 72: Relocation looks good. Thanks! - PR Review: https://git.openjdk.org/jdk/pull/16930#pullrequestreview-1760648178 PR Review Comment: https://git.openjdk.org/jdk/pull/16930#discussion_r1412624704
Re: RFR: 8321131: Console read line with zero out should zero out underlying buffer in JLine
On Fri, 1 Dec 2023 18:24:48 GMT, Naoto Sato wrote:
> This is the fix to JLine, which makes it on par with the built-in Console fix
> ([JDK-8320798](https://bugs.openjdk.org/browse/JDK-8320798)).
Marked as reviewed by iris (Reviewer).
src/jdk.internal.le/share/classes/jdk/internal/org/jline/JdkConsoleProviderImpl.java
line 114:
> 112: return null;
> 113: } finally {
> 114: jline.zeroOut();
The location of the `jline `declaration at new line 134 is unfortunate, but not
a problem this PR needs to resolve. The location makes sense if it was only
used in `initJLineIfNeeded()` at some point in the past.
-
PR Review: https://git.openjdk.org/jdk/pull/16930#pullrequestreview-1760456573
PR Review Comment: https://git.openjdk.org/jdk/pull/16930#discussion_r1412504396
Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v3]
On Thu, 30 Nov 2023 20:48:21 GMT, Joe Darcy wrote: >> Time to start making preparations for JDK 23. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains eight commits: > > - Merge branch 'master' into JDK-8319413 > - Merge branch 'master' into JDK-8319413 > - Add symbol files for JDK 22 build 25. > - Merge branch 'master' into JDK-8319413 > - Merge branch 'master' into JDK-8319413 > - Adjust expected release date. > - Fix omission in Classfile.java > - JDK-8319413: Start of release updates for JDK 23 Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16505#pullrequestreview-1758548243
Re: RFR: JDK-8320940: Fix typo in java.lang.Double
On Wed, 29 Nov 2023 02:00:14 GMT, Joe Darcy wrote: > Typo fix to to the new text added in JDK-8295391. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16872#pullrequestreview-1754401831
Re: RFR: 8320918: Fix errors in the built-in Catalog implementation [v3]
On Tue, 28 Nov 2023 21:36:20 GMT, Joe Wang wrote: >> Fix errors in the built-in Catalog implementation, specifically: >> -- incorrect case in the property name as defined in the CSR >> (https://bugs.openjdk.org/browse/JDK-8306056) >> -- tests needed to be updated accordingly >> -- jaxp.properties updated with documentation for the new properties >> >> Tests: passed after the update. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > the example now uses RESOLVE instead of FILES. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16862#pullrequestreview-1754066853
Re: RFR: JDK-8319413: Start of release updates for JDK 23
On Fri, 3 Nov 2023 23:42:03 GMT, Joe Darcy wrote: > Time to start making preparations for JDK 23. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16505#pullrequestreview-1751551968
Re: RFR: 8320602: Lock contention in SchemaDVFactory.getInstance()
On Mon, 27 Nov 2023 17:24:35 GMT, Joe Wang wrote: > Applying an update from the upstream source, quote: "Removing synchronized > from the getInstance() methods". As the reporter noted, this change was made > 16 years ago. > > Tests: SQE & unit tests passed Verified `synchronized` keyword removed from method declaration as in upstream source. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16829#pullrequestreview-1751076242
Re: RFR: 8320440: Implementation of Structured Concurrency (Second Preview)
On Mon, 20 Nov 2023 19:48:20 GMT, Alan Bateman wrote: > This API is sitting out JDK 22, meaning no API/implementation changes in this > PR. We expect this API to do a third preview in JDK 23 with some API changes. > > So for now, we just need to bump JEP number/title that shows up in the > preview section of the javadoc. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16748#pullrequestreview-1748399014
Re: RFR: 8320199: Fix HTML 5 errors in java.math.BigInteger
On Wed, 15 Nov 2023 21:59:56 GMT, Brian Burkhalter wrote: > Clean up HTML error due to nested anchor (``) elements. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16679#pullrequestreview-1733201186
Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v4]
On Tue, 14 Nov 2023 19:32:57 GMT, Naoto Sato wrote: >> Correcting the explanation of the `DateFormat.SHORT` constant. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > abbreviated/full clarification Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16645#pullrequestreview-1730777438
Re: RFR: 8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException
On Thu, 9 Nov 2023 17:44:44 GMT, Naoto Sato wrote: > Fixing the `Format::parseObject(String, ParsePosition)` implementation in > `DateTimeFormatter` class, to not throw `DateTimeException` but to return > null. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16586#pullrequestreview-1723287749
Re: RFR: 8305814: Update Xalan Java to 2.7.3
On Mon, 6 Nov 2023 22:52:47 GMT, Joe Wang wrote: > Xalan 2.7.3: merge minor changes from the upstream project. > > Test: existing XML tests pass Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16532#pullrequestreview-1716553613
Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v9]
On Mon, 30 Oct 2023 17:48:48 GMT, Eirik Bjorsnos wrote: >> Please review this PR which brings the DataDescriptorSignatureMissing test >> back to life. >> >> This test currently calls out to Python to create a test vector ZIP with a >> Data Descriptor without the recommended but optional signature. The Python >> dependency has turned out to be very brittle, so the test is currently >> marked with `@ignore` >> >> The PR replaces Python callouts with directly creating the test vector ZIP >> in the test itself. We can then remove the `@ignore`tag and run this useful >> test automatically. > > Eirik Bjorsnos has updated the pull request incrementally with three > additional commits since the last revision: > > - Describe the structure of Data Descriptors using an example > - Extend the comment of `makeZipWithSignaturelessDescriptor` with some > background info on (signature-less) data descriptors, for the benefit of > future maintainers. > - Convert test from testng to junit Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/12959#pullrequestreview-1713426994
Re: RFR: 8318466: Improve spec of NumberFormat's methods with unsupported operations
On Wed, 1 Nov 2023 21:27:57 GMT, Justin Lu wrote: > Please review this simple change which refines the specification of some > NumberFormat methods (with unsupported operations) to separate the API and > implementation specification. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16464#pullrequestreview-1710843738
Re: RFR: 8318487: Specification of the ListFormat.equals() method can be improved [v3]
On Tue, 24 Oct 2023 17:58:48 GMT, Naoto Sato wrote: >> Spec clarification of `ListFormat.equals()` method, utilizing newly >> introduced `getLocale()` and `getPatterns()`. A corresponding CSR has also >> been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflecting review comments Corresponding CSR also Reviewed. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16321#pullrequestreview-1695669443
Re: RFR: 8318569: Add getter methods for Locale and Patterns in ListFormat
On Fri, 20 Oct 2023 17:57:46 GMT, Naoto Sato wrote: > Proposing adding getter methods for `locale` and `patterns` fields in the > `ListFormat` instances. Those fields are used for `equals()`, but without the > public getter methods, users cannot tell the reasoning of the equality of two > instances. A corresponding CSR has also been drafted. Corresponding CSR also Reviewed. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16293#pullrequestreview-1690917007
Re: RFR: 8318458: Update javac and java manpages with restricted method options
On Wed, 18 Oct 2023 15:32:34 GMT, Maurizio Cimadamore wrote: > This PR updates the man pages for `javac` and `java` to document: > * the new `javac` warning for restricted methods (`-Xlint:restricted`) > * the `java` option to allow access to restricted methods without warnings > (`--enable-native-access`) Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16249#pullrequestreview-1685540336
Re: RFR: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16
On Tue, 17 Oct 2023 20:06:03 GMT, Justin Lu wrote: > This change updates the IANA subtag registry to the update released on > 2023-10-16. > > Announcement -> > https://mm.icann.org/pipermail/ietf-languages-announcements/2023-October/89.html Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16227#pullrequestreview-1684058244
Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY. Although some of the short names in the COMPAT provider are >> somewhat questionable (less common ones are simply made up from the long >> names by taking the initials), it would not be desirable for them to fall >> back to the GMT format. >> To mitigate the situation, CLDR can use the abbreviated names from the TZ >> database, which contains legacy (major) short names as FORMAT. The CLDR >> provider can use them instead of the GMT offset style. This enhancement is a >> precursor to the future removal of the COMPAT provider. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Delay populating GMT format at runtime. Reflecting review comments. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16206#pullrequestreview-1683283733
Re: RFR: 8318126: Refresh manpages
On Mon, 16 Oct 2023 01:18:52 GMT, David Holmes wrote: > The open nroff manpage files are out of sync with their closed markdown > sources and need to be refreshed. > > The changes to apply are coming from: > > - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor > to each subcommand option on jfr html page > - [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java > manpage markdown source for JFR filename expansion > - [JDK-8221633](https://bugs.openjdk.org/browse/JDK-8221633): > StartFlightRecording: consider moving mention of multiple comma-separated > parameters to the front > - [JDK-8308662](https://bugs.openjdk.org/browse/JDK-8308662): Update the > "java" tool specification for CompileOnly > - [JDK-8317565](https://bugs.openjdk.org/browse/JDK-8317565): Update Manpage > for obsoletion of UseSHM > - [JDK-8310460](https://bugs.openjdk.org/browse/JDK-8310460): Remove jdeps > -profile option > > There are also some simple line break changes, likely due to using different > versions of the pandoc tool. > > Thanks Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16196#pullrequestreview-1681114738
Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on MacBookPro M1 Pro:
>
>
> -Benchmark Mode Cnt Score Error Units
> -StringFormat.complexFormat avgt 15 1862.233 ? 217.479 ns/op
> -StringFormat.int02Format avgt 15 312.491 ? 26.021 ns/op
> -StringFormat.intFormat avgt 1584.432 ? 4.145 ns/op
> -StringFormat.longFormatavgt 1587.330 ? 6.111 ns/op
> -StringFormat.stringFormat avgt 1563.985 ? 11.366 ns/op
> -StringFormat.stringIntFormat avgt 1587.422 ? 0.147 ns/op
> -StringFormat.widthStringFormat avgt 15 250.740 ? 32.639 ns/op
> -StringFormat.widthStringIntFormat avgt 15 312.474 ? 16.309 ns/op
>
> +Benchmark Mode CntScoreError Units
> +StringFormat.complexFormat avgt 15 740.626 ? 66.671 ns/op
> (+151.45)
> +StringFormat.int02Format avgt 15 131.049 ? 0.432 ns/op
> (+138.46)
> +StringFormat.intFormat avgt 15 67.229 ? 4.155 ns/op
> (+25.59)
> +StringFormat.longFormatavgt 15 66.444 ? 0.614 ns/op
> (+31.44)
> +StringFormat.stringFormat avgt 15 62.619 ? 4.652 ns/op (+2.19)
> +StringFormat.stringIntFormat avgt 15 89.606 ? 13.966 ns/op (-2.44)
> +StringFormat.widthStringFormat avgt 15 52.462 ? 15.649 ns/op
> (+377.95)
> +StringFormat.widthStringIntFormat avgt 15 101.814 ? 3.147 ns/op
> (+206.91)
test/jdk/java/util/Formatter/BasicInt.java line 404:
> 402:
> 403: // non-conversion
> 404: tryCatch("%12", UnknownFormatConversionException.class);
Is this file still mechanically generated as indicated in line 31 (above)?
Perhaps these changes should be in Basic-X.java.template instead?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/15776#discussion_r1350397453
Re: RFR: 8317873: Add @sealedGraph to IllegalFormatException
On Wed, 11 Oct 2023 07:59:24 GMT, Per Minborg wrote: > This PR proposes to add @sealedGraph to `IllegalFormatException` Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16140#pullrequestreview-1672411158
Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v16]
On Thu, 5 Oct 2023 20:02:44 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
>>
>> The following are the test results based on MacBookPro M1 Pro:
>>
>>
>> -Benchmark Mode Cnt Score Error Units
>> -StringFormat.complexFormat avgt 15 1862.233 ? 217.479 ns/op
>> -StringFormat.int02Format avgt 15 312.491 ? 26.021 ns/op
>> -StringFormat.intFormat avgt 1584.432 ? 4.145 ns/op
>> -StringFormat.longFormatavgt 1587.330 ? 6.111 ns/op
>> -StringFormat.stringFormat avgt 1563.985 ? 11.366 ns/op
>> -StringFormat.stringIntFormat avgt 1587.422 ? 0.147 ns/op
>> -StringFormat.widthStringFormat avgt 15 250.740 ? 32.639 ns/op
>> -StringFormat.widthStringIntFormat avgt 15 312.474 ? 16.309 ns/op
>>
>> +Benchmark Mode CntScoreError Units
>> +StringFormat.complexFormat avgt 15 740.626 ? 66.671 ns/op
>> (+151.45)
>> +StringFormat.int02Format avgt 15 131.049 ? 0.432 ns/op
>> (+138.46)
>> +StringFormat.intFormat avgt 15 67.229 ? 4.155 ns/op
>> (+25.59)
>> +StringFormat.longFormatavgt 15 66.444 ? 0.614 ns/op
>> (+31.44)
>> +StringFormat.stringFormat avgt 15 62.619 ? 4.652 ns/op
>> (+2.19)
>> +StringFormat.stringIntFormat avgt 15 89.606 ? 13.966 ns/op
>> (-2.44)
>> +StringFormat.widthStringFormat avgt 15 52.462 ? 15.649 ns/op
>> (+377.95)
>> +StringFormat.widthStringIntFormat avgt 15 101.814 ? 3.147 ns/op
>> (+206.91)
>
> 温绍锦 has updated the pull request incrementally with two additional commits
> since the last revision:
>
> - add copyright info
> - Improve the readability, suggestion from @rgiulietti
test/jdk/java/util/Formatter/BasicInt.java line 404:
> 402:
> 403: // non-conversion
> 404: tryCatch("%12", UnknownFormatConversionException.class);
Is this file still mechanically generated as indicated in line 31 (above)?
Perhaps these changes should be in Basic-X.java.template instead?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/15776#discussion_r1350397453
Re: RFR: 8317471: ListFormat::parseObject() spec can be improved on parsePosition valid values
On Thu, 5 Oct 2023 17:57:00 GMT, Naoto Sato wrote: > Adding IOOBE clause to clarify the behavior on an invalid `parsePos` argument > on calling `ListFormat::parseObject()`. A corresponding CSR has also been > drafted. Documents existing behaviour. Associated CSR also Reviewed. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16063#pullrequestreview-1660615062
Re: RFR: 8317126: Redundant entries in Windows `tzmappings` file
On Thu, 28 Sep 2023 17:37:00 GMT, Naoto Sato wrote: > Removing redundant entries in `lib/tzmappings` file on Windows. The file maps > Windows time zones to Java time zones according to the region. Since `001` > means world, no region-specific entries are needed if those time zones are > the same. The diff of the generated tzmappings files, before and after the > fix, is attached. > [tzmappings.diff.txt](https://github.com/openjdk/jdk/files/12752377/tzmappings.diff.txt) Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15968#pullrequestreview-1649468588
Re: RFR: 8317119: Unused imports in the java.util.stream package [v2]
On Wed, 27 Sep 2023 22:44:52 GMT, Mourad Abbay wrote: >> Remove unused imports in the java.util.stream package. > > Mourad Abbay has updated the pull request incrementally with one additional > commit since the last revision: > > Update copyright year. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15949#pullrequestreview-1647685756
Re: RFR: 8316970: Add internal annotation to mark restricted methods [v2]
On Wed, 27 Sep 2023 17:29:29 GMT, Maurizio Cimadamore wrote: >> This patch adds a new internal annotation that is used to mark all >> restricted me >> thods in the FFM API. The new annotation is similar to the one we used for >> preview API methods. >> >> We plan to use the new annotation for adding new javac warnings when calling >> restricted methods, as well as to add better javadoc support for restricted >> methods. >> >> I have added a test which, similar to the test for `@CallerSensitive` checks >> all methods in `java.base` that are annotated with `@Restricted` and makes >> sure they conform to the list of restricted methods. > > Maurizio Cimadamore has updated the pull request incrementally with one > additional commit since the last revision: > > Drop requires tag from test I've confirmed that the identified set of restricted methods matches those declared for Java SE 21 (https://cr.openjdk.org/~iris/se/21/latestSpec/#Restricted-methods). I'm looking forward to the planned javadoc support for restricted methods. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15947#pullrequestreview-1647234726
Re: RFR: 8316038: Fix doc typos in java.io.Console and java.util.Scanner
On Mon, 11 Sep 2023 17:58:20 GMT, Pavel Rappo wrote: > Please review this trivial PR. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15667#pullrequestreview-1620730522
Re: RFR: 8315938: Deprecate for removal Unsafe methods that have standard APIs for many releases
On Fri, 8 Sep 2023 15:54:05 GMT, Alan Bateman wrote: > There are several methods defined by sun.misc.Unsafe that have standard API > equivalents for many years and releases. The change proposed here is to > deprecate, for removal, the park, unpark, getLoadAverage, loadFence, > storeFence, and fullFence methods. Code using these methods should move to > LockSupport.park/unpark (Java 5), OperatingSystemMXBean.getSystemLoadAverage > (Java 6), and VarHandles xxxFence methods (Java 9). > > The following is a summary of a search of 175973022 classes in 484751 > artifacts to get a sense of the usage of these methods. > > - 1290 usages of Unsafe.park. 1195 are libraries that have re-packaged some > version of ForkJoinPool, maybe from the jsr166 repo, maybe an older JDK > release. In the remaining, only Ehcache stands out with 29 matches. It seems > to be one usage but the library seems to copied/shaded into other artifacts. > > - 1322 usages of Unsafe.unpark. 1243 are re-packaged ForkJoinPool. 29 > occurrences are Encache, again one usage but the library seems to > copied/shaded into other artifacts. > > - 22 usages of Unsafe.getLoadAverage. Most of these are one usage in many > published versions of Apache HBase. > > - 339 usages of Unsafe.loadFence, 1057 usages of Unsafe.storeFence, 517 > usages of Unsafe.fullFence. A handful of these are libraries with copies of > j.u.concurrent, the rest seem to be high performance libraries that support > older JDK releases or just haven't been updated to use VarHandles yet. Happy to see these methods start their journey towards eventual removal. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15641#pullrequestreview-1618280143
Re: RFR: 8267174: Many test files have the wrong Copyright header
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a combination of `sed` and `grep`. Reviewing this patch is probably > easier using the raw patch file or a suitable webrev format. > > It's my assumption that these headers were introduced by mistake as it's > quite easy to copy the wrong template when creating new files. Thanks for fixing! - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15573#pullrequestreview-1613704179
Re: RFR: 8314483: Optionally override copyright header in generated source [v2]
On Thu, 24 Aug 2023 17:36:46 GMT, Erik Joelsson wrote: >> In the JDK build we have various build tools that generate source code from >> data files. For most of these tools, the source files are based on template >> files, which already have copyright headers, but for some, the complete >> source file is generated by the tool, which is providing the copyright >> header programatically. For the latter, we would like to implement an >> override mechanism in each tool so that we can change the copyright header >> from a custom makefile. > > Erik Joelsson has updated the pull request incrementally with one additional > commit since the last revision: > > Suggestion from dholmes Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15346#pullrequestreview-1594143141
Re: RFR: 8314495: Update to use jtreg 7.3.1
On Thu, 17 Aug 2023 07:24:14 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.3,1. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion` has been updated in the various `TEST.ROOT` > files. > > This change set also un-problem-lists tests from > https://github.com/openjdk/jdk/commit/360f65d7b15b327e2f160c42f318945cc6548bda > > This change set also fixes: > - https://bugs.openjdk.org/browse/JDK-8313902 > - https://bugs.openjdk.org/browse/JDK-8313903 > > Testing: tier1-tier5 OK Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15323#pullrequestreview-1585041001
Re: RFR: 8313949: Missing word in GPLv2 license text in StackMapTableAttribute.java
On Mon, 14 Aug 2023 12:47:46 GMT, Dmitry Cherepanov wrote: > The PR suggests updating copyright headers in two files so that they are the > same as in other files. The updated license appears to match the expected license: https://github.com/openjdk/jdk/blob/master/make/data/license-templates/gpl-cp-header - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15269#pullrequestreview-1577155280
Re: RFR: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02
On Thu, 3 Aug 2023 16:31:01 GMT, Justin Lu wrote: > Please review this PR which updates the IANA data from version 05-11-2023 to > version > [08-02-2023](https://mm.icann.org/pipermail/ietf-languages-announcements/2023-August/88.html). > > The contents of the update added variant subtag “blasl” to the language > subtag registry. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15142#pullrequestreview-1561806378
Re: RFR: 8311006: missing @since info in jdk.xml.dom
On Wed, 2 Aug 2023 22:26:37 GMT, Joe Wang wrote: > Please review a patch that add `@since` tags following existing convention > for XML APIs in java.xml and jdk.xml.dom modules. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15129#pullrequestreview-1559985912
Re: [jdk21] RFR: 8312572: JDK 21 RDP2 L10n resource files update
On Wed, 2 Aug 2023 17:03:40 GMT, Justin Lu wrote: > Please review this PR (L10N translation update), which is a backport of > commit > [9b55e9a7](https://github.com/openjdk/jdk/commit/9b55e9a706de9893b1a71c7a6a4e23c4b8842f18) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This change is required to keep the localized translations up to date with > the English source resource files. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk21/pull/160#pullrequestreview-1559601318
Re: RFR: 8310991: missing @since tags in java.xml
On Tue, 1 Aug 2023 19:32:40 GMT, Joe Wang wrote: > Please review a patch that adds the @since tag to DOM package. Added @since tags follow existing convention for XML APIs in java.xml and jdk.xml.dom modules. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15109#pullrequestreview-1557740390
Re: [jdk21] RFR: 8039165: [Doc] MessageFormat null locale generates NullPointerException
On Mon, 31 Jul 2023 21:13:16 GMT, Justin Lu wrote: > Please review this change which contains a backport of commit > [c6396dce](https://github.com/openjdk/jdk/commit/c6396dceb9a64578d5b335af27ad1d968190a1fa) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This PR is a java.text doc/test-only change. > > The commit being backported was authored by Justin Lu on 25 Jul 2023 and was > reviewed by Naoto Sato. > > Thanks! Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk21/pull/154#pullrequestreview-1556044570
