Re: RFR: 8333477: Delete extra empty spaces in Makefiles [v2]
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote: >> Hi all, >> This PR several extra empty spaces and extra empty lines in several >> Makefiles. It's trivial fix, no risk. >> >> Thanks. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > delete extra empty trailing blank line in > test/jdk/java/rmi/reliability/benchmark/bench/Makefile Thanks all for the review and sponsor. - PR Comment: https://git.openjdk.org/jdk/pull/19537#issuecomment-2154937099
Integrated: 8333477: Delete extra empty spaces in Makefiles
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote: > Hi all, > This PR several extra empty spaces and extra empty lines in several > Makefiles. It's trivial fix, no risk. > > Thanks. This pull request has now been integrated. Changeset: d130d2f4 Author:SendaoYan Committer: Julian Waters URL: https://git.openjdk.org/jdk/commit/d130d2f4f46d37a2b924343de19d012c129b0a55 Stats: 11 lines in 5 files changed: 0 ins; 2 del; 9 mod 8333477: Delete extra empty spaces in Makefiles Reviewed-by: erikj, chagedorn, liach, jwaters - PR: https://git.openjdk.org/jdk/pull/19537
Re: RFR: 8333477: Delete extra empty spaces in Makefiles [v2]
On Fri, 7 Jun 2024 12:53:46 GMT, Chen Liang wrote: >> No, it's an extra newline. A file should end with a newline but one is >> enough. > > As confusing as they are, unfortunately GitHub UI does not render extra > trailing newlines. This is the only one I could find with grepWin. I find the extra trailing newlines through below shell command: for i in `find . -iname "Makefile*" | sed "/./build/d"` ; do tail -n 2 $i | grep -c "^$" | grep -q "^1$" ; if [[ 0 -eq $? ]] ; then echo $i ; fi ; done There are only two files has been found: ./test/jdk/java/rmi/reliability/benchmark/bench/rmi/Makefile ./test/jdk/java/rmi/reliability/benchmark/bench/Makefile - PR Review Comment: https://git.openjdk.org/jdk/pull/19537#discussion_r1631168243
Re: RFR: 8333477: Delete extra empty spaces in Makefiles [v2]
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote: >> Hi all, >> This PR several extra empty spaces and extra empty lines in several >> Makefiles. It's trivial fix, no risk. >> >> Thanks. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > delete extra empty trailing blank line in > test/jdk/java/rmi/reliability/benchmark/bench/Makefile Thanks all for the review. - PR Comment: https://git.openjdk.org/jdk/pull/19537#issuecomment-2154735598
Re: RFR: 8333477: Delete extra empty spaces in Makefiles [v2]
On Thu, 6 Jun 2024 17:49:08 GMT, Chen Liang wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> delete extra empty trailing blank line in >> test/jdk/java/rmi/reliability/benchmark/bench/Makefile > > test/jdk/java/rmi/reliability/benchmark/bench/rmi/Makefile line 1: > >> 1: # > > This file change is dubious: > 1. It does not have any trailing whitespace that can fail the skara checks. > 2. If the duplicate blank lines in the end of this Makefile is indeed > problematic (as fixed here), please fix the only other occasion in the JDK, > which is the Makefile in the parent directory. (Checked with `\n$^\n$\Z` > pattern in all Makefiles) > > Recommended actions: Either > 1. Revert changes in this file; > 2. Also update `test/jdk/java/rmi/reliability/benchmark/bench/Makefile` to > remove the trailing blank line. Thanks for the suggestion, the trailing blank line of `test/jdk/java/rmi/reliability/benchmark/bench/Makefile` has been removed. - PR Review Comment: https://git.openjdk.org/jdk/pull/19537#discussion_r1630767547
Re: RFR: 8333477: Delete extra empty spaces in Makefiles [v2]
> Hi all, > This PR several extra empty spaces and extra empty lines in several > Makefiles. It's trivial fix, no risk. > > Thanks. SendaoYan has updated the pull request incrementally with one additional commit since the last revision: delete extra empty trailing blank line in test/jdk/java/rmi/reliability/benchmark/bench/Makefile - Changes: - all: https://git.openjdk.org/jdk/pull/19537/files - new: https://git.openjdk.org/jdk/pull/19537/files/0d2be363..e80b98da Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19537=01 - incr: https://webrevs.openjdk.org/?repo=jdk=19537=00-01 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19537.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19537/head:pull/19537 PR: https://git.openjdk.org/jdk/pull/19537
Re: RFR: 8333477: Delete extra empty spaces in Makefiles
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote: > Hi all, > This PR several extra empty spaces and extra empty lines in several > Makefiles. It's trivial fix, no risk. > > Thanks. Thanks for the review. Thanks all for the review. - PR Comment: https://git.openjdk.org/jdk/pull/19537#issuecomment-2147523325 PR Comment: https://git.openjdk.org/jdk/pull/19537#issuecomment-2147711173
Re: RFR: 8333477: Delete extra empty spaces in Makefiles
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote: > Hi all, > This PR several extra empty spaces and extra empty lines in several > Makefiles. It's trivial fix, no risk. > > Thanks. > /label build Thanks. - PR Comment: https://git.openjdk.org/jdk/pull/19537#issuecomment-2147467980
RFR: 8333477: Delete extra empty spaces in Makefiles
Hi all, This PR several extra empty spaces and extra empty lines in several Makefiles. It's trivial fix, no risk. Thanks. - Commit messages: - 8333477: Delete extra empty spaces in Makefiles Changes: https://git.openjdk.org/jdk/pull/19537/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19537=00 Issue: https://bugs.openjdk.org/browse/JDK-8333477 Stats: 9 lines in 4 files changed: 0 ins; 1 del; 8 mod Patch: https://git.openjdk.org/jdk/pull/19537.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19537/head:pull/19537 PR: https://git.openjdk.org/jdk/pull/19537
Re: RFR: 8332922: Test java/io/IO/IO.java fails when /usr/bin/expect not exist [v2]
On Sun, 26 May 2024 07:24:16 GMT, SendaoYan wrote: >> Hi all, >> When there is no `/usr/bin/expect` in system, `throw new SkippedException` >> will not make the jvm exit in `@BeforeAll` junit stage, thus this will cause >> this testcase run failed. So I make change from `throw new SkippedException` >> to `Assumptions.abort` to avoid this issue. >> Only change the testcase, no risk. >> >> Thanks. > > SendaoYan has updated the pull request incrementally with two additional > commits since the last revision: > > - delete "static final int JCK_STATUS_BASE = 95;" > >Signed-off-by: sendaoYan > - 8332922: Test java/io/IO/IO.java fails when /usr/bin/expect not exist > >Signed-off-by: sendaoYan > /sponsor Thanks. - PR Comment: https://git.openjdk.org/jdk/pull/19403#issuecomment-2132757338
Integrated: 8332922: Test java/io/IO/IO.java fails when /usr/bin/expect not exist
On Sun, 26 May 2024 02:58:02 GMT, SendaoYan wrote: > Hi all, > When there is no `/usr/bin/expect` in system, `throw new SkippedException` > will not make the jvm exit in `@BeforeAll` junit stage, thus this will cause > this testcase run failed. So I make change from `throw new SkippedException` > to `Assumptions.abort` to avoid this issue. > Only change the testcase, no risk. > > Thanks. This pull request has now been integrated. Changeset: 4e8deb39 Author:SendaoYan Committer: Daniel Jeliński URL: https://git.openjdk.org/jdk/commit/4e8deb396e38c69de22b6348dca637d814d73aef Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8332922: Test java/io/IO/IO.java fails when /usr/bin/expect not exist Reviewed-by: djelinski - PR: https://git.openjdk.org/jdk/pull/19403
Re: RFR: 8332922: Test java/io/IO/IO.java fails when /usr/bin/expect not exist [v2]
On Sun, 26 May 2024 07:40:38 GMT, Daniel Jeliński wrote: > LGTM. I assume you verified it does the right thing. Thanks for the review and approved. The change has been verified. - PR Comment: https://git.openjdk.org/jdk/pull/19403#issuecomment-2132120584
Re: RFR: 8332922: Test java/io/IO/IO.java fails when /usr/bin/expect not exist [v2]
On Sun, 26 May 2024 06:16:44 GMT, Alan Bateman wrote:
>> test/jdk/java/io/IO/IO.java line 64:
>>
>>> 62: expect = Paths.get("/usr/bin/expect"); // os-specific path
>>> 63: if (!Files.exists(expect) || !Files.isExecutable(expect)) {
>>> 64: System.out.println("jtreg.SkippedException: '" + expect
>>> + "' not found");
>>
>> SkippedException works with jtreg tests only. For jUnit you need to use
>> [Assumptions.abort](https://junit.org/junit5/docs/5.9.1/api/org.junit.jupiter.api/org/junit/jupiter/api/Assumptions.html#abort(java.lang.String))
>
>> SkippedException works with jtreg tests only. For jUnit you need to use
>> [Assumptions.abort](https://junit.org/junit5/docs/5.9.1/api/org.junit.jupiter.api/org/junit/jupiter/api/Assumptions.html#abort(java.lang.String))
>
> Yes, the Assumptions API should be used here. We use that in several JUnit
> tests that skip when tests when they can't run and you want it to fail the
> test.
Thanks for the review and suggest. The code has been updated according the
suggest. Thanks.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19403#discussion_r1615075147
Re: RFR: 8332922: Test java/io/IO/IO.java fails when /usr/bin/expect not exist [v2]
> Hi all, > When there is no `/usr/bin/expect` in system, `throw new SkippedException` > will not make the jvm exit in `@BeforeAll` junit stage, thus this will cause > this testcase run failed. So I make change from `throw new SkippedException` > to `System.exit` to avoid this issue. When use `System.exit`, I think we > should use `othervm` mode in jtreg. > Only change the testcase, the risk is low. > > Thanks. SendaoYan has updated the pull request incrementally with two additional commits since the last revision: - delete "static final int JCK_STATUS_BASE = 95;" Signed-off-by: sendaoYan - 8332922: Test java/io/IO/IO.java fails when /usr/bin/expect not exist Signed-off-by: sendaoYan - Changes: - all: https://git.openjdk.org/jdk/pull/19403/files - new: https://git.openjdk.org/jdk/pull/19403/files/90fa1e13..57b4dee5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19403=01 - incr: https://webrevs.openjdk.org/?repo=jdk=19403=00-01 Stats: 5 lines in 1 file changed: 0 ins; 2 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/19403.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19403/head:pull/19403 PR: https://git.openjdk.org/jdk/pull/19403
RFR: 8332922: Test java/io/IO/IO.java fails when /usr/bin/expect not exist
Hi all, When there is no `/usr/bin/expect` in system, `throw new SkippedException` will not make the jvm exit in `@BeforeAll` junit stage, thus this will cause this testcase run failed. So I make change from `throw new SkippedException` to `System.exit` to avoid this issue. When use `System.exit`, I think we should use `othervm` mode in jtreg. Only change the testcase, the risk is low. Thanks. - Commit messages: - 8332922: Test java/io/IO/IO.java fails when /usr/bin/expect not exist Changes: https://git.openjdk.org/jdk/pull/19403/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19403=00 Issue: https://bugs.openjdk.org/browse/JDK-8332922 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/19403.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19403/head:pull/19403 PR: https://git.openjdk.org/jdk/pull/19403
Withdrawn: 8332260: Mark tools/jlink/JLinkReproducibleTest.java as intermittent failure
On Wed, 15 May 2024 03:28:29 GMT, SendaoYan wrote: > Hi all, > The `tools/jlink/JLinkReproducibleTest.java` intermittent fails on linux > aarch64. Should we mark this testcase as `@key intermittent`. No risk. > > Thanks. > -sendao This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/19241
Re: RFR: 8332260: Mark tools/jlink/JLinkReproducibleTest.java as intermittent failure
On Wed, 15 May 2024 03:41:02 GMT, Jaikiran Pai wrote: > Hello @sendaoYan, the linked issue > https://bugs.openjdk.org/browse/JDK-8327181 which talks about a JVM crash > looks very generic and not specific to this test. Before updating this test, > I think that issue needs to investigated and addressed or at least we need to > ascertain that this test is somehow the only test causing it. OK, maybe we shoule close this PR before that issue has been investigated. - PR Comment: https://git.openjdk.org/jdk/pull/19241#issuecomment-2111526227
RFR: 8332260: Mark tools/jlink/JLinkReproducibleTest.java as intermittent failure
Hi all, The `tools/jlink/JLinkReproducibleTest.java` intermittent fails on linux aarch64. Should we mark this testcase as `@key intermittent`. No risk. Thanks. -sendao - Commit messages: - 8332260: mark tools/jlink/JLinkReproducibleTest.java as intermittent failure - 8332260: mark tools/jlink/JLinkReproducibleTest.java as intermittent failure Changes: https://git.openjdk.org/jdk/pull/19241/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19241=00 Issue: https://bugs.openjdk.org/browse/JDK-8332260 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/19241.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19241/head:pull/19241 PR: https://git.openjdk.org/jdk/pull/19241
Re: RFR: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed [v3]
On Tue, 23 Jan 2024 13:04:43 GMT, SendaoYan wrote: >> 8323640: [TESTBUG]testMemoryFailCount in >> jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail >> because OOM killed > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > 8323640: [TESTBUG]testMemoryFailCount in > jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because > OOM killed > > Signed-off-by: sendaoYan > /sponsor @jerboaa Thanks for the review and the sponsor. - PR Comment: https://git.openjdk.org/jdk/pull/17514#issuecomment-2044000397
Re: RFR: 8326461: tools/jlink/CheckExecutable.java fails as .debuginfo files are not executable
On Thu, 22 Feb 2024 07:23:04 GMT, SendaoYan wrote: > Before JDK-8325342(commit id:0bcece995840777db660811e4b20bb018e90439b), all > the files in build/linux-x86_64-server-release/images/jdk/bin are executable: > >  > > > After JDK-8325342, all the *.debuginfo files in > build/linux-x86_64-server-release/images/jdk/bin are not executable: > >  > > > This PR only modifies the testcase to adapt to the modification of the > corresponding build script, ignoring the check of debuginfo file executable > permissions, and the risk is low > /sponsor @shipilev @AlanBateman Thanks. - PR Comment: https://git.openjdk.org/jdk/pull/17958#issuecomment-2043997665
Re: RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 [v3]
On Mon, 11 Mar 2024 15:15:39 GMT, Naoto Sato wrote: > LGTM @naotoj Thanks for the review. - PR Comment: https://git.openjdk.org/jdk/pull/18155#issuecomment-2043989340
Re: RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 [v3]
On Sat, 9 Mar 2024 13:18:14 GMT, SendaoYan wrote: >> Date.toString() uses Locale.US explicitly for printing the time zone, so >> replace Locale.ROOT to Locale.US in this testcase for fix the test failure. >> >> This testcase fixed has been verified. >> >> Only change the testcase, risk is low. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > update the Locale.US code comment > > Signed-off-by: sendaoYan > /sponsor @DamonFool Thanks. - PR Comment: https://git.openjdk.org/jdk/pull/18155#issuecomment-2043989514
Integrated: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269
On Thu, 7 Mar 2024 16:47:01 GMT, SendaoYan wrote: > Date.toString() uses Locale.US explicitly for printing the time zone, so > replace Locale.ROOT to Locale.US in this testcase for fix the test failure. > > This testcase fixed has been verified. > > Only change the testcase, risk is low. This pull request has now been integrated. Changeset: e21da4ca Author:SendaoYan Committer: Jie Fu URL: https://git.openjdk.org/jdk/commit/e21da4caacb464827270d20b8fc62a50a1706316 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 Reviewed-by: naoto - PR: https://git.openjdk.org/jdk/pull/18155
Re: RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 [v3]
> Date.toString() uses Locale.US explicitly for printing the time zone, so > replace Locale.ROOT to Locale.US in this testcase for fix the test failure. > > This testcase fixed has been verified. > > Only change the testcase, risk is low. SendaoYan has updated the pull request incrementally with one additional commit since the last revision: update the Locale.US code comment Signed-off-by: sendaoYan - Changes: - all: https://git.openjdk.org/jdk/pull/18155/files - new: https://git.openjdk.org/jdk/pull/18155/files/6827b2be..14751490 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18155=02 - incr: https://webrevs.openjdk.org/?repo=jdk=18155=01-02 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/18155.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18155/head:pull/18155 PR: https://git.openjdk.org/jdk/pull/18155
Re: RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 [v3]
On Fri, 8 Mar 2024 17:29:09 GMT, Naoto Sato wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update the Locale.US code comment >> >> Signed-off-by: sendaoYan > > test/jdk/java/util/Properties/PropertiesStoreTest.java line 59: > >> 57: private static final String DATE_FORMAT_PATTERN = "EEE MMM dd >> HH:mm:ss zzz "; >> 58: // use a neutral locale, since when the date comment was written by >> Properties.store(...), >> 59: // it internally calls the Date.toString() which always writes in a >> locale insensitive manner > > Instead of blindly removing the comment, I'd suggest reflecting the fact that > `Date.toString()` uses `Locale.US` for time zone names. Thanks for your advice. The comment has been updated. - PR Review Comment: https://git.openjdk.org/jdk/pull/18155#discussion_r1518571662
Re: RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 [v2]
On Thu, 7 Mar 2024 21:07:12 GMT, Naoto Sato wrote: > Thanks for the fix. Although setting `Locale.US` to acquire the formatter is > correct, the reasoning is not. The real reason is that `Date.toString()` uses > `Locale.US` explicitly for printing the time zone > > https://github.com/openjdk/jdk/blob/972e81d1adb232b02114a5260d06144eb5b08849/src/java.base/share/classes/java/util/Date.java#L1045 > > Also, update the copyright year to 2024. Done. - PR Comment: https://git.openjdk.org/jdk/pull/18155#issuecomment-1984993010
Re: RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 [v2]
On Fri, 8 Mar 2024 02:41:06 GMT, SendaoYan wrote: >> Date.toString() uses Locale.US explicitly for printing the time zone, so >> replace Locale.ROOT to Locale.US in this testcase for fix the test failure. >> >> This testcase fixed has been verified. >> >> Only change the testcase, risk is low. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > 1. modify copyright year to 2024; 2. delete unmatch comment GHA: riscv cross compile fail. It's unrelated to this PR. - PR Comment: https://git.openjdk.org/jdk/pull/18155#issuecomment-1984994736
Re: RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 [v2]
> The DATE_FORMAT_PATTERN is set to "EEE MMM dd HH:mm:ss zzz ", is the time > format of US. So, creates a formatter should using Locale.US, rather than > Locale.ROOT, which means empty. SendaoYan has updated the pull request incrementally with one additional commit since the last revision: 1. modify copyright year to 2024; 2. delete unmatch comment - Changes: - all: https://git.openjdk.org/jdk/pull/18155/files - new: https://git.openjdk.org/jdk/pull/18155/files/7d8c0104..6827b2be Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18155=01 - incr: https://webrevs.openjdk.org/?repo=jdk=18155=00-01 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/18155.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18155/head:pull/18155 PR: https://git.openjdk.org/jdk/pull/18155
RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269
The DATE_FORMAT_PATTERN is set to "EEE MMM dd HH:mm:ss zzz ", is the time format of US. So, creates a formatter should using Locale.US, rather than Locale.ROOT, which means empty. - Commit messages: - 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 Changes: https://git.openjdk.org/jdk/pull/18155/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18155=00 Issue: https://bugs.openjdk.org/browse/JDK-8327486 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/18155.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18155/head:pull/18155 PR: https://git.openjdk.org/jdk/pull/18155
Integrated: 8326461: tools/jlink/CheckExecutable.java fails as .debuginfo files are not executable
On Thu, 22 Feb 2024 07:23:04 GMT, SendaoYan wrote: > Before JDK-8325342(commit id:0bcece995840777db660811e4b20bb018e90439b), all > the files in build/linux-x86_64-server-release/images/jdk/bin are executable: > >  > > > After JDK-8325342, all the *.debuginfo files in > build/linux-x86_64-server-release/images/jdk/bin are not executable: > >  > > > This PR only modifies the testcase to adapt to the modification of the > corresponding build script, ignoring the check of debuginfo file executable > permissions, and the risk is low This pull request has now been integrated. Changeset: cc1e216e Author:SendaoYan Committer: Alan Bateman URL: https://git.openjdk.org/jdk/commit/cc1e216eb9e4c817f6744ec76d62f21f4bd14489 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8326461: tools/jlink/CheckExecutable.java fails as .debuginfo files are not executable Reviewed-by: shade, alanb - PR: https://git.openjdk.org/jdk/pull/17958
RFR: 8326461: tools/jlink/CheckExecutable.java fail after JDK-8325342
Before JDK-8325342(commit id:0bcece995840777db660811e4b20bb018e90439b), all the files in build/linux-x86_64-server-release/images/jdk/bin are executable:  After JDK-8325342, all the *.debuginfo files in build/linux-x86_64-server-release/images/jdk/bin are not executable:  This PR only modifies the testcase to adapt to the modification of the corresponding build script, ignoring the check of debuginfo file executable permissions, and the risk is low - Commit messages: - 8326461: tools/jlink/CheckExecutable.java fail after JDK-8325342 Changes: https://git.openjdk.org/jdk/pull/17958/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17958=00 Issue: https://bugs.openjdk.org/browse/JDK-8326461 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/17958.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17958/head:pull/17958 PR: https://git.openjdk.org/jdk/pull/17958
Integrated: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
On Mon, 22 Jan 2024 09:31:43 GMT, sendaoYan wrote: > 8323640: [TESTBUG]testMemoryFailCount in > jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because > OOM killed This pull request has now been integrated. Changeset: 791b427f Author:sendaoYan Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk/commit/791b427f4410057cdcdf8fd8ea0dcce71f7dc513 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed Reviewed-by: sgehwolf - PR: https://git.openjdk.org/jdk/pull/17514
Re: RFR: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed [v3]
On Tue, 23 Jan 2024 13:04:43 GMT, sendaoYan wrote: >> 8323640: [TESTBUG]testMemoryFailCount in >> jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail >> because OOM killed > > sendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > 8323640: [TESTBUG]testMemoryFailCount in > jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because > OOM killed > > Signed-off-by: sendaoYan > GHA > Please enable GHA for your fork for future PRs. OK - PR Comment: https://git.openjdk.org/jdk/pull/17514#issuecomment-1906038625
Re: RFR: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed [v3]
> 8323640: [TESTBUG]testMemoryFailCount in > jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because > OOM killed sendaoYan has updated the pull request incrementally with one additional commit since the last revision: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed Signed-off-by: sendaoYan - Changes: - all: https://git.openjdk.org/jdk/pull/17514/files - new: https://git.openjdk.org/jdk/pull/17514/files/969b608d..d1eb4fac Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=17514=02 - incr: https://webrevs.openjdk.org/?repo=jdk=17514=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/17514.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17514/head:pull/17514 PR: https://git.openjdk.org/jdk/pull/17514
Re: RFR: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed [v2]
> 8323640: [TESTBUG]testMemoryFailCount in > jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because > OOM killed sendaoYan has updated the pull request incrementally with one additional commit since the last revision: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed Signed-off-by: sendaoYan - Changes: - all: https://git.openjdk.org/jdk/pull/17514/files - new: https://git.openjdk.org/jdk/pull/17514/files/be81665d..969b608d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=17514=01 - incr: https://webrevs.openjdk.org/?repo=jdk=17514=00-01 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/17514.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17514/head:pull/17514 PR: https://git.openjdk.org/jdk/pull/17514
Re: RFR: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
On Mon, 22 Jan 2024 15:03:18 GMT, Severin Gehwolf wrote: > `1k` increments for a total of `512k` times seems overkill. Are you sure > that's needed to make the test pass? How about `1MB` increments for a total > of `512` times? When the docker serivice work normally on the test machine, this test will always fail. This test want to verify the API `jdk.internal.platform.Metrics.systemMetrics().getMemoryFailCount()` work normally or not. The API return memory allocate fail times in jvm. But, before this PR, everytime it allocate `1M` memory, the API has no chance the catch the memory allocate fail, the jvm was killed by OOM. Change `8M` increments to `1K` mean to avoid OOM killed for the jvm in docker container. jvm was killed by OOM in docker container:  `1M` Increnents also can avoid OOM killed.  - PR Comment: https://git.openjdk.org/jdk/pull/17514#issuecomment-1905139487
Re: RFR: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
On Mon, 22 Jan 2024 09:31:43 GMT, sendaoYan wrote: > 8323640: [TESTBUG]testMemoryFailCount in > jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because > OOM killed The test case before this PR has a maximum heap of 64MB and applies for 8M of memory each time in the for loop. When applying for memory for the sixth time, it was killed by the docker container because of OOM, jdk.internal.platform.Metrics.systemMetrics().getMemoryFailCount( ) interface has no chance to return 1, and the Java process returns exit code 137. The maximum heap is also 64M, The PR is changed to 1KB each time to ensure that the getMemoryFailCount() interface has a chance to return 1 and the test case has a chance to exit the for loop of memory allocation. ## test result before this PR:  ## test result after this PR:  - PR Comment: https://git.openjdk.org/jdk/pull/17514#issuecomment-1903589872
RFR: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed - Commit messages: - 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed Changes: https://git.openjdk.org/jdk/pull/17514/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17514=00 Issue: https://bugs.openjdk.org/browse/JDK-8323640 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/17514.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17514/head:pull/17514 PR: https://git.openjdk.org/jdk/pull/17514
Withdrawn: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
On Fri, 12 Jan 2024 03:31:37 GMT, sendaoYan wrote: > 8323640: [TESTBUG]testMemoryFailCount in > jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because > OOM killed This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/17386
Re: RFR: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed [v2]
> 8323640: [TESTBUG]testMemoryFailCount in > jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because > OOM killed sendaoYan has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed Signed-off-by: sendaoYan - Changes: - all: https://git.openjdk.org/jdk/pull/17386/files - new: https://git.openjdk.org/jdk/pull/17386/files/e8a99fe4..9f0aa2a1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=17386=01 - incr: https://webrevs.openjdk.org/?repo=jdk=17386=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/17386.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17386/head:pull/17386 PR: https://git.openjdk.org/jdk/pull/17386
Re: RFR: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
On Fri, 12 Jan 2024 03:31:37 GMT, sendaoYan wrote: > Reviewed-by: Yi Yang The test case before this PR has a maximum heap of 64MB and applies for 8M of memory each time in the for loop. When applying for memory for the sixth time, it was killed by the docker container because of OOM, jdk.internal.platform.Metrics.systemMetrics().getMemoryFailCount( ) interface has no chance to return 1, and the Java process returns exit code 137. The maximum heap is also 64M, The PR is changed to 1KB each time to ensure that the getMemoryFailCount() interface has a chance to return 1 and the test case has a chance to exit the for loop of memory allocation. ## test result before this PR:  ## test result after this PR:  - PR Comment: https://git.openjdk.org/jdk/pull/17386#issuecomment-1889517014
RFR: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
Reviewed-by: Yi Yang - Commit messages: - 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed Changes: https://git.openjdk.org/jdk/pull/17386/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17386=00 Issue: https://bugs.openjdk.org/browse/JDK-8323640 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/17386.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17386/head:pull/17386 PR: https://git.openjdk.org/jdk/pull/17386
