Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]
On Wed, 22 May 2024 07:56:26 GMT, Alan Bateman wrote: >>> @bchristi-git Just checking in—we're waiting for CSR-approval here before >>> integrating? 樂 >> >> Indeed - can't move forward without a CSR. Also wouldn't mind more reviewer >> ✔️s. > >> Indeed - can't move forward without a CSR. Also wouldn't mind more reviewer >> ✔️s. > > I can do that. One other thing to do is to rebase the changes, it looks like > this branch is 6 months behind main line. @AlanBateman @stuart-marks Any final words before @bchristi-git gets to do the honors of integrating? :) - PR Comment: https://git.openjdk.org/jdk/pull/16644#issuecomment-2142174930
Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]
On Tue, 21 May 2024 16:59:38 GMT, Brent Christian wrote: > Indeed - can't move forward without a CSR. Also wouldn't mind more reviewer > ✔️s. I can do that. One other thing to do is to rebase the changes, it looks like this branch is 6 months behind main line. - PR Comment: https://git.openjdk.org/jdk/pull/16644#issuecomment-2124116145
Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]
On Wed, 17 Apr 2024 17:12:28 GMT, Brent Christian wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Another update to reachabilityFence() @apiNote > > AFAICT, all review feedback on this change has been addressed. I would love > to have some reviewers take another look. Thanks! > @bchristi-git Just checking in—we're waiting for CSR-approval here before > integrating? 樂 Indeed - can't move forward without a CSR. Also wouldn't mind more reviewer ✔️s. - PR Comment: https://git.openjdk.org/jdk/pull/16644#issuecomment-2123059255
Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]
On Wed, 17 Apr 2024 17:12:28 GMT, Brent Christian wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Another update to reachabilityFence() @apiNote > > AFAICT, all review feedback on this change has been addressed. I would love > to have some reviewers take another look. Thanks! @bchristi-git Just checking in—we're waiting for CSR-approval here before integrating? 樂 - PR Comment: https://git.openjdk.org/jdk/pull/16644#issuecomment-2122461878
Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]
On Fri, 5 Apr 2024 23:13:39 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >> >> A couple key things we want to be able to say are: >> - `Reference.reachabilityFence(x)` _happens-before_ reference processing >> occurs for 'x'. >> - `Cleaner.register()` _happens-before_ the Cleaner thread runs the >> registered cleaning action. >> >> This will bring Cleaner in line (or close) with the memory visibility >> guarantees made for finalizers in [JLS >> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5): >> _"There is a happens-before edge from the end of a constructor of an object >> to the start of a finalizer (§12.6) for that object."_ > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > Another update to reachabilityFence() @apiNote Thanks Brent, I have no objections. Good job! - PR Comment: https://git.openjdk.org/jdk/pull/16644#issuecomment-2067611311
Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]
On Fri, 5 Apr 2024 23:13:39 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >> >> A couple key things we want to be able to say are: >> - `Reference.reachabilityFence(x)` _happens-before_ reference processing >> occurs for 'x'. >> - `Cleaner.register()` _happens-before_ the Cleaner thread runs the >> registered cleaning action. >> >> This will bring Cleaner in line (or close) with the memory visibility >> guarantees made for finalizers in [JLS >> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5): >> _"There is a happens-before edge from the end of a constructor of an object >> to the start of a finalizer (§12.6) for that object."_ > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > Another update to reachabilityFence() @apiNote AFAICT, all review feedback on this change has been addressed. I would love to have some reviewers take another look. Thanks! - PR Comment: https://git.openjdk.org/jdk/pull/16644#issuecomment-2061795930
Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Reference.reachabilityFence(x)` _happens-before_ reference processing > occurs for 'x'. > - `Cleaner.register()` _happens-before_ the Cleaner thread runs the > registered cleaning action. > > This will bring Cleaner in line (or close) with the memory visibility > guarantees made for finalizers in [JLS > 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5): > _"There is a happens-before edge from the end of a constructor of an object > to the start of a finalizer (§12.6) for that object."_ Brent Christian has updated the pull request incrementally with one additional commit since the last revision: Another update to reachabilityFence() @apiNote - Changes: - all: https://git.openjdk.org/jdk/pull/16644/files - new: https://git.openjdk.org/jdk/pull/16644/files/bdac5cce..91d4db48 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=16644=21 - incr: https://webrevs.openjdk.org/?repo=jdk=16644=20-21 Stats: 19 lines in 1 file changed: 0 ins; 5 del; 14 mod Patch: https://git.openjdk.org/jdk/pull/16644.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16644/head:pull/16644 PR: https://git.openjdk.org/jdk/pull/16644
