Re: RFR: 8331876: JFR: Move file read and write events to java.base [v5]

2024-05-17 Thread Alan Bateman 
On Thu, 16 May 2024 12:10:46 GMT, Erik Gahlin  wrote:

>> Hi,
>> 
>> Could I have a review of a change that moves the jdk.FileRead and 
>> jdk.FileWrite events to java.base to remove the use of the ASM 
>> instrumentation.
>> 
>> Testing: jdk/jdk/jfr
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Remove dependency on JFR for retransformation

src/java.base/share/classes/java/io/FileInputStream.java line 65:

> 63: /**
> 64:  * Flag set by jdk.internal.event.JFRTracing to determines if
> 65:  * file reads should be traced by JFR.

s/determines if/indicate if/

-

PR Review Comment: https://git.openjdk.org/jdk/pull/19129#discussion_r1604617070

Re: RFR: 8331876: JFR: Move file read and write events to java.base [v5]

2024-05-16 Thread Erik Gahlin 
> Hi,
> 
> Could I have a review of a change that moves the jdk.FileRead and 
> jdk.FileWrite events to java.base to remove the use of the ASM 
> instrumentation.
> 
> Testing: jdk/jdk/jfr
> 
> Thanks
> Erik

Erik Gahlin has updated the pull request incrementally with one additional 
commit since the last revision:

  Remove dependency on JFR for retransformation

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/19129/files
  - new: https://git.openjdk.org/jdk/pull/19129/files/f2439ac3..c4c64774

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk=19129=04
 - incr: https://webrevs.openjdk.org/?repo=jdk=19129=03-04

  Stats: 233 lines in 2 files changed: 122 ins; 111 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/19129.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19129/head:pull/19129

PR: https://git.openjdk.org/jdk/pull/19129