Re: RFR: 8330182: Start of release updates for JDK 24 [v2]
On Tue, 23 Apr 2024 07:03:45 GMT, David Holmes wrote: > There are further updates to this test in the pipeline (new deprecated flags > in 23) so you will need to keep updating to reflect that. Thanks @dholmes-ora ; acknowledged. - PR Review Comment: https://git.openjdk.org/jdk/pull/18787#discussion_r1583479535
Re: RFR: 8330182: Start of release updates for JDK 24 [v2]
On Wed, 17 Apr 2024 05:43:12 GMT, Joe Darcy wrote: >> Get JDK 24 underway. > > Joe Darcy has updated the pull request incrementally with two additional > commits since the last revision: > > - Correct release date as observed in review feedback. > - Improve javadoc of class file update. LGTM Thanks test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java line 1: > 1: /* There are further updates to this test in the pipeline (new deprecated flags in 23) so you will need to keep updating to reflect that. - Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2016422206 PR Review Comment: https://git.openjdk.org/jdk/pull/18787#discussion_r1575750313
Re: RFR: 8330182: Start of release updates for JDK 24 [v2]
On Wed, 17 Apr 2024 05:43:12 GMT, Joe Darcy wrote: >> Get JDK 24 underway. > > Joe Darcy has updated the pull request incrementally with two additional > commits since the last revision: > > - Correct release date as observed in review feedback. > - Improve javadoc of class file update. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2006604933
Re: RFR: 8330182: Start of release updates for JDK 24 [v2]
On Wed, 17 Apr 2024 05:43:12 GMT, Joe Darcy wrote: >> Get JDK 24 underway. > > Joe Darcy has updated the pull request incrementally with two additional > commits since the last revision: > > - Correct release date as observed in review feedback. > - Improve javadoc of class file update. ClassFile changes are OK. - Marked as reviewed by asotona (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2005504192
Re: RFR: 8330182: Start of release updates for JDK 24 [v2]
> Get JDK 24 underway. Joe Darcy has updated the pull request incrementally with two additional commits since the last revision: - Correct release date as observed in review feedback. - Improve javadoc of class file update. - Changes: - all: https://git.openjdk.org/jdk/pull/18787/files - new: https://git.openjdk.org/jdk/pull/18787/files/dcec9e96..dc488f21 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18787=01 - incr: https://webrevs.openjdk.org/?repo=jdk=18787=00-01 Stats: 5 lines in 2 files changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/18787.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18787/head:pull/18787 PR: https://git.openjdk.org/jdk/pull/18787
