[coreboot] [PATCH] fix Tyan s2881 boot (Kconfig)
This fixes breakage introduced in r5051. Thanks, Ward. -- Ward Vandewege w...@fsf.org Free Software Foundation - Senior Systems Administrator Revision 5051 broke Kconfig booting for the Tyan s2881 board. Up to 5050, there were two SB_HT_CHAIN_ON_BUS0 sections in the mainboard Kconfig file - one setting the parameter to 0, the other setting it to 2. Revision 5051 removed one of the two SB_HT_CHAIN_ON_BUS0 sections - the wrong one. This patch fixes that. Tested on real hardware. Signed-off-by: Ward Vandewege w...@gnu.org Index: src/mainboard/tyan/s2881/Kconfig === --- src/mainboard/tyan/s2881/Kconfig (revision 5076) +++ src/mainboard/tyan/s2881/Kconfig (working copy) @@ -24,7 +24,7 @@ config SB_HT_CHAIN_ON_BUS0 int - default 0 + default 2 depends on BOARD_TYAN_S2881 config LB_CKS_RANGE_END -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [PATCH] fix Tyan s2881 boot (Kconfig)
On 2/3/10 6:50 PM, Ward Vandewege wrote: This fixes breakage introduced in r5051. Thanks, Ward. Sorry for the inconvenience. Acked-by: Stefan Reinauer ste...@coresystems.de -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: i...@coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866 -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [PATCH] fix Tyan s2881 boot (Kconfig)
Am 03.02.2010 18:50, schrieb Ward Vandewege: This fixes breakage introduced in r5051. Sorry for that. I assumed newconfig would be fine: (Options.lb) #make the SB HT chain on bus 0, default is not (0) default CONFIG_SB_HT_CHAIN_ON_BUS0=0 If you want to change that in newconfig, too, consider both your patch and that change to be Acked-by: Patrick Georgi patrick.geo...@coresystems.de -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [PATCH] fix Tyan s2881 boot (Kconfig)
On Wed, Feb 03, 2010 at 06:52:57PM +0100, Stefan Reinauer wrote: On 2/3/10 6:50 PM, Ward Vandewege wrote: This fixes breakage introduced in r5051. Thanks, Ward. Sorry for the inconvenience. Acked-by: Stefan Reinauer ste...@coresystems.de No worries - fixed in r5083 for both newconfig and Kconfig. Thanks, Ward. -- Ward Vandewege w...@fsf.org Free Software Foundation - Senior Systems Administrator -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
