Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2
Committed to r4562. -Original Message- From: coreboot-boun...@coreboot.org [mailto:coreboot-boun...@coreboot.org] On Behalf Of Bao, Zheng Sent: Thursday, August 06, 2009 10:27 AM To: Ward Vandewege Cc: Coreboot Subject: Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2 I am trying to port the ddr3 feature. I will submit a full patch to replace this one. Zheng -Original Message- From: Ward Vandewege [mailto:w...@gnu.org] Sent: Tuesday, July 21, 2009 3:58 AM To: Bao, Zheng Cc: Coreboot Subject: Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2 On Thu, Jul 16, 2009 at 03:40:49PM +0800, Bao, Zheng wrote: This patch is about the DA-C2 and RB-C2. Chip with install processor Revision ID of 0x100F62 is DA-C2, instead of RB-C2 which was incorrectly defined in raminit_amdmct.c. RB-C2's ID is 0x100F42. The Erratas applied to them are almost the same. Issues: 1. I really dont know what their nicknames are (Shanghai C2 or something). 2. About the mc_patch_0186.h, I dont know if it is allowed to be released. If you really need it, please contact AMD Inc to see if it is public. 3. I haven't made coreboot go thoroughly on this RB-C2. This patch is just half tested. I am not confident it is 100% correct. Zheng Signed-off-by: Zheng Bao zheng@amd.com With this patch, I can still boot my system with 00100F42h (RB-C2) CPUs - Opteron 2372HE. Acked-by: Ward Vandewege w...@gnu.org Thanks, Ward. -- Ward Vandewege w...@gnu.org -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2
Issues: 1. I really don't know what their nicknames are (Shanghai C2 or something). 2. About the mc_patch_0186.h, I don't know if it is allowed to be released. If you really need it, please contact AMD Inc to see if it is public. 3. My RB-C2 is Socket type AM3, which needs DDR3 support. Probably your RB-C2 doesn't need DDR3. If it does and you really need it, please contact AMD Inc to see if it is allowed to release DDR3 code. Zheng -Original Message- From: coreboot-boun...@coreboot.org [mailto:coreboot-boun...@coreboot.org] On Behalf Of Bao, Zheng Sent: Monday, August 24, 2009 2:32 PM To: Coreboot Subject: Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2 Committed to r4562. -Original Message- From: coreboot-boun...@coreboot.org [mailto:coreboot-boun...@coreboot.org] On Behalf Of Bao, Zheng Sent: Thursday, August 06, 2009 10:27 AM To: Ward Vandewege Cc: Coreboot Subject: Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2 I am trying to port the ddr3 feature. I will submit a full patch to replace this one. Zheng -Original Message- From: Ward Vandewege [mailto:w...@gnu.org] Sent: Tuesday, July 21, 2009 3:58 AM To: Bao, Zheng Cc: Coreboot Subject: Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2 On Thu, Jul 16, 2009 at 03:40:49PM +0800, Bao, Zheng wrote: This patch is about the DA-C2 and RB-C2. Chip with install processor Revision ID of 0x100F62 is DA-C2, instead of RB-C2 which was incorrectly defined in raminit_amdmct.c. RB-C2's ID is 0x100F42. The Erratas applied to them are almost the same. Issues: 1. I really dont know what their nicknames are (Shanghai C2 or something). 2. About the mc_patch_0186.h, I dont know if it is allowed to be released. If you really need it, please contact AMD Inc to see if it is public. 3. I haven't made coreboot go thoroughly on this RB-C2. This patch is just half tested. I am not confident it is 100% correct. Zheng Signed-off-by: Zheng Bao zheng@amd.com With this patch, I can still boot my system with 00100F42h (RB-C2) CPUs - Opteron 2372HE. Acked-by: Ward Vandewege w...@gnu.org Thanks, Ward. -- Ward Vandewege w...@gnu.org -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2
On Thu, Aug 06, 2009 at 10:26:38AM +0800, Bao, Zheng wrote: I am trying to port the ddr3 feature. I will submit a full patch to replace this one. Sounds good, thanks. I won't be able to test until the end of August though, but perhaps someone else can ack before then. Thanks, Ward. -- Ward Vandewege w...@gnu.org -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2
I am trying to port the ddr3 feature. I will submit a full patch to replace this one. Zheng -Original Message- From: Ward Vandewege [mailto:w...@gnu.org] Sent: Tuesday, July 21, 2009 3:58 AM To: Bao, Zheng Cc: Coreboot Subject: Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2 On Thu, Jul 16, 2009 at 03:40:49PM +0800, Bao, Zheng wrote: This patch is about the DA-C2 and RB-C2. Chip with install processor Revision ID of 0x100F62 is DA-C2, instead of RB-C2 which was incorrectly defined in raminit_amdmct.c. RB-C2's ID is 0x100F42. The Erratas applied to them are almost the same. Issues: 1. I really dont know what their nicknames are (Shanghai C2 or something). 2. About the mc_patch_0186.h, I dont know if it is allowed to be released. If you really need it, please contact AMD Inc to see if it is public. 3. I haven't made coreboot go thoroughly on this RB-C2. This patch is just half tested. I am not confident it is 100% correct. Zheng Signed-off-by: Zheng Bao zheng@amd.com With this patch, I can still boot my system with 00100F42h (RB-C2) CPUs - Opteron 2372HE. Acked-by: Ward Vandewege w...@gnu.org Thanks, Ward. -- Ward Vandewege w...@gnu.org -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2
Bao, Zheng wrote: In Fam10 BKDG, it says 31:28 PkgType: package type. Specifies the processor package type. This field is encoded as follows: 0001b: AM2r2 or AM3. What is the difference between AM2 and AM2r2? //Peter -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2
On Thu, Jul 16, 2009 at 03:40:49PM +0800, Bao, Zheng wrote: This patch is about the DA-C2 and RB-C2. Chip with install processor Revision ID of 0x100F62 is DA-C2, instead of RB-C2 which was incorrectly defined in raminit_amdmct.c. RB-C2's ID is 0x100F42. The Erratas applied to them are almost the same. Issues: 1. I really dont know what their nicknames are (Shanghai C2 or something). 2. About the mc_patch_0186.h, I dont know if it is allowed to be released. If you really need it, please contact AMD Inc to see if it is public. 3. I haven't made coreboot go thoroughly on this RB-C2. This patch is just half tested. I am not confident it is 100% correct. Zheng Signed-off-by: Zheng Bao zheng@amd.com With this patch, I can still boot my system with 00100F42h (RB-C2) CPUs - Opteron 2372HE. Acked-by: Ward Vandewege w...@gnu.org Thanks, Ward. -- Ward Vandewege w...@gnu.org -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2
On Mon, Jul 20, 2009 at 10:10:13AM +0800, Bao, Zheng wrote: According to the Revision Guide, I think there might be several kinds of 0x100F42 RB-C2. They are AM2r2, AM3, F1207. Yeah, I see that on page 10 of the Fam10h Revision guide. Note that the link on http://developer.amd.com/documentation/guides/Pages/default.aspx to the Fam10 revision guide is wrong, the correct link is http://support.amd.com/us/Processor_TechDocs/41322.pdf The actual socket type should be read from CPUID_8001_EBX. Right? I think so, according to the revision guide... Thanks, Ward. -- Ward Vandewege w...@gnu.org -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2
If anyone can tell me what the nicknames of AMD_RB_C2 AMD_DA_C2 are, I will submit the code. Zheng -Original Message- From: Ward Vandewege [mailto:w...@gnu.org] Sent: Tuesday, July 21, 2009 3:58 AM To: Bao, Zheng Cc: Coreboot Subject: Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2 On Thu, Jul 16, 2009 at 03:40:49PM +0800, Bao, Zheng wrote: This patch is about the DA-C2 and RB-C2. Chip with install processor Revision ID of 0x100F62 is DA-C2, instead of RB-C2 which was incorrectly defined in raminit_amdmct.c. RB-C2's ID is 0x100F42. The Erratas applied to them are almost the same. Issues: 1. I really dont know what their nicknames are (Shanghai C2 or something). 2. About the mc_patch_0186.h, I dont know if it is allowed to be released. If you really need it, please contact AMD Inc to see if it is public. 3. I haven't made coreboot go thoroughly on this RB-C2. This patch is just half tested. I am not confident it is 100% correct. Zheng Signed-off-by: Zheng Bao zheng@amd.com With this patch, I can still boot my system with 00100F42h (RB-C2) CPUs - Opteron 2372HE. Acked-by: Ward Vandewege w...@gnu.org Thanks, Ward. -- Ward Vandewege w...@gnu.org -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2
According to the Revision Guide, I think there might be several kinds of 0x100F42 RB-C2. They are AM2r2, AM3, F1207. The actual socket type should be read from CPUID_8001_EBX. Right? Zheng -Original Message- From: Ward Vandewege [mailto:w...@gnu.org] Sent: Friday, July 17, 2009 11:42 PM To: Bao, Zheng Cc: Coreboot Subject: Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2 On Fri, Jul 17, 2009 at 10:01:35AM +0800, Bao, Zheng wrote: RB-C2 probably uses socket type AM3, which is not supported in Coreboot currently. I wonder if your board can go through the whole image. Hmm, I think there is some confusion here. If RB-C2 is really 0x100F42, then we are most certainly talking about Socket F. I have a few Opteron 2372 HE CPUs that are 0x100F42. You can contact tim.per...@amd.com about the patch releasing. Thank you, I have done so. Thanks, Ward. -- Ward Vandewege w...@gnu.org -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2
On Friday 17 July 2009 04:01:35 Bao, Zheng wrote: Hi Zheng RB-C2 probably uses socket type AM3, which is not supported in Coreboot currently. I wonder if your board can go through the whole image. The RB-C2 / 0x100f42 is socket F. Christian -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2
Hi, Christian, In Fam10 BKDG, it says CPUID Fn8000_0001_EBX BrandId Identifier Bits Description 31:28 PkgType: package type. Specifies the processor package type. This field is encoded as follows: b: Fr2(1207), Fr5(1207), or Fr6(1207). 0001b: AM2r2 or AM3. 0010b: S1g3 or S1g4. 0011b: G34. 0100b: ASB2. 0101b: C32. The CPUID Fn8000_0001_EBX of the CPU I am using is 0x10002056, whose bit 31:28 is 1, right? Zheng -Original Message- From: Christian Leber [mailto:christian.le...@ziti.uni-heidelberg.de] Sent: Friday, July 17, 2009 5:24 PM To: coreboot@coreboot.org Cc: Bao, Zheng Subject: Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2 On Friday 17 July 2009 04:01:35 Bao, Zheng wrote: Hi Zheng RB-C2 probably uses socket type AM3, which is not supported in Coreboot currently. I wonder if your board can go through the whole image. The RB-C2 / 0x100f42 is socket F. Christian -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2
On Fri, Jul 17, 2009 at 10:01:35AM +0800, Bao, Zheng wrote: RB-C2 probably uses socket type AM3, which is not supported in Coreboot currently. I wonder if your board can go through the whole image. Hmm, I think there is some confusion here. If RB-C2 is really 0x100F42, then we are most certainly talking about Socket F. I have a few Opteron 2372 HE CPUs that are 0x100F42. You can contact tim.per...@amd.com about the patch releasing. Thank you, I have done so. Thanks, Ward. -- Ward Vandewege w...@gnu.org -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2
Hi Zheng, On Thu, Jul 16, 2009 at 03:40:49PM +0800, Bao, Zheng wrote: This patch is about the DA-C2 and RB-C2. Chip with install processor Revision ID of 0x100F62 is DA-C2, instead of RB-C2 which was incorrectly defined in raminit_amdmct.c. RB-C2's ID is 0x100F42. The Erratas applied to them are almost the same. Aha. That would perhaps explain why my box with Quad-Core AMD Opteron(tm) Processor 2372 HE with revision id 0x100f42 really does not like ucode revision 92 (it resets itself constantly). Issues: 1. I really dont know what their nicknames are (Shanghai C2 or something). Don't know about that. 2. About the mc_patch_0186.h, I dont know if it is allowed to be released. If you really need it, please contact AMD Inc to see if it is public. Well, I have my box booting without any ucode update. It would be nice to have mc_patch_0186.h public if that's the revision for my cpus. Who do I ask? 3. I haven't made coreboot go thoroughly on this RB-C2. This patch is just half tested. I now have a working tree for Supermicro h8dmr with RB-C2 but it needs a bit more tweaking and cleaning up. I hope to get that ready soon so I can submit the patch to the list. I am not confident it is 100% correct. I'll test tonight or tomorrow and let you know how it goes. Thanks! Ward. -- Ward Vandewege w...@gnu.org -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2
RB-C2 probably uses socket type AM3, which is not supported in Coreboot currently. I wonder if your board can go through the whole image. You can contact tim.per...@amd.com about the patch releasing. Zheng -Original Message- From: Ward Vandewege [mailto:w...@gnu.org] Sent: Thursday, July 16, 2009 10:37 PM To: Bao, Zheng Cc: Coreboot Subject: Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2 Hi Zheng, On Thu, Jul 16, 2009 at 03:40:49PM +0800, Bao, Zheng wrote: This patch is about the DA-C2 and RB-C2. Chip with install processor Revision ID of 0x100F62 is DA-C2, instead of RB-C2 which was incorrectly defined in raminit_amdmct.c. RB-C2's ID is 0x100F42. The Erratas applied to them are almost the same. Aha. That would perhaps explain why my box with Quad-Core AMD Opteron(tm) Processor 2372 HE with revision id 0x100f42 really does not like ucode revision 92 (it resets itself constantly). Issues: 1. I really dont know what their nicknames are (Shanghai C2 or something). Don't know about that. 2. About the mc_patch_0186.h, I dont know if it is allowed to be released. If you really need it, please contact AMD Inc to see if it is public. Well, I have my box booting without any ucode update. It would be nice to have mc_patch_0186.h public if that's the revision for my cpus. Who do I ask? 3. I haven't made coreboot go thoroughly on this RB-C2. This patch is just half tested. I now have a working tree for Supermicro h8dmr with RB-C2 but it needs a bit more tweaking and cleaning up. I hope to get that ready soon so I can submit the patch to the list. I am not confident it is 100% correct. I'll test tonight or tomorrow and let you know how it goes. Thanks! Ward. -- Ward Vandewege w...@gnu.org -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
