Re: CURL_FTP_HTTPSTYLE_HEAD

2024-01-18 Thread Dan Fandrich via curl-library
On Wed, Jan 17, 2024 at 03:28:11PM +0100, Nejc Drašček via curl-library wrote:
> I'm using ftp library ( github.com/embeddedmz/ftpclient-cpp ), which under
> the hood uses libcurl, and some requests are "polluting" stdout with http
> headers:
> 
> Last-Modified: Mon, 15 Jan 2024 14:32:44 GMT
> Content-Length: 0
> Accept-ranges: bytes
> 
> According to comment in lib/ftp.c this define is/was supposed to be removed
> at next so bump. The define is still enabled on master at the time of this
> message. Modifying libcurl source locally is not an option since we're using
> vcpkg to manage (external) libraries.
> 
> If there is a way to do this I would be much obliged to be pointed in that
> direction.

I zoomed right over the identifier in the subject and didn't see it. Those
#ifdefs were added 17 years ago, and given curl's goal of backward
compatibility and no SONAME bumps, it's unlikely to be removed in the next 17
years.

Having said that, this codes writes to the write function so what happens to it 
is
under the application's control. If an application doesn't want it written to
stdout, it shouldn't write it to stdout. But, if the application is performing
a NOBODY request over FTP, presumably it wants to get some metadata for that
URL and therefore some output. In this respect, ftp: is handled the same as
http: support in this respect. Both:
  curl -I ftp://mirror2.tuxinator.org/robots.txt
and
  curl -I https://www.tuxinator.org/robots.txt
return similar kinds of information in similar ways.

I don't know what ftpclient-cpp does or wants to do with these requests, but it
sounds like it's not doing them in the way you want or expect. That's more
likely to be a problem with it rather than with curl.

Dan
-- 
Unsubscribe: https://lists.haxx.se/mailman/listinfo/curl-library
Etiquette:   https://curl.se/mail/etiquette.html


Re: problem with unpaused connection

2024-01-18 Thread Dan Fandrich via curl-library
On Thu, Jan 18, 2024 at 01:46:34PM +0300, Sergey Bronnikov via curl-library 
wrote:
> Before Curl version 8.4.0 everything worked fine (exactly with Curl 8.3.0),
> but after updating Curl to 8.4.0 in our HTTP client

Have you tried 8.5.0? There have been some important HTTP/2 changes since that
version.

Dan
-- 
Unsubscribe: https://lists.haxx.se/mailman/listinfo/curl-library
Etiquette:   https://curl.se/mail/etiquette.html


problem with unpaused connection

2024-01-18 Thread Sergey Bronnikov via curl-library

Hello, everyone


I'm stuck with a problem and asking for a help.


Context:

we have a project that contains a HTTP client with Lua API implemented 
using Curl library, sources are [3] and [4].


This Lua HTTP client used in another closed-source Lua module that 
implements an etcd client in Lua.


Before Curl version 8.4.0 everything worked fine (exactly with Curl 
8.3.0), but after updating Curl to 8.4.0 in our HTTP client


some tests for etcd-client Lua module became failed from time to time.

There are test logs for passed and failed cases with enabled debug in 
curl: [5] and [6] and diff [7].



Observations:

1. The problem is specific for HTTP/2 protocol, because problem is gone

if force HTTP 1.1 protocol with CURL_HTTP_VERSION_1_1.

2. Problem is triggered by commit [3] introduced in Curl 8.4.0 [4],

because the problem is gone after reverting aforementioned commit.


Symptoms:

curl library with enabled debug prints a message below before a test fail:

> readwrite, dselect_bits, early return on PAUSED

This message was introduced in aforementioned commit to curl library.


Current version of Curl library: 8.5.0

OS: Ubuntu x86_64 22.04


What could cause a problem? As I got a debug message right connection 
become paused


and no one unpause it. Curl callback 'curl_easy_io_read_cb' returns 
CURL_READFUNC_PAUSE


and on next read httpc_request_io_write unpauses connection with 
CURLPAUSE_SEND_CONT.




1. https://github.com/tarantool/tarantool/blob/master/src/curl.c

2. https://github.com/tarantool/tarantool/blob/master/src/httpc.c

3. 
https://github.com/curl/curl/commit/6b9a591bf7d82031f463373706d7de1cba0adee6


4. https://curl.se/changes.html#8_4_0

5. 
https://github.com/ligurio/snippets/blob/master/curl-question/curl-fail.log


6. 
https://github.com/ligurio/snippets/blob/master/curl-question/curl-pass.log


7. 
https://github.com/ligurio/snippets/blob/master/curl-question/curl-diff.log


--
Unsubscribe: https://lists.haxx.se/mailman/listinfo/curl-library
Etiquette:   https://curl.se/mail/etiquette.html


Re: Daily source snapshots stopped updating

2024-01-18 Thread Daniel Stenberg via curl-library

On Thu, 18 Jan 2024, Marcel Raad via curl-library wrote:

The daily source snapshots on https://curl.se/snapshots/ stopped updating 
after January 9, which stopped my autobuilds. Not sure if that would be a 
curl or website issue, so I'm reporting it here instead of a GitHub issue.


Oops, #12661 hits again... I'll fix!

--

 / daniel.haxx.se
 | Commercial curl support up to 24x7 is available!
 | Private help, bug fixes, support, ports, new features
 | https://curl.se/support.html
--
Unsubscribe: https://lists.haxx.se/mailman/listinfo/curl-library
Etiquette:   https://curl.se/mail/etiquette.html


Re: CURL_FTP_HTTPSTYLE_HEAD

2024-01-18 Thread Nejc Drašček via curl-library
Define in title of this topic, github link: 
https://github.com/curl/curl/blob/master/lib/ftp.c#L230



--
Unsubscribe: https://lists.haxx.se/mailman/listinfo/curl-library
Etiquette:   https://curl.se/mail/etiquette.html


Daily source snapshots stopped updating

2024-01-18 Thread Marcel Raad via curl-library
Hi,

The daily source snapshots on https://curl.se/snapshots/ stopped updating after 
January 9,
which stopped my autobuilds. Not sure if that would be a curl or website issue, 
so I'm
reporting it here instead of a GitHub issue.

Marcel
-- 
Unsubscribe: https://lists.haxx.se/mailman/listinfo/curl-library
Etiquette:   https://curl.se/mail/etiquette.html