Processed: your mail
Processing commands for cont...@bugs.debian.org: > tags 872059 +pending Bug #872059 [debootstrap] No longer creates /dev/console. Added tag(s) pending. > tags 872577 +pending Bug #872577 [debootstrap] debootstrap: Handle existing /dev Added tag(s) pending. > tags 698677 +pending Bug #698677 [debootstrap] debootstrap: 'Release signed by unknown key' should report keyring used Added tag(s) pending. > tags 893954 +pending Bug #893954 [debootstrap] debootstrap ignores https mirror setting, just use default http mirror (i.e. http://deb.debian.org) Added tag(s) pending. > tags 872948 +pending Bug #872948 [debootstrap] debootstrap: Debootstrap does not explain what is calls a Debian base system Added tag(s) pending. > thanks Stopping processing here. Please contact me if you need assistance. -- 698677: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=698677 872059: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872059 872577: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872577 872948: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872948 893954: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=893954 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: your mail
Processing commands for cont...@bugs.debian.org: > tags 563647 +pending Bug #563647 [debootstrap] debootstrap: manpage neglects complete path for --unpack-tarball Added tag(s) pending. > thanks Stopping processing here. Please contact me if you need assistance. -- 563647: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=563647 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: reassign 894673 to wnpp, reassign 894231 to installation-reports
Processing commands for cont...@bugs.debian.org: > reassign 894673 wnpp Bug #894673 [adapta-gtk-theme] RFP:RequestForPackage: adapta-gtk-theme Warning: Unknown package 'adapta-gtk-theme' Bug reassigned from package 'adapta-gtk-theme' to 'wnpp'. No longer marked as found in versions 3.93.0.225-0ubuntu1~bionic1. Ignoring request to alter fixed versions of bug #894673 to the same values previously set > reassign 894231 installation-reports Bug #894231 [debian 9.3.0 stretch installation reports] Debian 9.3 (stretch) Installation Warning: Unknown package 'debian' Warning: Unknown package '9.3.0' Warning: Unknown package 'stretch' Warning: Unknown package 'installation' Warning: Unknown package 'reports' Bug reassigned from package 'debian 9.3.0 stretch installation reports' to 'installation-reports'. Ignoring request to alter found versions of bug #894231 to the same values previously set Ignoring request to alter fixed versions of bug #894231 to the same values previously set > thanks Stopping processing here. Please contact me if you need assistance. -- 894231: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894231 894673: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894673 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
nobootloader_1.52_source.changes ACCEPTED into unstable
Accepted: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Format: 1.8 Date: Tue, 03 Apr 2018 18:19:21 +0200 Source: nobootloader Binary: nobootloader Architecture: source Version: 1.52 Distribution: unstable Urgency: medium Maintainer: Debian Install System TeamChanged-By: Christian Perrier Description: nobootloader - Don't install any bootloader (udeb) Changes: nobootloader (1.52) unstable; urgency=medium . [ Updated translations ] * Hebrew (he.po) by Yaron Shahrabani Checksums-Sha1: c43e02b37b6b41316973cb6574578fec9e8d764e 1643 nobootloader_1.52.dsc ee88d60ea5e81fbc1d9aaedc30a526f228aa9f84 79192 nobootloader_1.52.tar.xz Checksums-Sha256: 1ae58c6102cdcafab9037daa15e6f79f3eec67d7bbcc749fc8b31ad1a46af42e 1643 nobootloader_1.52.dsc 2c551731920e3eb29bbcd230a042e50be1a5c345f365316ebb4a0928373146d5 79192 nobootloader_1.52.tar.xz Files: 01fb1336346cac1dfcf9112c240d54a9 1643 debian-installer standard nobootloader_1.52.dsc 21c7bde1f8e4e9af55b9ba2fb50975f9 79192 debian-installer standard nobootloader_1.52.tar.xz -BEGIN PGP SIGNATURE- iQIzBAEBCAAdFiEE1cL5v8oSi7oip3IYhy9wLE1uJagFAlrDrL4ACgkQhy9wLE1u JagbjA//UhFgf1zRygcJdfzL8E3MIeO5pYNQdSlBRaaAD7TwNF7971qX8bGLfDk0 p5zZ8k1X9tvkhtXU1VBZ2KzOvquAP8A/lKpV4UsRR0NOOM7DF9Ie09DYObqKZkmh YD6P7gseMMxGV+6GRpuK0HLmZ584FeckEe+vbhkHXmKlOgLU3p7j7L4y4jIHbxiO u+vQydSFSxN+vQ5O9eLFi0J8H7hK6vIDpQuIS9QnLlHwCp1P8QDPWrSSfQea1X7F MNTVH5BmOr5KuJtvYXRmNEuY4EHdWyf/PQsCtHIfZ4el8piQJcY52+jZotwiWP1g ysCMBxUUWvLsOrZTbHfHRYWAFlcrS7UwVaj93BrQosuNyc/D6iQnFT55xYuHKwvf Hug2y+O4OGi2uRgpQg6dA2RbM5IaaeBwirpxk+/TE/+LqlEDZTyyNAi1h1l8gmXU RMpcfsP470EubhsXFv+Qd4XeTXRjYqJ6NjlfOJqxPmG3yi4g7CD9a8hKeXwx6R8x wVFNUY4sXDPoad3e0dOVFESQKkOloZkkK7Mn2PXzYCYuAse1ghLKVqeX6vEIXB/T bMhunMDzJBynxplUfucfG/N8QrJLGUSHkCw4N5u582oPcC50ukmcIlXPrg4vdCfo yFmbClxjAQIjSAwDoF0cwRGBCtHv8/6K5wTZMfuRohleyqWvHHc= =bBB5 -END PGP SIGNATURE- Thank you for your contribution to Debian.
network-console_1.77_source.changes ACCEPTED into unstable
Accepted: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Format: 1.8 Date: Tue, 03 Apr 2018 06:55:09 +0200 Source: network-console Binary: network-console Architecture: source Version: 1.77 Distribution: unstable Urgency: medium Maintainer: Debian Install System TeamChanged-By: Christian Perrier Description: network-console - Continue installation remotely using SSH (udeb) Changes: network-console (1.77) unstable; urgency=medium . [ Updated translations ] * Arabic (ar.po) by ButterflyOfFire * Welsh (cy.po) by Huw Waters * Hebrew (he.po) by Yaron Shahrabani Checksums-Sha1: 65f60eead33c0edaa3abc10742ecbe567d7de0c8 1680 network-console_1.77.dsc 96f38cd1fd91db9412d462cfb4ec8f7ade65d9d8 98100 network-console_1.77.tar.xz Checksums-Sha256: 7fb18adb6999575698a2b82433ce2659cb3db6bb80cbd064e768eb333739003f 1680 network-console_1.77.dsc d6d89df2993b853fcba3fe8df8e8a056008398c9c05e4ade131e02c074c1c8f5 98100 network-console_1.77.tar.xz Files: 5ef54865bc0fa71e67c6af29060bb9b4 1680 debian-installer optional network-console_1.77.dsc d1214d038cc29224eb3fbd196be21bd6 98100 debian-installer optional network-console_1.77.tar.xz -BEGIN PGP SIGNATURE- iQIzBAEBCAAdFiEE1cL5v8oSi7oip3IYhy9wLE1uJagFAlrDqTAACgkQhy9wLE1u JaiCVxAAs3ID/YEh9saQrMaGczqOZMeQIYFsWf9+WcQXB/L8DU+uNEQHKDmThAmG uPs5uZ8TVFRgFK6pj144DabmlJwIoSFd6BPQm9OsCOJwTBy4Z3yA207pBRAxcdxq DBCb3srwBnc+Zjql4V0VXRPc1I5fAx5MZgc1pxIK49447+LuZML41AWoBFVxGspJ TfcQIKnS28YTgzHsq+RlwtqeEzIvqg+bt4z2Cz1skJVeLiqxHj6+BolOKP2rCZ0r fAmny6n7skhQ1PLAculRTgFwt5m+mjX3m2tBqYkRBZlam4TdsC5R/YH/l6HpjyQS F0Kf7wEYUawH99ylgsEBuJTjVemJ9ab4kVSRkwwfKE76VYbeVycKutf2wOONs9+0 W0fYrGIWsV+v2H6Fl1R2Iv4T0X2ziGFTDaIfGxPaW5JepNdi6gLnDdKsNj83P4t6 URKTb6eH6rQSZhg8PEbsHHk9Ei9SEf5E4Aw4Z+dhEdJMhMPXJi0CACkUqzfkf4cY oLya+lBopMKXTOdZO3DAuhe6DI1RHSJtdYYZsdXL0o2WdiVrpD5IzJFUY473Y6yt fxlUTsndtD3tHQ9E4Vk5fshbnkLD6mD8i2LO+4RYQ3VxAZ4L26xr6O8hx9DuFBCa cY4y4+E6f0pWyfEHe1zXr/dpYGzlEg6Xqq2l0pkPkOWBcbByBpY= =jNjw -END PGP SIGNATURE- Thank you for your contribution to Debian.
Accepted nobootloader 1.52 (source) into unstable
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Format: 1.8 Date: Tue, 03 Apr 2018 18:19:21 +0200 Source: nobootloader Binary: nobootloader Architecture: source Version: 1.52 Distribution: unstable Urgency: medium Maintainer: Debian Install System TeamChanged-By: Christian Perrier Description: nobootloader - Don't install any bootloader (udeb) Changes: nobootloader (1.52) unstable; urgency=medium . [ Updated translations ] * Hebrew (he.po) by Yaron Shahrabani Checksums-Sha1: c43e02b37b6b41316973cb6574578fec9e8d764e 1643 nobootloader_1.52.dsc ee88d60ea5e81fbc1d9aaedc30a526f228aa9f84 79192 nobootloader_1.52.tar.xz Checksums-Sha256: 1ae58c6102cdcafab9037daa15e6f79f3eec67d7bbcc749fc8b31ad1a46af42e 1643 nobootloader_1.52.dsc 2c551731920e3eb29bbcd230a042e50be1a5c345f365316ebb4a0928373146d5 79192 nobootloader_1.52.tar.xz Files: 01fb1336346cac1dfcf9112c240d54a9 1643 debian-installer standard nobootloader_1.52.dsc 21c7bde1f8e4e9af55b9ba2fb50975f9 79192 debian-installer standard nobootloader_1.52.tar.xz -BEGIN PGP SIGNATURE- iQIzBAEBCAAdFiEE1cL5v8oSi7oip3IYhy9wLE1uJagFAlrDrL4ACgkQhy9wLE1u JagbjA//UhFgf1zRygcJdfzL8E3MIeO5pYNQdSlBRaaAD7TwNF7971qX8bGLfDk0 p5zZ8k1X9tvkhtXU1VBZ2KzOvquAP8A/lKpV4UsRR0NOOM7DF9Ie09DYObqKZkmh YD6P7gseMMxGV+6GRpuK0HLmZ584FeckEe+vbhkHXmKlOgLU3p7j7L4y4jIHbxiO u+vQydSFSxN+vQ5O9eLFi0J8H7hK6vIDpQuIS9QnLlHwCp1P8QDPWrSSfQea1X7F MNTVH5BmOr5KuJtvYXRmNEuY4EHdWyf/PQsCtHIfZ4el8piQJcY52+jZotwiWP1g ysCMBxUUWvLsOrZTbHfHRYWAFlcrS7UwVaj93BrQosuNyc/D6iQnFT55xYuHKwvf Hug2y+O4OGi2uRgpQg6dA2RbM5IaaeBwirpxk+/TE/+LqlEDZTyyNAi1h1l8gmXU RMpcfsP470EubhsXFv+Qd4XeTXRjYqJ6NjlfOJqxPmG3yi4g7CD9a8hKeXwx6R8x wVFNUY4sXDPoad3e0dOVFESQKkOloZkkK7Mn2PXzYCYuAse1ghLKVqeX6vEIXB/T bMhunMDzJBynxplUfucfG/N8QrJLGUSHkCw4N5u582oPcC50ukmcIlXPrg4vdCfo yFmbClxjAQIjSAwDoF0cwRGBCtHv8/6K5wTZMfuRohleyqWvHHc= =bBB5 -END PGP SIGNATURE-
Processing of nobootloader_1.52_source.changes
nobootloader_1.52_source.changes uploaded successfully to localhost along with the files: nobootloader_1.52.dsc nobootloader_1.52.tar.xz Greetings, Your Debian queue daemon (running on host usper.debian.org)
Processing of network-console_1.77_source.changes
network-console_1.77_source.changes uploaded successfully to localhost along with the files: network-console_1.77.dsc network-console_1.77.tar.xz Greetings, Your Debian queue daemon (running on host usper.debian.org)
Accepted network-console 1.77 (source) into unstable
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Format: 1.8 Date: Tue, 03 Apr 2018 06:55:09 +0200 Source: network-console Binary: network-console Architecture: source Version: 1.77 Distribution: unstable Urgency: medium Maintainer: Debian Install System TeamChanged-By: Christian Perrier Description: network-console - Continue installation remotely using SSH (udeb) Changes: network-console (1.77) unstable; urgency=medium . [ Updated translations ] * Arabic (ar.po) by ButterflyOfFire * Welsh (cy.po) by Huw Waters * Hebrew (he.po) by Yaron Shahrabani Checksums-Sha1: 65f60eead33c0edaa3abc10742ecbe567d7de0c8 1680 network-console_1.77.dsc 96f38cd1fd91db9412d462cfb4ec8f7ade65d9d8 98100 network-console_1.77.tar.xz Checksums-Sha256: 7fb18adb6999575698a2b82433ce2659cb3db6bb80cbd064e768eb333739003f 1680 network-console_1.77.dsc d6d89df2993b853fcba3fe8df8e8a056008398c9c05e4ade131e02c074c1c8f5 98100 network-console_1.77.tar.xz Files: 5ef54865bc0fa71e67c6af29060bb9b4 1680 debian-installer optional network-console_1.77.dsc d1214d038cc29224eb3fbd196be21bd6 98100 debian-installer optional network-console_1.77.tar.xz -BEGIN PGP SIGNATURE- iQIzBAEBCAAdFiEE1cL5v8oSi7oip3IYhy9wLE1uJagFAlrDqTAACgkQhy9wLE1u JaiCVxAAs3ID/YEh9saQrMaGczqOZMeQIYFsWf9+WcQXB/L8DU+uNEQHKDmThAmG uPs5uZ8TVFRgFK6pj144DabmlJwIoSFd6BPQm9OsCOJwTBy4Z3yA207pBRAxcdxq DBCb3srwBnc+Zjql4V0VXRPc1I5fAx5MZgc1pxIK49447+LuZML41AWoBFVxGspJ TfcQIKnS28YTgzHsq+RlwtqeEzIvqg+bt4z2Cz1skJVeLiqxHj6+BolOKP2rCZ0r fAmny6n7skhQ1PLAculRTgFwt5m+mjX3m2tBqYkRBZlam4TdsC5R/YH/l6HpjyQS F0Kf7wEYUawH99ylgsEBuJTjVemJ9ab4kVSRkwwfKE76VYbeVycKutf2wOONs9+0 W0fYrGIWsV+v2H6Fl1R2Iv4T0X2ziGFTDaIfGxPaW5JepNdi6gLnDdKsNj83P4t6 URKTb6eH6rQSZhg8PEbsHHk9Ei9SEf5E4Aw4Z+dhEdJMhMPXJi0CACkUqzfkf4cY oLya+lBopMKXTOdZO3DAuhe6DI1RHSJtdYYZsdXL0o2WdiVrpD5IzJFUY473Y6yt fxlUTsndtD3tHQ9E4Vk5fshbnkLD6mD8i2LO+4RYQ3VxAZ4L26xr6O8hx9DuFBCa cY4y4+E6f0pWyfEHe1zXr/dpYGzlEg6Xqq2l0pkPkOWBcbByBpY= =jNjw -END PGP SIGNATURE-
Bug#563647: debootstrap: manpage neglects complete path for
On Tue, 3 Apr 2018 13:14:15 +0100 Justin B Ryewrote: > Yes, this is an improvement if it might use HTTPS, though not if it > will always use HTTP. debootstrap work depends on mirror and it use both HTTP and HTTPS by default. > But you missed the equivalent text in the debootstrap usage message: Okay, I just looked at debootstrap.8 file. Fixed :) -- Regards, Hideki Yamane henrich @ debian.org/iijmio-mail.jp
Bug#563647: debootstrap: manpage neglects complete path for
Hideki Yamane wrote: >> If I was doing a pedantic review of every bit of debootstrap's >> documentation and output I'd suggest replacing "http(s)" with >> "HTTP(S)" throughout, but there's no point doing that just here. > > I can find only one "via http" word, as below. Is it okay? Well, I was saying "don't bother"! But it looks easier than I was assuming. > diff --git a/debootstrap.8 b/debootstrap.8 > index e802003..87e2ae1 100644 > --- a/debootstrap.8 > +++ b/debootstrap.8 > @@ -137,7 +137,7 @@ Don't delete the /debootstrap directory in the target > after completing the > installation. > .IP > .IP "\fB\-\-unpack\-tarball=FILE\fP" > -Acquire .debs from tarball FILE instead of downloading via http. > +Acquire .debs from tarball FILE instead of downloading via HTTP(S). Yes, this is an improvement if it might use HTTPS, though not if it will always use HTTP. But you missed the equivalent text in the debootstrap usage message: --unpack-tarball=T acquire .debs from a tarball instead of http (Elsewhere in the usage output it already uses uppercase.) I notice one other mention of wrong-case "https" in the debootstrap sources (apart from changelog mentions): "functions" has a "keyring()" function with this output: info KEYRING "Keyring file not available at %s; switching to https mirror %s" "$1" "$DEF_HTTPS_MIRROR" ^ -- JBR with qualifications in linguistics, experience as a Debian sysadmin, and probably no clue about this particular package
Bug#563647: debootstrap: manpage neglects complete path for
Hi, On Tue, 3 Apr 2018 12:30:34 +0100 Justin B Ryewrote: > > Could you review below messages in deboostrap manpage, please? > > Looks good to me. Thanks! > If I was doing a pedantic review of every bit of debootstrap's > documentation and output I'd suggest replacing "http(s)" with > "HTTP(S)" throughout, but there's no point doing that just here. I can find only one "via http" word, as below. Is it okay? diff --git a/debootstrap.8 b/debootstrap.8 index e802003..87e2ae1 100644 --- a/debootstrap.8 +++ b/debootstrap.8 @@ -137,7 +137,7 @@ Don't delete the /debootstrap directory in the target after completing the installation. .IP .IP "\fB\-\-unpack\-tarball=FILE\fP" -Acquire .debs from tarball FILE instead of downloading via http. +Acquire .debs from tarball FILE instead of downloading via HTTP(S). .IP .IP "\fB\-\-make\-tarball=FILE\fP" Instead of bootstrapping, make a tarball (written to FILE) of the downloaded -- Regards, Hideki Yamane henrich @ debian.org/iijmio-mail.jp
Bug#563647: debootstrap: manpage neglects complete path for
Hideki Yamane wrote: > Could you review below messages in deboostrap manpage, please? Looks good to me. > > On Wed, 21 Mar 2018 17:36:07 +0900 Hideki Yamane> wrote: >> Here's a proposed patch for it. >> >> diff --git a/debootstrap b/debootstrap >> index 083473d..1d5d5c6 100755 >> --- a/debootstrap >> +++ b/debootstrap >> @@ -550,7 +550,7 @@ fi >> >> if [ "$UNPACK_TARBALL" ]; then >> if [ "${UNPACK_TARBALL#/}" = "$UNPACK_TARBALL" ]; then >> -error 1 TARPATH "Tarball must be given a complete path" >> +error 1 TARPATH "Tarball must be given an absolute path" >> fi >> if [ "${UNPACK_TARBALL%.tar}" != "$UNPACK_TARBALL" ]; then >> (cd "$TARGET" && tar -xf "$UNPACK_TARBALL") >> diff --git a/debootstrap.8 b/debootstrap.8 >> index e802003..699f1fd 100644 >> --- a/debootstrap.8 >> +++ b/debootstrap.8 >> @@ -137,11 +137,12 @@ Don't delete the /debootstrap directory in the target >> after completing the >> installation. >> .IP >> .IP "\fB\-\-unpack\-tarball=FILE\fP" >> -Acquire .debs from tarball FILE instead of downloading via http. >> +Acquire .debs from gzipped tarball FILE (specified with absolute path) >> +instead of downloading via http. >> .IP >> .IP "\fB\-\-make\-tarball=FILE\fP" >> -Instead of bootstrapping, make a tarball (written to FILE) of the downloaded >> -packages. >> +Instead of bootstrapping, make a gzipped tarball (written to FILE) of the >> +downloaded packages. >> The resulting tarball may be passed to a later >> .BR \-\-unpack\-tarball . >> .IP If I was doing a pedantic review of every bit of debootstrap's documentation and output I'd suggest replacing "http(s)" with "HTTP(S)" throughout, but there's no point doing that just here. -- JBR with qualifications in linguistics, experience as a Debian sysadmin, and probably no clue about this particular package
Bug#563647: debootstrap: manpage neglects complete path for
--unpack-tarball Message-Id: <20180403194408.2fe90c84d510e7c600c25...@iijmio-mail.jp> In-Reply-To: <20180321173607.98899f6a4719754b42d41...@iijmio-mail.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Hi list, Could you review below messages in deboostrap manpage, please? On Wed, 21 Mar 2018 17:36:07 +0900 Hideki Yamanewrote: > Here's a proposed patch for it. > > diff --git a/debootstrap b/debootstrap > index 083473d..1d5d5c6 100755 > --- a/debootstrap > +++ b/debootstrap > @@ -550,7 +550,7 @@ fi > > if [ "$UNPACK_TARBALL" ]; then > if [ "${UNPACK_TARBALL#/}" = "$UNPACK_TARBALL" ]; then > - error 1 TARPATH "Tarball must be given a complete path" > + error 1 TARPATH "Tarball must be given an absolute path" > fi > if [ "${UNPACK_TARBALL%.tar}" != "$UNPACK_TARBALL" ]; then > (cd "$TARGET" && tar -xf "$UNPACK_TARBALL") > diff --git a/debootstrap.8 b/debootstrap.8 > index e802003..699f1fd 100644 > --- a/debootstrap.8 > +++ b/debootstrap.8 > @@ -137,11 +137,12 @@ Don't delete the /debootstrap directory in the target > after completing the > installation. > .IP > .IP "\fB\-\-unpack\-tarball=FILE\fP" > -Acquire .debs from tarball FILE instead of downloading via http. > +Acquire .debs from gzipped tarball FILE (specified with absolute path) > +instead of downloading via http. > .IP > .IP "\fB\-\-make\-tarball=FILE\fP" > -Instead of bootstrapping, make a tarball (written to FILE) of the downloaded > -packages. > +Instead of bootstrapping, make a gzipped tarball (written to FILE) of the > +downloaded packages. > The resulting tarball may be passed to a later > .BR \-\-unpack\-tarball . > .IP > > -- Regards, Hideki Yamane henrich @ debian.org/iijmio-mail.jp
Re: debootstrap 1.0.93+nmu5
On Tue, 3 Apr 2018 11:53:45 +0200 Raphael Hertzogwrote: > > +if [ -e /usr/bin/apt-config ]; then > > In case like this, you usually use "-x" to ensure it's also executable. Thanks :) -- Regards, Hideki Yamane henrich @ debian.org/iijmio-mail.jp
Re: debootstrap 1.0.93+nmu5
On Tue, 03 Apr 2018, Hideki Yamane wrote: > +if [ -e /usr/bin/apt-config ]; then In case like this, you usually use "-x" to ensure it's also executable. > +eval $(apt-config shell AUTOPROXY Acquire::http::ProxyAutoDetect) > +if [ -z "$http_proxy" ] && [ -x "$AUTOPROXY" ]; then > +http_proxy="$($AUTOPROXY)" > +if [ -n "$http_proxy" ]; then > +echo "Using auto-detected proxy: $http_proxy" > +export http_proxy > +fi > fi > fi > - > -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: https://www.freexian.com/services/debian-lts.html Learn to master Debian: https://debian-handbook.info/get/
Re: debootstrap 1.0.93+nmu5
On Tue, 3 Apr 2018 11:20:43 +0200 Raphael Hertzogwrote: > In most postinst snippets, it is used like this: > > if which apt-config >/dev/null 2>&1; then > > I don't see the need for a sub-shell. I've tried which command on NetBSD, it failed. So just check "test -e" for /usr/bin/apt-config as below. diff --git a/debootstrap b/debootstrap index 083473d..dfdff4b 100755 --- a/debootstrap +++ b/debootstrap @@ -51,15 +51,16 @@ DEF_HTTPS_MIRROR="https://deb.debian.org/debian; # do auto proxy discovery AUTOPROXY="" -eval $(apt-config shell AUTOPROXY Acquire::http::ProxyAutoDetect) -if [ -z "$http_proxy" ] && [ -x "$AUTOPROXY" ]; then -http_proxy="$($AUTOPROXY)" -if [ -n "$http_proxy" ]; then -echo "Using auto-detected proxy: $http_proxy" -export http_proxy +if [ -e /usr/bin/apt-config ]; then +eval $(apt-config shell AUTOPROXY Acquire::http::ProxyAutoDetect) +if [ -z "$http_proxy" ] && [ -x "$AUTOPROXY" ]; then +http_proxy="$($AUTOPROXY)" +if [ -n "$http_proxy" ]; then +echo "Using auto-detected proxy: $http_proxy" +export http_proxy +fi fi fi -
Re: debootstrap 1.0.93+nmu5
On Fri, 30 Mar 2018, Hideki Yamane wrote: > On Fri, 30 Mar 2018 14:24:27 +0200 > Raphael Hertzogwrote: > > debootstrap can be run on a non-Debian system and should not assume that > > apt-config is available. I would suggest to protect this code with > > a check of the existence of apt-config. > > You're right. Then, how about this? > > if (which apt-config > /dev/null); then In most postinst snippets, it is used like this: if which apt-config >/dev/null 2>&1; then I don't see the need for a sub-shell. Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: https://www.freexian.com/services/debian-lts.html Learn to master Debian: https://debian-handbook.info/get/