Bug#1024311: Bug#1024276: #1024276: ITP: golang-github-googleapis-enterprise-certificate-proxy -- Google Proxies for
On 2023-12-17 15:12, Drew Parsons wrote: On 2023-12-17 03:30, Maytham Alsudany wrote: Hi Drew, We've got a mechanism using debian/watch and debian/copyright to automate removing third_party/pkcs11/* and creating the 0.*.0+dfsg tarball. I suggest making a Merge Request with your fix so we can review that, and then merge it all together. Done, see https://salsa.debian.org/go-team/packages/golang-github-google-go-pkcs11/-/merge_requests/1 Thanks Maytham. I've made review. Don't erase the existing package history in debian/changelog. I had a small question about the include path for pkcs11.h (how does the build system know about nss? The last revision of the MR looks good, I've merged now. Maytham, have you got push rights to the repo to push the updates to the upstream branch and the tags for the final upstream source commit? Drew
Bug#1024311: Bug#1024276: #1024276: ITP: golang-github-googleapis-enterprise-certificate-proxy -- Google Proxies for
On 2023-12-17 03:30, Maytham Alsudany wrote: Hi Drew, We've got a mechanism using debian/watch and debian/copyright to automate removing third_party/pkcs11/* and creating the 0.*.0+dfsg tarball. I suggest making a Merge Request with your fix so we can review that, and then merge it all together. Done, see https://salsa.debian.org/go-team/packages/golang-github-google-go-pkcs11/-/merge_requests/1 Thanks Maytham. I've made review. Don't erase the existing package history in debian/changelog. I had a small question about the include path for pkcs11.h (how does the build system know about nss? Drew
Bug#1024311: Bug#1024276: #1024276: ITP: golang-github-googleapis-enterprise-certificate-proxy -- Google Proxies for
Hi Drew, > We've got a mechanism using debian/watch and debian/copyright to > automate removing third_party/pkcs11/* and creating the 0.*.0+dfsg > tarball. I suggest making a Merge Request with your fix so we can > review that, and then merge it all together. Done, see https://salsa.debian.org/go-team/packages/golang-github-google-go-pkcs11/-/merge_requests/1 Kind regards, Maytham signature.asc Description: This is a digitally signed message part
Bug#1024311: Bug#1024276: #1024276: ITP: golang-github-googleapis-enterprise-certificate-proxy -- Google Proxies for
Hi Drew, > > I've got access to the Salsa repo, so are you ok with me pushing these > > changes > > to the repo? > > We've got a mechanism using debian/watch and debian/copyright to > automate removing third_party/pkcs11/* and creating the 0.*.0+dfsg > tarball. I suggest making a Merge Request with your fix so we can > review that, and then merge it all together. I've done precisely that, you can see the commit at [1]. You can find my work at [2]. I'd prefer to commit directly to the team repo rather than opening a merge request, as the commits include the new (repacked) upstream version. A MR will require the upstream branch and tag to be updated/added manually after merging, or another separate MR. Please have a look at my work and let me know if I can go ahead with pushing these changes to the team repo. [1]: https://salsa.debian.org/Maytha8/go-pkcs11/-/commit/3035f43e [2]: https://salsa.debian.org/Maytha8/go-pkcs11 Kind regards, Maytham signature.asc Description: This is a digitally signed message part
Bug#1024311: Bug#1024276: #1024276: ITP: golang-github-googleapis-enterprise-certificate-proxy -- Google Proxies for
On 2023-12-10 04:52, Maytham Alsudany wrote: Hi Drew, On Sat, 2023-12-09 at 11:24 +0100, Drew Parsons wrote: My mistake, I have go-pkcs11-dev installed locally, but it's the one holding up these upgrades. The golang-github-google-go-pkcs11-dev rejection message was: the OASIS IPR stuff is really weird, but at least this: (...)solely for the purpose of developing and promoting the OASIS Deliverable(...) already makes it non-free. I did a bit of research and found that golang-github-miekg-pkcs11 had the same problem with embedded OASIS Open code. What the maintainer has done is repack the source to remove the non-DFSG-compliant OASIS code and change the imports and (B-)Deps to use libnss instead, which provides the same functionality. I've locally cloned the Salsa repo for golang-github-google-go-pkcs11-dev, and made the following changes: * Bumped the version to 0.3.0 * Repacked it to remove third_party/pkcs11/* (0.3.0+dfsg) * Patched in the libnss imports (copying the miekg-pkcs11 package) * Patched the tests so they use their own ./syslog.tmp instead of the non- existent one at /var/log/syslog Thanks for that, Maytham, that will be very helpful I've got access to the Salsa repo, so are you ok with me pushing these changes to the repo? We've got a mechanism using debian/watch and debian/copyright to automate removing third_party/pkcs11/* and creating the 0.*.0+dfsg tarball. I suggest making a Merge Request with your fix so we can review that, and then merge it all together. Drew
Bug#1024311: Bug#1024276: #1024276: ITP: golang-github-googleapis-enterprise-certificate-proxy -- Google Proxies for
Hi Drew, On Sat, 2023-12-09 at 11:24 +0100, Drew Parsons wrote: > My mistake, I have go-pkcs11-dev installed locally, but it's the one > holding up these upgrades. > > The golang-github-google-go-pkcs11-dev rejection message was: > > the OASIS IPR stuff is really weird, but at least this: > (...)solely for the purpose of developing and promoting the OASIS > Deliverable(...) > > already makes it non-free. I did a bit of research and found that golang-github-miekg-pkcs11 had the same problem with embedded OASIS Open code. What the maintainer has done is repack the source to remove the non-DFSG-compliant OASIS code and change the imports and (B-)Deps to use libnss instead, which provides the same functionality. I've locally cloned the Salsa repo for golang-github-google-go-pkcs11-dev, and made the following changes: * Bumped the version to 0.3.0 * Repacked it to remove third_party/pkcs11/* (0.3.0+dfsg) * Patched in the libnss imports (copying the miekg-pkcs11 package) * Patched the tests so they use their own ./syslog.tmp instead of the non- existent one at /var/log/syslog I've got access to the Salsa repo, so are you ok with me pushing these changes to the repo? Kind regards, Maytham signature.asc Description: This is a digitally signed message part
