Bug#1042827: [Pkg-sssd-devel] priv-wrapper?
Simon Josefsson kirjoitti 3.8.2023 klo 22.55: Timo Aaltonen writes: I had a brief look at priv-wrapper packaging, and noticed it only keeps the debian/ dir in git? The sssd-team packages have the full upstream git as the base, with packaging added to the packaging branch. I prefer those will remain like that :) I usually also do the full git repo with upstream branch for most of the packages I maintain, but for this new package I wanted to see if keeping only debian/ in git worked, as I've had success with that in another package. What is really the upside of having upstream code in Debian's git? One downside is that it wastes space, although I don't think that matters a lot these days. Another downside is that it confuses what is really the "upstream" in case the Debian git-repo's view of what "upstream" is differs from the real upstream. How do you pull a new upstream release, download the tarball? I don't like working with upstream tarballs as the source of a new release, git is much nicer. And it allows using snapshots when needed etc. Just to clarify, did you mean that you would want priv-wrapper to use the same style as the other packages, or merely that I shouldn't change the other sssd-packages to use this debian/-only approach? I wouldn't do the latter. Generally if you feel there is any subjective style matter you don't agree with, I'm happy to follow what you prefer. I prefer to keep priv-wrapper as debian/-only if you think that is okay, unless I learn some disadvantage with it that I am not aware of yet. It's fine to have priv-wrapper as-is, no objections there. /Simon PS. Changing to your ubuntu.com email address since sending to your debian.org address results in bounces when debian.org forwards it to ubuntu.com because debian.org is not authorized to send emails on behalf of si...@josefsson.org due to (probably) my SPF 'mx -all' preference. I think it is a problem with the debian.org forwarder.. Yeah email sucks. I can't send to gmail addresses (with @debian.org) because of my smtp provider which has no DKIM.. -- t
Bug#1042827: [Pkg-sssd-devel] priv-wrapper?
Timo Aaltonen writes: > Simon Josefsson kirjoitti 1.8.2023 klo 18.46: >> Hi >> I have finished packaging cwrap's priv-wrapper: >> https://salsa.debian.org/jas/priv-wrapper/ >> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1042827 >> Would you be interested in co-maintaining priv-wrapper in the SSSD >> group? I noticed that SSSD maintains some of the other cwrap projects: >> https://tracker.debian.org/pkg/nss-wrapper >> https://tracker.debian.org/pkg/pam-wrapper >> https://tracker.debian.org/pkg/uid-wrapper >> I'm happy to maintain priv-wrapper in the sssd-group, and help >> improve >> packaging of other SSSD packages (e.g, upload new releases), if you >> grant me access to the Salsa gitlab group. >> /Simon > > Hi, > > That sounds fine. Great -- I'll move priv-wrapper once ftp-master has approved it, and then make a new upload using its new home. I'll review nss/pam/uid-wrapper next, I don't expect much changes, I'll upload to DELAYED to allow for review. > I had a brief look at priv-wrapper packaging, and noticed it only > keeps the debian/ dir in git? The sssd-team packages have the full > upstream git as the base, with packaging added to the packaging > branch. I prefer those will remain like that :) I usually also do the full git repo with upstream branch for most of the packages I maintain, but for this new package I wanted to see if keeping only debian/ in git worked, as I've had success with that in another package. What is really the upside of having upstream code in Debian's git? One downside is that it wastes space, although I don't think that matters a lot these days. Another downside is that it confuses what is really the "upstream" in case the Debian git-repo's view of what "upstream" is differs from the real upstream. Just to clarify, did you mean that you would want priv-wrapper to use the same style as the other packages, or merely that I shouldn't change the other sssd-packages to use this debian/-only approach? I wouldn't do the latter. Generally if you feel there is any subjective style matter you don't agree with, I'm happy to follow what you prefer. I prefer to keep priv-wrapper as debian/-only if you think that is okay, unless I learn some disadvantage with it that I am not aware of yet. /Simon PS. Changing to your ubuntu.com email address since sending to your debian.org address results in bounces when debian.org forwards it to ubuntu.com because debian.org is not authorized to send emails on behalf of si...@josefsson.org due to (probably) my SPF 'mx -all' preference. I think it is a problem with the debian.org forwarder.. signature.asc Description: PGP signature
Bug#1042827: [Pkg-sssd-devel] priv-wrapper?
Simon Josefsson kirjoitti 1.8.2023 klo 18.46: Hi I have finished packaging cwrap's priv-wrapper: https://salsa.debian.org/jas/priv-wrapper/ https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1042827 Would you be interested in co-maintaining priv-wrapper in the SSSD group? I noticed that SSSD maintains some of the other cwrap projects: https://tracker.debian.org/pkg/nss-wrapper https://tracker.debian.org/pkg/pam-wrapper https://tracker.debian.org/pkg/uid-wrapper I'm happy to maintain priv-wrapper in the sssd-group, and help improve packaging of other SSSD packages (e.g, upload new releases), if you grant me access to the Salsa gitlab group. /Simon Hi, That sounds fine. I had a brief look at priv-wrapper packaging, and noticed it only keeps the debian/ dir in git? The sssd-team packages have the full upstream git as the base, with packaging added to the packaging branch. I prefer those will remain like that :) -- t
