Bug#1055192: RFS: golang-github-apenella-go-ansible
On Sun, Dec 24, 2023 at 01:41:39PM +0530, Ananthu C V wrote: > It looks that this has been a clear oversight from my side. *I do find this a > very useful library* > but as you mentioned, since go team convention does not include packaging > libaries that are not > needed by any binaries, there is probably no real value in getting this in. It is not a go-team convention as such. In principle library packages can be packaged as well. However there is no utility in doing so. At the end of the day, a user only wants the necessary tools. The situation is quite different from python or javascript (where you work). In those teams, once you install python lib or a js lib, you can use it for your development w/o any extra hurdles. All imports/functionalities would work just fine. However, in go packages, you need to change the GOPATH/GOROOT to actually import and use those packages. This makes close to no sense for anyone to do, and simply using a go get is the most simple way. Adding in lib packages that effectively won't be used also calls for extra maintenance burden on the team so at least I find it sensible to add lib packages only when there's a use for them. > As such, please prune the corresponding repositories for the following: > - golang-github-apenella-go-ansible > - golang-github-apenella-go-common-utils > - golang-github-sosedoff-ansible-vault-go Pruned! > I feel sincerely sorry that an oversight from my side has ended up taking > some of your busy schedule > and I apologize for making you spend your time needlessly. I'll try my best > to make sure such mishapas > does not occur in the future, since it is not beneficial to anyone. And > regardless of the outcome of > this, thanks a lot for taking a look at the RFS. Don't worry about it, thanks for working on these regardless! Best, Nilesh signature.asc Description: PGP signature
Bug#1055192: RFS: golang-github-apenella-go-ansible
On Sat, Dec 23, 2023 at 10:35:08PM +0530, Nilesh Patra wrote: > I finally got some time to look at this. From what I see, this is just a > library > package (and no binary) and this seems to be the final package you want to > get uploaded. > > Generally, all go library packages 'are'/'should be' present in Debian > because they are needed > for a target (binary) package which a user is interested in using. No-one > would be keen > on apt installing golang libraries and fiddling with GOPATH/GOROOT > rather than a simpler `go get -u` if they want to use them to write code. > > Hence, unless you have any target packages for which these libs are needed, I > do not see > a lot of use of getting this in. Let me know what you'd think. I *do* expect > your reponse on this. It looks that this has been a clear oversight from my side. *I do find this a very useful library* but as you mentioned, since go team convention does not include packaging libaries that are not needed by any binaries, there is probably no real value in getting this in. As such, please prune the corresponding repositories for the following: - golang-github-apenella-go-ansible - golang-github-apenella-go-common-utils - golang-github-sosedoff-ansible-vault-go > Thanks! > > Best, > Nilesh I feel sincerely sorry that an oversight from my side has ended up taking some of your busy schedule and I apologize for making you spend your time needlessly. I'll try my best to make sure such mishapas does not occur in the future, since it is not beneficial to anyone. And regardless of the outcome of this, thanks a lot for taking a look at the RFS. Best, Ananthu
Bug#1055192: RFS: golang-github-apenella-go-ansible
I finally got some time to look at this. From what I see, this is just a library package (and no binary) and this seems to be the final package you want to get uploaded. Generally, all go library packages 'are'/'should be' present in Debian because they are needed for a target (binary) package which a user is interested in using. No-one would be keen on apt installing golang libraries and fiddling with GOPATH/GOROOT rather than a simpler `go get -u` if they want to use them to write code. Hence, unless you have any target packages for which these libs are needed, I do not see a lot of use of getting this in. Let me know what you'd think. I *do* expect your reponse on this. Thanks! Best, Nilesh signature.asc Description: PGP signature
Bug#1055192: RFS: golang-github-apenella-go-ansible
Hi Nilesh, I wouldn't put any blame on you at all, rather I appreciate it a lot that you are willing to upload it even when you are so busy. Please take your time :) Best, Ananthu On 21 December 2023 10:59:38 pm IST, Nilesh Patra wrote: >On Sat, Dec 16, 2023 at 01:49:18PM +0530, weepingclown wrote: >> Thanks a lot for this and I really appreciate it, especially considering it >> has been a while (~6weeks) since I've sent this RFS. >> [...] >> Now, I'd appreciate if there is someone who could sponsor this in the go >> team. That includes uploading the two dependencies of this; >> apenella-go-common-utils and sossedoff-vault-go. >> Hoping to find a sponsor this time. > >@weepingclown: Maybe I am the one to blame here, sorry about this. >Your mails did not hit my mailbox for whatever reason and I've been too >occupied with RL to have taken a look anytime soon. > >I'll upload these when I get some breathing space. Feel free to ping me in >about 2 >weeks if you see no activity on this. > >@Maytham: If I happened to miss commenting on any of your RFS request that's >already >sponsored, let me know. > >Best, >Nilesh
Bug#1055192: RFS: golang-github-apenella-go-ansible
On Sat, Dec 16, 2023 at 01:49:18PM +0530, weepingclown wrote: > Thanks a lot for this and I really appreciate it, especially considering it > has been a while (~6weeks) since I've sent this RFS. > [...] > Now, I'd appreciate if there is someone who could sponsor this in the go > team. That includes uploading the two dependencies of this; > apenella-go-common-utils and sossedoff-vault-go. > Hoping to find a sponsor this time. @weepingclown: Maybe I am the one to blame here, sorry about this. Your mails did not hit my mailbox for whatever reason and I've been too occupied with RL to have taken a look anytime soon. I'll upload these when I get some breathing space. Feel free to ping me in about 2 weeks if you see no activity on this. @Maytham: If I happened to miss commenting on any of your RFS request that's already sponsored, let me know. Best, Nilesh signature.asc Description: PGP signature
Bug#1055192: RFS: golang-github-apenella-go-ansible
Hi Maytham, Once again, thanks for the care, and what you mentioned once again made sense so I've implemented them after testing. While I feel bad at the fact that I've missed these more than once, in the process I also just solved something that had been bugging me. That said, I'd rather I haven't missed more things xD Thanks again :) Best, Ananthu On 18 December 2023 1:19:10 pm IST, Maytham Alsudany wrote: >Hi Ananthu, > >On Sat, 2023-12-16 at 16:07 +0530, weepingclown wrote: >> DH_GOLANG_EXCLUDES_ALL is true by default since DH_COMPAT 12 (according to >> the >> manual at least). I also confirmed that examples/ is not installed in >> /usr/share/gocode. Nonetheless, thank you for showing the care :) > >My mistake, I didn't notice that in the manual. :) > >Here's some more things I've found (in go-ansible): > > - golang-github-go-errors-errors-dev is only used in >pkg/vault/variableVaulter_test.go, should it be and removed from >Deps? > - golang-github-spf13-cobra-dev is only used in the examples (specifically >examples/ansibleplaybook-cobra-cmd/ansibleplaybook-cobra-cmd.go), should it >be removed from (B-)Deps? > >Kind regards, >Maytham
Bug#1055192: RFS: golang-github-apenella-go-ansible
Hi Ananthu, On Sat, 2023-12-16 at 16:07 +0530, weepingclown wrote: > DH_GOLANG_EXCLUDES_ALL is true by default since DH_COMPAT 12 (according to the > manual at least). I also confirmed that examples/ is not installed in > /usr/share/gocode. Nonetheless, thank you for showing the care :) My mistake, I didn't notice that in the manual. :) Here's some more things I've found (in go-ansible): - golang-github-go-errors-errors-dev is only used in pkg/vault/variableVaulter_test.go, should it be and removed from Deps? - golang-github-spf13-cobra-dev is only used in the examples (specifically examples/ansibleplaybook-cobra-cmd/ansibleplaybook-cobra-cmd.go), should it be removed from (B-)Deps? Kind regards, Maytham signature.asc Description: This is a digitally signed message part
Bug#1055192: RFS: golang-github-apenella-go-ansible
Hi Maytham, DH_GOLANG_EXCLUDES_ALL is true by default since DH_COMPAT 12 (according to the manual at least). I also confirmed that examples/ is not installed in /usr/share/gocode. Nonetheless, thank you for showing the care :) Best, Ananthu On 16 December 2023 3:32:01 pm IST, Maytham Alsudany wrote: >Hi Ananthu, > >> Thanks a lot for this and I really appreciate it > >Anytime! You'll probably want to also enable DH_GOLANG_EXCLUDES_ALL so that the >examples aren't installed in /usr/share/gocode, as the examples are not meant >to >be imported by other programs. (Refer to the man page.) > >Kind regards, >Maytham
Bug#1055192: RFS: golang-github-apenella-go-ansible
Hi Ananthu, > Thanks a lot for this and I really appreciate it Anytime! You'll probably want to also enable DH_GOLANG_EXCLUDES_ALL so that the examples aren't installed in /usr/share/gocode, as the examples are not meant to be imported by other programs. (Refer to the man page.) Kind regards, Maytham signature.asc Description: This is a digitally signed message part
Bug#1055192: RFS: golang-github-apenella-go-ansible
Hi Maytham, Thanks a lot for this and I really appreciate it, especially considering it has been a while (~6weeks) since I've sent this RFS. Thank you for DH_GOLANG_EXCLUDES, that was what I was looking for, but couldn't get any answers from anyone before. This also helped removing the DH_GOLANG_INSTALL_EXTRA in entirety. I found your other suggestions just as valid and reasonable, and have applied all of them. Thanks a lot for the review! Now, I'd appreciate if there is someone who could sponsor this in the go team. That includes uploading the two dependencies of this; apenella-go-common-utils and sossedoff-vault-go. Hoping to find a sponsor this time. Best, Ananthu On 16 December 2023 5:57:20 am IST, Maytham Alsudany wrote: >Hi weepingclown, > >I've had a look at your three packages, and everything you've done is perfect. > >Some feedback regarding apanella-go-ansible: > > * Formatting: inconsistent indenting in d/control's B-Deps field > > * Instead of removing usr/bin after dh_auto_install, I recommend you use >dh-golang's settings to do that instead. Have a look at the >Debian::Debhelper::Buildsystem::golang manpage, specifically >DH_GOLANG_EXCLUDES and DH_GOLANG_EXCLUDES_ALL env vars. > > * Is examples/ansibleplaybook-simple-embedfs/embedfs/ >necessary in DH_GOLANG_INSTALL_EXTRA? > > * You may want to rename d/examples to >d/golang-github-apanella-go-ansible-dev.examples > >I question the need for stretchr-testify in the Depends field, but if other >packages have it, then no worries. > >Kind regards >Maytham
Bug#1055192: RFS: golang-github-apenella-go-ansible
Hi weepingclown, I've had a look at your three packages, and everything you've done is perfect. Some feedback regarding apanella-go-ansible: * Formatting: inconsistent indenting in d/control's B-Deps field * Instead of removing usr/bin after dh_auto_install, I recommend you use dh-golang's settings to do that instead. Have a look at the Debian::Debhelper::Buildsystem::golang manpage, specifically DH_GOLANG_EXCLUDES and DH_GOLANG_EXCLUDES_ALL env vars. * Is examples/ansibleplaybook-simple-embedfs/embedfs/ necessary in DH_GOLANG_INSTALL_EXTRA? * You may want to rename d/examples to d/golang-github-apanella-go-ansible-dev.examples I question the need for stretchr-testify in the Depends field, but if other packages have it, then no worries. Kind regards Maytham signature.asc Description: This is a digitally signed message part
Bug#1055192: RFS: golang-github-apenella-go-ansible
Dear Go team, I am looking for a sponsor for the package "golang-github-apenella-go-ansible". I pushed to our team's Salsa: https://salsa.debian.org/go-team/packages/golang-github-apenella-go-ansible It currently has dependencies that are not uploaded yet, please see #1055195 and #1055196. I have previously sent RFS for both of them. Could you please review/sponsor these packages? Any kind of reviews and suggestions are appreciated. Thanks
