Bug#1059382: kitty: Text rendering change

2023-12-24 Thread Wesley Schwengle



Hi Nilesh

On 12/24/23 03:19, Nilesh Patra wrote:


Thanks for reporting it and taking the time to bisect it as well!


The issue is that on a dark background with light text everything is made bold,
whereas previously this was not bold. I think it is wise to inform users that
`text_composition_strategy legacy` restores the old defaults (similar to the
version in stable) and/or refer to the manual page:

https://sw.kovidgoyal.net/kitty/conf/#opt-kitty.text_composition_strategy

If kitty can read a system-wide config it might be set there.


It can, but honestly I don't want to diverge from upstream here. Everyone may 
not like the said change and enforcing a system wide config for a composition 
change isn't something that I'm willing to do.

If you could, please consider opening up an upstream issue to see if we can 
reach a common ground. If not, I'll just add a d/NEWS entry informing 
users/sysadmin about this change.


I'm fine with adding a d/NEWS entry, that is mainly the reason why I 
reported the bug. I think it's worth a mention because it confused me 
quite a bit :)


Cheers,
Wesley


--
Wesley Schwengle
E: wes...@schwengle.net



Bug#1059382: kitty: Text rendering change

2023-12-23 Thread Nilesh Patra



Hi Weasley,

On 24 December 2023 8:58:14 am IST, Wesley Schwengle  
wrote:
>Package: kitty
>Version: 0.31.0-3
>Severity: normal
>X-Debbugs-Cc: wes...@schwengle.net
>
>Dear Maintainer,
>
>On Debian stable version 0.26.5 of kitty is running, on testing/unstable this
>is 0.31.0. In 0.28.0 a change in text rendering is made by upstream, this is
>mentioned in the changelog.
>
>
>Text rendering change: Use sRGB correct linear gamma blending for nicer font
>rendering and better color accuracy with transparent windows. See the option
>text_composition_strategy for details. The obsolete macos_thicken_font will
>make the font too thick and needs to be removed manually if it is configured.
>(#5969)
>
>I didn't spot it and went in full bisect mode to figure out which commit caused
>it. I found it and could relate it to the Changelog entry.

Thanks for reporting it and taking the time to bisect it as well!

>The issue is that on a dark background with light text everything is made bold,
>whereas previously this was not bold. I think it is wise to inform users that
>`text_composition_strategy legacy` restores the old defaults (similar to the
>version in stable) and/or refer to the manual page:
>
>https://sw.kovidgoyal.net/kitty/conf/#opt-kitty.text_composition_strategy
>
>If kitty can read a system-wide config it might be set there.

It can, but honestly I don't want to diverge from upstream here. Everyone may 
not like the said change and enforcing a system wide config for a composition 
change isn't something that I'm willing to do.

If you could, please consider opening up an upstream issue to see if we can 
reach a common ground. If not, I'll just add a d/NEWS entry informing 
users/sysadmin about this change.

Thanks,
Nilesh



Bug#1059382: kitty: Text rendering change

2023-12-23 Thread Wesley Schwengle
Package: kitty
Version: 0.31.0-3
Severity: normal
X-Debbugs-Cc: wes...@schwengle.net

Dear Maintainer,

On Debian stable version 0.26.5 of kitty is running, on testing/unstable this
is 0.31.0. In 0.28.0 a change in text rendering is made by upstream, this is
mentioned in the changelog.


Text rendering change: Use sRGB correct linear gamma blending for nicer font
rendering and better color accuracy with transparent windows. See the option
text_composition_strategy for details. The obsolete macos_thicken_font will
make the font too thick and needs to be removed manually if it is configured.
(#5969)

I didn't spot it and went in full bisect mode to figure out which commit caused
it. I found it and could relate it to the Changelog entry.

The issue is that on a dark background with light text everything is made bold,
whereas previously this was not bold. I think it is wise to inform users that
`text_composition_strategy legacy` restores the old defaults (similar to the
version in stable) and/or refer to the manual page:

https://sw.kovidgoyal.net/kitty/conf/#opt-kitty.text_composition_strategy

If kitty can read a system-wide config it might be set there.

Cheers,
Wesley


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (900, 'unstable'), (500, 'experimental'), (500, 'testing'), (10, 
'stable-updates'), (10, 'stable-security'), (10, 'oldstable-security'), (10, 
'oldoldstable'), (10, 'stable'), (10, 'oldstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.6.8-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages kitty depends on:
ii  kitty-shell-integration  0.31.0-3
ii  kitty-terminfo   0.31.0-3
ii  libc62.37-13
ii  libdbus-1-3  1.14.10-3
ii  libharfbuzz0b8.0.1-1
ii  liblcms2-2   2.14-2
ii  libpng16-16  1.6.40-2
ii  libpython3.113.11.7-2
ii  libssl3  3.1.4-2
ii  libwayland-client0   1.22.0-2.1
ii  libx11-6 2:1.8.7-1
ii  libx11-xcb1  2:1.8.7-1
ii  libxcursor1  1:1.2.1-1
ii  libxkbcommon-x11-0   1.6.0-1
ii  libxkbcommon01.6.0-1
ii  libxxhash0   0.8.2-2
ii  python3  3.11.6-1
ii  python3.11   3.11.7-2
ii  zlib1g   1:1.3.dfsg-3

Versions of packages kitty recommends:
ii  kitty-doc 0.31.0-3
ii  libcanberra0  0.30-11

Versions of packages kitty suggests:
pn  imagemagick  

-- no debconf information