Bug#1066074: ntfs-3g: broken shlibs (deb and udeb)

2024-03-14 Thread Benjamin Drung
On Tue, 12 Mar 2024 02:12:16 +0100 Cyril Brulebois 
wrote:
> Source: ntfs-3g
> Version: 1:2022.10.3-1.1
> Severity: serious
> Tags: d-i
> Justification: broken shlibs
> X-Debbugs-Cc: debian-b...@lists.debian.org, Benjamin Drung

> 
> Hi,
> 
> Here's what debian/libntfs-3g89t64/DEBIAN/shlibs looks like after
> a build:
> 
> libntfs-3g 89 libntfs-3g89
> udeb: libntfs-3g 89 libntfs-3g89
> 
> That doesn't match binaries shipped by the source package.
> 
> 
> See debian/rules:
> 
> SONAME = $(shell objdump -p debian/tmp/lib/*/libntfs-3g.so.*.* |
awk -Fso. '/SONAME/ { print $$2 }')
> 
> […]
> 
> override_dh_makeshlibs:
> dh_makeshlibs --add-udeb=ntfs-3g-udeb -Vlibntfs-
3g$(SONAME)
> 
> 
> In the previous version we had:
> 
> libntfs-3g 89 libntfs-3g89
> udeb: libntfs-3g 89 ntfs-3g-udeb
> 
> Adding 't64' at the end of the dh_makeshlibs line quoted above gives:
> 
> libntfs-3g 89 libntfs-3g89t64
> udeb: libntfs-3g 89 ntfs-3g-udeb
> 
> which certainly looks much better. I haven't performed any rebuild
test
> for the reverse dependencies of the library, nor runtime tests on the
> d-i side (other packages are broken right now). The Depends field of
> the udeb looks correct now though:
> 
> -Depends: libc6-udeb (>= 2.37), libntfs-3g89, fuse3-udeb
> +Depends: libc6-udeb (>= 2.37), fuse3-udeb
> 
> 
> I'll leave it up to the 64-bit time_t transition drivers to choose how
> to address this issue (add t64 on the SONAME line, or just in the
> dh_makeshlibs override, or something else), and to track down packages
> that might have been rebuilt against the broken library.

Attached the diff for the NMU upload.

-- 
Benjamin Drung
Debian & Ubuntu Developer
diff -Nru ntfs-3g-2022.10.3/debian/changelog ntfs-3g-2022.10.3/debian/changelog
--- ntfs-3g-2022.10.3/debian/changelog	2024-03-01 13:40:22.0 +0100
+++ ntfs-3g-2022.10.3/debian/changelog	2024-03-14 13:21:45.0 +0100
@@ -1,3 +1,11 @@
+ntfs-3g (1:2022.10.3-1.2) unstable; urgency=medium
+
+  [ Zixing Liu ]
+  * Non-maintainer upload.
+  * d/rules: add t64 suffix to the dh_makeshlib command. (Closes: #1066074)
+
+ -- Benjamin Drung   Thu, 14 Mar 2024 13:21:45 +0100
+
 ntfs-3g (1:2022.10.3-1.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru ntfs-3g-2022.10.3/debian/rules ntfs-3g-2022.10.3/debian/rules
--- ntfs-3g-2022.10.3/debian/rules	2022-10-31 15:14:06.0 +0100
+++ ntfs-3g-2022.10.3/debian/rules	2024-03-14 13:21:09.0 +0100
@@ -105,7 +105,7 @@
 	dh_link --remaining-packages
 
 override_dh_makeshlibs:
-	dh_makeshlibs --add-udeb=ntfs-3g-udeb -Vlibntfs-3g$(SONAME)
+	dh_makeshlibs --add-udeb=ntfs-3g-udeb -Vlibntfs-3g$(SONAME)t64
 
 .PHONY: override_dh_auto_configure override_dh_auto_install \
 	override_dh_installchangelogs \


Bug#1066074: ntfs-3g: broken shlibs (deb and udeb)

2024-03-11 Thread Cyril Brulebois
Source: ntfs-3g
Version: 1:2022.10.3-1.1
Severity: serious
Tags: d-i
Justification: broken shlibs
X-Debbugs-Cc: debian-b...@lists.debian.org, Benjamin Drung 

Hi,

Here's what debian/libntfs-3g89t64/DEBIAN/shlibs looks like after
a build:

libntfs-3g 89 libntfs-3g89
udeb: libntfs-3g 89 libntfs-3g89

That doesn't match binaries shipped by the source package.


See debian/rules:

SONAME = $(shell objdump -p debian/tmp/lib/*/libntfs-3g.so.*.* | awk -Fso. 
'/SONAME/ { print $$2 }')

[…]

override_dh_makeshlibs:
dh_makeshlibs --add-udeb=ntfs-3g-udeb -Vlibntfs-3g$(SONAME)


In the previous version we had:

libntfs-3g 89 libntfs-3g89
udeb: libntfs-3g 89 ntfs-3g-udeb

Adding 't64' at the end of the dh_makeshlibs line quoted above gives:

libntfs-3g 89 libntfs-3g89t64
udeb: libntfs-3g 89 ntfs-3g-udeb

which certainly looks much better. I haven't performed any rebuild test
for the reverse dependencies of the library, nor runtime tests on the
d-i side (other packages are broken right now). The Depends field of
the udeb looks correct now though:

-Depends: libc6-udeb (>= 2.37), libntfs-3g89, fuse3-udeb
+Depends: libc6-udeb (>= 2.37), fuse3-udeb


I'll leave it up to the 64-bit time_t transition drivers to choose how
to address this issue (add t64 on the SONAME line, or just in the
dh_makeshlibs override, or something else), and to track down packages
that might have been rebuilt against the broken library.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant