Bug#1066239: gnome-system-tools: FTBFS: shares-tool.c:113:17: error: implicit declaration of function ‘table_add_share’ [-Werror=implicit-function-declaration]
Thank you very much for the patch. Applied it, it looks fine.
Bug#1066239: gnome-system-tools: FTBFS: shares-tool.c:113:17: error: implicit declaration of function ‘table_add_share’ [-Werror=implicit-function-declaration]
Package: gnome-system-tools Followup-For: Bug #1066239 User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu noble ubuntu-patch Control: tags -1 patch Dear Maintainer, Would it be possible tot consider the attached patch as a solution to this issue. In Ubuntu, the attached patch was applied to achieve the following: * d/p/implicit_declaration.patch: add missing declarations to resolve ftbfs (LP: #2060165). Thanks for considering the patch. -- System Information: Debian Release: trixie/sid APT prefers mantic-updates APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 'mantic'), (100, 'mantic-backports') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 6.5.0-26-generic (SMP w/32 CPU threads; PREEMPT) Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled diff -Nru gnome-system-tools-3.0.0/debian/patches/implicit_declaration.patch gnome-system-tools-3.0.0/debian/patches/implicit_declaration.patch --- gnome-system-tools-3.0.0/debian/patches/implicit_declaration.patch 1970-01-01 12:00:00.0 +1200 +++ gnome-system-tools-3.0.0/debian/patches/implicit_declaration.patch 2024-04-04 11:38:40.0 +1300 @@ -0,0 +1,29 @@ +Description: add missing declarations + Add missing headers and declarations to resolve -Werror=implicit-function-declaration. +Author: Vladimir Petko +Bug-Ubuntu: https://bugs.launchpad.net/debian/+source/gnome-system-tools/+bug/2060165 +Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066239 +Forwarded: no +Last-Update: 2024-04-04 + +--- a/src/shares/shares-tool.h b/src/shares/shares-tool.h +@@ -58,6 +58,7 @@ + }; + + GstSharesTool *gst_shares_tool_new (void); ++GType gst_shares_tool_get_type(); + + + G_END_DECLS +--- a/src/shares/shares-tool.c b/src/shares/shares-tool.c +@@ -23,6 +23,8 @@ + #include "users-table.h" + #include + #include "gst.h" ++#include "table.h" ++#include "share-settings.h" + + static void gst_shares_tool_class_init (GstSharesToolClass *class); + static void gst_shares_tool_init (GstSharesTool *tool); diff -Nru gnome-system-tools-3.0.0/debian/patches/series gnome-system-tools-3.0.0/debian/patches/series --- gnome-system-tools-3.0.0/debian/patches/series 2024-03-31 19:12:52.0 +1300 +++ gnome-system-tools-3.0.0/debian/patches/series 2024-04-04 11:38:40.0 +1300 @@ -23,3 +23,4 @@ max_group_name_32_chars.patch remove_g_thread_init.patch 70_gst-yelp.patch +implicit_declaration.patch
Bug#1066239: gnome-system-tools: FTBFS: shares-tool.c:113:17: error: implicit declaration of function ‘table_add_share’ [-Werror=implicit-function-declaration]
Source: gnome-system-tools Version: 3.0.0-9.1 Severity: serious Justification: FTBFS Tags: trixie sid ftbfs User: lu...@debian.org Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef Hi, During a rebuild of all packages in sid, your package failed to build on amd64. This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration Relevant part (hopefully): > gcc -DHAVE_CONFIG_H -I. -I../.. > -DPIXMAPS_DIR=\""/usr/share/gnome-system-tools/pixmaps"\" > -DINTERFACES_DIR=\""/usr/share/gnome-system-tools/ui"\" -DFRONTEND_DIR=\"""\" > -DDESKTOP_DATA_DIR=\"""\" -DCONF_DIR=\""/etc/gnome-system-tools"\" > -I../../src/common -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 > -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include > -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 > -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi > -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 > -I/usr/include/x86_64-linux-gnu -I/usr/include/webp > -I/usr/include/gio-unix-2.0 -I/usr/include/cloudproviders > -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 > -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 > -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -pthread > -I/usr/include/liboobs-1.0 -I/usr/include/polkit-1 -I/usr/include/glib-2.0 > -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/libmount > -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -pthread-Wdate-time > -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration > -ffile-prefix-map=/<>=. -fstack-protector-strong > -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection > -Wall -Wchar-subscripts -Wmissing-declarations -Wnested-externs > -Wpointer-arith -Wcast-align -Wsign-compare -Wformat-security -c -o > shares-tool.o shares-tool.c > In file included from /usr/include/liboobs-1.0/oobs/oobs.h:28, > from ../../src/common/gst-tool.h:30, > from shares-tool.h:27, > from shares-tool.c:22: > /usr/include/liboobs-1.0/oobs/oobs-session.h:79:13: warning: Deprecated > pre-processor symbol: replace with "const" >79 | G_CONST_RETURN gchar * oobs_session_get_authentication_action > (OobsSession *session); > | ^ > In file included from /usr/include/liboobs-1.0/oobs/oobs-user.h:40, > from /usr/include/liboobs-1.0/oobs/oobs-selfconfig.h:28, > from /usr/include/liboobs-1.0/oobs/oobs.h:31: > /usr/include/liboobs-1.0/oobs/oobs-group.h:58:13: warning: Deprecated > pre-processor symbol: replace with "const" >58 | G_CONST_RETURN gchar* oobs_group_get_name (OobsGroup *group); > | ^ > /usr/include/liboobs-1.0/oobs/oobs-user.h:84:13: warning: Deprecated > pre-processor symbol: replace with "const" >84 | G_CONST_RETURN gchar* oobs_user_get_login_name (OobsUser *user); > | ^~~~ > /usr/include/liboobs-1.0/oobs/oobs-user.h:94:13: warning: Deprecated > pre-processor symbol: replace with "const" >94 | G_CONST_RETURN gchar* oobs_user_get_home_directory (OobsUser *user); > | ^~~~ > /usr/include/liboobs-1.0/oobs/oobs-user.h:97:13: warning: Deprecated > pre-processor symbol: replace with "const" >97 | G_CONST_RETURN gchar* oobs_user_get_shell (OobsUser *user); > | ^~~ > /usr/include/liboobs-1.0/oobs/oobs-user.h:100:13: warning: Deprecated > pre-processor symbol: replace with "const" > 100 | G_CONST_RETURN gchar* oobs_user_get_full_name (OobsUser *user); > | ^~~ > /usr/include/liboobs-1.0/oobs/oobs-user.h:101:13: warning: Deprecated > pre-processor symbol: replace with "const" > 101 | G_CONST_RETURN gchar* oobs_user_get_full_name_fallback (OobsUser > *user); > | ^ > /usr/include/liboobs-1.0/oobs/oobs-user.h:104:13: warning: Deprecated > pre-processor symbol: replace with "const" > 104 | G_CONST_RETURN gchar* oobs_user_get_room_number (OobsUser *user); > | ^ > /usr/include/liboobs-1.0/oobs/oobs-user.h:107:13: warning: Deprecated > pre-processor symbol: replace with "const" > 107 | G_CONST_RETURN gchar* oobs_user_get_work_phone_number (OobsUser > *user); > | ^ > /usr/include/liboobs-1.0/oobs/oobs-user.h:110:13: warning:
