Bug#1066274: aa3d: FTBFS: aa3d.c:37:30: error: implicit declaration of function ‘strcmp’ [-Werror=implicit-function-declaration]

[Steve Langasek]

Package: aa3d
Version: 1.0-8.2
Followup-For: Bug #1066274
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Please find attached a fix for this bug.

This fix has been uploaded to Ubuntu.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru aa3d-1.0/debian/patches/no-implicit-declarations.patch 
aa3d-1.0/debian/patches/no-implicit-declarations.patch
--- aa3d-1.0/debian/patches/no-implicit-declarations.patch  1969-12-31 
16:00:00.0 -0800
+++ aa3d-1.0/debian/patches/no-implicit-declarations.patch  2024-04-09 
13:42:30.0 -0700
@@ -0,0 +1,18 @@
+Description: add missing string.h include
+Author: Steve Langasek 
+Bug-Debian: https://bugs.debian.org/1066274
+Last-Update: 2024-04-09
+Forwarded: no
+
+Index: aa3d-1.0/aa3d.c
+===
+--- aa3d-1.0.orig/aa3d.c
 aa3d-1.0/aa3d.c
+@@ -22,6 +22,7 @@
+  */
+ #include 
+ #include 
++#include 
+ static char data[65536 / 2];
+ int main(int argc, char **argv)
+ {
diff -Nru aa3d-1.0/debian/patches/series aa3d-1.0/debian/patches/series
--- aa3d-1.0/debian/patches/series  1969-12-31 16:00:00.0 -0800
+++ aa3d-1.0/debian/patches/series  2024-04-09 13:41:03.0 -0700
@@ -0,0 +1 @@
+no-implicit-declarations.patch

Bug#1066274: aa3d: FTBFS: aa3d.c:37:30: error: implicit declaration of function ‘strcmp’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: aa3d
Version: 1.0-8.2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> cc -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now  aa3d.c   -o aa3d
> aa3d.c: In function ‘main’:
> aa3d.c:37:30: error: implicit declaration of function ‘strcmp’ 
> [-Werror=implicit-function-declaration]
>37 | if (s < argc - 1 && !strcmp(argv[s], "-w"))
>   |  ^~
> aa3d.c:25:1: note: include ‘’ or provide a declaration of ‘strcmp’
>24 | #include 
>   +++ |+#include 
>25 | static char data[65536 / 2];
> aa3d.c:98:68: error: implicit declaration of function ‘strlen’ 
> [-Werror=implicit-function-declaration]
>98 | s = string == NULL ? letter : string[(x + shift) % 
> strlen(string)];
>   |
> ^~
> aa3d.c:98:68: note: include ‘’ or provide a declaration of ‘strlen’
> aa3d.c:98:68: warning: incompatible implicit declaration of built-in function 
> ‘strlen’ [-Wbuiltin-declaration-mismatch]
> aa3d.c:98:68: note: include ‘’ or provide a declaration of ‘strlen’
> cc1: some warnings being treated as errors
> make[1]: *** [: aa3d] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/aa3d_1.0-8.2_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na=ign=7=7=only=ftbfs-20240313=lu...@debian.org=1=1=1=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.