Bug#1066286: das-watchdog: FTBFS: test_rt.c:32:33: error: implicit declaration of function ‘getpid’ [-Werror=implicit-function-declaration]

[Steve Langasek]

Package: das-watchdog
Followup-For: Bug #1066286
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Please find attached a patch for this issue, which has been uploaded to
Ubuntu.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru das-watchdog-0.9.0/debian/patches/no-implicit-declarations.patch 
das-watchdog-0.9.0/debian/patches/no-implicit-declarations.patch
--- das-watchdog-0.9.0/debian/patches/no-implicit-declarations.patch
1969-12-31 16:00:00.0 -0800
+++ das-watchdog-0.9.0/debian/patches/no-implicit-declarations.patch
2024-04-09 16:13:22.0 -0700
@@ -0,0 +1,18 @@
+Description: add missing unistd.h include
+Author: Steve Langasek 
+Bug-Debian: https://bugs.debian.org/1066286
+Last-Update: 2024-04-09
+Forwarded: no
+
+Index: das-watchdog-0.9.0/test_rt.c
+===
+--- das-watchdog-0.9.0.orig/test_rt.c
 das-watchdog-0.9.0/test_rt.c
+@@ -4,6 +4,7 @@
+ #include 
+ #include 
+ #include 
++#include 
+ 
+ int main() {
+   struct sched_param params;
diff -Nru das-watchdog-0.9.0/debian/patches/series 
das-watchdog-0.9.0/debian/patches/series
--- das-watchdog-0.9.0/debian/patches/series2023-09-19 01:59:37.0 
-0700
+++ das-watchdog-0.9.0/debian/patches/series2024-04-09 16:11:24.0 
-0700
@@ -6,3 +6,4 @@
 0001-Remove-duplicate-check-for-temp-i-0.patch
 0003-The-result-of-fgetc-is-an-int-not-a-char.patch
 fix-memory-leak-on-realloc.patch
+no-implicit-declarations.patch

Bug#1066286: das-watchdog: FTBFS: test_rt.c:32:33: error: implicit declaration of function ‘getpid’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: das-watchdog
Version: 0.9.0-4
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -Wl,-z,relro -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wdate-time -D_FORTIFY_SOURCE=2 test_rt.c -o test_rt
> test_rt.c: In function ‘main’:
> test_rt.c:32:33: error: implicit declaration of function ‘getpid’ 
> [-Werror=implicit-function-declaration]
>32 | printf("My pid is %d\n",getpid());
>   | ^~
> test_rt.c:33:9: error: implicit declaration of function ‘sleep’ 
> [-Werror=implicit-function-declaration]
>33 | sleep(1);
>   | ^
> cc1: some warnings being treated as errors
> make[1]: *** [Makefile:14: all] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/das-watchdog_0.9.0-4_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na=ign=7=7=only=ftbfs-20240313=lu...@debian.org=1=1=1=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.