Bug#1066305: 3dchess: FTBFS: init.c:140:21: error: implicit declaration of function ‘time’ [-Werror=implicit-function-declaration]

2024-04-09 Thread Steve Langasek
Package: 3dchess
Version: 0.8.1-21
Followup-For: Bug #1066305
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Please find attached the fix for this bug, which has been uploaded to
Ubuntu.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru 3dchess-0.8.1/debian/patches/no-implicit-declarations.patch 
3dchess-0.8.1/debian/patches/no-implicit-declarations.patch
--- 3dchess-0.8.1/debian/patches/no-implicit-declarations.patch 1969-12-31 
16:00:00.0 -0800
+++ 3dchess-0.8.1/debian/patches/no-implicit-declarations.patch 2024-04-09 
13:23:33.0 -0700
@@ -0,0 +1,18 @@
+Description: fix missing declaration of time()
+Author: Steve Langasek 
+Bug-Debian: https://bugs.debian.org/1066305
+Last-Update: 2024-04-09
+Forwarded: no
+
+Index: 3dchess-0.8.1/src/init.c
+===
+--- 3dchess-0.8.1.orig/src/init.c
 3dchess-0.8.1/src/init.c
+@@ -29,6 +29,7 @@
+ #include 
+ #include 
+ #include 
++#include 
+ #include "../include/machine.h"
+ #include "../include/3Dc.h"
+ 
diff -Nru 3dchess-0.8.1/debian/patches/series 
3dchess-0.8.1/debian/patches/series
--- 3dchess-0.8.1/debian/patches/series 2022-03-26 18:33:58.0 -0700
+++ 3dchess-0.8.1/debian/patches/series 2024-04-09 13:22:34.0 -0700
@@ -4,3 +4,4 @@
 13_machine.h.patch
 hardening.patch
 wasteful-CPU-consumption.patch
+no-implicit-declarations.patch


Bug#1066305: 3dchess: FTBFS: init.c:140:21: error: implicit declaration of function ‘time’ [-Werror=implicit-function-declaration]

2024-03-13 Thread Lucas Nussbaum
Source: 3dchess
Version: 0.8.1-21
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc `dpkg-buildflags --get CFLAGS` -O2 -fstrength-reduce -fpcc-struct-return 
> -DVERSION=\"0.8.1\"  -DHAVE_UNISTD_H -DHAVE_ULIMIT_H -DUNDO_ANY_MOVE 
> -I../include -Wdate-time -D_FORTIFY_SOURCE=2  -c -o xnet.o xnet.c
> engine.c: In function ‘TraverseDir’:
> engine.c:82:43: warning: conversion from ‘unsigned int’ to ‘unsigned char:2’ 
> changes value from ‘4294967295’ to ‘3’ [-Woverflow]
>82 |   SQUARE_INVALID->xyzPos.zLevel = UINT_MAX;
>   |   ^~~~
> init.c: In function ‘Init3Dc’:
> init.c:140:21: error: implicit declaration of function ‘time’ 
> [-Werror=implicit-function-declaration]
>   140 |   srandom((unsigned)time(NULL));
>   | ^~~~
> init.c:34:1: note: ‘time’ is defined in header ‘’; did you forget to 
> ‘#include ’?
>33 | #include "../include/3Dc.h"
>   +++ |+#include 
>34 | 
> gcc `dpkg-buildflags --get CFLAGS` -O2 -fstrength-reduce -fpcc-struct-return 
> -DVERSION=\"0.8.1\"  -DHAVE_UNISTD_H -DHAVE_ULIMIT_H -DUNDO_ANY_MOVE 
> -I../include -Wdate-time -D_FORTIFY_SOURCE=2  -c -o callbaks.o callbaks.c
> gcc `dpkg-buildflags --get CFLAGS` -O2 -fstrength-reduce -fpcc-struct-return 
> -DVERSION=\"0.8.1\"  -DHAVE_UNISTD_H -DHAVE_ULIMIT_H -DUNDO_ANY_MOVE 
> -I../include -Wdate-time -D_FORTIFY_SOURCE=2  -c -o DrawingA.o DrawingA.c
> cc1: some warnings being treated as errors
> make[1]: *** [: init.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/3dchess_0.8.1-21_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na=ign=7=7=only=ftbfs-20240313=lu...@debian.org=1=1=1=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.