Bug#1066645: gtkterm: FTBFS: ../src/interface.c:738:9: error: implicit declaration of function ‘g_sprintf’; did you mean ‘g_snprintf’? [-Werror=implicit-function-declaration]

2024-04-10 Thread Willem van den Akker
Thanks,

Is already fixed upstream in 1.3. This will be released next week.

/Willem

On Tue, 2024-04-09 at 22:55 -0700, Steve Langasek wrote:
> Package: gtkterm
> Followup-For: Bug #1066645
> User: ubuntu-de...@lists.ubuntu.com
> Usertags: origin-ubuntu noble ubuntu-patch
> Control: tags -1 patch
> 
> Please find attached a patch for this issue which has been uploaded
> to
> Ubuntu.
> 



Bug#1066645: gtkterm: FTBFS: ../src/interface.c:738:9: error: implicit declaration of function ‘g_sprintf’; did you mean ‘g_snprintf’? [-Werror=implicit-function-declaration]

2024-04-09 Thread Steve Langasek
Package: gtkterm
Followup-For: Bug #1066645
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Please find attached a patch for this issue which has been uploaded to
Ubuntu.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru gtkterm-1.2.1/debian/patches/no-implicit-declarations.patch 
gtkterm-1.2.1/debian/patches/no-implicit-declarations.patch
--- gtkterm-1.2.1/debian/patches/no-implicit-declarations.patch 1969-12-31 
16:00:00.0 -0800
+++ gtkterm-1.2.1/debian/patches/no-implicit-declarations.patch 2024-04-09 
22:49:04.0 -0700
@@ -0,0 +1,28 @@
+Description: add missing includes
+Author: Steve Langasek 
+Bug-Debian: https://bugs.debian.org/1066645
+Last-Update: 2024-04-09
+Forwarded: no
+
+Index: gtkterm-1.2.1/src/interface.c
+===
+--- gtkterm-1.2.1.orig/src/interface.c
 gtkterm-1.2.1/src/interface.c
+@@ -79,6 +79,7 @@
+ #include "logging.h"
+ 
+ #include 
++#include 
+ #include 
+ 
+ guint id;
+Index: gtkterm-1.2.1/src/user_signals.c
+===
+--- gtkterm-1.2.1.orig/src/user_signals.c
 gtkterm-1.2.1/src/user_signals.c
+@@ -1,3 +1,5 @@
++#include 
++#include 
+ #include 
+ #include "interface.h"
+ 
diff -Nru gtkterm-1.2.1/debian/patches/series 
gtkterm-1.2.1/debian/patches/series
--- gtkterm-1.2.1/debian/patches/series 1969-12-31 16:00:00.0 -0800
+++ gtkterm-1.2.1/debian/patches/series 2024-04-09 22:48:12.0 -0700
@@ -0,0 +1 @@
+no-implicit-declarations.patch


Bug#1066645: gtkterm: FTBFS: ../src/interface.c:738:9: error: implicit declaration of function ‘g_sprintf’; did you mean ‘g_snprintf’? [-Werror=implicit-function-declaration]

2024-03-13 Thread Lucas Nussbaum
Source: gtkterm
Version: 1.2.1-1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> cc -Isrc/gtkterm.p -Isrc -I../src -I. -I.. -Idata -I/usr/include/gtk-3.0 
> -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 
> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/harfbuzz 
> -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libmount 
> -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo 
> -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 
> -I/usr/include/x86_64-linux-gnu -I/usr/include/webp 
> -I/usr/include/gio-unix-2.0 -I/usr/include/cloudproviders 
> -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 
> -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 
> -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/vte-2.91 
> -I/usr/include/gudev-1.0 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 
> -Wall -Winvalid-pch -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -MD -MQ src/gtkterm.p/interface.c.o 
> -MF src/gtkterm.p/interface.c.o.d -o src/gtkterm.p/interface.c.o -c 
> ../src/interface.c
> ../src/interface.c:154:9: warning: ‘GtkStock’ is deprecated 
> [-Wdeprecated-declarations]
>   154 | {"FileExit", GTK_STOCK_QUIT, NULL, "Q", NULL, 
> gtk_main_quit},
>   | ^
> ../src/interface.c:155:9: warning: ‘GtkStock’ is deprecated 
> [-Wdeprecated-declarations]
>   155 | {"ClearScreen", GTK_STOCK_CLEAR, N_("_Clear screen"), 
> "L", NULL, G_CALLBACK(clear_buffer)},
>   | ^
> ../src/interface.c:156:9: warning: ‘GtkStock’ is deprecated 
> [-Wdeprecated-declarations]
>   156 | {"ClearScrollback", GTK_STOCK_CLEAR, N_("_Clear scrollback"), 
> "K", NULL, G_CALLBACK(clear_scrollback)},
>   | ^
> ../src/interface.c:157:9: warning: ‘GtkStock’ is deprecated 
> [-Wdeprecated-declarations]
>   157 | {"SendFile", GTK_STOCK_JUMP_TO, N_("Send _RAW file"), 
> "R", NULL, G_CALLBACK(send_raw_file)},
>   | ^
> ../src/interface.c:158:9: warning: ‘GtkStock’ is deprecated 
> [-Wdeprecated-declarations]
>   158 | {"SaveFile", GTK_STOCK_SAVE_AS, N_("_Save RAW file"), "", 
> NULL, G_CALLBACK(save_raw_file)},
>   | ^
> ../src/interface.c:161:9: warning: ‘GtkStock’ is deprecated 
> [-Wdeprecated-declarations]
>   161 | {"EditCopy", GTK_STOCK_COPY, NULL, "C", NULL, 
> G_CALLBACK(edit_copy_callback)},
>   | ^
> ../src/interface.c:162:9: warning: ‘GtkStock’ is deprecated 
> [-Wdeprecated-declarations]
>   162 | {"EditPaste", GTK_STOCK_PASTE, NULL, "V", 
> NULL, G_CALLBACK(edit_paste_callback)},
>   | ^
> ../src/interface.c:163:9: warning: ‘GtkStock’ is deprecated 
> [-Wdeprecated-declarations]
>   163 | {"EditFind", GTK_STOCK_FIND, NULL, "F", NULL, 
> G_CALLBACK(edit_find_callback)},
>   | ^
> ../src/interface.c:164:9: warning: ‘GtkStock’ is deprecated 
> [-Wdeprecated-declarations]
>   164 | {"EditSelectAll", GTK_STOCK_SELECT_ALL, NULL, 
> "A", NULL, G_CALLBACK(edit_select_all_callback)},
>   | ^
> ../src/interface.c:167:9: warning: ‘GtkStock’ is deprecated 
> [-Wdeprecated-declarations]
>   167 | {"LogToFile", GTK_STOCK_MEDIA_RECORD, N_("To file..."), "", 
> NULL, G_CALLBACK(logging_start)},
>   | ^
> ../src/interface.c:168:9: warning: ‘GtkStock’ is deprecated 
> [-Wdeprecated-declarations]
>   168 | {"LogPauseResume", GTK_STOCK_MEDIA_PAUSE, NULL, "", NULL, 
> G_CALLBACK(logging_pause_resume)},
>   | ^
> ../src/interface.c:169:9: warning: ‘GtkStock’ is deprecated 
> [-Wdeprecated-declarations]
>   169 | {"LogStop", GTK_STOCK_MEDIA_STOP, NULL, "", NULL, 
> G_CALLBACK(logging_stop)},
>   | ^
> ../src/interface.c:170:9: warning: ‘GtkStock’ is deprecated 
> [-Wdeprecated-declarations]
>   170 | {"LogClear", GTK_STOCK_CLEAR, NULL, "", NULL, 
> G_CALLBACK(logging_clear)},
>   | ^
> ../src/interface.c:173:9: warning: ‘GtkStock’ is deprecated 
> [-Wdeprecated-declarations]
>   173 | {"ConfigPort", GTK_STOCK_PROPERTIES, N_("_Port"), 
> "S", NULL, G_CALLBACK(Config_Port_Fenetre)},
>   | ^
> ../src/interface.c:174:9: warning: ‘GtkStock’ is deprecated 
> [-Wdeprecated-declarations]
>   174 | {"ConfigTerminal", GTK_STOCK_PREFERENCES, N_("_Main window"), 
> "", NULL, G_CALLBACK(Config_Terminal)},
>   | ^
>