Bug#573636: diakonos fails to start
[ resending, last mail bounced because of my stupid local setup ]
Hi Ralph,
attached you can find *my* solution for the diakonos RC bug #573636.
It's pretty simple but YMMV as usual :)
I plan to upload it to DELAYED/10 tonight. 10 because I'm leaving for
a week tomorrow and won't be able to do anything if the upload breaks
something (which it shouldn't).
If you want me to upload it faster (because you have no time or
something)
just mail me.
Regards
Evgeni
--
Bruce Schneier can read and understand Perl programs.
diff -u diakonos-0.8.12/debian/changelog diakonos-0.8.12/debian/changelog
--- diakonos-0.8.12/debian/changelog
+++ diakonos-0.8.12/debian/changelog
@@ -1,3 +1,11 @@
+diakonos (0.8.12-1.1) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Depend on ruby1.9.1 and call it directly in the shebang.
+Closes: #573636
+
+ -- Evgeni Golov evg...@debian.org Fri, 19 Mar 2010 10:42:42 +0100
+
diakonos (0.8.12-1) unstable; urgency=medium
* new upstream version, see upstream changelog, amongst the upstream changes
diff -u diakonos-0.8.12/debian/control diakonos-0.8.12/debian/control
--- diakonos-0.8.12/debian/control
+++ diakonos-0.8.12/debian/control
@@ -11,7 +11,7 @@
Package: diakonos
Architecture: all
-Depends: ${misc:Depends}, ruby (=1.9.1)
+Depends: ${misc:Depends}, ruby1.9.1
Homepage: http://purepistos.net/diakonos/
Description: Customizable, usable console-based text editor
an editor made it with the intention of being easier to configure and use than
only in patch2:
unchanged:
--- diakonos-0.8.12.orig/bin/diakonos
+++ diakonos-0.8.12/bin/diakonos
@@ -1,4 +1,4 @@
-#!/usr/bin/env ruby
+#!/usr/bin/ruby1.9.1
require 'diakonos'
Bug#573636: diakonos fails to start
looks as though all work has been done, will rebuild and repost this evening or over the weekend. Thanks Nate Bargmann (bug report), Daiki Ueno (fix and work on patch), and Evgeni Golov. Ralph Amissah -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#573636: diakonos fails to start
Hi, On Tue, Mar 16, 2010 at 04:14:04PM +0700, Daiki Ueno wrote: Evgeni Golov evg...@debian.org writes: *However* I'd not use dpatch at all here. Maintainer already has direct changes to files in his .diff.gz (lib/diakonos.rb and lib/diakonos/help.rb) and I think forcing him to some patch system he is not (yet) using is the wrong way *here* (don't understand me wrong, I'm all for patch systems [even if I prefer quilt over dpatch] but here we are not the maintainer and should adapt his workflow). Yes, I used dpatch just to make it clear that the shebang change is Debian specific. I have no strong opinion on whether/which patch systems are used here. Yes, but the maintainer already has direct changes in his diff.gz, without a patch system. So I'd continue his workflow here and do it without a proper patch system. PS: if you want, i can upload the patch/NMU after you fixed the point(s) above :) Thanks, but not really for now. I also think that it would be definitely better for the bug to be fixed by the maintainer :-) It is better, for sure, but well, the bug is RC (diakonos is completely unuseable atm) and already 6 days old. I think I will upload a NMU to DELAYED/7 or so later today. Regards Evgeni -- Bruce Schneier can read and understand Perl programs. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#573636: diakonos fails to start
Hi, thanks for your patch. However I think it's slightly wrong. You are using dpatch without having dpatch as build-depend. When you have dpatch as b-d, why not use /usr/share/dpatch/dpatch.make and it's magic targets? Using build-stamp: patch-stamp clean: unpatch should be enough (you do not need to unclean before unpatching, because you are not patching any makefiles or smth involved in the clean process). *However* I'd not use dpatch at all here. Maintainer already has direct changes to files in his .diff.gz (lib/diakonos.rb and lib/diakonos/help.rb) and I think forcing him to some patch system he is not (yet) using is the wrong way *here* (don't understand me wrong, I'm all for patch systems [even if I prefer quilt over dpatch] but here we are not the maintainer and should adapt his workflow). Regards, Evgeni PS: if you want, i can upload the patch/NMU after you fixed the point(s) above :) -- Bruce Schneier can read and understand Perl programs. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#573636: diakonos fails to start
Evgeni Golov evg...@debian.org writes: You are using dpatch without having dpatch as build-depend. When you have dpatch as b-d, why not use /usr/share/dpatch/dpatch.make and it's magic targets? Ah, I didn't know that. Thanks for the tip. *However* I'd not use dpatch at all here. Maintainer already has direct changes to files in his .diff.gz (lib/diakonos.rb and lib/diakonos/help.rb) and I think forcing him to some patch system he is not (yet) using is the wrong way *here* (don't understand me wrong, I'm all for patch systems [even if I prefer quilt over dpatch] but here we are not the maintainer and should adapt his workflow). Yes, I used dpatch just to make it clear that the shebang change is Debian specific. I have no strong opinion on whether/which patch systems are used here. PS: if you want, i can upload the patch/NMU after you fixed the point(s) above :) Thanks, but not really for now. I also think that it would be definitely better for the bug to be fixed by the maintainer :-) Regards, -- Daiki Ueno -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#573636: diakonos fails to start
tags 573636 +patch
thanks
Hi,
Here is a patch following Evgeni's suggestion. I've confirmed that it
actually fixed the startup failure.
pgpupE07OmUcd.pgp
Description: PGP signature
diff -u diakonos-0.8.12/debian/changelog diakonos-0.8.12/debian/changelog
--- diakonos-0.8.12/debian/changelog
+++ diakonos-0.8.12/debian/changelog
@@ -1,3 +1,11 @@
+diakonos (0.8.12-1.1) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Depend on ruby1.9.1 and don't use #!/usr/bin/env ruby since diakonos
+only works with ruby1.9.1 (Closes: #573636).
+
+ -- Daiki Ueno u...@unixuser.org Tue, 16 Mar 2010 10:08:49 +0700
+
diakonos (0.8.12-1) unstable; urgency=medium
* new upstream version, see upstream changelog, amongst the upstream changes
diff -u diakonos-0.8.12/debian/control diakonos-0.8.12/debian/control
--- diakonos-0.8.12/debian/control
+++ diakonos-0.8.12/debian/control
@@ -11,7 +11,7 @@
Package: diakonos
Architecture: all
-Depends: ${misc:Depends}, ruby (=1.9.1)
+Depends: ${misc:Depends}, ruby1.9.1
Homepage: http://purepistos.net/diakonos/
Description: Customizable, usable console-based text editor
an editor made it with the intention of being easier to configure and use than
diff -u diakonos-0.8.12/debian/rules diakonos-0.8.12/debian/rules
--- diakonos-0.8.12/debian/rules
+++ diakonos-0.8.12/debian/rules
@@ -1,12 +1,22 @@
#!/usr/bin/make -f
#export DH_VERBOSE=1
-clean:
+clean: clean-patched unpatch
+clean-patched:
dh_testdir
dh_testroot
dh_clean
-build:
+build: patch
+
+patch: patch-stamp
+patch-stamp:
+ dpatch apply-all
+ dpatch cat-all patch-stamp
+
+unpatch:
+ dpatch deapply-all
+ rm -rf patch-stamp debian/patched
install:
only in patch2:
unchanged:
--- diakonos-0.8.12.orig/debian/patches/00list
+++ diakonos-0.8.12/debian/patches/00list
@@ -0,0 +1,2 @@
+01_no-env-shebang
+
only in patch2:
unchanged:
--- diakonos-0.8.12.orig/debian/patches/01_no-env-shebang.dpatch
+++ diakonos-0.8.12/debian/patches/01_no-env-shebang.dpatch
@@ -0,0 +1,16 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## 01_no-env-shebang.dpatch by Daiki Ueno u...@unixuser.org
+##
+## All lines beginning with `## DP:' are a description of the patch.
+## DP: don't use /usr/bin/env for shebang
+
+...@dpatch@
+
+--- diakonos-0.8.12/bin/diakonos~ 2010-03-16 10:35:49.0 +0700
diakonos-0.8.12/bin/diakonos 2010-03-16 10:36:03.0 +0700
+@@ -1,4 +1,4 @@
+-#!/usr/bin/env ruby
++#!/usr/bin/ruby1.9.1
+
+ require 'diakonos'
+
Sent from Thailand Mini-DebCamp 2010 BSP:
http://wiki.debian.org/DebianThailand/MiniDebCamp2010/BSP
Regards,
--
Daiki Ueno
Bug#573636: diakonos fails to start
Hi, just had a quick look at this bug. diakonos needs ruby1.9.1 (and installs it's files only for 1.9.1) but depends on ruby = 1.9.1 which pulls ruby1.8 per default and has unversioned ruby in the shebang. To solve this bug, one would need to 1. replace the dependency to ruby1.9.1 2. replace the shebang to ruby1.9.1 Regards Evgeni -- Bruce Schneier can read and understand Perl programs. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#573636: diakonos fails to start
Package: diakonos Version: 0.8.12-1 Severity: grave Justification: renders package unusable After installation of diakonos, attempting to open the program results in the following error: $ diakonos /usr/bin/diakonos:3:in `require': no such file to load -- diakonos (LoadError) from /usr/bin/diakonos:3 Even attempting to open with a filename on the command line fails. - Nate -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: i386 (i686) Kernel: Linux 2.6.32-3-686 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages diakonos depends on: ii ruby 4.2An interpreter of object-oriented diakonos recommends no packages. diakonos suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
