Bug#890877: gitlab: javascript locales not precompiled

2018-02-22 Thread Pirate Praveen
On ചൊവ്വ 20 ഫെബ്രുവരി 2018 02:29 വൈകു, Libor Klepáč wrote:
> Package: gitlab
> Version: 9.5.4+dfsg-5
> Severity: normal
> 
> Hello,
> it seems, that javascript locales are not precompiled before running webpack.
> Upstream changed to yarn based build system and fixed it here.
> https://gitlab.com/gitlab-org/gitlab-ce/commit/4c57d5ad188fe59e0c85798ccc4c81405652048c
> 
> You can run
> bundle exec rake gettext:po_to_json 
> 
> before webpack to fix it.
> Problem is, it needs to write to 
> /usr/share/gitlab/app/assets/javascripts/locale/
> So it must be set writeable by user gitlab or run as root.
> 
> Without this step, javascript is broken, it fails to load timeago.js, 
> screenshot in attachement

I have pushed a fix to git, but now it fails to install (possibly
unrelated to this change because I'm trying on a clean system now), so
not uploaded a new version yet.

I, [2018-02-22T18:19:13.958461 #7774]  INFO -- : Writing
/usr/share/gitlab/public/assets/print-87b4ace0db1f79d91e4fe6e74435b66b71d70fee57ffbb72d0fade17374fcc6b.css
I, [2018-02-22T18:19:13.959968 #7774]  INFO -- : Writing
/usr/share/gitlab/public/assets/print-87b4ace0db1f79d91e4fe6e74435b66b71d70fee57ffbb72d0fade17374fcc6b.css.gz
I, [2018-02-22T18:19:14.128913 #7774]  INFO -- : Writing
/usr/share/gitlab/public/assets/notify-abfe30822d82207505a29881cc27c46d0cf2f8bf68481bd421ba1ce23ca7c508.css
I, [2018-02-22T18:19:14.129177 #7774]  INFO -- : Writing
/usr/share/gitlab/public/assets/notify-abfe30822d82207505a29881cc27c46d0cf2f8bf68481bd421ba1ce23ca7c508.css.gz
I, [2018-02-22T18:19:14.850053 #7774]  INFO -- : Writing
/usr/share/gitlab/public/assets/katex-e46cafe9c3fa73920a7c2c063ee8bb0613e0cf85fd96a3aea25f8419c4bfcfba.css
I, [2018-02-22T18:19:14.850316 #7774]  INFO -- : Writing
/usr/share/gitlab/public/assets/katex-e46cafe9c3fa73920a7c2c063ee8bb0613e0cf85fd96a3aea25f8419c4bfcfba.css.gz
rake aborted!

ExecJS::ProgramError: TypeError: UglifyJS.Compressor is not a function
apply.source (eval at  ((execjs):4108:8), :23:35)
eval (eval at  ((execjs):4108:8), :63:2)
(execjs):4108:8
(execjs):4114:14
(execjs):1:102
Object. ((execjs):1:120)
Module._compile (module.js:635:30)
Object.Module._extensions..js (module.js:646:10)
Module.load (module.js:554:32)
tryModuleLoad (module.js:497:12)




signature.asc
Description: OpenPGP digital signature


Bug#890877: gitlab: javascript locales not precompiled

2018-02-20 Thread Libor Klepáč
Package: gitlab
Version: 9.5.4+dfsg-5
Severity: normal

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Hello,
it seems, that javascript locales are not precompiled before running webpack.
Upstream changed to yarn based build system and fixed it here.
https://gitlab.com/gitlab-org/gitlab-ce/commit/4c57d5ad188fe59e0c85798ccc4c81405652048c

You can run
bundle exec rake gettext:po_to_json 

before webpack to fix it.
Problem is, it needs to write to 
/usr/share/gitlab/app/assets/javascripts/locale/
So it must be set writeable by user gitlab or run as root.

Without this step, javascript is broken, it fails to load timeago.js, 
screenshot in attachement

Libor



-BEGIN PGP SIGNATURE-

iQJJBAEBCAAzFiEEPGZVVU37tFmB0TQv8O+MbsKfR44FAlqL43MVHGxpYm9yLmts
ZXBhY0BiY29tLmN6AAoJEPDvjG7Cn0eO+PkP/iMIuG5VD5Z7+zIDfCmU2oyeJ7EU
nQ3YG3l42mtF1sQZQF289X0ZXkokZKWF7x7QVgmiTbpPxp6e8/EV9y08lQePYuuC
0zTfbUT56ug0DSz8IIgSndHAUUSfag/KigNbnsIIlY8YzkQq+E0hjNSoxEmYnq3E
Sz4rZttqLmisdGgZa9pdPivCOtEdJsAgssSoWo8CP9WeIML3syC4PXc0cUCCjkN9
nAHl/T4W5nJVRNo4GMBTdzTViy900MnAFuJkse0HqoW3lMXZ9Dx418Q3sk946Epl
FSZWeYX5P0MJVt6/DFiHkotREeK5+sMccdlRRRHYUtcyBYyYdHBWA/a0xZj6a2uH
hTFhxO8rEE+7RfKSqbXnubgTAZ/jrSuF4j3srRKw62+ZP+ZMnQzDoGFmppkkPnL3
N34y5lwaPRkDZpNx1Ronb1O6dj+WnGv1HcHpYh3qCvBYvcQHX+ySDNNbDz4rin8V
Xxk8FB8QgVU0fmpl/vWbN/W7yWFFyivzWAZAnAaGRFvRAw017oZnNHEH7SgP58h4
KEDimLhKoYD3Q/mZ4W7MNQ4Ag7eLgqW+1lvpvIES+IWe5Okl6Hnb+/lRTapm7WnD
90PQdqEFFPTCDmwk/KCVSE+k0vwlfiQB70texHCnUjEe1hqhPAMaMIrJKug3381/
NO6Tk6V2SCX2Q0gg
=Ktyx
-END PGP SIGNATURE-