Bug#915236: ngspice FTBFS: dh_install: Cannot find "doc/*build_ngspice*.png"

2018-12-04 Thread Adrian Bunk
Control: retitle -1 ngspice FTBFS when not building in a path matching 
*build/ngspice*

On Tue, Dec 04, 2018 at 07:43:14AM +0100, Carsten Schoenert wrote:
> Control: severity -1 important
> Control: retile -1 ngspice: FTBR: dh_install: Cannot find 
> "doc/*build_ngspice*.png
> 
> Hello Adrian,

Hello Carsten,

> On Sun, Dec 02, 2018 at 01:05:56AM +0200, Adrian Bunk wrote:
> > Source: ngspice
> > Version: 29-1
> > Severity: serious
> > Tags: ftbfs
> > 
> > https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/ngspice.html
> > 
> > ...
> > dh_install
> > dh_install: Cannot find (any matches for) "doc/*build_ngspice*.png" (tried 
> > in ., debian/tmp)
> > 
> > dh_install: ngspice-doc missing files: doc/*build_ngspice*.png
> > dh_install: missing files, aborting
> > make[1]: *** [debian/rules:124: override_dh_install-indep] Error 25
> 
> as much I like your work in Debian I disagree on the used severity for
> this report.
> ngspice isn't failing on any buildd, *all* platforms Debian is currently
> supporting have build successfully the ngspice packages. So I really
> don't see a FTBFS!
> 
> I agree that ngspice isn't building reproducible for some reason. Policy
> is saying that a package SHOULD be buildable reproducible but not it
> MUST, so a report against a package due not buildable reproducible can't
> be RC. Because of this I've downgraded the severity to important.

this bug is not about the package not being reproducible.

> Without some debugging why the second build of ngspice in the
> reproducible build environment is failing it's unlikely to find the
> reason for the failing build. I don't have any reproducible build
> environment running, I wont find out something useful.
>...

It is the first build that failed in reproducible, and it also failed 
when I tried locally in a chroot before submitting this bug.

Looking at my failed build, there is an interesting cause of this FTBFS:

bunk@localhost:~/ngspice-29$ ls doc/*ngspice*
doc/26_home_bunk_ngspice-29_doc_Images_fft_windows.png
doc/27_home_bunk_ngspice-29_doc_Images_ng-win-out.png
doc/28_home_bunk_ngspice-29_doc_Images_ng-win-out-white.png
doc/29_home_bunk_ngspice-29_doc_Images_Example_Circuit_C1.png
doc/30_home_bunk_ngspice-29_doc_Images_C4.png
doc/31_home_bunk_ngspice-29_doc_Images_C5.png
doc/32_home_bunk_ngspice-29_doc_Images_vr2-trrandom.png
doc/33_home_bunk_ngspice-29_doc_Images_gnuplot-stat-an.png
doc/34_home_bunk_ngspice-29_doc_Images_optim-speed.png
doc/35_home_bunk_ngspice-29_doc_Images_XSPICE-Toplevel.png
doc/36_home_bunk_ngspice-29_doc_Images_Example_Circuit_1.png
doc/37_home_bunk_ngspice-29_doc_Images_Example_Circuit_2.png
doc/38_home_bunk_ngspice-29_doc_Images_Example_Circuit_C3.png
doc/39_home_bunk_ngspice-29_doc_Images_Filter-IO.png
doc/40_home_bunk_ngspice-29_doc_Images_Subc-filter.png
doc/41_home_bunk_ngspice-29_doc_Images_CIDER_Conc_profile1.png
doc/42_home_bunk_ngspice-29_doc_Images_CIDER_Conc_profile2.png
doc/43_home_bunk_ngspice-29_doc_Images_mesh-3a.png
bunk@localhost:~/ngspice-29$ 

The binary package contains the build path in the file names, and the 
build fails when your regex that matches when *build/ngspice* is part
of the build path fails.

> Regards
> Carsten

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed



Bug#915236: ngspice FTBFS: dh_install: Cannot find "doc/*build_ngspice*.png"

2018-12-03 Thread Carsten Schoenert
Control: severity -1 important
Control: retile -1 ngspice: FTBR: dh_install: Cannot find 
"doc/*build_ngspice*.png

Hello Adrian,

On Sun, Dec 02, 2018 at 01:05:56AM +0200, Adrian Bunk wrote:
> Source: ngspice
> Version: 29-1
> Severity: serious
> Tags: ftbfs
> 
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/ngspice.html
> 
> ...
> dh_install
> dh_install: Cannot find (any matches for) "doc/*build_ngspice*.png" (tried in 
> ., debian/tmp)
> 
> dh_install: ngspice-doc missing files: doc/*build_ngspice*.png
> dh_install: missing files, aborting
> make[1]: *** [debian/rules:124: override_dh_install-indep] Error 25

as much I like your work in Debian I disagree on the used severity for
this report.
ngspice isn't failing on any buildd, *all* platforms Debian is currently
supporting have build successfully the ngspice packages. So I really
don't see a FTBFS!

I agree that ngspice isn't building reproducible for some reason. Policy
is saying that a package SHOULD be buildable reproducible but not it
MUST, so a report against a package due not buildable reproducible can't
be RC. Because of this I've downgraded the severity to important.

Without some debugging why the second build of ngspice in the
reproducible build environment is failing it's unlikely to find the
reason for the failing build. I don't have any reproducible build
environment running, I wont find out something useful.
Instead I will try to make the ngspice manual source be better supported
by the autotool environment. This will need some talking to upstream
first.

Regards
Carsten



Bug#915236: ngspice FTBFS: dh_install: Cannot find "doc/*build_ngspice*.png"

2018-12-02 Thread Carsten Schoenert
Hello Juhani,

Am 02.12.18 um 10:45 schrieb Juhani Numminen:
> I can't reproduce the failure on my pbuilder setup, but the relevant
> part of debian/rules look suspicious because the semicolon ; rather
> than && is used when chaining shell commands. With semicolon, a
> failure to e.g. change directory can go unnoticed and lyx would
> be run in an unexpected dir. Not sure if that's the case here.

if the folder doc/ wouldn't exist make would also fail on this step, so
that's not the root for the bug report Adrian has created. For sure
something isn't working as expected but I don't see why is working with
sbuild and pbuilder and also on the first run of the reproducible setup
but not on the second.

Since version 29 (or was it also in 28) the documentation comes with the
files configure.ac and Makefile.am which are the base for configuring a
project by the autotools. Instead of doing some manual lyx calls to
create the documentation we should fix the current poor implementation
of the autotools files.

-- 
Regards
Carsten Schoenert



Bug#915236: ngspice FTBFS: dh_install: Cannot find "doc/*build_ngspice*.png"

2018-12-02 Thread Juhani Numminen
Dear Maintainer,

On Sun, 02 Dec 2018 01:05:56 +0200 Adrian Bunk  wrote:
> Source: ngspice
> Version: 29-1
> Severity: serious
> Tags: ftbfs
> 
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/ngspice.html
> 
> ...
> dh_install
> dh_install: Cannot find (any matches for) "doc/*build_ngspice*.png" (tried in 
> ., debian/tmp)
> 
> dh_install: ngspice-doc missing files: doc/*build_ngspice*.png
> dh_install: missing files, aborting
> make[1]: *** [debian/rules:124: override_dh_install-indep] Error 25

I can't reproduce the failure on my pbuilder setup, but the relevant
part of debian/rules look suspicious because the semicolon ; rather
than && is used when chaining shell commands. With semicolon, a
failure to e.g. change directory can go unnoticed and lyx would
be run in an unexpected dir. Not sure if that's the case here.

Please see the Merge Request on Salsa:
https://salsa.debian.org/electronics-team/ngspice/merge_requests/1

--
Juhani



Bug#915236: ngspice FTBFS: dh_install: Cannot find "doc/*build_ngspice*.png"

2018-12-01 Thread Adrian Bunk
Source: ngspice
Version: 29-1
Severity: serious
Tags: ftbfs

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/ngspice.html

...
dh_install
dh_install: Cannot find (any matches for) "doc/*build_ngspice*.png" (tried in 
., debian/tmp)

dh_install: ngspice-doc missing files: doc/*build_ngspice*.png
dh_install: missing files, aborting
make[1]: *** [debian/rules:124: override_dh_install-indep] Error 25