Bug#916178: roger-router-cli: missing dependency on cups

2020-01-24 Thread Gianfranco Costamagna
 control: tags -1 -wontfixcontrol: reassign -1 src:roger-router
>I'm not going to engage in reassign combat, but my understanding is that the
>following code from roger-router-cli.postinst _assumes_ that a local CUPS
>daemon is available (as no -h is specified):

you can do it, as said before, I wasn't really sure about the reassign either(I 
know such packages can have a working subset of functionalities and having an 
additional dependency is sometimes not the right thing to do!)

>if which lpadmin >/dev/null
>then
>    lpadmin -p "Roger-Router-Fax" -E -v roger-cups:/ -P 
>/usr/share/roger/roger-fax.ppd>
>fi>
> the postinst of roger-router-cli depends on a running, local, cups-daemon,
>it has to grow a dependency on the daemon itself, and cups-client will not
>grow that dependency.
>
>I'm tagging this bug as wontfix in CUPS, feel free to remove that tag when
>reassigning back to roger-router-cli.

thanks for the explanation!
I'm not an user of roger-router myself, I just tried to fix RC bugs, but I'll 
be happy to see an upload or to upload it if youhave a patch :)
otherwise, I think people will just need to install the cups dependency 
theirselves(or I can just add that dependency and live happy, but I have the 
feeling that the postinst/postrm can be tweaked to ignore the missing 
dependency?)
Gianfranco
  

Bug#916178: roger-router-cli: missing dependency on cups

2020-01-20 Thread Didier 'OdyX' Raboud
Control: -1 +wontfix 
# No change is going to happen in CUPS

Le lundi, 20 janvier 2020, 09.25:11 h CET Gianfranco Costamagna a écrit :
> On Mon, 10 Dec 2018 23:29:14 +0100 Marc Lehmann wrote:
> > Package: roger-router-cli
> > Version: 1.8.14-2+b3
> > Severity: serious
> > Justification: Policy 3.5
> > 
> > Dear Maintainer,
> > 
> > roger-router-cli apparently depends on cups-daemon, but has no required
> > dependency on it. if only cups-client is installed, installation fails
> > because the daemon is not running:
> > 
> > Setting up roger-router-cli (1.8.14-2+b3) ...
> > lpadmin: Unable to connect to server: Bad file descriptor
> > 
> > dpkg: error processing package roger-router-cli (--configure):
> >  subprocess installed post-installation script returned error exit status
> >  1
> > 
> > I *guess* the fix would be to make the dependency on cups optional in the
> > post-install script somehow.
> 
> I think, that if cups provides a client that doesn't work without the
> corresponding daemon, its a cups bug.
> 
> If they provide a cups-client containing binaries (e.g. lpadmin) that works
> only with cups-daemon installed, maybe they can think about adding that
> dependency, or split them into a new subpackage, or something else (like
> fail less badly).

Absolutely not, no, sorry.

cups-client software works fine against non-local CUPS servers (see lpadmin's
-h option), so adding a cups-client dependency against cups-daemon would
impose a server on client-only setup. Quite like if firefox would grow a
dependency on Apache2.

> Not sure, but I have the feeling that reassigning to cups team is the right
> choice to do.

I'm not going to engage in reassign combat, but my understanding is that the
following code from roger-router-cli.postinst _assumes_ that a local CUPS
daemon is available (as no -h is specified):

if which lpadmin >/dev/null
then
lpadmin -p "Roger-Router-Fax" -E -v roger-cups:/ -P 
/usr/share/roger/roger-fax.ppd
fi

(from 
https://salsa.debian.org/debian/roger-router/blob/master/debian/roger-router-cli.postinst#L17
 )

If the postinst of roger-router-cli depends on a running, local, cups-daemon,
it has to grow a dependency on the daemon itself, and cups-client will not
grow that dependency.

I'm tagging this bug as wontfix in CUPS, feel free to remove that tag when
reassigning back to roger-router-cli.

Cheers,
OdyX

signature.asc
Description: This is a digitally signed message part.


Bug#916178: roger-router-cli: missing dependency on cups

2020-01-20 Thread Gianfranco Costamagna
control: reassign -1 src:cups
control: found -1 2.3.1-1
control: affects -1 roger-router-cli
Hello Marc
On Mon, 10 Dec 2018 23:29:14 +0100 Marc Lehmann  
wrote:
> Package: roger-router-cli
> Version: 1.8.14-2+b3
> Severity: serious
> Justification: Policy 3.5
> 
> Dear Maintainer,
> 
> roger-router-cli apparently depends on cups-daemon, but has no required
> dependency on it. if only cups-client is installed, installation fails
> because the daemon is not running:
> 
> Setting up roger-router-cli (1.8.14-2+b3) ...
> lpadmin: Unable to connect to server: Bad file descriptor
> dpkg: error processing package roger-router-cli (--configure):
>  subprocess installed post-installation script returned error exit status 1
> 
> I *guess* the fix would be to make the dependency on cups optional in the
> post-install script somehow.
> 


I think, that if cups provides a client that doesn't work without the 
corresponding daemon, its a cups bug.

If they provide a cups-client containing binaries (e.g. lpadmin) that works 
only with cups-daemon installed,
maybe they can think about adding that dependency, or split them into a new 
subpackage, or something else
(like fail less badly).

Not sure, but I have the feeling that reassigning to cups team is the right 
choice to do.

thanks

Gianfranco



Bug#916178: roger-router-cli: missing dependency on cups

2018-12-10 Thread Marc Lehmann
Package: roger-router-cli
Version: 1.8.14-2+b3
Severity: serious
Justification: Policy 3.5

Dear Maintainer,

roger-router-cli apparently depends on cups-daemon, but has no required
dependency on it. if only cups-client is installed, installation fails
because the daemon is not running:

Setting up roger-router-cli (1.8.14-2+b3) ...
lpadmin: Unable to connect to server: Bad file descriptor
dpkg: error processing package roger-router-cli (--configure):
 subprocess installed post-installation script returned error exit status 1

I *guess* the fix would be to make the dependency on cups optional in the
post-install script somehow.

-- System Information:
Debian Release: 9.6
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'unstable-debug'), (500, 'testing-debug'), 
(500, 'stable-updates'), (500, 'stable-debug'), (500, 'unstable'), (500, 
'testing'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, x32

Kernel: Linux 4.18.20-041820-generic (SMP w/8 CPU cores)
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=C (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/bash
Init: systemd (via /run/systemd/system)

Versions of packages roger-router-cli depends on:
ii  libasound2  1.1.3-5
ii  libatk1.0-0 2.30.0-1
ii  libc6   2.27-8
ii  libcairo-gobject2   1.16.0-1
ii  libcairo2   1.16.0-1
ii  libgdk-pixbuf2.0-0  2.36.5-2+deb9u2
ii  libgirepository-1.0-1   1.50.0-1+b1
ii  libglib2.0-02.58.1-2
ii  libgssdp-1.0-3  1.0.1-1
ii  libgstreamer-plugins-base1.0-0  1.10.4-1
ii  libgstreamer1.0-0   1.10.4-1
ii  libgtk-3-0  3.24.1-2
ii  libgupnp-1.0-4  1.0.1-1
ii  libpango-1.0-0  1.42.4-4
ii  libpangocairo-1.0-0 1.42.4-4
ii  libpeas-1.0-0   1.20.0-1+b1
ii  libportaudio2   19.6.0-1
ii  libpulse0   10.0-1+deb9u1
ii  libroutermanager0   1.8.14-2+b3
ii  libsecret-1-0   0.18.5-3.1
ii  libsndfile1 1.0.27-3
ii  libsoup2.4-12.64.2-1
ii  libspeex1   1.2~rc1.2-1+b2
ii  libspeexdsp11.2~rc1.2-1+b2
ii  libtiff54.0.8-2+deb9u4
ii  libxml2 2.9.4+dfsg1-2.2+deb9u2

Versions of packages roger-router-cli recommends:
ii  cups-client  2.2.1-8+deb9u2
pn  cups-daemon  
ii  ghostscript  9.26~dfsg-0+deb9u1

roger-router-cli suggests no packages.

-- no debconf information