Bug#951507: wine: please fix arm64 build failure with some gcc versions

2020-02-17 Thread Michael Gilbert
control: retitle -1 wine: fails to build with clang 9 on arm64

On Mon, Feb 17, 2020 at 10:54 AM Gianfranco Costamagna wrote:
> Hello, looks like wine is still failing on Ubuntu arm64, probably because of 
> new gcc or new glibc, or a combo of them both...

The difference is that clang 9 is ubuntu's default and debian's
default is clang 8.

Best wishes,
Mike



Bug#951507: wine: please fix arm64 build failure with some gcc versions

2020-02-17 Thread Gianfranco Costamagna
Source: wine
version: 5.0-2
Severity: normal
Tags: patch


Hello, looks like wine is still failing on Ubuntu arm64, probably because of 
new gcc or new glibc, or a combo of them both...

https://launchpadlibrarian.net/465353257/buildlog_ubuntu-focal-arm64.wine_5.0-2_BUILDING.txt.gz

fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body 
-Wignored-qualifiers -Wno-pragma-pack -Wstrict-prototypes -Wtype-limits -Wvla 
-Wwrite-strings -Wpointer-arith -gdwarf-2 -gstrict-dwarf -Werror -Wdate-time -g 
-O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat 
-Werror=format-security -fcommon -Wno-shift-overflow -Wno-unused-function 
-Wno-deprecated-declarations -Wno-enum-conversion -Wno-absolute-value
../d3dx9_36/effect.c:1472:12: error: result of comparison of unsigned enum 
expression < 0 is always false 
[-Werror,-Wtautological-unsigned-enum-zero-compare]
if (op < 0 || op > SCT_PSINT)
~~ ^ ~
looks like the following trivial patch is enough to make it compile correctly
http://launchpadlibrarian.net/465353550/wine_5.0-2_5.0-2ubuntu1.diff.gz
(we could also export -Wno-tautological-unsigned-enum-zero-compare to fix it 
but the bug seems real)

thanks for considering it!

Gianfranco