Bug#402331: Agree with Steve Langasek's analysis.

2006-12-17 Thread Alex Owen

As others have said there is no need to compile the source when
building a source as binary package. Hence there is no need to have
depandancies on specific users when building the qmail-src deb from
the qmail source deb.

There are two ways of solving this...
[1] the same way as pine by only having a source deb in the archive.
(The difference here is that we would need to build depend on a
trivial package which adds the required users in it's postinst)

[2] (and more like the package presently tries) the same way as kernel
module packages.
Here we tar up a debianised source tree into a binary deb with a
postinst that adds the required users. For insperation look at some
kernel module source packages... eg: qla2x00 from sarge. From memory a
different debian/rules is copied into the  debianised source tree
which ends up in the binary than exists in the source.

Currently the issue seems to be that the qmail source deb really wants
to build the qmail deb directly and the qmail-src debv seems to have
been hacked in to debian/rules. It also seems that the  SAME
debian/rules is used  BOTH the qmail-src deb and the qmail deb. This
is in my opinion asking for trouble. See earlier comment about looking
a kernel-module source packages for insparation.

I hope this analysis helps!?!
Alex Owen


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#402331: Agree with Steve Langasek's analysis.

2006-12-17 Thread Jon Marler
Quoting Alex Owen [EMAIL PROTECTED]:

 As others have said there is no need to compile the source when
 building a source as binary package. Hence there is no need to have
 depandancies on specific users when building the qmail-src deb from
 the qmail source deb.

 There are two ways of solving this...
 [1] the same way as pine by only having a source deb in the archive.
 (The difference here is that we would need to build depend on a
 trivial package which adds the required users in it's postinst)

 [2] (and more like the package presently tries) the same way as kernel
 module packages.
 Here we tar up a debianised source tree into a binary deb with a
 postinst that adds the required users. For insperation look at some
 kernel module source packages... eg: qla2x00 from sarge. From memory a
 different debian/rules is copied into the  debianised source tree
 which ends up in the binary than exists in the source.

 Currently the issue seems to be that the qmail source deb really wants
 to build the qmail deb directly and the qmail-src debv seems to have
 been hacked in to debian/rules. It also seems that the  SAME
 debian/rules is used  BOTH the qmail-src deb and the qmail deb. This
 is in my opinion asking for trouble. See earlier comment about looking
 a kernel-module source packages for insparation.

 I hope this analysis helps!?!
 Alex Owen

I worked up a possible fix for the problem, and sent it to Steve, but he hasn't
tried it yet.

I don't have a system that replicates the behavior, so it always works for me.

I believe I found the offending single line of code, and made an updated
package.  It looks like you're analysis was spot-on.  The debian/rules file
would build the qmail package in tandem with the -src package.  A one-line fix
in the debain/rules file makes that unwanted behavior stop.

If I don't hear back from Steve in a day or two, I'll just upload it and he can
re-open the bug if it isn't fixed.

Cheers!

Jon




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]