Bug#571027: Patch for this file conflict bug...

2010-03-19 Thread Jonathan Nieder
Christian PERRIER wrote:

 This bug will only appear on lenny-sid upgrades because the version in
 lenny is 2.86.ds1-61, that has the offending manpage. It was removed
 later on in sysv-rc package development. Beware the sysv-rc
 maintainers disabled the inclusion of the manpage, but only
 temporarily, so that problem might pop up again later non.
 
 I think this can be fixed with a Breaks statement, that will force
 sysv-rc to be updated prior to the update of manpages-fr-extra.

I worry that that is not completely robust: a Breaks would would
force sysv-rc to be updated prior to configuring the updated
manpages-fr-extra, but it doesn’t enforce the appropriate unpacking
order when upgrading with dpkg.

I think a Replaces should be good enough.  After all, this doesn’t
actually break the old sysv-rc version.

Would something like this work?  Using unversioned Replaces like
this is only appropriate if we know that sysv-rc should not overwrite
any files from manpages-fr-extra in squeeze or squeeze+1.  I suspect
we do know that.

Jonathan
Index: debian/control
===
--- debian/control  (revision 2102)
+++ debian/control  (working copy)
@@ -14,6 +14,7 @@
 Priority: optional
 Replaces: manpages-fr ( 2.33.2-1), belocs-locales-bin ( 2.4-3)
 Recommends: manpages-fr
+Replaces: sysv-rc
 Suggests: man-db | man-browser, manpages-fr-dev
 Description: French version of the manual pages
  French translation of manual pages found in manpages and manpages-dev
Index: debian/changelog
===
--- debian/changelog(revision 2102)
+++ debian/changelog(working copy)
@@ -9,6 +9,11 @@
   [ Simon Paillard ]
   * Fix [2-9]ème in [2-9]e
 
+  [ Christian Perrier ]
+  * Add Replaces: sysv-rc to allow safe upgrades from lenny as
+sysv-rc is providing /usr/share/man/fr/man8/update-rc.d.8.gz
+Closes: #571027
+
  -- Nicolas FRANCOIS (Nekral) nicolas.franc...@centraliens.net  Fri, 22 Jan 
2010 23:30:57 +0100
 
 manpages-fr-extra (20090906) unstable; urgency=low


Bug#571027: Patch for this file conflict bug...

2010-03-19 Thread Nicolas François
Hello,

On Fri, Mar 19, 2010 at 05:54:56AM -0500, jrnie...@gmail.com wrote:
 
 I think a Replaces should be good enough.  After all, this doesn’t
 actually break the old sysv-rc version.
 
 Would something like this work?  Using unversioned Replaces like
 this is only appropriate if we know that sysv-rc should not overwrite
 any files from manpages-fr-extra in squeeze or squeeze+1.  I suspect
 we do know that.

Yes, it should be a Replace, but a versionned one would be better as the
best solution would be to have the manpages distributed in the sysv-rc
package.

-- 
Nekral



--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#571027: Patch for this file conflict bug...

2010-03-19 Thread Christian PERRIER
Quoting Jonathan Nieder (jrnie...@gmail.com):

  I think this can be fixed with a Breaks statement, that will force
  sysv-rc to be updated prior to the update of manpages-fr-extra.
 
 I worry that that is not completely robust: a Breaks would would
 force sysv-rc to be updated prior to configuring the updated
 manpages-fr-extra, but it doesn’t enforce the appropriate unpacking
 order when upgrading with dpkg.

Ah, right.

 I think a Replaces should be good enough.  After all, this doesn’t
 actually break the old sysv-rc version.

I was balanced about these choices and they show the limits of my
knowledge, sometimes, when it comes at package dependencies.

Does this guarantee that, after the update, sysv-rc will still be on
the system?

 Would something like this work?  Using unversioned Replaces like
 this is only appropriate if we know that sysv-rc should not overwrite
 any files from manpages-fr-extra in squeeze or squeeze+1.  I suspect
 we do know that.


Sure. The said manpage was the only one causing this problem.



signature.asc
Description: Digital signature


Bug#571027: Patch for this file conflict bug...

2010-03-19 Thread Jonathan Nieder
Nicolas François wrote:
 On Fri, Mar 19, 2010 at 05:54:56AM -0500, jrnie...@gmail.com wrote:

 Using unversioned Replaces like
 this is only appropriate if we know that sysv-rc should not overwrite
 any files from manpages-fr-extra in squeeze or squeeze+1.  I suspect
 we do know that.

 Yes, it should be a Replace, but a versionned one would be better as the
 best solution would be to have the manpages distributed in the sysv-rc
 package.

So exactly the opposite of my suspicion was true!  Makes sense; I should
have thought about it more.  Here’s an updated patch.
Index: debian/control
===
--- debian/control  (revision 2102)
+++ debian/control  (working copy)
@@ -12,7 +12,8 @@
 Architecture: all
 Section: doc
 Priority: optional
-Replaces: manpages-fr ( 2.33.2-1), belocs-locales-bin ( 2.4-3)
+Replaces: manpages-fr ( 2.33.2-1), belocs-locales-bin ( 2.4-3),
+   sysv-rc ( 2.87dsf-3)
 Recommends: manpages-fr
 Suggests: man-db | man-browser, manpages-fr-dev
 Description: French version of the manual pages
Index: debian/changelog
===
--- debian/changelog(revision 2102)
+++ debian/changelog(working copy)
@@ -9,6 +9,11 @@
   [ Simon Paillard ]
   * Fix [2-9]ème in [2-9]e
 
+  [ Christian Perrier ]
+  * Add Replaces: sysv-rc ( 2.87dsf-3) to allow safe upgrades from
+lenny as sysv-rc is providing /usr/share/man/fr/man8/update-rc.d.8.gz
+Closes: #571027
+
  -- Nicolas FRANCOIS (Nekral) nicolas.franc...@centraliens.net  Fri, 22 Jan 
2010 23:30:57 +0100
 
 manpages-fr-extra (20090906) unstable; urgency=low


Bug#571027: Patch for this file conflict bug...

2010-03-19 Thread Jonathan Nieder
Christian PERRIER wrote:
 Quoting Jonathan Nieder (jrnie...@gmail.com):

 I think a Replaces should be good enough.  After all, this doesn’t
 actually break the old sysv-rc version.

 I was balanced about these choices and they show the limits of my
 knowledge, sometimes, when it comes at package dependencies.
 
 Does this guarantee that, after the update, sysv-rc will still be on
 the system?

Yes, the only thing it does is to allow manpages-fr-extra to take over
files from sysv-rc.

There is a downside: if someone installs sysv-rc/lenny with
manpages-fr-extra/squeeze and then uninstalls or downgrades
manpages-fr-extra, then the update-rc.d manpage goes missing until
manpages-fr-extra is reinstalled.  Once can prevent this by forcing a
sysv-rc upgrade (at least for apt users) using Breaks in addition to the
Replaces.  That might be a good idea, too.

See http://bugs.debian.org/557929 for a more serious example of this
consideration.

À plus,
Jonathan



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#571027: Patch for this file conflict bug...

2010-03-19 Thread Jonathan Nieder
Jonathan Nieder wrote:

 There is a downside: if someone installs sysv-rc/lenny with
 manpages-fr-extra/squeeze and then uninstalls or downgrades
 manpages-fr-extra, then the update-rc.d manpage goes missing until
 manpages-fr-extra is reinstalled.  Once can prevent this by forcing a
  upgraded or ^One ^

Sorry for the confusion.  I’m off to sleep.

Thank you for your dedication, both.  It is impressive to see.
Jonathan



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#571027: Patch for this file conflict bug...

2010-03-16 Thread Christian PERRIER
tags 571027 patch
thanks

This bug will only appear on lenny-sid upgrades because the version in
lenny is 2.86.ds1-61, that has the offending manpage. It was removed
later on in sysv-rc package development. Beware the sysv-rc
maintainers disabled the inclusion of the manpage, but only
temporarily, so that problem might pop up again later non.

I think this can be fixed with a Breaks statement, that will force
sysv-rc to be updated prior to the update of manpages-fr-extra.

-- 



diff -Nru manpages-fr-extra-20090906.old/debian/changelog 
manpages-fr-extra-20090906+nmu1/debian/changelog
--- manpages-fr-extra-20090906.old/debian/changelog 2010-03-16 
11:25:12.0 +0100
+++ manpages-fr-extra-20090906+nmu1/debian/changelog2010-03-16 
11:48:12.0 +0100
@@ -1,3 +1,13 @@
+manpages-fr-extra (20090906+nmu1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Add Breaks: sysv-rc ( 2.87dsf-3) to allow safe upgrades from
+lenny as sysv-rc is providing
+/usr/share/man/fr/man8/update-rc.d.8.gz
+Closes: #571027
+
+ -- Christian Perrier bubu...@debian.org  Tue, 16 Mar 2010 11:48:08 +0100
+
 manpages-fr-extra (20090906) unstable; urgency=low
 
   [ Nicolas FRANCOIS ]
diff -Nru manpages-fr-extra-20090906.old/debian/control 
manpages-fr-extra-20090906+nmu1/debian/control
--- manpages-fr-extra-20090906.old/debian/control   2010-03-16 
11:25:12.0 +0100
+++ manpages-fr-extra-20090906+nmu1/debian/control  2010-03-16 
11:46:43.0 +0100
@@ -14,6 +14,7 @@
 Priority: optional
 Replaces: manpages-fr ( 2.33.2-1), belocs-locales-bin ( 2.4-3)
 Recommends: manpages-fr
+Breaks: sysv-rc ( 2.87dsf-3)
 Suggests: man-db | man-browser, manpages-fr-dev
 Description: French version of the manual pages
  French translation of manual pages found in manpages and manpages-dev


signature.asc
Description: Digital signature