Bug#695268: liblockfile1: harmful remove action in M-A:same package

2012-12-11 Thread AnĂ­bal Monsalve Salazar
On Sun, Dec 09, 2012 at 05:55:20PM -0600, Rob Browning wrote:
I suspect this may be a reasonable fix:

Thank you.

Please see http://bugs.debian.org/695655


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#695268: liblockfile1: harmful remove action in M-A:same package

2012-12-09 Thread Rob Browning

I suspect this may be a reasonable fix:

diff --git a/debian/changelog b/debian/changelog
index 0b3a119..d000449 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+liblockfile (1.09-4.1) unstable; urgency=low
+
+  * Don't remove /usr/share/doc/liblockfile1 from the postrm anymore.
+Doing so breaks multarch, and it appears that the code was originally
+inserted to fix an upgrade problem (#339498) from 2005.
+(closes: #695268)
+
+ -- Rob Browning r...@defaultvalue.org  Sun, 09 Dec 2012 17:39:52 -0600
+
 liblockfile (1.09-4) unstable; urgency=low
 
   * Multiarch issues
diff --git a/debian/postrm b/debian/postrm
index 4d9d0ef..8c9df31 100644
--- a/debian/postrm
+++ b/debian/postrm
@@ -5,10 +5,5 @@ set -e
 if [ $1 = remove ]
 then
 ldconfig
-
-if [ -d /usr/share/doc/liblockfile1 ]
-then
-rm -fr /usr/share/doc/liblockfile1
-fi
 fi
 	

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4


Bug#695268: liblockfile1: harmful remove action in M-A:same package

2012-12-07 Thread Dominik George
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Hi,

I looked at the package and am baffled by the postinst and postrm scripts. 
They are (should be?) entirely useless (manually calling ldconfig ??).

I then brought up debian/rules and immediately saw what the reason for 
that method is: Complete ignorance of debhelper or anything else allowing 
anyone but the maintainer to cope with the packaging work in a reasonable 
way.

I am reporting this issue as a wishlist bug because I think maintainers 
should try to not make life for other contributors harder than necessary. 
And re-working the paackge with proper debhelper code would certainly also 
fix this issue.

- -nik

- -- 
* mirabilos is handling my post-1990 smartphone *
mirabilos Aaah, it vibrates! Wherefor art thou, daemonic device??

PGP fingerprint: 2086 9A4B E67D 1DCD FFF6  F6C1 59FC 8E1D 6F2A 8001
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.19 (GNU/Linux)

iQFOBAEBCAA4BQJQwg/NMRpodHRwczovL3d3dy5kb21pbmlrLWdlb3JnZS5kZS9n
cGctcG9saWN5LnR4dC5hc2MACgkQWfyOHW8qgAGEGwf+PIBFHWu49w2O/kdyCXn+
egsiTvLcjt6irn9nYyKHwdMjZdmBgndzSSqCcynpoc3iWjmmZBE9GR7aFoSezUHE
etaqHLjdqy5PM6BB1Nu+mjj0yBni72Pszb3lN5+Rly4ptpr8H9SrNMwM+VzbbHMv
xkkQ4rjNwgZRmlB1vDfMFH2/lKMD2moLLAIGZAxnSWWUEhz+ROAz7xdKbyp2Rdy3
nqfGIBdOOaxzCKdfTfYtCoh6IsMtEVhA778kN+54k4/DzVfWju1ACiUkdp7vApn0
dWrCOZQC4ixiXe2HpTmoIOdvg/eUfIzGLPcjaVll+mhbbDTaEVi4Gf3xWL9KlsFH
Vg==
=KkjQ
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#695268: liblockfile1: harmful remove action in M-A:same package

2012-12-06 Thread Helmut Grohne
Package: liblockfile1
Version: 1.09-4
Severity: serious

Steps taken:

Install liblockfile1:amd64. Observe that it ships
/usr/share/doc/liblockfile1. Install liblockfile1:i386. Observe that
/usr/share/doc/liblockfile1 is still correctly there. Remove
liblockfile1:i386, but not liblockfile1:amd64. Now The doc dir is gone.
This is due to the postinst shipped by liblockfile1.

I do not understand why liblockfile1 removes /usr/share/doc/liblockfile1
during postrm remove as I would expect it to be removed by dpkg if
necessary.

Helmut


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org