Bug#457501: lintian: quilt needed in clean target

2008-01-02 Thread Russ Allbery
Bernd Zeimetz [EMAIL PROTECTED] writes:

 lintian already will allow (and even require) quilt to be in
 Build-Depends because of this.  This looks like a specific problem with
 lintian's understanding of this package, but cython doesn't appear to
 be in the archive, so I can't check what's going on with it.

 It just went trough new
 ftp://ftp.de.debian.org/debian/pool/main/c/cython/

I finally had a chance to look at this, and the problem was that Lintian
didn't correctly handle double-colon rules.  (It thought the rule was
clean: instead of clean and hence didn't notice that quilt was called
from clean.)  This will be fixed in the next version.

-- 
Russ Allbery ([EMAIL PROTECTED])   http://www.eyrie.org/~eagle/



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#457501: lintian: quilt needed in clean target

2007-12-22 Thread Bernd Zeimetz
Package: lintian
Version: 1.23.41
Severity: minor

As quilt is used to deapply patches in the clean target usually, lintian
should not suggest to move it to build-deps-indep while building an
arch:all package.

Just one random example:
I: cython source: build-depends-without-arch-dep quilt


Thanks,

Bernd



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#457501: lintian: quilt needed in clean target

2007-12-22 Thread Russ Allbery
Bernd Zeimetz [EMAIL PROTECTED] writes:

 Package: lintian
 Version: 1.23.41
 Severity: minor

 As quilt is used to deapply patches in the clean target usually, lintian
 should not suggest to move it to build-deps-indep while building an
 arch:all package.

 Just one random example:
 I: cython source: build-depends-without-arch-dep quilt

lintian already will allow (and even require) quilt to be in Build-Depends
because of this.  This looks like a specific problem with lintian's
understanding of this package, but cython doesn't appear to be in the
archive, so I can't check what's going on with it.

How is the debian/rules file written?  lintian looks for both the include
of the quilt makefile fragment and for calling quilt explicitly during the
clean target.

If you have any specific packages that have this problem that I can look
at, that would be greatly appreciated.  lintian should already be handling
this correctly and there isn't any general fix that I know how to apply
without more details.

-- 
Russ Allbery ([EMAIL PROTECTED])   http://www.eyrie.org/~eagle/



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#457501: lintian: quilt needed in clean target

2007-12-22 Thread Bernd Zeimetz

 Just one random example:
 I: cython source: build-depends-without-arch-dep quilt
 
 lintian already will allow (and even require) quilt to be in Build-Depends
 because of this.  This looks like a specific problem with lintian's
 understanding of this package, but cython doesn't appear to be in the
 archive, so I can't check what's going on with it.

It just went trough new
ftp://ftp.de.debian.org/debian/pool/main/c/cython/

 How is the debian/rules file written?  lintian looks for both the include
 of the quilt makefile fragment and for calling quilt explicitly during the
 clean target.

I think the problem is that debian/rules is written using cdbs and does
not use /usr/share/cdbs/1/rules/patchsys-quilt.mk, but handles the quilt
manually instead. I'll ask the maintainer if he really needs to do that
for some reason, or if using patchsys-quilt.mk instead would be fine for
him. So I'm not really sure if this bugreport was unnecessary noise, or
if lintian should indeed not complain here.
Probably it would make sense to check the clean: and clean:: targets in
debian/rules


-- 
Bernd Zeimetz
[EMAIL PROTECTED] http://bzed.de/



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]