Re: Small 'default' patch for lh_config
On Monday 09 June 2008, 07:08:14, Daniel Baumann wrote: http://git.debian.org/?p=users/mammadori-guest/live-helper.git;a=summary can you please write changelog entries that are true? Little aggressive? such as.. Replacing whitespaces with tabs. for 60c755e5089a8ac0c425f1f345ed39984eb4037b I just deleted 1 space int that commit, so the changelog is true, sorry. -- ESC:wq -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Re: Small 'default' patch for lh_config
On Monday 09 June 2008, 07:17:07, Daniel Baumann wrote:
and for b6928b6d6400f5fd17ec8d300cdbc254ed5b0f8b, i think that those
values variables/options are *always* used. even if a --conffile is
specified. live-helper shouldn't weight it, it never does it anywhere else.
Done.
Echo_warning Using these defaults from ${DEFAULT_LH_CONFFILE}:
should be
Echo_verbose Using system defaults from ${DEFAULT_LH_CONFFILE}: [...]
Done all, although Echo_verbose could be user disabled and from the paste bin
visible request it seemed to me Echo_warning to be the best fit.
git pushed.
--
ESC:wq
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
___
debian-live-devel mailing list
debian-live-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Re: Small 'default' patch for lh_config
Marco Amadori wrote: git pushed. both merged, thanks. -- Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist Email: [EMAIL PROTECTED] Internet: http://people.panthera-systems.net/~daniel-baumann/ ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Re: Small 'default' patch for lh_config
Daniel Baumann wrote: and for b6928b6d6400f5fd17ec8d300cdbc254ed5b0f8b, i think that those values variables/options are *always* used. even if a --conffile is specified. to avoid missunderstandings: s/are always/should always/ -- Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist Email: [EMAIL PROTECTED] Internet: http://people.panthera-systems.net/~daniel-baumann/ ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Re: Small 'default' patch for lh_config
On Monday 09 June 2008, 09:02:25, Daniel Baumann wrote: Marco Amadori wrote: git pushed. both merged, thanks. Your are welcome. Could you merge also live-snapshot ones? -- ESC:wq -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Re: Small 'default' patch for lh_config
Marco Amadori [EMAIL PROTECTED] writes: Ok, I meant that YOU always complained about trailing, leading and tab-mixed spaces in my patches and code, (a thing which I agree since I was using vim without the proper space highlighting). Other than that you always fixed those unecessaries spaces before applying my patches and code, which I'm fine with too. You're right in cleaning up the Daniel mess but do it in another commit please ;-) /me hides! -- O T A V I OS A L V A D O R - E-mail: [EMAIL PROTECTED] UIN: 5906116 GNU/Linux User: 239058 GPG ID: 49A5F855 Home Page: http://otavio.ossystems.com.br - Microsoft sells you Windows ... Linux gives you the whole house. ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Re: Small 'default' patch for lh_config
Marco Amadori wrote: Someone told me in the past to remove useless spaces and always removed them all from my patches and code, he must be someone you don't know personally I think. seriously, i don't understand that sentence. Anyway, I'll rework it with your and Lamby's hints then I'll ping again. thanks. -- Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist Email: [EMAIL PROTECTED] Internet: http://people.panthera-systems.net/~daniel-baumann/ ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Re: Small 'default' patch for lh_config
Chris Lamb wrote:
The only problem I see with it is that it makes it impossible to see 100% of
a users build settings from the output of lh_config lh_build alone such
as the pastebins pasted to the #debian-live IRC channel. If lh_build could
be tricked into saying Using settings from ${FOO} or somesuch, I'm sure
this would preemptively save someone some debugging time.
ack.
Oh, also: isn't /etc/default/foo reserved for the foo daemon?
no; but it should be /etc/default/live-helper
--
Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email: [EMAIL PROTECTED]
Internet: http://people.panthera-systems.net/~daniel-baumann/
___
debian-live-devel mailing list
debian-live-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Re: Small 'default' patch for lh_config
Marco Amadori wrote: For an easy review: http://git.debian.org/?p=users/mammadori-guest/live-helper.git;a=commitdiff;h=cd4a6142f4bb84b57a6cba7ddb9b505e56dbe81a please always watch your diffs to not include other (probably useless) changes; such as - Version + Version -- Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist Email: [EMAIL PROTECTED] Internet: http://people.panthera-systems.net/~daniel-baumann/ ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Small 'default' patch for lh_config
Hi, I found that patch useful, it provides a system wide location for lh_config values, I use it for 2 or 3 vars. For an easy review: http://git.debian.org/?p=users/mammadori-guest/live-helper.git;a=commitdiff;h=cd4a6142f4bb84b57a6cba7ddb9b505e56dbe81a For mergeing: git add remote marco git://git.debian.org/git/users/mammadori-guest/live-helper -- ESC:wq signature.asc Description: This is a digitally signed message part. ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
