Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian@packages.debian.org
Usertags: pu
X-Debbugs-Cc: engra...@packages.debian.org
Control: affects -1 + src:engrampa
[ Reason ]
While upload a new upstream version of engrampa, a bookworm-pu has been
prepared that fixes various memleaks and resolves a bug in the archive
"save as" action.
[ Impact ]
Engrampa will still have memleaks + the save as dialog will still be
broken.
[ Tests ]
Manually. A new dialog box has been added by upstream. This will
only be presented to the users in English (as the translations
have not been cherry-picked into this package).
[ Risks ]
Regressions might occur, affecting engrampa and in general MATE desktop
users.
[ Checklist ]
[x] *all* changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in (old)stable
[x] the issue is verified as fixed in unstable
[ Changes ]
+ * debian/patches:
++ Cherry-pick various memleak fixes from upstream:
+ 0001_dlg-package-installer-fix-memory-leak.patch,
+ 0002_fr-window-fix-memory-leak.patch,
+ 0003_file-data-fix-memory-leak.patch, and
+ 0005_fr-process-fix-memory-leak.patch.
++ Add 0004_Fix-archive-file-save-as-function.patch. Fix archive 'save as'
+ function. (Closes: #969761).
[ Other info ]
None.
diff -Nru engrampa-1.26.0/debian/changelog engrampa-1.26.0/debian/changelog
--- engrampa-1.26.0/debian/changelog2021-12-12 16:00:52.0 +0100
+++ engrampa-1.26.0/debian/changelog2023-12-29 08:13:22.0 +0100
@@ -1,3 +1,16 @@
+engrampa (1.26.0-1+deb12u1) bookworm; urgency=medium
+
+ * debian/patches:
++ Cherry-pick various memleak fixes from upstream:
+ 0001_dlg-package-installer-fix-memory-leak.patch,
+ 0002_fr-window-fix-memory-leak.patch,
+ 0003_file-data-fix-memory-leak.patch, and
+ 0005_fr-process-fix-memory-leak.patch.
++ Add 0004_Fix-archive-file-save-as-function.patch. Fix archive 'save as'
+ function. (Closes: #969761).
+
+ -- Mike Gabriel Fri, 29 Dec 2023 08:13:22 +0100
+
engrampa (1.26.0-1) unstable; urgency=medium
[ Martin Wimpress ]
diff -Nru
engrampa-1.26.0/debian/patches/0001_dlg-package-installer-fix-memory-leak.patch
engrampa-1.26.0/debian/patches/0001_dlg-package-installer-fix-memory-leak.patch
---
engrampa-1.26.0/debian/patches/0001_dlg-package-installer-fix-memory-leak.patch
1970-01-01 01:00:00.0 +0100
+++
engrampa-1.26.0/debian/patches/0001_dlg-package-installer-fix-memory-leak.patch
2023-12-29 08:03:51.0 +0100
@@ -0,0 +1,38 @@
+From da64dd31f77a8082650d0904da19a21dfc400ae1 Mon Sep 17 00:00:00 2001
+From: rbuj
+Date: Thu, 21 Oct 2021 20:12:17 +0200
+Subject: [PATCH 1/5] dlg-package-installer: fix memory leak
+
+Signed-off-by: Mike Gabriel
+---
+ src/dlg-package-installer.c | 5 -
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/src/dlg-package-installer.c b/src/dlg-package-installer.c
+index 0b18441..3cda168 100644
+--- a/src/dlg-package-installer.c
b/src/dlg-package-installer.c
+@@ -305,9 +305,11 @@ dlg_package_installer (FrWindow *window,
+ {
+ char *secondary_text;
+ GtkWidget *dialog;
++ char *description;
+
++ description = g_content_type_get_description
(idata->archive->content_type);
+ secondary_text = g_strdup_printf (_("There is no command
installed for %s files.\nDo you want to search for a command to open this
file?"),
+-
g_content_type_get_description (idata->archive->content_type));
++description);
+ dialog = _gtk_message_dialog_new (GTK_WINDOW (idata->window),
+ GTK_DIALOG_MODAL,
+ "dialog-error",
+@@ -328,6 +330,7 @@ dlg_package_installer (FrWindow *window,
+ g_signal_connect (dialog, "response", G_CALLBACK
(confirm_search_dialog_response_cb), idata);
+ gtk_widget_show (dialog);
+
++ g_free (description);
+ g_free (secondary_text);
+ }
+
+--
+2.39.2
+
diff -Nru engrampa-1.26.0/debian/patches/0002_fr-window-fix-memory-leak.patch
engrampa-1.26.0/debian/patches/0002_fr-window-fix-memory-leak.patch
--- engrampa-1.26.0/debian/patches/0002_fr-window-fix-memory-leak.patch
1970-01-01 01:00:00.0 +0100
+++ engrampa-1.26.0/debian/patches/0002_fr-window-fix-memory-leak.patch
2023-12-29 08:03:51.0 +0100
@@ -0,0 +1,81 @@
+From c0fadd464f227e7ebbfefd3fa54e578f1bb9998b Mon Sep 17 00:00:00 2001
+From: rbuj
+Date: Thu, 21 Oct 2021 21:34:05 +0200
+Subject: [PATCH 2/5] fr-window: fix memory leak
+
+Signed-off-by: Mike Gabriel
+---
+ src/fr-window.c | 13 ++---
+ 1 file changed, 10 insertions(+), 3 deletions(-)
+
+diff --git
