[Desktop-packages] [Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs
Thanks! I've just installed it on one of my Xenial servers for testing... I'll let you know how it goes... Cheers! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to cups in Ubuntu. https://bugs.launchpad.net/bugs/1747765 Title: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs Status in cups package in Ubuntu: Fix Released Status in cups source package in Xenial: Fix Released Status in cups source package in Bionic: Fix Released Status in cups source package in Cosmic: Fix Released Status in cups source package in Disco: Fix Released Bug description: [Impact] The documentation allows the following types of arguments for the PreserveJobHistory parameter: PreserveJobHistory Yes PreserveJobHistory No PreserveJobHistory seconds The value in seconds is treated in the same as 'No' resulting in immediate removing of jobs from history, while it is supposed to save it for . [Test Case] 1. Set PreserveJobHistory to 30. Set LogLevel to debug. 2. Schedule a job for printing. 3. Check the error_log. 4. Set PreserveJobHistory to No. Repeat 2-3. 5. Set PreserveJobHistory to Yes. Repeat 2-3. Expected result (for PreserveJobHistory values): 30: Job is save for at least 30 seconds. No: Job is removed right after processing. Yes: Job is never removed. Actual results (for PreserveJobHistory values): 30: Job is immediately removed from history. No: Job is removed right after processing. Yes: Job is never removed. [Regression Potential] * With the fix the jobs will be saved longer than before, so in tight conditions (low disk space) and heavy workload it may affect memory/disk space consumption and lead to running out of free space in worst case. [Other Info] * Original bug description: 1) Ubuntu Release Description: Ubuntu 16.04.3 LTS Release: 16.04 2) Version of the package cups: Installed: 2.1.3-4ubuntu0.3 Candidate: 2.1.3-4ubuntu0.3 Version table: *** 2.1.3-4ubuntu0.3 500 500 http://us.archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages 3) What I expected to happen: from man cupsd.conf PreserveJobFiles Yes PreserveJobFiles No PreserveJobFiles seconds Specifies whether job files (documents) are preserved after a job is printed. If a numeric value is specified, job files are preserved for the indicated number of seconds after printing. The default is "86400" (preserve 1 day). PreserveJobHistory Yes PreserveJobHistory No PreserveJobHistory seconds Specifies whether the job history is preserved after a job is printed. If a numeric value is specified, the job history is preserved for the indicated number of seconds after printing. If "Yes", the job history is preserved until the MaxJobs limit is reached. The default is "Yes". 4) What happens instead If I put the following directives in cupsd.conf the job files and history are deleted immediately. PreserveJobFiles 604800 PreserveJobHistory 604800 Debug log showing history being purged: d [06/Feb/2018:15:11:59 -0600] cupsdCheckJobs: 0 active jobs, sleeping=0, ac-power=-1, reload=0, curtime=1517951519 d [06/Feb/2018:15:11:59 -0600] cupsdCleanJobs: MaxJobs=100, JobHistory=604800, JobFiles=604800 D [06/Feb/2018:15:11:59 -0600] [Job 106] Removing from history. D [06/Feb/2018:15:11:59 -0600] [Job 106] Unloading... To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
Re: [Desktop-packages] [Bug 1701333] Re: building cups without systemd results in error due to 'IdleExitTimeout' undeclared
The patch I provided for this last year fixed the problem for me - Original Message - > From: "gf" <1701...@bugs.launchpad.net> > To: "Bo Kersey" > Sent: Thursday, August 30, 2018 3:31:17 PM > Subject: [Bug 1701333] Re: building cups without systemd results in error due > to 'IdleExitTimeout' undeclared > Hello Bo, > Thank you for submitting this bug and reporting a problem with cups. You made > this bug report some time ago and Ubuntu has been updated since then. > > Could you confirm that this is no longer a problem and that we can close the > ticket? > If it is still a problem, are you still interested in finding a solution to > this > bug? > If you are, could you let us know, and in the current version, run the > following > (only once): > apport-collect BUGNUMBER > and upload the updated logs and and any other logs that are relevant for this > particular issue. > > Thank you again for helping make Ubuntu better. > G > [Ubuntu Bug Squad volunteer triager] > > ** Changed in: cups (Ubuntu) > Status: New => Incomplete > > -- > You received this bug notification because you are subscribed to the bug > report. > https://bugs.launchpad.net/bugs/1701333 > > Title: > building cups without systemd results in error due to > 'IdleExitTimeout' undeclared > > To manage notifications about this bug go to: > https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1701333/+subscriptions -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to cups in Ubuntu. https://bugs.launchpad.net/bugs/1701333 Title: building cups without systemd results in error due to 'IdleExitTimeout' undeclared Status in cups package in Ubuntu: Incomplete Bug description: I'm backporting cups-2.1.3 to trusty and I found an ubuntu patch that lets cups stop on 30 seconds idle time if it was started on demand by upstart (ubuntu-cupsd-idleexittimeout-upstart.patch) All other uses of IdleExitTimeout are enclosed in an a conditional so that the code is masked if not build with launchd or systemd. However, this one is not This results in the following build error: cc -Wall -Wno-format-y2k -Wunused -fPIC -g -fstack-protector -Wno-unused-result -Wsign-conversion -Wno-tautological-compare -D_GNU_SOURCE -I.. -D_CUPS_SOURCE -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -I/usr/include/libusb-1.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -DDBUS_API_SUBJECT_TO_CHANGE -D_REENTRANT -I/usr/include/p11-kit-1 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_THREAD_SAFE -D_REENTRANT -c -o main.o main.c main.c: In function 'upstart_checkin': main.c:1708:8: error: 'IdleExitTimeout' undeclared (first use in this function) if (!IdleExitTimeout) ^ main.c:1708:8: note: each undeclared identifier is reported only once for each function it appears in I have added that conditional the the offending patch and I have attached it to this bug Thanks! To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1701333/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1747765] [NEW] PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs
Public bug reported: 1) Ubuntu Release Description:Ubuntu 16.04.3 LTS Release:16.04 2) Version of the package cups: Installed: 2.1.3-4ubuntu0.3 Candidate: 2.1.3-4ubuntu0.3 Version table: *** 2.1.3-4ubuntu0.3 500 500 http://us.archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages 3) What I expected to happen: from man cupsd.conf PreserveJobFiles Yes PreserveJobFiles No PreserveJobFiles seconds Specifies whether job files (documents) are preserved after a job is printed. If a numeric value is specified, job files are preserved for the indicated number of seconds after printing. The default is "86400" (preserve 1 day). PreserveJobHistory Yes PreserveJobHistory No PreserveJobHistory seconds Specifies whether the job history is preserved after a job is printed. If a numeric value is specified, the job history is preserved for the indicated number of seconds after printing. If "Yes", the job history is preserved until the MaxJobs limit is reached. The default is "Yes". 4) What happens instead If I put the following directives in cupsd.conf the job files and history are deleted immediately. PreserveJobFiles 604800 PreserveJobHistory 604800 Debug log showing history being purged: d [06/Feb/2018:15:11:59 -0600] cupsdCheckJobs: 0 active jobs, sleeping=0, ac-power=-1, reload=0, curtime=1517951519 d [06/Feb/2018:15:11:59 -0600] cupsdCleanJobs: MaxJobs=100, JobHistory=604800, JobFiles=604800 D [06/Feb/2018:15:11:59 -0600] [Job 106] Removing from history. D [06/Feb/2018:15:11:59 -0600] [Job 106] Unloading... ** Affects: cups (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to cups in Ubuntu. https://bugs.launchpad.net/bugs/1747765 Title: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs Status in cups package in Ubuntu: New Bug description: 1) Ubuntu Release Description: Ubuntu 16.04.3 LTS Release: 16.04 2) Version of the package cups: Installed: 2.1.3-4ubuntu0.3 Candidate: 2.1.3-4ubuntu0.3 Version table: *** 2.1.3-4ubuntu0.3 500 500 http://us.archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages 3) What I expected to happen: from man cupsd.conf PreserveJobFiles Yes PreserveJobFiles No PreserveJobFiles seconds Specifies whether job files (documents) are preserved after a job is printed. If a numeric value is specified, job files are preserved for the indicated number of seconds after printing. The default is "86400" (preserve 1 day). PreserveJobHistory Yes PreserveJobHistory No PreserveJobHistory seconds Specifies whether the job history is preserved after a job is printed. If a numeric value is specified, the job history is preserved for the indicated number of seconds after printing. If "Yes", the job history is preserved until the MaxJobs limit is reached. The default is "Yes". 4) What happens instead If I put the following directives in cupsd.conf the job files and history are deleted immediately. PreserveJobFiles 604800 PreserveJobHistory 604800 Debug log showing history being purged: d [06/Feb/2018:15:11:59 -0600] cupsdCheckJobs: 0 active jobs, sleeping=0, ac-power=-1, reload=0, curtime=1517951519 d [06/Feb/2018:15:11:59 -0600] cupsdCleanJobs: MaxJobs=100, JobHistory=604800, JobFiles=604800 D [06/Feb/2018:15:11:59 -0600] [Job 106] Removing from history. D [06/Feb/2018:15:11:59 -0600] [Job 106] Unloading... To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1701333] [NEW] building cups without systemd results in error due to 'IdleExitTimeout' undeclared
Public bug reported: I'm backporting cups-2.1.3 to trusty and I found an ubuntu patch that lets cups stop on 30 seconds idle time if it was started on demand by upstart (ubuntu-cupsd-idleexittimeout-upstart.patch) All other uses of IdleExitTimeout are enclosed in an a conditional so that the code is masked if not build with launchd or systemd. However, this one is not This results in the following build error: cc -Wall -Wno-format-y2k -Wunused -fPIC -g -fstack-protector -Wno-unused-result -Wsign-conversion -Wno-tautological-compare -D_GNU_SOURCE -I.. -D_CUPS_SOURCE -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -I/usr/include/libusb-1.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -DDBUS_API_SUBJECT_TO_CHANGE -D_REENTRANT -I/usr/include/p11-kit-1 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_THREAD_SAFE -D_REENTRANT -c -o main.o main.c main.c: In function 'upstart_checkin': main.c:1708:8: error: 'IdleExitTimeout' undeclared (first use in this function) if (!IdleExitTimeout) ^ main.c:1708:8: note: each undeclared identifier is reported only once for each function it appears in I have added that conditional the the offending patch and I have attached it to this bug Thanks! ** Affects: cups (Ubuntu) Importance: Undecided Status: New ** Tags: backport ** Attachment added: "updated file debian/patches/ubuntu/ubuntu-cupsd-idleexittimeout-upstart.patch" https://bugs.launchpad.net/bugs/1701333/+attachment/4905877/+files/ubuntu-cupsd-idleexittimeout-upstart.patch -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to cups in Ubuntu. https://bugs.launchpad.net/bugs/1701333 Title: building cups without systemd results in error due to 'IdleExitTimeout' undeclared Status in cups package in Ubuntu: New Bug description: I'm backporting cups-2.1.3 to trusty and I found an ubuntu patch that lets cups stop on 30 seconds idle time if it was started on demand by upstart (ubuntu-cupsd-idleexittimeout-upstart.patch) All other uses of IdleExitTimeout are enclosed in an a conditional so that the code is masked if not build with launchd or systemd. However, this one is not This results in the following build error: cc -Wall -Wno-format-y2k -Wunused -fPIC -g -fstack-protector -Wno-unused-result -Wsign-conversion -Wno-tautological-compare -D_GNU_SOURCE -I.. -D_CUPS_SOURCE -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -I/usr/include/libusb-1.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -DDBUS_API_SUBJECT_TO_CHANGE -D_REENTRANT -I/usr/include/p11-kit-1 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_THREAD_SAFE -D_REENTRANT -c -o main.o main.c main.c: In function 'upstart_checkin': main.c:1708:8: error: 'IdleExitTimeout' undeclared (first use in this function) if (!IdleExitTimeout) ^ main.c:1708:8: note: each undeclared identifier is reported only once for each function it appears in I have added that conditional the the offending patch and I have attached it to this bug Thanks! To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1701333/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
